GNU bug report logs - #67866
[PATCH] daemon: Change default ‘timeout’ and ‘max-silent-time’ values.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#67866: closed ([PATCH] daemon: Change default ‘timeout’
 and ‘max-silent-time’ values.)
Date: Mon, 08 Jan 2024 11:23:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 08 Jan 2024 12:22:03 +0100
with message-id <87jzok6pes.fsf <at> gnu.org>
and subject line Re: [bug#67866] [PATCH] daemon: Change default ‘timeout’ and ‘max-silent-time’ values.
has caused the debbugs.gnu.org bug report #67866,
regarding [PATCH] daemon: Change default ‘timeout’ and ‘max-silent-time’ values.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
67866: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67866
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: [PATCH] daemon: Change default ‘timeout’ and ‘max-silent-time’ values.
Date: Sun, 17 Dec 2023 15:35:24 +0100

Having a timeout seems generally preferable as it makes sure build slots
are not kept busy for no good reason (few package builds, if any, are
expected to exceed these values).

* nix/libstore/globals.cc (Settings::Settings): Change ‘maxSilentTime’
and ‘buildTimeout’.
* gnu/services/base.scm (<guix-configuration>)[max-silent-time]
[timeout]: Change default values.
* doc/guix.texi (Invoking guix-daemon, Base Services): Adjust
accordingly.

Change-Id: I25c50893f3f7fcca451b8f093d9d4d1a15fa58d8
---
 doc/guix.texi           | 8 ++++----
 gnu/services/base.scm   | 4 ++--
 nix/libstore/globals.cc | 4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)

Hi!

I was pretty sure these were the default values already and was shocked to
discover that this was not the case.

Thoughts?  Objections?

Ludo'.

diff --git a/doc/guix.texi b/doc/guix.texi
index e61a893af9..5f44a78f90 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -1799,7 +1799,7 @@ Invoking guix-daemon
 When the build or substitution process remains silent for more than
 @var{seconds}, terminate it and report a build failure.
 
-The default value is @code{0}, which disables the timeout.
+The default value is @code{3600} (one hour).
 
 The value specified here can be overridden by clients (@pxref{Common
 Build Options, @option{--max-silent-time}}).
@@ -1808,7 +1808,7 @@ Invoking guix-daemon
 Likewise, when the build or substitution process lasts for more than
 @var{seconds}, terminate it and report a build failure.
 
-The default value is @code{0}, which disables the timeout.
+The default value is 24 hours.
 
 The value specified here can be overridden by clients (@pxref{Common
 Build Options, @option{--timeout}}).
@@ -19384,8 +19384,8 @@ Base Services
 might want to turn it off for instance in a virtual machine that does
 not need it and where the extra boot time is a problem.
 
-@item @code{max-silent-time} (default: @code{0})
-@itemx @code{timeout} (default: @code{0})
+@item @code{max-silent-time} (default: @code{3600})
+@itemx @code{timeout} (default: @code{(* 3600 24)})
 The number of seconds of silence and the number of seconds of activity,
 respectively, after which a build process times out.  A value of zero
 disables the timeout.
diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 6539bfd6ce..60388a22dd 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -1798,9 +1798,9 @@ (define-record-type* <guix-configuration>
   (chroot-directories guix-configuration-chroot-directories ;list of file-like/strings
                       (default '()))
   (max-silent-time  guix-configuration-max-silent-time ;integer
-                    (default 0))
+                    (default 3600))
   (timeout          guix-configuration-timeout    ;integer
-                    (default 0))
+                    (default (* 3600 24)))
   (log-compression  guix-configuration-log-compression
                     (default 'gzip))
   (discover?        guix-configuration-discover?
diff --git a/nix/libstore/globals.cc b/nix/libstore/globals.cc
index d4f9a46a74..89add1f107 100644
--- a/nix/libstore/globals.cc
+++ b/nix/libstore/globals.cc
@@ -32,8 +32,8 @@ Settings::Settings()
     buildCores = 1;
     readOnlyMode = false;
     thisSystem = SYSTEM;
-    maxSilentTime = 0;
-    buildTimeout = 0;
+    maxSilentTime = 3600;
+    buildTimeout = 3600 * 24;
     useBuildHook = true;
     printBuildTrace = false;
     multiplexedBuildOutput = false;

base-commit: b681e339fa37f2a26763458ee56b31af1d6a7ec5
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>, Ricardo Wurmus <rekado <at> elephly.net>,
 67866-done <at> debbugs.gnu.org, Christopher Baines <guix <at> cbaines.net>
Subject: Re: [bug#67866] [PATCH] daemon: Change default ‘timeout’ and
 ‘max-silent-time’ values.
Date: Mon, 08 Jan 2024 12:22:03 +0100

Hi,

Simon Tournier <zimon.toutoune <at> gmail.com> skribis:

> On Sun, 17 Dec 2023 at 15:35, Ludovic Courtès <ludo <at> gnu.org> wrote:
>> Having a timeout seems generally preferable as it makes sure build slots
>> are not kept busy for no good reason (few package builds, if any, are
>> expected to exceed these values).
>>
>> * nix/libstore/globals.cc (Settings::Settings): Change ‘maxSilentTime’
>> and ‘buildTimeout’.
>> * gnu/services/base.scm (<guix-configuration>)[max-silent-time]
>> [timeout]: Change default values.
>> * doc/guix.texi (Invoking guix-daemon, Base Services): Adjust
>> accordingly.
>>
>> Change-Id: I25c50893f3f7fcca451b8f093d9d4d1a15fa58d8
>> ---
>>  doc/guix.texi           | 8 ++++----
>>  gnu/services/base.scm   | 4 ++--
>>  nix/libstore/globals.cc | 4 ++--
>>  3 files changed, 8 insertions(+), 8 deletions(-)
>
> LGTM although I have not tried the patch.

Pushed as d5724111ea2a8f5312b47fe9aae2bc74278c127e, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.