From unknown Fri Jun 20 18:21:29 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#67866 <67866@debbugs.gnu.org> To: bug#67866 <67866@debbugs.gnu.org> Subject: Status: [PATCH] daemon: Change default =?UTF-8?Q?=E2=80=98timeout=E2=80=99?= and =?UTF-8?Q?=E2=80=98max-silent-time=E2=80=99?= values. Reply-To: bug#67866 <67866@debbugs.gnu.org> Date: Sat, 21 Jun 2025 01:21:29 +0000 retitle 67866 [PATCH] daemon: Change default =E2=80=98timeout=E2=80=99 and = =E2=80=98max-silent-time=E2=80=99 values. reassign 67866 guix-patches submitter 67866 Ludovic Court=C3=A8s severity 67866 normal tag 67866 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 17 09:35:47 2023 Received: (at submit) by debbugs.gnu.org; 17 Dec 2023 14:35:47 +0000 Received: from localhost ([127.0.0.1]:56804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEsF8-00072V-H3 for submit@debbugs.gnu.org; Sun, 17 Dec 2023 09:35:47 -0500 Received: from lists.gnu.org ([2001:470:142::17]:46552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEsF6-00072A-VR for submit@debbugs.gnu.org; Sun, 17 Dec 2023 09:35:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEsEx-0004eF-Eh for guix-patches@gnu.org; Sun, 17 Dec 2023 09:35:36 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEsEw-0000MG-G3; Sun, 17 Dec 2023 09:35:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=becJM0gsHkKDXJN1mhbQdjx6MQw0upRuOL3iyIO9eH0=; b=iAZAgpKG4xfgTF wZJNZiw1Tq6GZmat9wR0NSqMRXYZruVNSL3FW12J19mocTT3ECjnTQo8hl28JnTStydZrEjgTY4kF 8n+ToYAAEFn6jXIBzek5QKGQiSXUe2sFHtNfzjzd3WUw+w1972aL6BIjCnB7UZ+CO82Fpn7asTYZV Vcmx20XU4fEwRCuwe0ExqLcmPdNlVg38eAfGKk42s+FjM8aeEyDvKDPVTkL54gRfKGkY1aqaE+EuE FzSGEtAyChQoMA2LnbHIY9+fVuQGQiS0z60vcrQ1xs2bORQh26uU0AzGexG28yDqD0teARgjtdXWv nHwOjJXJ6eQRIdqhmzQw==; From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH] =?UTF-8?q?daemon:=20Change=20default=20=E2=80=98timeout?= =?UTF-8?q?=E2=80=99=20and=20=E2=80=98max-silent-time=E2=80=99=20values.?= Date: Sun, 17 Dec 2023 15:35:24 +0100 Message-ID: <498d6405f0a2d792bb3af7d4e19ae19cf8780822.1702823602.git.ludo@gnu.org> X-Mailer: git-send-email 2.41.0 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Having a timeout seems generally preferable as it makes sure build slots are not kept busy for no good reason (few package builds, if any, are expected to exceed these values). * nix/libstore/globals.cc (Settings::Settings): Change ‘maxSilentTime’ and ‘buildTimeout’. * gnu/services/base.scm ()[max-silent-time] [timeout]: Change default values. * doc/guix.texi (Invoking guix-daemon, Base Services): Adjust accordingly. Change-Id: I25c50893f3f7fcca451b8f093d9d4d1a15fa58d8 --- doc/guix.texi | 8 ++++---- gnu/services/base.scm | 4 ++-- nix/libstore/globals.cc | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) Hi! I was pretty sure these were the default values already and was shocked to discover that this was not the case. Thoughts? Objections? Ludo'. diff --git a/doc/guix.texi b/doc/guix.texi index e61a893af9..5f44a78f90 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -1799,7 +1799,7 @@ Invoking guix-daemon When the build or substitution process remains silent for more than @var{seconds}, terminate it and report a build failure. -The default value is @code{0}, which disables the timeout. +The default value is @code{3600} (one hour). The value specified here can be overridden by clients (@pxref{Common Build Options, @option{--max-silent-time}}). @@ -1808,7 +1808,7 @@ Invoking guix-daemon Likewise, when the build or substitution process lasts for more than @var{seconds}, terminate it and report a build failure. -The default value is @code{0}, which disables the timeout. +The default value is 24 hours. The value specified here can be overridden by clients (@pxref{Common Build Options, @option{--timeout}}). @@ -19384,8 +19384,8 @@ Base Services might want to turn it off for instance in a virtual machine that does not need it and where the extra boot time is a problem. -@item @code{max-silent-time} (default: @code{0}) -@itemx @code{timeout} (default: @code{0}) +@item @code{max-silent-time} (default: @code{3600}) +@itemx @code{timeout} (default: @code{(* 3600 24)}) The number of seconds of silence and the number of seconds of activity, respectively, after which a build process times out. A value of zero disables the timeout. diff --git a/gnu/services/base.scm b/gnu/services/base.scm index 6539bfd6ce..60388a22dd 100644 --- a/gnu/services/base.scm +++ b/gnu/services/base.scm @@ -1798,9 +1798,9 @@ (define-record-type* (chroot-directories guix-configuration-chroot-directories ;list of file-like/strings (default '())) (max-silent-time guix-configuration-max-silent-time ;integer - (default 0)) + (default 3600)) (timeout guix-configuration-timeout ;integer - (default 0)) + (default (* 3600 24))) (log-compression guix-configuration-log-compression (default 'gzip)) (discover? guix-configuration-discover? diff --git a/nix/libstore/globals.cc b/nix/libstore/globals.cc index d4f9a46a74..89add1f107 100644 --- a/nix/libstore/globals.cc +++ b/nix/libstore/globals.cc @@ -32,8 +32,8 @@ Settings::Settings() buildCores = 1; readOnlyMode = false; thisSystem = SYSTEM; - maxSilentTime = 0; - buildTimeout = 0; + maxSilentTime = 3600; + buildTimeout = 3600 * 24; useBuildHook = true; printBuildTrace = false; multiplexedBuildOutput = false; base-commit: b681e339fa37f2a26763458ee56b31af1d6a7ec5 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 19 09:43:00 2023 Received: (at 67866) by debbugs.gnu.org; 19 Dec 2023 14:43:00 +0000 Received: from localhost ([127.0.0.1]:35150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFbJD-0002D5-M3 for submit@debbugs.gnu.org; Tue, 19 Dec 2023 09:43:00 -0500 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:40242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFbJ8-0002CU-BM for 67866@debbugs.gnu.org; Tue, 19 Dec 2023 09:42:54 -0500 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-50bcf41379bso1143515e87.1 for <67866@debbugs.gnu.org>; Tue, 19 Dec 2023 06:42:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702996966; x=1703601766; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=AXr0xyZSOzSAAOGuk/rtqmSArbe3yb6D56CEov+FJ+w=; b=h3b1lwCRwr8VTIBcuqnRs4ibF7OsjDw/a6FxS4PKQc6UvoTnEIEdZAMP7DFCCqB++i 87tYnIe3jSua2gj7aW5nivmNmp61Lpci4vemRXI5VRFSlx5aKL14c17rLGT/rzKDmnOa pmMrrwTDdkl/yTUfu05WQXmxQng+i2RhE2c++woUxpvT01OCKWnxwFMaWEtjUin/642k VQRx2p2zZH3dlitr8UQwmpoxK0w+Y75ZnngRqhawH8KAB5wD9LJgRYxixrOQ7zFvUi5Z OU0Toiqn8RSzKkh8C0KOcfrc9mLulaUtRLlMaVOXN3lOit4TdzW+hvBGJ0jrpFsTsj1y 8cYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702996966; x=1703601766; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AXr0xyZSOzSAAOGuk/rtqmSArbe3yb6D56CEov+FJ+w=; b=ryGnAEfZIgdQI+eznPcn6mQRx3qIfxNLNcUstAbYCKRQ2qktvjF1tRsLi/vs1LSfTF KDtGY4F8EA8BWFHtJWvxAV947I4OV2uSNOI8NZaKN6jwN1Fmu+hGAYMOJ/UNNA/HIZAY K51+VWEcLjRrLu/Qv2SRfAyV3H6EyHw5uNY/ecwkGTi7YYHTkq0mAaaL8vrhcWMwQwg6 yep3jwOOx/3BhzWnmNviE7921TibMHVAlgvmrV/8286+tJIUcY2yYDZbVGs/IT0iaQnK v3n0bU6IJAaV/p6Y8MA1+Q9wWdVwTnkxWSruMiuaXZXzKLvIzxpSBxpTmHGx03ynddbr Zivw== X-Gm-Message-State: AOJu0Yw5bevdRgggv17YBNnqn4k6YFu4O79o9wtzcdDyL7ZbG6pxtZkN shHhcRqafEqLH8z2yMWWUB4ZMoPhSZc= X-Google-Smtp-Source: AGHT+IFgCiPeWK7HyYbTZQBGwjMCIEKQ48cdsNtOINRpiKOV2xBLMwj1tAH9MPu6Mxk1TyYFGmxmKg== X-Received: by 2002:a05:6512:3e19:b0:50e:4e04:f92d with SMTP id i25-20020a0565123e1900b0050e4e04f92dmr356248lfv.6.1702996965706; Tue, 19 Dec 2023 06:42:45 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id u9-20020a05600c19c900b0040d18fdfe96sm3085866wmq.44.2023.12.19.06.42.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 06:42:45 -0800 (PST) From: Simon Tournier To: Ludovic =?utf-8?Q?Court=C3=A8s?= , 67866@debbugs.gnu.org Subject: Re: [bug#67866] [PATCH] daemon: Change default =?utf-8?B?4oCYdGlt?= =?utf-8?B?ZW91dOKAmQ==?= and =?utf-8?Q?=E2=80=98max-silent-time=E2=80=99?= values. In-Reply-To: <498d6405f0a2d792bb3af7d4e19ae19cf8780822.1702823602.git.ludo@gnu.org> References: <498d6405f0a2d792bb3af7d4e19ae19cf8780822.1702823602.git.ludo@gnu.org> Date: Tue, 19 Dec 2023 14:10:31 +0100 Message-ID: <87r0ji49tk.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67866 Cc: Josselin Poiret , Mathieu Othacehe , Ludovic =?utf-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Ricardo Wurmus , Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Sun, 17 Dec 2023 at 15:35, Ludovic Court=C3=A8s wrote: > Having a timeout seems generally preferable as it makes sure build slots > are not kept busy for no good reason (few package builds, if any, are > expected to exceed these values). > > * nix/libstore/globals.cc (Settings::Settings): Change =E2=80=98maxSilent= Time=E2=80=99 > and =E2=80=98buildTimeout=E2=80=99. > * gnu/services/base.scm ()[max-silent-time] > [timeout]: Change default values. > * doc/guix.texi (Invoking guix-daemon, Base Services): Adjust > accordingly. > > Change-Id: I25c50893f3f7fcca451b8f093d9d4d1a15fa58d8 > --- > doc/guix.texi | 8 ++++---- > gnu/services/base.scm | 4 ++-- > nix/libstore/globals.cc | 4 ++-- > 3 files changed, 8 insertions(+), 8 deletions(-) LGTM although I have not tried the patch. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 08 06:22:25 2024 Received: (at 67866-done) by debbugs.gnu.org; 8 Jan 2024 11:22:25 +0000 Received: from localhost ([127.0.0.1]:35339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rMni4-0004vN-UN for submit@debbugs.gnu.org; Mon, 08 Jan 2024 06:22:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rMni1-0004ux-VU for 67866-done@debbugs.gnu.org; Mon, 08 Jan 2024 06:22:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMnhp-0000lV-7G; Mon, 08 Jan 2024 06:22:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=eKK9Gu5eOnQVEKnPgmEIJsX3EpX81YXu8xz//7FsjF8=; b=fAeqtfkfPo4CAkqAgiOM YrTtjVK1tKgJfOWxgqgi3lKcRkwMQtLyrk6tmJfbKz8z80Ml/tiSh7zQ6rEhlawCfRHqmZfPZCIFZ ZRkZUeSiQdIa2pJlwuqBZeu02LbXmJ3k+RyqHb7NG8oh6DFZvIw/d7eqXtU4RFCv/N7+m2qXY/XeD F1JgGRnlTvpcdZiHqHEVLPuy6qPIKD28NOmTKs2HWrAV7CE32Icvg0FbjMnQOgQbbn+HBsEogHJbq MpuovgMOGJ0adaboNCs5xWkRts3GbgAGUtWFrjZXY3xi3ZJa/QA6fNZX3iT6BFItC4tU5WEcGD57W CrobOPnXh+nsTw==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Simon Tournier Subject: Re: [bug#67866] [PATCH] daemon: Change default =?utf-8?B?4oCYdGlt?= =?utf-8?B?ZW91dOKAmQ==?= and =?utf-8?Q?=E2=80=98max-silent-time=E2=80=99?= values. In-Reply-To: <87r0ji49tk.fsf@gmail.com> (Simon Tournier's message of "Tue, 19 Dec 2023 14:10:31 +0100") References: <498d6405f0a2d792bb3af7d4e19ae19cf8780822.1702823602.git.ludo@gnu.org> <87r0ji49tk.fsf@gmail.com> Date: Mon, 08 Jan 2024 12:22:03 +0100 Message-ID: <87jzok6pes.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67866-done Cc: Josselin Poiret , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 67866-done@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Simon Tournier skribis: > On Sun, 17 Dec 2023 at 15:35, Ludovic Court=C3=A8s wrote: >> Having a timeout seems generally preferable as it makes sure build slots >> are not kept busy for no good reason (few package builds, if any, are >> expected to exceed these values). >> >> * nix/libstore/globals.cc (Settings::Settings): Change =E2=80=98maxSilen= tTime=E2=80=99 >> and =E2=80=98buildTimeout=E2=80=99. >> * gnu/services/base.scm ()[max-silent-time] >> [timeout]: Change default values. >> * doc/guix.texi (Invoking guix-daemon, Base Services): Adjust >> accordingly. >> >> Change-Id: I25c50893f3f7fcca451b8f093d9d4d1a15fa58d8 >> --- >> doc/guix.texi | 8 ++++---- >> gnu/services/base.scm | 4 ++-- >> nix/libstore/globals.cc | 4 ++-- >> 3 files changed, 8 insertions(+), 8 deletions(-) > > LGTM although I have not tried the patch. Pushed as d5724111ea2a8f5312b47fe9aae2bc74278c127e, thanks! Ludo=E2=80=99. From unknown Fri Jun 20 18:21:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 05 Feb 2024 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator