GNU bug report logs - #67865
[PATCH] ange-ftp fails with tnftp client

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christophe Deleuze <christophe.deleuze <at> free.fr>
Subject: bug#67865: closed (Re: bug#67865: [PATCH] ange-ftp fails with
 tnftp client)
Date: Mon, 18 Dec 2023 10:17:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#67865: [PATCH] ange-ftp fails with tnftp client

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 67865 <at> debbugs.gnu.org.

-- 
67865: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67865
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: christophe.deleuze <at> free.fr, 67865-done <at> debbugs.gnu.org
Subject: Re: bug#67865: [PATCH] ange-ftp fails with tnftp client
Date: Mon, 18 Dec 2023 11:16:10 +0100

Version: 29.2

Eli Zaretskii <eliz <at> gnu.org> writes:

Hi,

>> > I suggest slightly changing the regexp used in string-match to allow
>> > for this colon, as shown below:
>> >
>> > (defun ange-ftp-passive-mode (proc on-or-off)
>> >   (if (string-match (concat "Passive mode:? " on-or-off)
>> >   [...]
>> >
>> > The attached patch does just that.
>>
>> Looks OK to me.
>>
>> Eli, do we want this in emacs-29 or master?
>
> It's okay to install this on emacs-29, thanks.

Done, closing the bug.

Best regards, Michael.

[Message part 3 (message/rfc822, inline)]

From: Christophe Deleuze <christophe.deleuze <at> free.fr>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] ange-ftp fails with tnftp client
Date: Sun, 17 Dec 2023 14:56:57 +0100

[Message part 4 (text/plain, inline)]

* bug description

When used with the tnftp client (https://en.wikipedia.org/wiki/Tnftp),
ange-ftp fails when trying to enable passive mode.

* fix description

Passive mode is enabled by function ange-ftp-passive-mode:

(defun ange-ftp-passive-mode (proc on-or-off)
  (if (string-match (concat "Passive mode " on-or-off)
                    (cdr (ange-ftp-raw-send-cmd
                          proc (concat "passive " on-or-off)
                          "Trying passive mode..." nil)))
      (ange-ftp-message (concat "Trying passive mode..." on-or-off))
    (error "Trying passive mode...failed")))

that expects to get a result string containing the string "Passive
mode on" (when on-or-off is "on"), however tnftp includes a colon in
its answer (extract from the buffer the ftp process is run in):

ftp> passive on
Passive mode: on; fallback to active mode: off.

I suggest slightly changing the regexp used in string-match to allow
for this colon, as shown below:

(defun ange-ftp-passive-mode (proc on-or-off)
  (if (string-match (concat "Passive mode:? " on-or-off)
  [...]
  
The attached patch does just that.

For information, in debian bookworm the ftp package has changed from
netkit-ftp to being a dummy transitional package for tnftp.

regards,

[0001-ange-ftp-fix-passive-mode-result-string-for-tntfp-cl.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.