From unknown Fri Jun 20 20:12:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67865: [PATCH] ange-ftp fails with tnftp client Resent-From: Christophe Deleuze Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Dec 2023 14:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 67865 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 67865@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17028219544252 (code B ref -1); Sun, 17 Dec 2023 14:06:01 +0000 Received: (at submit) by debbugs.gnu.org; 17 Dec 2023 14:05:54 +0000 Received: from localhost ([127.0.0.1]:56784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rErmD-00016W-VW for submit@debbugs.gnu.org; Sun, 17 Dec 2023 09:05:54 -0500 Received: from lists.gnu.org ([2001:470:142::17]:38698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rErmC-00016H-H4 for submit@debbugs.gnu.org; Sun, 17 Dec 2023 09:05:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rErm5-0007O5-7w for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 09:05:45 -0500 Received: from mx1.esisar.grenoble-inp.fr ([195.220.36.133]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rErm3-0006N4-2E for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 09:05:44 -0500 Received: from localhost (localhost [127.0.0.1]) by mx1.esisar.grenoble-inp.fr (Postfix) with ESMTP id 248EAEC0287 for ; Sun, 17 Dec 2023 15:05:38 +0100 (CET) Received: from mx1.esisar.grenoble-inp.fr ([127.0.0.1]) by localhost (mx1.esisar.grenoble-inp.fr [127.0.0.1]) (amavis, port 10032) with ESMTP id 0tWklqJU-eIG for ; Sun, 17 Dec 2023 15:05:37 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mx1.esisar.grenoble-inp.fr (Postfix) with ESMTP id AA496EC0290 for ; Sun, 17 Dec 2023 15:05:37 +0100 (CET) X-Virus-Scanned: amavis at mx1.esisar.grenoble-inp.fr Received: from mx1.esisar.grenoble-inp.fr ([127.0.0.1]) by localhost (mx1.esisar.grenoble-inp.fr [127.0.0.1]) (amavis, port 10026) with ESMTP id RzXyX04mOgpL for ; Sun, 17 Dec 2023 15:05:37 +0100 (CET) Received: from srv-zimbra.esisar.grenoble-inp.fr (unknown [172.21.100.139]) by mx1.esisar.grenoble-inp.fr (Postfix) with ESMTPS id 8CCD1EC0287 for ; Sun, 17 Dec 2023 15:05:37 +0100 (CET) Received: from srv-zimbra.esisar.grenoble-inp.fr (localhost [127.0.0.1]) by srv-zimbra.esisar.grenoble-inp.fr (Postfix) with ESMTPS id 719D06E0223 for ; Sun, 17 Dec 2023 14:05:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by srv-zimbra.esisar.grenoble-inp.fr (Postfix) with ESMTP id 5F8E56E0224 for ; Sun, 17 Dec 2023 14:05:37 +0000 (UTC) X-Virus-Scanned: amavis at srv-zimbra.esisar.grenoble-inp.fr Received: from srv-zimbra.esisar.grenoble-inp.fr ([127.0.0.1]) by localhost (srv-zimbra.esisar.grenoble-inp.fr [127.0.0.1]) (amavis, port 10026) with ESMTP id mrFKqx2GmGZv for ; Sun, 17 Dec 2023 14:05:37 +0000 (UTC) Received: from LC1758 (88-120-161-23.subs.proxad.net [88.120.161.23]) by srv-zimbra.esisar.grenoble-inp.fr (Postfix) with ESMTPSA id 20A246E0223 for ; Sun, 17 Dec 2023 14:05:37 +0000 (UTC) User-agent: mu4e 1.11.7; emacs 30.0.50 From: Christophe Deleuze Date: Sun, 17 Dec 2023 14:56:57 +0100 Message-ID: <878r5slyad.fsf@esisar.grenoble-inp.fr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: neutral client-ip=195.220.36.133; envelope-from=christophe.deleuze@free.fr; helo=mx1.esisar.grenoble-inp.fr X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779, SPOOFED_FREEMAIL=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.6 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) --=-=-= Content-Type: text/plain * bug description When used with the tnftp client (https://en.wikipedia.org/wiki/Tnftp), ange-ftp fails when trying to enable passive mode. * fix description Passive mode is enabled by function ange-ftp-passive-mode: (defun ange-ftp-passive-mode (proc on-or-off) (if (string-match (concat "Passive mode " on-or-off) (cdr (ange-ftp-raw-send-cmd proc (concat "passive " on-or-off) "Trying passive mode..." nil))) (ange-ftp-message (concat "Trying passive mode..." on-or-off)) (error "Trying passive mode...failed"))) that expects to get a result string containing the string "Passive mode on" (when on-or-off is "on"), however tnftp includes a colon in its answer (extract from the buffer the ftp process is run in): ftp> passive on Passive mode: on; fallback to active mode: off. I suggest slightly changing the regexp used in string-match to allow for this colon, as shown below: (defun ange-ftp-passive-mode (proc on-or-off) (if (string-match (concat "Passive mode:? " on-or-off) [...] The attached patch does just that. For information, in debian bookworm the ftp package has changed from netkit-ftp to being a dummy transitional package for tnftp. regards, --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-ange-ftp-fix-passive-mode-result-string-for-tntfp-cl.patch Content-Description: patch >From 1f41c0b474b7cc731aa4824902199c13bd15c895 Mon Sep 17 00:00:00 2001 From: Christophe Deleuze Date: Sun, 17 Dec 2023 14:49:27 +0100 Subject: [PATCH] ange-ftp: fix passive mode result string for tntfp client --- lisp/net/ange-ftp.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/net/ange-ftp.el b/lisp/net/ange-ftp.el index 4e4db34a78d..a1eb57baa20 100644 --- a/lisp/net/ange-ftp.el +++ b/lisp/net/ange-ftp.el @@ -2164,7 +2164,7 @@ ange-ftp-get-process proc))) (defun ange-ftp-passive-mode (proc on-or-off) - (if (string-match (concat "Passive mode " on-or-off) + (if (string-match (concat "Passive mode:? " on-or-off) (cdr (ange-ftp-raw-send-cmd proc (concat "passive " on-or-off) "Trying passive mode..." nil))) -- 2.39.2 --=-=-=-- From unknown Fri Jun 20 20:12:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67865: [PATCH] ange-ftp fails with tnftp client Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Dec 2023 18:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67865 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Christophe Deleuze Cc: 67865@debbugs.gnu.org Received: via spool by 67865-submit@debbugs.gnu.org id=B67865.170283873026489 (code B ref 67865); Sun, 17 Dec 2023 18:46:01 +0000 Received: (at 67865) by debbugs.gnu.org; 17 Dec 2023 18:45:30 +0000 Received: from localhost ([127.0.0.1]:59021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEw8o-0006sR-4t for submit@debbugs.gnu.org; Sun, 17 Dec 2023 13:45:30 -0500 Received: from mout.gmx.net ([212.227.15.15]:49159) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEw8l-0006Wz-5V for 67865@debbugs.gnu.org; Sun, 17 Dec 2023 13:45:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1702838719; x=1703443519; i=michael.albinus@gmx.de; bh=FrEOiJmOg7KDRJxpMZP5QADj0E/6UYjItsh+DmIuWtY=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=jqg778d4Y5ZDNdD4b8IcNNjVYWfNIyBARJ7R6oj5j4Q6NEQWXLr/NB3sRTt9O9IR xttGOhUkzSbr2SUrI5M4nV1aIVGggXdydbNX9JTWHbRKotFBT/0HaEsor9H6LhIfm vYYFyZZMjmgIoIJcztFs2p9ooXg5p4v3NqJPQ8fjqbFkToAAeNJCHBRpvMWZW9rWV K1D4d+uV+i+weBcR9PtcQGc0wGfTT9iLklT9fgt8DbnZ7kRQqNspYQ+K67PDD7kIh 7w3CA6GyT2CubCNmXGzJLxQq+q2oxT28TXGK8q8xw0ktzTBWIQBJMobs7BJh+U6ko sA1EOK1i8OB52ePgqA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.3]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MXp9i-1qgpoB0sRQ-00Y7Ow; Sun, 17 Dec 2023 19:45:19 +0100 From: Michael Albinus In-Reply-To: <878r5slyad.fsf@esisar.grenoble-inp.fr> (Christophe Deleuze's message of "Sun, 17 Dec 2023 14:56:57 +0100") References: <878r5slyad.fsf@esisar.grenoble-inp.fr> Date: Sun, 17 Dec 2023 19:45:18 +0100 Message-ID: <8734w0vfb5.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:juM3AmU+fIm9O496vt7/szQaL9Fla0aLDZDqRY54q5UvOzUP1zQ xA0HBhImRQRbl+eWUhnqj7HoiYVcO04E/lwvTfWADJkqsFaUUY02ORlOjZf8ODD9y9GUElY AtrqiY85pBgoc8HausW+kHe5aAzn+9Eg7dQ7LzhlUYyhrxdOR15RJqneBoYKQtQokPZON+J hZwM7hH2ZXK7gRbw3WNPw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:tcs2hH9bVkQ=;SRW4CDPnVOc/94R79sjs6IgBtKd pbzGW3yy69B9nPRm3g3XXTeLwhlJNMUiwf7uOiWmEYtqSUxul44dLJ1s82QjxPPxqSA0J0Y0b jHk+O+N0YxAyRS6869aDEaWLkREOZMSl5Dvl7nmKAb95tGB7NtP98SE33cAdj3d9FKhZBB+yU bgNnDtqvhyDP5oNP6zmREeRsAcnQohetnRQsWYDjEo0pxjaS65g3rI573dQkJl65QegOxfM/Q gURjwrnjI/zmWCAnx//jbNlFvmjU4RegJd+45pBCMLhC93kO7P0ceGkO3/CS7MZmQqSpr/HH5 fRz1Xe+P8OqKbfPu74+Q1SGOm68d8OaXfkfx/Zj88se3S93jHAdaGgZZ2aossBKBYFBAkGN4P /8ANh95iN+BZFwWvkDUT12yNaU1HRaXIwoWTkiknl/RByUG8pzaeRn025PTfObKMW2E8LdXsA zRHv3BButXDln1jltEwKMZyyuY3lW60oejjjFzZIcCLI+gMi1hakyFd/7dKxdfIKNQ5jXA/Py wiXvgvq8v379rPGL0iCujAyHv/KXmrdPcQJOpq5K4LMavTZKVCSrV/Q0qMfqCfBKYsTfCdsh2 U0GgSgigRF9sFk4Q6O7yMWPWRn+kruwGnInFXhNGNx+QXfbn8tlcXVz9FuMUfJhb3fhcJB3BI p5vTfjSAZWOmFJjWqJRgEh2k959lzMGXIX0Sl6LLLplex9zNRZt1kELP4LWb0IkpfM99mrPui LvoUE8sxD1d3+Jlf+L5OinOedLdnjUVfLDbGif3m0In6rG3XD8kfSsuzo8uOAeFXXDnyE5H8L RqmYFAbohUkIIXHaBNEU5LWkUiwwx8ycm9JOd7ccWgVB/1l898oJxvYZgUW0EjkIF+7egnwqY xTy3vlNBPJC2B7rIt/+IbFE3Knio/PWLgL1X+/AA5EBsFLey5abeaBqdfCmmwsRNBR9smCX/M sWNPzA== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Christophe Deleuze writes: Hi Cristophe, > I suggest slightly changing the regexp used in string-match to allow > for this colon, as shown below: > > (defun ange-ftp-passive-mode (proc on-or-off) > (if (string-match (concat "Passive mode:? " on-or-off) > [...] > > The attached patch does just that. Looks OK to me. Eli, do we want this in emacs-29 or master? > regards, Best rergards, Michael. From unknown Fri Jun 20 20:12:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67865: [PATCH] ange-ftp fails with tnftp client Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Dec 2023 19:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67865 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: 67865@debbugs.gnu.org, christophe.deleuze@free.fr Received: via spool by 67865-submit@debbugs.gnu.org id=B67865.170284106122887 (code B ref 67865); Sun, 17 Dec 2023 19:25:02 +0000 Received: (at 67865) by debbugs.gnu.org; 17 Dec 2023 19:24:21 +0000 Received: from localhost ([127.0.0.1]:59031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEwkO-0005x5-VP for submit@debbugs.gnu.org; Sun, 17 Dec 2023 14:24:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEwkN-0005wu-B0 for 67865@debbugs.gnu.org; Sun, 17 Dec 2023 14:24:19 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEwkG-0001Ny-1p; Sun, 17 Dec 2023 14:24:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=c5j92yD399UFrDCea0htldhlqSvHqE0C+weNrHdR8hI=; b=OTSMgrZ0dLpn 4ijGlb6e7x0sxaGDlgMSkFOziqXN5UKu6Bhp0juCqyZ7LLwRq5l146zWWyWpbZSdAj6BFbqcRdv1a TboCyecyvakeNt92lf68dDZWVkx1xNwNAf/ic0kfJ9R5KltDQiV2DOcHm0n8NV40m0G0QyZyydXzS 5d/8x5C86dBPE51Yuz9jgudHH+LACfLHtPz4KCzUUyj0KfzZGN/nikNcjlO+LMn8hpXVuNuu9BnbK OLKKuLGZicTtWK6FpUdUqQLchgu5ViVsABcPFsW159zou3x2s/vL0veGHEpK2rv/ZdZxXhuFwJYvW a3CYrM91HwHghn4/Tqtquw==; Date: Sun, 17 Dec 2023 21:23:55 +0200 Message-Id: <835y0wk4z8.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <8734w0vfb5.fsf@gmx.de> (bug-gnu-emacs@gnu.org) References: <878r5slyad.fsf@esisar.grenoble-inp.fr> <8734w0vfb5.fsf@gmx.de> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 67865@debbugs.gnu.org > Date: Sun, 17 Dec 2023 19:45:18 +0100 > From: Michael Albinus via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Christophe Deleuze writes: > > Hi Cristophe, > > > I suggest slightly changing the regexp used in string-match to allow > > for this colon, as shown below: > > > > (defun ange-ftp-passive-mode (proc on-or-off) > > (if (string-match (concat "Passive mode:? " on-or-off) > > [...] > > > > The attached patch does just that. > > Looks OK to me. > > Eli, do we want this in emacs-29 or master? It's okay to install this on emacs-29, thanks. From unknown Fri Jun 20 20:12:50 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Christophe Deleuze Subject: bug#67865: closed (Re: bug#67865: [PATCH] ange-ftp fails with tnftp client) Message-ID: References: <87cyv3u87p.fsf@gmx.de> <878r5slyad.fsf@esisar.grenoble-inp.fr> X-Gnu-PR-Message: they-closed 67865 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 67865@debbugs.gnu.org Date: Mon, 18 Dec 2023 10:17:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1702894622-4254-1" This is a multi-part message in MIME format... ------------=_1702894622-4254-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #67865: [PATCH] ange-ftp fails with tnftp client which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 67865@debbugs.gnu.org. --=20 67865: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D67865 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1702894622-4254-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 67865-done) by debbugs.gnu.org; 18 Dec 2023 10:16:22 +0000 Received: from localhost ([127.0.0.1]:59482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFAfe-000151-E5 for submit@debbugs.gnu.org; Mon, 18 Dec 2023 05:16:22 -0500 Received: from mout.gmx.net ([212.227.17.22]:53183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFAfb-00014X-An for 67865-done@debbugs.gnu.org; Mon, 18 Dec 2023 05:16:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1702894571; x=1703499371; i=michael.albinus@gmx.de; bh=YKzKj/icxsxr/nogrnydG0dycg27BfycwFRRb9X1GOI=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=P9RAAbqLPdDHA1U2brcctaYmfu0EUl7y8aJX1ac7QNQokXD75bKdiNWBCl2XXvgY OTtOStu3F4ZbNILd9JxY6DZpYfWzTtocTpgvOvMTFwoeb0i2Sr0ZIcc6tB0mmEXDL QMH1LaVc6t48ObV+0bCCuXgQPQwqOzOEQODs4tVrM56/TKHqxOe0VzbjTLpBCWqpt lzl85ZuPRVPPHwT8hUBlv56D9WT9Qn7TCcna6bpjcnmc3EJDsdZyepm/YEOuYuNzA SFLEOV/Sbgy2S4mtB2Hw0JMePzahTnmUuxZJMH25KnvUpJyzsfnk8PKu/P+uC3pqF RLdlN0G6OEkT7POgYQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.3]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MiJZO-1qm92z14R4-00fRi4; Mon, 18 Dec 2023 11:16:11 +0100 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#67865: [PATCH] ange-ftp fails with tnftp client In-Reply-To: <835y0wk4z8.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 17 Dec 2023 21:23:55 +0200") References: <878r5slyad.fsf@esisar.grenoble-inp.fr> <8734w0vfb5.fsf@gmx.de> <835y0wk4z8.fsf@gnu.org> Date: Mon, 18 Dec 2023 11:16:10 +0100 Message-ID: <87cyv3u87p.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:vT2m09I7YIZ4kUjAgz647WExokzLZP2IUnwm1tDtCpzKRaXBRQ6 OFwCzxEEhrtU7IuA74VhdDzv/EnDacG30EkjuHAl8+GuzHIhEVF53UFriPb/p+kc/DQKBcR vbEx57qd9XfUrRCi0o4CVafXveytSf06c7wpzQpnLf8dSD96OUDFcgLLRjcX/QteTEtEKF+ kComdYGwCNri4IcrDtVlw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:53BM8++e6nM=;isCPZIeilyuYxmOshS2wRfhQ83z rr5s8ow8TNwbUbaKs0qfNBo5v6Gq1U5+WNU/EU/k/88saLJ7Eh2c73JZBcoh3FEs5F0BvTc3P xc2vvrDrObK6ZqZv4Wk0S7KS8zPkxB4N1yBPfUmUx6tO1bXfz2EPHbu6FIVz+s+LFBf8quSe9 HBIpI1PnC9gCnpQnEgSjdR/wIqzynJF0caIFQmu6aly+UZurKNfiQaxOUd1jCxuf+C7givtg8 XoZgzgiVe+Vph+4I6uKbiWpxgrO14m4jrPThHxYXX08R1C4IXMXMnnXP1Pv844jF1IoRYOoa3 KKVjhr92kQfctoOaILwNOYlQfh+Z72+B69qlgBim5rxV+9W49B0+gQBoplnFHyC7bpeTFoxyA LRa0qdIc8WkSDnzBsDw9fitszRnN3B/MFAXWT9D4FZg6FpglT4vXyz2vwnqxT0c/lnwpMq4vi WX9PoHE8QaOXz34rcfSyCkHlx1AE/rZJWh67TzPS9wqinwgUYoqVu0N0MlZq9dfdnwZF+8v+q fJ5lxFACPFIfmrIIcPeeIRPw3PtFGUt96soL79FvEB2NMJ8TqzNze+lGikJfgh0+NBDwwZ+HQ Tr8X72LY36QssI8LqYFIED1+w2h1Om9LfA7v/Ubq3QcknWb1aWiG/NWpDZ9O+/gxUD1544UuQ +tsFHCAy57asplLCUPFu4LWcF3UKT0Hi6Tr/ZJTS8auqxz5/JB9pMlHBTWA+67C5wkHeUVBIR 5IlPS78PEnKc5ES7+f479LWiNJ9THCzDMaPhEf1Wbi0+fLgE8o1dmcWERFEdvinm8EQasK6Zo 7C0sNwOTXgqTu/EC4XhlaFmNgYCPrR8RwBykQ0dsMmTsUEI42hdrdSbiXmdiOJcpyH9A1HBTs 04tEcJGes72twlzvEDseyBBImFXHFf9fySLKUYgGTJERwu3ftOlC34ior61NTwK8NS9QmbaRe onpujA== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67865-done Cc: christophe.deleuze@free.fr, 67865-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Version: 29.2 Eli Zaretskii writes: Hi, >> > I suggest slightly changing the regexp used in string-match to allow >> > for this colon, as shown below: >> > >> > (defun ange-ftp-passive-mode (proc on-or-off) >> > (if (string-match (concat "Passive mode:? " on-or-off) >> > [...] >> > >> > The attached patch does just that. >> >> Looks OK to me. >> >> Eli, do we want this in emacs-29 or master? > > It's okay to install this on emacs-29, thanks. Done, closing the bug. Best regards, Michael. ------------=_1702894622-4254-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 17 Dec 2023 14:05:54 +0000 Received: from localhost ([127.0.0.1]:56784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rErmD-00016W-VW for submit@debbugs.gnu.org; Sun, 17 Dec 2023 09:05:54 -0500 Received: from lists.gnu.org ([2001:470:142::17]:38698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rErmC-00016H-H4 for submit@debbugs.gnu.org; Sun, 17 Dec 2023 09:05:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rErm5-0007O5-7w for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 09:05:45 -0500 Received: from mx1.esisar.grenoble-inp.fr ([195.220.36.133]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rErm3-0006N4-2E for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 09:05:44 -0500 Received: from localhost (localhost [127.0.0.1]) by mx1.esisar.grenoble-inp.fr (Postfix) with ESMTP id 248EAEC0287 for ; Sun, 17 Dec 2023 15:05:38 +0100 (CET) Received: from mx1.esisar.grenoble-inp.fr ([127.0.0.1]) by localhost (mx1.esisar.grenoble-inp.fr [127.0.0.1]) (amavis, port 10032) with ESMTP id 0tWklqJU-eIG for ; Sun, 17 Dec 2023 15:05:37 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mx1.esisar.grenoble-inp.fr (Postfix) with ESMTP id AA496EC0290 for ; Sun, 17 Dec 2023 15:05:37 +0100 (CET) X-Virus-Scanned: amavis at mx1.esisar.grenoble-inp.fr Received: from mx1.esisar.grenoble-inp.fr ([127.0.0.1]) by localhost (mx1.esisar.grenoble-inp.fr [127.0.0.1]) (amavis, port 10026) with ESMTP id RzXyX04mOgpL for ; Sun, 17 Dec 2023 15:05:37 +0100 (CET) Received: from srv-zimbra.esisar.grenoble-inp.fr (unknown [172.21.100.139]) by mx1.esisar.grenoble-inp.fr (Postfix) with ESMTPS id 8CCD1EC0287 for ; Sun, 17 Dec 2023 15:05:37 +0100 (CET) Received: from srv-zimbra.esisar.grenoble-inp.fr (localhost [127.0.0.1]) by srv-zimbra.esisar.grenoble-inp.fr (Postfix) with ESMTPS id 719D06E0223 for ; Sun, 17 Dec 2023 14:05:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by srv-zimbra.esisar.grenoble-inp.fr (Postfix) with ESMTP id 5F8E56E0224 for ; Sun, 17 Dec 2023 14:05:37 +0000 (UTC) X-Virus-Scanned: amavis at srv-zimbra.esisar.grenoble-inp.fr Received: from srv-zimbra.esisar.grenoble-inp.fr ([127.0.0.1]) by localhost (srv-zimbra.esisar.grenoble-inp.fr [127.0.0.1]) (amavis, port 10026) with ESMTP id mrFKqx2GmGZv for ; Sun, 17 Dec 2023 14:05:37 +0000 (UTC) Received: from LC1758 (88-120-161-23.subs.proxad.net [88.120.161.23]) by srv-zimbra.esisar.grenoble-inp.fr (Postfix) with ESMTPSA id 20A246E0223 for ; Sun, 17 Dec 2023 14:05:37 +0000 (UTC) User-agent: mu4e 1.11.7; emacs 30.0.50 From: Christophe Deleuze To: bug-gnu-emacs@gnu.org Subject: [PATCH] ange-ftp fails with tnftp client Date: Sun, 17 Dec 2023 14:56:57 +0100 Message-ID: <878r5slyad.fsf@esisar.grenoble-inp.fr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: neutral client-ip=195.220.36.133; envelope-from=christophe.deleuze@free.fr; helo=mx1.esisar.grenoble-inp.fr X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779, SPOOFED_FREEMAIL=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) --=-=-= Content-Type: text/plain * bug description When used with the tnftp client (https://en.wikipedia.org/wiki/Tnftp), ange-ftp fails when trying to enable passive mode. * fix description Passive mode is enabled by function ange-ftp-passive-mode: (defun ange-ftp-passive-mode (proc on-or-off) (if (string-match (concat "Passive mode " on-or-off) (cdr (ange-ftp-raw-send-cmd proc (concat "passive " on-or-off) "Trying passive mode..." nil))) (ange-ftp-message (concat "Trying passive mode..." on-or-off)) (error "Trying passive mode...failed"))) that expects to get a result string containing the string "Passive mode on" (when on-or-off is "on"), however tnftp includes a colon in its answer (extract from the buffer the ftp process is run in): ftp> passive on Passive mode: on; fallback to active mode: off. I suggest slightly changing the regexp used in string-match to allow for this colon, as shown below: (defun ange-ftp-passive-mode (proc on-or-off) (if (string-match (concat "Passive mode:? " on-or-off) [...] The attached patch does just that. For information, in debian bookworm the ftp package has changed from netkit-ftp to being a dummy transitional package for tnftp. regards, --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-ange-ftp-fix-passive-mode-result-string-for-tntfp-cl.patch Content-Description: patch >From 1f41c0b474b7cc731aa4824902199c13bd15c895 Mon Sep 17 00:00:00 2001 From: Christophe Deleuze Date: Sun, 17 Dec 2023 14:49:27 +0100 Subject: [PATCH] ange-ftp: fix passive mode result string for tntfp client --- lisp/net/ange-ftp.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/net/ange-ftp.el b/lisp/net/ange-ftp.el index 4e4db34a78d..a1eb57baa20 100644 --- a/lisp/net/ange-ftp.el +++ b/lisp/net/ange-ftp.el @@ -2164,7 +2164,7 @@ ange-ftp-get-process proc))) (defun ange-ftp-passive-mode (proc on-or-off) - (if (string-match (concat "Passive mode " on-or-off) + (if (string-match (concat "Passive mode:? " on-or-off) (cdr (ange-ftp-raw-send-cmd proc (concat "passive " on-or-off) "Trying passive mode..." nil))) -- 2.39.2 --=-=-=-- ------------=_1702894622-4254-1--