From unknown Wed Jun 18 23:12:24 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#67864 <67864@debbugs.gnu.org> To: bug#67864 <67864@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Transmission: Update to 4.0.5. Reply-To: bug#67864 <67864@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:12:24 +0000 retitle 67864 [PATCH] gnu: Transmission: Update to 4.0.5. reassign 67864 guix-patches submitter 67864 Leo Famulari severity 67864 normal tag 67864 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 17 01:34:12 2023 Received: (at submit) by debbugs.gnu.org; 17 Dec 2023 06:34:12 +0000 Received: from localhost ([127.0.0.1]:56526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEkj5-0002w1-Q9 for submit@debbugs.gnu.org; Sun, 17 Dec 2023 01:34:12 -0500 Received: from lists.gnu.org ([2001:470:142::17]:59118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEkj1-0002vj-2Q for submit@debbugs.gnu.org; Sun, 17 Dec 2023 01:34:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEkiu-0007Vo-8B for guix-patches@gnu.org; Sun, 17 Dec 2023 01:34:00 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEkir-00043z-9J for guix-patches@gnu.org; Sun, 17 Dec 2023 01:33:59 -0500 Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.west.internal (Postfix) with ESMTP id 311653200A35; Sun, 17 Dec 2023 01:33:55 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sun, 17 Dec 2023 01:33:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to; s=mesmtp; t=1702794834; x=1702881234; bh=J7OiNUrHgvyTJ8WuFH 3/HBdvh8CVtoAT6tEaulh0bhk=; b=gn4TOhJCaUmQFpbK/Xpa4RBiyjoBA6W7BP 5PbbyafBJnQdXuA4nN4pcJS+09n+0RyKsm1xhK4Gf05GS2pBkXcB4yiFRTLbHP2E UcqnEyB1tGwQC88GkF8/BbTvBwim9+45QXgNP6WbhSwjRdCf0U0y4hww13tPBFnj SsNyoMQZA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1702794834; x=1702881234; bh=J7OiNUrHgvyTJ8WuFH3/HBdvh8CV toAT6tEaulh0bhk=; b=3cTn5mCumXETmWC4axzOkG8miF10GgqxFfkZ0jXWG4m+ W1fPqE4lE3NHsf6mPdIrFqMUOLMsbF8wbyCtgA3TgGdCI1syVdcUfkr6RC+j2QpS QN2abb/37MKl0083gz6GqSJWYc84vBo5R5YdK3Ppo7qAfG0r8H3AL7xU6syDwu0p 4dXXkECXWZ7FpK681z9wb01sBLvyoWH+hFUNczCdWC36WkGvfKL1l8629Gw34fQd e2tp6nNEgJdGL60Kx7WQouRuG40E8avO8NQOGAJy3G/rvOQuEIPEZPv8pbVdUA72 uWfRsnOd768JLSIu4YYypuvE0zCIT26xoBt1vmfMxg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddthedgleekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhi rdhnrghmvgeqnecuggftrfgrthhtvghrnhepgeevfedtgefgveeggffhfedulefgudeitd ekhfeggeevheefjeehuefffeehveeinecuffhomhgrihhnpehgihhthhhusgdrtghomhen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghose hfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Sun, 17 Dec 2023 01:33:54 -0500 (EST) From: Leo Famulari To: guix-patches@gnu.org Subject: [PATCH] gnu: Transmission: Update to 4.0.5. Date: Sun, 17 Dec 2023 01:33:48 -0500 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.147.123.20; envelope-from=leo@famulari.name; helo=wout4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) * gnu/packages/bittorrent.scm (transmission): Update to 4.0.5. [source]: Use 'transmission-4.0.5-fix-build.patch'. * gnu/packages/patches/transmission-4.0.5-fix-build.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. Change-Id: I8e9486dca07f01628e7886e7ac5757d511056cb7 --- gnu/local.mk | 1 + gnu/packages/bittorrent.scm | 5 +- .../transmission-4.0.5-fix-build.patch | 98 +++++++++++++++++++ 3 files changed, 102 insertions(+), 2 deletions(-) create mode 100644 gnu/packages/patches/transmission-4.0.5-fix-build.patch diff --git a/gnu/local.mk b/gnu/local.mk index c404d2f52f..7983be58a5 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -2057,6 +2057,7 @@ dist_patch_DATA = \ %D%/packages/patches/tofi-32bit-compat.patch \ %D%/packages/patches/tpetra-remove-duplicate-using.patch \ %D%/packages/patches/transcode-ffmpeg.patch \ + %D%/packages/patches/transmission-4.0.5-fix-build.patch \ %D%/packages/patches/trytond-add-egg-modules-to-path.patch \ %D%/packages/patches/trytond-add-guix_trytond_path.patch \ %D%/packages/patches/ttf2eot-cstddef.patch \ diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm index 8c032940d4..fd92a93763 100644 --- a/gnu/packages/bittorrent.scm +++ b/gnu/packages/bittorrent.scm @@ -87,15 +87,16 @@ (define-module (gnu packages bittorrent) (define-public transmission (package (name "transmission") - (version "4.0.4") + (version "4.0.5") (source (origin (method url-fetch) (uri (string-append "https://github.com/transmission/transmission" "/releases/download/" version "/transmission-" version ".tar.xz")) + (patches (search-patches "transmission-4.0.5-fix-build.patch")) (sha256 (base32 - "19nm7f4x3zq610da5fl63vpycj4kv07np6ldm8czpgyziwqv9xqm")))) + "0mv3ds3bbp1fbmdlrjinmzvk46acpafydirh7h2014j7988zys7x")))) (build-system cmake-build-system) (outputs '("out" ; library and command-line interface "gui")) ; graphical user interface diff --git a/gnu/packages/patches/transmission-4.0.5-fix-build.patch b/gnu/packages/patches/transmission-4.0.5-fix-build.patch new file mode 100644 index 0000000000..606e8d2ab3 --- /dev/null +++ b/gnu/packages/patches/transmission-4.0.5-fix-build.patch @@ -0,0 +1,98 @@ +Fix the build of Transmission 4.0.5: + +https://github.com/transmission/transmission/issues/6392 + +Patches copied from upstream pull request: + +https://github.com/transmission/transmission/pull/6393 + +From 64b0933e713c725867ba5817bd197d668923161e Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?C=C5=93ur?= +Date: Sun, 17 Dec 2023 00:11:11 +0100 +Subject: [PATCH] build fix get_files2 behind IF_GTKMM4_10 + +--- + gtk/GtkCompat.h | 6 ++++++ + gtk/OptionsDialog.cc | 2 +- + 2 files changed, 7 insertions(+), 1 deletion(-) + +diff --git a/gtk/GtkCompat.h b/gtk/GtkCompat.h +index 34d1bbe22dd..6dde2a5ef8b 100644 +--- a/gtk/GtkCompat.h ++++ b/gtk/GtkCompat.h +@@ -44,6 +44,12 @@ + #define IF_GTKMM4(ThenValue, ElseValue) ElseValue + #endif + ++#if GTKMM_CHECK_VERSION(4, 10, 0) ++#define IF_GTKMM4_10(ThenValue, ElseValue) ThenValue ++#else ++#define IF_GTKMM4_10(ThenValue, ElseValue) ElseValue ++#endif ++ + #if GLIBMM_CHECK_VERSION(2, 68, 0) + #define IF_GLIBMM2_68(ThenValue, ElseValue) ThenValue + #else +diff --git a/gtk/OptionsDialog.cc b/gtk/OptionsDialog.cc +index 08198540c10..bff4286286a 100644 +--- a/gtk/OptionsDialog.cc ++++ b/gtk/OptionsDialog.cc +@@ -338,7 +338,7 @@ void TorrentFileChooserDialog::onOpenDialogResponse(int response, Glib::RefPtr +Date: Sun, 17 Dec 2023 02:54:33 +0100 +Subject: [PATCH] code review: revert bd31d805003909bd5927f26a02eb60b78a82355b + +--- + gtk/GtkCompat.h | 6 ------ + gtk/OptionsDialog.cc | 11 ++++++++++- + 2 files changed, 10 insertions(+), 7 deletions(-) + +diff --git a/gtk/GtkCompat.h b/gtk/GtkCompat.h +index 6dde2a5ef8b..34d1bbe22dd 100644 +--- a/gtk/GtkCompat.h ++++ b/gtk/GtkCompat.h +@@ -44,12 +44,6 @@ + #define IF_GTKMM4(ThenValue, ElseValue) ElseValue + #endif + +-#if GTKMM_CHECK_VERSION(4, 10, 0) +-#define IF_GTKMM4_10(ThenValue, ElseValue) ThenValue +-#else +-#define IF_GTKMM4_10(ThenValue, ElseValue) ElseValue +-#endif +- + #if GLIBMM_CHECK_VERSION(2, 68, 0) + #define IF_GLIBMM2_68(ThenValue, ElseValue) ThenValue + #else +diff --git a/gtk/OptionsDialog.cc b/gtk/OptionsDialog.cc +index bff4286286a..8c28fc76f98 100644 +--- a/gtk/OptionsDialog.cc ++++ b/gtk/OptionsDialog.cc +@@ -338,7 +338,16 @@ void TorrentFileChooserDialog::onOpenDialogResponse(int response, Glib::RefPtr>(); ++ auto files_model = get_files(); ++ for (auto i = guint{ 0 }; i < files_model->get_n_items(); ++i) ++ { ++ files.push_back(gtr_ptr_dynamic_cast(files_model->get_object(i))); ++ } ++#else ++ auto const files = get_files(); ++#endif + g_assert(!files.empty()); + + /* remember this folder the next time we use this dialog */ base-commit: fe86819d8bde674766659c22b215d3a689a8026e -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 25 12:27:28 2023 Received: (at 67864) by debbugs.gnu.org; 25 Dec 2023 17:27:28 +0000 Received: from localhost ([127.0.0.1]:55256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHojg-0002W6-Hf for submit@debbugs.gnu.org; Mon, 25 Dec 2023 12:27:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHojd-0002Vr-Ix for 67864@debbugs.gnu.org; Mon, 25 Dec 2023 12:27:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHojR-0000WW-8v; Mon, 25 Dec 2023 12:27:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=aBdbn81/SxbiU2QqcNJf3SlhqG9mzB50aN1gURp342g=; b=X0gzrAilFI4nxYAKYQ/s 9HOl+nz7JNNBein2rxCsV/+/LgiRWkOr0tQXsNoGJ5EQ+BiYQM279APukvc+DRNT5/BElhUbPoWv2 WY5mLVgLjhhNscJ7LpGEasWcAPzeyiWUoj67XGFLh4w5GzxBf94HUxsjClgOwP9NaKUgHmJ/Sa4/B rGc1qK/v11x/jgzZNJWLMjy+VvhpSC7jFlbf6wbah9Log3Q6o5hZTxV1nyRiWN7ye5lDl2V9NtidE RQpQ88ZmI98yx6CeNFPptyqsQthIM4pcyvW+aW2MpdBAjaVl1d50bIYbQz41PCLdjGD9Pp1fO5JC8 GCpFhJw25PmCZw==; From: Mathieu Othacehe To: Leo Famulari Subject: Re: [bug#67864] [PATCH] gnu: Transmission: Update to 4.0.5. In-Reply-To: (Leo Famulari's message of "Sun, 17 Dec 2023 01:33:48 -0500") References: Date: Mon, 25 Dec 2023 18:27:10 +0100 Message-ID: <87jzp2i45t.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67864 Cc: 67864@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > * gnu/packages/bittorrent.scm (transmission): Update to 4.0.5. > [source]: Use 'transmission-4.0.5-fix-build.patch'. > * gnu/packages/patches/transmission-4.0.5-fix-build.patch: New file. > * gnu/local.mk (dist_patch_DATA): Add it. Looks good! Mathieu From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 29 15:00:02 2023 Received: (at 67864-done) by debbugs.gnu.org; 29 Dec 2023 20:00:02 +0000 Received: from localhost ([127.0.0.1]:42285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJJ1V-0005i4-KA for submit@debbugs.gnu.org; Fri, 29 Dec 2023 15:00:01 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:47927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJJ1S-0005hm-W1 for 67864-done@debbugs.gnu.org; Fri, 29 Dec 2023 15:00:00 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B12315C02CB; Fri, 29 Dec 2023 14:59:53 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 29 Dec 2023 14:59:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=mesmtp; t=1703879993; x= 1703966393; bh=nvZuCES9+EGeUe2EdwJOH0af1zYRgbt4n44SNB6UQMI=; b=b GtyswHkUS+x2DMTyyL6B2lgRbPo92LPMmh804QmN9/Wqf7K/lDpaD10ugrbeC7ED YxnZfjlZoq4NQCMBPORyiEzcIBl6BmimEd9GjDS88EdlhMWspA/uknmG2DzRJ5MM lQXpPiwM94liQS2RtZSk0FVeonfZ2D06IQ3kDk/sE4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1703879993; x=1703966393; bh=nvZuCES9+EGeUe2EdwJOH0af1zYR gbt4n44SNB6UQMI=; b=uenDHWlInALmmXRoqGCXNLIDbqY2eOn6SKAuRiu5aA3D qej3NJHR1r0SMNBkBcaORMKd16RYngHyVc9BiTknsljzEwL1akpa/n7RiWk/sUsl O4qam714h+az7xIK8ANUPEmlbk+z/0ViUsxZY8PpiDfSBkfJrITA9oVmUaMdsuEp kc7GccuOsAvNdbfy3r6fO89AQ91+9fiYx6QoqlRlt9heKFF5JIUbZ1hBwetYq4P+ N7zjnKcvTqqnEx93kX+xsk6vTEL8rusc26AZ38+TcyNoBmt3qZ7K5zLjKMKplWxC MqYRVKFGTEMmmIeJTuCQuFYumPlRYELpK4uuc4q9Hw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeffedgudefvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvgho ucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrg htthgvrhhnpeeiteduheefkeeufeelgeduhfejgfelheefleeuhfeffffgueduleehvdej leeiteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 29 Dec 2023 14:59:53 -0500 (EST) Date: Fri, 29 Dec 2023 14:59:51 -0500 From: Leo Famulari To: Mathieu Othacehe Subject: Re: [bug#67864] [PATCH] gnu: Transmission: Update to 4.0.5. Message-ID: References: <87jzp2i45t.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87jzp2i45t.fsf@gnu.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67864-done Cc: 67864-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Mon, Dec 25, 2023 at 06:27:10PM +0100, Mathieu Othacehe wrote: > > > * gnu/packages/bittorrent.scm (transmission): Update to 4.0.5. > > [source]: Use 'transmission-4.0.5-fix-build.patch'. > > * gnu/packages/patches/transmission-4.0.5-fix-build.patch: New file. > > * gnu/local.mk (dist_patch_DATA): Add it. > > Looks good! Great, pushed as d263c49919235b81b318c45c99aa189be04c5f28 From unknown Wed Jun 18 23:12:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 27 Jan 2024 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator