GNU bug report logs - #67842
[PATCH 0/4] Refactor mympd service.

Previous Next

Full log

View this message in rfc822 format

From: Bruno Victal <mirai <at> makinata.eu>
To: 67842 <at> debbugs.gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [bug#67842] [PATCH 3/4] services: mympd: Fix syslog logging and missing service destructor.
Date: Fri, 15 Dec 2023 21:02:38 +0000

* gnu/services/audio.scm: (mympd-shepherd-service): Fix syslog logging and
missing service destructor. Prefer list over quasiquote.
---
 gnu/services/audio.scm | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
index ae991ced4d..4fcfcc13ea 100644
--- a/gnu/services/audio.scm
+++ b/gnu/services/audio.scm
@@ -938,14 +938,15 @@ (define (mympd-shepherd-service config)
                                                             cache-directory)))))
 
               (make-forkexec-constructor
-               `(#$(file-append package "/bin/mympd")
-                 "--user" #$username
-                 #$@(if (eq? log-to 'syslog) '("--syslog") '())
-                 "--workdir" #$work-directory
-                 "--cachedir" #$cache-directory)
+               (list #$(file-append package "/bin/mympd")
+                     "--user" #$username
+                     #$@(if (maybe-value-set? log-to) '() '("--syslog"))
+                     "--workdir" #$work-directory
+                     "--cachedir" #$cache-directory)
                #:environment-variables
                (list #$(format #f "MYMPD_LOGLEVEL=~a" log-level))
-               #:log-file #$(maybe-value log-to)))))))))
+               #:log-file #$(maybe-value log-to))))))
+     (stop #~(make-kill-destructor)))))
 
 (define (mympd-accounts config)
   (match-record config <mympd-configuration> (user group)
-- 
2.41.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.