From unknown Sat Aug 09 13:06:35 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#67839 <67839@debbugs.gnu.org> To: bug#67839 <67839@debbugs.gnu.org> Subject: Status: shepherd: sometimes hangs on `guix system reconfigure` Reply-To: bug#67839 <67839@debbugs.gnu.org> Date: Sat, 09 Aug 2025 20:06:35 +0000 retitle 67839 shepherd: sometimes hangs on `guix system reconfigure` reassign 67839 guix submitter 67839 Attila Lendvai severity 67839 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 15 14:21:05 2023 Received: (at submit) by debbugs.gnu.org; 15 Dec 2023 19:21:05 +0000 Received: from localhost ([127.0.0.1]:53461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEDk9-0007Pr-3h for submit@debbugs.gnu.org; Fri, 15 Dec 2023 14:21:05 -0500 Received: from lists.gnu.org ([2001:470:142::17]:40230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEDk6-0007Ow-Dn for submit@debbugs.gnu.org; Fri, 15 Dec 2023 14:21:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEDk0-0007qv-4h for bug-guix@gnu.org; Fri, 15 Dec 2023 14:20:56 -0500 Received: from mail-4018.proton.ch ([185.70.40.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEDjw-0007Ba-KL for bug-guix@gnu.org; Fri, 15 Dec 2023 14:20:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name; s=protonmail; t=1702668046; x=1702927246; bh=NwH8OoV2s4H9SPqqjRjnvkBUXFfnYIoyz4uDgvl4B3I=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=c4rR3c9RG6EmzBrYRAlpsja/keI37gHcX0h2zbZHHOXmZ8A+KxJcwxGokuRh4VqEQ MOgt+CvTwYDiRrjFWg6dQjEV2yQFNwkSFlz5piqiqpgsSeN5YJFniMamGfmBkevvu2 79ZXUvhLWuSBVa3UNGOMFURST6bx7A3159H63n+QIAVd/Su1yNgjoKv9wJoXMvDEHN 7Szf8TwtvqnXMkvCb4C/ZOiwZ6ev0FVdRf+iZ6A+c0AQyn7yV0XALswbKV6STWWzq2 6wTiTwPwyVgEx9R825/MPEh3IvOIVHkG8Kec6hZlajVAavRVfQAP2QKsBpxjNVOFkj TI6f2uBT5oGsA== Date: Fri, 15 Dec 2023 19:20:36 +0000 To: "bug-guix@gnu.org" From: Attila Lendvai Subject: shepherd: sometimes hangs on `guix system reconfigure` Message-ID: Feedback-ID: 28384833:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.40.18; envelope-from=attila@lendvai.name; helo=mail-4018.proton.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) my fellow hackers, i'm going to attach two patches that is essentially just adding a couple of= asserts that trigger a test failure (tests/replacement.sh). my current codebase (https://codeberg.org/attila-lendvai-patches/shepherd/c= ommits/branch/attila) logs a whole lot more information, and has a more sop= histicated error handling. triggering the same error on that codebase shows= that the first assert is already failing (the one that is before spawning = the new fiber for the controller of the replacement). maybe the root cause is this: https://github.com/wingo/fibers/issues/29 HTH, --=20 =E2=80=A2 attila lendvai =E2=80=A2 PGP: 963F 5D5F 45C7 DFCD 0A39 -- =E2=80=9CAngry people want you to see how powerful they are=E2=80=A6 loving= people want you to see how powerful You are.=E2=80=9D =09=E2=80=94 Chief Red Eagle From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 15 14:37:49 2023 Received: (at 67839) by debbugs.gnu.org; 15 Dec 2023 19:37:49 +0000 Received: from localhost ([127.0.0.1]:53476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEE0L-00026z-EL for submit@debbugs.gnu.org; Fri, 15 Dec 2023 14:37:49 -0500 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:58678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEE0J-00026Y-By for 67839@debbugs.gnu.org; Fri, 15 Dec 2023 14:37:47 -0500 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40c39e936b4so10625315e9.1 for <67839@debbugs.gnu.org>; Fri, 15 Dec 2023 11:37:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702669061; x=1703273861; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nPnpgOGb44XCaxlJVDoPkbIfJAEil85EURvGlL3piwU=; b=AY77TLchXuVGGhnyFWxcuqRElJwA/1id1D6cs5C7boG6T4QKQ0MiTi/1scLjxGDlR7 EnGEf/DZl61mTE5KfpiA9XjtEhTgbUsVIAsuZfxD7R8memCyT6TQByKAZc9W+/HKBiXA U6c/VQr5N2gvECbmiN4BkMA8539GYh/98N5n7P2E0dZMuU/Ppxe/M1c2c9UoWIJpIRBJ DV8BM23/a0Zqzstv56q7PJPpsMxzPQ1ivusz3NjPrepSD6v4Qb0139kV/vx0tur1jZ4H zt4s6CvfzHuysxDdIU4mfL6P+DCKM1ltkHF5+RLXqDif+oeYA0N/uSoRkNWs2ewEGrK6 j+7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702669061; x=1703273861; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nPnpgOGb44XCaxlJVDoPkbIfJAEil85EURvGlL3piwU=; b=vrEpktLXvNXF69dzCj2WtDgGU6CJSu2RkTtMK8L6r929wAO69DM6LW1ibjoIOHG3uz Yq8Ba8bMWwryiknzn/heDR2dx4ff5FH4TtW8jWx4yJUlJHzKJQOUW8Hz+tK4sCHy6UjK PkVPAZR3LEAf0DSZVs1z8ZcST8T+6XzIcy3UNMBzqtHgFDx8ELC33WQRPM8PTYxHrW+0 nhUZZ+BTsXK0874J0TBll5YzzVO+wT3jUQhngiemlXU/o1sYllvVnkNYMz67OuC7opzw Sllpev0GmEW8RrAcJFIoLn2H9qBLLg7MwH19dX0tdYAZibxHV7+SAAkb3FMRXP8ubu92 Qg6g== X-Gm-Message-State: AOJu0Yx9lvXkqAC8n/xe4websgtbKkwGSe1J211NrVrQA1VwxORD0P+5 LOEoYkCpy9lkwYKJe9TMBf4Z95by/kQukg== X-Google-Smtp-Source: AGHT+IF4sjjAz+0EHEtiPyGm8HE/lze1TP2LJRbnBx99ju7LyErfVO2PyKPcWAaY4jV/BTVEwofz4Q== X-Received: by 2002:a05:600c:4f4e:b0:40c:2734:13a6 with SMTP id m14-20020a05600c4f4e00b0040c273413a6mr3349808wmq.3.1702669061063; Fri, 15 Dec 2023 11:37:41 -0800 (PST) Received: from lelap.lan (2a00-1f40-b161-8e0--477.pool6.panelnet.hu. [2a00:1f40:b161:8e0::477]) by smtp.gmail.com with ESMTPSA id h2-20020a05600c350200b0040c6b2c8fa9sm3491801wmq.41.2023.12.15.11.37.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 11:37:38 -0800 (PST) From: Attila Lendvai X-Google-Original-From: Attila Lendvai To: 67839@debbugs.gnu.org Subject: [PATCH 1/2] shepherd: Move root-service start under with-process-monitor. Date: Fri, 15 Dec 2023 20:37:08 +0100 Message-ID: <20231215193708.25169-2-attila@lendvai.name> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67839 Cc: Attila Lendvai X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * modules/shepherd.scm (main): move the (start-service root-service) under the dynamic extent of with-process-monitor, so that (current-process-monitor) is valid for the root-service, too. --- modules/shepherd.scm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/modules/shepherd.scm b/modules/shepherd.scm index efc5517..77c6d18 100644 --- a/modules/shepherd.scm +++ b/modules/shepherd.scm @@ -451,12 +451,12 @@ fork in the child process." (run-fibers (lambda () (with-service-registry + (with-process-monitor - ;; Register and start the 'root' service. - (register-services (list root-service)) - (start-service root-service) + ;; Register and start the 'root' service. + (register-services (list root-service)) + (start-service root-service) - (with-process-monitor ;; Replace the default 'system*' binding with one that ;; cooperates instead of blocking on 'waitpid'. Replace ;; 'primitive-load' (in C as of 3.0.9) with one that does -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 15 14:38:16 2023 Received: (at 67839) by debbugs.gnu.org; 15 Dec 2023 19:38:16 +0000 Received: from localhost ([127.0.0.1]:53480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEE0l-00028J-Qt for submit@debbugs.gnu.org; Fri, 15 Dec 2023 14:38:16 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:61456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEE0j-00027w-2c for 67839@debbugs.gnu.org; Fri, 15 Dec 2023 14:38:14 -0500 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-3365baf616eso224479f8f.2 for <67839@debbugs.gnu.org>; Fri, 15 Dec 2023 11:38:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702669087; x=1703273887; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8aHgjZWzLgQzhZ5kgTRqER+zfkQHNJofiQE4niyj+LM=; b=Hx04h7I41ZVWTpJkLUTY2jtxhe7Z2a8wG8Jr/B3h+5PihDbwTUAJboZjxh5z1R/tWv 9D2+96tqzpZFAr7s4ZyDBDM9rACk8v8XJg3pf3e1M205n/dLn8LGvOiBRTyYHJx0DD3g +qDO+uzzuUEMHpybWVPtQ61ee9wAMObb2WlAs7KnVLyXZCsnWu40iQbibcMCQHwNrUCY 8g6q27PedLV5JzNahXUzq2oVCfbiYHCPj/HhaaZwneOBO2einKse1yuNIBa87VAKyv6t jR2P4joTkm32j/W5SsFgXBBJKDNcTpY8In3iwNH+MXmxv/XFwNGn0GKVbevgdZJlQZs6 JbAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702669087; x=1703273887; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8aHgjZWzLgQzhZ5kgTRqER+zfkQHNJofiQE4niyj+LM=; b=DF1tgGptsVi1K1/cKNBpCmhVXrdyf2xp01sv9gsyfpOyaXDiAbZL33r3zkDPZRcvYn iRd/hB9Tkwa91Syp7KEfCkt3ot6Lt05bIXXmASPLNOgBa/zBC6kBU1Dr1Ysq1FN9gRh7 AK2caRGS//C2MNxzzXssPqVCbTzUX1RlOIGUX00hB0lmu05GJ2KVD+BULFqhvgATU6Oz x2JztAJzHn6oSMffXkSn4tYrQRvTO5bP6Ph8jzFfI4Ada9N4A7ZUEbLNl+M1KnZQCWcZ 6and+DOVOKzOv2p2xIA7aof4Koaj3SofknjEu4c6E1vm2onn60qE1wDBJKVeV7yVj8pG wo4Q== X-Gm-Message-State: AOJu0YwRNRWGEk6bNnpduBzIn0ucEEcgKdz7WMGESuZXyr3ESP1SVo+/ b+GJVu9TpXOQpn473epCvJpKtnhxRimWiw== X-Google-Smtp-Source: AGHT+IH1k0vQTf3L31slQfbcc/g8IMSe3yIjcs9WjSaRPAwsJdu6hRDSbTmYTGyxidnKMUJehdIAHQ== X-Received: by 2002:a05:6000:231:b0:336:592b:207a with SMTP id l17-20020a056000023100b00336592b207amr544555wrz.141.1702669086702; Fri, 15 Dec 2023 11:38:06 -0800 (PST) Received: from lelap.lan (2a00-1f40-b161-8e0--477.pool6.panelnet.hu. [2a00:1f40:b161:8e0::477]) by smtp.gmail.com with ESMTPSA id h2-20020a05600c350200b0040c6b2c8fa9sm3491801wmq.41.2023.12.15.11.38.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 11:38:05 -0800 (PST) From: Attila Lendvai X-Google-Original-From: Attila Lendvai To: 67839@debbugs.gnu.org Subject: [PATCH 2/2] service: Add two asserts that will make tests/replacement.sh fail. Date: Fri, 15 Dec 2023 20:37:10 +0100 Message-ID: <20231215193708.25169-4-attila@lendvai.name> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231215193708.25169-2-attila@lendvai.name> References: <20231215193708.25169-2-attila@lendvai.name> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67839 Cc: Attila Lendvai X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * modules/shepherd/service.scm (spawn-service-controller): Add two asserts. This is the bug that causes `guix system reconfigure ...` to sometimes hang, and subsequently all shepherd commands, because a match-error flies out from the service-controller of a replaced service, and thus its fiber dies. --- modules/shepherd/service.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/modules/shepherd/service.scm b/modules/shepherd/service.scm index c3bdf44..0ee6929 100644 --- a/modules/shepherd/service.scm +++ b/modules/shepherd/service.scm @@ -382,9 +382,11 @@ denoting what the service provides." (define (spawn-service-controller service) "Return a channel over which @var{service} may be controlled." + (assert (current-process-monitor)) (let ((channel (make-channel))) (spawn-fiber (lambda () + (assert (current-process-monitor)) ;; The controller writes to its current output port via 'local-output'. ;; Make sure that goes to the right port. If the controller got a ;; wrong output port, it could crash and stop responding just because a -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 15 15:33:57 2023 Received: (at 67839) by debbugs.gnu.org; 15 Dec 2023 20:33:57 +0000 Received: from localhost ([127.0.0.1]:53599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEEsf-0005s4-Ec for submit@debbugs.gnu.org; Fri, 15 Dec 2023 15:33:57 -0500 Received: from mx2.mythic-beasts.com ([2a00:1098:0:82:1000:0:2:1]:39599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEEsb-0005rP-8t; Fri, 15 Dec 2023 15:33:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=twilken.net ; s=mythic-beasts-k1; h=To:From:Subject:Date; bh=jC0InzQ7oEP9Z7WFVgDGj++WwCHyrN863tnSo3uvUWU=; b=rBeynNr3NeGoKZ+sKMQHfaYS8q HNj4tq/4ZJvYcwhEn++Vpw8d9TYIKUBVYDxoI1UQTlyskwz92mRudiXkMdB9VB9Zp09cwvELWd00o HwDPiHLQGSD8rp4tphQREpUuoVi8yv9HFahxbFzSmJ6ujzVWerLWrzugacwNwwKO7IHxoUmjs8wGN Qomf/YfAF+YZNvAoq+PvUoNMu2/OG2MjSbk/AjJX1xchl8aE58VEEESOARZq1l70zrzHe7D+KqhVX 3P5qgi7Qyx/5xzRrbqeuIaaWy3Kl7L4XHFmS65IAV+s+Rwsg663Z8ELRb6USEjDKdmem+ATwOlVrW twoeT0Nw==; Received: by mailhub-hex-d.mythic-beasts.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rEEsT-0019KS-Ny; Fri, 15 Dec 2023 20:33:46 +0000 Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 15 Dec 2023 21:33:15 +0100 Subject: Re: Shepherd stops responding during "guix system reconfigure" From: "Timo Wilken" To: "Attila Lendvai" Message-Id: X-Mailer: aerc 0.15.2 References: In-Reply-To: X-BlackCat-Spam-Score: 7 X-Spam-Status: No, score=0.7 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67839 Cc: 67538@debbugs.gnu.org, 67230@debbugs.gnu.org, 67839@debbugs.gnu.org, 65178@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Fri Dec 15, 2023 at 8:47 PM CET, Attila Lendvai wrote: > i think i have found the root cause of this, as documented here: https://= issues.guix.gnu.org/67839 > > that issue contains patches for shepherd to reproduce it in its test suit= e. Thank you very much for this, Attila! Are the patch in 67839 and/or your branch "attila" linked from there in a state that I could test them locally? Would it be valuable to you if I ran = a patched Shepherd and sent logs and/or backtraces as I encountered them? From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 15 16:24:52 2023 Received: (at 67839) by debbugs.gnu.org; 15 Dec 2023 21:24:52 +0000 Received: from localhost ([127.0.0.1]:53682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEFfw-0006e7-Bi for submit@debbugs.gnu.org; Fri, 15 Dec 2023 16:24:52 -0500 Received: from mail-4317.proton.ch ([185.70.43.17]:48689) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEFfs-0006dQ-8U; Fri, 15 Dec 2023 16:24:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name; s=protonmail; t=1702675480; x=1702934680; bh=y3yAYaeQdcJALa8ThMhZGisB2wRnQmTrZGz2x9iZ8K0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=aB4FHXQE24zHZx2Ff3xO1GVshSHX9h9s09FakwGFwp2WA2s3PS+7lI1pJZRf6Yj2A Xbdr1EXGaKzTF1t0HDK0QbbpPxamHBGtMxmZcUqpiM8r6dawoYB5lxaWQ0/UCp3rLy CnEgrfrHvxPAldF0+0zjLNmgjtp3B7c7FgAAvDfdpIQ2/wOwnwizlfWtrITzD6VVQb 0REsYCFtH2oCFRZoOWUrZFIl9lN668bNiu5EQz5c9MOD2OsG2mXuaZVgBC+m9gGYrX cUQSrBEguWJYI/pVGBDW+17Hb4IOZ+Uy2oRE0iKUT0+pNvUgD9mobEvcFKZHia013a JkyxW2hUZDgUQ== Date: Fri, 15 Dec 2023 21:24:15 +0000 To: Timo Wilken From: Attila Lendvai Subject: Re: Shepherd stops responding during "guix system reconfigure" Message-ID: In-Reply-To: References: Feedback-ID: 28384833:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67839 Cc: 67538@debbugs.gnu.org, 67230@debbugs.gnu.org, 67839@debbugs.gnu.org, 65178@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Thank you very much for this, Attila! you're welcome! :) > Are the patch in 67839 and/or your branch "attila" linked from there in a > state that I could test them locally? Would it be valuable to you if I ra= n a > patched Shepherd and sent logs and/or backtraces as I encountered them? it's nice of you, but not really. now that we have a failing test case in s= hepherd's unit tests that can reproduce it much easier. with #67839 you would only get you an extra "Assertion failed" message over= master, without much useful output. as for my branch, it would emit a lot of useful log, including backtraces, = but i keep force-pushing into it. i'm running my servers with it, though, s= o if you feel really adventurous, and want to join the debugging, then you = can try... otherwise it's too much in flux. what we need to focus on now is making shepherd's test suite run clean agai= n, one way or another. then i can test it in a real life environment, and r= eport back with any possible findings. --=20 =E2=80=A2 attila lendvai =E2=80=A2 PGP: 963F 5D5F 45C7 DFCD 0A39 -- =E2=80=9CIgnorance might be bliss for the ignorant, but for the rest of us = it's a fucking pain in the ass.=E2=80=9D =09=E2=80=94 Ricky Gervais From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 16 19:07:24 2023 Received: (at 67839) by debbugs.gnu.org; 17 Dec 2023 00:07:24 +0000 Received: from localhost ([127.0.0.1]:56346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEegm-0000Gx-Dc for submit@debbugs.gnu.org; Sat, 16 Dec 2023 19:07:24 -0500 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]:45540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEegd-0000GZ-CH for 67839@debbugs.gnu.org; Sat, 16 Dec 2023 19:07:22 -0500 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-54c79968ffbso1984112a12.3 for <67839@debbugs.gnu.org>; Sat, 16 Dec 2023 16:07:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702771628; x=1703376428; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=RPjTEqAoDTNTOpC6SAoefIlLyYxwP/pAeZ/dxmPSmEI=; b=fC4BXNr6ETVjCZy6wkWz8GPdJfpBSv8YqS7mYaGuaslmPlWIoMQo70NLBBp6gpwdEJ oVBrnTubylnqgi4MAZzH/t4udeYH2HkesonRqMHCa8CMQZjbA/AuZ1NbECi8rIEw9pcH tfj5fUNEg3MiUX64dZiKaQNuvzpO0e0iJA+/VQD3hO/s74LPsMUEUJ2hqKxuM+bJsvPV dhLtn7AU4n0MMTRr6g4joJVPcqlumTxsrQ3x2qGrHWBvBXrg4WzbXfSVmJD4qTYVyaYX XnCWTCr7OULUaee9o537+cjwX35suCwnE4Pcf2h8kClF0P7qFTp+r5m73Lo1iNhP3PBx IzUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702771628; x=1703376428; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RPjTEqAoDTNTOpC6SAoefIlLyYxwP/pAeZ/dxmPSmEI=; b=pMWePf89i6gNOCjwC9XVV+xaGEE3uFxCt95mSqxq9eZQP8WMc6QxfwXolwoUARfJEz x/GGIbA46B4AoGjI9EPpgeFuviDxeKGD1mD20nWpqMOUjfJH6ghk72vZTCEqSamoOI2u AZ0m2xWIm3zEV4aGtA/OKO0iwsWdGhY5y9yB3MTja3Lc3N+p6zll/gzf5Ioa3sk3jcxX rMTKF9GtlcdHS18zZHd5426jFVBLSngbaq3cp+ATOcw1TrirKF91MIC0B4O25/WNmI7/ 00pMT8dxBR3huQMw4RjKdurULZzwWpxkNOzZkmu+CBRht1n70I2HBoa2in2ZBSk/5U9L NUbQ== X-Gm-Message-State: AOJu0YyxxmVOjmaWvf51egbs43VUI+faI7EvQXbCLe2OtDYA974AFElQ vgykL3ULNe+FbpKEaEk3Oq7l6NZcgrlulA== X-Google-Smtp-Source: AGHT+IHOZjeJVeLS1NQ2aVIeIXb8TLncdBEDFuGC0J2QwL8zZ7bsh7yGwsWhYEEcRs8bJPeAr2zNfA== X-Received: by 2002:a50:99dd:0:b0:54b:1a4c:8711 with SMTP id n29-20020a5099dd000000b0054b1a4c8711mr6923461edb.2.1702771628284; Sat, 16 Dec 2023 16:07:08 -0800 (PST) Received: from lelap.lan (2a00-1f40-b161-8e0--477.pool6.panelnet.hu. [2a00:1f40:b161:8e0::477]) by smtp.gmail.com with ESMTPSA id l14-20020aa7cace000000b005530492d900sm783982edt.58.2023.12.16.16.06.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Dec 2023 16:07:07 -0800 (PST) From: Attila Lendvai X-Google-Original-From: Attila Lendvai To: 67839@debbugs.gnu.org Subject: [PATCH 3/2] shepherd: Fix tests/replacement.sh Date: Sun, 17 Dec 2023 01:06:24 +0100 Message-ID: <20231217000623.1430-2-attila@lendvai.name> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67839 Cc: Attila Lendvai X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * modules/shepherd.scm (main): Switch with-service-registry and with-process-monitor. Fix proposed by @emixa-d at https://github.com/wingo/fibers/issues/29#issuecomment-1858922276. This way the parameterize of the process monitor covers everything else. --- modules/shepherd.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/shepherd.scm b/modules/shepherd.scm index 77c6d18..3303de3 100644 --- a/modules/shepherd.scm +++ b/modules/shepherd.scm @@ -450,8 +450,8 @@ fork in the child process." ;; because POSIX threads and 'fork' cannot be used together. (run-fibers (lambda () - (with-service-registry - (with-process-monitor + (with-process-monitor + (with-service-registry ;; Register and start the 'root' service. (register-services (list root-service)) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 16 19:45:02 2023 Received: (at 67839) by debbugs.gnu.org; 17 Dec 2023 00:45:03 +0000 Received: from localhost ([127.0.0.1]:56379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEfH9-0006T3-J7 for submit@debbugs.gnu.org; Sat, 16 Dec 2023 19:45:02 -0500 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:61528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEfH7-0006Sh-1p for 67839@debbugs.gnu.org; Sat, 16 Dec 2023 19:44:58 -0500 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-3365e985c2cso439082f8f.2 for <67839@debbugs.gnu.org>; Sat, 16 Dec 2023 16:44:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702773890; x=1703378690; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4Mk7jLFsb4QSOWC4RJ/CAAuNvvUY9wedxBZkZCM90jU=; b=O3k/T46VKzAXPTpQInvbFo4RdnCpmR3v0/3kMQZLRU3BkHoDEd5BQXL4+gcc7vU+x7 7Fg4oEBasIu9Acz/MFXDxAqppwDRyu6Xe1TSJkge8QbEDSxhJTF+/R19JQVFJFRKyf9e Ne5d+qdqBrLnukI0imqL8TGaymE2+bRFHaU/8S+Came7CQ/6hxcKt8WWNquXxAmKcf+0 clU4n+QXDZxpOeuiVdnKmh55ykqGtplvgMJTEJKjBYQjydqJwx0NUMLf2qAE5dMK14o0 qeJaJCxfFBVQ3v6SCqtgBcoW+n1PaK8pk22y9ZRluJW5YJMokYJ0eOKIVrhgsh21TXah MIOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702773890; x=1703378690; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4Mk7jLFsb4QSOWC4RJ/CAAuNvvUY9wedxBZkZCM90jU=; b=Wc+LqlJacjV3KNETrciru0ZAhvVW0y848ZSFhv6ZiJZS8Hz2tRZ1oBcE6iV29gW1aE zObW5DWQhPjbkBYNSF0SDQaBKSBxiMYspwVg8quP4VVkKewaF3GdhJXbq2Xou/88J4no EAEkoVyUiEFSTsHSvnYxFb725N4sdEFgQ0VLIpou2/EkvhXlDcmCu3zbgnTCQPhKldxU NZhHdqCQ8w8XovUXkDiHUjXQ3/EPTrna8cp9EhT1vYKZin9OlIdr7N6ZScGqSff18KX8 Z8Pl9u/ti230g6Z+MDOxGz1b+1go6/8HPH5Z1QajgrYD7Ot7q9mWkzhmLIjmMZCN+wGk /97Q== X-Gm-Message-State: AOJu0Yz29H1HUaQ5ZD0BqpIBwRdNT3KoMG2mG37zL+hpW1dXQnkdpQTS 1J4nI7+4FrcWV4Y9yeO7lDA7FLDajeRWLA== X-Google-Smtp-Source: AGHT+IFJ3yVXKM2AQE3I/im+PTJLfN0alnqJsbSaNlaqKDrsW4AyZAfgVaTR2U/Mtyp4e71w7gKdTw== X-Received: by 2002:a5d:6847:0:b0:336:4420:948d with SMTP id o7-20020a5d6847000000b003364420948dmr3354770wrw.122.1702773889963; Sat, 16 Dec 2023 16:44:49 -0800 (PST) Received: from lelap.lan (2a00-1f40-b161-900-9180-9bd5-ff71-193b.pool6.panelnet.hu. [2a00:1f40:b161:900:9180:9bd5:ff71:193b]) by smtp.gmail.com with ESMTPSA id t16-20020a056402241000b00552743342c8sm2960258eda.59.2023.12.16.16.44.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Dec 2023 16:44:49 -0800 (PST) From: Attila Lendvai X-Google-Original-From: Attila Lendvai To: 67839@debbugs.gnu.org Subject: [PATCH v2 1/2] shepherd: Make sure with-process-monitor covers everything needed. Date: Sun, 17 Dec 2023 01:44:24 +0100 Message-ID: <20231217004424.28303-2-attila@lendvai.name> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67839 Cc: Attila Lendvai X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * modules/shepherd.scm (main): Switch with-service-registry and with-process-monitor. This way the parameterize of the process monitor covers everything else. This fixes the bug that caused `guix system reconfigure` to hang in certain situations. Fix proposed by @emixa-d at: https://github.com/wingo/fibers/issues/29#issuecomment-1858922276. --- modules/shepherd.scm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/modules/shepherd.scm b/modules/shepherd.scm index efc5517..3303de3 100644 --- a/modules/shepherd.scm +++ b/modules/shepherd.scm @@ -450,13 +450,13 @@ fork in the child process." ;; because POSIX threads and 'fork' cannot be used together. (run-fibers (lambda () - (with-service-registry + (with-process-monitor + (with-service-registry - ;; Register and start the 'root' service. - (register-services (list root-service)) - (start-service root-service) + ;; Register and start the 'root' service. + (register-services (list root-service)) + (start-service root-service) - (with-process-monitor ;; Replace the default 'system*' binding with one that ;; cooperates instead of blocking on 'waitpid'. Replace ;; 'primitive-load' (in C as of 3.0.9) with one that does -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 16 19:45:04 2023 Received: (at 67839) by debbugs.gnu.org; 17 Dec 2023 00:45:04 +0000 Received: from localhost ([127.0.0.1]:56381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEfHD-0006b4-TB for submit@debbugs.gnu.org; Sat, 16 Dec 2023 19:45:04 -0500 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:54684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEfH8-0006Sj-6G for 67839@debbugs.gnu.org; Sat, 16 Dec 2023 19:44:59 -0500 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-552e5d0bee4so1459043a12.1 for <67839@debbugs.gnu.org>; Sat, 16 Dec 2023 16:44:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702773891; x=1703378691; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s5Mg/c4eypqbbjxhRJjH4V2CQgASghFd8RY2vK7nqvc=; b=SMb1s057xwPdxhaulCVC6y1GGnqzH86V9Z2XZoil7ShNiy3rZt5AodR1FwOgJIQl7I J407hYBWLxWcazDwF6d3dBfB6wZrFCaeeqSq5yPy7xpksRxbbz4uIr3vaQa6XCb2jKVL G9W8RE6M8p0ZDQgErBtVahHViLwpTJ9bYG5ZuAuV/yg2pfw+Wg2cRy9jyDu5ptaNKQVg HqmIGaeanAcZvxd0+OlJA+K7CnOJHfFVh2zhu4CSzmhBnRTSrZmFeE7qDWLp1y5L2Ee4 MLb6T2WVAdpZABK3P3Dh4cly2Tye84lrQ4K7SCxR1mMOZE+d4jQycwkSsfPvOd6sOLQt y+Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702773891; x=1703378691; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s5Mg/c4eypqbbjxhRJjH4V2CQgASghFd8RY2vK7nqvc=; b=rrqR6Y06MygLQjGkH5mnnCjnQf9IpHJ+1A+8zl9fNYE7hcT/L0R27MsC6Gc9NqsSIg pTfdv+6BcwPM3WIUxS11upMqgau4JWf0XXE4JhP1mx/ZxSDI4SkHoAveUurbFKqJiFwh SnkMQj64vtepS0K18gpJZetaW4vRqwbkmwlfDT42k7/hJ1912agSxkxe0YYgDSetzg1X IWdFIX5jFi6jjYItUucJup5OSWbpJdU7oGGRY0Qkl0/b+Px8cHKFBEV8Rmcs6Fbppt7J TJ6SDi8ftQ+HxI7AaEA5z2lr1nTEQCF/6QjyUi9WQEu2YODJis9qDwgs4tBete0gEPwc noJA== X-Gm-Message-State: AOJu0Yy1JHyooTTkYCndiPlQX3VRDtRAXFPoZDT4NaFzq7wXDFrCFJYi k16X4dQan1FkQ9X8LVrCTKF8gxRbAIbJeA== X-Google-Smtp-Source: AGHT+IHIE+wm1uvfAUHRGr3awQ7MWtagZYJmcxTqtE2E2Lo+dTFY8rFog04jOzmqbQ5F75aWD8IImA== X-Received: by 2002:a50:85ca:0:b0:551:14c0:7325 with SMTP id q10-20020a5085ca000000b0055114c07325mr5864079edh.40.1702773891376; Sat, 16 Dec 2023 16:44:51 -0800 (PST) Received: from lelap.lan (2a00-1f40-b161-900-9180-9bd5-ff71-193b.pool6.panelnet.hu. [2a00:1f40:b161:900:9180:9bd5:ff71:193b]) by smtp.gmail.com with ESMTPSA id t16-20020a056402241000b00552743342c8sm2960258eda.59.2023.12.16.16.44.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Dec 2023 16:44:51 -0800 (PST) From: Attila Lendvai X-Google-Original-From: Attila Lendvai To: 67839@debbugs.gnu.org Subject: [PATCH v2 2/2] service: Add asserts that used to make tests/replacement.sh fail. Date: Sun, 17 Dec 2023 01:44:25 +0100 Message-ID: <20231217004424.28303-3-attila@lendvai.name> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231217004424.28303-2-attila@lendvai.name> References: <20231217004424.28303-2-attila@lendvai.name> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67839 Cc: Attila Lendvai X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * modules/shepherd/service.scm (spawn-service-controller): Add two asserts. This is the bug that causes `guix system reconfigure ...` to sometimes hang, and subsequently all shepherd commands, because a match-error flies out from the service-controller of a replaced service, and thus its fiber dies. These asserts get triggered without the previous commit that fixes the issue. --- modules/shepherd/service.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/modules/shepherd/service.scm b/modules/shepherd/service.scm index c3bdf44..0ee6929 100644 --- a/modules/shepherd/service.scm +++ b/modules/shepherd/service.scm @@ -382,9 +382,11 @@ denoting what the service provides." (define (spawn-service-controller service) "Return a channel over which @var{service} may be controlled." + (assert (current-process-monitor)) (let ((channel (make-channel))) (spawn-fiber (lambda () + (assert (current-process-monitor)) ;; The controller writes to its current output port via 'local-output'. ;; Make sure that goes to the right port. If the controller got a ;; wrong output port, it could crash and stop responding just because a -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 17 17:00:13 2023 Received: (at 67839) by debbugs.gnu.org; 17 Dec 2023 22:00:13 +0000 Received: from localhost ([127.0.0.1]:59090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEzBE-0003K0-QL for submit@debbugs.gnu.org; Sun, 17 Dec 2023 17:00:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEzBD-0002t9-1N for 67839@debbugs.gnu.org; Sun, 17 Dec 2023 17:00:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEzB5-00022G-HN; Sun, 17 Dec 2023 17:00:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=HBwFZUY5o/iG2JGwxSO59sQjZPsJ/2Fp2Uns1jZL7+w=; b=axU8le1xwPXmaNIqWspq YaDgbMp3B4uB3GZCaOIhtwcHx4pYkV8uAzi1rHbWfscyWWuJuxgRQwje9xKG6jlWDk6Oa9CSlGm0E bCYIJN3KdX/yrc/ngzFe9JfBLRQKGirxH2TrpipMbnJ2ra7nfcV3YHjv3NUfOJ4eJxnDqyYwUr7nI CnzKNGf1R0LSD6M2eJcIMtYNg8p+TdaOE3FGwVoeIUTz+nHK/2ATDSZ261vbl5cmQEWzmW7Miy9nc 0nYYndfSeXWdpTZzf34v6IzlsOI3XRAh4sjZ2+PxSs3E9PfjkjN/BO7C09A4WUXjAk9DrfKdaQ8Q5 +ef5Fmn7sm8EeQ==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Attila Lendvai Subject: Re: bug#67839: shepherd: sometimes hangs on `guix system reconfigure` In-Reply-To: <20231217004424.28303-2-attila@lendvai.name> (Attila Lendvai's message of "Sun, 17 Dec 2023 01:44:24 +0100") References: <20231217004424.28303-2-attila@lendvai.name> Date: Sun, 17 Dec 2023 22:59:59 +0100 Message-ID: <87sf40qylc.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67839 Cc: Attila Lendvai , 67839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Attila, Attila Lendvai skribis: > * modules/shepherd.scm (main): Switch with-service-registry and > with-process-monitor. This way the parameterize of the process monitor c= overs > everything else. This fixes the bug that caused `guix system reconfigure= ` to > hang in certain situations. Fix proposed by @emixa-d at: > https://github.com/wingo/fibers/issues/29#issuecomment-1858922276. [...] > * modules/shepherd/service.scm (spawn-service-controller): Add two assert= s. > This is the bug that causes `guix system reconfigure ...` to sometimes ha= ng, > and subsequently all shepherd commands, because a match-error flies out f= rom > the service-controller of a replaced service, and thus its fiber dies. T= hese > asserts get triggered without the previous commit that fixes the issue. Good catch!! I pushed these patches with small edits, in particular adding a test that reproduces the bug without relying on assertion failures: 5dbde1c support: =E2=80=98assert=E2=80=99 logs source location informatio= n. 0bcf02a Update NEWS. c07f0a8 service: Add asserts to ensure a process monitor is running. 9be0b7e shepherd: Make sure =E2=80=98with-process-monitor=E2=80=99 covers= everything needed. Thanks for the tedious but fruitful debugging work! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 17 17:00:59 2023 Received: (at control) by debbugs.gnu.org; 17 Dec 2023 22:00:59 +0000 Received: from localhost ([127.0.0.1]:59096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEzBz-0004zN-6x for submit@debbugs.gnu.org; Sun, 17 Dec 2023 17:00:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEzBx-0004mv-BW for control@debbugs.gnu.org; Sun, 17 Dec 2023 17:00:57 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEzBq-0002KN-BD for control@debbugs.gnu.org; Sun, 17 Dec 2023 17:00:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=FhlJiG3PqB/B4ZaVT2/lDEWk5q4zHFlSFZheJ4Vfiu0=; b=p9MyVTJb78vMVN tV2vQ61MQCzNCGYLTkuwW0DF2NPmcVYKsMLv8mVYG0iLyj4NiLhXRwTp5ahJZSVQ0z7DSf1dwaSEr 5x+lwGKUkx1fNA//NqiRvBcvdVQ6jbit30Zr7CaRYrai0TC8maTZJnKCvnmN1xlcF+9ujxxlQP7Bp 9KluCalb4UeGbifo5e904+hACCLWaIMKtn0E/wvwZ+Nx28emYLXULXmhkdKwbQ/cGbA5iTpET2B4u u1kbO9J22ZZl6Ld5oaz+/8bkWf/QVuwoO4YhjEKy1fqrhuFFb085rldKh/JrSmz7FamMgz3piVcR3 6Z0Tc4wsAOgmVtZyA8PA==; Date: Sun, 17 Dec 2023 23:00:08 +0100 Message-Id: <87r0jkqyl3.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #67839 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 67839 quit From unknown Sat Aug 09 13:06:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 15 Jan 2024 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator