From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 15 08:31:04 2023 Received: (at submit) by debbugs.gnu.org; 15 Dec 2023 13:31:04 +0000 Received: from localhost ([127.0.0.1]:51756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rE8HP-0006JM-A1 for submit@debbugs.gnu.org; Fri, 15 Dec 2023 08:31:03 -0500 Received: from lists.gnu.org ([2001:470:142::17]:58512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rE5hA-0005jN-Lc for submit@debbugs.gnu.org; Fri, 15 Dec 2023 05:45:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rE5h3-0007hM-I7 for bug-gnu-emacs@gnu.org; Fri, 15 Dec 2023 05:45:22 -0500 Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rE5h1-0004uX-Kf for bug-gnu-emacs@gnu.org; Fri, 15 Dec 2023 05:45:21 -0500 Received: by mail-oi1-x22d.google.com with SMTP id 5614622812f47-3b9e07690ccso423545b6e.3 for ; Fri, 15 Dec 2023 02:45:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702637117; x=1703241917; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:subject:to:from :message-id:date:from:to:cc:subject:date:message-id:reply-to; bh=e96o67tvT6+hSdunDi9mH/w4BqAQtimuMiJlUuLwxsY=; b=IuAykWtGJirWHtUzf5+sgsknvaBCBoot4UhO5nyYphDutAeRSU186wK0hHpBn+1TzO Qvn6j+aKZOfFiIZa0uH2D5PCXlW3yMax4bg4T/HnuEq9GsAxYWEvObK9S3CCmF28lrdd AAztHflURWgmuKx14JYNOe5DFeJi6Re6CsetgtRigzaMgcf8SelON0+65iNy/aPWTAGM AIAGD7xe0aXdVRgbQEFCopMZa5Fab1XOq31J1Kbo1Am/r7c4D57RtcXfkLpePC6DA+mY E6uKQlltqomu51T52vsvuzvGaEthRlqmRegAJgu6dzMozkLKlvqFvIGTkE+L1+iH6SHY Xl5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702637117; x=1703241917; h=content-transfer-encoding:mime-version:user-agent:subject:to:from :message-id:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e96o67tvT6+hSdunDi9mH/w4BqAQtimuMiJlUuLwxsY=; b=BRKowjwQkIXhqh1QSjvzeJoEu06S542lZTvvs2C/t3pPnpE/1leNThMH8Ox+9ygSDy 9+Eay1IiIfqHf6PZ9P68mgWAvRyU8ERTJ/D2JYdtUo60x/Mc2NAVB5rI7vYR4jBOyuDk hMxXfkqnLUuhQMHeoDt2fRPUnF6dp5ocfLEF3CyWIDux2EMAF3jCtUoqdZk0iWevDQt/ wRg7Vy1maLxgEDa0bIdxftWhKsY+Y4o/qFC7EFJdhK4u8LGOeTa9Qv1MpGAYPDcDYB7C 5lzlkBBG050KMU83n3LscDRpsRVTj19NV4SlqFx8eEciVEjLxT6868aIXJtgBgTGlTdE lR/g== X-Gm-Message-State: AOJu0YzIlNnrF0smUj90aEe0Kz/Pz/Xuqvzsy6MTjj1YMLzPmJWWu70h XIKmbKUflfbF6qYx5oxPfF9G+KKnemI= X-Google-Smtp-Source: AGHT+IEz+cChComL+CoIhhH2fOfSXK1g2WGora5x0ey1A8U0ezRz/4fPPZXBftX/7SqkfmHbFM0xiQ== X-Received: by 2002:a05:6808:2f10:b0:3b9:de62:2baa with SMTP id gu16-20020a0568082f1000b003b9de622baamr15273914oib.20.1702637116754; Fri, 15 Dec 2023 02:45:16 -0800 (PST) Received: from host.i ([2409:10:c880:6010:f20:f14e:3ed4:186f]) by smtp.gmail.com with ESMTPSA id fa11-20020a056a002d0b00b006cb95c0fff4sm13260577pfb.71.2023.12.15.02.45.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 02:45:16 -0800 (PST) Date: Fri, 15 Dec 2023 19:45:13 +0900 Message-ID: <87bkarn3ra.wl@id.domain> From: kakkokakko@gmail.com To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Error with undocumented disabled commands User-Agent: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.1 Mule/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::22d; envelope-from=kakkokakko@gmail.com; helo=mail-oi1-x22d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 15 Dec 2023 08:31:02 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 1. emacs -Q --eval "(progn (defun foo () (interactive)) (put 'foo 'disabled= t))" 2. M-x foo RET Then, I encountered the error message "Wrong type argument: char-or-string-p, nil". This behavior is different from that in previous versions, like 27.1, where I received the following message. | You have invoked the disabled command foo. | It is disabled because new users often find it confusing. | Here=A2s the first part of its description: |=20 | << not documented >> | ... I also expect similar behavior in 30.0.50. In 30.0.50, it appears that disabled-command-function in novice.el triggers this error by executing (insert nil) for undocumented commands in the following code. | (insert (condition-case () | (documentation cmd) | (error "<< not documented >>"))) Although omitting a docstring is generally considered poor practice, triggering an error for such commands might not be intentional behavior. The corresponding code in 27.1 was as follows: | (... (or (condition-case () | (documentation cmd) | (error nil)) | "<< not documented >>")) --=20 KH From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 16 08:11:52 2023 Received: (at 67835) by debbugs.gnu.org; 16 Dec 2023 13:11:52 +0000 Received: from localhost ([127.0.0.1]:54207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEUSO-0001t1-0h for submit@debbugs.gnu.org; Sat, 16 Dec 2023 08:11:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEUSL-0001sj-9B for 67835@debbugs.gnu.org; Sat, 16 Dec 2023 08:11:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEUSE-0008VT-Ck; Sat, 16 Dec 2023 08:11:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=i+SBya0XNbrq0E5ySiZgT4bj8ZGyGo69t9gW1hLDoiE=; b=Ys9Ob9N69VjJCAt71m1D g3ZVSwlZHPfz3q5sLBzJRCo1TpJ/a6UjZPqS2MmxW4NHm3jd4OEfbfolIo49cDKpaVW15ca5+W+Xr Fmrl2b62WVvOk/Uw0S2zyYehrBqSGmFR/qbqH6bTjCh1SlppTYq9f4AQlRU1/vyBeLMEMRjf/cObV yBi/8MRqsYppOxEtYYtX9jEfqRlyNw3Wx0R7cjxBlrEctZ7zV9hXzp66lK/FauQcowCwLPjN2jsyp sFQkTBeaLaYLGZpvisQERDQl4m9qPvlYSr0d3diCLEBdUY9+/thWJ8sgvuE8s+srTLt1y0glKy9ve Dh+txut1px/trw==; Date: Sat, 16 Dec 2023 15:11:24 +0200 Message-Id: <83cyv6mgw3.fsf@gnu.org> From: Eli Zaretskii To: kakkokakko@gmail.com, Stefan Kangas In-Reply-To: <87bkarn3ra.wl@id.domain> (kakkokakko@gmail.com) Subject: Re: bug#67835: 30.0.50; Error with undocumented disabled commands References: <87bkarn3ra.wl@id.domain> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-7 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67835 Cc: 67835@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 15 Dec 2023 19:45:13 +0900 > From: kakkokakko@gmail.com > > 1. emacs -Q --eval "(progn (defun foo () (interactive)) (put 'foo 'disabled t))" > 2. M-x foo RET > > Then, I encountered the error message "Wrong type argument: > char-or-string-p, nil". This behavior is different from that in > previous versions, like 27.1, where I received the following message. > > | You have invoked the disabled command foo. > | It is disabled because new users often find it confusing. > | Here¢s the first part of its description: > | > | << not documented >> > | ... > > I also expect similar behavior in 30.0.50. > > In 30.0.50, it appears that disabled-command-function in > novice.el triggers this error by executing (insert nil) for > undocumented commands in the following code. > > | (insert (condition-case () > | (documentation cmd) > | (error "<< not documented >>"))) > > Although omitting a docstring is generally considered poor practice, > triggering an error for such commands might not be intentional > behavior. The corresponding code in 27.1 was as follows: > > | (... (or (condition-case () > | (documentation cmd) > | (error nil)) > | "<< not documented >>")) Stefan, could you please look into this? The above seems to come from your changes in commit 6ad79059d2f843a1be617c72ae0e9d8a02c9a203. I'd like to fix this on the emacs-29 branch soon, if possible. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 16 14:37:25 2023 Received: (at 67835-done) by debbugs.gnu.org; 16 Dec 2023 19:37:26 +0000 Received: from localhost ([127.0.0.1]:56086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEaTV-0004uR-Jn for submit@debbugs.gnu.org; Sat, 16 Dec 2023 14:37:25 -0500 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:51383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEaTQ-0004u7-Nr for 67835-done@debbugs.gnu.org; Sat, 16 Dec 2023 14:37:24 -0500 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-54c77e0835bso2117323a12.2 for <67835-done@debbugs.gnu.org>; Sat, 16 Dec 2023 11:37:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702755434; x=1703360234; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=Pn6K/TsQWkoQwh4kpzeNFP+hRJDnCTE/348ZtqGtcP0=; b=lQlP0jO1tG4D/SihIjNduEWbYU9HwRcHfOgcvwq2FT+eRZPwFeDS9xnyPoROfXOrlt B6bhRU0hw2+W+097CZpKzh4kKLMQq101nlH/PcZMENJf6IiGaGHPTP/u3kT8kcYnQlTm 8Tv/yY5C85K95V0QT0ETqI71OCK/OPG/DLsRcCnj1Ms+3t2TaXa2hSKosOfkezF0c4bJ m9Fp/2xEjb9O8Yie6OHqbaib8R997r2y9KSAeP0PTp62g9j+hbx7ph4RFwa9r0gLcua4 9mxnDuplG4eBXpoRz3zOE0PBqiLpc+/30fkSQLhzSkzvnHS8utRinPmolV0ALn8UaA3v v6Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702755434; x=1703360234; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Pn6K/TsQWkoQwh4kpzeNFP+hRJDnCTE/348ZtqGtcP0=; b=LtNhgm7Lh9YHQHpPU28upOG2BvotcdLkWq6kjiw+RRuXXYf8R20hw6kVzlTivEs79q gwuOAnM3/ZDseWO+a62Ljxxm2ZfTgttw1FMs2CNOCudw9n3wa0WNOBP5NMRDfBFIz6vC jmnAYZCWBQ5m0l3B9IDitR8hLw2IZGghBrmU43PGV+/EyAbNs0SGE/YMZKjPuABL5t6M xxO5FrQea2Th1j+kAo8jiyu9pB6EzjLbo9buC5NT2VnEpQ/+Ur6vK4HIjWQSKASGbNoz mvjKXAXHDY33dq0p9xYnyP1tJawrbjJIb7+jfoDBE2IhUSN67W044NTczkwvaxFMqQd3 dO7g== X-Gm-Message-State: AOJu0YxninxG70JUIZUfsnc4BBbxVex5epEE8WeWMpIlSFWo0skTr1+0 oJDMYnuDfE/M58iLhBpS9kMPbTznMVPexzmB7xw= X-Google-Smtp-Source: AGHT+IH4q6fHdI+1DhohJXUacCuaLb7vdoVtOEVTQylZmTX/RoWLdZ2H7jxyZxg2ss0XAJLJ1bb+nV1UQw+AptnHzH8= X-Received: by 2002:a50:d787:0:b0:551:ab9e:53c6 with SMTP id w7-20020a50d787000000b00551ab9e53c6mr4847364edi.52.1702755434083; Sat, 16 Dec 2023 11:37:14 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 16 Dec 2023 11:37:13 -0800 From: Stefan Kangas In-Reply-To: <83cyv6mgw3.fsf@gnu.org> References: <87bkarn3ra.wl@id.domain> <83cyv6mgw3.fsf@gnu.org> MIME-Version: 1.0 Date: Sat, 16 Dec 2023 11:37:13 -0800 Message-ID: Subject: Re: bug#67835: 30.0.50; Error with undocumented disabled commands To: Eli Zaretskii , kakkokakko@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 67835-done Cc: 67835-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 29.2 Eli Zaretskii writes: >> Date: Fri, 15 Dec 2023 19:45:13 +0900 >> From: kakkokakko@gmail.com >> >> 1. emacs -Q --eval "(progn (defun foo () (interactive)) (put 'foo 'disab= led t))" >> 2. M-x foo RET >> >> Then, I encountered the error message "Wrong type argument: >> char-or-string-p, nil". This behavior is different from that in >> previous versions, like 27.1, where I received the following message. >> >> | You have invoked the disabled command foo. >> | It is disabled because new users often find it confusing. >> | Here=E2=80=99s the first part of its description: >> | >> | << not documented >> >> | ... >> >> I also expect similar behavior in 30.0.50. >> >> In 30.0.50, it appears that disabled-command-function in >> novice.el triggers this error by executing (insert nil) for >> undocumented commands in the following code. >> >> | (insert (condition-case () >> | (documentation cmd) >> | (error "<< not documented >>"))) >> >> Although omitting a docstring is generally considered poor practice, >> triggering an error for such commands might not be intentional >> behavior. The corresponding code in 27.1 was as follows: >> >> | (... (or (condition-case () >> | (documentation cmd) >> | (error nil)) >> | "<< not documented >>")) Thanks for the bug report! This should now be fixed on emacs-29. From unknown Sat Jun 21 03:19:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 14 Jan 2024 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator