Subject: bug#67822: closed (Re: [bug#67822] [PATCH v4] gnu: maths: petsc: Reduce closure size.)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 27 Feb 2024 09:52:02 +0000

Your bug report

#67822: [PATCH] gnu: maths: petsc: Reduce closure size.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
67822: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67822
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#67822] [PATCH v4] gnu: maths: petsc: Reduce closure size.
From: Ludovic Courtès <[email-masked]>
To: Lars Bilke <[email-masked]>
Cc: [email-masked], Andreas Enge <[email-masked]>, Efraim Flashner <[email-masked]>, Eric Bavier <[email-masked]>
Date: Tue, 27 Feb 2024 10:50:33 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Lars Bilke <[email-masked]> skribis:

> Reduces closure size by around 350 MB by removing refernces to build
> dependencies (e.g. gcc).
>
> New ion v4:
>
> Used proposed :graph: syntax.
> Also removed gfortran reference.
>
> Change-Id: I2e6900747b2118546f0a39ceb109b3f2f90e6949

[...]

> +                (("([[:graph:]]+)/bin/sed") "sed")
> +                (("([[:graph:]]+)/bin/gfortran") "gfortran")
> +                ))))

I move those lonely parens to the previous line, tweaked the commit log,
and applied it.  Thank you!

Ludo’.

Subject: [PATCH] gnu: maths: petsc: Reduce closure size.
From: Lars Bilke <[email-masked]>
To: [email-masked]
Cc: Lars Bilke <[email-masked]>
Date: Thu, 14 Dec 2023 13:56:08 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Reduces closure size by around 350 MB.

May break CMake-based projects which use the following script:

https://github.com/jedbrown/cmake-modules/blob/master/FindPETSc.cmake

Use pkg-config based finding instead. See
https://github.com/jedbrown/cmake-modules/blob/master/README.md.

Change-Id: I2e6900747b2118546f0a39ceb109b3f2f90e6949
---
 gnu/packages/maths.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 0f4d29b40f..7f3e80efa4 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -3484,6 +3484,8 @@ (define-public petsc
                           '("configure.log" "make.log" "gmake.log"
                             "test.log" "error.log" "RDict.db"
                             "PETScBuildInternal.cmake"
+                            "petscvariables"
+                            "configure-hash"
                             ;; Once installed, should uninstall with Guix
                             "uninstall.py")))))
           (add-after 'install 'move-examples

base-commit: ac61e9705fb8c450c6cd0c1731fbb1b909c1f944
-- 
2.43.0