GNU bug report logs - #67812
[PATCH] gnu: skalibs: Correct symlink permissions on the hurd.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#67812: closed ([PATCH] gnu: skalibs: Correct symlink
 permissions on the hurd.)
Date: Fri, 22 Dec 2023 17:39:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 22 Dec 2023 17:37:35 +0000
with message-id <87sf3uw32a.fsf <at> cbaines.net>
and subject line Re: [bug#67812] [PATCH] gnu: skalibs: Correct symlink permissions on the hurd.
has caused the debbugs.gnu.org bug report #67812,
regarding [PATCH] gnu: skalibs: Correct symlink permissions on the hurd.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
67812: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67812
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: skalibs: Correct symlink permissions on the hurd.
Date: Wed, 13 Dec 2023 13:01:37 +0000

* gnu/packages/skarnet.scm (skalibs)[arguments]: Patch tools/install.sh umask.

Change-Id: Ia431a06d6150b33562dcf0f57eb3ba0fd84ba864
---
 gnu/packages/skarnet.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/skarnet.scm b/gnu/packages/skarnet.scm
index 6781e2eb58..eef4e6b6f9 100644
--- a/gnu/packages/skarnet.scm
+++ b/gnu/packages/skarnet.scm
@@ -42,8 +42,12 @@ (define-public skalibs
     (arguments
      '(#:tests? #f                      ; no tests exist
        #:phases (modify-phases %standard-phases
-                  (add-after 'unpack 'reproducible
+                  (add-after 'unpack 'patch
                     (lambda _
+                      ;; This umask makes the symlinks in lib readable on
+                      ;; i586-gnu
+                      (substitute* "tools/install.sh"
+                        (("umask 077") "umask 033"))
                       ;; Sort source files deterministically so that the *.a
                       ;; and *.so files are reproducible.
                       (substitute* "Makefile"

base-commit: 5f812344d293e5faaca44eeaab3b889fa6cb7e33
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: 67812-done <at> debbugs.gnu.org
Subject: Re: [bug#67812] [PATCH] gnu: skalibs: Correct symlink permissions
 on the hurd.
Date: Fri, 22 Dec 2023 17:37:35 +0000

[Message part 4 (text/plain, inline)]

Christopher Baines <mail <at> cbaines.net> writes:

> * gnu/packages/skarnet.scm (skalibs)[arguments]: Patch tools/install.sh umask.
>
> Change-Id: Ia431a06d6150b33562dcf0f57eb3ba0fd84ba864
> ---
>  gnu/packages/skarnet.scm | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/skarnet.scm b/gnu/packages/skarnet.scm
> index 6781e2eb58..eef4e6b6f9 100644
> --- a/gnu/packages/skarnet.scm
> +++ b/gnu/packages/skarnet.scm
> @@ -42,8 +42,12 @@ (define-public skalibs
>      (arguments
>       '(#:tests? #f                      ; no tests exist
>         #:phases (modify-phases %standard-phases
> -                  (add-after 'unpack 'reproducible
> +                  (add-after 'unpack 'patch
>                      (lambda _
> +                      ;; This umask makes the symlinks in lib readable on
> +                      ;; i586-gnu
> +                      (substitute* "tools/install.sh"
> +                        (("umask 077") "umask 033"))
>                        ;; Sort source files deterministically so that the *.a
>                        ;; and *.so files are reproducible.
>                        (substitute* "Makefile"
>
> base-commit: 5f812344d293e5faaca44eeaab3b889fa6cb7e33

Pushed to master as f18f59fa4b249bbde6290ac5b91f6cd524b60848.

I also restored i586-gnu in the supported-systems.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.