Subject: bug#67812: closed (Re: [bug#67812] [PATCH] gnu: skalibs: Correct symlink permissions on the hurd.)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 22 Dec 2023 17:39:02 +0000

Your bug report

#67812: [PATCH] gnu: skalibs: Correct symlink permissions on the hurd.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
67812: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67812
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#67812] [PATCH] gnu: skalibs: Correct symlink permissions on the hurd.
From: Christopher Baines <[email-masked]>
To: [email-masked]
Date: Fri, 22 Dec 2023 17:37:35 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Christopher Baines <[email-masked]> writes:

> * gnu/packages/skarnet.scm (skalibs)[arguments]: Patch tools/install.sh umask.
>
> Change-Id: Ia431a06d6150b33562dcf0f57eb3ba0fd84ba864
> ---
>  gnu/packages/skarnet.scm | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/skarnet.scm b/gnu/packages/skarnet.scm
> index 6781e2eb58..eef4e6b6f9 100644
> --- a/gnu/packages/skarnet.scm
> +++ b/gnu/packages/skarnet.scm
> @@ -42,8 +42,12 @@ (define-public skalibs
>      (arguments
>       '(#:tests? #f                      ; no tests exist
>         #:phases (modify-phases %standard-phases
> -                  (add-after 'unpack 'reproducible
> +                  (add-after 'unpack 'patch
>                      (lambda _
> +                      ;; This umask makes the symlinks in lib readable on
> +                      ;; i586-gnu
> +                      (substitute* "tools/install.sh"
> +                        (("umask 077") "umask 033"))
>                        ;; Sort source files deterministically so that the *.a
>                        ;; and *.so files are reproducible.
>                        (substitute* "Makefile"
>
> base-commit: 5f812344d293e5faaca44eeaab3b889fa6cb7e33

Pushed to master as f18f59fa4b249bbde6290ac5b91f6cd524b60848.

I also restored i586-gnu in the supported-systems.

Subject: [PATCH] gnu: skalibs: Correct symlink permissions on the hurd.
From: Christopher Baines <[email-masked]>
To: [email-masked]
Date: Wed, 13 Dec 2023 13:01:37 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/skarnet.scm (skalibs)[arguments]: Patch tools/install.sh umask.

Change-Id: Ia431a06d6150b33562dcf0f57eb3ba0fd84ba864
---
 gnu/packages/skarnet.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/skarnet.scm b/gnu/packages/skarnet.scm
index 6781e2eb58..eef4e6b6f9 100644
--- a/gnu/packages/skarnet.scm
+++ b/gnu/packages/skarnet.scm
@@ -42,8 +42,12 @@ (define-public skalibs
     (arguments
      '(#:tests? #f                      ; no tests exist
        #:phases (modify-phases %standard-phases
-                  (add-after 'unpack 'reproducible
+                  (add-after 'unpack 'patch
                     (lambda _
+                      ;; This umask makes the symlinks in lib readable on
+                      ;; i586-gnu
+                      (substitute* "tools/install.sh"
+                        (("umask 077") "umask 033"))
                       ;; Sort source files deterministically so that the *.a
                       ;; and *.so files are reproducible.
                       (substitute* "Makefile"

base-commit: 5f812344d293e5faaca44eeaab3b889fa6cb7e33
-- 
2.41.0