GNU bug report logs - #67795
[PATCH] Handle local-variable major-mode remaps specifying non-existent mode

Previous Next

Package: emacs;

Reported by: Brian Leung <leungbk <at> posteo.net>

Date: Tue, 12 Dec 2023 13:54:02 UTC

Severity: normal

Tags: patch

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#67795: closed ([PATCH] Handle local-variable major-mode
 remaps specifying non-existent mode)
Date: Fri, 15 Mar 2024 02:19:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Thu, 14 Mar 2024 22:17:37 -0400
with message-id <jwv7ci4kzok.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#67795: [PATCH] Handle local-variable major-mode remaps specifying non-existent mode
has caused the debbugs.gnu.org bug report #67795,
regarding [PATCH] Handle local-variable major-mode remaps specifying non-existent mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
67795: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67795
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Brian Leung <leungbk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Handle local-variable major-mode remaps specifying
 non-existent mode
Date: Tue, 12 Dec 2023 13:52:53 +0000
[Message part 3 (text/plain, inline)]
Tags: patch





In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, 
cairo
version 1.18.0, Xaw3d scroll bars)
Repository revision: 9434ad25ce2747864e0bcf5665f65eb65a079178
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 
11.0.12101009
System Description: NixOS 24.05 (Uakari)

Configured using:
'configure
--prefix=/nix/store/q131p42vldq964fr9rpdz1qmsqrywa00-emacs-git-20231211.0
--disable-build-details --with-modules --with-x-toolkit=lucid
--with-xft --with-cairo --with-compress-install
--with-toolkit-scroll-bars --with-native-compilation
--without-imagemagick --without-small-ja-dic --with-tree-sitter
--without-xinput2 --without-xwidgets'
[0001-Handle-local-variable-major-mode-remaps-specifying-n.patch (text/patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Brian Leung <leungbk <at> posteo.net>
Cc: 67795-done <at> debbugs.gnu.org
Subject: Re: bug#67795: [PATCH] Handle local-variable major-mode remaps
 specifying non-existent mode
Date: Thu, 14 Mar 2024 22:17:37 -0400
> The patch below should be much more than just a "good start", because
> I think I got to understand the code this time around :-)
> The previous code worked OK but was inconsistent in its handling of
> modes that we don't have (i.e. is non-existent).

Pushed to `master`.  I think we can close this.
Thanks Brian for the initial patch.  It was very helpful.


        Stefan



This bug report was last modified 1 year and 63 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.