Subject: Re: bug#67767: 30.0.50; ERC 5.6: Add track integration to the nicks module

From: "J.P." <[email-masked]>
Date: Fri, 04 Oct 2024 18:40:25 -0700

"J.P." <[email-masked]> writes:

> +(defun erc-nicks--track-always (current contender contenders ranks normals)
> +  "Return a viable `nicks' face, possibly CURRENT, among CONTENDERS.
> +See `erc-track--select-mode-line-face' for parameter types."
> +  (when-let
> +      ((spkr (erc-nicks--assess-track-faces current contender ranks normals)))
> +    (catch 'contender
> +      (dolist (candidate (cdr (reverse contenders)))
                             ~~~~~~~~~~~~~~~~~~~~~~~

That should be

         (dolist (candidate (reverse (cdr contenders)))

Also, `spkr' is unused.

> +        (when (erc-nicks--ours-p candidate)
> +          (cl-assert (gethash candidate normals))
>            (throw 'contender candidate))))))
>  
>  (defun erc-nicks--setup-track-integration ()