GNU bug report logs - #67764
30.0.50; Opening image in eww no longer works

Previous Next

Full log

Message #23 received at 67764 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: 67764 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, jm <at> pub.pink
Subject: Re: bug#67764: 30.0.50; Opening image in eww no longer works
Date: Tue, 12 Dec 2023 14:44:12 +0530

[Message part 1 (text/plain, inline)]

[Tuesday December 12, 2023] Manuel Giraud wrote:

> Visuwesh <visuweshm <at> gmail.com> writes:
>
> [...]
>
>> diff --git a/lisp/net/shr.el b/lisp/net/shr.el
>> index 9f030b4c743..bf5038a421d 100644
>> --- a/lisp/net/shr.el
>> +++ b/lisp/net/shr.el
>> @@ -1137,7 +1137,9 @@ shr-put-image
>>          (when image
>>            ;; The trailing space can confuse shr-insert into not
>>            ;; putting any space after inline images.
>> -	  (setq alt (string-trim alt))
>> +          ;; ALT may be nil when visiting image URLs in eww
>> +          ;; (bug#6774).
>
> There is a 6 missing in the bug reference ;-)

...and in the commit log.  I don't know how I managed to mess it up.
Thanks for catching the mistake.  Revised patch attached.

[0001-Fix-shr-put-image-with-nil-value-for-ALT.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.