From unknown Sun Jun 22 07:59:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67764: 30.0.50; Opening image in eww no longer works Resent-From: john muhl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Dec 2023 06:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 67764 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 67764@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.170227681119279 (code B ref -1); Mon, 11 Dec 2023 06:41:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Dec 2023 06:40:11 +0000 Received: from localhost ([127.0.0.1]:52289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCZxb-00050s-4d for submit@debbugs.gnu.org; Mon, 11 Dec 2023 01:40:11 -0500 Received: from lists.gnu.org ([2001:470:142::17]:56740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCZxY-00050f-9n for submit@debbugs.gnu.org; Mon, 11 Dec 2023 01:40:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCZxD-0007bS-S1 for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 01:39:48 -0500 Received: from out-174.mta0.migadu.com ([2001:41d0:1004:224b::ae]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCZxB-0006Bn-Ac for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 01:39:47 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; s=key1; t=1702276780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=XW5+HmLwvtFr3l9ucsihO/1O1YMsVmNYanuBiNrfwsA=; b=E7Io1TU2EQ8ANmezdeYXe4tzomY0SmuaznuLNfQcRwCEwqm/+OG8/NjbxHmTqmn34sQ1Do uiW8+55Pul2bCtc+IxKXF5sB9ltw5RUKYX0CHdTQ8GGaVxkCONMgiprv+Qc0mKt3G2prwe LC2ckfqijLbVgpGoaq7s8i8TJqeDtNo= From: john muhl Date: Mon, 11 Dec 2023 00:26:41 -0600 Message-ID: <87msuhfdjr.fsf@pub.pink> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:1004:224b::ae; envelope-from=jm@pub.pink; helo=out-174.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) In Emacs 29.1 the image opens as expected: emacs -Q M-: (eww "https://www.gnu.org/software/emacs/images/emacs.png") On master it fails with "Wrong type argument: stringp, nil". Bisect says 4254544 is the first bad commit. In GNU Emacs 30.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.18.0) of 2023-12-11 built on localhost Repository revision: cd702556759b33662cd6536c89ef02ddcd93d4ff Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12302002 System Description: Fedora Linux 39 (Thirty Nine) Configured using: 'configure --with-native-compilation=no' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB From unknown Sun Jun 22 07:59:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67764: 30.0.50; Opening image in eww no longer works Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Dec 2023 11:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67764 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: john muhl Cc: 67764@debbugs.gnu.org Received: via spool by 67764-submit@debbugs.gnu.org id=B67764.170229483019839 (code B ref 67764); Mon, 11 Dec 2023 11:41:02 +0000 Received: (at 67764) by debbugs.gnu.org; 11 Dec 2023 11:40:30 +0000 Received: from localhost ([127.0.0.1]:52712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCeeD-00059v-P3 for submit@debbugs.gnu.org; Mon, 11 Dec 2023 06:40:30 -0500 Received: from mail-pj1-x1042.google.com ([2607:f8b0:4864:20::1042]:61780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCeeA-00059e-K9 for 67764@debbugs.gnu.org; Mon, 11 Dec 2023 06:40:27 -0500 Received: by mail-pj1-x1042.google.com with SMTP id 98e67ed59e1d1-2866af9d73bso3016587a91.3 for <67764@debbugs.gnu.org>; Mon, 11 Dec 2023 03:40:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702294806; x=1702899606; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=xhw9NKq2qVS4/A2mGSQy92O5vQCtdLIyInQJbjcfyAA=; b=OUXwGT0QGCr/GN1msGO8mjprHuHqI+YV7uLLZ7XAUT1cS4co2alRn+c9ocJQEo+XYW qbDwmGwpswprhBhADE9opWPJi8jEHB9XmAX2PACK5JN+48UAtcnoJtva4BLipFGestgk AA7gbrK+H+KM30JFTtpE45vA4AWH+FxC0ZAlLCkDj/ozS9U12CHbDs7xpNU5T+0WZfg2 90i2HvdQZB2yGyp1wwcJY2+DZ5/JnhJOeTPv6+TMQ5J/8sqGUrOTV5nXm/1XWRs4CdSz f+nXvVTdjaWtCYkEyROF5lEdVMXKdsKE93+Xb/JMWZ0BJiKy0dwhVkSdgYVnvaNhsiDz mDcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702294806; x=1702899606; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xhw9NKq2qVS4/A2mGSQy92O5vQCtdLIyInQJbjcfyAA=; b=JBLd4h8xWo/mPIc1iOUdMz/uf/XxWE9gesKW6fM1oHb5zwaph8ihaOrOExWhr84k/M /wepZxLq4Fb7fC61PxQ8E39kTeSybUO6RyyiQ5CnLzd/TEfj0RWlimCbVLTjGTVFxPWF Q3sSN65wevWwi3QL1rt6u/CNZfp1fWzauVowPTpv7x1NGSbfxCxOY38rAf/OXhjdQuDa 9kdKZEAfIHQIUB6A3ZLd9rscqHrOF5Y3RCWRZ1++2YjFQB88fkuXW1IRFVE7c6XR6vD3 wocZDFWWTjnisz8zkK1Wli33cHBJtadhkOJ8SpSF7RF2MfqNCeY3dTmi3Qv4YKiMYmg/ Z1HQ== X-Gm-Message-State: AOJu0YwRF4H6+ccsTqy7pp7u+xyAAy6VQWP/33uhHTbMonq/pJdBnHkv zriGWnUZin7z4bB/MJgYbVY= X-Google-Smtp-Source: AGHT+IHghORj70vbytC+Z44fvYqYP1ZcfjOCG69qvmNzGEmX+z+1bJKT6Uun+CdlnBzNCIbYK5NY1Q== X-Received: by 2002:a17:90a:c205:b0:286:6cc1:8674 with SMTP id e5-20020a17090ac20500b002866cc18674mr1567213pjt.89.1702294805787; Mon, 11 Dec 2023 03:40:05 -0800 (PST) Received: from localhost ([49.205.83.111]) by smtp.gmail.com with ESMTPSA id pq18-20020a17090b3d9200b00286dfa09e7asm6763465pjb.24.2023.12.11.03.40.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 03:40:05 -0800 (PST) From: Visuwesh In-Reply-To: <87msuhfdjr.fsf@pub.pink> (john muhl via's message of "Mon, 11 Dec 2023 00:26:41 -0600") References: <87msuhfdjr.fsf@pub.pink> Date: Mon, 11 Dec 2023 17:10:01 +0530 Message-ID: <87sf49ge7i.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain [Monday December 11, 2023] john muhl via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > In Emacs 29.1 the image opens as expected: > > emacs -Q > M-: (eww "https://www.gnu.org/software/emacs/images/emacs.png") > > On master it fails with "Wrong type argument: stringp, nil". > Bisect says 4254544 is the first bad commit. Recent changes in shr-put-image didn't account for the possible nil value for ALT. Attached patch fixes the issue on my end. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-shr-put-image-with-nil-value-for-ALT.patch >From f6d3fc0de572a1039e83df0389c1c7efce0ef0cf Mon Sep 17 00:00:00 2001 From: Visuwesh Date: Mon, 11 Dec 2023 17:09:03 +0530 Subject: [PATCH] ; Fix shr-put-image with nil value for ALT * lisp/net/shr.el (shr-put-image): Account for nil value for ALT. (Bug#6774) --- lisp/net/shr.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/net/shr.el b/lisp/net/shr.el index 9f030b4c743..19c52ac8802 100644 --- a/lisp/net/shr.el +++ b/lisp/net/shr.el @@ -1137,7 +1137,7 @@ shr-put-image (when image ;; The trailing space can confuse shr-insert into not ;; putting any space after inline images. - (setq alt (string-trim alt)) + (setq alt (string-trim (or alt "*"))) ;; When inserting big-ish pictures, put them at the ;; beginning of the line. (let ((inline (shr--inline-image-p image))) -- 2.42.0 --=-=-=-- From unknown Sun Jun 22 07:59:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67764: 30.0.50; Opening image in eww no longer works Resent-From: john muhl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Dec 2023 15:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67764 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Visuwesh Cc: 67764@debbugs.gnu.org Received: via spool by 67764-submit@debbugs.gnu.org id=B67764.170230707721604 (code B ref 67764); Mon, 11 Dec 2023 15:05:02 +0000 Received: (at 67764) by debbugs.gnu.org; 11 Dec 2023 15:04:37 +0000 Received: from localhost ([127.0.0.1]:54323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rChpl-0005cN-46 for submit@debbugs.gnu.org; Mon, 11 Dec 2023 10:04:37 -0500 Received: from out-178.mta1.migadu.com ([2001:41d0:203:375::b2]:29751) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rChpi-0005cC-BF for 67764@debbugs.gnu.org; Mon, 11 Dec 2023 10:04:35 -0500 References: <87msuhfdjr.fsf@pub.pink> <87sf49ge7i.fsf@gmail.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; s=key1; t=1702307057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2iT6dnFryAf2Qcm2AAks7DCAsBhtmbLW2BNk8AfFp5I=; b=r10W1mVIHTuCs9Y+BaYT6TlRvrk0b+qNqo+zAqFSAghYWyRXlNqoQlOPbEb9lhFqJu1swA DH42fykVciSUKSWAifkawc7VOmhNWe5gFU1CcVUGTmnBF9R5khtRV0VIcelaN3ebtqTDFO 6A58jDKj8rSdEifZtndZB5gQbqa7/YM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: john muhl Date: Mon, 11 Dec 2023 09:03:39 -0600 In-reply-to: <87sf49ge7i.fsf@gmail.com> Message-ID: <8734w8srv6.fsf@pub.pink> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Visuwesh writes: > [Monday December 11, 2023] john muhl via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" wrote: > >> In Emacs 29.1 the image opens as expected: >> >> emacs -Q >> M-: (eww "https://www.gnu.org/software/emacs/images/emacs.png") >> >> On master it fails with "Wrong type argument: stringp, nil". >> Bisect says 4254544 is the first bad commit. > > Recent changes in shr-put-image didn't account for the possible nil > value for ALT. Attached patch fixes the issue on my end. Thanks. That fixes it here too. From unknown Sun Jun 22 07:59:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67764: 30.0.50; Opening image in eww no longer works Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Dec 2023 15:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67764 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Visuwesh Cc: 67764@debbugs.gnu.org, jm@pub.pink Received: via spool by 67764-submit@debbugs.gnu.org id=B67764.170230967726758 (code B ref 67764); Mon, 11 Dec 2023 15:48:01 +0000 Received: (at 67764) by debbugs.gnu.org; 11 Dec 2023 15:47:57 +0000 Received: from localhost ([127.0.0.1]:54358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCiVg-0006xT-LI for submit@debbugs.gnu.org; Mon, 11 Dec 2023 10:47:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCiVc-0006wj-Oz for 67764@debbugs.gnu.org; Mon, 11 Dec 2023 10:47:55 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCiVI-0000fE-0n; Mon, 11 Dec 2023 10:47:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=51SYDVc9XbTsZgLTlKxuZ3jj/xCQtTzNPi0FdTa26qs=; b=UtHzEIKjtYE7 iSZCCU2DSIZQKLsPg72sWhgcP/Gs5S9pV1/N0hq0QS8nK1qwZukjzpaxFhPeWMW1vx1DhRV9hmc+6 pD2rYOI5/ctSsdg2TB8Nwdt5Txy7FrC1cAQbioGThnD7fqrXTbLuESgY4D4IVmzrMt4Fsngs2TRHR cvJzZIMQLV/WTC+13PYxgrqVN4xMuqfw+gZMsIRjAioML3GNVCwWCiXtTojEuIjrDPF3cuzgoQ5i+ 9LhjGTrHebHxVInzn9exbOTg+xAxmzkTUOOAwqz6m/6ciXNYi6pyhmFskh/wvPqvcv+QRpDx3nLlf CI7++ni9eneXBVJ2qHeWzA==; Date: Mon, 11 Dec 2023 17:47:17 +0200 Message-Id: <83edfsvj0a.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87sf49ge7i.fsf@gmail.com> (message from Visuwesh on Mon, 11 Dec 2023 17:10:01 +0530) References: <87msuhfdjr.fsf@pub.pink> <87sf49ge7i.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 67764@debbugs.gnu.org > From: Visuwesh > Date: Mon, 11 Dec 2023 17:10:01 +0530 > > > emacs -Q > > M-: (eww "https://www.gnu.org/software/emacs/images/emacs.png") > > > > On master it fails with "Wrong type argument: stringp, nil". > > Bisect says 4254544 is the first bad commit. > > Recent changes in shr-put-image didn't account for the possible nil > value for ALT. Attached patch fixes the issue on my end. > > > >From f6d3fc0de572a1039e83df0389c1c7efce0ef0cf Mon Sep 17 00:00:00 2001 > From: Visuwesh > Date: Mon, 11 Dec 2023 17:09:03 +0530 > Subject: [PATCH] ; Fix shr-put-image with nil value for ALT > > * lisp/net/shr.el (shr-put-image): Account for nil value for ALT. > (Bug#6774) > --- > lisp/net/shr.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/net/shr.el b/lisp/net/shr.el > index 9f030b4c743..19c52ac8802 100644 > --- a/lisp/net/shr.el > +++ b/lisp/net/shr.el > @@ -1137,7 +1137,7 @@ shr-put-image > (when image > ;; The trailing space can confuse shr-insert into not > ;; putting any space after inline images. > - (setq alt (string-trim alt)) > + (setq alt (string-trim (or alt "*"))) > ;; When inserting big-ish pictures, put them at the > ;; beginning of the line. > (let ((inline (shr--inline-image-p image))) Thanks, but can we please avoid running a fixed string through string-trim? Also, I think the fallback on "*" deserves a comment to explain why that is done. From unknown Sun Jun 22 07:59:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67764: 30.0.50; Opening image in eww no longer works Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Dec 2023 04:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67764 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 67764@debbugs.gnu.org, jm@pub.pink Received: via spool by 67764-submit@debbugs.gnu.org id=B67764.17023544041947 (code B ref 67764); Tue, 12 Dec 2023 04:14:02 +0000 Received: (at 67764) by debbugs.gnu.org; 12 Dec 2023 04:13:24 +0000 Received: from localhost ([127.0.0.1]:55082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCu95-0000VJ-MP for submit@debbugs.gnu.org; Mon, 11 Dec 2023 23:13:24 -0500 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]:42250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCu90-0000V4-Rj for 67764@debbugs.gnu.org; Mon, 11 Dec 2023 23:13:22 -0500 Received: by mail-pf1-x444.google.com with SMTP id d2e1a72fcca58-6cebbf51742so3608824b3a.1 for <67764@debbugs.gnu.org>; Mon, 11 Dec 2023 20:13:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702354378; x=1702959178; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=p1NXD1x05k0kouWTtE3wzWoyC3zKDdJP71Q8rNX6wP8=; b=nlvdfdj59PfE4+0Qj3tEyXouG6CU0nMdsHDGT6ikjXwqH0ek02NxZL6YTbUKEb79eq T3Lt2LNDk07I77RbZJCkYenOyIBr/poBFLYCeS/R2csG0AsZNtfGf7Mfu2MXlAo0YZju VH6mgshRfE4DMjFxKV/WbupmSDnXQoSbSs0DxCIwZG1fJi0v1mvgWskGIMLuQXaJBZsr Op+X+cVqs7deElYD7CNNUF3Ikx0GxTwFiP/gDk02dF/MeEHrfeX4TMiN52GSfN9YmeO5 zphUzY3EM43IyFZbgX6pB3K6HlDVtihY6aBBYcT1mlS/scLqKNcBpkQqTVg2MZgB9xNs Effg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702354378; x=1702959178; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=p1NXD1x05k0kouWTtE3wzWoyC3zKDdJP71Q8rNX6wP8=; b=Ccs4TrTPJxpLA1ybY8R4bOdZ+6TfqoB2jZYQzKx+yihpq5Vum/zxiDAHw+WzJyasD0 e2IUedVqvp5SNRX8fl3+uT4HX9XdgJX9m8JN3Q1TMb7tWG/M1OU9nV4XYV5R6EMsJ984 s4Yn0lOJBJXkuaQsNegBXluC3+H/jUlRXtUNWL3o6sW9Uad5bcu+EIuacjB9v9/EEqtO U4gAAXI8obj1KQekl8hM5YiVDWQGu1ZBI8vy/W7BW56Fa+4mzeS+EEPgzNZluHx7w5O9 GWqa8Gp56eMtygS4J1Tn6JXzlFkWBpztbtRApvZvFcL9tn81FTgXA1cBVEhCeHbGnrf4 WTZQ== X-Gm-Message-State: AOJu0YzfGgFGsFLQEP0cmPwoRAnCPy0QjcQCBkVPOp3AKB+M5aKMTjxn EToXu48g6+hKC/MaflOPHEBU+KRKUz5DBSJX X-Google-Smtp-Source: AGHT+IHrmlJ1t4/aDgfsEdj2/tgIrRU9Fb2tcv3ELJgT+MHWLuBZn8eMN5G52yApv9mTgxnry7gg9g== X-Received: by 2002:aa7:88c6:0:b0:6ce:7a8f:af81 with SMTP id k6-20020aa788c6000000b006ce7a8faf81mr7342279pff.28.1702354377891; Mon, 11 Dec 2023 20:12:57 -0800 (PST) Received: from localhost ([49.204.128.180]) by smtp.gmail.com with ESMTPSA id b17-20020a056a000cd100b0068ffb8da107sm6973500pfv.212.2023.12.11.20.12.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 20:12:57 -0800 (PST) From: Visuwesh In-Reply-To: <83edfsvj0a.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 11 Dec 2023 17:47:17 +0200") References: <87msuhfdjr.fsf@pub.pink> <87sf49ge7i.fsf@gmail.com> <83edfsvj0a.fsf@gnu.org> Date: Tue, 12 Dec 2023 09:42:54 +0530 Message-ID: <87r0jst5x5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain [Monday December 11, 2023] Eli Zaretskii wrote: >> Cc: 67764@debbugs.gnu.org >> From: Visuwesh >> Date: Mon, 11 Dec 2023 17:10:01 +0530 >> >> > emacs -Q >> > M-: (eww "https://www.gnu.org/software/emacs/images/emacs.png") >> > >> > On master it fails with "Wrong type argument: stringp, nil". >> > Bisect says 4254544 is the first bad commit. >> >> Recent changes in shr-put-image didn't account for the possible nil >> value for ALT. Attached patch fixes the issue on my end. >> >> >> >From f6d3fc0de572a1039e83df0389c1c7efce0ef0cf Mon Sep 17 00:00:00 2001 >> From: Visuwesh >> Date: Mon, 11 Dec 2023 17:09:03 +0530 >> Subject: [PATCH] ; Fix shr-put-image with nil value for ALT >> >> [...] >> > Thanks, but can we please avoid running a fixed string through > string-trim? > > Also, I think the fallback on "*" deserves a comment to explain why > that is done. OK, how about the attached instead? --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-shr-put-image-with-nil-value-for-ALT.patch >From 27cd2c4c028723009ebf19696825d22c15f59795 Mon Sep 17 00:00:00 2001 From: Visuwesh Date: Mon, 11 Dec 2023 17:09:03 +0530 Subject: [PATCH] Fix shr-put-image with nil value for ALT * lisp/net/shr.el (shr-put-image): Account for nil value for ALT. (Bug#6774) --- lisp/net/shr.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/net/shr.el b/lisp/net/shr.el index 9f030b4c743..bf5038a421d 100644 --- a/lisp/net/shr.el +++ b/lisp/net/shr.el @@ -1137,7 +1137,9 @@ shr-put-image (when image ;; The trailing space can confuse shr-insert into not ;; putting any space after inline images. - (setq alt (string-trim alt)) + ;; ALT may be nil when visiting image URLs in eww + ;; (bug#6774). + (setq alt (if alt (string-trim alt) "*")) ;; When inserting big-ish pictures, put them at the ;; beginning of the line. (let ((inline (shr--inline-image-p image))) -- 2.42.0 --=-=-=-- From unknown Sun Jun 22 07:59:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67764: 30.0.50; Opening image in eww no longer works Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Dec 2023 08:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67764 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Visuwesh Cc: 67764@debbugs.gnu.org, Eli Zaretskii , jm@pub.pink Received: via spool by 67764-submit@debbugs.gnu.org id=B67764.170236890028537 (code B ref 67764); Tue, 12 Dec 2023 08:15:02 +0000 Received: (at 67764) by debbugs.gnu.org; 12 Dec 2023 08:15:00 +0000 Received: from localhost ([127.0.0.1]:55209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCxuu-0007QD-9J for submit@debbugs.gnu.org; Tue, 12 Dec 2023 03:15:00 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:12202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCxuq-0007Q2-0s for 67764@debbugs.gnu.org; Tue, 12 Dec 2023 03:14:59 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=iZUyXHCM +NIMXBRomVuZUZpYj7WJRjoLmPxp6gCYgYs=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=6m9q8Y9BlcqOSenaYJK0DutCujWoAV //MlP9CqSFRWJv/40aKJVsE05fMFnktT8pU6X0qVTP+WQvNxSTr43DAA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=iZUyXHCM+NIMXBRo mVuZUZpYj7WJRjoLmPxp6gCYgYs=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=cKAqiR5FS5/Kl0jxM87HDwLuuw35GOH3p2q8LL JzXPOLq9MuIbqgqHJy47X64q/poORp2wSfu24HbK/3EHMpXE2Kue18vF2sbrseSTS8Pi/U +iJl+8BrCLDfqGwlqtiKcZqEEKhe2GjL7iAY0AYq1HPz2vBeo2AfuUOkWUZD3DIGDOK/HV 9CI5xZefkOBs8jbx2vH/wwxuWix5VPoUceH35ZZyA7j5ZjjxHvbkNuOf9IQl9k2mgFDfVm tCC3mMuat9GTQGJAa4HICf0QKoGeCKv9BvvXEURXQ9MJSVVDUsCa4LX6jVtVg1ooh0y1FR EZ+YPGHJPC1piQ+Jil0eG/cQ== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id c3c46702 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 12 Dec 2023 09:14:38 +0100 (CET) From: Manuel Giraud In-Reply-To: <87r0jst5x5.fsf@gmail.com> (Visuwesh's message of "Tue, 12 Dec 2023 09:42:54 +0530") References: <87msuhfdjr.fsf@pub.pink> <87sf49ge7i.fsf@gmail.com> <83edfsvj0a.fsf@gnu.org> <87r0jst5x5.fsf@gmail.com> Date: Tue, 12 Dec 2023 09:14:37 +0100 Message-ID: <87h6kn4z2q.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Visuwesh writes: [...] > diff --git a/lisp/net/shr.el b/lisp/net/shr.el > index 9f030b4c743..bf5038a421d 100644 > --- a/lisp/net/shr.el > +++ b/lisp/net/shr.el > @@ -1137,7 +1137,9 @@ shr-put-image > (when image > ;; The trailing space can confuse shr-insert into not > ;; putting any space after inline images. > - (setq alt (string-trim alt)) > + ;; ALT may be nil when visiting image URLs in eww > + ;; (bug#6774). There is a 6 missing in the bug reference ;-) -- Manuel Giraud From unknown Sun Jun 22 07:59:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#67764: 30.0.50; Opening image in eww no longer works Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Dec 2023 09:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67764 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Manuel Giraud Cc: 67764@debbugs.gnu.org, Eli Zaretskii , jm@pub.pink Received: via spool by 67764-submit@debbugs.gnu.org id=B67764.17023724802122 (code B ref 67764); Tue, 12 Dec 2023 09:15:01 +0000 Received: (at 67764) by debbugs.gnu.org; 12 Dec 2023 09:14:40 +0000 Received: from localhost ([127.0.0.1]:55289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCyqe-0000YA-6X for submit@debbugs.gnu.org; Tue, 12 Dec 2023 04:14:40 -0500 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]:52581) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCyqb-0000Xw-FW for 67764@debbugs.gnu.org; Tue, 12 Dec 2023 04:14:39 -0500 Received: by mail-pf1-x441.google.com with SMTP id d2e1a72fcca58-6cea0fd9b53so3221859b3a.1 for <67764@debbugs.gnu.org>; Tue, 12 Dec 2023 01:14:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702372456; x=1702977256; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=EHqqhA14wm+P1YbeegGRYfeefh+zlZzm3M5eoYPBdKA=; b=ZZsQ7jvrd80Z35TShCLEMpeeR3r+BECqnk0PfNnirMKMULpzGpmfWNOS+nTAO6FnhN OEMs35rbMXHxFbw49r8N3LxucaJi6E/+K/xbzZVHS3UBec0jtx9eWjzTv3ONgx9hhDAM mSs7XV/GQHAVTHSKou+2ztVLAkt46z8pluoc8BjZuT/DssaktHcqHa8BS2b2vnSC3A5F h2T1f/Yn5wIf8Uo6emqWR2cyE35nkIR+C6PCIBE2XyGr6g9gT244iOh5V+aaEPtRnnVP wJMTPk4o5hz9BlwBKPIWECrFXIkBLREdkSItdUP10p48Dtbp+bm2RIFR7qNkIEediyK4 I9SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702372456; x=1702977256; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EHqqhA14wm+P1YbeegGRYfeefh+zlZzm3M5eoYPBdKA=; b=TbcFeIaXd0qCqTu4BjSHZxLkKkECqTJe9uG1gD7EynM3NGZBjgJR76J2TAUhMJydYc yeXJQygd6JFztJxT+7msePUqjK1Oc2Bi/3DNaHdkrb69Ie6m1LsQES7UqCC0Rq4+rmLK 2OJze4nIXdyVtzXyad6CTWBa5qt6OnGtLXxFbhzzyZ21LgLIPOXh/hNcZj4YnH3EyPP9 VZGppV1D4h9CIe0y0Z7EgczDg75P7vfycH397Efm7ROAz9zzbWkiAcvSGHHhrM2Xz59t Cd+lpUD6j+pT6DRAxdlij9Fe4FEot0AWnfH8xUhz4y49/RbZG7UU8hH3v/DA5grSw7VF IBQw== X-Gm-Message-State: AOJu0YxcUtwDLky49IZaFXMYiON4pdg7Ah6gQvvWpxBesq3x+pCkywtu UXXdHK90HKv8AxtZhCLHkEA= X-Google-Smtp-Source: AGHT+IHCG7XO00KsZ8XHHNx93+jHcbsyH0RW3OTiqqKf0SDfPttnshIfQnyW4epsScWiV1OTxCMPdA== X-Received: by 2002:a05:6a00:4655:b0:6ce:6a06:1caa with SMTP id kp21-20020a056a00465500b006ce6a061caamr2516628pfb.20.1702372456387; Tue, 12 Dec 2023 01:14:16 -0800 (PST) Received: from localhost ([49.204.128.180]) by smtp.gmail.com with ESMTPSA id h5-20020a62b405000000b006cdb8ef2db6sm7925924pfn.94.2023.12.12.01.14.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 01:14:15 -0800 (PST) From: Visuwesh In-Reply-To: <87h6kn4z2q.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Tue, 12 Dec 2023 09:14:37 +0100") References: <87msuhfdjr.fsf@pub.pink> <87sf49ge7i.fsf@gmail.com> <83edfsvj0a.fsf@gnu.org> <87r0jst5x5.fsf@gmail.com> <87h6kn4z2q.fsf@ledu-giraud.fr> Date: Tue, 12 Dec 2023 14:44:12 +0530 Message-ID: <87msufu6jf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain [Tuesday December 12, 2023] Manuel Giraud wrote: > Visuwesh writes: > > [...] > >> diff --git a/lisp/net/shr.el b/lisp/net/shr.el >> index 9f030b4c743..bf5038a421d 100644 >> --- a/lisp/net/shr.el >> +++ b/lisp/net/shr.el >> @@ -1137,7 +1137,9 @@ shr-put-image >> (when image >> ;; The trailing space can confuse shr-insert into not >> ;; putting any space after inline images. >> - (setq alt (string-trim alt)) >> + ;; ALT may be nil when visiting image URLs in eww >> + ;; (bug#6774). > > There is a 6 missing in the bug reference ;-) ...and in the commit log. I don't know how I managed to mess it up. Thanks for catching the mistake. Revised patch attached. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-shr-put-image-with-nil-value-for-ALT.patch >From 4327fb4eae80b217437fbabae6c2ef7c6ac940a3 Mon Sep 17 00:00:00 2001 From: Visuwesh Date: Mon, 11 Dec 2023 17:09:03 +0530 Subject: [PATCH] Fix shr-put-image with nil value for ALT * lisp/net/shr.el (shr-put-image): Account for nil value for ALT. (Bug#67764) --- lisp/net/shr.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/net/shr.el b/lisp/net/shr.el index 9f030b4c743..d6ea5213337 100644 --- a/lisp/net/shr.el +++ b/lisp/net/shr.el @@ -1137,7 +1137,9 @@ shr-put-image (when image ;; The trailing space can confuse shr-insert into not ;; putting any space after inline images. - (setq alt (string-trim alt)) + ;; ALT may be nil when visiting image URLs in eww + ;; (bug#67764). + (setq alt (if alt (string-trim alt) "*")) ;; When inserting big-ish pictures, put them at the ;; beginning of the line. (let ((inline (shr--inline-image-p image))) -- 2.42.0 --=-=-=-- From unknown Sun Jun 22 07:59:13 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: john muhl Subject: bug#67764: closed (Re: bug#67764: 30.0.50; Opening image in eww no longer works) Message-ID: References: <83jzpemhpx.fsf@gnu.org> <87msuhfdjr.fsf@pub.pink> X-Gnu-PR-Message: they-closed 67764 X-Gnu-PR-Package: emacs Reply-To: 67764@debbugs.gnu.org Date: Sat, 16 Dec 2023 12:55:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1702731302-27993-1" This is a multi-part message in MIME format... ------------=_1702731302-27993-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #67764: 30.0.50; Opening image in eww no longer works which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 67764@debbugs.gnu.org. --=20 67764: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D67764 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1702731302-27993-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 67764-done) by debbugs.gnu.org; 16 Dec 2023 12:54:02 +0000 Received: from localhost ([127.0.0.1]:54161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEUB8-0007Fp-8m for submit@debbugs.gnu.org; Sat, 16 Dec 2023 07:54:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEUB6-0007FV-GQ for 67764-done@debbugs.gnu.org; Sat, 16 Dec 2023 07:54:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEUAz-0000So-Vm; Sat, 16 Dec 2023 07:53:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qL+3VFdLCC/s845fD7y2kgjKeI8CDp2+StTgvA4R/Fw=; b=hW7OyeoeWin6 EJAN0GigrNdkpjWJwUUhtd3T0u/6mFJPqEF8igsVlrvCco2A5hxKivm9NBRZoU1bI2hxSRZIVK3yy tt84y/us02NntsQ2gsQmlxDK7MxJNjmMGTsv9iS3Vv+PcwojXwWna9hWk6hwaw8Wq0PfGx4olN9JP 7MyVCVbvu10/BdRVnugmyS91gLiPvZCBDrD75bgmWfNCIexBet41x5IgYu28UrEz4cwwg50X9nH07 NFA5SeP4AJkT0qSjNYYEehqgAXSELGav/N/3rraxiNgQo8U22czx1s1GYChIEpZ2IZvK2INr3qo1L /XmTUA5+wUkBiCNmgSN8oA==; Date: Sat, 16 Dec 2023 14:53:30 +0200 Message-Id: <83jzpemhpx.fsf@gnu.org> From: Eli Zaretskii To: Visuwesh In-Reply-To: <87msufu6jf.fsf@gmail.com> (message from Visuwesh on Tue, 12 Dec 2023 14:44:12 +0530) Subject: Re: bug#67764: 30.0.50; Opening image in eww no longer works References: <87msuhfdjr.fsf@pub.pink> <87sf49ge7i.fsf@gmail.com> <83edfsvj0a.fsf@gnu.org> <87r0jst5x5.fsf@gmail.com> <87h6kn4z2q.fsf@ledu-giraud.fr> <87msufu6jf.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67764-done Cc: jm@pub.pink, 67764-done@debbugs.gnu.org, manuel@ledu-giraud.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Visuwesh > Cc: Eli Zaretskii , 67764@debbugs.gnu.org, jm@pub.pink > Date: Tue, 12 Dec 2023 14:44:12 +0530 > > > Visuwesh writes: > > > > [...] > > > >> diff --git a/lisp/net/shr.el b/lisp/net/shr.el > >> index 9f030b4c743..bf5038a421d 100644 > >> --- a/lisp/net/shr.el > >> +++ b/lisp/net/shr.el > >> @@ -1137,7 +1137,9 @@ shr-put-image > >> (when image > >> ;; The trailing space can confuse shr-insert into not > >> ;; putting any space after inline images. > >> - (setq alt (string-trim alt)) > >> + ;; ALT may be nil when visiting image URLs in eww > >> + ;; (bug#6774). > > > > There is a 6 missing in the bug reference ;-) > > ...and in the commit log. I don't know how I managed to mess it up. > Thanks for catching the mistake. Revised patch attached. Thanks, installed on the master branch, and closing the bug. ------------=_1702731302-27993-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Dec 2023 06:40:11 +0000 Received: from localhost ([127.0.0.1]:52289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCZxb-00050s-4d for submit@debbugs.gnu.org; Mon, 11 Dec 2023 01:40:11 -0500 Received: from lists.gnu.org ([2001:470:142::17]:56740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCZxY-00050f-9n for submit@debbugs.gnu.org; Mon, 11 Dec 2023 01:40:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCZxD-0007bS-S1 for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 01:39:48 -0500 Received: from out-174.mta0.migadu.com ([2001:41d0:1004:224b::ae]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCZxB-0006Bn-Ac for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 01:39:47 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; s=key1; t=1702276780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=XW5+HmLwvtFr3l9ucsihO/1O1YMsVmNYanuBiNrfwsA=; b=E7Io1TU2EQ8ANmezdeYXe4tzomY0SmuaznuLNfQcRwCEwqm/+OG8/NjbxHmTqmn34sQ1Do uiW8+55Pul2bCtc+IxKXF5sB9ltw5RUKYX0CHdTQ8GGaVxkCONMgiprv+Qc0mKt3G2prwe LC2ckfqijLbVgpGoaq7s8i8TJqeDtNo= From: john muhl To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Opening image in eww no longer works Date: Mon, 11 Dec 2023 00:26:41 -0600 X-Debbugs-Cc: Message-ID: <87msuhfdjr.fsf@pub.pink> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:1004:224b::ae; envelope-from=jm@pub.pink; helo=out-174.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) In Emacs 29.1 the image opens as expected: emacs -Q M-: (eww "https://www.gnu.org/software/emacs/images/emacs.png") On master it fails with "Wrong type argument: stringp, nil". Bisect says 4254544 is the first bad commit. In GNU Emacs 30.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.18.0) of 2023-12-11 built on localhost Repository revision: cd702556759b33662cd6536c89ef02ddcd93d4ff Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12302002 System Description: Fedora Linux 39 (Thirty Nine) Configured using: 'configure --with-native-compilation=no' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB ------------=_1702731302-27993-1--