GNU bug report logs - #67752
[PATCH] Fix (setopt register-separator "\n") non-matching type warning

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67752 in the body.
You can then email your comments to 67752 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: gerard.vermeulen <at> posteo.net
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix (setopt register-separator "\n") non-matching type 
 warning
Date: Sun, 10 Dec 2023 17:37:49 +0000

[Message part 1 (text/plain, inline)]

Hi,

attached patch fixes "(setopt register-separator "\n") non-matching
type warnings" and makes the register-separator documentation
less confusing to me.

Regards -- Gerard

[0001-Fix-setopt-register-separator-n-non-matching-type-wa.patch (application/octet-stream, attachment)]

Message #8 received at 67752 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: gerard.vermeulen <at> posteo.net
Cc: 67752 <at> debbugs.gnu.org
Subject: Re: bug#67752: [PATCH] Fix (setopt register-separator "\n")
 non-matching type warning
Date: Sat, 16 Dec 2023 14:06:40 +0200

tags 67752 notabug
thanks

> Date: Sun, 10 Dec 2023 17:37:49 +0000
> From: gerard.vermeulen <at> posteo.net
> 
> attached patch fixes "(setopt register-separator "\n") non-matching
> type warnings" and makes the register-separator documentation
> less confusing to me.

I think register-separator is supposed to be a register, not a
separator string.  That's how it is documented.

So I don't think these changes should be installed.

Thanks.

Message #13 received at 67752 <at> debbugs.gnu.org (full text, mbox):

From: gerard.vermeulen <at> posteo.net
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 67752 <at> debbugs.gnu.org
Subject: Re: bug#67752: [PATCH] Fix (setopt register-separator "\n")
 non-matching type warning
Date: Sat, 16 Dec 2023 20:02:43 +0000

On 16.12.2023 13:06, Eli Zaretskii wrote:
> tags 67752 notabug
[...]
> I think register-separator is supposed to be a register, not a
> separator string.  That's how it is documented.
> 
> So I don't think these changes should be installed.
> 
Indeed, I did not understand from the documentation that the
"+" register is special and that one can do directly:
(set-register ?+ "\n*REGISTER SEPARATOR*\n")

I am sorry for the noise and you can close the bug as far as it
concerns me.

Regards

Message #18 received at 67752-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: gerard.vermeulen <at> posteo.net
Cc: 67752-done <at> debbugs.gnu.org
Subject: Re: bug#67752: [PATCH] Fix (setopt register-separator "\n")
 non-matching type warning
Date: Sat, 16 Dec 2023 22:21:10 +0200

> Date: Sat, 16 Dec 2023 20:02:43 +0000
> From: gerard.vermeulen <at> posteo.net
> Cc: 67752 <at> debbugs.gnu.org
> 
> 
> 
> On 16.12.2023 13:06, Eli Zaretskii wrote:
> > tags 67752 notabug
> [...]
> > I think register-separator is supposed to be a register, not a
> > separator string.  That's how it is documented.
> > 
> > So I don't think these changes should be installed.
> > 
> Indeed, I did not understand from the documentation that the
> "+" register is special and that one can do directly:
> (set-register ?+ "\n*REGISTER SEPARATOR*\n")
> 
> I am sorry for the noise and you can close the bug as far as it
> concerns me.

No need to apologize.  I'm closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.