GNU bug report logs - #67730
[PATCH] Add font-locking for shebangs in js-ts-mode and typescript-ts-mode

Previous Next

Package: emacs;

Reported by: Noah Peart <noah.v.peart <at> gmail.com>

Date: Sat, 9 Dec 2023 19:45:02 UTC

Severity: normal

Tags: patch

Fixed in version 29.2

Done: Dmitry Gutov <dmitry <at> gutov.dev>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67730 in the body.
You can then email your comments to 67730 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#67730; Package emacs. (Sat, 09 Dec 2023 19:45:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Noah Peart <noah.v.peart <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 09 Dec 2023 19:45:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Noah Peart <noah.v.peart <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add font-locking for shebangs in js-ts-mode and
 typescript-ts-mode
Date: Sat, 9 Dec 2023 11:44:19 -0800

[Message part 1 (text/plain, inline)]
Tags: patch


* Bug: `js-ts-mode` and `typescript-ts-mode` are missing font-locking
rules for hashbang lines.

Recipe to reproduce:
Open a buffer and insert

    #!/usr/bin/env node

Run `M-x js-ts-mode` and `M-x typescript-ts-mode` to see no font-locking
is applied to the hash bang line.

[Message part 2 (text/html, inline)]
[js-ts-mode-fontify-hash-bang.patch (text/x-patch, attachment)]
[typescript-ts-mode-fontify-hash-bang.patch (text/x-patch, attachment)]
Reply sent to Dmitry Gutov <dmitry <at> gutov.dev>:
You have taken responsibility. (Sun, 10 Dec 2023 02:54:02 GMT) Full text and rfc822 format available.
Notification sent to Noah Peart <noah.v.peart <at> gmail.com>:
bug acknowledged by developer. (Sun, 10 Dec 2023 02:54:02 GMT) Full text and rfc822 format available.

Message #10 received at 67730-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Noah Peart <noah.v.peart <at> gmail.com>, 67730-done <at> debbugs.gnu.org
Subject: Re: bug#67730: [PATCH] Add font-locking for shebangs in js-ts-mode
 and typescript-ts-mode
Date: Sun, 10 Dec 2023 04:53:13 +0200

Version: 29.2

On 09/12/2023 21:44, Noah Peart wrote:
> Tags: patch
> 
> 
> * Bug: `js-ts-mode` and `typescript-ts-mode` are missing font-locking
> rules for hashbang lines.
> 
> Recipe to reproduce:
> Open a buffer and insert
> 
>      #!/usr/bin/env node
> 
> Run `M-x js-ts-mode` and `M-x typescript-ts-mode` to see no font-locking
> is applied to the hash bang line.

Thanks! Installed.

Note that both commit messages exceeded the allowed 78, so I had to 
amend them by hand.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 07 Jan 2024 12:24:07 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 167 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.