Subject: Re: [bug#67722] [PATCH v2] gnu: libtorrent-rasterbar: Remove timeout for tests.

From: Ludovic Courtès <[email-masked]>
Date: Tue, 12 Dec 2023 09:11:07 +0100

Hello,

Tomas Volf <[email-masked]> skribis:

> The timeout is still enforced by the build farm for the build as a whole, so
> it should not cause any builds to be permanently stuck.
>
> * gnu/packages/bittorrent.scm
> (libtorrent-rasterbar)[arguments]<#:phases>['check]: Remote test timeout.
>
> Change-Id: I535c72fec24658a4b2151d2e8794319055c9a278

[...]

> -                    (timeout "600")
>                      (jobs (if parallel-tests?
>                                (number->string (parallel-job-count))
>                                "1")))
> @@ -478,7 +477,6 @@ (define-public libtorrent-rasterbar
>                   (invoke "ctest"
>                           "-E" exclude-regex
>                           "-j" jobs
> -                         "--timeout" timeout

What’s the rationale though?

If we know that tests, individually, are meant to take less than 10mn,
it still seems nicer to stop at 10mn rather than wait for the 1h
max-silent timeout, no?

Thanks,
Ludo’.