GNU bug report logs - #67688
30.0.50; ffap prepends buffers default-directory to guessed file name in case of tramp's file name syntax

Previous Next

Full log

View this message in rfc822 format

From: Visuwesh <visuweshm <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: michael.albinus <at> gmx.de, grfz <at> gmx.de, 67688 <at> debbugs.gnu.org
Subject: bug#67688: 30.0.50; ffap prepends buffers default-directory to guessed file name in case of tramp's file name syntax
Date: Sat, 16 Dec 2023 20:15:48 +0530

[Message part 1 (text/plain, inline)]

[சனி டிசம்பர் 16, 2023] Eli Zaretskii wrote:

>> From: Visuwesh <visuweshm <at> gmail.com>
>> Cc: michael.albinus <at> gmx.de,  grfz <at> gmx.de,  67688 <at> debbugs.gnu.org
>> Date: Tue, 12 Dec 2023 21:15:02 +0530
>> 
>> [Tuesday December 12, 2023] Eli Zaretskii wrote:
>> 
>> >> Cc: grfz <at> gmx.de, 67688 <at> debbugs.gnu.org
>> >> From: Visuwesh <visuweshm <at> gmail.com>
>> >> Date: Tue, 12 Dec 2023 20:41:28 +0530
>> >> 
>> >> -(defcustom ffap-lax-url t
>> >> +(defcustom ffap-lax-url nil
>> >
>> > This change of the default requires a NEWS entry.
>> >
>> > Thanks.
>> 
>> I was waiting for review from others.  Nevertheless, I have attached a
>> proper patch.
>
> Thanks.  Let's wait a bit longer, but meanwhile, a nit:
>
>> --- a/etc/NEWS
>> +++ b/etc/NEWS
>> @@ -258,6 +258,11 @@ called in the '--eval' expression, which is useful when those
>>  arguments contain arbitrary characters that otherwise might require
>>  elaborate and error-prone escaping (to protect them from the shell).
>>  
>> +---
>> +** ffap-lax-url now defaults to nil.
>> +Previously, it was set to ffap-lax-url to t but this broke remote file
>> +name detection.
>
> Please quote symbols in NEWS 'like this'.

Oops, fixed in attached patch.

[0001-Make-ffap-correctly-guess-remote-file-names-at-point.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.