GNU bug report logs - #67684
30.0.50; Font lock rule conflict in js-ts-mode at level 4

Previous Next

Full log

View this message in rfc822 format

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Loïc Lemaître <loic.lemaitre <at> gmail.com>, 67684 <at> debbugs.gnu.org, Yuan Fu <casouri <at> gmail.com>
Subject: bug#67684: 30.0.50; Font lock rule conflict in js-ts-mode at level 4
Date: Fri, 8 Dec 2023 03:33:16 +0200

[Message part 1 (text/plain, inline)]

Hi!

On 07/12/2023 12:07, Loïc Lemaître wrote:
> I have noticed a font coloration issue in js-ts-mode when setting the 
> treesit font lock level to 4: JSX attributes color is not the same than 
> at level 3.
> There should have a conflict between rules for "property_identifier" 
> treesit type. The feature that triggers the conflict is "property" (of 
> the level 4).
> 
> You can reproduce the issue by following these steps:
> - M-: (setq treesit-font-lock-level 4)
> - M-x js-ts-mode on a JSX buffer
> 
> Note that the bug already exists in Emacs 29.1.

The attached patch seems to fix that.

But it removes a function added by Yuan in e78e69b33189, while 
reshuffling the highlights to reorder priorities.

Yuan, do you remember why you did it that way back then? Perhaps I'm 
missing some other conflict.

[js-ts-font-lock-property.diff (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.