GNU bug report logs - #67681
[PATCH] gnu: Add node-commander.

Previous Next

To reply to this bug, email your comments to 67681 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rikard Nordgren <hrn <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: hrn <at> posteo.net
Subject: [PATCH] gnu: Add node-commander.
Date: Thu,  7 Dec 2023 08:29:16 +0000

* gnu/packages/node-xyz.scm (node-commander): New variable.

Change-Id: I5b00861705d64e0e89da81acee833e145287bd66
---
 gnu/packages/node-xyz.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index 6c16417309..8486d121dd 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -155,6 +155,44 @@ (define-public node-color-name
      "This package provides a JSON list with color names and their values.")
     (license license:expat)))
 
+(define-public node-commander
+  (package
+    (name "node-commander")
+    (version "11.1.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/tj/commander.js")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1xwh85kbxj76ni41r2h0apl8mjbfcnmxzzp3vlspq30w8kwfckni"))))
+    (build-system node-build-system)
+    (arguments
+     '(#:tests? #f
+       #:phases (modify-phases %standard-phases
+                  (add-after 'patch-dependencies 'delete-dependencies
+                    (lambda _
+                      (delete-dependencies '("@types/jest" "@types/node"
+                                             "@typescript-eslint/eslint-plugin"
+                                             "@typescript-eslint/parser"
+                                             "eslint"
+                                             "eslint-config-standard"
+                                             "eslint-config-standard-with-typescript"
+                                             "eslint-plugin-import"
+                                             "eslint-plugin-jest"
+                                             "eslint-plugin-n"
+                                             "eslint-plugin-promise"
+                                             "jest"
+                                             "ts-jest"
+                                             "tsd"
+                                             "typescript")))))))
+    (home-page "https://github.com/tj/commander.js")
+    (synopsis "Command line interface for node.js")
+    (description "The complete solution for node.js command-line interfaces.")
+    (license license:expat)))
+
 (define-public node-crx3
   (package
     (name "node-crx3")

base-commit: 23627b1706af25a0a30b96b9169a3495279aff1b
-- 
2.34.1

Message #8 received at 67681 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Rikard Nordgren <hrn <at> posteo.net>
Cc: 67681 <at> debbugs.gnu.org
Subject: Re: [bug#67681] [PATCH] gnu: Add node-commander.
Date: Wed, 03 Jan 2024 22:31:53 -0500

Hi,

Rikard Nordgren <hrn <at> posteo.net> writes:

> * gnu/packages/node-xyz.scm (node-commander): New variable.
>
> Change-Id: I5b00861705d64e0e89da81acee833e145287bd66
> ---
>  gnu/packages/node-xyz.scm | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>
> diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
> index 6c16417309..8486d121dd 100644
> --- a/gnu/packages/node-xyz.scm
> +++ b/gnu/packages/node-xyz.scm
> @@ -155,6 +155,44 @@ (define-public node-color-name
>       "This package provides a JSON list with color names and their values.")
>      (license license:expat)))
>  
> +(define-public node-commander
> +  (package
> +    (name "node-commander")
> +    (version "11.1.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/tj/commander.js")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "1xwh85kbxj76ni41r2h0apl8mjbfcnmxzzp3vlspq30w8kwfckni"))))
> +    (build-system node-build-system)
> +    (arguments
> +     '(#:tests? #f

Why is the test suite disabled?  A comment (explaining a good reason) is
needed :-).

> +       #:phases (modify-phases %standard-phases
> +                  (add-after 'patch-dependencies 'delete-dependencies

A comment explaining why these are removed would help.

> +                    (lambda _
> +                      (delete-dependencies '("@types/jest" "@types/node"
> +                                             "@typescript-eslint/eslint-plugin"
> +                                             "@typescript-eslint/parser"
> +                                             "eslint"
> +                                             "eslint-config-standard"
> +                                             "eslint-config-standard-with-typescript"
> +                                             "eslint-plugin-import"
> +                                             "eslint-plugin-jest"
> +                                             "eslint-plugin-n"
> +                                             "eslint-plugin-promise"
> +                                             "jest"
> +                                             "ts-jest"
> +                                             "tsd"
> +                                             "typescript")))))))
> +    (home-page "https://github.com/tj/commander.js")
> +    (synopsis "Command line interface for node.js")
> +    (description "The complete solution for node.js command-line interfaces.")

Could you please expand a bit on the description?  What features does it
have?  Keep it factual; "The complete solution ..." sounds like
marketing language.

-- 
Thanks,
Maxim

Message #13 received at 67681 <at> debbugs.gnu.org (full text, mbox):

From: hrn <hrn <at> posteo.net>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 67681 <at> debbugs.gnu.org
Subject: Re: [bug#67681] [PATCH] gnu: Add node-commander.
Date: Thu, 04 Jan 2024 17:20:27 +0000

Hi,

Thanks  for reviewing!

> Why is the test suite disabled?  A comment (explaining a good reason) 
> is
> needed :-).

This is what many node packages in node-xyz.scm does. I think this is 
because the tests are difficult to bootstrap. The dependency chains for 
the tests
are typically large and circular.

> A comment explaining why these are removed would help.

This is also the norm in node-xyz.scm. The excluded dependencies are for 
development and can in many cases be very difficult to bootstrap.

To be able to make progress with packaging node packages it seems to me 
that the general strategy has been  to disable tests and dependencies 
needed for tests. My assumption might be wrong though. Do you still 
think I should add comments?

> Could you please expand a bit on the description?  What features does 
> it
> have?  Keep it factual; "The complete solution ..." sounds like
> marketing language.

I agree that this needs to be changed. I blindly copied what the package 
said about itself.

Best regards,
Rikard

Message #16 received at 67681 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: hrn <hrn <at> posteo.net>
Cc: 67681 <at> debbugs.gnu.org
Subject: Re: [bug#67681] [PATCH] gnu: Add node-commander.
Date: Sat, 06 Jan 2024 14:05:11 -0500

Hi,

hrn <hrn <at> posteo.net> writes:

> Hi,
>
> Thanks  for reviewing!
>
>> Why is the test suite disabled?  A comment (explaining a good
>> reason) is
>> needed :-).
>
> This is what many node packages in node-xyz.scm does. I think this is
> because the tests are difficult to bootstrap. The dependency chains
> for the tests
> are typically large and circular.
>
>> A comment explaining why these are removed would help.
>
> This is also the norm in node-xyz.scm. The excluded dependencies are
> for development and can in many cases be very difficult to bootstrap.
>
> To be able to make progress with packaging node packages it seems to
> me that the general strategy has been  to disable tests and
> dependencies needed for tests. My assumption might be wrong though. Do
> you still think I should add comments?

OK, this makes sense, but hard to grasp for a newcomer like me to (gnu
packages node-xyz).  Perhaps it could be explained in a commentary
comment at the top of the module.

>> Could you please expand a bit on the description?  What features
>> does it
>> have?  Keep it factual; "The complete solution ..." sounds like
>> marketing language.
>
> I agree that this needs to be changed. I blindly copied what the
> package said about itself.

OK.  I look forward to a v2.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.