From unknown Wed Sep 10 04:08:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6768: ls: fix a test failure that should have been skipped Resent-From: dsh@linux.ucla.edu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 31 Jul 2010 14:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 6768 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 6768@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Reply-To: dsh@linux.ucla.edu Received: via spool by submit@debbugs.gnu.org id=B.12805868851615 (code B ref -1); Sat, 31 Jul 2010 14:35:02 +0000 Received: (at submit) by debbugs.gnu.org; 31 Jul 2010 14:34:45 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OfD9A-0000Q0-OS for submit@debbugs.gnu.org; Sat, 31 Jul 2010 10:34:45 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Of1gy-0003Hc-Jh for submit@debbugs.gnu.org; Fri, 30 Jul 2010 22:20:53 -0400 Received: from lists.gnu.org ([199.232.76.165]:34179) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Of1hF-0007KC-PX for submit@debbugs.gnu.org; Fri, 30 Jul 2010 22:21:09 -0400 Received: from [140.186.70.92] (port=55606 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Of1hD-0003QF-TP for bug-coreutils@gnu.org; Fri, 30 Jul 2010 22:21:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RDNS_NONE autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Of1hC-0005zw-Rc for bug-coreutils@gnu.org; Fri, 30 Jul 2010 22:21:08 -0400 Received: from [131.179.104.17] (port=55902 helo=uranium.linux.ucla.edu) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Of1hC-0005z8-M2 for bug-coreutils@gnu.org; Fri, 30 Jul 2010 22:21:06 -0400 Received: from dsh by uranium.linux.ucla.edu with local (Exim 4.69) (envelope-from ) id 1Of1CA-0001lD-CJ for bug-coreutils@gnu.org; Fri, 30 Jul 2010 18:49:02 -0700 Date: Fri, 30 Jul 2010 18:49:02 -0700 From: dsh@linux.ucla.edu Message-ID: <20100731014902.GA6666@linux.ucla.edu> Mail-Followup-To: bug-coreutils@gnu.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.7 (----) X-Mailman-Approved-At: Sat, 31 Jul 2010 10:34:43 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.7 (-----) Hi, I just ran into this one test failure while building the latest sources. The test didn't really fail, but the exit via the function invoked in $() doesn't terminate the test script, it simply terminates the substitution command. Here are the bits where it failed: ++ inode_via_readdir /home/dsh/.gvfs ++ mount_point=/home/dsh/.gvfs +++ basename /home/dsh/.gvfs ++ base=.gvfs ++ case $base in ++ skip_test_ 'mount point component starts with "."' ... ++ exit 77 + readdir_inode= ++ env stat --format=%i /home/dsh/.gvfs + stat_inode=1 + case $stat_inode in + test '' = 1 + fail=1 This simple patch checks for a skipped test status and continues to the next test. >From d76e0dbf81798e209ad958fa9582c975452b36ab Mon Sep 17 00:00:00 2001 From: Dan Hipschman Date: Fri, 30 Jul 2010 18:33:33 -0700 Subject: [PATCH] ls: fix a test failure that should have been skipped * tests/ls/readdir-mountpoint-inode: Check to see if skip_test_ is called in a helper function via $() instead of mistakenly failing. --- tests/ls/readdir-mountpoint-inode | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tests/ls/readdir-mountpoint-inode b/tests/ls/readdir-mountpoint-inode index 2285e92..63378b6 100755 --- a/tests/ls/readdir-mountpoint-inode +++ b/tests/ls/readdir-mountpoint-inode @@ -64,6 +64,7 @@ inode_via_readdir() for dir in $mount_points; do readdir_inode=$(inode_via_readdir $dir) + test $? = 77 && continue stat_inode=$(env stat --format=%i $dir) # If stat fails or says the inode is 0, skip $dir. case $stat_inode in 0|'') continue;; esac -- 1.7.1 From unknown Wed Sep 10 04:08:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6768: ls: fix a test failure that should have been skipped Resent-From: Eric Blake Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 09 Aug 2010 14:56:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6768 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 6768@debbugs.gnu.org Received: via spool by 6768-submit@debbugs.gnu.org id=B6768.128136570929094 (code B ref 6768); Mon, 09 Aug 2010 14:56:03 +0000 Received: (at 6768) by debbugs.gnu.org; 9 Aug 2010 14:55:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OiTkr-0007ZD-5T for submit@debbugs.gnu.org; Mon, 09 Aug 2010 10:55:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OiTkn-0007Yq-T9 for 6768@debbugs.gnu.org; Mon, 09 Aug 2010 10:55:07 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o79Etk8Y010541 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <6768@debbugs.gnu.org>; Mon, 9 Aug 2010 10:55:46 -0400 Received: from [10.3.113.67] (ovpn-113-67.phx2.redhat.com [10.3.113.67]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o79Etj7C032551 for <6768@debbugs.gnu.org>; Mon, 9 Aug 2010 10:55:45 -0400 Message-ID: <4C6016B4.9080607@redhat.com> Date: Mon, 09 Aug 2010 08:54:44 -0600 From: Eric Blake Organization: Red Hat User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.3 Thunderbird/3.1.1 MIME-Version: 1.0 References: <20100731014902.GA6666@linux.ucla.edu> In-Reply-To: <20100731014902.GA6666@linux.ucla.edu> X-Enigmail-Version: 1.1.2 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig02998DBB2EB966F806FB191A" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Spam-Score: -10.1 (----------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -10.1 (----------) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig02998DBB2EB966F806FB191A Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 07/30/2010 07:49 PM, dsh@linux.ucla.edu wrote: > Hi, >=20 > I just ran into this one test failure while building the latest sources= =2E The > test didn't really fail, but the exit via the function invoked in $() d= oesn't > terminate the test script, it simply terminates the substitution comman= d. >=20 > Here are the bits where it failed: >=20 > ++ case $base in > ++ skip_test_ 'mount point component starts with "."' > ... > ++ exit 77 > + readdir_inode=3D > ++ env stat --format=3D%i /home/dsh/.gvfs Thanks; applied. > Subject: [PATCH] ls: fix a test failure that should have been skipped >=20 > * tests/ls/readdir-mountpoint-inode: Check to see if skip_test_ is > called in a helper function via $() instead of mistakenly failing. > for dir in $mount_points; do > readdir_inode=3D$(inode_via_readdir $dir) > + test $? =3D 77 && continue --=20 Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org --------------enig02998DBB2EB966F806FB191A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJMYBa0AAoJEKeha0olJ0NqwZoH/2HWvLM6elgfkXbAP4sBsA/f vJvUOczBpwsD4qAODC0tXMc3+fkHfUagIxdXi8DCfTjfmkSaoHcV5i9KivEQQ9CL 2VnHhSpWi7ILR9BehiZWeiKNZJ5LWinqaF7woN25x9C3oPRvZvSWVuRrH/JGLCky YMaijHud0ZBDhuCSafQnOOx+vRQVosX5GOm4FmaAgKhj6FeFdXtxkKGFvlWsUZWu VIa0tzM3HbhJTBOMITLqPcWKqc+GnxHeSvNjAKBd8rSTUxHJ59zkCAmbeDHlNN0v WgkURPFCmnHmW1OJBx5H4mUB/76qRPO8vJsIWkNNF3kHMMNDA7QK1uJQL0A6i18= =BptS -----END PGP SIGNATURE----- --------------enig02998DBB2EB966F806FB191A-- From unknown Wed Sep 10 04:08:36 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: dsh@linux.ucla.edu Subject: bug#6768: closed (Re: bug#6768: ls: fix a test failure that should have been skipped) Message-ID: References: <87oc01jkoc.fsf@rho.meyering.net> <20100731014902.GA6666@linux.ucla.edu> X-Gnu-PR-Message: they-closed 6768 X-Gnu-PR-Package: coreutils Reply-To: 6768@debbugs.gnu.org Date: Sun, 07 Aug 2011 15:41:06 +0000 Content-Type: multipart/mixed; boundary="----------=_1312731666-2712-1" This is a multi-part message in MIME format... ------------=_1312731666-2712-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #6768: ls: fix a test failure that should have been skipped which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 6768@debbugs.gnu.org. --=20 6768: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D6768 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1312731666-2712-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 6768-done) by debbugs.gnu.org; 7 Aug 2011 15:40:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qq5So-0000gs-3B for submit@debbugs.gnu.org; Sun, 07 Aug 2011 11:40:30 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qq5Sl-0000gl-NK for 6768-done@debbugs.gnu.org; Sun, 07 Aug 2011 11:40:28 -0400 Received: from rho.meyering.net (localhost.localdomain [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id E59D9600AC; Sun, 7 Aug 2011 17:38:59 +0200 (CEST) From: Jim Meyering To: Eric Blake Subject: Re: bug#6768: ls: fix a test failure that should have been skipped In-Reply-To: <4C6016B4.9080607@redhat.com> (Eric Blake's message of "Mon, 09 Aug 2010 08:54:44 -0600") References: <20100731014902.GA6666@linux.ucla.edu> <4C6016B4.9080607@redhat.com> Date: Sun, 07 Aug 2011 17:38:59 +0200 Message-ID: <87oc01jkoc.fsf@rho.meyering.net> Lines: 24 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: 6768-done Cc: 6768-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Eric Blake wrote: > On 07/30/2010 07:49 PM, dsh@linux.ucla.edu wrote: >> Hi, >> >> I just ran into this one test failure while building the latest sources. The >> test didn't really fail, but the exit via the function invoked in $() doesn't >> terminate the test script, it simply terminates the substitution command. >> >> Here are the bits where it failed: >> >> ++ case $base in >> ++ skip_test_ 'mount point component starts with "."' >> ... >> ++ exit 77 >> + readdir_inode= >> ++ env stat --format=%i /home/dsh/.gvfs > > Thanks; applied. > >> Subject: [PATCH] ls: fix a test failure that should have been skipped Thanks. Closing this issue. ------------=_1312731666-2712-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 31 Jul 2010 14:34:45 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OfD9A-0000Q0-OS for submit@debbugs.gnu.org; Sat, 31 Jul 2010 10:34:45 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Of1gy-0003Hc-Jh for submit@debbugs.gnu.org; Fri, 30 Jul 2010 22:20:53 -0400 Received: from lists.gnu.org ([199.232.76.165]:34179) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Of1hF-0007KC-PX for submit@debbugs.gnu.org; Fri, 30 Jul 2010 22:21:09 -0400 Received: from [140.186.70.92] (port=55606 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Of1hD-0003QF-TP for bug-coreutils@gnu.org; Fri, 30 Jul 2010 22:21:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RDNS_NONE autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Of1hC-0005zw-Rc for bug-coreutils@gnu.org; Fri, 30 Jul 2010 22:21:08 -0400 Received: from [131.179.104.17] (port=55902 helo=uranium.linux.ucla.edu) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Of1hC-0005z8-M2 for bug-coreutils@gnu.org; Fri, 30 Jul 2010 22:21:06 -0400 Received: from dsh by uranium.linux.ucla.edu with local (Exim 4.69) (envelope-from ) id 1Of1CA-0001lD-CJ for bug-coreutils@gnu.org; Fri, 30 Jul 2010 18:49:02 -0700 Date: Fri, 30 Jul 2010 18:49:02 -0700 From: dsh@linux.ucla.edu To: bug-coreutils@gnu.org Subject: ls: fix a test failure that should have been skipped Message-ID: <20100731014902.GA6666@linux.ucla.edu> Mail-Followup-To: bug-coreutils@gnu.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.7 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 31 Jul 2010 10:34:43 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: dsh@linux.ucla.edu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.7 (-----) Hi, I just ran into this one test failure while building the latest sources. The test didn't really fail, but the exit via the function invoked in $() doesn't terminate the test script, it simply terminates the substitution command. Here are the bits where it failed: ++ inode_via_readdir /home/dsh/.gvfs ++ mount_point=/home/dsh/.gvfs +++ basename /home/dsh/.gvfs ++ base=.gvfs ++ case $base in ++ skip_test_ 'mount point component starts with "."' ... ++ exit 77 + readdir_inode= ++ env stat --format=%i /home/dsh/.gvfs + stat_inode=1 + case $stat_inode in + test '' = 1 + fail=1 This simple patch checks for a skipped test status and continues to the next test. >From d76e0dbf81798e209ad958fa9582c975452b36ab Mon Sep 17 00:00:00 2001 From: Dan Hipschman Date: Fri, 30 Jul 2010 18:33:33 -0700 Subject: [PATCH] ls: fix a test failure that should have been skipped * tests/ls/readdir-mountpoint-inode: Check to see if skip_test_ is called in a helper function via $() instead of mistakenly failing. --- tests/ls/readdir-mountpoint-inode | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tests/ls/readdir-mountpoint-inode b/tests/ls/readdir-mountpoint-inode index 2285e92..63378b6 100755 --- a/tests/ls/readdir-mountpoint-inode +++ b/tests/ls/readdir-mountpoint-inode @@ -64,6 +64,7 @@ inode_via_readdir() for dir in $mount_points; do readdir_inode=$(inode_via_readdir $dir) + test $? = 77 && continue stat_inode=$(env stat --format=%i $dir) # If stat fails or says the inode is 0, skip $dir. case $stat_inode in 0|'') continue;; esac -- 1.7.1 ------------=_1312731666-2712-1--