From unknown Fri Jun 20 07:17:43 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#67667 <67667@debbugs.gnu.org> To: bug#67667 <67667@debbugs.gnu.org> Subject: Status: wrong phrasing in installation wizard seen in emacs-29.1_2-installer.exe Reply-To: bug#67667 <67667@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:17:43 +0000 retitle 67667 wrong phrasing in installation wizard seen in emacs-29.1_2-in= staller.exe reassign 67667 emacs submitter 67667 sebboh@the-good-guys.net severity 67667 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 06 15:47:11 2023 Received: (at submit) by debbugs.gnu.org; 6 Dec 2023 20:47:11 +0000 Received: from localhost ([127.0.0.1]:40520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAynX-0001Hz-5E for submit@debbugs.gnu.org; Wed, 06 Dec 2023 15:47:11 -0500 Received: from lists.gnu.org ([2001:470:142::17]:39812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAyfd-00014K-SY for submit@debbugs.gnu.org; Wed, 06 Dec 2023 15:39:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAyfM-0003Io-43 for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2023 15:38:44 -0500 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rAyfH-0005Tc-Vl for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2023 15:38:42 -0500 Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-5c66418decaso115910a12.3 for ; Wed, 06 Dec 2023 12:38:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=the-good-guys-net.20230601.gappssmtp.com; s=20230601; t=1701895114; x=1702499914; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=mb8OkMQchrBwclMSKkvvQaUTJyhqr0trToaEQatsgGc=; b=b5ub2JVIH6HJjsfV3kXIGZS262blN/QBkApjwQOVV2yh0/Gdf8Jjp61av+B0qvdpuZ WK6hBk9w0XqiJqi0Zag2MiOrgXX+qo5vqbCSt+pI3yHSi2wc2fIBEHFgH17UOKPMbvql eC7oTorU85A2hYsfzIlOwUkJ9VOVcCNEZb0hIOqoFbtusx2qFZqsAVVp+tWRQqoznC/Q oqYOJ+AX0i4HQDhkXCvmxCSTTtXERQfg+HxGBPdr/a8eXtJnFIWEc6MH6riCUsUDJ9Jc /pZSaaLUtskPjXyCw5ko4GO9JbLT1A17ivozcqXzhhD7LcHVeR1rSFav8tv3WXOwcSJy 8VIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701895114; x=1702499914; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=mb8OkMQchrBwclMSKkvvQaUTJyhqr0trToaEQatsgGc=; b=SovKoe9sgmrgEZnwfOuBdwWITwNhZ6oe5mmkrXE5KgQHk5/x64GJIS2ihP+4hre6rU i9bsBSMjf88PQV+llbb0WLF/2QEY28/s741/gq9iFZwRQbAvqkz9+o78dSCJnA3kBukr nbIsiU2W9cF4Fi9ozJadERxfpNcUUfTRw/nXiVUjhA3cJI9OkLFZmPx/iH2m953Ngonl rmIjD6/aTRqTC2Vzm3vrYe+0bWyP8VhYarEz1UU7W9svukExLYgMp8Djk6jggFIjKWTd N8L8GD/HfYXhUU1IvAA9puUZJGk5BpJUuvfsgh/7ZBlw1q3jYqLhwDUFTHlZYErROiKI c+qQ== X-Gm-Message-State: AOJu0YxzpI6k1SBsJa+mbtxX3DifctZZU46d8t1YQHW3KISOM0Q5e1ua ann7ZNAhsp0HLmW49fZjbDh/Qsm0+v4lFiowmkuTsy1XXZgpPOL88SA= X-Google-Smtp-Source: AGHT+IGQW8ZWLxz4Rj9tg/P41lOY2X0VIRBFrMbVmbp4tWsMRWeVMzFi2X8/ooS4LRk1k+FGrY58UciDWh0te4OovDk= X-Received: by 2002:a17:90a:8046:b0:286:b052:7ead with SMTP id e6-20020a17090a804600b00286b0527eadmr1172114pjw.95.1701895114525; Wed, 06 Dec 2023 12:38:34 -0800 (PST) MIME-Version: 1.0 From: sebboh@the-good-guys.net Date: Wed, 6 Dec 2023 14:38:23 -0600 Message-ID: Subject: wrong phrasing in installation wizard seen in emacs-29.1_2-installer.exe To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: none client-ip=2607:f8b0:4864:20::531; envelope-from=david.loyall@the-good-guys.net; helo=mail-pg1-x531.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 06 Dec 2023 15:47:08 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello. This screenshot says it all. http://0x0.st/H3iS.png As I understand it, it is not a requirement of GPLv3 that the user "accept" the "terms" of the "agreement" in order to perform an installation. I recommend removing the "if you accept ..." language and changing the "I Agree" button to just "OK" or "Noted...", or "Next". Cheers, --sebboh From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 10 12:37:51 2024 Received: (at 67667) by debbugs.gnu.org; 10 Jan 2024 17:37:51 +0000 Received: from localhost ([127.0.0.1]:42818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNcWV-00083B-24 for submit@debbugs.gnu.org; Wed, 10 Jan 2024 12:37:51 -0500 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]:52554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNcWS-00082v-JS for 67667@debbugs.gnu.org; Wed, 10 Jan 2024 12:37:49 -0500 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-5578485fc0eso3457139a12.1 for <67667@debbugs.gnu.org>; Wed, 10 Jan 2024 09:37:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704908264; x=1705513064; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=IyBVi5Ffqvi3Nys0jLB7f+0VLS7NaXQ/BL1Mqgt9EYk=; b=LpzpzsN+C+hvHGyJG0oYg6HAoRTtHOR4aWhEsx62miiME9BXcXcXzKluZCJcmajQFT yYkLmiy8JW0ElMYh6WnyAL9Sn3LO4HNQetN3IHGJbWleAYNKr/bkwk+OMNsLln/LW9/S Ex2eywfJYZfPqOr3cpmRZuvqVIg4L8aWPrsp9aOnWZ3NaExjEpBg1ZmfabAbeALm2ksx I9ieQ8hqQBE9FtqgBTgILK8ZSxI1TLmuRPM9zS/sIdz3ZwIO0tFBwXZzDbYHaMyuFu+N ggyohrZfW5YVXLtO+xK0lIf/8Kou7/eg3f9PFO73ej+NwYN5IIh9kwr0SECEOPr93Pl0 to1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704908264; x=1705513064; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IyBVi5Ffqvi3Nys0jLB7f+0VLS7NaXQ/BL1Mqgt9EYk=; b=DOm44dm5/k1uMcd/I5/CpOOIbZ6Tftk03BCqEmSOX4sP/KZ+4ueeGbdIYTVBHC3pBS X+e24fM4oxORlwoi0UWeYRMKZfME5UwSoYY2fpKoaFcl20wPC/sPBuoD2+UXHnkWT1Ov WNBZSuEJF8Cwe4TB1/OVK7aqH9gv+9xHOLVuic64mN/D3aU0pqGT84m/h7EqWw/iVABH qVe0pRlfcr7fI0l/4WBqm+tJSRFuPqNHxpU21p2dEGShDvhJc9155G4oJs5JircdydQF mrVYdpzbzOortpE7IzSxDqPu7tnBvVwVONX/Oifo4kycMxGSAbStS5iMJc9PL+v8ePm3 /rsg== X-Gm-Message-State: AOJu0YzOkdrFuZSUvAZ9s95yBHWOX+Iqs9dvNwvj8rNk5PNBpXGU5qbK jEFPjpdBO8/nNbUb4ymcwj82aLSfKSfWujt/hDcs3ZcaeulC1g== X-Google-Smtp-Source: AGHT+IGou70on9vBNs9UmnX7yNHAWO3rivavrAFt/9ANixhWrRlxt+BM7UEkuz5zbvdzPAg7zY1QmTCm6/f9nK73OQ0= X-Received: by 2002:a50:ec90:0:b0:557:ed8b:c606 with SMTP id e16-20020a50ec90000000b00557ed8bc606mr733950edr.23.1704908263867; Wed, 10 Jan 2024 09:37:43 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 10 Jan 2024 09:37:43 -0800 From: Stefan Kangas In-Reply-To: (sebboh@the-good-guys.net's message of "Wed, 6 Dec 2023 14:38:23 -0600") References: MIME-Version: 1.0 Date: Wed, 10 Jan 2024 09:37:43 -0800 Message-ID: Subject: Re: bug#67667: wrong phrasing in installation wizard seen in emacs-29.1_2-installer.exe To: sebboh@the-good-guys.net Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67667 Cc: Corwin Brust , 67667@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) sebboh@the-good-guys.net writes: > Hello. > > This screenshot says it all. http://0x0.st/H3iS.png > > As I understand it, it is not a requirement of GPLv3 that the user > "accept" the "terms" of the "agreement" in order to perform an > installation. > > I recommend removing the "if you accept ..." language and changing the > "I Agree" button to just "OK" or "Noted...", or "Next". Corwin, what do you think? From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 10 12:38:00 2024 Received: (at control) by debbugs.gnu.org; 10 Jan 2024 17:38:00 +0000 Received: from localhost ([127.0.0.1]:42821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNcWe-00083c-Fn for submit@debbugs.gnu.org; Wed, 10 Jan 2024 12:38:00 -0500 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:42476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNcWc-00083N-WB for control@debbugs.gnu.org; Wed, 10 Jan 2024 12:37:59 -0500 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-557c188f313so5636079a12.1 for ; Wed, 10 Jan 2024 09:38:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704908274; x=1705513074; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=V9tfkUtgq7W8mJsJlKacy0aIMXGfpBDJluRlZzxOa6I=; b=ZU/UzKobgSVZo5d+grYeUWIic/V8wX+26xva7muDK93fX6I8OXGa0YJRWGdFCvPDWa jQv/69Nx0438jJVKN2FGId9ZbOwQzOOSKQhChhe1DEOxw23yisvPscp3b065jJIuLXJf HPt4Zj9yxi/Li+PjbT+Su8nM2l1Fh9yY3pqGKHuHCGe7tE51WmCTWAXRTx2ZTgPMv1sP mgYVUgqxGy6Cb4951Wj2D5ar+PESpdrDtPK0iSg72Neiac1ESDZCbwNiP6/8E/Mvxtmt +qzD964aM4p6kFdzkeuGh33YoMxA2cwNiV6+oCpxFXaZIA1fCVPpoZsLn0mVYC8cBjpw IMnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704908274; x=1705513074; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=V9tfkUtgq7W8mJsJlKacy0aIMXGfpBDJluRlZzxOa6I=; b=XaCEaTlEpnbMOv7D605mn2BGjYXsoyGGhIfTN3B7RQDkAW+AaaQeTCxRqzp8RuB6mB zP5fStACa04QXTiFmHlMp7UTBVT/k9bwKSSfMr7L56JOLD6C7kjTbjN7sP0ojCw3GGgs RFmvEYciGUfe5eV4hD0Kayne6xMBkK3kocwcYVDjf9FFMtC5p0sdIUHlc/w6B+9D4i1y laOLwkC03a4UO0bjrejpMxvjXLYHhs9ZSz0iAkg64J1iidsk0nrn20gnZAyeggtGPe4m dmw7Q/pBcsGzAN7CMAK7sZcj92t8IWTV1j2MQes52ktHGfCzGIVPhPsMuuaCdXsP2/I4 Fisg== X-Gm-Message-State: AOJu0Yz7L5lECUTJT6S7P2sx/7TybemWkG8dFbciAaov225X08ZrayQk PMvhXq743IZtjy3Y5cmXTdR9TFPN5cutN7QOU13ES0j2Vy+U6w== X-Google-Smtp-Source: AGHT+IHAWc8+xqr/BLc2kIfKYHbNFLAueV+RV5n6QNVno+Lwxf9KJM9QiJ2URbJEt5Nr12TGAZdJ2U+uHfHIfh2euyg= X-Received: by 2002:a50:cd59:0:b0:554:8c9d:c3ff with SMTP id d25-20020a50cd59000000b005548c9dc3ffmr513204edj.29.1704908274371; Wed, 10 Jan 2024 09:37:54 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 10 Jan 2024 09:37:54 -0800 From: Stefan Kangas MIME-Version: 1.0 Date: Wed, 10 Jan 2024 09:37:54 -0800 Message-ID: Subject: control message for bug #67667 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 67667 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 10 12:54:50 2024 Received: (at 67667) by debbugs.gnu.org; 10 Jan 2024 17:54:50 +0000 Received: from localhost ([127.0.0.1]:42956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNcmw-0002wz-Do for submit@debbugs.gnu.org; Wed, 10 Jan 2024 12:54:50 -0500 Received: from mail-ot1-f52.google.com ([209.85.210.52]:54629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNcmt-0002wm-VW for 67667@debbugs.gnu.org; Wed, 10 Jan 2024 12:54:48 -0500 Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-6dddf7ea893so1322492a34.1 for <67667@debbugs.gnu.org>; Wed, 10 Jan 2024 09:54:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704909283; x=1705514083; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=roxMjh0YfUS+NtDeGZKa3ct2GxfAcplL9D6RjSmIwrU=; b=Xdlw80BhfGNxJ0bK3GM9vVkAHoHpgzvEz5nvCfNGmYQp+Bxad51fGbqGzyev+32ayz k2le8QdB42D9+HtV46wg+ZKIP6yBlp/b/qpAyWlRgN0Z0ZQ7AUpJVp7RWAJuo2vEj2yi 9wN8kp1f8YIKAiLM+wION6IC/9lyt4G8/AUPF8uuU6zAFhiHpTHCYPgmsyB80KcHtYWm QIREDy6JhdDuajhEtUpzDywDUUIo0wizaP/2p+Qz0pwwqF+SUp6guH+IYmr1DrCD1y3I i8NxZOOtGbtVfZ0P+5hGKB29uImFl4jL5d4ZBWxsr/fNngEjdhuNdN77nwPO9DlfG6w2 0UJw== X-Gm-Message-State: AOJu0YwZ43opXhEqfB6AURfI3/IP1zy9he44nOBt6zvDhyofbCzKnPd+ 3bTfHDYnFmo2H2pje3z43xJVlTjAsr2MLvhAcqQ= X-Google-Smtp-Source: AGHT+IFxxdpvgIM5oNFiFijAukkQ6etyjrt4bvocQCjRlcEabejEVvwIPhXhIfg4Nl2UlQF3OSXrKI9an+sa4QnY1Hg= X-Received: by 2002:a05:6870:a11c:b0:203:cfc9:e705 with SMTP id m28-20020a056870a11c00b00203cfc9e705mr970804oae.1.1704909283481; Wed, 10 Jan 2024 09:54:43 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Corwin Brust Date: Wed, 10 Jan 2024 11:54:31 -0600 Message-ID: Subject: Re: bug#67667: wrong phrasing in installation wizard seen in emacs-29.1_2-installer.exe To: Stefan Kangas Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 67667 Cc: sebboh@the-good-guys.net, 67667@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Wed, Jan 10, 2024 at 11:37=E2=80=AFAM Stefan Kangas wrote: > > sebboh@the-good-guys.net writes: > > > Hello. > > > > This screenshot says it all. http://0x0.st/H3iS.png > > > > As I understand it, it is not a requirement of GPLv3 that the user > > "accept" the "terms" of the "agreement" in order to perform an > > installation. > > > > I recommend removing the "if you accept ..." language and changing the > > "I Agree" button to just "OK" or "Noted...", or "Next". > > Corwin, what do you think? > I agree. Let's patch it. I'll send something if I don't see someone else has already pushed a fix for this. I assume this might wait for me since I'm in a position to test it fairly easily. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 11 03:31:26 2024 Received: (at 67667) by debbugs.gnu.org; 11 Jan 2024 08:31:26 +0000 Received: from localhost ([127.0.0.1]:58688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNqTF-0004qk-Pg for submit@debbugs.gnu.org; Thu, 11 Jan 2024 03:31:26 -0500 Received: from mail-ot1-f47.google.com ([209.85.210.47]:54538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNqTD-0004kr-Hs for 67667@debbugs.gnu.org; Thu, 11 Jan 2024 03:31:24 -0500 Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-6dddf7ea893so1624803a34.1 for <67667@debbugs.gnu.org>; Thu, 11 Jan 2024 00:31:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704961880; x=1705566680; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sWaF5g26vs6AT9G1SNudqXY/FUuF78I+bE+aROKyL/g=; b=E12aHPfsVw/Eob5fLNZ2wo15oBPmb8zoW9o9MIX+j0N9Bj/E+VIbFDKmA14iS6KkbL JNscaVEHCPcDAoElsHvmn8Clt9gDfZMAnSaThWw1r+V5VvxJ6fntvdjLpBvwY4pO2lMw bCstO5nNbpk6LRgbAnwU95SFawg47B1s2iV9F3FPLU/GNODLSnqwlFuXVLRkCz2sOUbt ipKNGQ2mQTOKzF6GZrAYVvVmZopVJVqn8GXbSfcOh0puSy3gP+0yVFCxskbmuyCgiOxl 5EnNR1aU0bf6NArFWuXXQVlFt868Bb/oQJqsK4dXNlUfbEGNzkfw31fYVUDDaXwME0ly 3noQ== X-Gm-Message-State: AOJu0YxUMlHAKmtnVJ8NcoRopWZ2pSJUBmWB83p+C9Kpnewdcgr8VUmt IAn9OEMFDoNl4lbbg9ixfrqbJzEodVhi/v3/bZU= X-Google-Smtp-Source: AGHT+IH5g/+H5ycWCXWvjfykzk/2NYLEcbdI+uEaoohskZJP6cyGLziga7n6V9o9OH4Z3SZfOeuaFcq5LDv5DpNm8E0= X-Received: by 2002:a9d:7a4b:0:b0:6dd:e96c:7f4 with SMTP id z11-20020a9d7a4b000000b006dde96c07f4mr944507otm.47.1704961880290; Thu, 11 Jan 2024 00:31:20 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Corwin Brust Date: Thu, 11 Jan 2024 02:31:08 -0600 Message-ID: Subject: Re: bug#67667: wrong phrasing in installation wizard seen in emacs-29.1_2-installer.exe To: Stefan Kangas Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 67667 Cc: sebboh@the-good-guys.net, 67667@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Wed, Jan 10, 2024 at 11:54=E2=80=AFAM Corwin Brust wrote= : > > On Wed, Jan 10, 2024 at 11:37=E2=80=AFAM Stefan Kangas wrote: > > > > sebboh@the-good-guys.net writes: > > > > > This screenshot says it all. http://0x0.st/H3iS.png > > > > > > As I understand it, it is not a requirement of GPLv3 that the user > > > "accept" the "terms" of the "agreement" in order to perform an > > > installation. > > > > > > I recommend removing the "if you accept ..." language and changing th= e > > > "I Agree" button to just "OK" or "Noted...", or "Next". > > > > Corwin, what do you think? > > > > I agree. Let's patch it. > I've taken a first -entirely "functional"- swing. WDYT? This should be a comparable screen-shot to yours, sebboh. https://bru.st/i/emacs-30.0.50-installer-NEW_WjvTInvkeC.png This folder on contains the usual items for a Windows snapshot build unaltered vs rev dc1f18, plus a few more: https://corwin.bru.st/emacs-30/emacs-30-dc1f18 The "extra" items are: emacs-30.0.50-installer-NEW.exe - build with patch applied emacs.patched.nsi - installer script after applying patch 0001_windows_installer_license_verbage.patch - this patch: --- /g/emacs-29/admin/nt/dist-build/emacs.nsi 2023-09-05 03:56:12.381580000 -0500 +++ emacs.nsi 2024-01-11 02:00:31.143091400 -0600 @@ -10,7 +10,7 @@ Var StartMenuFolder -!define MUI_WELCOMEPAGE_TITLE "Emacs" +!define MUI_WELCOMEPAGE_TITLE "Emacs ${EMACS_VERSION} Setup" !define MUI_WELCOMEPAGE_TITLE_3LINES !define MUI_WELCOMEPAGE_TEXT "Welcome to Emacs -- the editor of a lifetime= ." @@ -20,8 +20,11 @@ !insertmacro MUI_PAGE_WELCOME - -!define MUI_LICENSEPAGE_TEXT_TOP "The GNU General Public License" +!define MUI_PAGE_HEADER_TEXT "Emacs is Free Software" +!define MUI_PAGE_HEADER_SUBTEXT "A component of the GNU operating system." +!define MUI_LICENSEPAGE_TEXT_TOP "This program is free software." +!define MUI_LICENSEPAGE_TEXT_BOTTOM "You can redistribute this program and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License (as above), or (at your option) any later version." +!define MUI_LICENSEPAGE_BUTTON "OK" !insertmacro MUI_PAGE_LICENSE "emacs-${VERSION_BRANCH}\share\emacs\${EMACS_VERSION}\lisp\COPYING" !insertmacro MUI_PAGE_DIRECTORY From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 17:56:56 2024 Received: (at 67667) by debbugs.gnu.org; 11 Feb 2024 22:56:56 +0000 Received: from localhost ([127.0.0.1]:56128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZIkp-0007zw-7F for submit@debbugs.gnu.org; Sun, 11 Feb 2024 17:56:56 -0500 Received: from mail-oa1-f54.google.com ([209.85.160.54]:54609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZIkl-0007zT-R7; Sun, 11 Feb 2024 17:56:52 -0500 Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-21959151f4fso1061058fac.1; Sun, 11 Feb 2024 14:56:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707692189; x=1708296989; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pdRpbugKJD/gh9Fr9Nv3QkqvO/r6Tvl9Yke2BKGBE4U=; b=rjE3lbdQoL4HYpYg/JX8wzUNQ5z6xQGXk6Fy1nWQWjC/NnZHCgWKbmXRuoBhl5p7Zo 7nuDTCFZcjOjq6errWXxI8BFoo42+ghBzCEypgK3FNwtFl7altjpmeVpTA1FQSPksfTZ epx2yWNR+V5ARiKg+dXKlgiMvHHOKLIbiAA78wmn0W19dwnpQBWIQuoUIraEjk4ZtNba AIgqq0YILfLGXBPb9PPz+u6r2VfR+2Rc4CDp0uTJn2L3amS16NQ0JG+pXDroq9j8XJ1F ybQ4ZOEGyDPzmr10PNQ5VtOD7fChcs5sh7zjLSuapkW8FA7h1ffQCOiCFxuuj4QN4sV9 1g5g== X-Forwarded-Encrypted: i=1; AJvYcCWUI+x8QGPkWZ+v3aOzPwTbJW5fl8na7qzeaeYhPL58QO84+fUy4aDKf8R5MRAhttLjT+lMDnHoiHIRo9of6qjJBCvzJTg= X-Gm-Message-State: AOJu0Yzjm7VHRQzRWoZGZduc8JGpn8yjvStdsUkX2X0hUd3beeWS2h9x Oo8CjHP9LWGmNhpy5wEwKKHErsY08WuithwRc8EYnIsvT5fXJwp8Ed/mzWGkQRpQj5cSL5YbGH0 56DmELVkPTY7SKOQ+/0a8fmRdMzw= X-Google-Smtp-Source: AGHT+IFrSMIp9Se23hJKW0TPRs8SSZb/DbJYLJBrH6NSZvZP0PddDgzP+GkrwaCd9/JeWUUgpekNr59Wmqn7GEZL3Nk= X-Received: by 2002:a05:6871:112:b0:219:3b40:702a with SMTP id y18-20020a056871011200b002193b40702amr4271753oab.35.1707692189394; Sun, 11 Feb 2024 14:56:29 -0800 (PST) MIME-Version: 1.0 References: <37a30898d11190e4e6e03faafecde143d90b7d9d.camel@aegee.org> In-Reply-To: From: Corwin Brust Date: Sun, 11 Feb 2024 16:56:17 -0600 Message-ID: Subject: Re: bug#68756: Uninstalling emacs does not remove Start Menu entries created during the installation To: Stefan Kangas , =?UTF-8?B?0JTQuNC70Y/QvSDQn9Cw0LvQsNGD0LfQvtCy?= Content-Type: multipart/mixed; boundary="000000000000568f1d06112312e7" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 67667 Cc: 68756@debbugs.gnu.org, 67667@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --000000000000568f1d06112312e7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable tags 68756 + patch thanks =D0=94=D0=B8=D0=BB=D1=8F=D0=BD, I have created an installer based on the a= ttached patch and posted it to my own site. If you try that out please let me know what you think. https://bru.st/i/emacs-29.2.50_bug%2358756-installer.exe Note, this is based on the "tip" of the emacs-29 branch, and not built from the release sources for no other reason than expediency: I am running a CI locally so I can easily test changes to the NSI installer without (especially) compiling other things. And that also means I'm quite open to trying things, if we come up with more adventurous changes than those proposed here. Reprising your original expectations: > =E2=80=A2 Uninstalling emacs should remove the Start Menu directories, cr= eated during installing emacs. This is fixed, I believe, however a bug remains (I will file a new bug given we wind up taking things in pieces, as I'm suggesting): customizing the name of the Start Menu folder isn't working for me with or without this patch. Meanwhile: > =E2=80=A2 Installing emacs should ask to first remove the previously inst= alled emacs version, as long as it does not do inplace upgrade (substitutio= n). Per this patch I did not add any Sections or controls, however a given uninstaller will no-longer delete any other versions beside the one it installed. I am open to better and more dramatic changes, but I think it might make sense to work in stages, perhaps under quite granular bug reports. In any event, I expect to "work my way up" to any more complex changes needed to the NSI script incrementally. Stefan, I think the attached minimal change, plus the other patch for not needing to "accept" licensing in 67667 (which tracker I've added in CC), would be a good basis for making a 29.2_2. Ideally, we could push these two and then I will create a 29.2_2 set. From there, I'll probably focus on improving things for the 30.1 series pre-tests notwithstanding "show stoppers" with the top-of-stack 29.x binaries. I can work on (each of) this smaller changes as much as needed, but I'd like to keep the installer simple while we do. (E.g. defer adding any new Sections/pages or controls we can live without until Emacs 30.) As an example of something not addressed by the patch, only the mostly recently installed Emacs can be uninstalled. To address that will require giving each uninstaller a unique name as part of creating it under the installation target directory. I'm fairly confident I'll get that right, but I'm not as confident as I am of the one attached. Moreover, I would prioritize fixing the issue of (potentially) deleting several installed versions without mentioning (which, =D0=94=D0=B8= =D0=BB=D1=8F=D0=BD, thank you again for reporting that that is happening). Corwin --000000000000568f1d06112312e7 Content-Type: application/octet-stream; name="0001-admin-nt-dist-build-emacs.nsi-Uninstall-delete-one-version-only.patch" Content-Disposition: attachment; filename="0001-admin-nt-dist-build-emacs.nsi-Uninstall-delete-one-version-only.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lsi1vvja0 KiBhZG1pbi9udC9kaXN0LWJ1aWxkL2VtYWNzLm5zaTogKFVuaW5zdGFsbCkgZGVsZXRlIG9ubHkg b25lIHZlcnNpb24KClByZXZpb3VzbHksIHRoZSB1bmluc3RhbGxlciB3b3VsZCByZWN1cnNpdmVs eSwgdW5jb25kaXRpb25hbGx5LCByZW1vdmUKdGhlIHBhcmVudCBmb2xkZXIsIHJhdGhlciB0aGFu IHRoZSBzdWItZm9sZGVyIGNvbnRhaW5pbmcgdGhlIGJpbmFyaWVzCmNvcnJpc3BvbmRpbmcgdG8g dGhlIGluc3RhbGxlci4gIE5vdyBVbmluc3RhbGwgd2lsbCBhbHdheXMgcmVtb3ZlIHRoZQpmaWxl cyBjb3BpZWQgZHVyaW5nIEluc3RhbGwgYW5kIHJlbW92ZSAoZS5nLikgIlByb2dyYW0gRmlsZXNc RW1hY3MiIG9ubHkKaWYgbm8gb3RoZXIgKGUuZy4pICBjb3BpZXMgb2YgRW1hY3MgKG9yIG90aGVy IGZpbGVzKSByZW1haW4KdGhlcmVpbi4gQWRkaXRpb25hbGx5LCB0aGUgdW5pbnN0YWxsZXIgZGlk IG5vdCByZW1vdmUgdGhlIFNob3J0Y3V0IHRvCnJ1bmVtYWNzLmV4ZSwgcHJldmVudGluZyBkZWxl dGlvbiBvZiB0aGUgU3RhcnQgTWVudSBlbnRyeS4gKEJ1ZyM1Njg1NikKLS0tCiBhZG1pbi9udC9k aXN0LWJ1aWxkL2VtYWNzLm5zaSB8IDggKysrKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvYWRtaW4vbnQvZGlzdC1idWls ZC9lbWFjcy5uc2kgYi9hZG1pbi9udC9kaXN0LWJ1aWxkL2VtYWNzLm5zaQppbmRleCA1NTdiYjEw NmRkZS4uYmM5ZGI2MWI5YWUgMTAwNjQ0Ci0tLSBhL2FkbWluL250L2Rpc3QtYnVpbGQvZW1hY3Mu bnNpCisrKyBiL2FkbWluL250L2Rpc3QtYnVpbGQvZW1hY3MubnNpCkBAIC02NiwxMiArNjYsMTYg QEAgU2VjdGlvbiAiVW5pbnN0YWxsIgogICAjIEFsd2F5cyBkZWxldGUgdW5pbnN0YWxsZXIgZmly c3QKICAgRGVsZXRlICIkSU5TVERJUlxVbmluc3RhbGwuZXhlIgogCi0gICMgbm93IGRlbGV0ZSBp bnN0YWxsZWQgZGlyZWN0b3J5Ci0gIFJNRGlyIC9yICIkSU5TVERJUiIKKyAgIyByZWN1cnNpdmVs eSBkZWxldGUgZGlyZWN0b3J5IGZvciB0aGlzIHZlcnNpb24KKyAgUk1EaXIgL3IgIiRJTlNURElS XGVtYWNzLSR7VkVSU0lPTl9CUkFOQ0h9IgorCisgICMgcmVtb3ZlIHRoZSBFbWFjcyBkaXJlY3Rv cnkgaW4gUHJvZ3JhbSBGaWxlcyAoaWYgZW1wdHkpCiAgIFJNRGlyICIkSU5TVERJUiIKIAogICAh aW5zZXJ0bWFjcm8gTVVJX1NUQVJUTUVOVV9HRVRGT0xERVIgQXBwbGljYXRpb24gJFN0YXJ0TWVu dUZvbGRlcgogCisgICMgcmVtb3ZlIFN0YXJ0IE1lbnUgUHJvZ3JhbSBzaG9ydGN1dHMKKyAgRGVs ZXRlICIkU01QUk9HUkFNU1wkU3RhcnRNZW51Rm9sZGVyXEVtYWNzLmxuayIKICAgRGVsZXRlICIk U01QUk9HUkFNU1wkU3RhcnRNZW51Rm9sZGVyXFVuaW5zdGFsbC5sbmsiCiAgIFJNRGlyICIkU01Q Uk9HUkFNU1wkU3RhcnRNZW51Rm9sZGVyIgogU2VjdGlvbkVuZAotLSAKMi4zNi4xCgo= --000000000000568f1d06112312e7-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 15 13:27:59 2024 Received: (at 67667) by debbugs.gnu.org; 15 Feb 2024 18:27:59 +0000 Received: from localhost ([127.0.0.1]:57002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ragSk-0003Rf-Na for submit@debbugs.gnu.org; Thu, 15 Feb 2024 13:27:59 -0500 Received: from mail.aegee.org ([144.76.142.78]:33128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ragSh-0003RH-5g; Thu, 15 Feb 2024 13:27:56 -0500 Authentication-Results: mail.aegee.org/41FIROwJ3977909; auth=pass (PLAIN) smtp.auth=didopalauzov@aegee.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aegee.org; s=k4096; t=1708021645; i=dkim+MSA-ssl@aegee.org; bh=pch9I7uJrjnlF0HgKgdC8sJfzUOVyLEFk0ImVFci6mE=; h=Date:From:To:CC:Subject:In-Reply-To:References; b=Bp0pvxTraTUQTw3yguRatVuez3D/LzkibCQoTrhd+yeOWZYEV/OoeEKAamdC/zcHB rnT4NyFSn+VPl0okpjQPhcbE7mmnn5o4H8VuA7+U9guOlbK0QEgFWvCsY454wb8/ua u6+YofqVGtxopoRuoepa36ClcEP9BmXY6/CbLF4cXHshiHq5+yT/I0g1D+A9mHA7tE 5MnuUELJLM5MPci66MfCEYYbC8FycwyUmNhtkv7CmhHa+qINcq7kFlI3RXKyP3tdyg lYkVWTcPbcSVJosmKFVf6NnnUBojrJxdpDQCjf42dQXWYU/YiyuX69P+v1jkLrWZK/ CTtwVbFwWfsgfa5olueb9SqayKlYjDdW65Kk2buEoKjc94DHEt71RTk07APzXm/ZXJ uFnjjcHRsLvVtAamLUM0ybjn15pTJi+MHCgLRqhu30iuaKKtFy1qqSF/LJIcBwziD0 RAhk/hfOvxc2KOc8nFR+7425LgpEL8YDfwS9+DYX6T/OKmhQ14gKcP0I4Fe0wzERud s7as+NIzjmrBOBr+FU+mDha7IVKih37+DxO2jxh6/xixlr3R1qqO+15QNvPSlrcFIW Ylxp9dmLZuO+dPfoNmPF95rPrbM1rG7POxZQxoPfvBjmGnHkOc2QIq4HvIVNWjQ//u zRzJxEYvuifi/AJf9DmmSFkg= Authentication-Results: mail.aegee.org/41FIROwJ3977909; dkim=none Received: from [127.0.0.1] (x527162f2.dyn.telefonica.de [82.113.98.242] (may be forged)) (authenticated bits=0) by mail.aegee.org (8.17.2/8.17.2) with ESMTPSA id 41FIROwJ3977909 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 15 Feb 2024 18:27:25 GMT Date: Thu, 15 Feb 2024 18:27:17 +0000 From: =?UTF-8?B?0JTQuNC70Y/QvSDQn9Cw0LvQsNGD0LfQvtCy?= To: Corwin Brust , Stefan Kangas Subject: =?US-ASCII?Q?Re=3A_bug=2368756=3A_Uninstalling_emacs_does_not_remove_?= =?US-ASCII?Q?Start_Menu_entries_created_during_the_installation?= User-Agent: K-9 Mail for Android In-Reply-To: References: <37a30898d11190e4e6e03faafecde143d90b7d9d.camel@aegee.org> Message-ID: <5E06E817-4C3F-42F1-8901-73DA5A069CB9@aegee.org> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary=----5CO3JWEBLHFV1JDDIT0UD5UW7RVVYQ Content-Transfer-Encoding: 7bit X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 67667 Cc: 68756@debbugs.gnu.org, 67667@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) ------5CO3JWEBLHFV1JDDIT0UD5UW7RVVYQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Corwin, before installing emacs-29=2E2=2E50_bug#58756-installer=2Eexe I have insta= lled emacs-29=2E2-installer=2Eexe =2E The latter has created a Start Menu g= roup emacs 29=2E2 with two icons - emacs and uninstall=2E After installing = emacs-29=2E2=2E50_bug#58756-installer=2Eexe it creates separate Start Menu = directory 29=2E2=2E50=2E The Start menu Emacs 29=2E2/uninstall disappears= =2E After clicking Start Menu/emacs 29=2E2=2E50/uninstall the entry Emacs 2= 9=2E2/uninstall appears again, but it is now dysfunctional=2E Apart from th= is, uninstalling 29=2E2=2E50 does remove the Start Menu entries it has crea= ted=2E I cannot test if two different versions work during install/uninstal= l as expected, since I have no two different versions which are at the same= time =E2=80=9Cfixed=E2=80=9D=2E Kind regards =D0=94=D0=B8=D0=BB=D1=8F=D0=BD=20 =D0=9D=D0=B0 11 =D1=84=D0=B5=D0=B2=D1=80=D1=83=D0=B0=D1=80=D0=B8 2024 =D0= =B3=2E 22:56:17 UTC, Corwin Brust =D0=BD=D0=B0=D0=BF=D0= =B8=D1=81=D0=B0: >tags 68756 + patch >thanks > >=D0=94=D0=B8=D0=BB=D1=8F=D0=BD, I have created an installer based on the= attached patch and >posted it to my own site=2E If you try that out please let me know what >you think=2E > >https://bru=2Est/i/emacs-29=2E2=2E50_bug%2358756-installer=2Eexe > >Note, this is based on the "tip" of the emacs-29 branch, and not built >from the release sources for no other reason than expediency: I am >running a CI locally so I can easily test changes to the NSI installer >without (especially) compiling other things=2E And that also means I'm >quite open to trying things, if we come up with more adventurous >changes than those proposed here=2E > >Reprising your original expectations: > >> =E2=80=A2 Uninstalling emacs should remove the Start Menu directories, = created during installing emacs=2E > >This is fixed, I believe, however a bug remains (I will file a new bug >given we wind up taking things in pieces, as I'm suggesting): >customizing the name of the Start Menu folder isn't working for me >with or without this patch=2E Meanwhile: > >> =E2=80=A2 Installing emacs should ask to first remove the previously in= stalled emacs version, as long as it does not do inplace upgrade (substitut= ion)=2E > >Per this patch I did not add any Sections or controls, however a given >uninstaller will no-longer delete any other versions beside the one it >installed=2E > >I am open to better and more dramatic changes, but I think it might >make sense to work in stages, perhaps under quite granular bug >reports=2E In any event, I expect to "work my way up" to any more >complex changes needed to the NSI script incrementally=2E > >Stefan, > >I think the attached minimal change, plus the other patch for not >needing to "accept" licensing in 67667 (which tracker I've added in >CC), would be a good basis for making a 29=2E2_2=2E Ideally, we could >push these two and then I will create a 29=2E2_2 set=2E From there, I'll >probably focus on improving things for the 30=2E1 series pre-tests >notwithstanding "show stoppers" with the top-of-stack 29=2Ex binaries=2E >I can work on (each of) this smaller changes as much as needed, but >I'd like to keep the installer simple while we do=2E (E=2Eg=2E defer addi= ng >any new Sections/pages or controls we can live without until Emacs >30=2E) > >As an example of something not addressed by the patch, only the mostly >recently installed Emacs can be uninstalled=2E To address that will >require giving each uninstaller a unique name as part of creating it >under the installation target directory=2E I'm fairly confident I'll >get that right, but I'm not as confident as I am of the one attached=2E >Moreover, I would prioritize fixing the issue of (potentially) >deleting several installed versions without mentioning (which, =D0=94=D0= =B8=D0=BB=D1=8F=D0=BD, >thank you again for reporting that that is happening)=2E > > >Corwin ------5CO3JWEBLHFV1JDDIT0UD5UW7RVVYQ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Hello Corwin,

before inst= alling emacs-29=2E2=2E50_bug#58756-installer=2Eexe I have installed emacs-2= 9=2E2-installer=2Eexe =2E The latter has created a Start Menu group emacs 2= 9=2E2 with two icons - emacs and uninstall=2E After installing emacs-29=2E2= =2E50_bug#58756-installer=2Eexe it creates separate Start Menu directory 29= =2E2=2E50=2E The Start menu Emacs 29=2E2/uninstall disappears=2E After clic= king Start Menu/emacs 29=2E2=2E50/uninstall the entry Emacs 29=2E2/uninstal= l appears again, but it is now dysfunctional=2E Apart from this, uninstalli= ng 29=2E2=2E50 does remove the Start Menu entries it has created=2E I canno= t test if two different versions work during install/uninstall as expected,= since I have no two different versions which are at the same time =E2=80= =9Cfixed=E2=80=9D=2E

Kind regards
=C2=A0 =D0=94=D0=B8=D0=BB=D1=8F= =D0=BD


=D0=9D=D0= =B0 11 =D1=84=D0=B5=D0=B2=D1=80=D1=83=D0=B0=D1=80=D0=B8 2024 =D0=B3=2E 22:5= 6:17 UTC, Corwin Brust <corwin@bru=2Est> =D0=BD=D0=B0=D0=BF=D0=B8=D1= =81=D0=B0:
tags 68756 + patch
thanks
=D0=94=D0=B8=D0=BB=D1=8F=D0=BD,  I have created an installer based on the=
 attached patch and
posted it to my own site=2E  If you try that out ple=
ase let me know what
you think=2E

https://bru=2Est/i/emacs-29=
=2E2=2E50_bug%2358756-installer=2Eexe

Note, this is based on the=
 "tip" of the emacs-29 branch, and not built
from the release sources fo=
r no other reason than expediency: I am
running a CI locally so I can ea=
sily test changes to the NSI installer
without (especially) compiling ot=
her things=2E  And that also means I'm
quite open to trying things, if w=
e come up with more adventurous
changes than those proposed here=2E
<=
br>Reprising your original expectations:

=E2=80=A2 Uninstalling emacs =
should remove the Start Menu directories, created during installing emacs=
=2E

This is fixed, I believe, h=
owever a bug remains (I will file a new bug
given we wind up taking thin=
gs in pieces, as I'm suggesting):
customizing the name of the Start Menu=
 folder isn't working for me
with or without this patch=2E  Meanwhile:
=E2=80=A2 Installing emacs should ask to first remove the previously in=
stalled emacs version, as long as it does not do inplace upgrade (substitut=
ion)=2E

Per this patch I did no=
t add any Sections or controls, however a given
uninstaller will no-long=
er delete any other versions beside the one it
installed=2E

I am =
open to better and more dramatic changes, but I think it might
make sens=
e to work in stages, perhaps under quite granular bug
reports=2E  In any=
 event, I expect to "work my way up" to any more
complex changes needed =
to the NSI script incrementally=2E

Stefan,

I think the attach=
ed minimal change, plus the other patch for not
needing to "accept" lice=
nsing in 67667 (which tracker I've added in
CC), would be a good basis f=
or making a 29=2E2_2=2E  Ideally, we could
push these two and then I wil=
l create a 29=2E2_2 set=2E  From there, I'll
probably focus on improving=
 things for the 30=2E1 series pre-tests
notwithstanding "show stoppers" =
with the top-of-stack 29=2Ex binaries=2E
I can work on (each of) this sm=
aller changes as much as needed, but
I'd like to keep the installer simp=
le while we do=2E (E=2Eg=2E defer adding
any new Sections/pages or contr=
ols we can live without until Emacs
30=2E)

As an example of somet=
hing not addressed by the patch, only the mostly
recently installed Emac=
s can be uninstalled=2E  To address that will
require giving each uninst=
aller a unique name as part of creating it
under the installation target=
 directory=2E  I'm fairly confident I'll
get that right, but I'm not as =
confident as I am of the one attached=2E
Moreover, I would prioritize fi=
xing the issue of (potentially)
deleting several installed versions with=
out mentioning (which, =D0=94=D0=B8=D0=BB=D1=8F=D0=BD,
thank you again f=
or reporting that that is happening)=2E


Corwin
------5CO3JWEBLHFV1JDDIT0UD5UW7RVVYQ--