GNU bug report logs - #67667
wrong phrasing in installation wizard seen in emacs-29.1_2-installer.exe

Previous Next

To reply to this bug, email your comments to 67667 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: sebboh <at> the-good-guys.net
To: bug-gnu-emacs <at> gnu.org
Subject: wrong phrasing in installation wizard seen in
 emacs-29.1_2-installer.exe
Date: Wed, 6 Dec 2023 14:38:23 -0600

Hello.

This screenshot says it all.  http://0x0.st/H3iS.png

As I understand it, it is not a requirement of GPLv3 that the user
"accept" the "terms" of the "agreement" in order to perform an
installation.

I recommend removing the "if you accept ..." language and changing the
"I Agree" button to just "OK" or "Noted...", or "Next".

Cheers,
--sebboh

Message #8 received at 67667 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: sebboh <at> the-good-guys.net
Cc: Corwin Brust <corwin <at> bru.st>, 67667 <at> debbugs.gnu.org
Subject: Re: bug#67667: wrong phrasing in installation wizard seen in
 emacs-29.1_2-installer.exe
Date: Wed, 10 Jan 2024 09:37:43 -0800

sebboh <at> the-good-guys.net writes:

> Hello.
>
> This screenshot says it all.  http://0x0.st/H3iS.png
>
> As I understand it, it is not a requirement of GPLv3 that the user
> "accept" the "terms" of the "agreement" in order to perform an
> installation.
>
> I recommend removing the "if you accept ..." language and changing the
> "I Agree" button to just "OK" or "Noted...", or "Next".

Corwin, what do you think?

Message #13 received at 67667 <at> debbugs.gnu.org (full text, mbox):

From: Corwin Brust <corwin <at> bru.st>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: sebboh <at> the-good-guys.net, 67667 <at> debbugs.gnu.org
Subject: Re: bug#67667: wrong phrasing in installation wizard seen in
 emacs-29.1_2-installer.exe
Date: Wed, 10 Jan 2024 11:54:31 -0600

On Wed, Jan 10, 2024 at 11:37 AM Stefan Kangas <stefankangas <at> gmail.com> wrote:
>
> sebboh <at> the-good-guys.net writes:
>
> > Hello.
> >
> > This screenshot says it all.  http://0x0.st/H3iS.png
> >
> > As I understand it, it is not a requirement of GPLv3 that the user
> > "accept" the "terms" of the "agreement" in order to perform an
> > installation.
> >
> > I recommend removing the "if you accept ..." language and changing the
> > "I Agree" button to just "OK" or "Noted...", or "Next".
>
> Corwin, what do you think?
>

I agree.  Let's patch it.

I'll send something if I don't see someone else has already pushed a
fix for this.  I assume this might wait for me since I'm in a position
to test it fairly easily.

Message #16 received at 67667 <at> debbugs.gnu.org (full text, mbox):

From: Corwin Brust <corwin <at> bru.st>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: sebboh <at> the-good-guys.net, 67667 <at> debbugs.gnu.org
Subject: Re: bug#67667: wrong phrasing in installation wizard seen in
 emacs-29.1_2-installer.exe
Date: Thu, 11 Jan 2024 02:31:08 -0600

On Wed, Jan 10, 2024 at 11:54 AM Corwin Brust <corwin <at> bru.st> wrote:
>
> On Wed, Jan 10, 2024 at 11:37 AM Stefan Kangas <stefankangas <at> gmail.com> wrote:
> >
> > sebboh <at> the-good-guys.net writes:
> >
> > > This screenshot says it all.  http://0x0.st/H3iS.png
> > >
> > > As I understand it, it is not a requirement of GPLv3 that the user
> > > "accept" the "terms" of the "agreement" in order to perform an
> > > installation.
> > >
> > > I recommend removing the "if you accept ..." language and changing the
> > > "I Agree" button to just "OK" or "Noted...", or "Next".
> >
> > Corwin, what do you think?
> >
>
> I agree.  Let's patch it.
>

I've taken a first -entirely "functional"- swing.  WDYT?

This should be a comparable screen-shot to yours, sebboh.
  https://bru.st/i/emacs-30.0.50-installer-NEW_WjvTInvkeC.png

This folder on contains the usual items for a Windows snapshot build
unaltered vs rev dc1f18, plus a few more:
  https://corwin.bru.st/emacs-30/emacs-30-dc1f18

The "extra" items are:
  emacs-30.0.50-installer-NEW.exe - build with patch applied
  emacs.patched.nsi - installer script after applying patch
  0001_windows_installer_license_verbage.patch - this patch:

--- /g/emacs-29/admin/nt/dist-build/emacs.nsi 2023-09-05
03:56:12.381580000 -0500
+++ emacs.nsi 2024-01-11 02:00:31.143091400 -0600
@@ -10,7 +10,7 @@
 Var StartMenuFolder


-!define MUI_WELCOMEPAGE_TITLE "Emacs"
+!define MUI_WELCOMEPAGE_TITLE "Emacs ${EMACS_VERSION} Setup"
 !define MUI_WELCOMEPAGE_TITLE_3LINES
 !define MUI_WELCOMEPAGE_TEXT "Welcome to Emacs -- the editor of a lifetime."

@@ -20,8 +20,11 @@

 !insertmacro MUI_PAGE_WELCOME

-
-!define MUI_LICENSEPAGE_TEXT_TOP "The GNU General Public License"
+!define MUI_PAGE_HEADER_TEXT "Emacs is Free Software"
+!define MUI_PAGE_HEADER_SUBTEXT "A component of the GNU operating system."
+!define MUI_LICENSEPAGE_TEXT_TOP "This program is free software."
+!define MUI_LICENSEPAGE_TEXT_BOTTOM "You can redistribute this
program and/or modify it under the terms of the GNU General Public
License as published by the Free Software Foundation, either version 3
of the License (as above), or (at your option) any later version."
+!define MUI_LICENSEPAGE_BUTTON "OK"
 !insertmacro MUI_PAGE_LICENSE
"emacs-${VERSION_BRANCH}\share\emacs\${EMACS_VERSION}\lisp\COPYING"

 !insertmacro MUI_PAGE_DIRECTORY

Message #19 received at 67667 <at> debbugs.gnu.org (full text, mbox):

From: Corwin Brust <corwin <at> bru.st>
To: Stefan Kangas <stefankangas <at> gmail.com>, 
 Дилян Палаузов <dilyan.palauzov <at> aegee.org>
Cc: 68756 <at> debbugs.gnu.org, 67667 <at> debbugs.gnu.org
Subject: Re: bug#68756: Uninstalling emacs does not remove Start Menu entries
 created during the installation
Date: Sun, 11 Feb 2024 16:56:17 -0600

[Message part 1 (text/plain, inline)]

tags 68756 + patch
thanks

Дилян,  I have created an installer based on the attached patch and
posted it to my own site.  If you try that out please let me know what
you think.

https://bru.st/i/emacs-29.2.50_bug%2358756-installer.exe

Note, this is based on the "tip" of the emacs-29 branch, and not built
from the release sources for no other reason than expediency: I am
running a CI locally so I can easily test changes to the NSI installer
without (especially) compiling other things.  And that also means I'm
quite open to trying things, if we come up with more adventurous
changes than those proposed here.

Reprising your original expectations:

> • Uninstalling emacs should remove the Start Menu directories, created during installing emacs.

This is fixed, I believe, however a bug remains (I will file a new bug
given we wind up taking things in pieces, as I'm suggesting):
customizing the name of the Start Menu folder isn't working for me
with or without this patch.  Meanwhile:

> • Installing emacs should ask to first remove the previously installed emacs version, as long as it does not do inplace upgrade (substitution).

Per this patch I did not add any Sections or controls, however a given
uninstaller will no-longer delete any other versions beside the one it
installed.

I am open to better and more dramatic changes, but I think it might
make sense to work in stages, perhaps under quite granular bug
reports.  In any event, I expect to "work my way up" to any more
complex changes needed to the NSI script incrementally.

Stefan,

I think the attached minimal change, plus the other patch for not
needing to "accept" licensing in 67667 (which tracker I've added in
CC), would be a good basis for making a 29.2_2.  Ideally, we could
push these two and then I will create a 29.2_2 set.  From there, I'll
probably focus on improving things for the 30.1 series pre-tests
notwithstanding "show stoppers" with the top-of-stack 29.x binaries.
I can work on (each of) this smaller changes as much as needed, but
I'd like to keep the installer simple while we do. (E.g. defer adding
any new Sections/pages or controls we can live without until Emacs
30.)

As an example of something not addressed by the patch, only the mostly
recently installed Emacs can be uninstalled.  To address that will
require giving each uninstaller a unique name as part of creating it
under the installation target directory.  I'm fairly confident I'll
get that right, but I'm not as confident as I am of the one attached.
Moreover, I would prioritize fixing the issue of (potentially)
deleting several installed versions without mentioning (which, Дилян,
thank you again for reporting that that is happening).


Corwin

[0001-admin-nt-dist-build-emacs.nsi-Uninstall-delete-one-version-only.patch (application/octet-stream, attachment)]

Message #22 received at 67667 <at> debbugs.gnu.org (full text, mbox):

From: Дилян Палаузов
 <Dilyan.Palauzov <at> aegee.org>
To: Corwin Brust <corwin <at> bru.st>, Stefan Kangas <stefankangas <at> gmail.com>
Cc: 68756 <at> debbugs.gnu.org, 67667 <at> debbugs.gnu.org
Subject: Re: bug#68756: Uninstalling emacs does not remove Start Menu entries created during the installation
Date: Thu, 15 Feb 2024 18:27:17 +0000

[Message part 1 (text/plain, inline)]

Hello Corwin,

before installing emacs-29.2.50_bug#58756-installer.exe I have installed emacs-29.2-installer.exe . The latter has created a Start Menu group emacs 29.2 with two icons - emacs and uninstall. After installing emacs-29.2.50_bug#58756-installer.exe it creates separate Start Menu directory 29.2.50. The Start menu Emacs 29.2/uninstall disappears. After clicking Start Menu/emacs 29.2.50/uninstall the entry Emacs 29.2/uninstall appears again, but it is now dysfunctional. Apart from this, uninstalling 29.2.50 does remove the Start Menu entries it has created. I cannot test if two different versions work during install/uninstall as expected, since I have no two different versions which are at the same time “fixed”.

Kind regards
  Дилян 

На 11 февруари 2024 г. 22:56:17 UTC, Corwin Brust <corwin <at> bru.st> написа:
>tags 68756 + patch
>thanks
>
>Дилян,  I have created an installer based on the attached patch and
>posted it to my own site.  If you try that out please let me know what
>you think.
>
>https://bru.st/i/emacs-29.2.50_bug%2358756-installer.exe
>
>Note, this is based on the "tip" of the emacs-29 branch, and not built
>from the release sources for no other reason than expediency: I am
>running a CI locally so I can easily test changes to the NSI installer
>without (especially) compiling other things.  And that also means I'm
>quite open to trying things, if we come up with more adventurous
>changes than those proposed here.
>
>Reprising your original expectations:
>
>> • Uninstalling emacs should remove the Start Menu directories, created during installing emacs.
>
>This is fixed, I believe, however a bug remains (I will file a new bug
>given we wind up taking things in pieces, as I'm suggesting):
>customizing the name of the Start Menu folder isn't working for me
>with or without this patch.  Meanwhile:
>
>> • Installing emacs should ask to first remove the previously installed emacs version, as long as it does not do inplace upgrade (substitution).
>
>Per this patch I did not add any Sections or controls, however a given
>uninstaller will no-longer delete any other versions beside the one it
>installed.
>
>I am open to better and more dramatic changes, but I think it might
>make sense to work in stages, perhaps under quite granular bug
>reports.  In any event, I expect to "work my way up" to any more
>complex changes needed to the NSI script incrementally.
>
>Stefan,
>
>I think the attached minimal change, plus the other patch for not
>needing to "accept" licensing in 67667 (which tracker I've added in
>CC), would be a good basis for making a 29.2_2.  Ideally, we could
>push these two and then I will create a 29.2_2 set.  From there, I'll
>probably focus on improving things for the 30.1 series pre-tests
>notwithstanding "show stoppers" with the top-of-stack 29.x binaries.
>I can work on (each of) this smaller changes as much as needed, but
>I'd like to keep the installer simple while we do. (E.g. defer adding
>any new Sections/pages or controls we can live without until Emacs
>30.)
>
>As an example of something not addressed by the patch, only the mostly
>recently installed Emacs can be uninstalled.  To address that will
>require giving each uninstaller a unique name as part of creating it
>under the installation target directory.  I'm fairly confident I'll
>get that right, but I'm not as confident as I am of the one attached.
>Moreover, I would prioritize fixing the issue of (potentially)
>deleting several installed versions without mentioning (which, Дилян,
>thank you again for reporting that that is happening).
>
>
>Corwin

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.