GNU bug report logs - #67661
30.0.50; *Completions* has started popping up for icomplete-in-buffer

Previous Next

Full log

View this message in rfc822 format

From: Jim Porter <jporterbugs <at> gmail.com>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: 67661 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, john muhl <jm <at> pub.pink>, Eshel Yaron <me <at> eshelyaron.com>, Juri Linkov <juri <at> linkov.net>
Subject: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer
Date: Wed, 17 Jan 2024 11:18:32 -0800

On 1/10/2024 9:55 AM, Sean Whitton wrote:
>> --- a/test/lisp/eshell/em-cmpl-tests.el
>> +++ b/test/lisp/eshell/em-cmpl-tests.el
>> @@ -186,7 +186,7 @@ em-cmpl-test/file-completion/non-unique
>>          (save-excursion
>>            (goto-char (point-max))
>>            (forward-line -1)
>> -         (should (looking-at "Complete, but not unique")))))))
>> +         (should (looking-at "Making completion list...")))))))
>>
>>   (ert-deftest em-cmpl-test/file-completion/glob ()
>>     "Test completion of file names using a glob."
> 
> Jim, does this seem reasonable?

Sorry, I missed this the first time around (I've got a lot of other 
stuff I'm trying to balance at the moment). I think this would fix the 
issue, but I've instead pushed 5f5faad2497 which solves this in a 
more-direct way by checking whether the *Completions* buffer is visible. 
That's what the test is really trying to test anyway.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.