GNU bug report logs - #67661
30.0.50; *Completions* has started popping up for icomplete-in-buffer

Previous Next

Full log

View this message in rfc822 format

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 67661 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, john muhl <jm <at> pub.pink>, Eshel Yaron <me <at> eshelyaron.com>, Juri Linkov <juri <at> linkov.net>
Subject: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer
Date: Wed, 10 Jan 2024 17:55:34 +0000

Hello,

On Tue 09 Jan 2024 at 09:12pm -06, john muhl wrote:

> This commit (d7ff14fcba6) caused an eshell test to start
> failing. It seems like the test was written to account for the
> above mentioned bug in pcomplete but wasn’t sure. Attached is
> the test output and the change in the test to fix it.
>
>
>
> --- a/test/lisp/eshell/em-cmpl-tests.el
> +++ b/test/lisp/eshell/em-cmpl-tests.el
> @@ -186,7 +186,7 @@ em-cmpl-test/file-completion/non-unique
>         (save-excursion
>           (goto-char (point-max))
>           (forward-line -1)
> -         (should (looking-at "Complete, but not unique")))))))
> +         (should (looking-at "Making completion list...")))))))
>
>  (ert-deftest em-cmpl-test/file-completion/glob ()
>    "Test completion of file names using a glob."

Jim, does this seem reasonable?

-- 
Sean Whitton

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.