From unknown Mon Aug 18 11:16:43 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#67661 <67661@debbugs.gnu.org> To: bug#67661 <67661@debbugs.gnu.org> Subject: Status: 30.0.50; *Completions* has started popping up for icomplete-in-buffer Reply-To: bug#67661 <67661@debbugs.gnu.org> Date: Mon, 18 Aug 2025 18:16:43 +0000 retitle 67661 30.0.50; *Completions* has started popping up for icomplete-i= n-buffer reassign 67661 emacs submitter 67661 Sean Whitton severity 67661 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 06 10:30:48 2023 Received: (at submit) by debbugs.gnu.org; 6 Dec 2023 15:30:49 +0000 Received: from localhost ([127.0.0.1]:40206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAtrM-0006p2-IE for submit@debbugs.gnu.org; Wed, 06 Dec 2023 10:30:48 -0500 Received: from lists.gnu.org ([2001:470:142::17]:60228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAtrJ-0006oi-38 for submit@debbugs.gnu.org; Wed, 06 Dec 2023 10:30:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAtqz-0004SC-4E for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2023 10:30:26 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAtqs-0008Ga-9t for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2023 10:30:23 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E98935C02B6 for ; Wed, 6 Dec 2023 10:30:13 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 06 Dec 2023 10:30:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t=1701876613; x=1701963013; bh=Ctlx3h51XYLUugmFdhHShWU7D elt03QKXpVi7aRYWPM=; b=cwKi0QPtxr5P2ouAupLfhCiDtpxuFojg0bJHl1dL5 5wCbPtDwDawRwOirP/R5apHeJMRUfH68zTIQiClD757u9pVZ3mHQZGlU0kVUfjAs oUjzdoP7NAB7oqplYyCgyqiVFy16UAmzfhIutr7D3FP/z6NW/naRy2diYzR05UP1 JWYaQMbA9IWDeEd5yS1UK/47VF02rtF5UP17tRCiqc2cQGaHNXlrmPAIa2Tsdpqi eTsyo+ZmCpDDsAg2WEH5H2EdGcEsrUyxPe2I7y0nzao/MBU0xT32lzDMgRb9wqta lLpbE+EvN928WkHxFTQwx5/ni5hFTK8xxq04s2/gmpMWQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1701876613; x=1701963013; bh=Ctlx3h51XYLUugmFdhHShWU7Delt03QKXpV i7aRYWPM=; b=1P7QM3Uwi8/Zw/pPbGvbDwjbgGJljarz52KRpXm3o4kCDmLepqX 50MNwbDzOBbc5GY2s0hKhhs55hptqOdyiVJA6sZr11z7MQ5AIWUuISDumT1tMPJt wFhUWQKg/5T5ZY3QyHNaKNwcijVtVvKnOsq8ZFSLQSWU7I5ouOBRqzGAvx7Uh6ux l/eOc+ObyHp/hf7cZwJmLNAecyhnLQhpyiCodQJkvzaBrZZH6Gi+B6N6nzzOPEwo I9gHXqLgp/+q40jjj8IhldC69e54pv3ydCjthdyCQkZaW5Er/UrTPb+AFx8xHXPG Gf4PWAdrnwtH+ESHY4lZd85QTYHdrcPgvgw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudektddgjeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkfgggtgesthdttddttd ertdenucfhrhhomhepufgvrghnucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhp fihhihhtthhonhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeffgfehgefggfehuedvte fhkedutdfggfdtueekgeektdetffdtgefhvdfgtdejleenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhith htohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 6 Dec 2023 10:30:13 -0500 (EST) Received: by melete.silentflame.com (Postfix, from userid 1000) id B7BEC7EDF76; Wed, 6 Dec 2023 15:30:12 +0000 (GMT) From: Sean Whitton To: bug-gnu-emacs@gnu.org Subject: 30.0.50; *Completions* has started popping up for icomplete-in-buffer Date: Wed, 06 Dec 2023 15:30:12 +0000 Message-ID: <87o7f3e4cb.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=66.111.4.28; envelope-from=spwhitton@spwhitton.name; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) X-debbugs-cc: juri@linkov.net Hello, 1. emacs -q 2. (setopt icomplete-in-buffer t) 3. M-x icomplete-mode 4. M-x eshell 5. try to tab-complete something where there is more than one possible completion, e.g. ls in a directory with many files. Previously you would get the icomplete in buffer completion. Now, additionally, *Completions* pops up, but it doesn't make sense to have both. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 06 12:28:42 2023 Received: (at 67661) by debbugs.gnu.org; 6 Dec 2023 17:28:42 +0000 Received: from localhost ([127.0.0.1]:40344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAvhS-0001ub-3f for submit@debbugs.gnu.org; Wed, 06 Dec 2023 12:28:42 -0500 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]:44843) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAvhP-0001u2-Pk for 67661@debbugs.gnu.org; Wed, 06 Dec 2023 12:28:40 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id F30FC20007; Wed, 6 Dec 2023 17:28:19 +0000 (UTC) From: Juri Linkov To: Sean Whitton Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <87o7f3e4cb.fsf@melete.silentflame.com> (Sean Whitton's message of "Wed, 06 Dec 2023 15:30:12 +0000") Organization: LINKOV.NET References: <87o7f3e4cb.fsf@melete.silentflame.com> Date: Wed, 06 Dec 2023 19:13:51 +0200 Message-ID: <86h6kvba50.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > 1. emacs -q > 2. (setopt icomplete-in-buffer t) > 3. M-x icomplete-mode > 4. M-x eshell > 5. try to tab-complete something where there is more than one possible > completion, e.g. ls in a directory with many files. > > Previously you would get the icomplete in buffer completion. > Now, additionally, *Completions* pops up, but it doesn't make sense to > have both. Is this related to bug#61943? From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 06 13:14:47 2023 Received: (at 67661) by debbugs.gnu.org; 6 Dec 2023 18:14:47 +0000 Received: from localhost ([127.0.0.1]:40413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAwQ3-0005i4-2T for submit@debbugs.gnu.org; Wed, 06 Dec 2023 13:14:47 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:47219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAwPy-0005hl-72 for 67661@debbugs.gnu.org; Wed, 06 Dec 2023 13:14:46 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id BAAE03200ACF; Wed, 6 Dec 2023 13:14:23 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 06 Dec 2023 13:14:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1701886463; x= 1701972863; bh=ToeLydm+P8pgjc3XbGhz2d1HlaU93tBaclJw8HXdBX0=; b=O I7utU3k/wzEEYRTqEu7RAihIM6glWSlAUT27+aqBL/uemr2g13UYEFueZ/8QSsD+ g8Iz1aZEDF/DsVzZd24Azx1Mrgb7XoKX4NNEjqJBImcmDWu5Js7sGT4ffl9elmmW AhwH5bcXiyLin6hHcMC/s4VsjJtorigr6Izsj9+4SKf0eobz1l7XSEhS5PcdU+Ly +b9892NxFflj4KMm9yjx5HWTfRtYRBEfQB70dk1OEa3r2oibo6YfEFBDTzDZqvxH BIikGXUOUA/hgUx/YecSdIuzeuEp58jVW6SoROO0zPR7lIElPs71wP3d0vWdBgck Z/jH7QUB3NgxRqpT8QrHw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1701886463; x=1701972863; bh=ToeLydm+P8pgj c3XbGhz2d1HlaU93tBaclJw8HXdBX0=; b=oW6kgvelxGqUdDg67t/AVsNobeRgw jxUnYipL4FCvdPlWobDRi+2wm4wyr6IzEUDu++nH6hIXUSALoLSf3lH8ZcJNkfPo KjKuRZhMEt82BqadSauagOi287gi7D0VPbx8/uMFs4TXAant+Ld/osI7h3ocTEBg BTsMO1fzzULMm4lqhrH7fmYvGJydwqFltdHwNsluy9lhr4K01FhQq5U+WEjJwKML mhMq5iwAktX/mDM5Zz1ttkX0LqYMMbGvkJ9pbUH94EUMcY6DQVvlXa+Zoc7GNS2N 6EUr0aQSjbjg9i6VRKAb3t/w5YihkNUtyvT4Zy2NxOBEP9GnMGfIWDIIg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudektddguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedu keeggeelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Dec 2023 13:14:22 -0500 (EST) Received: by melete.silentflame.com (Postfix, from userid 1000) id 7D0337E7BF0; Wed, 6 Dec 2023 18:14:13 +0000 (GMT) From: Sean Whitton To: Juri Linkov Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <86h6kvba50.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 06 Dec 2023 19:13:51 +0200") References: <87o7f3e4cb.fsf@melete.silentflame.com> <86h6kvba50.fsf@mail.linkov.net> Date: Wed, 06 Dec 2023 18:14:13 +0000 Message-ID: <87fs0fdwqy.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Wed 06 Dec 2023 at 07:13pm +02, Juri Linkov wrote: >> 1. emacs -q >> 2. (setopt icomplete-in-buffer t) >> 3. M-x icomplete-mode >> 4. M-x eshell >> 5. try to tab-complete something where there is more than one possible >> completion, e.g. ls in a directory with many files. >> >> Previously you would get the icomplete in buffer completion. >> Now, additionally, *Completions* pops up, but it doesn't make sense to >> have both. > > Is this related to bug#61943? I'm not using fido-mode anymore, so I doubt it. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 06 13:41:26 2023 Received: (at 67661) by debbugs.gnu.org; 6 Dec 2023 18:41:26 +0000 Received: from localhost ([127.0.0.1]:40435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAwpq-0006OK-5K for submit@debbugs.gnu.org; Wed, 06 Dec 2023 13:41:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAwpm-0006O5-Do for 67661@debbugs.gnu.org; Wed, 06 Dec 2023 13:41:24 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAwpT-0001uZ-Iu; Wed, 06 Dec 2023 13:41:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+Boco+JflXn+cRY4UmEysWqPgDmTJkZQ/mUJVcSJ9G0=; b=XjSaefvsRrJQ W8Sj28hYM0ilYt7BJ5m9mkHg0Lx4IXhKS9+Vev0cuPqk9tHRH+Aqx7MGM0KI00mH6sD1OvaWNy4yX WY+NHb+0Ip8gPeL++D/V8l2mNpaWEnGhnR5+vkaSmurxWrB06L36nfskd9GRRiu3SWd1cEoj2BU5W eIvzXPUj+dO5sqa+6mLKYtt00gvNLrE3sW+Z1PxLCnMtOOz2oWzpSBjMOwsEkxWwV/N3v6ji81Vm0 CYjW7XPLWDX5mLw2stCcuyqv2m+lCB8wpzOOpU4Xns7H5usKc42vNIWXyqMfOUpuD9c03pyxUwkR8 xN+4PuGob689gU1eO67khw==; Date: Wed, 06 Dec 2023 20:41:13 +0200 Message-Id: <83wmtr2mye.fsf@gnu.org> From: Eli Zaretskii To: Sean Whitton In-Reply-To: <87o7f3e4cb.fsf@melete.silentflame.com> (message from Sean Whitton on Wed, 06 Dec 2023 15:30:12 +0000) Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer References: <87o7f3e4cb.fsf@melete.silentflame.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: juri@linkov.net > From: Sean Whitton > Date: Wed, 06 Dec 2023 15:30:12 +0000 > > X-debbugs-cc: juri@linkov.net > > Hello, > > 1. emacs -q > 2. (setopt icomplete-in-buffer t) > 3. M-x icomplete-mode > 4. M-x eshell > 5. try to tab-complete something where there is more than one possible > completion, e.g. ls in a directory with many files. > > Previously you would get the icomplete in buffer completion. > Now, additionally, *Completions* pops up, but it doesn't make sense to > have both. AFAICT, the above description of the problem is inaccurate. The *Completions* buffer would pop up in previous versions as well, but only after a second TAB. Whereas the in-buffer completion would show after the first TAB. Now in Emacs 30 after the first TAB nothing happens, and after the second TAB you see the same display as previously after the second TAB: both in-buffer completion and the *Completions* buffer popped up. So I think the problem is that the first TAB does NOT show in-buffer completion anymore in the above scenario. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 07 06:43:00 2023 Received: (at 67661) by debbugs.gnu.org; 7 Dec 2023 11:43:00 +0000 Received: from localhost ([127.0.0.1]:41262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBCmS-0007oT-Ge for submit@debbugs.gnu.org; Thu, 07 Dec 2023 06:43:00 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:34805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBCmQ-0007oE-PB for 67661@debbugs.gnu.org; Thu, 07 Dec 2023 06:42:59 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 43D375C0132; Thu, 7 Dec 2023 06:42:41 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 07 Dec 2023 06:42:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1701949361; x= 1702035761; bh=0v24BVcEXrP1PwDnfDDURv8fjE2Zv/Dx1dY5dyE6Q5s=; b=O dfgFAYjHKK1btvp+NWlFyqk/WuKJXZauy+gm+iUcRxFAqZ7ACc8QIPUPXL20zdIp XrRfXb23i55dpj6vYxZCI7GWZG5vGwlastk0TEvHc2Ztw4iE3OuhuUjEVduLQiQl NUTWetvEn8Z/GcNnFgOWeIqyK5tUPkLeY/3w0BUtcm8plAarFILwpzRk2WARjJlj QmSUY5evPx40S6KpqFkN35Q2YETfQA8WxwuoCgv7gxlJv8dCQNzLi8unIYqWn/W4 uTbwG3RTKVd/NhqJd/XAxi61WAkLiR11bIg3OhJRywrmtB1C+YlB5QU+rTTBNaV9 R+yecRf3KLg223vPOz37Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1701949361; x=1702035761; bh=0v24BVcEXrP1P wDnfDDURv8fjE2Zv/Dx1dY5dyE6Q5s=; b=acDhFUa4ts7DRb6uudguBGLTgD90F wkAOftartu/sjXJrcwHCrYDfFEbHUIL/mTTsE4AAOFJvhewWdWGYKEqF+YW5y2/Q xMJ7i8JBb3Sb8vY9tKnyUDTFIGJpRI+FBQJ8138Tk+T8WHH1v1RbvVfK4z9K/oVZ D4oyHIACatd46wYgqZ6VjgqnU6j5U862zeQtoRuZUGtxlKVSDs6qtPctSIOBX2Bf Mn5st7etibj8+SKUXbW/aAqjfLH5K1Mc9oxlfI7UIk0yBhFWFvK7w41lx5VkFpiw 6SHey6xASf6wFXyRGHhqpXz4wMcqgpo4xZ868xjOFCjbU2i8ODWnpYzkw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudekvddgfeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Dec 2023 06:42:40 -0500 (EST) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 21F3C940FFB; Thu, 7 Dec 2023 11:42:40 +0000 (GMT) From: Sean Whitton To: Eli Zaretskii Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <83wmtr2mye.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 06 Dec 2023 20:41:13 +0200") References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> Date: Thu, 07 Dec 2023 11:42:40 +0000 Message-ID: <87lea62q8f.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eshel Yaron , juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Wed 06 Dec 2023 at 08:41pm +02, Eli Zaretskii wrote: >> Cc: juri@linkov.net >> From: Sean Whitton >> Date: Wed, 06 Dec 2023 15:30:12 +0000 >> >> X-debbugs-cc: juri@linkov.net >> >> Hello, >> >> 1. emacs -q >> 2. (setopt icomplete-in-buffer t) >> 3. M-x icomplete-mode >> 4. M-x eshell >> 5. try to tab-complete something where there is more than one possible >> completion, e.g. ls in a directory with many files. >> >> Previously you would get the icomplete in buffer completion. >> Now, additionally, *Completions* pops up, but it doesn't make sense to >> have both. > > AFAICT, the above description of the problem is inaccurate. The > *Completions* buffer would pop up in previous versions as well, but > only after a second TAB. Whereas the in-buffer completion would show > after the first TAB. Now in Emacs 30 after the first TAB nothing > happens, and after the second TAB you see the same display as > previously after the second TAB: both in-buffer completion and the > *Completions* buffer popped up. > > So I think the problem is that the first TAB does NOT show in-buffer > completion anymore in the above scenario. Confirmed, thank you. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 07 12:34:30 2023 Received: (at 67661) by debbugs.gnu.org; 7 Dec 2023 17:34:30 +0000 Received: from localhost ([127.0.0.1]:43053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBIGb-0001dQ-JD for submit@debbugs.gnu.org; Thu, 07 Dec 2023 12:34:29 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:42661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBIGX-0001cj-Fn for 67661@debbugs.gnu.org; Thu, 07 Dec 2023 12:34:28 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id F33D120002; Thu, 7 Dec 2023 17:34:05 +0000 (UTC) From: Juri Linkov To: Sean Whitton Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <87o7f3e4cb.fsf@melete.silentflame.com> (Sean Whitton's message of "Wed, 06 Dec 2023 15:30:12 +0000") Organization: LINKOV.NET References: <87o7f3e4cb.fsf@melete.silentflame.com> Date: Thu, 07 Dec 2023 19:28:25 +0200 Message-ID: <868r66gipm.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > 1. emacs -q > 2. (setopt icomplete-in-buffer t) > 3. M-x icomplete-mode > 4. M-x eshell > 5. try to tab-complete something where there is more than one possible > completion, e.g. ls in a directory with many files. > > Previously you would get the icomplete in buffer completion. > Now, additionally, *Completions* pops up, but it doesn't make sense to > have both. It's possible to hide *Completions* when icomplete-mode is enabled, but I'm not sure if everyone will like this. For example, I'm using both icomplete-mode and the *Completions* buffer at the same time in the minibuffer. And in a regular buffer we should keep for users the ability to pop up *Completions* in addition to in-buffer completions. Maybe the best solution would be to use something like in completion-preview-mode where you can use in-buffer completions and still be able to type M-C-i to pop up the *Completions* buffer. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 07 17:04:45 2023 Received: (at 67661) by debbugs.gnu.org; 7 Dec 2023 22:04:45 +0000 Received: from localhost ([127.0.0.1]:43286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBMU9-0004yy-Hn for submit@debbugs.gnu.org; Thu, 07 Dec 2023 17:04:45 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:36431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBMU6-0004yV-0I for 67661@debbugs.gnu.org; Thu, 07 Dec 2023 17:04:44 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 5D24E3200B92; Thu, 7 Dec 2023 17:04:22 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 07 Dec 2023 17:04:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1701986661; x= 1702073061; bh=qdr40SvQJbZytFstYEE75kJuuHWq6FcPAoLxA6V9ceI=; b=B 3f/CQroAjbRlW21RyYQAIa1d6XM34Fwwbx+N8MFi16RYGUvodNid25ddcHJR+ggv 7kylTl+yG3+xuplOpRuIldwqQHhLDf+vI/edi43WHd3Ws24vcIR702L3CckrSvVv 2IcVsHoB100NMh+v8HzvuI+UzcLimeZjV+9bHQeigYvq1faJj9IHmM6zBLNkwLdw RU7xAXrjNh8kslTOJrnj/sA9UbmS+2scWsEL65bGVdWGyYbCEdtLMbdzWUlOocAD RcW0jL2lle771ZwKYuZgLfHwSedahVFhzQeRJkkYenoWtAp7epy5RtPeyXU52/8Z 6/9Spo3wQXuU3jiaJO5vA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1701986661; x=1702073061; bh=qdr40SvQJbZyt FstYEE75kJuuHWq6FcPAoLxA6V9ceI=; b=uOwmi8ek64cpjG/L2mXI8jX1mpvkd xsBjHOr71W2tnjQlyqUBOjN1lsK7AePBj14hag7rnnBnHg/8eqOgvpauannmtcJv kvrVhEpGeUMI3sq6MIJp+XWBtJ/CZbmy5UrJB6H00b8d2Jq+O+qkNE2tmsjhcQIc GNhowYTPMmz+EBlN+nMhu7j8AP0oMPVFxMID6A612trVBaCz///BqOqQLVlYbvR4 Cj4Ub7qQHf6/U+1v/kUXkIwRhG3BtvZm7gGwEXYD/I9Lqe+lNIkhJ6Y43uK2uV5f quMLk4UktZDp09lsd1rD1cCvqYDliu3jL0nTsKrnuxinpU68W7H+5m/Hw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudekfedgleeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Dec 2023 17:04:21 -0500 (EST) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 8BABA94077A; Thu, 7 Dec 2023 22:04:18 +0000 (GMT) From: Sean Whitton To: Juri Linkov Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <868r66gipm.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 07 Dec 2023 19:28:25 +0200") References: <87o7f3e4cb.fsf@melete.silentflame.com> <868r66gipm.fsf@mail.linkov.net> Date: Thu, 07 Dec 2023 22:04:18 +0000 Message-ID: <87msul4ql9.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Thu 07 Dec 2023 at 07:28pm +02, Juri Linkov wrote: >> 1. emacs -q >> 2. (setopt icomplete-in-buffer t) >> 3. M-x icomplete-mode >> 4. M-x eshell >> 5. try to tab-complete something where there is more than one possible >> completion, e.g. ls in a directory with many files. >> >> Previously you would get the icomplete in buffer completion. >> Now, additionally, *Completions* pops up, but it doesn't make sense to >> have both. > > It's possible to hide *Completions* when icomplete-mode is enabled, > but I'm not sure if everyone will like this. For example, > I'm using both icomplete-mode and the *Completions* buffer > at the same time in the minibuffer. And in a regular buffer > we should keep for users the ability to pop up *Completions* > in addition to in-buffer completions. > > Maybe the best solution would be to use something like > in completion-preview-mode where you can use in-buffer > completions and still be able to type M-C-i to pop up > the *Completions* buffer. This is a regression though, right? It didn't use to pop up. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 08 01:28:54 2023 Received: (at 67661) by debbugs.gnu.org; 8 Dec 2023 06:28:54 +0000 Received: from localhost ([127.0.0.1]:43647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBUM1-0007D0-VC for submit@debbugs.gnu.org; Fri, 08 Dec 2023 01:28:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBULz-0007CY-Go for 67661@debbugs.gnu.org; Fri, 08 Dec 2023 01:28:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBULh-0006lp-C1; Fri, 08 Dec 2023 01:28:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Tpk8Ylg1A8jF2Opkl79bgH7Ko7V4wtXZ7gmi8B9NUCY=; b=fvSezvrUt/KD 1nr0gwcaGMRt/cZltyryjyraeRO56art14tb4c6oMmTU+4C8fTce60anBFFB5h2p2QdYC0CqTTqQ5 M8Ae2646b5rb16KEzad8fB2pOQovP/YyWhF1+iUlDqikD48R5v+h9Y5MC5QqGfEp1KFtwZbPqZs4x dVjDSr4ElJGtPgx/7L1dE8lNa+fFxp6JByxGsz5ERURZEjQw1bahjy6/DN211Y/FLmZhLkG3GGRR8 hnSyCl7/03tTn3Gl4gRLWyelVpcIFZI5zmDfD2ACrDmRRpj4g/fEp2Vrlir1RqLDyHPfrrYMdJ8jT QCR7jniInGPvwrik60b5lg==; Date: Fri, 08 Dec 2023 08:28:48 +0200 Message-Id: <83lea51a3j.fsf@gnu.org> From: Eli Zaretskii To: Sean Whitton In-Reply-To: <87msul4ql9.fsf@zephyr.silentflame.com> (message from Sean Whitton on Thu, 07 Dec 2023 22:04:18 +0000) Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer References: <87o7f3e4cb.fsf@melete.silentflame.com> <868r66gipm.fsf@mail.linkov.net> <87msul4ql9.fsf@zephyr.silentflame.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 67661@debbugs.gnu.org > From: Sean Whitton > Date: Thu, 07 Dec 2023 22:04:18 +0000 > > Hello, > > On Thu 07 Dec 2023 at 07:28pm +02, Juri Linkov wrote: > > >> 1. emacs -q > >> 2. (setopt icomplete-in-buffer t) > >> 3. M-x icomplete-mode > >> 4. M-x eshell > >> 5. try to tab-complete something where there is more than one possible > >> completion, e.g. ls in a directory with many files. > >> > >> Previously you would get the icomplete in buffer completion. > >> Now, additionally, *Completions* pops up, but it doesn't make sense to > >> have both. > > > > It's possible to hide *Completions* when icomplete-mode is enabled, > > but I'm not sure if everyone will like this. For example, > > I'm using both icomplete-mode and the *Completions* buffer > > at the same time in the minibuffer. And in a regular buffer > > we should keep for users the ability to pop up *Completions* > > in addition to in-buffer completions. > > > > Maybe the best solution would be to use something like > > in completion-preview-mode where you can use in-buffer > > completions and still be able to type M-C-i to pop up > > the *Completions* buffer. > > This is a regression though, right? It didn't use to pop up. Once again: it did. The *Completions* buffer always popped up the second time you type TAB. The problem here is that the first TAB doesn't show the in-buffer completion. _That_ is the regression we should try fixing. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 08 05:20:20 2023 Received: (at 67661) by debbugs.gnu.org; 8 Dec 2023 10:20:21 +0000 Received: from localhost ([127.0.0.1]:43888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBXy0-00007G-FF for submit@debbugs.gnu.org; Fri, 08 Dec 2023 05:20:20 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:58255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBXxv-00006Z-TS for 67661@debbugs.gnu.org; Fri, 08 Dec 2023 05:20:19 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4189B5C0041; Fri, 8 Dec 2023 05:19:57 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 08 Dec 2023 05:19:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1702030797; x= 1702117197; bh=SxKO2H0Gp5PafvakeYvH29etMCIZgWUKEi0/hbDeQ54=; b=M YHhA5ZtIIbKpct5zhECLfVGdyP5c/uvbllFPXNoxgoM+Biwp9eWC9+GGV1DSXdK6 dizIUAU9vyq5rZB1YUf53eLrJVOgmKMd9aXlF9XSG4YuKmqkuUnX79FX6WPPKOh4 955gfAJa1vfK4t/fwdsgARXYyWwk8ryJb/ZlyMPxo9jNzB3BKBOzUM/8zVwqZXQM HOLB0C0fGY0COkmpJM2kP6X3v94FW/LZlShbHJ804L8tXgfbrcsbBmr/Ff/exQam +5nR+mexN1ZHvpECLvezdC7KHfeqNkR9zE37Bx4Q7xDbO/nH4fp+LVb19G/+E4Bv 16Rd3JYxs1jdV8npUv1Ow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1702030797; x=1702117197; bh=SxKO2H0Gp5Paf vakeYvH29etMCIZgWUKEi0/hbDeQ54=; b=odTgvFbD5ZUTTjP8ZT7QF34prQ3HY VtIY5RB3h0kmUA0q3cuGeTtDoi7BF/DQvYLBj1Z5lt/FyXZL0nMUzt4XR9kr4Ptx /3b4qOYsP43642klXZSMrje/w8KG1csDr242ARa+LS79KaQngoCHNTivddeBN6Z0 sZIHiZXXNIX8bQNbjbFONQfDZ7ITfphG+ItrAA8XtXvFRLA4oH2IFUi+6W1JuTbP 4TjDRTbVjj+0G0xFt0kG33+EepDrWTjmC0KMaRUTp18kxBnewRBfjXFymBIuSbdT JzQiMZgpktBLRUOb7D7pRpWXmm6WtLKaDLQ/thH5LfD/9jyKiJDMeykPQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudekiedgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Dec 2023 05:19:56 -0500 (EST) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 10C329416AC; Fri, 8 Dec 2023 10:19:54 +0000 (GMT) From: Sean Whitton To: Eli Zaretskii Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <83lea51a3j.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 08 Dec 2023 08:28:48 +0200") References: <87o7f3e4cb.fsf@melete.silentflame.com> <868r66gipm.fsf@mail.linkov.net> <87msul4ql9.fsf@zephyr.silentflame.com> <83lea51a3j.fsf@gnu.org> Date: Fri, 08 Dec 2023 10:19:54 +0000 Message-ID: <871qbx808l.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Fri 08 Dec 2023 at 08:28am +02, Eli Zaretskii wrote: >> Cc: 67661@debbugs.gnu.org >> From: Sean Whitton >> Date: Thu, 07 Dec 2023 22:04:18 +0000 >> >> Hello, >> >> On Thu 07 Dec 2023 at 07:28pm +02, Juri Linkov wrote: >> >> >> 1. emacs -q >> >> 2. (setopt icomplete-in-buffer t) >> >> 3. M-x icomplete-mode >> >> 4. M-x eshell >> >> 5. try to tab-complete something where there is more than one possible >> >> completion, e.g. ls in a directory with many files. >> >> >> >> Previously you would get the icomplete in buffer completion. >> >> Now, additionally, *Completions* pops up, but it doesn't make sense to >> >> have both. >> > >> > It's possible to hide *Completions* when icomplete-mode is enabled, >> > but I'm not sure if everyone will like this. For example, >> > I'm using both icomplete-mode and the *Completions* buffer >> > at the same time in the minibuffer. And in a regular buffer >> > we should keep for users the ability to pop up *Completions* >> > in addition to in-buffer completions. >> > >> > Maybe the best solution would be to use something like >> > in completion-preview-mode where you can use in-buffer >> > completions and still be able to type M-C-i to pop up >> > the *Completions* buffer. >> >> This is a regression though, right? It didn't use to pop up. > > Once again: it did. The *Completions* buffer always popped up the > second time you type TAB. The problem here is that the first TAB > doesn't show the in-buffer completion. _That_ is the regression we > should try fixing. Right, that's what I meant. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 07:09:52 2023 Received: (at 67661) by debbugs.gnu.org; 9 Dec 2023 12:09:52 +0000 Received: from localhost ([127.0.0.1]:46940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBw9Y-0003BU-CC for submit@debbugs.gnu.org; Sat, 09 Dec 2023 07:09:52 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:60153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBw9U-0003B6-0p; Sat, 09 Dec 2023 07:09:51 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 764AF3200CAE; Sat, 9 Dec 2023 07:09:28 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sat, 09 Dec 2023 07:09:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1702123767; x= 1702210167; bh=6EVeyqEYig6BQxFhHbDwg0mYhWHRmKaobkF+bulfT8c=; b=f u/B1tSElVnkDGg/FvkDjiWGXFvxzQqsurVF4XS6LtcciS4qMDWvEwfUPsiaSOATP L4zMYbgEI+C20UEO3zyK0/ecE3aO6rZEvz7jj8CIJhoguWoRXXyT7OYqdBALSoYr QmgXUAB3gSRp6xQSWWPVJ79ikiDS0Khzf1Oi97lmRrDmK7uW4IuZxHzlEafEWVQU DePAhoCTAMbISv3s0+PIPZBNf0av3J5BoeHBA/ikm3dZYrYUl4ao/auAGIplEA+y TZWytVGqLJyl318qSKK1ND7dQzD8AQ0L7Fqn9xRcESNKC8yFHDAoiXg0ZlNfmNVm YWNrtG4+U7Y2w2skPQzfg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1702123767; x=1702210167; bh=6EVeyqEYig6BQ xFhHbDwg0mYhWHRmKaobkF+bulfT8c=; b=fphgHm1h+X1cFY0TPNbq+qxejIPw6 idef5rDHmk3u8kZXrWW2w/OxlcC5y/TNr9/DKy+3D5J361B4hyDjV+tI0z/c3K7h JXfwAYyXbTdxCiOUdcHJIUhcmaLkAMQd+tmkQ2nin4s+7LIfFDaXl6LYjPaSCqlS PhBFS/32JXG9rl08gYgQb1u7by3DsUCKM6KVA6gpOR9QfocOpEYfDNxWJAhZ7QRJ QMBwMKuGvxVFpspXaHojoswviwXEFi626RM+mxOL5opn+PPzqlKJv/yv0F/yn3jh kF8tMIIh4cJ3zabFr2IPgB5Q2ImvtE0HCrJhfCm1hmHGNTC0ottnbCUFA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudekkedgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 9 Dec 2023 07:09:26 -0500 (EST) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 64F30940F7A; Sat, 9 Dec 2023 12:09:25 +0000 (GMT) From: Sean Whitton To: Eshel Yaron , Juri Linkov Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <83wmtr2mye.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 06 Dec 2023 20:41:13 +0200") References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> Date: Sat, 09 Dec 2023 12:09:25 +0000 Message-ID: <87lea3wpai.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , 67001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Wed 06 Dec 2023 at 08:41pm +02, Eli Zaretskii wrote: > AFAICT, the above description of the problem is inaccurate. The > *Completions* buffer would pop up in previous versions as well, but > only after a second TAB. Whereas the in-buffer completion would show > after the first TAB. Now in Emacs 30 after the first TAB nothing > happens, and after the second TAB you see the same display as > previously after the second TAB: both in-buffer completion and the > *Completions* buffer popped up. > > So I think the problem is that the first TAB does NOT show in-buffer > completion anymore in the above scenario. Commit 5416896d608 is responsible for the problem. It would seem that it turns off completion-in-region-mode too early. Eshel, Juri, can you take a look, please? Thanks. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 08:09:08 2023 Received: (at 67661) by debbugs.gnu.org; 9 Dec 2023 13:09:09 +0000 Received: from localhost ([127.0.0.1]:46969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBx4u-0007YR-EB for submit@debbugs.gnu.org; Sat, 09 Dec 2023 08:09:08 -0500 Received: from mail.eshelyaron.com ([107.175.124.16]:44666 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBx4o-0007Y8-6a; Sat, 09 Dec 2023 08:09:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1702127328; bh=kZyjeRPWfVvS/GEmXxkJAPDlBfAI8YWJSCq00o7H+p4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=arVh8rNutM0iPqv4FVqd4MhGdhA5RwAOxzEioY4O2H2rxaJrZKkEZX3TEyjvuMgba kbfL2B04ErP0wyPHH06A6qefVDX7d6bfSaMqjHsY2aoEpIaWEfFlT5A+/242hss8Uv VlPXnQOapseMVq7kG8CyNrhuw/qyFFsPQnXvPRdNe8XEd6erdesTjvBdlGpdIWKYge T/SGtsyTyWq2d/2KOZ3n58cNhLarxD/xuTu7jefA7Of7DyqfmDLmzWzzn/rBgrwel8 M3z4f6CrHzPEKJV36NizeYxEoBzdjpT2krUuQqg+Vam8mVTeN8BsMQCubQdudbmAwE B/Xj6q4xZTGRQ== From: Eshel Yaron To: Sean Whitton Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <87lea3wpai.fsf@zephyr.silentflame.com> (Sean Whitton's message of "Sat, 09 Dec 2023 12:09:25 +0000") References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> Date: Sat, 09 Dec 2023 14:08:45 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , 67001@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Sean, Sean Whitton writes: > Previously you would get the icomplete in buffer completion. Now, > additionally, *Completions* pops up, but it doesn't make sense to have > both. I agree that having both interface together is a bit much, but AFAICT that has been the case at least since Emacs 27 whenever the text before point was the longest common prefix of several completion candidates. For example, try completing "l" instead of "ls" in eshell. On both Emacs 27 and on master, this shows both the *Completions* buffer and the in-buffer `icomplete` interface. Is this what you get as well? Sean Whitton writes: > Hello, > > On Wed 06 Dec 2023 at 08:41pm +02, Eli Zaretskii wrote: > >> AFAICT, the above description of the problem is inaccurate. The >> *Completions* buffer would pop up in previous versions as well, but >> only after a second TAB. Whereas the in-buffer completion would show >> after the first TAB. Now in Emacs 30 after the first TAB nothing >> happens, and after the second TAB you see the same display as >> previously after the second TAB: both in-buffer completion and the >> *Completions* buffer popped up. >> >> So I think the problem is that the first TAB does NOT show in-buffer >> completion anymore in the above scenario. > > Commit 5416896d608 is responsible for the problem. > It would seem that it turns off completion-in-region-mode too early. IIUC, the problem of showing both interfaces is inherent to how `icomplete-in-buffer` is implemented. It's just that in this case of completing "ls" the *Completions* doesn't show up at first because it's an exact match. What allowed the `icomplete` to show up is that although the *Completions* buffer wasn't shown, `completion-in-region-mode` would remain on, and that caused only the `icomplete` interface to appear in this specific case. The reason we now disable `completion-in-region-mode` when it doesn't show the *Completions* buffer, is to avoid having the key bindings that this minor mode sets up from lingering and shadowing other bindings. If it doesn't make sense for `icomplete-in-buffer` to appear along with the *Completions* buffer, perhaps `icomplete-in-buffer` should simply be an alternative `completion-in-region-function`? Best, Eshel From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 08:26:26 2023 Received: (at 67661) by debbugs.gnu.org; 9 Dec 2023 13:26:26 +0000 Received: from localhost ([127.0.0.1]:46993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBxLd-00080P-Tz for submit@debbugs.gnu.org; Sat, 09 Dec 2023 08:26:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBxLb-000803-Hk; Sat, 09 Dec 2023 08:26:24 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBxLI-0007Re-CX; Sat, 09 Dec 2023 08:26:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MzeBrVVcwHpA8dfUdt7VNeg12K6uTWukXZbHCOWbgnQ=; b=BK42nc/aTzkR l7Y9kBa6ocrD1+feP6R0A09C1n5kMdsZ9ntPld61IG1kHy5Sdil2FKu2bk5bvQABQDRh8QLZS1oFT mvlucXIZdAllZ38i/UGOoOX9ExhDiMEePxeU94g2GmVphXeAdnypO8+hAa+kDjshjQDilVghtyB50 xADYesQaGiHyQcJVi0rdEGe3EbDrCWVBatyWQH7gaS8ixZHFHpB8pYSGzV+EMs9GDAFGOxZ8MqVa8 N6bThNJY58A3nAyKZEtjE1rUayXnsvTWYfKVxmsZrYP7hWK8Wz6F+Qh47ywScUnjruCxSUEIQ1W3R VCRvIdTAiLSUC2WQo19rbg==; Date: Sat, 09 Dec 2023 15:25:45 +0200 Message-Id: <8334wby0bq.fsf@gnu.org> From: Eli Zaretskii To: Eshel Yaron In-Reply-To: (message from Eshel Yaron on Sat, 09 Dec 2023 14:08:45 +0100) Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, juri@linkov.net, 67001@debbugs.gnu.org, spwhitton@spwhitton.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Eshel Yaron > Cc: Juri Linkov , 67661@debbugs.gnu.org, Eli Zaretskii > , 67001@debbugs.gnu.org > Date: Sat, 09 Dec 2023 14:08:45 +0100 > > Sean Whitton writes: > > > Previously you would get the icomplete in buffer completion. Now, > > additionally, *Completions* pops up, but it doesn't make sense to have > > both. > > I agree that having both interface together is a bit much, but AFAICT > that has been the case at least since Emacs 27 whenever the text before > point was the longest common prefix of several completion candidates. > For example, try completing "l" instead of "ls" in eshell. On both > Emacs 27 and on master, this shows both the *Completions* buffer and the > in-buffer `icomplete` interface. Is this what you get as well? This is not the regression that needs to be fixed here. > > On Wed 06 Dec 2023 at 08:41pm +02, Eli Zaretskii wrote: > > > >> AFAICT, the above description of the problem is inaccurate. The > >> *Completions* buffer would pop up in previous versions as well, but > >> only after a second TAB. Whereas the in-buffer completion would show > >> after the first TAB. Now in Emacs 30 after the first TAB nothing > >> happens, and after the second TAB you see the same display as > >> previously after the second TAB: both in-buffer completion and the > >> *Completions* buffer popped up. > >> > >> So I think the problem is that the first TAB does NOT show in-buffer > >> completion anymore in the above scenario. > > > > Commit 5416896d608 is responsible for the problem. > > It would seem that it turns off completion-in-region-mode too early. > > IIUC, the problem of showing both interfaces is inherent to how > `icomplete-in-buffer` is implemented. Once again, the fact that the second TAB shows both completion interfaces is not the problem: as you point out that was how Emacs behaved since long ago. The problem here is that the _first_ TAB does NOT show in-buffer completions. This should be fixed, since it is a regression wrt Emacs 29. > It's just that in this case of > completing "ls" the *Completions* doesn't show up at first because it's > an exact match. What allowed the `icomplete` to show up is that > although the *Completions* buffer wasn't shown, > `completion-in-region-mode` would remain on, and that caused only the > `icomplete` interface to appear in this specific case. > > The reason we now disable `completion-in-region-mode` when it doesn't > show the *Completions* buffer, is to avoid having the key bindings that > this minor mode sets up from lingering and shadowing other bindings. That sounds like some very technical problem, and it should be fixed by some other means than disabling completion-in-region-mode. > If it doesn't make sense for `icomplete-in-buffer` to appear along with > the *Completions* buffer Again, this is not the problem to solve. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 09:14:14 2023 Received: (at 67661) by debbugs.gnu.org; 9 Dec 2023 14:14:14 +0000 Received: from localhost ([127.0.0.1]:47048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBy5t-0000p3-OC for submit@debbugs.gnu.org; Sat, 09 Dec 2023 09:14:14 -0500 Received: from mail.eshelyaron.com ([107.175.124.16]:52410 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBy5q-0000ok-Cf; Sat, 09 Dec 2023 09:14:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1702131235; bh=XlA5ML8bEu0WyQmUTxuV5QUCv0RVv3FirmnCDhvVnlY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=p6oBToNLOrdh/tzPEvuCNaC9f/7wieLPxgt3kysEDKdseVq2zeEll6N7Ylmd/o8xv vj0fR0PPpIP0huLlE/W10WkyA70aE1VMD+9YwSTDih7geP5y8NdaFTqCXFBMI24PUn Drm3MUYpiuVCK1DdABkcoSYShjhpak5EDBxe5acixblGoDI/NJKd8if5fAGBHv2piR oTXD7BujKgZzWZYh/88Om97KKGyHITfPp4ZyI7xdEFlzMEaKNBqqcbNFxT1KEcZLj7 fc2WW6f5Md4/wWDhkx5dmuFI0CAMayHXmS64KQbXy29bg3Vfg+JJHXTM+mpVMa/7Wu 0sACLXjffclig== From: Eshel Yaron To: Eli Zaretskii Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <8334wby0bq.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 09 Dec 2023 15:25:45 +0200") References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> Date: Sat, 09 Dec 2023 15:13:53 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, juri@linkov.net, 67001@debbugs.gnu.org, spwhitton@spwhitton.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Eshel Yaron >> >> Sean Whitton writes: >> >> > Previously you would get the icomplete in buffer completion. Now, >> > additionally, *Completions* pops up, but it doesn't make sense to have >> > both. >> >> I agree that having both interface together is a bit much, but AFAICT >> that has been the case at least since Emacs 27 whenever the text before >> point was the longest common prefix of several completion candidates. >> For example, try completing "l" instead of "ls" in eshell. On both >> Emacs 27 and on master, this shows both the *Completions* buffer and the >> in-buffer `icomplete` interface. Is this what you get as well? >> [...] >> IIUC, the problem of showing both interfaces is inherent to how >> `icomplete-in-buffer` is implemented. > > Once again, the fact that the second TAB shows both completion > interfaces is not the problem: as you point out that was how Emacs > behaved since long ago. The problem here is that the _first_ TAB does > NOT show in-buffer completions. Yes, but what I pointed out was that the first TAB has been showing both interfaces since Emacs 27, just not with this particular recipe. >> If it doesn't make sense for `icomplete-in-buffer` to appear along >> with the *Completions* buffer > > Again, this is not the problem to solve. Could you explain what you mean here? If this behavior doesn't make sense, isn't it worth trying to solve it for all cases, rather than just for one specific case? From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 09:41:26 2023 Received: (at 67661) by debbugs.gnu.org; 9 Dec 2023 14:41:26 +0000 Received: from localhost ([127.0.0.1]:47070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rByWD-0001Xw-QB for submit@debbugs.gnu.org; Sat, 09 Dec 2023 09:41:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rByWB-0001Wj-DG; Sat, 09 Dec 2023 09:41:24 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rByVr-0005ud-Q4; Sat, 09 Dec 2023 09:41:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QMHVVBuE7sTnQog+brYPpZN3VCsLqrLl0CoeL5VKnUc=; b=pJdhimHnfQMo Oicc8T/1ZwrOU+Fob2lww68pX0LaklzNkjz6dZahEawgVG2Z5s4yJzuFZ7drtZV8AKjz9ZqS8O3+4 1h76usIPPat9rkx0zb80LlUSs0FoACVtdDOa8abdjNt7wo9Bv2D5qf9fRhrui6kydpPUjZ3TgULnO ZzsTPQZe8ruEPF0nvLS6OcM1UsZiMoSkWAZm8KC0qBgQqIFeYB8yqtLHCQP5UMoSTRLci1rnBS2Rv D97m6Tmfm1yF1M5d1MOkjzqOK/XtY3YfpRecedJq1qvSk6b7KTz6uZE4xQIg2bKmkFS5g1bZDViFT Go9A3qi8dJJFk77RmGRbCw==; Date: Sat, 09 Dec 2023 16:40:48 +0200 Message-Id: <83y1e3wia7.fsf@gnu.org> From: Eli Zaretskii To: Eshel Yaron In-Reply-To: (message from Eshel Yaron on Sat, 09 Dec 2023 15:13:53 +0100) Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, juri@linkov.net, 67001@debbugs.gnu.org, spwhitton@spwhitton.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Eshel Yaron > Cc: spwhitton@spwhitton.name, juri@linkov.net, 67661@debbugs.gnu.org, > 67001@debbugs.gnu.org > Date: Sat, 09 Dec 2023 15:13:53 +0100 > > Eli Zaretskii writes: > > > Once again, the fact that the second TAB shows both completion > > interfaces is not the problem: as you point out that was how Emacs > > behaved since long ago. The problem here is that the _first_ TAB does > > NOT show in-buffer completions. > > Yes, but what I pointed out was that the first TAB has been showing both > interfaces since Emacs 27, just not with this particular recipe. That's not what I see in Emacs 29. There' the first TAB shows only the in-buffer completions, and the second TAB pops up the *Completions* buffer (without removing the in-buffer completions). > >> If it doesn't make sense for `icomplete-in-buffer` to appear along > >> with the *Completions* buffer > > > > Again, this is not the problem to solve. > > Could you explain what you mean here? If this behavior doesn't make > sense, isn't it worth trying to solve it for all cases, rather than just > for one specific case? I don't think I understand what you mean by "one specific case". Which case, and why is it specific? Sean reported a regression in behavior under icomplete-in-buffer, so I looked into the recipe he posted. What I saw was that Emacs 29 shows the in-buffer completions after the first TAB and adds to that the *Completions* buffer after the second TAB. By contrast, Emacs 30 shows nothing after the first TAB, and shows both in-buffer completions and the *Completions* buffer after the second TAB. So my conclusion was that the regression is the behavior after the first TAB. If this conclusion is incorrect, please tell what did I miss. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 10:23:19 2023 Received: (at 67661) by debbugs.gnu.org; 9 Dec 2023 15:23:19 +0000 Received: from localhost ([127.0.0.1]:48756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBzAl-0005oJ-93 for submit@debbugs.gnu.org; Sat, 09 Dec 2023 10:23:19 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:43493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBzAj-0005nm-9R; Sat, 09 Dec 2023 10:23:18 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 667403200A83; Sat, 9 Dec 2023 10:22:57 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 09 Dec 2023 10:22:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1702135376; x= 1702221776; bh=sXRfzVl3LcZiVDyV2lBDGZ754zqILead4/AdrqGPQkY=; b=e 18HaLeCHGE+8UPukDv1JkCJXx1g0AbJsBZB9vK0SSM3oPFOyRbyhn919tPOQjtF+ 8+eTllTA9NUDfL8q0RnULhL153bg/h2hsOnfwULPsWMnnaTi2W0M+CmoLVFcAVK3 LrRuC4CvOr/wgBHaRRnEYIe2RJ1sORQ3m5Po12ojn8JUgywIWDWEp9B4vCHxIQFM e56eDj4MwomzdzJRbNyaG3fEkXCPWlABQ2CSKPZFwI8nFwqqUrVFQauK8l6H+Wja qP0AnokO7SLmXvJ7yD1ceibAGQtLSVZXR3Ips8y/AZquJJqoXslYiH6cLucMeTvG 5tKokpGZzAqcwpandP9ng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1702135376; x=1702221776; bh=sXRfzVl3LcZiV DyV2lBDGZ754zqILead4/AdrqGPQkY=; b=snp57+wlz4CN6Oq3bpKSf3TmrDnU4 L+skKaTe0sGOdx9MVyyZ8Uq0/yWeKN+cpFukMqNCfWbFy+Jn9ZD7q1kOz9RII3Gv G1UGn3dsf9t3KBXnbPMeGcoYL3YPDHBonc9yii4Vp+N7SvtgQNEriSnmeHaCiK9N /Jg28a+pCCiBmQiAklNIVpY2ikFV91UWblOjmiQ/lC4zXz1WlDeDWLv0u/h2IElc LJhgBkPmqMmR3G1p8vn9rwQNOYX7qi6E5YP5efEHIEWBmpkPBbinjf9l2zmSbKGS eUWDBfZ2okyGwLO0QiyDHtIy1+v45DCyA/R2GxKB9fmqBtBAy+NzgEiiQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudekkedgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 9 Dec 2023 10:22:55 -0500 (EST) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 97A849416CD; Sat, 9 Dec 2023 15:22:50 +0000 (GMT) From: Sean Whitton To: Eli Zaretskii , Eshel Yaron Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <83y1e3wia7.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 09 Dec 2023 16:40:48 +0200") References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> Date: Sat, 09 Dec 2023 15:22:50 +0000 Message-ID: <87a5qjwgc5.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, 67001@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Sat 09 Dec 2023 at 04:40pm +02, Eli Zaretskii wrote: > Sean reported a regression in behavior under icomplete-in-buffer, so I > looked into the recipe he posted. What I saw was that Emacs 29 shows > the in-buffer completions after the first TAB and adds to that the > *Completions* buffer after the second TAB. By contrast, Emacs 30 > shows nothing after the first TAB, and shows both in-buffer > completions and the *Completions* buffer after the second TAB. So my > conclusion was that the regression is the behavior after the first > TAB. If this conclusion is incorrect, please tell what did I miss. This is exactly how I understand the situation. icomplete-in-buffer didn't work at all for years, until Juri (iirc) fixed it for Emacs 29. So what happens in much older Emacs doesn't seem important. It's a regression since Emacs 29. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 11:04:19 2023 Received: (at 67661) by debbugs.gnu.org; 9 Dec 2023 16:04:20 +0000 Received: from localhost ([127.0.0.1]:48781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBzoR-0006sC-E3 for submit@debbugs.gnu.org; Sat, 09 Dec 2023 11:04:19 -0500 Received: from mail.eshelyaron.com ([107.175.124.16]:58680 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBzoM-0006rw-BQ; Sat, 09 Dec 2023 11:04:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1702137840; bh=4Go6izHrQ/0SDorNr/Tq7yCZrnhedUgGsZ2R9V7PRJM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Uhs0ZSBusJpBO4sQzWoLHlI4tnacpFilemmkAL9o8gef1RhLxvsn1OiqW6C+ErEBT RHRCyyfVMHmkF8Q69T4FqwWbld3DptakyvO0KgECxcjnLiVi2DHeT43R+d4uFTpVqx 1DRxLli9CP/tyXnwCTAg6yo1gujVCbRg0XpUhwqSxUMtDpRrzphAf5tCNuKyNjRfnS U+wxjvNmUrBj9SauYaWnmZ9FnKHOmFF06y6PznVag7AUCSPZ6Nh2OVdkfZTU4IbbwL 9fk41MtSFNh5G1IeJQENWFHhTy5FUSweNAvJXeX0QDnoyeGQ25dvHEmX9We4ebnf57 a+NMKlZbRJb1A== From: Eshel Yaron To: Eli Zaretskii Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <83y1e3wia7.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 09 Dec 2023 16:40:48 +0200") References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> Date: Sat, 09 Dec 2023 17:03:57 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, 67001@debbugs.gnu.org, spwhitton@spwhitton.name, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Eshel Yaron >> Cc: spwhitton@spwhitton.name, juri@linkov.net, 67661@debbugs.gnu.org, >> 67001@debbugs.gnu.org >> Date: Sat, 09 Dec 2023 15:13:53 +0100 >> >> Eli Zaretskii writes: >> >> > Once again, the fact that the second TAB shows both completion >> > interfaces is not the problem: as you point out that was how Emacs >> > behaved since long ago. The problem here is that the _first_ TAB does >> > NOT show in-buffer completions. >> >> Yes, but what I pointed out was that the first TAB has been showing both >> interfaces since Emacs 27, just not with this particular recipe. > > That's not what I see in Emacs 29. There' the first TAB shows only > the in-buffer completions, and the second TAB pops up the > *Completions* buffer (without removing the in-buffer completions). Did you try with "l" before point instead of "ls" as I suggested? Sean, how about you? >> >> If it doesn't make sense for `icomplete-in-buffer` to appear along >> >> with the *Completions* buffer >> > >> > Again, this is not the problem to solve. >> >> Could you explain what you mean here? If this behavior doesn't make >> sense, isn't it worth trying to solve it for all cases, rather than just >> for one specific case? > > I don't think I understand what you mean by "one specific case". > Which case, and why is it specific? I was referring to the specific case that Sean's recipe illustrated. This case exhibits a change in behavior that you clearly described, and that change is supposedly for the worse. IIUC what bothers Sean is that both interfaces appear together, but the thing is that that seems to be inherent to how `icomplete-in-buffer` currently works. > Sean reported a regression in behavior under icomplete-in-buffer, so I > looked into the recipe he posted. What I saw was that Emacs 29 shows > the in-buffer completions after the first TAB and adds to that the > *Completions* buffer after the second TAB. By contrast, Emacs 30 > shows nothing after the first TAB, and shows both in-buffer > completions and the *Completions* buffer after the second TAB. So my > conclusion was that the regression is the behavior after the first > TAB. If this conclusion is incorrect, please tell what did I miss. I think your reasoning is perfectly sound, but since already in Emacs 29 (and beforehand) both interfaces would appear together after the first TAB if you complete another string, restoring the behavior of Emacs 29 wouldn't fully address this problem. Put plainly, I'm not sure the Emacs 29 behavior of `icomplete-in-buffer` is any more intended than the current behavior. Stefan Monnier wrote[0] a couple of years ago about `icomplete-in-buffer`: I wrote it this way [as a defvar] because I consider(ed) that code just "proof of concept" and not working well enough to inflict it on unsuspecting users. Followed by: The problem is not so much in the code but in the behavior. If you think the behavior is good enough, then by all means use it, but I think it's a bit rough around the edges. I don't use `icomplete-in-buffer` myself, but seems like Sean does, so my suggestion was that we implement this in earnest as a `completion-in-region-function`, while specifying the intended behavior regarding TABs, overlays, and the *Completions* buffer. Best, Eshel [0] https://yhetil.org/emacs/jwvzgv1yec5.fsf-monnier+emacs@gnu.org/ From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 11:07:53 2023 Received: (at 67661) by debbugs.gnu.org; 9 Dec 2023 16:07:53 +0000 Received: from localhost ([127.0.0.1]:48790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBzrs-0006y9-L6 for submit@debbugs.gnu.org; Sat, 09 Dec 2023 11:07:52 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:46079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBzrq-0006xo-ED; Sat, 09 Dec 2023 11:07:51 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 9B4BE3200AB0; Sat, 9 Dec 2023 11:07:29 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 09 Dec 2023 11:07:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1702138049; x= 1702224449; bh=YzuMQC+LvT6+gDHBxTbp9qBgVxTGNjDpWg+d+GcbSr0=; b=j PG+1x8B3UNB12fMmVejaWX5jgUu3IOGoTDnMyoGzCiY9fSdZcXGo1PxbQRANJvkT DKiP74rhE9BimfHGC42Su52SdtgrjLKMkUBgLaPCccXYI7XM9P3kvPbwYVaGKMJO RxXeaVaSejEYmlmnBFuguelSz42vnJipTw147ZUhV4YwMAXfnr5x1cxmyEehlNPz a9bWvLVFxOiQZx9+N4ANUbK5Gi8fa7msDLPP6OluRQmhkqOuGwCsLq5gM2ZE51Ck /YdccZYdRruHVxlmO89HFzdRIalYi7Xggtqx3aHnLZXIaI1aj6VvWFxf3Tw/nLH2 hiicpKgBge039ZjJUdXDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1702138049; x=1702224449; bh=YzuMQC+LvT6+g DHBxTbp9qBgVxTGNjDpWg+d+GcbSr0=; b=bMX7KmQUNdMLxmDLpOOQRvIJX0mo9 voZi2Fy1roKaqg2nArKW4j9L25w5YNLWBDquPfTqUD9A+sjvwNu3pVe03qVMRub1 xJxJFYvqA2ty/2BtKHFvCvtY6eq0n2ixwV1mVg0pW5o0twxwinLrJ5IZgYlLe4E6 fNaxWinWH/wdIg0PLDGFBg4n+Mw8ia+SD49V5i7/SL5RCLsEIrxsxfzTZhae81Na xADldHSkZGNiBMBdI3jp8lBcfwImxIpS7VBG8bkP6qfku6AN/eKwd93ABr89GJsT NW3mrqU+Q1I6sHDmQTJmFns0kNA/OkcXqoCq0pPO4ul0onpzi+iU58KPg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudekkedgkeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 9 Dec 2023 11:07:28 -0500 (EST) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 97E269416C7; Sat, 9 Dec 2023 16:07:27 +0000 (GMT) From: Sean Whitton To: Eshel Yaron Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: (Eshel Yaron's message of "Sat, 09 Dec 2023 17:03:57 +0100") References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> Date: Sat, 09 Dec 2023 16:07:27 +0000 Message-ID: <87sf4buzpc.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , 67001@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Sat 09 Dec 2023 at 05:03pm +01, Eshel Yaron wrote: > Did you try with "l" before point instead of "ls" as I suggested? > > Sean, how about you? I haven't tried this, because it does not seem to be relevant. > I was referring to the specific case that Sean's recipe illustrated. > This case exhibits a change in behavior that you clearly described, and > that change is supposedly for the worse. IIUC what bothers Sean is that > both interfaces appear together, but the thing is that that seems to be > inherent to how `icomplete-in-buffer` currently works. No, what bothers me is the regression as described by Eli. I apologise for not being clearer in my initial report. Thank you for your engagement. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 11:23:04 2023 Received: (at 67661) by debbugs.gnu.org; 9 Dec 2023 16:23:04 +0000 Received: from localhost ([127.0.0.1]:48798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rC06Z-0007NK-NX for submit@debbugs.gnu.org; Sat, 09 Dec 2023 11:23:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rC06W-0007Mh-3N; Sat, 09 Dec 2023 11:23:02 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rC06B-0007FG-Oh; Sat, 09 Dec 2023 11:22:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=SR6JJftdMbu2sO/18b+Ob6P+V5irsrGAQSzdSxEDhyo=; b=jkcMEunpsHnZ WJ1FsXbjpQuymM17Hk/b6do9i9J6DmqcMwV+AIDp99YL+Up4243gr5or+9PjdF3vqIe0QHAVznCN8 uQURG6Drm3E7JQ4hLglcsCgWYz4mjAmsf0Xl9U6E/Vr/9zorhIea8Vdj/IID5FqKF/p6oXrieoJCq MskdO8rLeQSM+bNO0onx5oZ2wG/ihXA2herpHbwhInMZV41LELRHgK8D1LZyWYf3wQLnTVxEYbp0u /TWkuIgTc81VSbSRIAddQDThi2O39xUgmhBuv8oEqwUqONDZNSqv8ejcw+XhFIBhXa1auVckUr3jw HbW+kBncut3X78TjWhhE2w==; Date: Sat, 09 Dec 2023 18:22:24 +0200 Message-Id: <83ttorwdkv.fsf@gnu.org> From: Eli Zaretskii To: Eshel Yaron In-Reply-To: (message from Eshel Yaron on Sat, 09 Dec 2023 17:03:57 +0100) Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, 67001@debbugs.gnu.org, spwhitton@spwhitton.name, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Eshel Yaron > Cc: 67661@debbugs.gnu.org, juri@linkov.net, 67001@debbugs.gnu.org, > spwhitton@spwhitton.name > Date: Sat, 09 Dec 2023 17:03:57 +0100 > > Eli Zaretskii writes: > > > That's not what I see in Emacs 29. There' the first TAB shows only > > the in-buffer completions, and the second TAB pops up the > > *Completions* buffer (without removing the in-buffer completions). > > Did you try with "l" before point instead of "ls" as I suggested? No, because Sean's recipe clearly said "ls". From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 12:23:20 2023 Received: (at 67661) by debbugs.gnu.org; 9 Dec 2023 17:23:20 +0000 Received: from localhost ([127.0.0.1]:48849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rC12u-0000Wb-Ah for submit@debbugs.gnu.org; Sat, 09 Dec 2023 12:23:20 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:48317) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rC12n-0000Vq-KR; Sat, 09 Dec 2023 12:23:16 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 3020C1BF203; Sat, 9 Dec 2023 17:22:51 +0000 (UTC) From: Juri Linkov To: Sean Whitton Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <87sf4buzpc.fsf@zephyr.silentflame.com> (Sean Whitton's message of "Sat, 09 Dec 2023 16:07:27 +0000") Organization: LINKOV.NET References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> Date: Sat, 09 Dec 2023 19:19:16 +0200 Message-ID: <86edfv9tuz.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , Eshel Yaron , 67001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> I was referring to the specific case that Sean's recipe illustrated. >> This case exhibits a change in behavior that you clearly described, and >> that change is supposedly for the worse. IIUC what bothers Sean is that >> both interfaces appear together, but the thing is that that seems to be >> inherent to how `icomplete-in-buffer` currently works. > > No, what bothers me is the regression as described by Eli. By definition a regression is a bug where a feature that has worked before stops working. As you noted, icomplete-in-buffer didn't work for years, until I fixed it for Emacs 29 (as least brought it to a usable state). The test case that you described shows its effect only by accident, until Eshel improved the related behavior of completion-in-region-mode, so that now icomplete-in-buffer works consistently when it enables both at the same time: in-buffer completions and in *Completions*. So instead of trying to restore an arbitrary behavior at the moment just after icomplete-in-buffer became usable, it would be much more useful to invest energy to deciding how better to finish this feature. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 14:04:54 2023 Received: (at 67661) by debbugs.gnu.org; 9 Dec 2023 19:04:54 +0000 Received: from localhost ([127.0.0.1]:48921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rC2dB-0003FM-JE for submit@debbugs.gnu.org; Sat, 09 Dec 2023 14:04:53 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:36105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rC2d6-0003F0-7N; Sat, 09 Dec 2023 14:04:51 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 3235632004E7; Sat, 9 Dec 2023 14:04:28 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 09 Dec 2023 14:04:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1702148667; x= 1702235067; bh=ZYE8khWcVZ3VG7zwyUWk94enDTc4pF4a21sw1708q34=; b=B HImt2cuMfLKmq+tM3ONAtUELkjcb3Yn6H0cn4iRZy1/t/gtvCqIbNODVSlFNmjOS +OemPfGkRXh9mHid0fr0vfqWxI0teWPbbw6aW84Wwf4eGuO+9+stjvbwJWDmnsTb Mv3plm/FQ33joitR7A4HV0tCUaRuFDrgLrCysQyP07228t5RJfcNiTkSk7QPIt2P YtBcKpGiVKYTTxRfgdMTzSABEgpTOnc6I2CqPu7IbSofAvLDfweSpWjNGccUzJy+ WE2nd5slxK9fEjZlUKRivlVhqE2EkrILa4ak4eiBwhUci9R4Pf4I8+wsj3HyRnGi 6KaSKrU/Pt5+Qokt9trlw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1702148667; x=1702235067; bh=ZYE8khWcVZ3VG 7zwyUWk94enDTc4pF4a21sw1708q34=; b=EsSI+jlbpz6N30fajs+i+1ANlOugI tXZ4qo/ef+PrA4BVXMbJ9ppNFRaL5KUKUmtNvlypcJWCPvPIKs2vPFlS3pTLVg2Y eL2KShIMs9Fyep7DkL+g3MQQK3Tf/y1VpITXx83BJbFUG7qr2V3qEeD9xS03w207 7O0Z628poEmKU5WK6dd7CBnUP1wdzpv4m6V77C4YdhJrsCOyrJV7Q8Pg65Bwyuft gDYe54ITJvGeGQLGgHVlYVB3R6ELPXD4RnjLKBU/8k7z6tIqQ98bj70E4ZUJ5OP+ ziU4iFvF5XVgCcxBh6qrVhsNtsWFnVIRxJN9XVQU/3ztuWcLh1ntsUB5w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudekkedguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedu keeggeelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 9 Dec 2023 14:04:26 -0500 (EST) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 525A09416C7; Sat, 9 Dec 2023 19:04:25 +0000 (GMT) From: Sean Whitton To: Juri Linkov Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <86edfv9tuz.fsf@mail.linkov.net> (Juri Linkov's message of "Sat, 09 Dec 2023 19:19:16 +0200") References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> Date: Sat, 09 Dec 2023 19:04:25 +0000 Message-ID: <87fs0burie.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , Eshel Yaron , 67001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Sat 09 Dec 2023 at 07:19pm +02, Juri Linkov wrote: >>> I was referring to the specific case that Sean's recipe illustrated. >>> This case exhibits a change in behavior that you clearly described, and >>> that change is supposedly for the worse. IIUC what bothers Sean is that >>> both interfaces appear together, but the thing is that that seems to be >>> inherent to how `icomplete-in-buffer` currently works. >> >> No, what bothers me is the regression as described by Eli. > > By definition a regression is a bug where a feature that has worked before > stops working. As you noted, icomplete-in-buffer didn't work for years, > until I fixed it for Emacs 29 (as least brought it to a usable state). > The test case that you described shows its effect only by accident, > until Eshel improved the related behavior of completion-in-region-mode, > so that now icomplete-in-buffer works consistently when it enables > both at the same time: in-buffer completions and in *Completions*. > > So instead of trying to restore an arbitrary behavior at the moment > just after icomplete-in-buffer became usable, it would be much more > useful to invest energy to deciding how better to finish this feature. Okay, well, if we think about it in terms of finishing the feature, then as the person who worked on it previously, could you share how you think it ought to work? ISTM that a single tab in Eshell starting completion, and a single tab not popping up a *Completions* buffer, are pretty clearly what we would want it to do, but maybe I just got used to it :) -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 10 12:54:36 2023 Received: (at 67661) by debbugs.gnu.org; 10 Dec 2023 17:54:36 +0000 Received: from localhost ([127.0.0.1]:51767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCO0i-0000CV-Ez for submit@debbugs.gnu.org; Sun, 10 Dec 2023 12:54:36 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:56021) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCO0f-0000Bt-Rk; Sun, 10 Dec 2023 12:54:34 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id F145F240002; Sun, 10 Dec 2023 17:54:11 +0000 (UTC) From: Juri Linkov To: Sean Whitton Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <87fs0burie.fsf@zephyr.silentflame.com> (Sean Whitton's message of "Sat, 09 Dec 2023 19:04:25 +0000") Organization: LINKOV.NET References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> Date: Sun, 10 Dec 2023 19:46:58 +0200 Message-ID: <86msuihxwl.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , Eshel Yaron , 67001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Okay, well, if we think about it in terms of finishing the feature, then > as the person who worked on it previously, could you share how you think > it ought to work? > > ISTM that a single tab in Eshell starting completion, and a single tab > not popping up a *Completions* buffer, are pretty clearly what we would > want it to do, but maybe I just got used to it :) I think that Eshel is right about setting `completion-in-region-function` to a new function. This function should be like `completion--in-region` but without this line: (completion--in-region-1 start end) If you just remove this line from `completion--in-region` then it should work like you expected without popping up *Completions*. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 10 16:42:30 2023 Received: (at 67661) by debbugs.gnu.org; 10 Dec 2023 21:42:31 +0000 Received: from localhost ([127.0.0.1]:51870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCRZG-0006Ar-J8 for submit@debbugs.gnu.org; Sun, 10 Dec 2023 16:42:30 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:41669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCRZD-0006AY-EV; Sun, 10 Dec 2023 16:42:28 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 8E1EF5C00A7; Sun, 10 Dec 2023 16:42:07 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 10 Dec 2023 16:42:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1702244527; x= 1702330927; bh=E8V89cxmg9G9QkkYx3v7vOqCgouK+kq/njNUP87GGyU=; b=N 0HhW1/J+ziGLvbxyuxhZT2ZVCZjb4FdDu7+50+amkn0WHT6NRSi5mIAMa7dNyacD NwfmunjFNYSK2x7UHAdc+9Omfdymc0aNcNvkmjWQ5Ez4QYFtzLbdueTnrp7eHp/v 6JfKvKlZ+AvNsfyjk5HN0pguytrrzloDy8rnHIMYeS1wTEDixVeHIl8+/6LNt+zJ Y3famdgJRh4ZsyisJbi2I1biwesJhqRjuy3svMbVnuut5353UQqg4jyXKLuWQ+k2 RPA9xIdc78Rq+zV7Tk32pKK5rKF1rMl/+y84pRVJsjf3K6LDCb50sSdtDZ8z1/t/ dwa00/SGHb06OoB1UQf/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1702244527; x=1702330927; bh=E8V89cxmg9G9Q kkYx3v7vOqCgouK+kq/njNUP87GGyU=; b=nMQGgr7NdjgLdsgvmv5uDnGDH7B0w z8L+NTo4ryGNhMitz3zuYAN0b65C/y//E4S+l38OPujnSLxeQjYKUekhbXqhShHn Hlb0/GyNe4gqus4L1PsrwCxda/Gyf85FA6dj+f1AKphNA4qi5LRHQLIj787YgT33 IjD7aGRYeu1DsFMaXQC+O8Z3qQoZI+h7VPa1U9k6B/mqxv+RXjiv6AvFQazf4H2j 9YZe3DFF9klFwEy/lJe5ehih4bX05GDqiYyXPkVd4RweOEFbckDWyJeTK0lgclxb I6qHx9r9AR9stF+TxscWACPLEHtxAkENpDzY+u2GI1bioo7EF6RTFoQKg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeltddgudehgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedu keeggeelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 10 Dec 2023 16:42:07 -0500 (EST) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 34F229410BF; Sun, 10 Dec 2023 21:42:06 +0000 (GMT) From: Sean Whitton To: Juri Linkov Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <86msuihxwl.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 10 Dec 2023 19:46:58 +0200") References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> Date: Sun, 10 Dec 2023 21:42:06 +0000 Message-ID: <87r0jtbuq9.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , Eshel Yaron , 67001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Sun 10 Dec 2023 at 07:46pm +02, Juri Linkov wrote: >> Okay, well, if we think about it in terms of finishing the feature, then >> as the person who worked on it previously, could you share how you think >> it ought to work? >> >> ISTM that a single tab in Eshell starting completion, and a single tab >> not popping up a *Completions* buffer, are pretty clearly what we would >> want it to do, but maybe I just got used to it :) > > I think that Eshel is right about setting `completion-in-region-function` > to a new function. This function should be like `completion--in-region` > but without this line: > > (completion--in-region-1 start end) > > If you just remove this line from `completion--in-region` then > it should work like you expected without popping up *Completions*. Thanks, that does indeed restore the behaviour. Should we change this to a different completion-in-region-function in icomplete.el, then? Or what did you have in mind? -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 11 12:22:03 2023 Received: (at 67661) by debbugs.gnu.org; 11 Dec 2023 17:22:03 +0000 Received: from localhost ([127.0.0.1]:54508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCjyl-0001wH-9E for submit@debbugs.gnu.org; Mon, 11 Dec 2023 12:22:03 -0500 Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]:54733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCjyh-0001ux-Nu; Mon, 11 Dec 2023 12:22:00 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 125D4240004; Mon, 11 Dec 2023 17:21:36 +0000 (UTC) From: Juri Linkov To: Sean Whitton Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <87r0jtbuq9.fsf@zephyr.silentflame.com> (Sean Whitton's message of "Sun, 10 Dec 2023 21:42:06 +0000") Organization: LINKOV.NET References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> Date: Mon, 11 Dec 2023 19:15:01 +0200 Message-ID: <865y147vbu.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , Eshel Yaron , 67001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> (completion--in-region-1 start end) >> >> If you just remove this line from `completion--in-region` then >> it should work like you expected without popping up *Completions*. > > Thanks, that does indeed restore the behaviour. > > Should we change this to a different completion-in-region-function in > icomplete.el, then? Or what did you have in mind? What I think is that ideally icomplete-in-buffer in a regular buffer should work like in the minibuffer, i.e. to be active all the time. This is more like completion-preview-mode where in-buffer candidates are shown as you type, whereas explicitly typing M-C-i pops up the *Completions* buffer. Do you agree this would be nice to do? From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 15 07:28:47 2023 Received: (at 67661) by debbugs.gnu.org; 15 Dec 2023 12:28:47 +0000 Received: from localhost ([127.0.0.1]:51734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rE7J8-0000XL-KJ for submit@debbugs.gnu.org; Fri, 15 Dec 2023 07:28:46 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:43849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rE7J7-0000X2-Bv; Fri, 15 Dec 2023 07:28:45 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 517315C02ED; Fri, 15 Dec 2023 07:28:40 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 15 Dec 2023 07:28:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1702643320; x= 1702729720; bh=vzRjPKlz+G3q1yoXS3mhLAU91z3izfe3EDj4s2l4psc=; b=i Nu+FGzkCI3Fc68715sJPnKIwrwZAvTF4lhPtJ6qcjDdjqjV+8cHkfXBfRdBDnfvm vGHaexyHliOeqE6N4WI6NfYCh6MGhoqjMojpPbHDqRFPQK/NdLPGjhe9TXS7+Rte eeXLPKU8fS+lvaVYESccacxBE6wB58wTA1YsNfSJqHAfpNEENzGfH9lkfagD+dt4 OTaWXiqjrFAeu7ssuugYv9Ciw+7cJu27ljtyirgC540dxLZocuvrXNmealjtGDoW Yl/4hV7MuJfkLdFOrGK1yqeT4HG4cpwb1fely3TYIXV1xFtM6lSFgWZOmLB+OcJh FgEA6dFCdYvBqHW98CTrg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1702643320; x=1702729720; bh=vzRjPKlz+G3q1yoXS3mhLAU91z3i zfe3EDj4s2l4psc=; b=Trufwu3yeyeYj+RZrHtshAXswOxiizvtUS2R35eM3mEv xtDMZwH1MhszQWkOPdMxUoEBN69lsuTl+Xqqpqxoa/Zhf5f1zGoYnHUUlcH7E1JS 40ES/CXdOUyiGOrsk+cLH4PyBaAonWcEyrE3cpIoDGvuVVKpnNO46zUzUWrn6q3i 4/1MNiwiz/P3QosAz8d/piQ/XsdPoocFl0MQRFGjHOVwyN+FMZRODMlqYT8DHGVV Gcuwn0EfrCUs8ruTiuut+7NugIU+b+K2tZV9wrHmQn+19/8d4yKyi6a9tCJ00AfM lyRYlHegHLkNP30DTvUFZ/erSlUHm146TXiYmWW1Ow== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtvddggeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 15 Dec 2023 07:28:39 -0500 (EST) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 46CCD940F6F; Fri, 15 Dec 2023 12:28:38 +0000 (GMT) From: Sean Whitton To: Juri Linkov Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <865y147vbu.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 11 Dec 2023 19:15:01 +0200") References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> Date: Fri, 15 Dec 2023 12:28:38 +0000 Message-ID: <871qbnodjd.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , Eshel Yaron , 67001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Mon 11 Dec 2023 at 07:15pm +02, Juri Linkov wrote: >>> (completion--in-region-1 start end) >>> >>> If you just remove this line from `completion--in-region` then >>> it should work like you expected without popping up *Completions*. >> >> Thanks, that does indeed restore the behaviour. >> >> Should we change this to a different completion-in-region-function in >> icomplete.el, then? Or what did you have in mind? > > What I think is that ideally icomplete-in-buffer in a regular buffer > should work like in the minibuffer, i.e. to be active all the time. > This is more like completion-preview-mode where in-buffer candidates > are shown as you type, whereas explicitly typing M-C-i pops up > the *Completions* buffer. Do you agree this would be nice to do? Hmm. This is an interesting idea. I don't think it would suit me, though -- it sounds like it would be quite visually noisy. Do you think we can provide both? -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 19 12:52:22 2023 Received: (at 67661) by debbugs.gnu.org; 19 Dec 2023 17:52:23 +0000 Received: from localhost ([127.0.0.1]:37278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFeGU-0007ma-Eq for submit@debbugs.gnu.org; Tue, 19 Dec 2023 12:52:22 -0500 Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]:36001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFeGS-0007mB-Gq; Tue, 19 Dec 2023 12:52:20 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 8394D1BF205; Tue, 19 Dec 2023 17:52:10 +0000 (UTC) From: Juri Linkov To: Sean Whitton Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <871qbnodjd.fsf@zephyr.silentflame.com> (Sean Whitton's message of "Fri, 15 Dec 2023 12:28:38 +0000") Organization: LINKOV.NET References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> Date: Tue, 19 Dec 2023 19:29:14 +0200 Message-ID: <86il4ut85p.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , Eshel Yaron , 67001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>>> (completion--in-region-1 start end) >>>> >>>> If you just remove this line from `completion--in-region` then >>>> it should work like you expected without popping up *Completions*. >>> >>> Thanks, that does indeed restore the behaviour. >>> >>> Should we change this to a different completion-in-region-function in >>> icomplete.el, then? Or what did you have in mind? >> >> What I think is that ideally icomplete-in-buffer in a regular buffer >> should work like in the minibuffer, i.e. to be active all the time. >> This is more like completion-preview-mode where in-buffer candidates >> are shown as you type, whereas explicitly typing M-C-i pops up >> the *Completions* buffer. Do you agree this would be nice to do? > > Hmm. This is an interesting idea. I don't think it would suit me, > though -- it sounds like it would be quite visually noisy. Do you think > we can provide both? Both are already shown: M-C-i pops up the *Completions* buffer and activates in-buffer candidates. If you want M-C-i only to activate in-buffer candidates, then the line above should be removed from `completion--in-region`. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 19 13:31:48 2023 Received: (at 67661) by debbugs.gnu.org; 19 Dec 2023 18:31:48 +0000 Received: from localhost ([127.0.0.1]:37332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFese-0008AM-2N for submit@debbugs.gnu.org; Tue, 19 Dec 2023 13:31:48 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:35315) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFesb-0008A2-Vj; Tue, 19 Dec 2023 13:31:46 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 1B5DE5C015A; Tue, 19 Dec 2023 13:31:38 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 19 Dec 2023 13:31:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1703010698; x= 1703097098; bh=dKGprMjVNScLosHidq9lsMfoVkaaiBIGrYfoUABKtfQ=; b=r 6d17M1MunQNJXrQ8jjG+nVrEa+AGy3pe1dfoIZEJ/Hs80psVGxE9tudcaknrhZvx uYzpyydHdB4BKiE0dnMcMf+9KhIUXN46zH+opC8my1olDTyWU+K1v6O9xEPTPdR6 Av7x5k+VxAyf4fyBKldZoDBSq03IeSFHOICsBZwbasNPcdIXpPul4Xk/zcwOJwkF xO5E4PSs1APIH7MgltNvbq1Wodomt8U8EIW5vb+r3WxDjc30v/zYYjn1WeiK2d/e 8hxTR5pREm9WG9PHUbTKnj2JNLISZen7Q3Q+3V0uqle1W2sTfH0JpjVN7cWTH7gf Urhn4vN8NEmb9pBJkqzFQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1703010698; x=1703097098; bh=dKGprMjVNScLosHidq9lsMfoVkaa iBIGrYfoUABKtfQ=; b=8iq50SW/EZPRJJM8QInkcOKnCtOFjS2KmZqifrirYurD g78mJaVv5nzML6kv/ljhOgfUcFF64M/YwQvR62/syYYLzgGtWDDHsbslP/J/XXAY GQl5j816qe8A7W1aN26Mq0cuUAXa/z5Glt0Y8v8Og4cnlKWWFDoqy/GoiqvV2k3i siWsH5t/Bqq7ZHaLJy6dc5FrEvAvoRmiA+2rQXbnfhgzJqPksKGPuhHMr/+nTluD v0MtUoJbcEujZlHR5KLvJOY/Iv6dbJLzwOknnnGSqP/C0vJ0H/RDfY0VY/tnMP4d sJAnj12PE3hO8oyaY5Qf6wEctjmzwIx6W/rnFGe9yA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddutddguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedu keeggeelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Dec 2023 13:31:37 -0500 (EST) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 7B4FA9409B4; Tue, 19 Dec 2023 18:31:25 +0000 (GMT) From: Sean Whitton To: Juri Linkov Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <86il4ut85p.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 19 Dec 2023 19:29:14 +0200") References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> Date: Tue, 19 Dec 2023 18:31:25 +0000 Message-ID: <87sf3yxcw2.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , Eshel Yaron , 67001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Tue 19 Dec 2023 at 07:29pm +02, Juri Linkov wrote: > Both are already shown: M-C-i pops up the *Completions* buffer > and activates in-buffer candidates. If you want M-C-i only > to activate in-buffer candidates, then the line above > should be removed from `completion--in-region`. When I said "provide both", I meant both your idea of how the feature should work, and my idea of how it should work. I didn't mean both the in-buffer candidates and the *Completions* buffer. What you've said isn't true, though: a single TAB, which is bound to completion-at-point in Eshell, does not show in-buffer candidates, nor does it pop up the *Completions* buffer. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 19 14:05:24 2023 Received: (at 67661) by debbugs.gnu.org; 19 Dec 2023 19:05:24 +0000 Received: from localhost ([127.0.0.1]:37431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFfPA-00067P-7W for submit@debbugs.gnu.org; Tue, 19 Dec 2023 14:05:24 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:56803) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFfP8-00066z-4o; Tue, 19 Dec 2023 14:05:22 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 6363E1C0005; Tue, 19 Dec 2023 19:05:10 +0000 (UTC) From: Juri Linkov To: Sean Whitton Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <87sf3yxcw2.fsf@zephyr.silentflame.com> (Sean Whitton's message of "Tue, 19 Dec 2023 18:31:25 +0000") Organization: LINKOV.NET References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> Date: Tue, 19 Dec 2023 20:58:04 +0200 Message-ID: <86plz2rp3v.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , Eshel Yaron , 67001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Both are already shown: M-C-i pops up the *Completions* buffer >> and activates in-buffer candidates. If you want M-C-i only >> to activate in-buffer candidates, then the line above >> should be removed from `completion--in-region`. > > When I said "provide both", I meant both your idea of how the feature > should work, and my idea of how it should work. I didn't mean both the > in-buffer candidates and the *Completions* buffer. > > What you've said isn't true, though: a single TAB, which is bound to > completion-at-point in Eshell, does not show in-buffer candidates, nor > does it pop up the *Completions* buffer. Because ls is complete, but not unique. So it requires the second TAB, exactly as in the minibuffer. A single TAB does this on incomplete candidate, e.g. l. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 20 05:34:23 2023 Received: (at 67661) by debbugs.gnu.org; 20 Dec 2023 10:34:23 +0000 Received: from localhost ([127.0.0.1]:38691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFtuA-0006kK-NC for submit@debbugs.gnu.org; Wed, 20 Dec 2023 05:34:23 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:45223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFtu8-0006jz-ER; Wed, 20 Dec 2023 05:34:20 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0E5425C01C0; Wed, 20 Dec 2023 05:34:12 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 20 Dec 2023 05:34:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1703068452; x= 1703154852; bh=E4xrKBcMLNaYhS56cZ8PFmak4zAVv8YE/GqbHI7KCt4=; b=I OfiS7r+Dj9h0vsD44XTnBTsdXCngOdH3FkEtu7pDwlE5dvZYog2K288jDMhZAI2q qYnyK1U1e8Rh/zE+ptE+xtPFObyLWgGTTtpr9gssrYg/+hr+QXL6ZWtwbmlHU3pX lR+5UJ44w51QdMBgjtzHMZeD44sV5a6NbSySu0+EJbCFgyxKF5O98YzkPRnMBSHT fgAX1s3jIFAIYXB9DiHRt2XYK6v/mZoo3yXR2EwdwNCgsnpguWaYJ4ZQkxdaBMT7 2ZP7JXAG78ZCYJq2MoSMlTUMSOFOVwuc0Yf753l6ktv1KdcKlmutPnSkO9mCJsS8 BJyaivRCtz58/N2PRuqTw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1703068452; x=1703154852; bh=E4xrKBcMLNaYhS56cZ8PFmak4zAV v8YE/GqbHI7KCt4=; b=HpSMso82JOK2sanjfQYj8+Prn/itBzIz1UQaYAzDuB8q z7jw9pZoySUcyvWFUKLcZjtkCCq/Ja230PK0Gtd/QzRxzO3BHYyMLMrSBcA20c1H 6Ft3jf2/8xJ+LzAcKE9feaVIPdUedar0dqLe6DoXrkeE4Sq5Yble1GZpQddKB412 a/5BLdQ6KiBT2rnhjm+t3NL7Nk0V3ZIjjBOfa4FfkB3Y/CN0zIsKJhhIHeKefIRR ie+LndIF9/nYDQk39M8DeP1jwhN5TPzEK8aGhaMr5uq9xXDfUngvCmNRFdcgjDp7 J/a0ApDp4YqCNw/Z3DWZxfB+fDUnKgx02AdObfhWsQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdduvddgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 20 Dec 2023 05:34:11 -0500 (EST) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 1F135940BC7; Wed, 20 Dec 2023 10:34:09 +0000 (GMT) From: Sean Whitton To: Juri Linkov Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <86plz2rp3v.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 19 Dec 2023 20:58:04 +0200") References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> Date: Wed, 20 Dec 2023 10:34:09 +0000 Message-ID: <87le9pxivy.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , Eshel Yaron , 67001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Tue 19 Dec 2023 at 08:58pm +02, Juri Linkov wrote: >>> Both are already shown: M-C-i pops up the *Completions* buffer >>> and activates in-buffer candidates. If you want M-C-i only >>> to activate in-buffer candidates, then the line above >>> should be removed from `completion--in-region`. >> >> When I said "provide both", I meant both your idea of how the feature >> should work, and my idea of how it should work. I didn't mean both the >> in-buffer candidates and the *Completions* buffer. >> >> What you've said isn't true, though: a single TAB, which is bound to >> completion-at-point in Eshell, does not show in-buffer candidates, nor >> does it pop up the *Completions* buffer. > > Because ls is complete, but not unique. So it requires the second TAB, > exactly as in the minibuffer. A single TAB does this on incomplete candidate, > e.g. l. Ah. This is not the bug. We may have been subtly miscommunicating. I am talking about completing the first argument to the command, not the 'ls' command itself. So for example: 1. emacs -q 2. (setopt icomplete-in-buffer t) 3. M-x icomplete-mode 4. M-x eshell 5. cd ~/src/emacs/ 6. ls l It takes a second to have Emacs display leim, lib, lib-src, lisp etc.. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 20 12:15:28 2023 Received: (at 67661) by debbugs.gnu.org; 20 Dec 2023 17:15:29 +0000 Received: from localhost ([127.0.0.1]:41708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rG0AK-0002vZ-CL for submit@debbugs.gnu.org; Wed, 20 Dec 2023 12:15:28 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:39643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rG0AH-0002aX-22; Wed, 20 Dec 2023 12:15:26 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id E01AAFF806; Wed, 20 Dec 2023 17:15:13 +0000 (UTC) From: Juri Linkov To: Sean Whitton Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <87le9pxivy.fsf@zephyr.silentflame.com> (Sean Whitton's message of "Wed, 20 Dec 2023 10:34:09 +0000") Organization: LINKOV.NET References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> <87le9pxivy.fsf@zephyr.silentflame.com> Date: Wed, 20 Dec 2023 19:14:49 +0200 Message-ID: <86jzp898um.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , Eshel Yaron , 67001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Because ls is complete, but not unique. So it requires the second TAB, >> exactly as in the minibuffer. A single TAB does this on incomplete candidate, >> e.g. l. > > Ah. This is not the bug. We may have been subtly miscommunicating. > I am talking about completing the first argument to the command, not > the 'ls' command itself. > > So for example: > > 1. emacs -q > 2. (setopt icomplete-in-buffer t) > 3. M-x icomplete-mode > 4. M-x eshell > 5. cd ~/src/emacs/ > 6. ls l > > It takes a second to have Emacs display leim, lib, lib-src, lisp etc.. Thanks for the reproducible test case. It seems there is a bug somewhere in pcomplete-completions-at-point. Without icomplete: 1. emacs -q 2. M-x eshell 3. ls l says "Complete, but not unique" that is not true. There is no such problem with shell that uses comint-completion-at-point instead of pcomplete-completions-at-point. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 22 07:00:51 2023 Received: (at 67661) by debbugs.gnu.org; 22 Dec 2023 12:00:51 +0000 Received: from localhost ([127.0.0.1]:46164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rGeCw-0003Rz-D3 for submit@debbugs.gnu.org; Fri, 22 Dec 2023 07:00:51 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:55051) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rGeCt-0003Dm-UE; Fri, 22 Dec 2023 07:00:48 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 209213200B35; Fri, 22 Dec 2023 07:00:37 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 22 Dec 2023 07:00:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1703246436; x= 1703332836; bh=TL+z57YRT3sdxNNtFAQuO5OpC8q12w4knvNhCsQyZ0A=; b=s GnwpeIB0AIyLE+1LAFjS+0bm/Gpaf7icQFuyzODIIE43euNE7EIfbIjfBMsPUHoQ nX1hK8Bzo1RFkppnkybovkUTxKDmvkQTNS5w/tJgX5NGgupJvLEeKSV132SvKufH 8owDEaOyY1LDmmQTZv6vCRFwhHTce900N3KyJEfuA/y93tOjtjpSvB46t2rGK9uH uQO7CuS7Gxo2Kfk6ePU2WuzmsFlLfRlAZewxbfkF0e/p5ITEqXUYkwfSCwX+V1VH 0alaSMv2bPP3DsInGvOcwmdzrbk1VGo5r+tCq1EHc3Sq8Cxn8qSmXIb9baAnmaE0 dTEcuHOvOHWYkxPXhwQHg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1703246436; x=1703332836; bh=TL+z57YRT3sdxNNtFAQuO5OpC8q1 2w4knvNhCsQyZ0A=; b=mR3PUKAoPlOXl+w+vRJz74JZQzbOf4EKU17VUSjbGkxj 2fL6Hl3cHRDbMkp7+il6oAT4qQJsRhQ1rXuhh4tKhR1BdCizq0MZ6XIZuu8kBf3n oSOUF9UZXLg1lHzeflFzFuuK7FDWaTBoPsPYh6Aeu/nOGKQ0VaDSCynh3GyZqmqw +xY7prMy1dAZ3mXSrBuJD2KsEp3fhthQz2vfRor00SaXOCFPt5pJFOAv1JCz98op tKZ0oNvnWNu64KqJ2eyLcTbLsOI1RsZlhItNQh6mKy/1gurMjew9qAp0QCpIikIF y+I8aLP/3XK4L3lNct4ao0gI8f0T+cuc2VmyCjnSnA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddujedgfeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 22 Dec 2023 07:00:35 -0500 (EST) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 807109416EC; Fri, 22 Dec 2023 12:00:33 +0000 (GMT) From: Sean Whitton To: Juri Linkov , Eshel Yaron , Eli Zaretskii Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <86jzp898um.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 20 Dec 2023 19:14:49 +0200") References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> <87le9pxivy.fsf@zephyr.silentflame.com> <86jzp898um.fsf@mail.linkov.net> Date: Fri, 22 Dec 2023 12:00:33 +0000 Message-ID: <874jgaxx9a.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, control@debbugs.gnu.org, 67001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) retitle 67661 30.0.50; Completion problem introduced by commit 5416896d608 thanks Hello, On Wed 20 Dec 2023 at 07:14pm +02, Juri Linkov wrote: > Thanks for the reproducible test case. It seems there is a bug somewhere in > pcomplete-completions-at-point. Without icomplete: > > 1. emacs -q > 2. M-x eshell > 3. ls l > > says "Complete, but not unique" that is not true. > > There is no such problem with shell that uses comint-completion-at-point > instead of pcomplete-completions-at-point. I have confirmed that 5416896d608 is the commit that introduces/reveals the problem, for my revised test case. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 23 12:40:29 2023 Received: (at 67661) by debbugs.gnu.org; 23 Dec 2023 17:40:30 +0000 Received: from localhost ([127.0.0.1]:51159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rH5zB-0007Rs-Ig for submit@debbugs.gnu.org; Sat, 23 Dec 2023 12:40:29 -0500 Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]:36557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rH5z9-0007RZ-Kp; Sat, 23 Dec 2023 12:40:27 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 08F1340003; Sat, 23 Dec 2023 17:40:14 +0000 (UTC) From: Juri Linkov To: Sean Whitton Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <874jgaxx9a.fsf@zephyr.silentflame.com> (Sean Whitton's message of "Fri, 22 Dec 2023 12:00:33 +0000") Organization: LINKOV.NET References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> <87le9pxivy.fsf@zephyr.silentflame.com> <86jzp898um.fsf@mail.linkov.net> <874jgaxx9a.fsf@zephyr.silentflame.com> Date: Sat, 23 Dec 2023 19:38:20 +0200 Message-ID: <86zfy0hl9u.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , Eshel Yaron , control@debbugs.gnu.org, 67001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Thanks for the reproducible test case. It seems there is a bug somewhere in >> pcomplete-completions-at-point. Without icomplete: >> >> 1. emacs -q >> 2. M-x eshell >> 3. ls l >> >> says "Complete, but not unique" that is not true. >> >> There is no such problem with shell that uses comint-completion-at-point >> instead of pcomplete-completions-at-point. > > I have confirmed that 5416896d608 is the commit that introduces/reveals > the problem, for my revised test case. This means that 5416896d608 exposed a bug in pcomplete-completions-at-point. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 29 12:48:01 2023 Received: (at 67661) by debbugs.gnu.org; 29 Dec 2023 17:48:01 +0000 Received: from localhost ([127.0.0.1]:42198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJGxl-0006YO-4I for submit@debbugs.gnu.org; Fri, 29 Dec 2023 12:48:01 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:49931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJGxj-0006XY-53; Fri, 29 Dec 2023 12:47:59 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id E9F415C01AE; Fri, 29 Dec 2023 12:47:53 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 29 Dec 2023 12:47:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1703872073; x= 1703958473; bh=uVWjla9JBUHUdceUXdnorIvrfNcV529HOPnAAwAQlAc=; b=n R1N6B1uZOaiGya3+gdNdbPIkkwIGg5ZGB7opqG9HCyPfOHKRiIGHPfbG6evE/inN u03ETNHgYx2Kv18yiWga9UTVMi8whCvVr3LNaMu+5SkGfpGTsWZ7DHj70BzCMJ52 bBmPyhrRzAgxFDq5O/U2QVWqGpJ0l5TS7lfvBvMzbLzjsmjRfKRZU4pRIaNW5x2f xfHdOX93tbW3thVRXYxqmP2OWzhHLbTN8CZejXLv2vPvG3RXGmlO0oJ5GWIWPrnh qlO55K/8pCBxU9qQZIQebJVFxw9Wgh21uV6zC1r/EBzmHGjKXSb1VgnmGDFacfiz jYThDX5uXtRT30LBtAxLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1703872073; x=1703958473; bh=uVWjla9JBUHUdceUXdnorIvrfNcV 529HOPnAAwAQlAc=; b=LBsKPTwB+iPHV8uSdiWZVUVUtbfjgR1KphS6hVfIPBSe +TCqAezPOshtEtpcYRXB3Pj7BOlfZdT+4rtz+ytkiUYI9wYViDRo6S3VzozcVlAM 84wc4Za7bjyLzgsdqTo/QdUyPIIjJiNhC6MORkYbyVrnnZPhexO8z+v8ECQfYc70 RjY7SgQRtNQFtGjvS0UKjh5U3laP58pj8IXT8TjNGB++SF7cl9PTsrCbjeII6nNE ZHFQHbnicTZz3qbu6J5Gfj6bELqlHO6TrHcJi0cHIQLu8Xh2ffiQEGqPEsAKc1o3 MPnJPA35tLArHTYRhqAORNPlK1UDWCP7BBJ7ectfJQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeffedguddthecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedu keeggeelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 29 Dec 2023 12:47:53 -0500 (EST) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 4C9C9941829; Fri, 29 Dec 2023 17:47:51 +0000 (GMT) From: Sean Whitton To: Juri Linkov , Eli Zaretskii Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <87le9pxivy.fsf@zephyr.silentflame.com> (Sean Whitton's message of "Wed, 20 Dec 2023 10:34:09 +0000") References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> <87le9pxivy.fsf@zephyr.silentflame.com> Date: Fri, 29 Dec 2023 17:47:51 +0000 Message-ID: <87frzk294o.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, control@debbugs.gnu.org, Eshel Yaron X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) retitle 67661 30.0.50; *Completions* has started popping up for icomplete-in-buffer thanks Hello, On Wed 20 Dec 2023 at 10:34am GMT, Sean Whitton wrote: > Ah. This is not the bug. We may have been subtly miscommunicating. > I am talking about completing the first argument to the command, not > the 'ls' command itself. > > So for example: > > 1. emacs -q > 2. (setopt icomplete-in-buffer t) > 3. M-x icomplete-mode > 4. M-x eshell > 5. cd ~/src/emacs/ > 6. ls l > > It takes a second to have Emacs display leim, lib, lib-src, lisp etc.. I've pushed a fix for this problem, which was in pcomplete--entries. Thanks again to Juri for pointing me to the Pcomplete machinery. I'm not sure whether to close the bug or not, because there remains the behavioural change for icomplete-in-buffer since Emacs 29.1. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 29 13:00:37 2023 Received: (at 67661) by debbugs.gnu.org; 29 Dec 2023 18:00:37 +0000 Received: from localhost ([127.0.0.1]:42208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJH9w-0008Ow-UT for submit@debbugs.gnu.org; Fri, 29 Dec 2023 13:00:37 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:52241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJH9v-0008Du-Kt for 67661@debbugs.gnu.org; Fri, 29 Dec 2023 13:00:36 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 506405C0112; Fri, 29 Dec 2023 13:00:30 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 29 Dec 2023 13:00:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1703872830; x= 1703959230; bh=iKStFOJOWjrIxhAW41T8zywrQvZMD93nTiDOA4RIayA=; b=S yAmY2UiTgW5DS+4PJTgawYXGcceJpSVs/wyxuPaO6itx0kZnN6OlqEs3xToj4lPP xzdj2ExWK6g5ntEbUimFIqHtAT3yPtvTK+fynhtC+3JN3tMmi89wtsCpo5AVuach s/TA5VoY9tLHMmbu26GYZBHrj9iKLnxWgbEZj8zng4LsKTKNvbCCFWKfA7Ol2qlC 4LywgiEOmtnRN8FZW8VW0qxV/r5+y7AspfcDsVFQugvqRKf+GQODS0D7w4Ff/hWV UArFYPqFjp6EdGyP7Hs8nMHq5NJT4SzRErn/XFnSm22E9PTtXckFK5zfB7F2MGfa dMFQKjWoNVDFzBZC25Jhg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1703872830; x=1703959230; bh=iKStFOJOWjrIxhAW41T8zywrQvZM D93nTiDOA4RIayA=; b=TVf23pY5xoLGH8awOMkMGxedDWtKRSFcMi6YsvXVlq5W TO5oRTuxbzdfHAT4cMTciZPVnZdDX/LqY0k5YdfwIIktumwpbgkTFTlmWA1Eu4Fs DdKQWh8QNIuZl238WX4wF8l5Ytdq1iRhj7wnEGxeTGC+bwGQXLtZH1VouDz35irV FzsgHap4RwocZkriR/4iW/NiyArXJAxZrY3wtBLmXWiGnDBLny6Q8Z9Xb6QE3UPb 8j0KxXLej3atlkCWfcdNHAGzv1eWqZZWDuOQvOZ51uZyspLMPBvMERXenC7bmOen wHq6wjasWRz0cn4pDYAV+sOXogdtQZEWDUoT8HZ4RA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeffedguddtkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedu keeggeelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 29 Dec 2023 13:00:29 -0500 (EST) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 31D4F941829; Fri, 29 Dec 2023 18:00:29 +0000 (GMT) From: Sean Whitton To: Juri Linkov , Eli Zaretskii , Eshel Yaron Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <87frzk294o.fsf@zephyr.silentflame.com> (Sean Whitton's message of "Fri, 29 Dec 2023 17:47:51 +0000") References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> <87le9pxivy.fsf@zephyr.silentflame.com> <87frzk294o.fsf@zephyr.silentflame.com> Date: Fri, 29 Dec 2023 18:00:29 +0000 Message-ID: <87bka828jm.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Fri 29 Dec 2023 at 05:47pm GMT, Sean Whitton wrote: > I'm not sure whether to close the bug or not, because there remains the > behavioural change for icomplete-in-buffer since Emacs 29.1. I've found a work around for the behavioural change: (setopt completion-auto-help t) (advice-add 'completion-at-point :after #'minibuffer-hide-completions) So maybe we should just add something explaining this to NEWS? The default value of completion-auto-help is t, but I had it set to `lazy'. If someone wants the Emacs 29 behaviour back, they'll need to ensure completion-auto-help is t, so I think we should mention it somewhere. Essentially, completion-auto-help now affects both the *Completions* buffer and icomplete-in-buffer's display. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 29 14:27:20 2023 Received: (at 67661) by debbugs.gnu.org; 29 Dec 2023 19:27:20 +0000 Received: from localhost ([127.0.0.1]:42251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJIVr-00086E-Or for submit@debbugs.gnu.org; Fri, 29 Dec 2023 14:27:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJIVp-000861-7a for 67661@debbugs.gnu.org; Fri, 29 Dec 2023 14:27:18 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJIVi-0004b9-S1; Fri, 29 Dec 2023 14:27:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aUabjx0/9sX78gM7K9pyeATY5czdBzCd4FFLicYahiY=; b=R5Ewi4wB9TN4 oP0ppp3U3xpaREf7+kRzVQ1ltkIEUmN04jJpKHERMdXBU0dLlHkAssLnJPa+uJkd1ggtnqiYXpWWl 7fT8+0f/VmrYV1M17+0spFq07tYO3W+M00B0ymMriCYk3/Y71u6b65+ti8k/tySkP/bK+ZN1ysePY RiwfqBC4dZEQI9IRAoSYiNd2UvviUzWTBaT8QT6Ai1Gf9+HGS+/XGju2pP4BNmDemoNzjQOR3qsCi RIgU/nOqOV8H28wXUzuAIpAymHWrYK1F9izWTSQt11JDLEWGD161sFCselms2MR+sNCRwqsV+WEzQ /KAW8iQnhEmd6CwRAxJn6w==; Date: Fri, 29 Dec 2023 21:27:00 +0200 Message-Id: <83bka86c8r.fsf@gnu.org> From: Eli Zaretskii To: Sean Whitton In-Reply-To: <87bka828jm.fsf@zephyr.silentflame.com> (message from Sean Whitton on Fri, 29 Dec 2023 18:00:29 +0000) Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> <87le9pxivy.fsf@zephyr.silentflame.com> <87frzk294o.fsf@zephyr.silentflame.com> <87bka828jm.fsf@zephyr.silentflame.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, me@eshelyaron.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Sean Whitton > Cc: 67661@debbugs.gnu.org > Date: Fri, 29 Dec 2023 18:00:29 +0000 > > Hello, > > On Fri 29 Dec 2023 at 05:47pm GMT, Sean Whitton wrote: > > > I'm not sure whether to close the bug or not, because there remains the > > behavioural change for icomplete-in-buffer since Emacs 29.1. > > I've found a work around for the behavioural change: > > (setopt completion-auto-help t) > (advice-add 'completion-at-point :after #'minibuffer-hide-completions) > > So maybe we should just add something explaining this to NEWS? To which entry in Emacs 29's NEWS would this be related? > The default value of completion-auto-help is t, but I had it set to > `lazy'. > If someone wants the Emacs 29 behaviour back, they'll need to ensure > completion-auto-help is t, so I think we should mention it somewhere. > Essentially, completion-auto-help now affects both the *Completions* > buffer and icomplete-in-buffer's display. If your change modifies the default behavior, that should be called out in NEWS of Emacs 30. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 29 15:24:35 2023 Received: (at 67661) by debbugs.gnu.org; 29 Dec 2023 20:24:36 +0000 Received: from localhost ([127.0.0.1]:42325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJJPH-00037W-G6 for submit@debbugs.gnu.org; Fri, 29 Dec 2023 15:24:35 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:36853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJJPF-00037K-Q5 for 67661@debbugs.gnu.org; Fri, 29 Dec 2023 15:24:34 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 8F6475C02F7; Fri, 29 Dec 2023 15:24:28 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 29 Dec 2023 15:24:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1703881468; x= 1703967868; bh=SrM/zTDb7HIlCtWDW0W+e8IJknUj6KScA6/NlWnn6co=; b=o NZBeU2He1C4MwH9vRz8Z/IujyQl2W2bIZx3FHHUZWfBIrSq7U5vRtWMuMgtzEqg+ DTuANIM59tWRIv6IJXyHihw+wkdfCYNJJB7YJ8qdBWXu1XLWlQc/K9ippKUrh2vs 57qW4WA7c66zFC7vzz+jPl/s8P0l2V2qZQW+aYNbmFs0dPGUDayRa0i4msSy8oP5 6Bd6YDwpeJZbDGf6b8xYcWswAMwxR/+3Q3IN83BRuf0Wd9364uf8nuEw6JmhUzT5 psB5/8aB0l5Wyqe2d4MwdtxCx7QaWoByhcJDFIQzJwm5Wv/jxYGfK9B/bwZaqvax 6rxkrawIoBtV8YY+/tEwg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1703881468; x=1703967868; bh=SrM/zTDb7HIlCtWDW0W+e8IJknUj 6KScA6/NlWnn6co=; b=Jbls7WdcqwtLl3KFCk8iDdLlYowx0vjFevEcJ2HJcgEL 64N2pQOXPsM/WVfRhNykaqYlXoAsuyC1Qz44vAMY0megAMTxe36Ex+Pcwxm3Vyow y7GSWzIRsYoW+jOOwZcaijrpyBU6rAOsLrxW9efG5c2SHWPqAFF9hBzmmsxRIFbp AzviWgp9j3CG+b15dj1DE20O7bGHiEye7anuvOXzGm7W+ogcUhdzAzMZ4QRMMQTM EkXcuRexFL6zG9XIuNlKJiU7DClMlX9lm3yXhf/B7ZpVOGlKI6aL/w69S3E5DVLJ H3VqnyJNdIMZjd37vuizQVOVaojLzRKZhHrIU/dutg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeffedgudefjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedu keeggeelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 29 Dec 2023 15:24:27 -0500 (EST) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 20937941829; Fri, 29 Dec 2023 20:24:26 +0000 (GMT) From: Sean Whitton To: Eli Zaretskii , juri@linkov.net Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <83bka86c8r.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 29 Dec 2023 21:27:00 +0200") References: <87o7f3e4cb.fsf@melete.silentflame.com> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> <87le9pxivy.fsf@zephyr.silentflame.com> <87frzk294o.fsf@zephyr.silentflame.com> <87bka828jm.fsf@zephyr.silentflame.com> <83bka86c8r.fsf@gnu.org> Date: Fri, 29 Dec 2023 20:24:26 +0000 Message-ID: <877ckw21vp.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, me@eshelyaron.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Fri 29 Dec 2023 at 09:27pm +02, Eli Zaretskii wrote: > To which entry in Emacs 29's NEWS would this be related? I'm talking about how Juri fixed icomplete-in-buffer for Emacs 29, and how it's now working differently. Juri's fix wasn't noted in NEWS.29, so there isn't a relevant entry. Let me lay out where I think things stand now that the confounding Pcomplete bug is fixed. Here are four reproductions: ,---- | | 1. emacs -q | 2. (setopt icomplete-in-buffer t | completion-auto-help 'lazy) | 3. M-x icomplete-mode | | | 4a. M-x eshell | 5a. cd ~/src/emacs/ | 6a. lsl | - Emacs 29: in-buffer Icomplete appears | - Emacs 30: nothing happens | 7a. a second time | - Emacs 29: *Completions* pops up | - Emacs 30: in-buffer Icomplete appears & *Completions* pops up | | | 4b. Insert text into *scratch*: (setopt icomplete- | 5b. C-M-i | - Emacs 29: in-buffer Icomplete appears | - Emacs 30: nothing happens | 6b. C-M-i a second time | - Emacs 29: accepts the completion | - Emacs 30: in-buffer Icomplete appears & *Completion* pops up | |---- | | 1. emacs -q | 2. (setopt icomplete-in-buffer t) | 3. M-x icomplete-mode | | | 4a. M-x eshell | 5a. cd ~/src/emacs/ | 6a. lsl | - Emacs 29: in-buffer Icomplete appears | - Emacs 30: in-buffer Icomplete appears & *Completions* pops up | 7a. a second time | - Emacs 29: *Completions* pops up | - Emacs 30: n/a | | | 4b. Insert text into *scratch*: (setopt icomplete- | 5b. C-M-i | - Emacsen 29 & 30: in-buffer Icomplete appears & *Completions* pops up. |---- We could see this as two incompatible changes to icomplete-in-buffer since Emacs 29: A. completion-auto-help now controls whether C-M-i or must be typed twice to display in-buffer Icomplete. Previously, completion-auto-help affected only minibuffer completion. I must have been thinking of it this way when I set it to `lazy'. B. *Completions* now always appears at the same time as the in-buffer Icomplete. Previously, in some cases, it would appear only after typing C-M-i or twice. An Icomplete user like me is likely to want to respond to both these changes. The worst case is how nothing happens after a single in the first reproduction, such that typing two s is always required. Thus, I propose adding a NEWS.30 entry like this: There have been some changes which normalise some behaviour of in-buffer completion that affect users of icomplete-in-buffer. Firstly, completion-auto-help now governs icomplete-in-buffer, whereas previously it affected only minibuffer completion. You may wish to review any existing customisation for completion-auto-help if in-buffer completion behaves in a way that surprises you. Secondly, the *Completions* buffer now always pops up at the same time that Icomplete displays its in-buffer completion. If you would prefer to see only Icomplete's display, which is what you might be used to, you could use (advice-add 'completion-at-point :after #'minibuffer-hide-completions) The reason I haven't gone ahead and added this already is that Juri has suggested further changing icomplete-in-buffer's default behaviour. I don't think that we should do that. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 30 01:30:49 2023 Received: (at 67661) by debbugs.gnu.org; 30 Dec 2023 06:30:49 +0000 Received: from localhost ([127.0.0.1]:42879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJSrx-0006oV-2S for submit@debbugs.gnu.org; Sat, 30 Dec 2023 01:30:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJSru-0006bQ-8Z for 67661@debbugs.gnu.org; Sat, 30 Dec 2023 01:30:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJSrn-00045B-1I; Sat, 30 Dec 2023 01:30:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OxroWjuaLfWKZ2njERNyTy2t2vTc42r24BKvccQVosY=; b=e+tki3xdrR/e 5eZ4FBgDKdm+Myc6GQ85seeosrJg1oM5M+pe5Z5OuuXG8hIQnZcYrC6JxhJneTUbvhTF8Xg7ukJqt Pao3SIya8JnYN0y2iCFjm2jA7xz765N+DpuDi0zkOtwyvS0fzFy9bi4dxuxdDJly5lSFcxD6vTN6p 214qYNmM2YCfWUncf6pdxgir7dL0RUTfZoWgYdYnJFY2vBK6+YQHQBvXZSQNCiZEVheEzxthbL1EK 7BEMUWnlRThmxG3jOW/DDL6INy4QIdGvja1sF5363wbFSLX87VR2h9srH1Rux5oNXOTVpc12QyD3Z OhPrv4PUyrxu29Dg08JgbA==; Date: Sat, 30 Dec 2023 08:30:29 +0200 Message-Id: <838r5c5hiy.fsf@gnu.org> From: Eli Zaretskii To: Sean Whitton In-Reply-To: <877ckw21vp.fsf@zephyr.silentflame.com> (message from Sean Whitton on Fri, 29 Dec 2023 20:24:26 +0000) Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer References: <87o7f3e4cb.fsf@melete.silentflame.com> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> <87le9pxivy.fsf@zephyr.silentflame.com> <87frzk294o.fsf@zephyr.silentflame.com> <87bka828jm.fsf@zephyr.silentflame.com> <83bka86c8r.fsf@gnu.org> <877ckw21vp.fsf@zephyr.silentflame.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, me@eshelyaron.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Sean Whitton > Cc: me@eshelyaron.com, 67661@debbugs.gnu.org > Date: Fri, 29 Dec 2023 20:24:26 +0000 > > On Fri 29 Dec 2023 at 09:27pm +02, Eli Zaretskii wrote: > > > To which entry in Emacs 29's NEWS would this be related? > > I'm talking about how Juri fixed icomplete-in-buffer for Emacs 29, and > how it's now working differently. Juri's fix wasn't noted in NEWS.29, > so there isn't a relevant entry. I thought you were suggesting to add something to NEWS in Emacs 29. If there's no suitable entry there, then I wonder what did you have in mind for Emacs 29 in this area. > Thus, I propose adding a NEWS.30 entry like this: > > There have been some changes which normalise some behaviour of > in-buffer completion that affect users of icomplete-in-buffer. > > Firstly, completion-auto-help now governs icomplete-in-buffer, > whereas previously it affected only minibuffer completion. You may > wish to review any existing customisation for completion-auto-help > if in-buffer completion behaves in a way that surprises you. > > Secondly, the *Completions* buffer now always pops up at the same > time that Icomplete displays its in-buffer completion. If you would > prefer to see only Icomplete's display, which is what you might be > used to, you could use > > (advice-add 'completion-at-point :after #'minibuffer-hide-completions) AFAIU, this should also mention changes in Emacs 29 wrt previous versions. Also, the entry should in terms of user-facing behavior, not in terms of how code works. It should also be more concrete; phrases like "you may wish to review existing customizations" are too vague to be useful. The last paragraph seems to indicate we lack some user option or a variable to get back the old behavior, since using advice-add is less friendly than flipping a variable. (IMO, we are making too many backward-incompatible changes in this area lately. But that's me.) From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 30 05:41:41 2023 Received: (at 67661) by debbugs.gnu.org; 30 Dec 2023 10:41:41 +0000 Received: from localhost ([127.0.0.1]:43107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJWmj-0005fL-AW for submit@debbugs.gnu.org; Sat, 30 Dec 2023 05:41:41 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:47761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJWmh-0005f9-RB for 67661@debbugs.gnu.org; Sat, 30 Dec 2023 05:41:40 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id F24D25C01C9; Sat, 30 Dec 2023 05:41:33 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 30 Dec 2023 05:41:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1703932893; x= 1704019293; bh=W+kQ6T2Teg6y/Lx2QOrFNlkJaMSFbbaxexQude72VZw=; b=E MXnSE9DYiCWxhvnnPXfxK9HV3knWKKSiFWwmjjLnSwqGHEzr42SRpjHt6TfgIs+L QqZwBogWEa5Ce0hdxP8qQEe3k5FJJjRoRvG4ik1C+5M/SzUSVvZsxCJlhkwGQd5Y 7x7vvdSxtCqeKgPTgm52uO4VY2ayVUI0mNpQY7PoAenHDBq+4gEaFRm+THh7oBzX MVtgzkrSBeX238TipRDAnl4WoDx52+B5z7vgZmOSQlerAjcoh27qpuS/PPvyzj27 azjX1WNRw3de4E1LGRh/kdZsqqZt8ZMpKCj48/VnBy9n73a7t4EDdpuqfhzzaPZd doQirFsRj/Pxn478I905A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1703932893; x=1704019293; bh=W+kQ6T2Teg6y/Lx2QOrFNlkJaMSF bbaxexQude72VZw=; b=UkRv/1BQRC50E7egKX2BDmRDSx3qElJt9ZY2fflj+FEY a2db656feFG7eekQTfHr1y23bGxuJViJlImIAvs0+/I56MC+kIrR/bgbRn5wfrJc scojGxbtIuwi8wJPtDHwiq1fAPBjsEWntZFK/cnxuPiJhjKHZW7BfbhZwWH+9O+l vSnQaje0YFH78p66Dd85ZvpKZoKDSsxBavATY7bmVWEKdA9yHYv5PmyAIg3CbnSf wnepmVy0vNjjKy/yGZtDlXOn/IrXG13HLYokOqzR26GpMleYji8oqrwqL4Q2NJx2 AReWNdlWGCLFbA+/YqEMQrKepQs8TvF9hBRoISX9/A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdefhedgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 30 Dec 2023 05:41:33 -0500 (EST) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 26285942278; Sat, 30 Dec 2023 10:41:32 +0000 (GMT) From: Sean Whitton To: Eli Zaretskii Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <838r5c5hiy.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Dec 2023 08:30:29 +0200") References: <87o7f3e4cb.fsf@melete.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> <87le9pxivy.fsf@zephyr.silentflame.com> <87frzk294o.fsf@zephyr.silentflame.com> <87bka828jm.fsf@zephyr.silentflame.com> <83bka86c8r.fsf@gnu.org> <877ckw21vp.fsf@zephyr.silentflame.com> <838r5c5hiy.fsf@gnu.org> Date: Sat, 30 Dec 2023 10:41:32 +0000 Message-ID: <87o7e8yntv.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, me@eshelyaron.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Sat 30 Dec 2023 at 08:30am +02, Eli Zaretskii wrote: > AFAIU, this should also mention changes in Emacs 29 wrt previous > versions. > > Also, the entry should in terms of user-facing behavior, not in terms > of how code works. It should also be more concrete; phrases like "you > may wish to review existing customizations" are too vague to be > useful. Thank you for the feedback. I've committed some documentation updates, and would welcome any further revision. > The last paragraph seems to indicate we lack some user option or a > variable to get back the old behavior, since using advice-add is less > friendly than flipping a variable. > > (IMO, we are making too many backward-incompatible changes in this > area lately. But that's me.) I decided to go ahead and commit the documentation updates so that the current state of play is written down. Perhaps after further discussion we'll want to make other changes. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 30 13:08:55 2023 Received: (at 67661) by debbugs.gnu.org; 30 Dec 2023 18:08:55 +0000 Received: from localhost ([127.0.0.1]:45033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJdlW-0003YI-UW for submit@debbugs.gnu.org; Sat, 30 Dec 2023 13:08:55 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:35193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJdlV-0003Xy-4M for 67661@debbugs.gnu.org; Sat, 30 Dec 2023 13:08:54 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 6B2A4C0004; Sat, 30 Dec 2023 18:08:45 +0000 (UTC) From: Juri Linkov To: Sean Whitton Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <877ckw21vp.fsf@zephyr.silentflame.com> (Sean Whitton's message of "Fri, 29 Dec 2023 20:24:26 +0000") Organization: LINKOV.NET References: <87o7f3e4cb.fsf@melete.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> <87le9pxivy.fsf@zephyr.silentflame.com> <87frzk294o.fsf@zephyr.silentflame.com> <87bka828jm.fsf@zephyr.silentflame.com> <83bka86c8r.fsf@gnu.org> <877ckw21vp.fsf@zephyr.silentflame.com> Date: Sat, 30 Dec 2023 19:50:45 +0200 Message-ID: <86ttnztvsi.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , me@eshelyaron.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > | 4b. Insert text into *scratch*: (setopt icomplete- > | 5b. C-M-i > | - Emacsen 29 & 30: in-buffer Icomplete appears & *Completions* pops up. This is exactly how icomplete-in-buffer was intended to work. > Secondly, the *Completions* buffer now always pops up at the same > time that Icomplete displays its in-buffer completion. If you would > prefer to see only Icomplete's display, which is what you might be > used to, you could use > > (advice-add 'completion-at-point :after #'minibuffer-hide-completions) > > The reason I haven't gone ahead and added this already is that Juri has > suggested further changing icomplete-in-buffer's default behaviour. > I don't think that we should do that. I suggested adding a new option that would disable popping up *Completions*. This is preferable to instructing users how to use advice-add. But this might be not quite straightforward to implement. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 30 13:09:05 2023 Received: (at 67661) by debbugs.gnu.org; 30 Dec 2023 18:09:06 +0000 Received: from localhost ([127.0.0.1]:45037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJdlh-0003Z8-7m for submit@debbugs.gnu.org; Sat, 30 Dec 2023 13:09:05 -0500 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]:56021) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJdlX-0003Y2-TC for 67661@debbugs.gnu.org; Sat, 30 Dec 2023 13:08:56 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 10AB4C0002; Sat, 30 Dec 2023 18:08:47 +0000 (UTC) From: Juri Linkov To: Sean Whitton Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <87o7e8yntv.fsf@zephyr.silentflame.com> (Sean Whitton's message of "Sat, 30 Dec 2023 10:41:32 +0000") Organization: LINKOV.NET References: <87o7f3e4cb.fsf@melete.silentflame.com> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> <87le9pxivy.fsf@zephyr.silentflame.com> <87frzk294o.fsf@zephyr.silentflame.com> <87bka828jm.fsf@zephyr.silentflame.com> <83bka86c8r.fsf@gnu.org> <877ckw21vp.fsf@zephyr.silentflame.com> <838r5c5hiy.fsf@gnu.org> <87o7e8yntv.fsf@zephyr.silentflame.com> Date: Sat, 30 Dec 2023 19:52:38 +0200 Message-ID: <86frzjtvpd.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , me@eshelyaron.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I decided to go ahead and commit the documentation updates so that the > current state of play is written down. Perhaps after further discussion > we'll want to make other changes. I noticed in your changes that it's probably better to use the official name "Icomplete mode": diff --git a/doc/emacs/buffers.texi b/doc/emacs/buffers.texi @@ -728,7 +728,7 @@ Icomplete @findex icomplete-mode @cindex Icomplete mode - Icomplete global minor mode provides a convenient way to quickly select an + Icomplete provides a convenient way to quickly select an element among the possible completions in a minibuffer. When enabled, typing in the minibuffer continuously displays a list of possible completions that match the string you have typed. i.e. "Icomplete mode provides a convenient way to..." From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 30 14:43:39 2023 Received: (at 67661) by debbugs.gnu.org; 30 Dec 2023 19:43:39 +0000 Received: from localhost ([127.0.0.1]:45095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJfFC-0004ny-Q4 for submit@debbugs.gnu.org; Sat, 30 Dec 2023 14:43:39 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:43499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJfF8-0004nc-UP for 67661@debbugs.gnu.org; Sat, 30 Dec 2023 14:43:37 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id EAD1632002B6; Sat, 30 Dec 2023 14:43:27 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 30 Dec 2023 14:43:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1703965407; x= 1704051807; bh=iOkM/yqdamBVnfv1unLCRpQfelTTfRU7QwYBNAKYobA=; b=B GACba86jI8PejKUUu7YAPc4EaE6zZkhN8sN+JFWd8ZCFtD0oCCj1mW8yqDA+paOe +17t4u8+zLfv8Os7p3ef7RaSosyOeCiMubLIIDOQ9TWPLiJgYd2P62dt62Gwhb0/ CZQW2DKpNUXQQNgeER9Wk3d5+hRZINZNA8mrwZTfLaCPArhq+j0otzXarlcmTN1a Iot2LHsLfIApPD9A/rFfC8pkvzDNx/hwF5u7VAOLxaoz8PeKM1xYoZ422Jhn/4+k tigDba4w7SVmmku3NqzkOWNSgjXyb3nbMM7RGelt/SxWre1G7AbVQvtOZtxNS42N YeaHFssM4jQsrykfq4sLA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1703965407; x=1704051807; bh=iOkM/yqdamBVnfv1unLCRpQfelTT fRU7QwYBNAKYobA=; b=uUfWG3uApfYmVinXpoDAk7W7IeIxuY1R82aAeOD9f3Z2 aMK/3qK3RIkLfgof3U1dlv3Jqd1AOzi+u6oC3GsQMTuycFOE6aOf5X5UaS8j+uJL PmQ9dTyrYpCZrjQL+/pJpl1TYIC8SFN7oF+i3PYEOfodrXkpGqnksGIphirY3g7E +0cuVRJkjNfRFeg6VANSmlYrrWXQ0UyY3IR8Cc4uqMg1PKdEJ4mx2m0Au2fPS8Q/ 6vG7tX4EaSsX+7JlxCP4vj8JYw734NDAJ8FeOG+DdbQULe6qNbr8KL4sODGhTMV8 YjqIBxkIjJPtjPuLFNzazJ/FLHcQ6T2gNFmNQw/diw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdefhedguddvlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedu keeggeelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 30 Dec 2023 14:43:26 -0500 (EST) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 6941F940543; Sat, 30 Dec 2023 19:43:25 +0000 (GMT) From: Sean Whitton To: Juri Linkov Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <86ttnztvsi.fsf@mail.linkov.net> (Juri Linkov's message of "Sat, 30 Dec 2023 19:50:45 +0200") References: <87o7f3e4cb.fsf@melete.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> <87le9pxivy.fsf@zephyr.silentflame.com> <87frzk294o.fsf@zephyr.silentflame.com> <87bka828jm.fsf@zephyr.silentflame.com> <83bka86c8r.fsf@gnu.org> <877ckw21vp.fsf@zephyr.silentflame.com> <86ttnztvsi.fsf@mail.linkov.net> Date: Sat, 30 Dec 2023 19:43:25 +0000 Message-ID: <87wmsvxyqq.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , me@eshelyaron.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Sat 30 Dec 2023 at 07:50pm +02, Juri Linkov wrote: >> | 4b. Insert text into *scratch*: (setopt icomplete- >> | 5b. C-M-i >> | - Emacsen 29 & 30: in-buffer Icomplete appears & *Completions* pops up. > > This is exactly how icomplete-in-buffer was intended to work. Right, yeah, I now understand that. In a previous message you said you think that icomplete-in-buffer is unfinished, and you'd like to consider further changes to how it works. Is that something you're still considering, or are you setting that aside for the time being? I ask because if you are happy with how things are now, we could close this bug. >> Secondly, the *Completions* buffer now always pops up at the same >> time that Icomplete displays its in-buffer completion. If you would >> prefer to see only Icomplete's display, which is what you might be >> used to, you could use >> >> (advice-add 'completion-at-point :after #'minibuffer-hide-completions) >> >> The reason I haven't gone ahead and added this already is that Juri has >> suggested further changing icomplete-in-buffer's default behaviour. >> I don't think that we should do that. > > I suggested adding a new option that would disable popping up *Completions*. > This is preferable to instructing users how to use advice-add. But this > might be not quite straightforward to implement. Yes, that would be preferable, if someone wants to work on it at some point. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 30 14:43:56 2023 Received: (at 67661) by debbugs.gnu.org; 30 Dec 2023 19:43:56 +0000 Received: from localhost ([127.0.0.1]:45100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJfFU-0004oX-90 for submit@debbugs.gnu.org; Sat, 30 Dec 2023 14:43:56 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:50383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJfFS-0004oJ-8w for 67661@debbugs.gnu.org; Sat, 30 Dec 2023 14:43:54 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 96EEA3200A1B; Sat, 30 Dec 2023 14:43:47 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 30 Dec 2023 14:43:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1703965427; x= 1704051827; bh=2KXM9vb+PsmWW5d3oT2+68piICBo1TvS2T8TEfZC3z4=; b=e YYNGeuuZHsU7PXd8wDH87aj/X+HIL2m9lrxWRHrzFqmIJmLQTvW22LY1Nq/6Px3I 4g8u4JprmeYBZWydWjV/9k/qBsuS9Evoh/bwQnueydX92dAPeJeOgAnwiF0fzbSs eZ0kJz35qQ+vM+fKN0zAb2q4YkKwXy322YylTBynWYNrF3jhF8VFOeUimgB+Oa2b wURxgKuyBHWRjEUsIalFX9ePfzSeo93hDbpH51Xsz0PQqnKLlmRkZ7f7w3Ni4b8b mMjuHvcQl2S36hNJI1CyTrXEutXyHiqe31oWtbHbboAMzZbNpu75XTuiHbhcCg/7 0HGty/JbjpCnwShhI/WzQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1703965427; x=1704051827; bh=2KXM9vb+PsmWW5d3oT2+68piICBo 1TvS2T8TEfZC3z4=; b=2RWIJvWq6AlyPX2f+cwaDf0v8JMPz7EYdWLxLtkCHV/e uyE8rOuF5mh99UEiwl6OBWrgCXXI+OMefY5Lz3gM4hobeZuU+M3VX38GJk3WRCp9 oQXcBBspD3LYdKxcN3sOpMD3vvf1OkgiD3v27Uxh/MOLsP337RpV1X9Kuz8dD8V9 Uyy7Es4npxTM6xg/B4J4AgOgWuYzXRaJB+9yQKL1g4XvgP2TaZJ00kgiyfihy98x X7k5rZkwiti4kAL5Uvhd4xX/fgwNFJxs3hSLMHzlCmqw6/Qa4cSZIWR8CfYaGS30 ZnH+rrIkID40ajKesVaULbTY1eDSmQ7jf1cZjNIZCg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdefhedgudeftdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedu keeggeelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 30 Dec 2023 14:43:46 -0500 (EST) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id E75C1940543; Sat, 30 Dec 2023 19:43:45 +0000 (GMT) From: Sean Whitton To: Juri Linkov Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <86frzjtvpd.fsf@mail.linkov.net> (Juri Linkov's message of "Sat, 30 Dec 2023 19:52:38 +0200") References: <87o7f3e4cb.fsf@melete.silentflame.com> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> <87le9pxivy.fsf@zephyr.silentflame.com> <87frzk294o.fsf@zephyr.silentflame.com> <87bka828jm.fsf@zephyr.silentflame.com> <83bka86c8r.fsf@gnu.org> <877ckw21vp.fsf@zephyr.silentflame.com> <838r5c5hiy.fsf@gnu.org> <87o7e8yntv.fsf@zephyr.silentflame.com> <86frzjtvpd.fsf@mail.linkov.net> Date: Sat, 30 Dec 2023 19:43:45 +0000 Message-ID: <87mstrxyq6.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , me@eshelyaron.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Sat 30 Dec 2023 at 07:52pm +02, Juri Linkov wrote: >> I decided to go ahead and commit the documentation updates so that the >> current state of play is written down. Perhaps after further discussion >> we'll want to make other changes. > > I noticed in your changes that it's probably better to use the official name > "Icomplete mode": > > diff --git a/doc/emacs/buffers.texi b/doc/emacs/buffers.texi > @@ -728,7 +728,7 @@ Icomplete > @findex icomplete-mode > @cindex Icomplete mode > > - Icomplete global minor mode provides a convenient way to quickly select an > + Icomplete provides a convenient way to quickly select an > element among the possible completions in a minibuffer. When enabled, typing > in the minibuffer continuously displays a list of possible completions that > match the string you have typed. > > i.e. "Icomplete mode provides a convenient way to..." Thanks, done. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 31 03:35:31 2023 Received: (at 67661) by debbugs.gnu.org; 31 Dec 2023 08:35:31 +0000 Received: from localhost ([127.0.0.1]:45600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJrIA-00017t-T9 for submit@debbugs.gnu.org; Sun, 31 Dec 2023 03:35:31 -0500 Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]:56291) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJrI8-00017b-M6; Sun, 31 Dec 2023 03:35:29 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 78571240002; Sun, 31 Dec 2023 08:35:19 +0000 (UTC) From: Juri Linkov To: Sean Whitton Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <87wmsvxyqq.fsf@zephyr.silentflame.com> (Sean Whitton's message of "Sat, 30 Dec 2023 19:43:25 +0000") Organization: LINKOV.NET References: <87o7f3e4cb.fsf@melete.silentflame.com> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> <87le9pxivy.fsf@zephyr.silentflame.com> <87frzk294o.fsf@zephyr.silentflame.com> <87bka828jm.fsf@zephyr.silentflame.com> <83bka86c8r.fsf@gnu.org> <877ckw21vp.fsf@zephyr.silentflame.com> <86ttnztvsi.fsf@mail.linkov.net> <87wmsvxyqq.fsf@zephyr.silentflame.com> Date: Sun, 31 Dec 2023 10:29:28 +0200 Message-ID: <864jfybwrb.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , me@eshelyaron.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 67661 30.0.50 thanks > In a previous message you said you think that icomplete-in-buffer is > unfinished, and you'd like to consider further changes to how it works. > Is that something you're still considering, or are you setting that > aside for the time being? > > I ask because if you are happy with how things are now, we could close > this bug. Right, let's close this bug. If someone wants to implement a new option, it's easy to open a new feature request. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 09 22:12:36 2024 Received: (at 67661) by debbugs.gnu.org; 10 Jan 2024 03:12:36 +0000 Received: from localhost ([127.0.0.1]:41503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNP1A-00043r-8Q for submit@debbugs.gnu.org; Tue, 09 Jan 2024 22:12:36 -0500 Received: from out-182.mta0.migadu.com ([2001:41d0:1004:224b::b6]:42380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNP17-00043h-UR for 67661@debbugs.gnu.org; Tue, 09 Jan 2024 22:12:35 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; s=key1; t=1704856345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6N392b4OCwjPj+zv00QyRl+g3BDDSkWU1Zm+Y8SH4iY=; b=K6PfYGXkMi5CgnPb+3WDa9SKunIVamIzFn6R4UNEY3O9ti1MvL+06h7H1dheEAkgZVhTbH auXc4M4VhKCwpcGThqSYFNwsctjti6HwB0g8GwhRRibS9lOxW6sYDBM/REZT3N+M7VI1Q1 73IFKjD3En77R8dFYul1/oWCIV5fdBM= From: john muhl To: Sean Whitton Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <87bka828jm.fsf@zephyr.silentflame.com> (Sean Whitton's message of "Fri, 29 Dec 2023 18:00:29 +0000") References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> <87le9pxivy.fsf@zephyr.silentflame.com> <87frzk294o.fsf@zephyr.silentflame.com> <87bka828jm.fsf@zephyr.silentflame.com> Date: Tue, 09 Jan 2024 21:12:22 -0600 Message-ID: <87zfxdvq3t.fsf@pub.pink> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , Eshel Yaron , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sean Whitton writes: I forgot the CCs. Sorry Sean for the double email. > Hello, > > On Fri 29 Dec 2023 at 05:47pm GMT, Sean Whitton wrote: > >> I'm not sure whether to close the bug or not, because there remains the >> behavioural change for icomplete-in-buffer since Emacs 29.1. > > I've found a work around for the behavioural change: > > (setopt completion-auto-help t) > (advice-add 'completion-at-point :after #'minibuffer-hide-completions) > > So maybe we should just add something explaining this to NEWS? > > The default value of completion-auto-help is t, but I had it set to > `lazy'. > If someone wants the Emacs 29 behaviour back, they'll need to ensure > completion-auto-help is t, so I think we should mention it somewhere. > Essentially, completion-auto-help now affects both the *Completions* > buffer and icomplete-in-buffer's display. This commit (d7ff14fcba6) caused an eshell test to start failing. It seems like the test was written to account for the above mentioned bug in pcomplete but wasn=E2=80=99t sure. Attached is the test output and the change in the test to fix it. --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=em-cmpl-tests.log Running 27 tests (2024-01-09 20:53:56-0600, selector `(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))') Loading em-alias... Loading em-banner... Loading em-basic... Loading em-extpipe... Loading em-glob... Loading em-ls... Loading em-pred... Loading em-prompt... Loading em-script... Loading em-term... passed 1/27 em-cmpl-test/command-completion (0.031879 sec) passed 2/27 em-cmpl-test/file-completion/after-list (0.002264 sec) passed 3/27 em-cmpl-test/file-completion/glob (0.001335 sec) Test em-cmpl-test/file-completion/non-unique backtrace: signal(ert-test-failed (((should (looking-at "Complete, but not uniq ert-fail(((should (looking-at "Complete, but not unique")) :form (lo (if (unwind-protect (setq value-67 (apply fn-65 args-66)) (setq form (let (form-description-69) (if (unwind-protect (setq value-67 (apply (let ((value-67 'ert-form-evaluation-aborted-68)) (let (form-descrip (let* ((fn-65 #'looking-at) (args-66 (condition-case err (list "Comp (save-excursion (goto-char (point-max)) (forward-line -1) (let* ((fn (save-current-buffer (set-buffer (messages-buffer)) (save-excursion (progn (write-region nil nil (expand-file-name "file.txt")) (write-r (unwind-protect (progn (write-region nil nil (expand-file-name "file (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct (save-current-buffer (set-buffer eshell-buffer) (let* ((coding-syste (unwind-protect (save-current-buffer (set-buffer eshell-buffer) (let (let* ((process-environment (cons "HISTFILE" process-environment)) ( (progn (let* ((process-environment (cons "HISTFILE" process-environm (unwind-protect (progn (let* ((process-environment (cons "HISTFILE" (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct (save-current-buffer (let* ((coding-system-for-write nil) (temp-file (closure (t) nil (save-current-buffer (let* ((coding-system-for-writ #f(compiled-function () #)() handler-bind-1(#f(compiled-function () #) id 1rNcnl-0002yn-Q1 for submit@debbugs.gnu.org; Wed, 10 Jan 2024 12:55:42 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:36023) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNcnk-0002yb-N3 for 67661@debbugs.gnu.org; Wed, 10 Jan 2024 12:55:41 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id BCEEA5C01B6; Wed, 10 Jan 2024 12:55:36 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 10 Jan 2024 12:55:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm1; t=1704909336; x=1704995736; bh=kvYOubiptpE3P9z/jrD4n6nrfi7Tj6Us fH4e9YPBgxk=; b=D/UobyWsuDU3VZ7E6jv8WsTwX/7j9E/Q6b2ed7yrgsPKkgTo 7PhXaFFsLgm8l3oBYNm6YxuJw34uCRmM9/ZDInNHNmvlO7E9j1/+l8yhiazLUBSx /SqT1f5Ol5frsihBIXNYt+McEg66rMfH5g3zxLZsByGjaVd9/mc7be6e5rk+F5PY qPEksck2w8yIvRSrvBurU9ajsPKzYXolehqY7WPNdnEa5pgWik1Hv/WfefwUOher vJBe/gevCgOnxD2ERcJ9gyIbADPpkl4H9S4EYTjO3g7IY6ORcDdFep8C1TcnbdeS Z8aZSfCQ/i4CsOS2IPg6PM7zkvE7A/Vr7hFEVw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1704909336; x= 1704995736; bh=kvYOubiptpE3P9z/jrD4n6nrfi7Tj6UsfH4e9YPBgxk=; b=n 3O7iKod8zSnif7XZqKVLPidMLq1dMORykhMYGMTB3WtuOZFi6cHQe4N6RJ6DEvaE aS2AAJx3Bi6JMUZLTUp1lX7BTSpv3nOXlmSFeiafdd92+yZFG0vK/cNOMfRVeT1C 9ACpR/lTuwRtGJMUgQTcy7Dwy5lc0ZUVznQ2Z2YZSKmPR/G2pcgjpElj2VqzC19J 6MGj+hAcSQ5KVryCmYYHuNOju2i8/fwTrHCZzvBGSVw4Q1piGeYc8WfArtgUXj15 EOaoBVprLECybczSITq5Bg1eZ5CdjZ3Hm5O+x9lgMckSU9GCASJPa49mNDlfL3lo HhAfNbyqMWzywKdALQ0mQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeiuddguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtgfesthhqtddttderjeenucfhrhhomhepufgv rghnucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmh gvqeenucggtffrrghtthgvrhhnpefffefhjedugedutddukeejkeeuveevvdeigefhgeel teeuhfekgeekhfeljedvudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 10 Jan 2024 12:55:35 -0500 (EST) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 38EDC9474A7; Wed, 10 Jan 2024 17:55:34 +0000 (GMT) From: Sean Whitton To: Jim Porter Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer In-Reply-To: <87zfxdvq3t.fsf@pub.pink> (john muhl's message of "Tue, 09 Jan 2024 21:12:22 -0600") References: <87o7f3e4cb.fsf@melete.silentflame.com> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> <87le9pxivy.fsf@zephyr.silentflame.com> <87frzk294o.fsf@zephyr.silentflame.com> <87bka828jm.fsf@zephyr.silentflame.com> <87zfxdvq3t.fsf@pub.pink> Date: Wed, 10 Jan 2024 17:55:34 +0000 Message-ID: <871qapnkdl.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , john muhl , Eshel Yaron , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Tue 09 Jan 2024 at 09:12pm -06, john muhl wrote: > This commit (d7ff14fcba6) caused an eshell test to start > failing. It seems like the test was written to account for the > above mentioned bug in pcomplete but wasn=E2=80=99t sure. Attached is > the test output and the change in the test to fix it. > > > > --- a/test/lisp/eshell/em-cmpl-tests.el > +++ b/test/lisp/eshell/em-cmpl-tests.el > @@ -186,7 +186,7 @@ em-cmpl-test/file-completion/non-unique > (save-excursion > (goto-char (point-max)) > (forward-line -1) > - (should (looking-at "Complete, but not unique"))))))) > + (should (looking-at "Making completion list..."))))))) > > (ert-deftest em-cmpl-test/file-completion/glob () > "Test completion of file names using a glob." Jim, does this seem reasonable? --=20 Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 17 14:18:43 2024 Received: (at 67661) by debbugs.gnu.org; 17 Jan 2024 19:18:43 +0000 Received: from localhost ([127.0.0.1]:53526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rQBQw-0003u7-SF for submit@debbugs.gnu.org; Wed, 17 Jan 2024 14:18:43 -0500 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]:51415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rQBQv-0003ts-Dx for 67661@debbugs.gnu.org; Wed, 17 Jan 2024 14:18:41 -0500 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-6d9a79a1ad4so6218952b3a.2 for <67661@debbugs.gnu.org>; Wed, 17 Jan 2024 11:18:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705519114; x=1706123914; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=6AcaYyi6iclkjXFp1MSr4ZM7x/5w7Spc6yDugMHvCl0=; b=LJ9PS78YHM/lGvZvkNdImVpgMwCl6AQY36O+HcxTrsSKI+tU5dVjYGqCcgRpAOYiXv tevp7VkpH82xf76bvLgUyMSRFknRFcG81JxIdNPMIgO7seu6E6lfsHpxa3FvEmqcaysd gnuzcOPuA2IG9Uz8L5YzkzWW3KoYpIDhPV3hlsH2J8bGYeYTICrjEylycYofQ50jkgQF ObqoP5P08kZ6tgQ6KcnV3MNnN1ODg4oPNC3aQwDsYv/ggx6OKBAhyCUNZSoT9WByEWRF Jox5Z1tlPIQ79rXynrUvbOeqYZD6dFbuc08XKxcb24SNgedeQjNQcjfbKIgtY5H+mtCR fMCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705519114; x=1706123914; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6AcaYyi6iclkjXFp1MSr4ZM7x/5w7Spc6yDugMHvCl0=; b=uwpfQQfE6b809Si8XkGJPHNZUmZw7z5d5GvOylsB76zkBSlV26ud77RkV0UYdeEznQ lX9fFPFFxDl0TjSwKdaQtnuol+dnR0OaCRFn+2CaIddoSsF3lyhbBqCC63SBO2eMoaxo cgpDwTgHjKXYZVoylNv/9uSfeKGeZ6aEd2HQUQKHduGpT2PhMJow3ZWswnios+uf/3cM TsSFh/SeDVAdJfNnsBHODBoGXKRtsI9B8x3UYY14WmdkQbVRVVcIfVYiLX+lWpddUdIA uftLoCLS2n+oDYIfA4wb3v4w3yudjtIlrTis7f8/0VK77O9m6q3OaVJ+r62WqTFZe5lf zR8w== X-Gm-Message-State: AOJu0YzdMTbuFXvqy7PT2rqAe7If6402+96dvPz/GvE1cC7HfJDjgvyu y6moCN2e3BBG6JpqbVT5cTk= X-Google-Smtp-Source: AGHT+IGPDownS8tT800gncP/jQ8PycJiC6T4tNbqqL8vjWHq1ssxa4mKt80KL+qjDMVQ+xdjgzoGzQ== X-Received: by 2002:a05:6a21:18c:b0:19a:427c:5c4a with SMTP id le12-20020a056a21018c00b0019a427c5c4amr5801565pzb.22.1705519114083; Wed, 17 Jan 2024 11:18:34 -0800 (PST) Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id a14-20020aa7864e000000b006d93afd243asm1806151pfo.72.2024.01.17.11.18.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jan 2024 11:18:33 -0800 (PST) Message-ID: Date: Wed, 17 Jan 2024 11:18:32 -0800 MIME-Version: 1.0 Subject: Re: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer Content-Language: en-US To: Sean Whitton References: <87o7f3e4cb.fsf@melete.silentflame.com> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> <87le9pxivy.fsf@zephyr.silentflame.com> <87frzk294o.fsf@zephyr.silentflame.com> <87bka828jm.fsf@zephyr.silentflame.com> <87zfxdvq3t.fsf@pub.pink> <871qapnkdl.fsf@zephyr.silentflame.com> From: Jim Porter In-Reply-To: <871qapnkdl.fsf@zephyr.silentflame.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67661 Cc: 67661@debbugs.gnu.org, Eli Zaretskii , john muhl , Eshel Yaron , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 1/10/2024 9:55 AM, Sean Whitton wrote: >> --- a/test/lisp/eshell/em-cmpl-tests.el >> +++ b/test/lisp/eshell/em-cmpl-tests.el >> @@ -186,7 +186,7 @@ em-cmpl-test/file-completion/non-unique >> (save-excursion >> (goto-char (point-max)) >> (forward-line -1) >> - (should (looking-at "Complete, but not unique"))))))) >> + (should (looking-at "Making completion list..."))))))) >> >> (ert-deftest em-cmpl-test/file-completion/glob () >> "Test completion of file names using a glob." > > Jim, does this seem reasonable? Sorry, I missed this the first time around (I've got a lot of other stuff I'm trying to balance at the moment). I think this would fix the issue, but I've instead pushed 5f5faad2497 which solves this in a more-direct way by checking whether the *Completions* buffer is visible. That's what the test is really trying to test anyway. From unknown Mon Aug 18 11:16:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 15 Feb 2024 12:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator