GNU bug report logs - #67650
[PATCH] ; Hide completion preview when switching windows

Previous Next

Full log

Message #8 received at 67650 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Eshel Yaron <me <at> eshelyaron.com>
Cc: 67650 <at> debbugs.gnu.org
Subject: Re: bug#67650: [PATCH] ;
 Hide completion preview when switching windows
Date: Wed, 06 Dec 2023 14:04:54 +0200

> Date: Tue, 05 Dec 2023 21:26:27 +0100
> From:  Eshel Yaron via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> This patch ensures that we dismiss the completion preview when users
> switch to another window.  Previously, the completion preview would
> remain in a window after switching to another window showing another
> buffer, since the `post-command-hook` that Completion Preview mode sets
> up locally doesn't run after a command switches to another buffer.

Sorry, I don't understand: why does it matter whether
post-command-hook runs _after_ switching to another buffer?  When and
why would a command that caused post-command-hook invocation NOT need
to dismiss the preview?  If post-command-hook should always dismiss
the preview, then we shouldn't need another hook, right?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.