GNU bug report logs - #67624
[PATCH] gnu: ncdu: Use zig-build-system.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Hilton Chain <hako <at> ultrarare.space>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#67624: closed ([PATCH] gnu: ncdu: Use zig-build-system.)
Date: Sun, 10 Dec 2023 04:52:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 10 Dec 2023 12:08:08 +0800
with message-id <87plzek8d3.wl-hako <at> ultrarare.space>
and subject line Re: [bug#67624] [PATCH] gnu: ncdu: Use zig-build-system.
has caused the debbugs.gnu.org bug report #67624,
regarding [PATCH] gnu: ncdu: Use zig-build-system.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
67624: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67624
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: guix-patches <at> gnu.org
Cc: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: [PATCH] gnu: ncdu: Use zig-build-system.
Date: Mon,  4 Dec 2023 16:48:39 +0100

* gnu/packages/ncdu.scm(ncdu): Move to zig-build-system.
  [build-system]: Use zig-build-system.
  [phases]: Delegate phase manipulation to the build-system. Remove
  'validate-runpath as it fails (we should remove it in the build-system
  directly).
  [make-flags]: Remove them.
  [native-inputs]: Remove zig-0.10.

Change-Id: I9027a1cbd925cfb0c135740e81a33b62cb9d91ca
---
 gnu/packages/ncdu.scm | 24 ++++++------------------
 1 file changed, 6 insertions(+), 18 deletions(-)

diff --git a/gnu/packages/ncdu.scm b/gnu/packages/ncdu.scm
index 30460b404d..1e7598a7fd 100644
--- a/gnu/packages/ncdu.scm
+++ b/gnu/packages/ncdu.scm
@@ -27,8 +27,8 @@ (define-module (gnu packages ncdu)
   #:use-module (guix utils)
   #:use-module (guix gexp)
   #:use-module (guix build-system gnu)
-  #:use-module (gnu packages perl)
-  #:use-module (gnu packages zig))
+  #:use-module (guix build-system zig)
+  #:use-module (gnu packages perl))
 
 (define-public ncdu-1
   ;; This old version is ‘LTS’.  Version 2 works fine and has more features,
@@ -73,28 +73,16 @@ (define-public ncdu
                #~(begin
                    ;; Delete a pregenerated man page.  We'll build it ourselves.
                    (delete-file "ncdu.1")))))
+    (build-system zig-build-system)
     (arguments
      (list
-       #:make-flags
-       #~(list (string-append "PREFIX=" #$output)
-               (string-append "CC=" #$(cc-for-target))
-               (string-append "ZIG_FLAGS=-Drelease-fast"))
        #:phases
        #~(modify-phases %standard-phases
-           (delete 'configure)      ; No configure script.
-           (add-before 'build 'pre-build
-             (lambda _
-               (setenv "ZIG_GLOBAL_CACHE_DIR"
-                       (mkdtemp "/tmp/zig-cache-XXXXXX"))))
+           (delete 'validate-runpath)
            (add-after 'build 'build-manpage
              (lambda _
-               (invoke "make" "doc")))
-           (replace 'check
-             (lambda* (#:key tests? #:allow-other-keys)
-               (when tests?
-                 (invoke "zig" "test" "build.zig")))))))
-    (native-inputs
-     (list perl zig-0.10))
+               (invoke "make" "doc"))))))
+    (native-inputs (list perl))
     (properties `((tunable? . #t)))))
 
 (define-public ncdu-2

base-commit: 61cc93e49cdc35d3cc1b7f6018a2645628c5e892
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Hilton Chain <hako <at> ultrarare.space>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Cc: 67624-done <at> debbugs.gnu.org
Subject: Re: [bug#67624] [PATCH] gnu: ncdu: Use zig-build-system.
Date: Sun, 10 Dec 2023 12:08:08 +0800

Hi Ekaitz,

On Mon, 04 Dec 2023 23:48:39 +0800,
Ekaitz Zarraga wrote:
>
> * gnu/packages/ncdu.scm(ncdu): Move to zig-build-system.
>   [build-system]: Use zig-build-system.
>   [phases]: Delegate phase manipulation to the build-system. Remove
>   'validate-runpath as it fails (we should remove it in the build-system
>   directly).
>   [make-flags]: Remove them.
>   [native-inputs]: Remove zig-0.10.
>
> Change-Id: I9027a1cbd925cfb0c135740e81a33b62cb9d91ca
> ---
>  gnu/packages/ncdu.scm | 24 ++++++------------------
>  1 file changed, 6 insertions(+), 18 deletions(-)

I have adjusted commit message and applied the patch as
20223da2f21cb1a0879aaed4b915305d1f197522, thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.