GNU bug report logs - #67616
[PATCH] Fix: add comint hook locally in lua-ts-inferior-lua

Previous Next

Package: emacs;

Reported by: Noah Peart <noah.v.peart <at> gmail.com>

Date: Mon, 4 Dec 2023 03:28:02 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Noah Peart <noah.v.peart <at> gmail.com>
Subject: bug#67616: closed (Re: bug#67616: [PATCH] Fix: add comint hook
 locally in lua-ts-inferior-lua)
Date: Sat, 16 Dec 2023 09:40:01 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#67616: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 67616 <at> debbugs.gnu.org.

-- 
67616: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67616
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Eli Zaretskii <eliz <at> gnu.org>
To: john muhl <jm <at> pub.pink>
Cc: noah.v.peart <at> gmail.com, 67616-done <at> debbugs.gnu.org
Subject: Re: bug#67616: [PATCH] Fix: add comint hook locally in
 lua-ts-inferior-lua
Date: Sat, 16 Dec 2023 11:39:04 +0200
> Cc: 67616 <at> debbugs.gnu.org
> Date: Mon, 04 Dec 2023 12:17:27 -0600
> From:  john muhl via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Noah Peart <noah.v.peart <at> gmail.com> writes:
> 
> > Yea, that looks good to me.  Is it necessary to set
> > `comint-use-prompt-regexp` to `t`?
> > The behaviour of `comint-previous/next-prompt` seems better when
> > that is nil.
> > Thanks!
> 
> You’re right. I wasn’t able to get creative enough to merge them
> into a single commit so it’s separate.

Thanks, installed on the master branch, and closing the bug.

P.S. Please both of you see how I edited the commit log messages in
minor ways, and try to follow this in the future.

[Message part 3 (message/rfc822, inline)]
From: Noah Peart <noah.v.peart <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua
Date: Sun, 3 Dec 2023 19:26:54 -0800
[Message part 4 (text/plain, inline)]
Tags: patch


Bug: In `lua-ts-inferior-lua`, `comint-preoutput-filter-functions` hook
isn't added locally.


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2023-12-03 built on noah-X580VD
Repository revision: 9c1f24d7a497ee8b9c1ec3f1161a3ed7d6e34bd0
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.3 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'
[Message part 5 (text/html, inline)]
[lua-ts-inferior-hook.patch (text/x-patch, attachment)]

This bug report was last modified 1 year and 158 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.