Subject: bug#67616: closed (Re: bug#67616: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 16 Dec 2023 09:40:01 +0000

Your bug report

#67616: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
67616: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67616
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#67616: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua
From: Eli Zaretskii <[email-masked]>
To: john muhl <[email-masked]>
Cc: [email-masked], [email-masked]
Date: Sat, 16 Dec 2023 11:39:04 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

> Cc: [email-masked]
> Date: Mon, 04 Dec 2023 12:17:27 -0600
> From:  john muhl via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <[email-masked]>
> 
> Noah Peart <[email-masked]> writes:
> 
> > Yea, that looks good to me.  Is it necessary to set
> > `comint-use-prompt-regexp` to `t`?
> > The behaviour of `comint-previous/next-prompt` seems better when
> > that is nil.
> > Thanks!
> 
> You’re right. I wasn’t able to get creative enough to merge them
> into a single commit so it’s separate.

Thanks, installed on the master branch, and closing the bug.

P.S. Please both of you see how I edited the commit log messages in
minor ways, and try to follow this in the future.

Subject: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua
From: Noah Peart <[email-masked]>
To: [email-masked]
Date: Sun, 3 Dec 2023 19:26:54 -0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Tags: patch

Bug: In `lua-ts-inferior-lua`, `comint-preoutput-filter-functions` hook
isn't added locally.

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2023-12-03 built on noah-X580VD
Repository revision: 9c1f24d7a497ee8b9c1ec3f1161a3ed7d6e34bd0
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.3 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'
From f5a8ea39731c32755d6c3d76bbdf3d621a0f5388 Mon Sep 17 00:00:00 2001
From: nverno <[email-masked]>
Date: Sun, 3 Dec 2023 19:21:04 -0800
Subject: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua

* lisp/progmodes/lua-ts-mode.el(lua-ts-inferior-lua): Add
comint-preoutput-filter-functions hook locally.
---
 lisp/progmodes/lua-ts-mode.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el
index 7307a5b13f1..13b6faa2950 100644
--- a/lisp/progmodes/lua-ts-mode.el
+++ b/lisp/progmodes/lua-ts-mode.el
@@ -576,7 +576,8 @@ lua-ts-inferior-lua
                                                     (group (* nonl))))
                                                "\\1" string)
                      ;; Re-add the prompt for the next line.
-                     lua-ts-inferior-prompt " "))))))
+                     lua-ts-inferior-prompt " ")))
+                nil t)))
   (select-window (display-buffer lua-ts-inferior-buffer
                                  '((display-buffer-reuse-window
                                     display-buffer-pop-up-frame)
-- 
2.34.1