From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 03 22:27:34 2023 Received: (at submit) by debbugs.gnu.org; 4 Dec 2023 03:27:34 +0000 Received: from localhost ([127.0.0.1]:33242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9zcL-00045G-NE for submit@debbugs.gnu.org; Sun, 03 Dec 2023 22:27:34 -0500 Received: from lists.gnu.org ([2001:470:142::17]:34168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9zcH-00044x-V7 for submit@debbugs.gnu.org; Sun, 03 Dec 2023 22:27:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9zc2-0000h7-7c for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2023 22:27:14 -0500 Received: from mail-oa1-x31.google.com ([2001:4860:4864:20::31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r9zbv-0008BM-Mv for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2023 22:27:13 -0500 Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-1fb04fb8d28so1286205fac.3 for ; Sun, 03 Dec 2023 19:27:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701660426; x=1702265226; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=3M5JP36shaR/+9E2V5P6lTNK3+w8/wmiPAYl5yPd09U=; b=itGLWJTEuIBwgSxzt0VTpFDLr2sueHHJ7irOSXuHBUWu8lBc21gwiRjdlPYNBI1zOo YIK5j3nrq/WZT6jLngXTuDEAiXhVoPc6Jku2YU3M8OLw74vl+2XTMSZ5+EQugSdwdV8G e8Iz1vyKIEuPyl/uBYCJSKsgQr1nfaYn/OIrCH7uWL9xTNfyJxmVAP8ZWSOT1rJxReOS sfHUJPf3tVyoW7XG34yvh65YYXAPlAMAEcyZkUfLZ/yxtgk+IdiPZn8hpPNy9hBTwwAQ 9TF2yOyNUo2GOfeqahA8bLqA3uZA18KFv3V6a8x0Fi32TQNS6PUii88hI8yY3gjsY2Kp ICOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701660426; x=1702265226; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3M5JP36shaR/+9E2V5P6lTNK3+w8/wmiPAYl5yPd09U=; b=AwrG9nncqQas3X8uZMCie77UwFZwFmyza+JLoyLTC3DDPHlM1uTxhkwrYitvrx25SB 8s/f4Wh5BMDwYZdpM7EjBGdLNvI3rWqz0pTVQTQIZi8F8ILmd7zPV53veB0Y/Wcz1PHK REaUZfUPhRSJxmJbwLVAqHwGZd/tHt35c1KS83NUKY3CoNluwgy84Sv/sp7uxichxLKP Elmg6RvplhWMajq4iDhI5HL0YABQ2ChckSI6rXClVf1hnJrckeI+HuW2tT/z50Nx65x2 w8APe7AGHcnmEDJJ+hfaxwOMfcTzsNJu5hFwo8etiv5SgDTwiB1Dp2KSgqIgIS+GLhuz P5dw== X-Gm-Message-State: AOJu0YxwTZb9S/3e5QFaMxPH3Ft0Vwb1zVpauK1+tIpthXSOQueJoZnX P5bBVOjuyJMI+3xtSYsHeAcY5TzyQjI1/cZEGVuk0ZYz2iraxLcw X-Google-Smtp-Source: AGHT+IEF5UIvsLHx2E3CWgrMbuTphQWrOGMVQT1Cb0zj+a7cP/IHrsIUItFOHqULjSRSzBkn08BQrVYxT9guLX/W9z8= X-Received: by 2002:a05:6871:8789:b0:1fa:f68b:8b9c with SMTP id td9-20020a056871878900b001faf68b8b9cmr3816697oab.34.1701660425766; Sun, 03 Dec 2023 19:27:05 -0800 (PST) MIME-Version: 1.0 From: Noah Peart Date: Sun, 3 Dec 2023 19:26:54 -0800 Message-ID: Subject: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000356675060ba6b136" Received-SPF: pass client-ip=2001:4860:4864:20::31; envelope-from=noah.v.peart@gmail.com; helo=mail-oa1-x31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --000000000000356675060ba6b136 Content-Type: multipart/alternative; boundary="000000000000356673060ba6b134" --000000000000356673060ba6b134 Content-Type: text/plain; charset="UTF-8" Tags: patch Bug: In `lua-ts-inferior-lua`, `comint-preoutput-filter-functions` hook isn't added locally. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.16.0) of 2023-12-03 built on noah-X580VD Repository revision: 9c1f24d7a497ee8b9c1ec3f1161a3ed7d6e34bd0 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Ubuntu 22.04.3 LTS Configured using: 'configure --prefix=/usr/local --with-modules --with-tree-sitter --with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls --with-json --with-mailutils --with-jpeg --with-png --with-rsvg --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12 CXX=gcc-12' --000000000000356673060ba6b134 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Tags: patch


Bug: In `lua-ts-inferior-lua`, `com= int-preoutput-filter-functions` hook
isn't added locally.

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.3= 3, cairo version 1.16.0) of 2023-12-03 built on noah-X580VD
Repository r= evision: 9c1f24d7a497ee8b9c1ec3f1161a3ed7d6e34bd0
Repository branch: mas= ter
Windowing system distributor 'The X.Org Foundation', version= 11.0.12101004
System Description: Ubuntu 22.04.3 LTS

Configured = using:
=C2=A0'configure --prefix=3D/usr/local --with-modules --with-= tree-sitter
--with-threads --with-x-toolkit=3Dgtk3 --with-xwidgets --wit= h-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg=
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=3Dgcc-12
CX= X=3Dgcc-12'

--000000000000356673060ba6b134-- --000000000000356675060ba6b136 Content-Type: text/x-patch; charset="US-ASCII"; name="lua-ts-inferior-hook.patch" Content-Disposition: attachment; filename="lua-ts-inferior-hook.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lpqcnnou0 RnJvbSBmNWE4ZWEzOTczMWMzMjc1NWQ2YzNkNzZiYmRmM2Q2MjFhMGY1Mzg4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBudmVybm8gPG5vYWgudi5wZWFydEBnbWFpbC5jb20+CkRhdGU6 IFN1biwgMyBEZWMgMjAyMyAxOToyMTowNCAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeDogYWRk IGNvbWludCBob29rIGxvY2FsbHkgaW4gbHVhLXRzLWluZmVyaW9yLWx1YQoKKiBsaXNwL3Byb2dt b2Rlcy9sdWEtdHMtbW9kZS5lbChsdWEtdHMtaW5mZXJpb3ItbHVhKTogQWRkCmNvbWludC1wcmVv dXRwdXQtZmlsdGVyLWZ1bmN0aW9ucyBob29rIGxvY2FsbHkuCi0tLQogbGlzcC9wcm9nbW9kZXMv bHVhLXRzLW1vZGUuZWwgfCAzICsrLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwg MSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2x1YS10cy1tb2RlLmVs IGIvbGlzcC9wcm9nbW9kZXMvbHVhLXRzLW1vZGUuZWwKaW5kZXggNzMwN2E1YjEzZjEuLjEzYjZm YWEyOTUwIDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9sdWEtdHMtbW9kZS5lbAorKysgYi9s aXNwL3Byb2dtb2Rlcy9sdWEtdHMtbW9kZS5lbApAQCAtNTc2LDcgKzU3Niw4IEBAIGx1YS10cy1p bmZlcmlvci1sdWEKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAoZ3JvdXAgKCogbm9ubCkpKSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIlxcMSIgc3RyaW5nKQogICAgICAgICAgICAgICAgICAgICAgOzsg UmUtYWRkIHRoZSBwcm9tcHQgZm9yIHRoZSBuZXh0IGxpbmUuCi0gICAgICAgICAgICAgICAgICAg ICBsdWEtdHMtaW5mZXJpb3ItcHJvbXB0ICIgIikpKSkpKQorICAgICAgICAgICAgICAgICAgICAg bHVhLXRzLWluZmVyaW9yLXByb21wdCAiICIpKSkKKyAgICAgICAgICAgICAgICBuaWwgdCkpKQog ICAoc2VsZWN0LXdpbmRvdyAoZGlzcGxheS1idWZmZXIgbHVhLXRzLWluZmVyaW9yLWJ1ZmZlcgog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJygoZGlzcGxheS1idWZmZXItcmV1c2Ut d2luZG93CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkaXNwbGF5LWJ1ZmZl ci1wb3AtdXAtZnJhbWUpCi0tIAoyLjM0LjEKCg== --000000000000356675060ba6b136-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 03 23:30:51 2023 Received: (at 67616) by debbugs.gnu.org; 4 Dec 2023 04:30:51 +0000 Received: from localhost ([127.0.0.1]:33266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rA0bb-0005ix-Cm for submit@debbugs.gnu.org; Sun, 03 Dec 2023 23:30:51 -0500 Received: from out-171.mta0.migadu.com ([2001:41d0:1004:224b::ab]:52297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rA0bW-0005il-CY for 67616@debbugs.gnu.org; Sun, 03 Dec 2023 23:30:50 -0500 References: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; s=key1; t=1701664234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K7hQKME/GjNwX6/x/Jw1ZYQlsaTtG0UDje+kveOkLt4=; b=iRiZXa1axC7eSp3u+dp4nrtDzdIbdAKIzACFCHMAOCWYDU5uIRb57Q3CBkF/AXF+M0o+7z brO6X5Kb8KFbPB4hfpWAU+A4SELTR40omJEW+4JfNRHL5tj2xk+vowy2ur0Bv66K05WL4C /E/gRJcZIzfxppazFjryMCcaaI77+pk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: john muhl To: Noah Peart Subject: Re: bug#67616: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua Date: Sun, 03 Dec 2023 22:18:22 -0600 In-reply-to: Message-ID: <87wmtua8t6.fsf@pub.pink> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67616 Cc: 67616@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Noah Peart writes: > Tags: patch > > Bug: In `lua-ts-inferior-lua`, `comint-preoutput-filter-functions` hook > isn't added locally. Thanks. I think that obsoletes the buffer-name check at the beginning. A quick test looks that way to me. Could you give a try? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-add-comint-hook-locally-in-lua-ts-inferior-lua.patch >From 077258d0f95d6597108a5cab8b73833deba05339 Mon Sep 17 00:00:00 2001 From: nverno Date: Sun, 3 Dec 2023 19:21:04 -0800 Subject: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua * lisp/progmodes/lua-ts-mode.el (lua-ts-inferior-lua): Add comint-preoutput-filter-functions hook locally. --- lisp/progmodes/lua-ts-mode.el | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el index 7307a5b13f1..5318144a057 100644 --- a/lisp/progmodes/lua-ts-mode.el +++ b/lisp/progmodes/lua-ts-mode.el @@ -560,9 +560,7 @@ lua-ts-inferior-lua (comint-read-input-ring t) (add-hook 'comint-preoutput-filter-functions (lambda (string) - (if (or (not (equal (buffer-name) lua-ts-inferior-buffer)) - (equal string - (concat lua-ts-inferior-prompt-continue " "))) + (if (equal string (concat lua-ts-inferior-prompt-continue " ")) string (concat ;; Filter out the extra prompt characters that @@ -576,7 +574,8 @@ lua-ts-inferior-lua (group (* nonl)))) "\\1" string) ;; Re-add the prompt for the next line. - lua-ts-inferior-prompt " ")))))) + lua-ts-inferior-prompt " "))) + nil t))) (select-window (display-buffer lua-ts-inferior-buffer '((display-buffer-reuse-window display-buffer-pop-up-frame) -- 2.41.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 04 02:59:16 2023 Received: (at 67616) by debbugs.gnu.org; 4 Dec 2023 07:59:16 +0000 Received: from localhost ([127.0.0.1]:33421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rA3rI-00030W-0T for submit@debbugs.gnu.org; Mon, 04 Dec 2023 02:59:16 -0500 Received: from mail-oo1-xc34.google.com ([2607:f8b0:4864:20::c34]:55786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rA3rG-00030K-DR for 67616@debbugs.gnu.org; Mon, 04 Dec 2023 02:59:15 -0500 Received: by mail-oo1-xc34.google.com with SMTP id 006d021491bc7-58ceab7daddso1607567eaf.3 for <67616@debbugs.gnu.org>; Sun, 03 Dec 2023 23:59:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701676738; x=1702281538; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=b08YGPsdVbaw5xQI7rxNXRASjHjluDAUqLAzhT1HAho=; b=T2Vz4PaFWlpj3722+V9mAFiKVf6o7YX0xymWl0zv4mlQoUM/t4L5DPg0JNhIbYa8+w WnWEStC1UvmH9FwFQOqy64j1htgl+xWAQwYyiTyG6NPZ+YBxPJvp50Fp6i79JoQQgT8c qncMMVwBaY3QdFdPsb6ZvOESgRggpPqFR3IDH8TGsowiTrUHTYven3DnzzlzU/qMaVYD 0M6wV6xAKNI/K27Uyd/B6DD2TpmRxbik7zJWrMQFHGFKMeURoXWszUUPb3urAmrUCX0H ZaQVc6+K4kH4uHWZRXetD2BD08d9sQPulezwJOun9VHlCL6TVFa8QO4xYcp3qPrE7B4b v9Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701676738; x=1702281538; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b08YGPsdVbaw5xQI7rxNXRASjHjluDAUqLAzhT1HAho=; b=RJWQP7jWrzBnvJsO3mH7AT1inVkragqYCmtUtRueu8ObuxSEj0VxaW0O5r3iVEfedq 8X1byhinPNTvVsqx8Lu1wqJLL4IkFXSi/Q4zgH3AP5mCBVU6MkTsW1uXtWiHwDN6danH cGn2Tadsw3CZMDKje6k4ckKbCkjWVd9mlWSo2Z/zwIlE4Ed1v6dOvktPO+gs/8B0MWHT /piPPi0tlYPlPr1KLXI9JCN/Xs5m0L3IA8BfoBaGiE4Z1QPIPdSlNINiAxd85sXTZpyF 3aB7x3gJAeqX9BPWGDEWgWpV9bxEXZ0q3KkDZf/X8SFwytEERImXVNTtx8EXP97ANaYi Z7Kg== X-Gm-Message-State: AOJu0YyABLJAR4VHjtQucRTfuCqsQIvIAXCPCgGaPgNscMVHmQQI7JjX 0L78DglAlEkFWZmDvUfmiIw9cEB8sDXLlTd+u0Y= X-Google-Smtp-Source: AGHT+IE+hQmSMCRU8Y7TMk/461mUjDkkngu7uxusmKjvsRmIk99EZFfd3sqN/orc4POl7Kb0BAP7Q42cw13azpcFzBo= X-Received: by 2002:a05:6870:c8f:b0:1fb:21ed:83ca with SMTP id mn15-20020a0568700c8f00b001fb21ed83camr1108967oab.55.1701676738043; Sun, 03 Dec 2023 23:58:58 -0800 (PST) MIME-Version: 1.0 References: <87wmtua8t6.fsf@pub.pink> In-Reply-To: <87wmtua8t6.fsf@pub.pink> From: Noah Peart Date: Sun, 3 Dec 2023 23:58:46 -0800 Message-ID: Subject: Re: bug#67616: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua To: john muhl Content-Type: multipart/alternative; boundary="0000000000007e6182060baa7d66" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67616 Cc: 67616@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000007e6182060baa7d66 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yea, that looks good to me. Is it necessary to set `comint-use-prompt-regexp` to `t`? The behaviour of `comint-previous/next-prompt` seems better when that is nil. Thanks! On Sun, Dec 3, 2023 at 8:30=E2=80=AFPM john muhl wrote: > Noah Peart writes: > > > Tags: patch > > > > Bug: In `lua-ts-inferior-lua`, `comint-preoutput-filter-functions` hook > > isn't added locally. > > Thanks. I think that obsoletes the buffer-name check at the > beginning. A quick test looks that way to me. Could you give a try? > > --0000000000007e6182060baa7d66 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yea, that looks good to me.=C2=A0 Is it necessary to set `= comint-use-prompt-regexp` to `t`?
The behaviour of `comint-previous/nex= t-prompt` seems better when that is nil.
Thanks!

<= div class=3D"gmail_quote">
On Sun, Dec= 3, 2023 at 8:30=E2=80=AFPM john muhl <jm@pub.pink> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">Noah Peart <noah.v.peart@gmail.com= > writes:

> Tags: patch
>
> Bug: In `lua-ts-inferior-lua`, `comint-preoutput-filter-functions` hoo= k
> isn't added locally.

Thanks. I think that obsoletes the buffer-name check at the
beginning. A quick test looks that way to me. Could you give a try?

--0000000000007e6182060baa7d66-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 04 14:40:20 2023 Received: (at 67616) by debbugs.gnu.org; 4 Dec 2023 19:40:20 +0000 Received: from localhost ([127.0.0.1]:35761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAEnk-0000Ia-Bh for submit@debbugs.gnu.org; Mon, 04 Dec 2023 14:40:20 -0500 Received: from out-183.mta0.migadu.com ([2001:41d0:1004:224b::b7]:39692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAEng-0000IH-HE for 67616@debbugs.gnu.org; Mon, 04 Dec 2023 14:40:19 -0500 References: <87wmtua8t6.fsf@pub.pink> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; s=key1; t=1701718802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pl8aj4fZ/AFcdPH+HtmWZEeum7mSCLENUOw7aaFCsH8=; b=a6paMZAp91JanoWqmRcUWNWEATyYipQVVVvBlI0Vy9mX3LYu8lCYSwnClZxm36x9Mvoefz R8cX0ayLf4X9KOUymnH25tSPgytVhhJn2p+Ql0OgSe4jlRqdW+uQ1DwZPOaEfOW3gGxEkO 3RUYJU/AkVnMV8O25tmKzumFH/IfudA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: john muhl To: Noah Peart Subject: Re: bug#67616: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua Date: Mon, 04 Dec 2023 12:17:27 -0600 In-reply-to: Message-ID: <87r0k192pd.fsf@pub.pink> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67616 Cc: 67616@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Noah Peart writes: > Yea, that looks good to me. Is it necessary to set > `comint-use-prompt-regexp` to `t`? > The behaviour of `comint-previous/next-prompt` seems better when > that is nil. > Thanks! You=E2=80=99re right. I wasn=E2=80=99t able to get creative enough to merge= them into a single commit so it=E2=80=99s separate. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-add-comint-hook-locally-in-lua-ts-inferior-lua.patch >From a354925d561725b1df310ca036519c26fb7f081a Mon Sep 17 00:00:00 2001 From: nverno Date: Sun, 3 Dec 2023 19:21:04 -0800 Subject: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua * lisp/progmodes/lua-ts-mode.el (lua-ts-inferior-lua): Add comint-preoutput-filter-functions hook locally. (bug#67616) --- lisp/progmodes/lua-ts-mode.el | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el index 7307a5b13f1..5318144a057 100644 --- a/lisp/progmodes/lua-ts-mode.el +++ b/lisp/progmodes/lua-ts-mode.el @@ -560,9 +560,7 @@ lua-ts-inferior-lua (comint-read-input-ring t) (add-hook 'comint-preoutput-filter-functions (lambda (string) - (if (or (not (equal (buffer-name) lua-ts-inferior-buffer)) - (equal string - (concat lua-ts-inferior-prompt-continue " "))) + (if (equal string (concat lua-ts-inferior-prompt-continue " ")) string (concat ;; Filter out the extra prompt characters that @@ -576,7 +574,8 @@ lua-ts-inferior-lua (group (* nonl)))) "\\1" string) ;; Re-add the prompt for the next line. - lua-ts-inferior-prompt " ")))))) + lua-ts-inferior-prompt " "))) + nil t))) (select-window (display-buffer lua-ts-inferior-buffer '((display-buffer-reuse-window display-buffer-pop-up-frame) -- 2.41.0 --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-Fix-comint-next-previous-prompt-in-lua-ts-mode.patch Content-Transfer-Encoding: quoted-printable >From 939c0d0144551b664f03ea5ac9486c2f02f295e1 Mon Sep 17 00:00:00 2001 From: john muhl Date: Mon, 4 Dec 2023 12:03:34 -0600 Subject: [PATCH] Fix comint-next/previous-prompt in lua-ts-mode MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit * lisp/progmodes/lua-ts-mode.el (lua-ts-inferior-lua): Don=E2=80=99t set `comint-use-prompt-regexp'. (bug#67616) --- lisp/progmodes/lua-ts-mode.el | 1 - 1 file changed, 1 deletion(-) diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el index 5318144a057..cbf0e573e37 100644 --- a/lisp/progmodes/lua-ts-mode.el +++ b/lisp/progmodes/lua-ts-mode.el @@ -552,7 +552,6 @@ lua-ts-inferior-lua (with-current-buffer lua-ts-inferior-buffer (setq-local comint-input-ignoredups t comint-input-ring-file-name lua-ts-inferior-history - comint-use-prompt-regexp t comint-prompt-read-only t comint-prompt-regexp (rx-to-string `(: bol ,lua-ts-inferior-= prompt --=20 2.41.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 16 04:39:30 2023 Received: (at 67616-done) by debbugs.gnu.org; 16 Dec 2023 09:39:30 +0000 Received: from localhost ([127.0.0.1]:53974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rER8s-0001MI-7p for submit@debbugs.gnu.org; Sat, 16 Dec 2023 04:39:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rER8q-0001M6-Op for 67616-done@debbugs.gnu.org; Sat, 16 Dec 2023 04:39:29 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rER8k-0003yR-M5; Sat, 16 Dec 2023 04:39:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=TIjiajwtXQG8o6eGhlDoWyTV2mBzypp40d1kq4bMneE=; b=dKoHtm6bWPlAlApjarHh LWBXGSCnfAX2pcs7WBX6IJ/4WoC/vt6vMKxkdH6siqFEWp15g+y9lx/3VMuGX7Q9REkNnVsJ56iBH 9XtjJhHJPjCccjQl0gpJVMndBqCxm+vKvCyX3FAY9eK9Rjmi8atvtvENwPCXU8zWbdzVF2hPhuE9C yVlWivl3Qlt4ZCH7f8RfL3qDa1T4urZtFYaIOyk0pIKNO75rtWKsyOfVIVY8Y5ikSctKZ4kd8eBvD BO1KmeQ39LpT66+K8WHzQfRlOq1EoaGa6cB70LGG4EJzgqD4aG47idnI0Cv7eTTyrLxCICOnnO2KE OanbRLDGyBGNaQ==; Date: Sat, 16 Dec 2023 11:39:04 +0200 Message-Id: <83zfyamqpz.fsf@gnu.org> From: Eli Zaretskii To: john muhl In-Reply-To: <87r0k192pd.fsf@pub.pink> (bug-gnu-emacs@gnu.org) Subject: Re: bug#67616: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua References: <87wmtua8t6.fsf@pub.pink> <87r0k192pd.fsf@pub.pink> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67616-done Cc: noah.v.peart@gmail.com, 67616-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 67616@debbugs.gnu.org > Date: Mon, 04 Dec 2023 12:17:27 -0600 > From: john muhl via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Noah Peart writes: > > > Yea, that looks good to me. Is it necessary to set > > `comint-use-prompt-regexp` to `t`? > > The behaviour of `comint-previous/next-prompt` seems better when > > that is nil. > > Thanks! > > You’re right. I wasn’t able to get creative enough to merge them > into a single commit so it’s separate. Thanks, installed on the master branch, and closing the bug. P.S. Please both of you see how I edited the commit log messages in minor ways, and try to follow this in the future. From unknown Sat Jun 21 10:45:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 13 Jan 2024 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator