Subject: bug#67615: [PATCH v4] * lisp/info.el (Info-url-alist): New option mapping manuals to URLs.

From: Eli Zaretskii <[email-masked]>
Date: Sat, 23 Dec 2023 12:05:05 +0200

> From: Mekeor Melire <[email-masked]>
> Cc: Eli Zaretskii <[email-masked]>
> Date: Tue, 19 Dec 2023 23:08:29 +0000
> 
> Secondly, I'd like to re-share the same version of the patch from my
> last e-mail. Perhaps it was forgotten, perhaps because I did not choose
> a new subject line.

It wasn't forgotten, but thanks anyway.

I have a few minor comments to this version:

> +(defcustom Info-url-alist
> +  '((("auth" "autotype" "bovine" "calc" "ccmode" "cl" "dbus" "dired-x"
> +      "ebrowse" "ede" "ediff" "edt" "efaq" "efaq-w32" "eglot" "eieio"
> +      "eintr" "elisp" "emacs" "emacs-gnutls" "emacs-mime" "epa" "erc"
> +      "ert" "eshell" "eudc" "eww" "flymake" "forms" "gnus"
> +      "htmlfontify" "idlwave" "ido" "info" "mairix-el" "message"
> +      "mh-e" "modus-themes" "newsticker" "nxml-mode" "octave-mode"
> +      "org" "pcl-cvs" "pgg" "rcirc" "reftex" "remember" "sasl" "sc"
> +      "semantic" "ses" "sieve" "smtpmail" "speedbar" "srecode"
> +      "todo-mode" "tramp" "transient" "url" "use-package" "vhdl-mode"
> +      "vip" "viper" "vtable" "widget" "wisent" "woman") .
> +     "https://www.gnu.org/software/emacs/manual/html_node/%m/%e"))
> +  "Alist telling `Info-mode' where manuals are accessible online.
> +
> +Each element of this list should have the form (MANUALs
> +. URL-SPEC).  MANUALS represents the name of one or more manuals.

Please reformat/refill this so that "(MANUALs . URL-SPEC)" is not
broken between two lines.

> +  (if-let* ((manual (match-string 1 node))
> +             (node (match-string 2 node))
> +             (association (seq-find
> +                            (lambda (pair)
> +                              (seq-contains (ensure-list (car pair))
                                 ^^^^^^^^^^^^^
This triggers a byte-compiler warning:

  In Info-url-for-node:
  info.el:1868:32: Warning: `seq-contains' is an obsolete function (as of 27.1); use `seq-contains-p' instead.

> +    (error "No URL-specification associated with manual-name `%s'")))

And this line triggers the following byte-compiler warning:

  info.el:1896:6: Warning: `error' called with 0 args to fill 1 format field(s)