GNU bug report logs - #6761
23.2; flyspell-prog-mode in TeX mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6761 in the body.
You can then email your comments to 6761 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.2; flyspell-prog-mode in TeX mode
Date: Fri, 30 Jul 2010 06:26:00 +0100

When flyspell-prog-mode is turned on a TeX buffer, anything that has a
trailing % will be checked, for example

  bookmarksnumbered%

This is incorrect as the word is neither doc string nor comment. I run
into this bug fairly often in LaTeX class and style files.

Leo

Message #8 received at 6761 <at> debbugs.gnu.org (full text, mbox):

From: Agustin Martin <agustin.martin <at> hispalinux.es>
To: Leo <sdl.web <at> gmail.com>, 6761 <at> debbugs.gnu.org
Subject: Re: bug#6761: 23.2; flyspell-prog-mode in TeX mode
Date: Fri, 12 Nov 2010 17:59:14 +0100

[Message part 1 (text/plain, inline)]

On Fri, Jul 30, 2010 at 06:26:00AM +0100, Leo wrote:
> When flyspell-prog-mode is turned on a TeX buffer, anything that has a
> trailing % will be checked, for example
> 
>   bookmarksnumbered%
> 
> This is incorrect as the word is neither doc string nor comment. I run
> into this bug fairly often in LaTeX class and style files.

I finally had time to look at this and seems I found the problem.
flyspell-prog-mode just checks that face is not one of the faces selected as
text faces, but does that in the char right after the word, so in

auto%

checks face in the % char getting font-lock-comment-face instead of nil as
should be for a not-to-be-checked word.

I am playing with attached patch that tries to make sure that check is done 
in the final character of the word, not in the next char outside it.

Will test a bit more and commit if no problems are found.

Thanks for your feedback,

-- 
Agustin

[flyspell-prog-mode.0.diff (text/x-diff, attachment)]

Message #13 received at 6761-done <at> debbugs.gnu.org (full text, mbox):

From: Agustin Martin <agustin.martin <at> hispalinux.es>
To: Leo <sdl.web <at> gmail.com>, 6761-done <at> debbugs.gnu.org
Subject: Re: bug#6761: 23.2; flyspell-prog-mode in TeX mode
Date: Mon, 15 Nov 2010 14:28:06 +0100

On Fri, Nov 12, 2010 at 05:59:14PM +0100, Agustin Martin wrote:
> On Fri, Jul 30, 2010 at 06:26:00AM +0100, Leo wrote:
> > When flyspell-prog-mode is turned on a TeX buffer, anything that has a
> > trailing % will be checked, for example
> > 
> >   bookmarksnumbered%
> > 
> > This is incorrect as the word is neither doc string nor comment. I run
> > into this bug fairly often in LaTeX class and style files.
> 
> I finally had time to look at this and seems I found the problem.
> flyspell-prog-mode just checks that face is not one of the faces selected as
> text faces, but does that in the char right after the word, so in
> 
> auto%
> 
> checks face in the % char getting font-lock-comment-face instead of nil as
> should be for a not-to-be-checked word.

Committed a change that should fix this, so closing this bug report. 
Just made sure that (flyspell-prog-mode) checks inside the word.

-- 
Agustin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.