GNU bug report logs - #67600
[PATCH] Add dashes to 'thing-at-point-email-regexp'

Previous Next

Package: emacs;

Reported by: Philip Kaludercic <philipk <at> posteo.net>

Date: Sun, 3 Dec 2023 12:53:02 UTC

Severity: normal

Tags: patch

Done: Philip Kaludercic <philipk <at> posteo.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Philip Kaludercic <philipk <at> posteo.net>
Subject: bug#67600: closed (Re: bug#67600: [PATCH] Add dashes to
 'thing-at-point-email-regexp')
Date: Sun, 17 Dec 2023 12:12:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#67600: [PATCH] Add dashes to 'thing-at-point-email-regexp'

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 67600 <at> debbugs.gnu.org.

-- 
67600: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67600
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 67600-done <at> debbugs.gnu.org
Subject: Re: bug#67600: [PATCH] Add dashes to 'thing-at-point-email-regexp'
Date: Sun, 17 Dec 2023 12:11:26 +0000
Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Philip Kaludercic <philipk <at> posteo.net>
>> Cc: 67600 <at> debbugs.gnu.org
>> Date: Sat, 16 Dec 2023 14:50:27 +0000
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> > Can you show a patch, so we could make sure we are on the same page?
>> 
>> Never mind, I misremembered my own patch, this is already what I am
>> proposing.
>> 
>> -  "<?[-+_~a-zA-Z0-9][-+_.~:a-zA-Z0-9]*@[-a-zA-Z0-9]+[-.a-zA-Z0-9]*>?"
>> +  "<?[-+_~a-zA-Z0-9/][-+_.~:a-zA-Z0-9/]*@[-a-zA-Z0-9]+[-.a-zA-Z0-9]*>?"
>> 
>> I had falsely assumed that my suggestion was to apply this change
>> 
>> -  "<?[-+_~a-zA-Z0-9][-+_.~:a-zA-Z0-9]*@[-a-zA-Z0-9/]+[-.a-zA-Z0-9/]*>?"
>> +  "<?[-+_~a-zA-Z0-9/][-+_.~:a-zA-Z0-9/]*@[-a-zA-Z0-9/]+[-.a-zA-Z0-9/]*>?"
>> 
>> Which would risk more false positives.
>
> Thanks.
>
> If you think the patch is safe enough, feel free to install.  If there
> are problems with it, I guess we will hear about them sooner or later.

OK thanks, done.

-- 
Philip Kaludercic

[Message part 3 (message/rfc822, inline)]
From: Philip Kaludercic <philipk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add dashes to 'thing-at-point-email-regexp'
Date: Sun, 03 Dec 2023 12:52:04 +0000
[Message part 4 (text/plain, inline)]
Tags: patch


I noticed this recently when trying to extract a link to an mailing list
of mine hosted on SourceHut.

In GNU Emacs 30.0.50 (build 3, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.16.0, Xaw scroll bars) of 2023-11-25 built on icterid
Repository revision: 78eb99c72c6834a9161fc4e3f3cef3fc6bdffefd
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101007
System Description: Debian GNU/Linux 12 (bookworm)

Configured using:
 'configure --with-imagemagick --with-x-toolkit=lucid
 --with-native-compilation=aot --with-tree-sitter 'CFLAGS=-O2
 -march=native -mtune=native -pipe''

[0001-Add-dashes-to-thing-at-point-email-regexp.patch (text/patch, attachment)]
[Message part 6 (text/plain, inline)]
-- 
Philip Kaludercic

This bug report was last modified 1 year and 157 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.