From unknown Fri Jun 20 19:48:58 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#67600 <67600@debbugs.gnu.org> To: bug#67600 <67600@debbugs.gnu.org> Subject: Status: [PATCH] Add dashes to 'thing-at-point-email-regexp' Reply-To: bug#67600 <67600@debbugs.gnu.org> Date: Sat, 21 Jun 2025 02:48:58 +0000 retitle 67600 [PATCH] Add dashes to 'thing-at-point-email-regexp' reassign 67600 emacs submitter 67600 Philip Kaludercic severity 67600 normal tag 67600 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 03 07:52:35 2023 Received: (at submit) by debbugs.gnu.org; 3 Dec 2023 12:52:35 +0000 Received: from localhost ([127.0.0.1]:59220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9lxa-0007nZ-Qv for submit@debbugs.gnu.org; Sun, 03 Dec 2023 07:52:35 -0500 Received: from lists.gnu.org ([2001:470:142::17]:36288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9lxY-0007nF-7R for submit@debbugs.gnu.org; Sun, 03 Dec 2023 07:52:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9lxD-0008NK-JE for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2023 07:52:12 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9lxB-0000CX-Em for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2023 07:52:11 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 7C336240028 for ; Sun, 3 Dec 2023 13:52:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1701607925; bh=AMNBe9zwKBdfzsJMao6E1wm3uoSQ6LaPIRuoMQWmEBg=; h=From:To:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=r4tnY/hF1jrgYBbH3UPO+BP8cPXwmWMd5vU71FyhiZ0F/ps1doyshDGvY00oMlk37 UaI3dSAa8BUnt+VQ0vHNthfoziWE/8Ej9lHXdgP5woDwCXS22qnEUVc4UfFtsXSPOW a6AdsrY3DO1Y71gz7l1lwrG19v5oJeZLtKImUHHcwWiEYHlb0Cr0WDl1n8k2YnOaYa gF7shMP1FgYDWdZpEPD3BSSHxh4FUi2K9iqha9iAq2Z9OmQU2E96rxIlXc1F06b6NM uAnxtcRlnGzd96XxfnVATwPjhXkpjDWIGm97BIWW4W6t+TYlkLaWAcHlGVaKphk4mh utXWyXQD7wy4Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SjmsJ6TSpz6twQ for ; Sun, 3 Dec 2023 13:52:04 +0100 (CET) From: Philip Kaludercic To: bug-gnu-emacs@gnu.org Subject: [PATCH] Add dashes to 'thing-at-point-email-regexp' X-Hashcash: 1:20:231203:bug-gnu-emacs@gnu.org::77mbEpjCPC/yelyp:0RUJ Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sun, 03 Dec 2023 12:52:04 +0000 Message-ID: <87v89fh2iz.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Tags: patch I noticed this recently when trying to extract a link to an mailing list of mine hosted on SourceHut. In GNU Emacs 30.0.50 (build 3, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw scroll bars) of 2023-11-25 built on icterid Repository revision: 78eb99c72c6834a9161fc4e3f3cef3fc6bdffefd Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101007 System Description: Debian GNU/Linux 12 (bookworm) Configured using: 'configure --with-imagemagick --with-x-toolkit=lucid --with-native-compilation=aot --with-tree-sitter 'CFLAGS=-O2 -march=native -mtune=native -pipe'' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Add-dashes-to-thing-at-point-email-regexp.patch >From 1caf9c71b7b0ad4a31a9318932b242f7a46183f5 Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Sun, 3 Dec 2023 13:49:07 +0100 Subject: [PATCH] Add dashes to 'thing-at-point-email-regexp' * lisp/thingatpt.el (thing-at-point-email-regexp): Allow for a (thing-at-point 'email) query to match addresses with dashes, as used by Sourcehut. --- lisp/thingatpt.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el index 88efbf73beb..80dc5ee60b7 100644 --- a/lisp/thingatpt.el +++ b/lisp/thingatpt.el @@ -652,7 +652,7 @@ thing-at-point-looking-at ;; Email addresses (defvar thing-at-point-email-regexp - "?" + "?" "A regular expression probably matching an email address. This does not match the real name portion, only the address, optionally with angle brackets.") -- 2.39.2 --=-=-= Content-Type: text/plain -- Philip Kaludercic --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 03 08:15:01 2023 Received: (at 67600) by debbugs.gnu.org; 3 Dec 2023 13:15:01 +0000 Received: from localhost ([127.0.0.1]:59246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9mJJ-0008M6-8J for submit@debbugs.gnu.org; Sun, 03 Dec 2023 08:15:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9mJH-0008Lr-Ay for 67600@debbugs.gnu.org; Sun, 03 Dec 2023 08:15:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9mJ1-00020q-Fs; Sun, 03 Dec 2023 08:14:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UdVXM5Ydu3gl0s+yKBH6WPw3gCRw2CMvNyiR6FgA3LA=; b=rawmvT3DihyN SVMG5dctT5iPGxnaBJFT0ovxvJKhGBx69tnft0pXMhurXuI61PKGj0hz1ceAAvEVL9wT9zzh4Nm+o hEEWtA9QUFOPkzaRU9h9O8vNtRFJBDLVgebIes67zKoLwgzvv04IBtspYgurDBUA9C6Kxzq4seusY HI1UjtXFkwq01FuQxF1Br5ersDWah2sdmJu3E8Enmb5AkD+yada3+g2ErY/b3O8jkM4USHPuzeLFl t0RC+CUpowG5PNC3EGHZMmMpxHuFBa3pZ6lcfyDredhoJEyDz/hKIDwhqBljvj019T4blZtnUgKyK sPCLqStOk0qXSlWPtSuSWA==; Date: Sun, 03 Dec 2023 15:14:45 +0200 Message-Id: <83plzn77i2.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87v89fh2iz.fsf@posteo.net> (message from Philip Kaludercic on Sun, 03 Dec 2023 12:52:04 +0000) Subject: Re: bug#67600: [PATCH] Add dashes to 'thing-at-point-email-regexp' References: <87v89fh2iz.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67600 Cc: 67600@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Date: Sun, 03 Dec 2023 12:52:04 +0000 > > I noticed this recently when trying to extract a link to an mailing list > of mine hosted on SourceHut. Looks like you are adding slashes, not dashes? From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 12 02:21:48 2023 Received: (at 67600) by debbugs.gnu.org; 12 Dec 2023 07:21:48 +0000 Received: from localhost ([127.0.0.1]:55162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCx5P-00064c-MA for submit@debbugs.gnu.org; Tue, 12 Dec 2023 02:21:48 -0500 Received: from mout01.posteo.de ([185.67.36.65]:59875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCx5J-00064K-Tk for 67600@debbugs.gnu.org; Tue, 12 Dec 2023 02:21:45 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 7E75D240027 for <67600@debbugs.gnu.org>; Tue, 12 Dec 2023 08:21:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1702365680; bh=4ripH3LM+UdPjVTSqTxxujenIaESpI7GxEC0+va04Z8=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=cxaDPm0meDEFFe7BrX+4U7pJfUQFWMHyau9I9cp2yyGhWsTncr3wcHYFk1nPbRLko uFEEllTiKLPm28UKr67lT3IhfRp8PshzyIE2ZtdVdJ7VZA4Y1EudrKxM+Xks4Uhmsx Z9B63ePXsd+Z1z+nyKggGjfC0PDP6zfORbliRQWEUSUqqkWQQGDhhZ0tlUad+14sbr aDFNuqWAKwG9MUHUSarMrFt+ZqM0ceqgyJhy/hb2kGgEp2dk0UP/lE9LH0RGtaXMI8 OgFAuXRfSTHGtc7Isq/vXJODxiN4WsAlvMlrHPdfgk2vq8xSupDLoG2rGVRzhtueYl cs00uwESNmSmg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Sq95W5RQSz6tw4; Tue, 12 Dec 2023 08:21:19 +0100 (CET) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#67600: [PATCH] Add dashes to 'thing-at-point-email-regexp' In-Reply-To: <83plzn77i2.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 03 Dec 2023 15:14:45 +0200") References: <87v89fh2iz.fsf@posteo.net> <83plzn77i2.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Tue, 12 Dec 2023 07:21:18 +0000 Message-ID: <87wmtjnaxd.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67600 Cc: 67600@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Philip Kaludercic >> Date: Sun, 03 Dec 2023 12:52:04 +0000 >> >> I noticed this recently when trying to extract a link to an mailing list >> of mine hosted on SourceHut. > > Looks like you are adding slashes, not dashes? Of course, my bad: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Add-slashes-to-thing-at-point-email-regexp.patch >From ee60512a4fa5fc33e1439c680505127828708d12 Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Sun, 3 Dec 2023 13:49:07 +0100 Subject: [PATCH] Add slashes to 'thing-at-point-email-regexp' * lisp/thingatpt.el (thing-at-point-email-regexp): Allow for a (thing-at-point 'email) query to match addresses with slashes, as used by Sourcehut. --- lisp/thingatpt.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el index 88efbf73beb..80dc5ee60b7 100644 --- a/lisp/thingatpt.el +++ b/lisp/thingatpt.el @@ -652,7 +652,7 @@ thing-at-point-looking-at ;; Email addresses (defvar thing-at-point-email-regexp - "?" + "?" "A regular expression probably matching an email address. This does not match the real name portion, only the address, optionally with angle brackets.") -- 2.39.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 12 07:06:45 2023 Received: (at 67600) by debbugs.gnu.org; 12 Dec 2023 12:06:45 +0000 Received: from localhost ([127.0.0.1]:55433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rD1XA-00086L-Ns for submit@debbugs.gnu.org; Tue, 12 Dec 2023 07:06:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rD1X9-000863-80 for 67600@debbugs.gnu.org; Tue, 12 Dec 2023 07:06:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rD1Wn-0003Im-EF; Tue, 12 Dec 2023 07:06:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CvfxKq25BbhZ0ZARVsrwcBimREvb8prk8YIUK6RxYNY=; b=bEmNOsNk2dUy w8oJqNMGU2jt1TaU41QhX9BqOO6g8tCkn47icMAg5lnsqzA5uaGi31qVDkWiyKq0xZq1uYXccEOsd MwJIMigWKgjUquBWRKPp9NNt9bKeD1b3GCOr2WwzILmJhpOph8PPV5S6maZmK4d4PqKOUOWb+iXT4 rOX24jCtQ6AJHaL80c3nriPAV4wx4OQMYgDwba8qV7kSGinracKmInH3NmXa4RSFeq3vSf/VJTE3U tDZM2BXHhGhbG2ZSgIyAPXKqZcRtcZPg4/H/Qc92Koh6WHHWsPjcGMednbtf8MeWDHv6irtTbakAc 4nBBPryymZllI1qTNuVGYg==; Date: Tue, 12 Dec 2023 14:06:03 +0200 Message-Id: <831qbrvd5g.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87wmtjnaxd.fsf@posteo.net> (message from Philip Kaludercic on Tue, 12 Dec 2023 07:21:18 +0000) Subject: Re: bug#67600: [PATCH] Add dashes to 'thing-at-point-email-regexp' References: <87v89fh2iz.fsf@posteo.net> <83plzn77i2.fsf@gnu.org> <87wmtjnaxd.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67600 Cc: 67600@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: 67600@debbugs.gnu.org > Date: Tue, 12 Dec 2023 07:21:18 +0000 > > Eli Zaretskii writes: > > >> From: Philip Kaludercic > >> Date: Sun, 03 Dec 2023 12:52:04 +0000 > >> > >> I noticed this recently when trying to extract a link to an mailing list > >> of mine hosted on SourceHut. > > > > Looks like you are adding slashes, not dashes? > > Of course, my bad: Thanks. My bother here is that this could cause false positives whereby thing-at-point would recognize file names with slashes as email addresses. Because otherwise I don't understand why the slash was omitted in the first place. Can we somehow make sure this won't happen? From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 12 07:21:59 2023 Received: (at 67600) by debbugs.gnu.org; 12 Dec 2023 12:22:00 +0000 Received: from localhost ([127.0.0.1]:55477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rD1lv-00009J-Fb for submit@debbugs.gnu.org; Tue, 12 Dec 2023 07:21:59 -0500 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]:47257) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rD1lt-000094-4G for 67600@debbugs.gnu.org; Tue, 12 Dec 2023 07:21:57 -0500 Received: by mail-pj1-x1044.google.com with SMTP id 98e67ed59e1d1-28ab4348bbcso568275a91.2 for <67600@debbugs.gnu.org>; Tue, 12 Dec 2023 04:21:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702383696; x=1702988496; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=9WUy764simr39SMv8NX8iOXmQx1DqY83doRcYEQD5N4=; b=OvTvRM7u0Es538diYniCHtxaFH2WvArlihV3AGaBbHqkLKlVePcFZzZWc8/5YyN5AV 4ml6Tws1MjGHwHb0k2ihM5BNBk9RDlq+70y8465tNHBcHTIhjQXcDs01E7+PAM//oKnD O3jra2Jsphba7vsoxpO5WjG+h2d+C52M7F98qa2QJ/2EPuxDTNMHFtcLG5cE3VDqNERF Wsmt6D84gVyfwp4HCZymDlaa63zl08L6SE4M/ss0jiVgJEvswP+LgVwrhDBSVgJpOUDh bh9Gy8+LGkRedd3QcOZ1H1TdILsBmDb5oHqIESJnwsdM86na3g+o47jylLxmmIHvtdx3 SLYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702383696; x=1702988496; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9WUy764simr39SMv8NX8iOXmQx1DqY83doRcYEQD5N4=; b=Kjl+wOl80HGRqQiMc/Y2mRY76QA7Mztj0FQqI3LyzBxc7qkpXM3YHJv2+EpsfmYhTs jIQHKtDk2Gm2nFaW8tDuP7EUPBeNZuA+Zig8AP6i43CV306qy8IvDaIqHKGNhQ8mHb+r E7+JksrYH3dqKgC26AWBN8Refes2znyvdH9rPXVs4SiLbmmRqFldmKOlPS0E1N61CBx7 PiDI1hHRoCQrT+7MVkj2om6uxZJfLEH7eSHhrG0AbmNh+R01k8hbWZYqS54Qm6Vn8OTN uoqnBet1iVR5V9Nl6JmMa0doAdtPdX+uM7CREI4SBWbjhrujBZyuUjA2atMMedGKI157 pCtA== X-Gm-Message-State: AOJu0YwDoCifG6rTa7tI/6zS0gmwJkEq1Ia5LMo0X8kZ8Ofg22zdm/No IevZhok2oGFbnfRwZExfcEo= X-Google-Smtp-Source: AGHT+IFmrxbwQlq/iWnDwqkw1ejWO3OmY5HhDqMqgpa5/cohdDCvaysGXY02sNwcfN0lkVcSXewznw== X-Received: by 2002:a17:90a:e645:b0:286:6cc0:b920 with SMTP id ep5-20020a17090ae64500b002866cc0b920mr2306472pjb.87.1702383695927; Tue, 12 Dec 2023 04:21:35 -0800 (PST) Received: from localhost ([49.204.128.180]) by smtp.gmail.com with ESMTPSA id y24-20020a17090aa41800b00287731b0ceasm1222683pjp.13.2023.12.12.04.21.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 04:21:35 -0800 (PST) From: Visuwesh To: Eli Zaretskii Subject: Re: bug#67600: [PATCH] Add dashes to 'thing-at-point-email-regexp' In-Reply-To: <831qbrvd5g.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 12 Dec 2023 14:06:03 +0200") References: <87v89fh2iz.fsf@posteo.net> <83plzn77i2.fsf@gnu.org> <87wmtjnaxd.fsf@posteo.net> <831qbrvd5g.fsf@gnu.org> Date: Tue, 12 Dec 2023 17:51:32 +0530 Message-ID: <87il53txv7.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67600 Cc: Philip Kaludercic , 67600@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [Tuesday December 12, 2023] Eli Zaretskii wrote: > Thanks. > > My bother here is that this could cause false positives whereby > thing-at-point would recognize file names with slashes as email > addresses. Because otherwise I don't understand why the slash was > omitted in the first place. Can we somehow make sure this won't > happen? I am running Emacs with the same change before Philip created this bug report and so far I haven't had false positives for email addresses because files with a @ in its name is rare. In practise, I think this patch is harmless in that regard. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 12 07:27:43 2023 Received: (at 67600) by debbugs.gnu.org; 12 Dec 2023 12:27:43 +0000 Received: from localhost ([127.0.0.1]:55492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rD1rT-0000JI-4Z for submit@debbugs.gnu.org; Tue, 12 Dec 2023 07:27:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rD1rR-0000J4-MB for 67600@debbugs.gnu.org; Tue, 12 Dec 2023 07:27:42 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rD1r6-0005Bg-Rk; Tue, 12 Dec 2023 07:27:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=nyjBLLecwkXXHwsgSjwH5sHL6Jlhj8DERCHldGXWIGs=; b=dgmSlyXP2n56 GAHyGzRUrz3IMQL+4wT3XOFTlhGrOvIz1qQWsM33V3dod3y7Nxi4IcH8ch9c5gz5weaMGVo9lEr9R FCelWQkG6X/v05nMRj1GDZK4kZcPi03IWSq320GRcGzBF593kMHLgXBK0zjSJ1WtX+62zD+F3V3/Z bqQXmGFH0vah6Br5xvBH/JPoWPn8HMfBu3eYQrXoIUsnxshgxMxhcZVJ2n6Y0nUSoB1MdVwz6e8Kz AWwYj9letn57Qhh1pa74CMEGEk1HIuMmocxWWaehJSTRwUWAO0FFPHU+p1OcV503c5U04On34oRpF wyElVsqpAed0IWUqfmCqYA==; Date: Tue, 12 Dec 2023 14:27:13 +0200 Message-Id: <83y1dztxlq.fsf@gnu.org> From: Eli Zaretskii To: Visuwesh In-Reply-To: <87il53txv7.fsf@gmail.com> (message from Visuwesh on Tue, 12 Dec 2023 17:51:32 +0530) Subject: Re: bug#67600: [PATCH] Add dashes to 'thing-at-point-email-regexp' References: <87v89fh2iz.fsf@posteo.net> <83plzn77i2.fsf@gnu.org> <87wmtjnaxd.fsf@posteo.net> <831qbrvd5g.fsf@gnu.org> <87il53txv7.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67600 Cc: philipk@posteo.net, 67600@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Visuwesh > Cc: Philip Kaludercic , 67600@debbugs.gnu.org > Date: Tue, 12 Dec 2023 17:51:32 +0530 > > [Tuesday December 12, 2023] Eli Zaretskii wrote: > > > Thanks. > > > > My bother here is that this could cause false positives whereby > > thing-at-point would recognize file names with slashes as email > > addresses. Because otherwise I don't understand why the slash was > > omitted in the first place. Can we somehow make sure this won't > > happen? > > I am running Emacs with the same change before Philip created this bug > report and so far I haven't had false positives for email addresses > because files with a @ in its name is rare. In practise, I think this > patch is harmless in that regard. Remote files that have user@host in their names do have that character. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 12 07:42:14 2023 Received: (at 67600) by debbugs.gnu.org; 12 Dec 2023 12:42:14 +0000 Received: from localhost ([127.0.0.1]:55510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rD25W-0003MR-97 for submit@debbugs.gnu.org; Tue, 12 Dec 2023 07:42:14 -0500 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]:52404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rD25U-0003MB-7g for 67600@debbugs.gnu.org; Tue, 12 Dec 2023 07:42:12 -0500 Received: by mail-pj1-x1044.google.com with SMTP id 98e67ed59e1d1-28ad2f0b278so60422a91.0 for <67600@debbugs.gnu.org>; Tue, 12 Dec 2023 04:41:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702384911; x=1702989711; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=4M2rnyt66YloFj7q4q0d5E9IBH+Hh3DdBe4I1ov2q+E=; b=E50ir/+7plKvs8c3onY+cUiv/7DeCdTq4HGyLkWHf5hABqdtk9cSoYzawUaLJf7+cq u933tvhXOv3jcmEv8FmjckIuVz9pGsGd/GpH/zt7XjFQBA4guqYeEDpvNsiCRSBpjkbr Pj2IRQgvsETZFFLYRWpbT+kdsv3oqduUWcKXvMldI6zWhDSUQmetMIphS5O1CoAL9fXd QHHKB1nfO004eDwzi4ERTa1qncK1APtXE7zsmrHqQP5rqtzYdFCqoKJjijT/QnmziDd5 27CXKOWtCWAkSw42gcARXJn09fUuQYCGNlf+sl7CAWsp0JiVv0NLyt/L4BasDXMjyyWq iMiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702384911; x=1702989711; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4M2rnyt66YloFj7q4q0d5E9IBH+Hh3DdBe4I1ov2q+E=; b=bnNG747uL9rOpQFSIFVHwTS0hoaYMSZgkBV8OsFPGk6jLz7PrHa5QvNJPbgEwA1i4p N/PgcfLZCx7aQU4ppyddD75iS4c9bQd/H8x15MtxGrEMzy36AA+L9hwoqKvi6Anw2RHd 42pzBMnxlSBB+tFlVGa7MfelSWDFJ1Bvlc8dPCxwSR7QxEvRdrhqbxTvRlBspH4oilwz B+y7gasRYF35Dyb8UdSjBIoh0gLuItCRAkGj3MK2XVFrmhxicE6Va5M1g+z6fvJE0Ja4 WuArnmArArC6aDykDdcejJAUqqd4wh6XuN4x2nB5FG+maLmPrvgE3UHjfAfd0UcwwE9d MHyA== X-Gm-Message-State: AOJu0YwSgLmarygOez9zMetlGi81t7Q5Vmzta2QhNW80ZlVu61GUU8Bp mrTLUIgy6GoskhkqAKBkZ7JIUwT5LPeIQA== X-Google-Smtp-Source: AGHT+IEFIOdbEIznwQZWZXI6r3lYMuir06rRAnN4O1q+8gBvc87o/vMWr5rcI3un2ILluN9aEKzsYQ== X-Received: by 2002:a17:90b:4ac7:b0:286:6cc1:2cba with SMTP id mh7-20020a17090b4ac700b002866cc12cbamr2532178pjb.68.1702384911066; Tue, 12 Dec 2023 04:41:51 -0800 (PST) Received: from localhost ([49.204.128.180]) by smtp.gmail.com with ESMTPSA id 4-20020a17090a194400b00286d686b3d9sm9803908pjh.17.2023.12.12.04.41.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 04:41:50 -0800 (PST) From: Visuwesh To: Eli Zaretskii Subject: Re: bug#67600: [PATCH] Add dashes to 'thing-at-point-email-regexp' In-Reply-To: <83y1dztxlq.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 12 Dec 2023 14:27:13 +0200") References: <87v89fh2iz.fsf@posteo.net> <83plzn77i2.fsf@gnu.org> <87wmtjnaxd.fsf@posteo.net> <831qbrvd5g.fsf@gnu.org> <87il53txv7.fsf@gmail.com> <83y1dztxlq.fsf@gnu.org> Date: Tue, 12 Dec 2023 18:11:47 +0530 Message-ID: <87edfrtwxg.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67600 Cc: philipk@posteo.net, 67600@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [Tuesday December 12, 2023] Eli Zaretskii wrote: >> From: Visuwesh >> Cc: Philip Kaludercic , 67600@debbugs.gnu.org >> Date: Tue, 12 Dec 2023 17:51:32 +0530 >> >> [Tuesday December 12, 2023] Eli Zaretskii wrote: >> >> > Thanks. >> > >> > My bother here is that this could cause false positives whereby >> > thing-at-point would recognize file names with slashes as email >> > addresses. Because otherwise I don't understand why the slash was >> > omitted in the first place. Can we somehow make sure this won't >> > happen? >> >> I am running Emacs with the same change before Philip created this bug >> report and so far I haven't had false positives for email addresses >> because files with a @ in its name is rare. In practise, I think this >> patch is harmless in that regard. > > Remote files that have user@host in their names do have that > character. AFAIU, user cannot have slashes in them as per the POSIX standards [1] and likewise with hostname so remote files should not pose a problem. Of course this assumes that you're only looking at methods like ssh, doas, sudo, etc. It seems like tramp disallows slashes in user and host anyway, try: (file-remote-p "/ssh:userwith/@host:/") ;; => nil (file-remote-p "/ssh:userwith@host/:/") ;; => nil (file-remote-p "/ssh:userwith@host:/") ;; => /ssh:userwith@host: 1. https://serverfault.com/a/578264 From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 12 08:09:15 2023 Received: (at 67600) by debbugs.gnu.org; 12 Dec 2023 13:09:15 +0000 Received: from localhost ([127.0.0.1]:55524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rD2Ve-00049u-J5 for submit@debbugs.gnu.org; Tue, 12 Dec 2023 08:09:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rD2Vc-00049h-63 for 67600@debbugs.gnu.org; Tue, 12 Dec 2023 08:09:13 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rD2VG-00061o-S5; Tue, 12 Dec 2023 08:08:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4+KORe4l/5dj9uGmNMJ1gY7YZKuYRFFEiK5FbSkHuBU=; b=W5EOOZdALclB eGRwkBrRHS98/ypXZxi6HOm7GaSyHzxjcJCKsXIWg0pMwUmBPb17RSedApYXKgeUf84CYiFCN3bL1 cAIxUfKpXOlkF4nP9oH9GQ864ryt3aq5YM8/JAzDhf5V5SOu9Rs+wULx90j//6Dy9GSRh5QiubGEk eKRCbo3MNr9s/cPDFFesYVM3lUb8DVNVcY2ZcGVPenmK9nHmLMU38PH/pHUpt1T913ctQ8gQT0rwt yvHGz6TpmG4/67OctoiYDYm46Tjtp8iaRwB+vmAonEcnkDx+ZqpC1d+oFlA8nk1uZhKODvCZikzWD EZoBGZ2QS+BqjNeI9WG9uw==; Date: Tue, 12 Dec 2023 15:08:41 +0200 Message-Id: <83ttontvom.fsf@gnu.org> From: Eli Zaretskii To: Visuwesh In-Reply-To: <87edfrtwxg.fsf@gmail.com> (message from Visuwesh on Tue, 12 Dec 2023 18:11:47 +0530) Subject: Re: bug#67600: [PATCH] Add dashes to 'thing-at-point-email-regexp' References: <87v89fh2iz.fsf@posteo.net> <83plzn77i2.fsf@gnu.org> <87wmtjnaxd.fsf@posteo.net> <831qbrvd5g.fsf@gnu.org> <87il53txv7.fsf@gmail.com> <83y1dztxlq.fsf@gnu.org> <87edfrtwxg.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67600 Cc: philipk@posteo.net, 67600@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Visuwesh > Cc: philipk@posteo.net, 67600@debbugs.gnu.org > Date: Tue, 12 Dec 2023 18:11:47 +0530 > > [Tuesday December 12, 2023] Eli Zaretskii wrote: > > >> I am running Emacs with the same change before Philip created this bug > >> report and so far I haven't had false positives for email addresses > >> because files with a @ in its name is rare. In practise, I think this > >> patch is harmless in that regard. > > > > Remote files that have user@host in their names do have that > > character. > > AFAIU, user cannot have slashes in them as per the POSIX standards [1] > and likewise with hostname so remote files should not pose a problem. > Of course this assumes that you're only looking at methods like ssh, > doas, sudo, etc. It seems like tramp disallows slashes in user and host > anyway, try: > > (file-remote-p "/ssh:userwith/@host:/") ;; => nil > (file-remote-p "/ssh:userwith@host/:/") ;; => nil > (file-remote-p "/ssh:userwith@host:/") ;; => /ssh:userwith@host: Why are you talking about slashes in user and host names? There are slashes in remote file names outside of those two. Are you saying that slashes in thing-at-point-email-regexp will only ever match if they are in the user or host names? That's not what I see: (string-match "?" "/ssh:userwith@host:/what/ever/it/can/be") => 0 From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 12 08:23:52 2023 Received: (at 67600) by debbugs.gnu.org; 12 Dec 2023 13:23:52 +0000 Received: from localhost ([127.0.0.1]:55540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rD2jo-0004ZE-BQ for submit@debbugs.gnu.org; Tue, 12 Dec 2023 08:23:52 -0500 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]:51279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rD2jl-0004Yx-HA for 67600@debbugs.gnu.org; Tue, 12 Dec 2023 08:23:50 -0500 Received: by mail-pg1-x541.google.com with SMTP id 41be03b00d2f7-5c1a75a4b6cso2763069a12.2 for <67600@debbugs.gnu.org>; Tue, 12 Dec 2023 05:23:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702387408; x=1702992208; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=y9j8Cv0uCI8hfB6vxxO88LjNk3P2fdb4V7dCnejKEYg=; b=U+agcuDDscWlCXKa6ICMYpcUpiot5tkwLaU4pgQhnEclSrz6oKkas4K1ZV20d6B0uT pTafxmZ15LdLeWDwCIl+lXtHdn+5jREfKZ2bWDQCjlEAks5ZgSAANa8seqsIT4fEChOu fpqQXi3Q56su/aMXTBf9hdAvxaod14aPL+G/9X1jy2jy4o4IlsNPybVpEYL3y8vt3mJZ oWEf8urRzPw0yX+g0WsnzGjGQJdNzVglaEKkvdnBmr9Zhyw8z/lg+5xS8WwIYWeH8rGm Ezwie2ypUGak+m9WdDNjVdRsx1/Y2eYBDe4YdYMkzCsG4FNX+SrAGZDAQlamwPSR65/V 1JZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702387408; x=1702992208; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y9j8Cv0uCI8hfB6vxxO88LjNk3P2fdb4V7dCnejKEYg=; b=KagnSH0Y5NyAor09uTKRNLG46btQOkxlsYFnXvSlZ+uS17OBEvWk0raRj9QZoDHMgJ zJCRJZeTmZ3E6MkpUyHOpqOI1hMHCyDueljH81qTbeTvrdRheTM0gme41CQbNtMRoU06 Lxf8kFTXtqs0EBx2ouzxmuM2mkAAGVCptmHrfv3o2wSOAWkh4kAsa09XHC3Pfyepi9Li aZS3iWEIXCD7vt1pO32FJ3sJx6L8Ul45coxaCdvqo8BZYSEBLCHuJA0elLgFubQKd3Lc aCfFVhm3MDUieZOvvuvZ0TPnbAUAIXL0NjpCh7g9MpHUlP1iSlrqPpjgtAe6vDTlr12P HzSQ== X-Gm-Message-State: AOJu0YxRKkxvWfu7p3uMlCOVefmWQdqhdcJf3JEXSA1gAvcEddxlkzoV 9FSWeUe2gkxvV/qrHoU5ulo= X-Google-Smtp-Source: AGHT+IFTSlV4W82VnKSOL3nlbpbUOzE5V7QT3tXnZUQdAMGa2jnUJmzGgdV7wsqBJmfN3cXDcXQOWw== X-Received: by 2002:a05:6a21:609:b0:18c:3260:e223 with SMTP id ll9-20020a056a21060900b0018c3260e223mr2625934pzb.18.1702387408058; Tue, 12 Dec 2023 05:23:28 -0800 (PST) Received: from localhost ([49.204.128.180]) by smtp.gmail.com with ESMTPSA id u23-20020a62d457000000b006ce781f6f85sm8431174pfl.43.2023.12.12.05.23.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 05:23:27 -0800 (PST) From: Visuwesh To: Eli Zaretskii Subject: Re: bug#67600: [PATCH] Add dashes to 'thing-at-point-email-regexp' In-Reply-To: <83ttontvom.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 12 Dec 2023 15:08:41 +0200") References: <87v89fh2iz.fsf@posteo.net> <83plzn77i2.fsf@gnu.org> <87wmtjnaxd.fsf@posteo.net> <831qbrvd5g.fsf@gnu.org> <87il53txv7.fsf@gmail.com> <83y1dztxlq.fsf@gnu.org> <87edfrtwxg.fsf@gmail.com> <83ttontvom.fsf@gnu.org> Date: Tue, 12 Dec 2023 18:53:25 +0530 Message-ID: <87a5qftv02.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67600 Cc: philipk@posteo.net, 67600@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [Tuesday December 12, 2023] Eli Zaretskii wrote: >> From: Visuwesh >> Cc: philipk@posteo.net, 67600@debbugs.gnu.org >> Date: Tue, 12 Dec 2023 18:11:47 +0530 >> >> [Tuesday December 12, 2023] Eli Zaretskii wrote: >> >> >> I am running Emacs with the same change before Philip created this bug >> >> report and so far I haven't had false positives for email addresses >> >> because files with a @ in its name is rare. In practise, I think this >> >> patch is harmless in that regard. >> > >> > Remote files that have user@host in their names do have that >> > character. >> >> AFAIU, user cannot have slashes in them as per the POSIX standards [1] >> and likewise with hostname so remote files should not pose a problem. >> Of course this assumes that you're only looking at methods like ssh, >> doas, sudo, etc. It seems like tramp disallows slashes in user and host >> anyway, try: >> >> (file-remote-p "/ssh:userwith/@host:/") ;; => nil >> (file-remote-p "/ssh:userwith@host/:/") ;; => nil >> (file-remote-p "/ssh:userwith@host:/") ;; => /ssh:userwith@host: > > Why are you talking about slashes in user and host names? There are > slashes in remote file names outside of those two. Are you saying > that slashes in thing-at-point-email-regexp will only ever match if > they are in the user or host names? That's not what I see: > > (string-match "?" > "/ssh:userwith@host:/what/ever/it/can/be") > => 0 I see what you mean now. But the problem is that even without the slashes in the regexp, the filename you gave matches: (string-match "?" "/ssh:userwith@host:/what/ever/it/can/be") ;; => 1 the matched string is ssh:userwith@host. So the old regexp will still return false positives when the point is on userwith@host I think. With the slashes, the matched string is /ssh:userwith@host. If we drop the slash from the first character class i.e., (string-match "?" "/ssh:userwith@host:/what/ever/it/can/be") ;; => 1 then the matched string is again ssh:userwith@host. And this regexp still matches the sr.ht list email addresses (this is the regexp I use in my Emacs checkout). From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 12 08:36:03 2023 Received: (at 67600) by debbugs.gnu.org; 12 Dec 2023 13:36:03 +0000 Received: from localhost ([127.0.0.1]:55552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rD2vb-0004ug-6b for submit@debbugs.gnu.org; Tue, 12 Dec 2023 08:36:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rD2vZ-0004u8-3l for 67600@debbugs.gnu.org; Tue, 12 Dec 2023 08:36:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rD2v9-0008CD-Js; Tue, 12 Dec 2023 08:35:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6G17fJH0Yb0Xrl53Qvaq1H9/SHf0sHLEMLkeffDuomQ=; b=NmDnA1KlPQRf TSQ6j3IUBrfg0REAtQhpg2M+Jm9h37pBoa7wT6mwsFlw/bsSlhmwwlDvIByZHzLdtoBy0vFeZv6Vx Av/tjAGCJk16tqx2qeL8+VZzlLlekIYahq2ClLCcuKxVe5402eJjSqoEpzTIOYSVs87sGV9/QhxjL 9QqwOSU0uBh6b0LIZTcQmekzFxoQptYEzSbE/R22RnrBFJHt/85TJu91XQEdCnSB/n2nim4IePAmP ZiJbiuuR0YdTnXeblTv6gE8HZha+Xu9WsY7yFJk08rTNy433HJ+dZrf/Vefb7cg1jIDsRaeaXwzV9 If+wzCFVxe5cBFrhKsO0EA==; Date: Tue, 12 Dec 2023 15:35:06 +0200 Message-Id: <83r0jrtugl.fsf@gnu.org> From: Eli Zaretskii To: Visuwesh In-Reply-To: <87a5qftv02.fsf@gmail.com> (message from Visuwesh on Tue, 12 Dec 2023 18:53:25 +0530) Subject: Re: bug#67600: [PATCH] Add dashes to 'thing-at-point-email-regexp' References: <87v89fh2iz.fsf@posteo.net> <83plzn77i2.fsf@gnu.org> <87wmtjnaxd.fsf@posteo.net> <831qbrvd5g.fsf@gnu.org> <87il53txv7.fsf@gmail.com> <83y1dztxlq.fsf@gnu.org> <87edfrtwxg.fsf@gmail.com> <83ttontvom.fsf@gnu.org> <87a5qftv02.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67600 Cc: philipk@posteo.net, 67600@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Visuwesh > Cc: philipk@posteo.net, 67600@debbugs.gnu.org > Date: Tue, 12 Dec 2023 18:53:25 +0530 > > >> (file-remote-p "/ssh:userwith/@host:/") ;; => nil > >> (file-remote-p "/ssh:userwith@host/:/") ;; => nil > >> (file-remote-p "/ssh:userwith@host:/") ;; => /ssh:userwith@host: > > > > Why are you talking about slashes in user and host names? There are > > slashes in remote file names outside of those two. Are you saying > > that slashes in thing-at-point-email-regexp will only ever match if > > they are in the user or host names? That's not what I see: > > > > (string-match "?" > > "/ssh:userwith@host:/what/ever/it/can/be") > > => 0 > > I see what you mean now. But the problem is that even without the > slashes in the regexp, the filename you gave matches: > > (string-match "?" > "/ssh:userwith@host:/what/ever/it/can/be") ;; => 1 > > the matched string is ssh:userwith@host. So the old regexp will still > return false positives when the point is on userwith@host I think. > > With the slashes, the matched string is /ssh:userwith@host. If we drop > the slash from the first character class i.e., > > (string-match "?" > "/ssh:userwith@host:/what/ever/it/can/be") ;; => 1 Yes, but now it matches without the leading slash, i.e. not entirely. But see bug#67688. My bother is that this change could perhaps increase the probability of such mis-guesses. Not sure it matters, I'm just asking. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 12 09:26:04 2023 Received: (at 67600) by debbugs.gnu.org; 12 Dec 2023 14:26:04 +0000 Received: from localhost ([127.0.0.1]:55602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rD3hz-0006FP-WB for submit@debbugs.gnu.org; Tue, 12 Dec 2023 09:26:04 -0500 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]:53665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rD3hy-0006F5-9v for 67600@debbugs.gnu.org; Tue, 12 Dec 2023 09:26:02 -0500 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1d307cf18fdso12658315ad.3 for <67600@debbugs.gnu.org>; Tue, 12 Dec 2023 06:25:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702391141; x=1702995941; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=7lXZ3HfgSHoFKDeif+BvjAX4PmPQ+TT7G7TeqPYbXk0=; b=WVznro7lNkZGU2DPncrhWuFsGfbplmLRDH25BcH4WZTl4BmDRgrtmZAJlPEaC/pKgZ 9/PKZkm7wGq/95LwMoMNT1rPqRSzjOSINufkMoriJTjQ+98E1pqBMWt8sCxB89QoAAC2 3J5+pvhRnD3myS4q2HnvPq8dNq8n1Fg+qfzeiIkgAmK6CqMpGGp9wuYtbRNdeCzK2DrY SGJJVUY77dQqg7849wWFRuTK0Y9E7x/GEpjI0WkkOc3TuZLbpkLd9qaldKqrJ2n6iHhu AqFUQsDSgdWepOCUCNTNzhJR/5prcHZXOG6A8sX8yXE5MUC6d2GANjQhUCJBGneG4drF u53g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702391141; x=1702995941; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7lXZ3HfgSHoFKDeif+BvjAX4PmPQ+TT7G7TeqPYbXk0=; b=NGGFKpArNbCyXiQkFuCWKERLnZoAldz9gaCjcZpl3690Bh/qbMETK0YaI6C2h8pJN0 KVb83sz/b6Uf6jfDrJMUgtAXk2HtjVEIb+50m5LJNrpvRmGJutSaAN3zTfAI37dZMl1V mnqIPYH7Pd6Q/j8bdGfkl/nB1gRpnpvSVRnJUrrUjheNxX3Dz4S7YlwvW5ZoSwY6sXOH D3qf5t/RrEAAIKPfdtfGOzeLSnLs2Iv7nNLogt3fOVOQB8VKocXfZenO90j+3D50en27 jGxBNUyZM8gpYp25qzbJCfEczxdBCBcOwNW32WCq8zsnrPAs/i+fh4Ch5fpuAbvnO38q 0gzQ== X-Gm-Message-State: AOJu0YwV9kGMKlLObSmbrJeblubioUM1GJcty0Z1J6a+GS4H6UeexPKn XTrsYsgpkhl9qiAJEOuYbhE= X-Google-Smtp-Source: AGHT+IElexV72khgwW8vNVtEcTfBbpsryNbct2PGdzS57v8DMuKtDX8ehibRlpozPL/SHRiXKXK+xg== X-Received: by 2002:a17:902:7ed0:b0:1d0:6ffd:cea8 with SMTP id p16-20020a1709027ed000b001d06ffdcea8mr2535092plb.97.1702391140671; Tue, 12 Dec 2023 06:25:40 -0800 (PST) Received: from localhost ([49.204.128.180]) by smtp.gmail.com with ESMTPSA id c3-20020a170902848300b001d33e6521b9sm1189874plo.14.2023.12.12.06.25.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 06:25:40 -0800 (PST) From: Visuwesh To: Eli Zaretskii Subject: Re: bug#67600: [PATCH] Add dashes to 'thing-at-point-email-regexp' In-Reply-To: <83r0jrtugl.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 12 Dec 2023 15:35:06 +0200") References: <87v89fh2iz.fsf@posteo.net> <83plzn77i2.fsf@gnu.org> <87wmtjnaxd.fsf@posteo.net> <831qbrvd5g.fsf@gnu.org> <87il53txv7.fsf@gmail.com> <83y1dztxlq.fsf@gnu.org> <87edfrtwxg.fsf@gmail.com> <83ttontvom.fsf@gnu.org> <87a5qftv02.fsf@gmail.com> <83r0jrtugl.fsf@gnu.org> Date: Tue, 12 Dec 2023 19:55:37 +0530 Message-ID: <875y13ts4e.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67600 Cc: philipk@posteo.net, 67600@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [Tuesday December 12, 2023] Eli Zaretskii wrote: >> I see what you mean now. But the problem is that even without the >> slashes in the regexp, the filename you gave matches: >> >> (string-match "?" >> "/ssh:userwith@host:/what/ever/it/can/be") ;; => 1 >> >> the matched string is ssh:userwith@host. So the old regexp will still >> return false positives when the point is on userwith@host I think. >> >> With the slashes, the matched string is /ssh:userwith@host. If we drop >> the slash from the first character class i.e., >> >> (string-match "?" >> "/ssh:userwith@host:/what/ever/it/can/be") ;; => 1 > > Yes, but now it matches without the leading slash, i.e. not entirely. > But see bug#67688. My bother is that this change could perhaps > increase the probability of such mis-guesses. Not sure it matters, > I'm just asking. Thanks for the pointer but changing the email address regexp will have no effect on the return value of (thing-at-point 'filename), and this is what ffap does (along with other heuristics), and others will do when they want to get the filename at point. But IME, the filename thing-at-point matches are really limited compared to the additional heuristics that ffap employs to match filename but they still aren't perfect: filenames with spaces in them are only picked up by ffap only when the point is over the "first word". From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 16 05:41:45 2023 Received: (at 67600) by debbugs.gnu.org; 16 Dec 2023 10:41:45 +0000 Received: from localhost ([127.0.0.1]:54001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rES76-0004vW-Ks for submit@debbugs.gnu.org; Sat, 16 Dec 2023 05:41:45 -0500 Received: from mout01.posteo.de ([185.67.36.65]:53635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rES72-0004v3-Ay for 67600@debbugs.gnu.org; Sat, 16 Dec 2023 05:41:43 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id BA504240027 for <67600@debbugs.gnu.org>; Sat, 16 Dec 2023 11:41:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1702723293; bh=8EWiSfaC+9S40sjw/l+VTpxK61a7z7GFTCAIse4/WwY=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=JqtF/GMu33GUshr6wZAjiJzFAzw285WuBfZ4myzZC4cj+lkus3NBNDUaOiJ4R+0x6 1WHSorGPJRwD0Z60qqJEToV+Mo6VbY92WlBgS+Popvf1FutA5ziu6Sc58AJgzfwzSL ON6KLapy9bUiW1SQzS27rRaPq/lkJK3Pavt95FqewmpvV//wLHsyuKwaO9PzS1PdrJ TPfDmJorXhPq1v+oACJhc3YeUFqJjwVbuCmh1/WvHOhdGPX7CNDKtJ9ReU1geaUAc4 P61pL/QddV9Z29w3mXFGxdMyzt4eRnMxq5PQD9CivVYI1rGSMpE0H8POw3CDDn12my Ft9vKGnzQgZSw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SsjLh6THlz6tsf; Sat, 16 Dec 2023 11:41:32 +0100 (CET) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#67600: [PATCH] Add dashes to 'thing-at-point-email-regexp' In-Reply-To: <831qbrvd5g.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 12 Dec 2023 14:06:03 +0200") References: <87v89fh2iz.fsf@posteo.net> <83plzn77i2.fsf@gnu.org> <87wmtjnaxd.fsf@posteo.net> <831qbrvd5g.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sat, 16 Dec 2023 10:41:32 +0000 Message-ID: <87jzpetoo3.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67600 Cc: 67600@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: 67600@debbugs.gnu.org >> Date: Tue, 12 Dec 2023 07:21:18 +0000 >> >> Eli Zaretskii writes: >> >> >> From: Philip Kaludercic >> >> Date: Sun, 03 Dec 2023 12:52:04 +0000 >> >> >> >> I noticed this recently when trying to extract a link to an mailing list >> >> of mine hosted on SourceHut. >> > >> > Looks like you are adding slashes, not dashes? >> >> Of course, my bad: > > Thanks. > > My bother here is that this could cause false positives whereby > thing-at-point would recognize file names with slashes as email > addresses. Because otherwise I don't understand why the slash was > omitted in the first place. Can we somehow make sure this won't > happen? One idea might be to just add slashes to the user name part of the address, which would suffice to solve the issue I was having. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 16 08:39:06 2023 Received: (at 67600) by debbugs.gnu.org; 16 Dec 2023 13:39:06 +0000 Received: from localhost ([127.0.0.1]:54248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEUsg-0007wP-AL for submit@debbugs.gnu.org; Sat, 16 Dec 2023 08:39:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEUsd-0007vt-Pq for 67600@debbugs.gnu.org; Sat, 16 Dec 2023 08:39:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEUsW-0005ni-Dh; Sat, 16 Dec 2023 08:38:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=uwIlbhqh08wuZgsyTleQXEViuunqmkl2fkjp2xVt/lE=; b=rQ8gXKLEAdYy c44Ty51Hzj0mhhiGZjYI178hg4WInAdTgRpUf+T9gQpE4J1ybFyuAUCpDPppyRFBMq5Nit+oSc69s ZSfHYuvoFhm8myygFKihWzx2gsxPaBVgiEo6nS3Vbp0OBnfr7afAGgXdyB3o+CbbvM339Ae05sYjn GMDEUem7kIiP0aA/pFJUXrmwFrmw/dj6lTFKDfBSXod3ye6o7rmvIjGVFGCK8tY8qHH+n8PBc5a+v oWWlTWtKly1snRdUyZH8EX2c1FcHz6aZ7hB/KgTUHUJrZicUnCneN+XZOVxc5xDTQUe6wiq4Y95Cq T5vdE/49BKeXi/PgKqEQSg==; Date: Sat, 16 Dec 2023 15:38:31 +0200 Message-Id: <838r5umfmw.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87jzpetoo3.fsf@posteo.net> (message from Philip Kaludercic on Sat, 16 Dec 2023 10:41:32 +0000) Subject: Re: bug#67600: [PATCH] Add dashes to 'thing-at-point-email-regexp' References: <87v89fh2iz.fsf@posteo.net> <83plzn77i2.fsf@gnu.org> <87wmtjnaxd.fsf@posteo.net> <831qbrvd5g.fsf@gnu.org> <87jzpetoo3.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67600 Cc: 67600@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: 67600@debbugs.gnu.org > Date: Sat, 16 Dec 2023 10:41:32 +0000 > > Eli Zaretskii writes: > > >> From: Philip Kaludercic > >> Cc: 67600@debbugs.gnu.org > >> Date: Tue, 12 Dec 2023 07:21:18 +0000 > >> > >> Eli Zaretskii writes: > >> > >> >> From: Philip Kaludercic > >> >> Date: Sun, 03 Dec 2023 12:52:04 +0000 > >> >> > >> >> I noticed this recently when trying to extract a link to an mailing list > >> >> of mine hosted on SourceHut. > >> > > >> > Looks like you are adding slashes, not dashes? > >> > >> Of course, my bad: > > > > Thanks. > > > > My bother here is that this could cause false positives whereby > > thing-at-point would recognize file names with slashes as email > > addresses. Because otherwise I don't understand why the slash was > > omitted in the first place. Can we somehow make sure this won't > > happen? > > One idea might be to just add slashes to the user name part of the > address, which would suffice to solve the issue I was having. Can you show a patch, so we could make sure we are on the same page? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 16 09:50:39 2023 Received: (at 67600) by debbugs.gnu.org; 16 Dec 2023 14:50:39 +0000 Received: from localhost ([127.0.0.1]:54279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEVzz-0005ur-9n for submit@debbugs.gnu.org; Sat, 16 Dec 2023 09:50:39 -0500 Received: from mout02.posteo.de ([185.67.36.66]:56121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEVzv-0005uZ-8D for 67600@debbugs.gnu.org; Sat, 16 Dec 2023 09:50:37 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 73EB1240101 for <67600@debbugs.gnu.org>; Sat, 16 Dec 2023 15:50:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1702738228; bh=DBPEjiJBFIFHwftzoY9Y6mbg9EC+hEMmMOte+21nzs0=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=n+/3wuB9s6v3IWxEQK4e9Weic8sZCcl+rQLP1PXlwFXY9SGiJ/gMyOwfoQPljnO1G bo5jBrzt1xJbJIR4oPmqw4q23EQ+TZ0fMuWZUduqjVAn3JaGV4fuAHb6fZF3x+PXWB WUftjDSJffz1nWL0L0bfq85nTWf1fntDZDyezf9f48mtcmftHEo4o1H6ux4Vwijs+m DxbL5KWz4nqYOttwZd5tDx8cd91I5YE/xw/CLc2Vs4c10mrRHy7r4wb+hz6RjK8Jaq zA2JhwHWEpXmUdP4MSJfXs5jnINMg7Ar+5cE8W9EQFu00ASHYJKydOqP9e2nw1Tk+X pZdZNg1ICxQ1g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Sspsw0JfXz6tyY; Sat, 16 Dec 2023 15:50:27 +0100 (CET) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#67600: [PATCH] Add dashes to 'thing-at-point-email-regexp' In-Reply-To: <838r5umfmw.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 16 Dec 2023 15:38:31 +0200") References: <87v89fh2iz.fsf@posteo.net> <83plzn77i2.fsf@gnu.org> <87wmtjnaxd.fsf@posteo.net> <831qbrvd5g.fsf@gnu.org> <87jzpetoo3.fsf@posteo.net> <838r5umfmw.fsf@gnu.org> X-Hashcash: 1:20:231216:67600@debbugs.gnu.org::RYveXCRpU7Eh63dx:ohn X-Hashcash: 1:20:231216:eliz@gnu.org::AUUsTd/bXeDklSo1:75cI Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sat, 16 Dec 2023 14:50:27 +0000 Message-ID: <87a5qanqvg.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67600 Cc: 67600@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: 67600@debbugs.gnu.org >> Date: Sat, 16 Dec 2023 10:41:32 +0000 >> >> Eli Zaretskii writes: >> >> >> From: Philip Kaludercic >> >> Cc: 67600@debbugs.gnu.org >> >> Date: Tue, 12 Dec 2023 07:21:18 +0000 >> >> >> >> Eli Zaretskii writes: >> >> >> >> >> From: Philip Kaludercic >> >> >> Date: Sun, 03 Dec 2023 12:52:04 +0000 >> >> >> >> >> >> I noticed this recently when trying to extract a link to an mailing list >> >> >> of mine hosted on SourceHut. >> >> > >> >> > Looks like you are adding slashes, not dashes? >> >> >> >> Of course, my bad: >> > >> > Thanks. >> > >> > My bother here is that this could cause false positives whereby >> > thing-at-point would recognize file names with slashes as email >> > addresses. Because otherwise I don't understand why the slash was >> > omitted in the first place. Can we somehow make sure this won't >> > happen? >> >> One idea might be to just add slashes to the user name part of the >> address, which would suffice to solve the issue I was having. > > Can you show a patch, so we could make sure we are on the same page? Never mind, I misremembered my own patch, this is already what I am proposing. - "?" + "?" I had falsely assumed that my suggestion was to apply this change - "?" + "?" Which would risk more false positives. -- Philip Kaludercic From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 16 10:00:28 2023 Received: (at 67600) by debbugs.gnu.org; 16 Dec 2023 15:00:28 +0000 Received: from localhost ([127.0.0.1]:55686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEW9U-0007JK-Fc for submit@debbugs.gnu.org; Sat, 16 Dec 2023 10:00:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEW9P-0006os-WD for 67600@debbugs.gnu.org; Sat, 16 Dec 2023 10:00:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEW9J-0006oY-Qk; Sat, 16 Dec 2023 10:00:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZG+gihYQk+p6aHaLYnMj4N+cKjahMWtucF6ZYDM4qRo=; b=dbPu7aerNO8d 9N0xXEwtfhouEHWGvOuc/ZkXHtgLBtepuz+PtF9SSztWlDfY0eWbgojHIUo957j97J2x913VIjDek lPS5gj1ZVJ3cUOhErOcroulq0RA9779DXJnLoiu19XyKoxekdE8QwepWeQ6W+8KVKw5meM3HptE1q b6tgr0YIe/4hWz0/CT/beshgIfx6j9sPsY4IqZ8ARUbBp6QqXFBpqM+xARKO9ULNXWtFQwuRqlyXi 2nVqYRTp3grXTwLZARLkvIUrvTZnQSrtTmhKYpaX02cIv6uOa3TH9MuWcGMTIR+F6Jl7rv1PpaoSf S01m4XUi7bo08RgWQJOUtw==; Date: Sat, 16 Dec 2023 16:59:56 +0200 Message-Id: <83zfyakxar.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87a5qanqvg.fsf@posteo.net> (message from Philip Kaludercic on Sat, 16 Dec 2023 14:50:27 +0000) Subject: Re: bug#67600: [PATCH] Add dashes to 'thing-at-point-email-regexp' References: <87v89fh2iz.fsf@posteo.net> <83plzn77i2.fsf@gnu.org> <87wmtjnaxd.fsf@posteo.net> <831qbrvd5g.fsf@gnu.org> <87jzpetoo3.fsf@posteo.net> <838r5umfmw.fsf@gnu.org> <87a5qanqvg.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67600 Cc: 67600@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: 67600@debbugs.gnu.org > Date: Sat, 16 Dec 2023 14:50:27 +0000 > > Eli Zaretskii writes: > > > Can you show a patch, so we could make sure we are on the same page? > > Never mind, I misremembered my own patch, this is already what I am > proposing. > > - "?" > + "?" > > I had falsely assumed that my suggestion was to apply this change > > - "?" > + "?" > > Which would risk more false positives. Thanks. If you think the patch is safe enough, feel free to install. If there are problems with it, I guess we will hear about them sooner or later. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 17 07:11:36 2023 Received: (at 67600-done) by debbugs.gnu.org; 17 Dec 2023 12:11:36 +0000 Received: from localhost ([127.0.0.1]:56669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEpzc-0002Rd-8a for submit@debbugs.gnu.org; Sun, 17 Dec 2023 07:11:36 -0500 Received: from mout02.posteo.de ([185.67.36.66]:45697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEpza-0002RM-8V for 67600-done@debbugs.gnu.org; Sun, 17 Dec 2023 07:11:34 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 035F1240101 for <67600-done@debbugs.gnu.org>; Sun, 17 Dec 2023 13:11:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1702815087; bh=felCZYXfSFxEYvpOheKiHf8zt1unu1GXH4u5HhcSIM0=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=MFzInQYk2v3LUCXyyJa+bhTPkwK5VOzQeZM9mRpekt6r/PzIUmdi87K0GV3T14r84 IqQt5ZUUu77GZ5V9L82EgGAZGYobzmZY1dQSkPg+hUd7GwE4rS6JhwdJHqVzBZow6/ bU5hCEykSsqoP21GZweG4RT1B3fhiJAhgvjgItTJgkhDnkV3od2uub04xxsZf3H7nF t1zSg0m4kBp0qYmN9PTrDGVo+oubE6YqR6qrTpe05X7CgWWGTjPm8LNuxD4XFNjBv8 5Y5bhgj0a6+DnfwfIHAc/Icltwy3ZlV1nsdHwM3PTsb65BdGUgXN488ph49XLqlEWK L2a20RSMhvucg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4StMHy4P1Qz6tyR; Sun, 17 Dec 2023 13:11:26 +0100 (CET) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#67600: [PATCH] Add dashes to 'thing-at-point-email-regexp' In-Reply-To: <83zfyakxar.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 16 Dec 2023 16:59:56 +0200") References: <87v89fh2iz.fsf@posteo.net> <83plzn77i2.fsf@gnu.org> <87wmtjnaxd.fsf@posteo.net> <831qbrvd5g.fsf@gnu.org> <87jzpetoo3.fsf@posteo.net> <838r5umfmw.fsf@gnu.org> <87a5qanqvg.fsf@posteo.net> <83zfyakxar.fsf@gnu.org> X-Hashcash: 1:20:231217:67600@debbugs.gnu.org::KrrbbpM7jV8cSwib:AGy X-Hashcash: 1:20:231217:eliz@gnu.org::D0WYn/AdNxkJYt1u:3yB Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sun, 17 Dec 2023 12:11:26 +0000 Message-ID: <87plz5kp01.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67600-done Cc: 67600-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: 67600@debbugs.gnu.org >> Date: Sat, 16 Dec 2023 14:50:27 +0000 >> >> Eli Zaretskii writes: >> >> > Can you show a patch, so we could make sure we are on the same page? >> >> Never mind, I misremembered my own patch, this is already what I am >> proposing. >> >> - "?" >> + "?" >> >> I had falsely assumed that my suggestion was to apply this change >> >> - "?" >> + "?" >> >> Which would risk more false positives. > > Thanks. > > If you think the patch is safe enough, feel free to install. If there > are problems with it, I guess we will hear about them sooner or later. OK thanks, done. -- Philip Kaludercic From unknown Fri Jun 20 19:48:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 14 Jan 2024 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator