From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 03 03:34:11 2023 Received: (at submit) by debbugs.gnu.org; 3 Dec 2023 08:34:11 +0000 Received: from localhost ([127.0.0.1]:59111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9hvW-0003bP-G1 for submit@debbugs.gnu.org; Sun, 03 Dec 2023 03:34:11 -0500 Received: from lists.gnu.org ([2001:470:142::17]:43014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9WTB-00073R-J5 for submit@debbugs.gnu.org; Sat, 02 Dec 2023 15:20:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9WSj-0000wn-Rh for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2023 15:19:43 -0500 Received: from 195-240-159-36.fixed.kpn.net ([195.240.159.36] helo=werkplek.tradesystem.nl) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9WSQ-0002TX-QY for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2023 15:19:40 -0500 Received: from werkplek.tradesystem.nl.tradesystem.nl (githost.tradesystem.nl [192.168.3.43]) by werkplek.tradesystem.nl (8.16.1/8.16.1) with ESMTPS id 3B2KJ7wg028325 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO) for ; Sat, 2 Dec 2023 21:19:07 +0100 (CET) (envelope-from matto@matto.nl) From: Matto Fransen To: bug-gnu-emacs@gnu.org Subject: [PATCH] Specific crirc log file time stamp forma Date: Sat, 02 Dec 2023 21:19:07 +0100 Message-ID: <86plzo1hok.fsf@werkplek.tradesystem.nl> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: none client-ip=195.240.159.36; envelope-from=matto@matto.nl; helo=werkplek.tradesystem.nl X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, KHOP_HELO_FCRDNS=0.26, RCVD_IN_SORBS_DUL=0.001, SPF_HELO_NONE=0.001, TVD_RCVD_IP=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 03 Dec 2023 03:34:09 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Tags: patch Allows the time stamp in crirc log files to differ from the format in the chat buffers. For example, the chat buffers can have the format "%H:%M ", while the log files can have a format including the date. In GNU Emacs 30.0.50 (build 1, x86_64-unknown-freebsd14.0) of 2023-12-02 built on testnuc.tradesystem.nl Repository revision: fb4b0b30a24e8192e71c1425dc8a295cf39f64ff Repository branch: rcirc-log-timestamp-format System Description: 14.0-RELEASE-p1 Configured using: 'configure --with-x-toolkit=no --without-x' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Specific-crirc-log-file-time-stamp-format.patch Content-Description: 0001-Specific-crirc-log-file-time-stamp-format.patch >From fa0927f06e88322e274f8ce668a71de41b02b80a Mon Sep 17 00:00:00 2001 From: Matto Fransen Date: Sat, 2 Dec 2023 20:55:37 +0100 Subject: [PATCH] Specific crirc log file time stamp fomrmat The time stamp format in the chat buffer may now differ from the format in the log files. * doc/misc/rcirc.texi: Document new variable * lisp/net/rcirc.el (rcirc-log-time-format): Custom variable for the format. Copyright-paperwork-exempt: yes --- doc/misc/rcirc.texi | 8 ++++++++ etc/NEWS | 7 ++++++- lisp/net/rcirc.el | 8 +++++++- 3 files changed, 21 insertions(+), 2 deletions(-) diff --git a/doc/misc/rcirc.texi b/doc/misc/rcirc.texi index 6b10d1ab2a4..aa424d8e164 100644 --- a/doc/misc/rcirc.texi +++ b/doc/misc/rcirc.texi @@ -929,6 +929,7 @@ Changing the time stamp format @cindex date time @cindex format time stamp @vindex rcirc-time-format +@vindex rcirc-log-time-format @code{rcirc-time-format} is the format used for the time stamp. Here's how to include the date in the time stamp: @@ -937,6 +938,13 @@ Changing the time stamp format (setopt rcirc-time-format "%Y-%m-%d %H:%M ") @end example +@code{rcirc-log-time-format} is the format used for the time stamp +in the log files. Here's how to use month and day in the time stamp: + +@example +(setopt rcirc-log-time-format "%m-%d %H:%M ") +@end example + @findex rcirc-when If you don't wish to use verbose time formatting all the time, you can use the @code{rcirc-when} command to display a complete timestamp for diff --git a/etc/NEWS b/etc/NEWS index da00ea9dbda..44cbf21a3d3 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1077,11 +1077,16 @@ For links in 'webjump-sites' without an explicit URI scheme, it was previously assumed that they should be prefixed with "http://". Such URIs are now prefixed with "https://" instead. ---- + *** 'bug-reference-mode' now supports 'thing-at-point'. Now, calling '(thing-at-point 'url)' when point is on a bug reference will return the URL for that bug. + +*** Specific timestamp format for crirc log files +Now, the timestamp format in crirc chat buffers can differ from the +timestamp format in the log files. + ** Customize +++ diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index ecfeb9f8f84..6390d4dd284 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -229,6 +229,12 @@ rcirc-time-format Used as the first arg to `format-time-string'." :type 'string) +(defcustom rcirc-log-time-format "%d-%b %H:%M " + "Describes how timestamps are printed in the log files. +Used as the first arg to `format-time-string'." + :version "30.1" + :type 'string ) + (defcustom rcirc-input-ring-size 1024 "Size of input history ring." :type 'integer) @@ -2209,7 +2215,7 @@ rcirc-log (parse-iso8601-time-string time t)))) (unless (null filename) (let ((cell (assoc-string filename rcirc-log-alist)) - (line (concat (format-time-string rcirc-time-format time) + (line (concat (format-time-string rcirc-log-time-format time) (substring-no-properties (rcirc-format-response-string process sender response target text)) -- 2.42.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 16 05:39:29 2023 Received: (at 67597) by debbugs.gnu.org; 16 Dec 2023 10:39:29 +0000 Received: from localhost ([127.0.0.1]:53996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rES4v-0004qx-09 for submit@debbugs.gnu.org; Sat, 16 Dec 2023 05:39:29 -0500 Received: from mout02.posteo.de ([185.67.36.66]:34777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rES4s-0004qj-9Z for 67597@debbugs.gnu.org; Sat, 16 Dec 2023 05:39:27 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 70B8D240101 for <67597@debbugs.gnu.org>; Sat, 16 Dec 2023 11:39:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1702723159; bh=ixcDZ+HoMnAw0yvCRSGq4OjLWP04DfN9Gnlj6iv3aIs=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=c0ugZXfOkiI1E5/VTdXqS6qrN7zow5O0+gvGIC4Z3M8dLRDn+/JqnX7/wZtSxG1YQ y2fyFLm4fxfTL6uqocBWIWXZZ988oRUSJOIJKzaaHubmc5zuvhO5Dsf3zODzjrhkCN NxaZQ1gbmeTmtUapAbaj6bldpQwR81kKwoOosmiNv6WDVBMIbBbD9E/Ql3nktuouwM 4SBgyAXOepPkdjARIJShaFDoREsUoWjAeB/FyMy+FH3S4R+0er8RVeEHh2A+cPmQtA wUsPgFrJbdGRqyBZTtyUAiDs4/8TtSOmRoCbaCU3oVHTBCvKRDF6uEDcPKEFxDgPY+ c49gaxT0z7PsA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SsjJ674ljz6tv5; Sat, 16 Dec 2023 11:39:18 +0100 (CET) From: Philip Kaludercic To: Matto Fransen Subject: Re: bug#67597: [PATCH] Specific rcirc log file time stamp format In-Reply-To: <86plzo1hok.fsf@werkplek.tradesystem.nl> (Matto Fransen's message of "Sat, 02 Dec 2023 21:19:07 +0100") References: <86plzo1hok.fsf@werkplek.tradesystem.nl> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sat, 16 Dec 2023 10:39:18 +0000 Message-ID: <87msuatort.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67597 Cc: 67597@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Matto Fransen writes: > Tags: patch > > Allows the time stamp in crirc log files to differ from ^ "rcirc"; you appear to make this typo a few more times below. > the format in the chat buffers. > For example, the chat buffers can have the format "%H:%M ", > while the log files can have a format including the date. > > In GNU Emacs 30.0.50 (build 1, x86_64-unknown-freebsd14.0) of 2023-12-02 > built on testnuc.tradesystem.nl > Repository revision: fb4b0b30a24e8192e71c1425dc8a295cf39f64ff > Repository branch: rcirc-log-timestamp-format > System Description: 14.0-RELEASE-p1 > > Configured using: > 'configure --with-x-toolkit=no --without-x' > > >>>From fa0927f06e88322e274f8ce668a71de41b02b80a Mon Sep 17 00:00:00 2001 > From: Matto Fransen > Date: Sat, 2 Dec 2023 20:55:37 +0100 > Subject: [PATCH] Specific crirc log file time stamp fomrmat > > The time stamp format in the chat buffer may now > differ from the format in the log files. > * doc/misc/rcirc.texi: Document new variable > * lisp/net/rcirc.el (rcirc-log-time-format): > Custom variable for the format. > > Copyright-paperwork-exempt: yes > --- > doc/misc/rcirc.texi | 8 ++++++++ > etc/NEWS | 7 ++++++- > lisp/net/rcirc.el | 8 +++++++- > 3 files changed, 21 insertions(+), 2 deletions(-) > > diff --git a/doc/misc/rcirc.texi b/doc/misc/rcirc.texi > index 6b10d1ab2a4..aa424d8e164 100644 > --- a/doc/misc/rcirc.texi > +++ b/doc/misc/rcirc.texi > @@ -929,6 +929,7 @@ Changing the time stamp format > @cindex date time > @cindex format time stamp > @vindex rcirc-time-format > +@vindex rcirc-log-time-format > > @code{rcirc-time-format} is the format used for the time stamp. Here's > how to include the date in the time stamp: > @@ -937,6 +938,13 @@ Changing the time stamp format > (setopt rcirc-time-format "%Y-%m-%d %H:%M ") > @end example > > +@code{rcirc-log-time-format} is the format used for the time stamp > +in the log files. Here's how to use month and day in the time stamp: > + > +@example > +(setopt rcirc-log-time-format "%m-%d %H:%M ") > +@end example I don't think the example here is necessary, nor does duplicating the previous paragraph sound nice IMO. It should suffice to just mention the user option in a sentence like "For log files, a different time format can be specified using the `rcirc-log-time-format' user option." > @findex rcirc-when > If you don't wish to use verbose time formatting all the time, you can > use the @code{rcirc-when} command to display a complete timestamp for > diff --git a/etc/NEWS b/etc/NEWS > index da00ea9dbda..44cbf21a3d3 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -1077,11 +1077,16 @@ For links in 'webjump-sites' without an explicit URI scheme, it was > previously assumed that they should be prefixed with "http://". Such > URIs are now prefixed with "https://" instead. > > ---- > + > *** 'bug-reference-mode' now supports 'thing-at-point'. > Now, calling '(thing-at-point 'url)' when point is on a bug reference > will return the URL for that bug. > > + You don't need to add these empty newlines before each header. > +*** Specific timestamp format for crirc log files > +Now, the timestamp format in crirc chat buffers can differ from the > +timestamp format in the log files. > + > ** Customize > > +++ > diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el > index ecfeb9f8f84..6390d4dd284 100644 > --- a/lisp/net/rcirc.el > +++ b/lisp/net/rcirc.el > @@ -229,6 +229,12 @@ rcirc-time-format > Used as the first arg to `format-time-string'." > :type 'string) > > +(defcustom rcirc-log-time-format "%d-%b %H:%M " > + "Describes how timestamps are printed in the log files. > +Used as the first arg to `format-time-string'." > + :version "30.1" > + :type 'string ) > + > (defcustom rcirc-input-ring-size 1024 > "Size of input history ring." > :type 'integer) > @@ -2209,7 +2215,7 @@ rcirc-log > (parse-iso8601-time-string time t)))) > (unless (null filename) > (let ((cell (assoc-string filename rcirc-log-alist)) > - (line (concat (format-time-string rcirc-time-format time) > + (line (concat (format-time-string rcirc-log-time-format time) > (substring-no-properties > (rcirc-format-response-string process sender > response target text)) From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 19 17:22:46 2023 Received: (at 67597) by debbugs.gnu.org; 19 Dec 2023 22:22:46 +0000 Received: from localhost ([127.0.0.1]:37781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFiU1-0003EI-JI for submit@debbugs.gnu.org; Tue, 19 Dec 2023 17:22:46 -0500 Received: from mout02.posteo.de ([185.67.36.66]:52375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFiTy-0003E2-Df for 67597@debbugs.gnu.org; Tue, 19 Dec 2023 17:22:35 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 6BAB8240101 for <67597@debbugs.gnu.org>; Tue, 19 Dec 2023 23:22:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1703024544; bh=Clx7IDHF54GVo0gXRmK1Y189fOxaGVH7BIuwEVHAc8U=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=inuB4NmGV5lLYLJ32pLxeHWsdCs/CnPZZZa82LlUXpHUc7PHO1q2poQVXG2BWFVjD zixpZ6oL7y/rdalowX5s9EFvlMzTlbPC/lc/MSRL9hYh4TcW8N68FOTcHOOqM8yvho M3htfiAKnTKarRSGU4Z62P4EbBIuBaLbJazdOMXYha1gvMihQ3yk1DHc8Knb6WLU27 jDR6pVj0p3ANXyrs5znvsOjiY6FH7tyaIIMFZpYlnZ1J3JZIwxCeOrODuHR7bDS5ke SJE0RGI5E8QQcmWfc/82JvO1Ie7MTURf5JCaEjDNwF82Ie+pInjs6GXDeaKIRWLtKh GxbTLLnN0+2nA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Svrlz75pHz6tws; Tue, 19 Dec 2023 23:22:23 +0100 (CET) From: Philip Kaludercic To: Matto Fransen Subject: Re: bug#67597: [PATCH] Specific rcirc log file time stamp format In-Reply-To: <865y0ufjp8.fsf@werkplek.tradesystem.nl> (Matto Fransen's message of "Tue, 19 Dec 2023 13:41:39 +0100") References: <86plzo1hok.fsf@werkplek.tradesystem.nl> <87msuatort.fsf@posteo.net> <865y0ufjp8.fsf@werkplek.tradesystem.nl> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Tue, 19 Dec 2023 22:22:23 +0000 Message-ID: <87cyv196jk.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67597 Cc: 67597@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Matto Fransen writes: > On 16 December 2023 10:39 Philip Kaludercic, wrote: > Hi Philip, > > Thanks for reviewing my patch. > Based on your remarks, I created a new patch, see attached. Find my comments below. > Is it enough to send you this patch, or should I also send it > somehow to the mailinglist? (I have no experience what so ever > with sending patches) I have resent your message to the bug tracker and am responding here as well. Ideally you should always use wide replies when composing a response, then everyone involved gets the message and the conversation can be found in the archives. > Best regards, > > Matto > > From 31535c00e75a169b886789e39564617750448c29 Mon Sep 17 00:00:00 2001 > From: Matto Fransen > Date: Tue, 19 Dec 2023 13:14:33 +0100 > Subject: [PATCH] Specific rcirc log file time stamp fomrmat > > The time stamp format in the chat buffer may now > differ from the format in the log files. > * doc/misc/rcirc.texi: Document new variable > * lisp/net/rcirc.el (rcirc-log-time-format): > Custom variable for the format. > > Copyright-paperwork-exempt: yes > --- > doc/misc/rcirc.texi | 4 ++++ > etc/NEWS | 3 +++ > lisp/net/rcirc.el | 8 +++++++- > 3 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/doc/misc/rcirc.texi b/doc/misc/rcirc.texi > index 6b10d1ab2a4..d6cf9066918 100644 > --- a/doc/misc/rcirc.texi > +++ b/doc/misc/rcirc.texi > @@ -929,6 +929,7 @@ Changing the time stamp format > @cindex date time > @cindex format time stamp > @vindex rcirc-time-format > +@vindex rcirc-log-time-format > > @code{rcirc-time-format} is the format used for the time stamp. Here's > how to include the date in the time stamp: > @@ -937,6 +938,9 @@ Changing the time stamp format > (setopt rcirc-time-format "%Y-%m-%d %H:%M ") > @end example > > +For log files, a different time format can be specified using the > +`rcirc-log-time-format' user option. > + > @findex rcirc-when > If you don't wish to use verbose time formatting all the time, you can > use the @code{rcirc-when} command to display a complete timestamp for > diff --git a/etc/NEWS b/etc/NEWS > index 90ff23b7937..910db376458 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -1152,6 +1152,9 @@ URIs are now prefixed with "https://" instead. > *** 'bug-reference-mode' now supports 'thing-at-point'. > Now, calling '(thing-at-point 'url)' when point is on a bug reference > will return the URL for that bug. An empty line between these two entries is expected, I think I might have misphrased myself in my last message? > +*** Specific timestamp format for rcirc log files > +Now, the timestamp format in rcirc chat buffers can differ from the > +timestamp format in the log files. > > ** Customize > > diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el > index ecfeb9f8f84..6390d4dd284 100644 > --- a/lisp/net/rcirc.el > +++ b/lisp/net/rcirc.el > @@ -229,6 +229,12 @@ rcirc-time-format > Used as the first arg to `format-time-string'." > :type 'string) > > +(defcustom rcirc-log-time-format "%d-%b %H:%M " > + "Describes how timestamps are printed in the log files. > +Used as the first arg to `format-time-string'." > + :version "30.1" > + :type 'string ) > + > (defcustom rcirc-input-ring-size 1024 > "Size of input history ring." > :type 'integer) > @@ -2209,7 +2215,7 @@ rcirc-log > (parse-iso8601-time-string time t)))) > (unless (null filename) > (let ((cell (assoc-string filename rcirc-log-alist)) > - (line (concat (format-time-string rcirc-time-format time) > + (line (concat (format-time-string rcirc-log-time-format time) > (substring-no-properties > (rcirc-format-response-string process sender > response target text)) Looks fine otherwise. I can fix the above issue if nothing else pops up. Another discussion, which I might have forgotten to mention (?) is that it might be nice to generalise logging so that one might choose to write ones logs into a SQLite database. But I am guessing you are not interested in working on this, because you haven't signed the CA yet, right? From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 19 17:33:48 2023 Received: (at 67597) by debbugs.gnu.org; 19 Dec 2023 22:33:48 +0000 Received: from localhost ([127.0.0.1]:37785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFiep-00065C-CD for submit@debbugs.gnu.org; Tue, 19 Dec 2023 17:33:48 -0500 Received: from mout02.posteo.de ([185.67.36.142]:41477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFiOY-00034A-5o for 67597@debbugs.gnu.org; Tue, 19 Dec 2023 17:16:59 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id C604D240104 for <67597@debbugs.gnu.org>; Tue, 19 Dec 2023 23:16:48 +0100 (CET) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SvrdX2Jxtz6tsg for <67597@debbugs.gnu.org>; Tue, 19 Dec 2023 23:16:47 +0100 (CET) Resent-To: 67597@debbugs.gnu.org Resent-From: Philip Kaludercic Resent-Date: Tue, 19 Dec 2023 23:16:47 +0100 Resent-Message-ID: <87le9p96sw.fsf@posteo.net> Received: from proxy02.posteo.name ([127.0.0.1]) by dovecot15.posteo.name (Dovecot) with LMTP id eAnQEJeKgWV01AIAB3Nl4w for ; Tue, 19 Dec 2023 13:41:47 +0100 Received: from proxy02.posteo.de ([127.0.0.1]) by proxy02.posteo.name (Dovecot) with LMTP id y8GHIMyNgWXWAQIAGFAyLg ; Tue, 19 Dec 2023 13:41:47 +0100 Received: from mailin06.posteo.de (unknown [10.0.1.6]) by proxy02.posteo.de (Postfix) with ESMTPS id 4Svbt34cJkz120b for ; Tue, 19 Dec 2023 13:41:47 +0100 (CET) Received: from mx04.posteo.de (mailin06.posteo.de [127.0.0.1]) by mailin06.posteo.de (Postfix) with ESMTPS id 8C942215AB for ; Tue, 19 Dec 2023 13:41:47 +0100 (CET) X-Posteo-Spam-Status: v=1; e=base64; a=aes-256-gcm; d=iT40u+q51SKOaAE2F5XRf6XH3OsMEKybIC7MfnPS7htm0VDxWqjIfq05nVSkmGAm/VQ1RvaEd dg//5DulRGJWdOCRxEs0UALe5Vf6pscrvemUXxGC/UycMMEclBWwj85BnJLfCbu1tya1j7n7iEV MqM2Lu/EQ7UVj22kVzvIcRhWZ03oBap4OKkUQRjpJpYwWoH09zwpVW73IAbPeR9aO5gILTv8o/X AgtgS1VOVblu9FH/+T+YoXuBc9xHeGqFxHZnyXw== X-Posteo-Antispam-Signature: v=1; e=base64; a=aes-256-gcm; d=hrwZ0igSPOjhw9SYAK/St35f5x/2hR6yv6epHA2CiXX3wxUKFiHHwNMD48wy3+dfJHuwaG/eGWElMy7qc7mdGKFv0RsOJp99m44f+S2/9/qDR70kDfgykf7SJ7XQQTYVWe/Cq9or Authentication-Results: posteo.de; dmarc=none (p=none dis=none) header.from=matto.nl Authentication-Results: posteo.de; spf=tempfail smtp.mailfrom=matto.nl X-Posteo-TLS-Received-Status: TLSv1.3 Received: from werkplek.tradesystem.nl (195-240-159-36.fixed.kpn.net [195.240.159.36]) by mx04.posteo.de (Postfix) with ESMTPS id 4Svbt25d1yz11pc for ; Tue, 19 Dec 2023 13:41:46 +0100 (CET) Received: from werkplek.tradesystem.nl.tradesystem.nl (githost.tradesystem.nl [192.168.3.43]) by werkplek.tradesystem.nl (8.16.1/8.16.1) with ESMTPS id 3BJCfdgJ090423 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO) for ; Tue, 19 Dec 2023 13:41:40 +0100 (CET) (envelope-from matto@matto.nl) From: Matto Fransen To: Philip Kaludercic Subject: Re: bug#67597: [PATCH] Specific rcirc log file time stamp format References: <86plzo1hok.fsf@werkplek.tradesystem.nl> <87msuatort.fsf@posteo.net> Date: Tue, 19 Dec 2023 12:41:39 +0000 In-Reply-To: <87msuatort.fsf@posteo.net> (Philip Kaludercic's message of "Sat, 16 Dec 2023 10:39:18 +0000") Message-ID: <865y0ufjp8.fsf@werkplek.tradesystem.nl> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67597 X-Mailman-Approved-At: Tue, 19 Dec 2023 17:33:46 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain On 16 December 2023 10:39 Philip Kaludercic, wrote: Hi Philip, Thanks for reviewing my patch. Based on your remarks, I created a new patch, see attached. Is it enough to send you this patch, or should I also send it somehow to the mailinglist? (I have no experience what so ever with sending patches) Best regards, Matto --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Specific-rcirc-log-file-time-stamp-fomrmat.patch Content-Description: improved patch >From 31535c00e75a169b886789e39564617750448c29 Mon Sep 17 00:00:00 2001 From: Matto Fransen Date: Tue, 19 Dec 2023 13:14:33 +0100 Subject: [PATCH] Specific rcirc log file time stamp fomrmat The time stamp format in the chat buffer may now differ from the format in the log files. * doc/misc/rcirc.texi: Document new variable * lisp/net/rcirc.el (rcirc-log-time-format): Custom variable for the format. Copyright-paperwork-exempt: yes --- doc/misc/rcirc.texi | 4 ++++ etc/NEWS | 3 +++ lisp/net/rcirc.el | 8 +++++++- 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/doc/misc/rcirc.texi b/doc/misc/rcirc.texi index 6b10d1ab2a4..d6cf9066918 100644 --- a/doc/misc/rcirc.texi +++ b/doc/misc/rcirc.texi @@ -929,6 +929,7 @@ Changing the time stamp format @cindex date time @cindex format time stamp @vindex rcirc-time-format +@vindex rcirc-log-time-format @code{rcirc-time-format} is the format used for the time stamp. Here's how to include the date in the time stamp: @@ -937,6 +938,9 @@ Changing the time stamp format (setopt rcirc-time-format "%Y-%m-%d %H:%M ") @end example +For log files, a different time format can be specified using the +`rcirc-log-time-format' user option. + @findex rcirc-when If you don't wish to use verbose time formatting all the time, you can use the @code{rcirc-when} command to display a complete timestamp for diff --git a/etc/NEWS b/etc/NEWS index 90ff23b7937..910db376458 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1152,6 +1152,9 @@ URIs are now prefixed with "https://" instead. *** 'bug-reference-mode' now supports 'thing-at-point'. Now, calling '(thing-at-point 'url)' when point is on a bug reference will return the URL for that bug. +*** Specific timestamp format for rcirc log files +Now, the timestamp format in rcirc chat buffers can differ from the +timestamp format in the log files. ** Customize diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index ecfeb9f8f84..6390d4dd284 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -229,6 +229,12 @@ rcirc-time-format Used as the first arg to `format-time-string'." :type 'string) +(defcustom rcirc-log-time-format "%d-%b %H:%M " + "Describes how timestamps are printed in the log files. +Used as the first arg to `format-time-string'." + :version "30.1" + :type 'string ) + (defcustom rcirc-input-ring-size 1024 "Size of input history ring." :type 'integer) @@ -2209,7 +2215,7 @@ rcirc-log (parse-iso8601-time-string time t)))) (unless (null filename) (let ((cell (assoc-string filename rcirc-log-alist)) - (line (concat (format-time-string rcirc-time-format time) + (line (concat (format-time-string rcirc-log-time-format time) (substring-no-properties (rcirc-format-response-string process sender response target text)) -- 2.42.0 --=-=-= Content-Type: text/plain > Matto Fransen writes: > >> Tags: patch >> >> Allows the time stamp in crirc log files to differ from > ^ > "rcirc"; you appear to make this typo a few > more times below. > 8< --snip-- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 20 15:30:39 2023 Received: (at 67597-done) by debbugs.gnu.org; 20 Dec 2023 20:30:40 +0000 Received: from localhost ([127.0.0.1]:41874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rG3DD-0000LY-FC for submit@debbugs.gnu.org; Wed, 20 Dec 2023 15:30:39 -0500 Received: from mout01.posteo.de ([185.67.36.65]:37199) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rG3DA-0008VT-EV for 67597-done@debbugs.gnu.org; Wed, 20 Dec 2023 15:30:38 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id CC98B240028 for <67597-done@debbugs.gnu.org>; Wed, 20 Dec 2023 21:30:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1703104226; bh=EwD/MgDTw58fexgGzBNsy3gQtxoAKbWvPWwsQT8XhJM=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=bbRf6rW3ezenaDxnMr9BnJmFpNtNR6JBVJKyRxp4b/ZC3MeVaIjx4f2yZT6QSSvck jp9mwcaFXu69Wz9ka7KQGzlgyJ/2xFWIY5oqjkiKfxf7sgNcEgJnyfODoK/1xK+jan 1FBtBTXOfkZxInSkATCJuzzKLhXFozUbYoILTBMUoXlp3wZFHM+TA18UiyTB8VxNPX oG24Ar4IWccvQBD/47WIBW8DQFhRc+V9yJO1APH1ShH/n3FJ4/KjCpj7ifpb6PBu8c buTyncm7ZJSewiTqGCn4CBqrTPzBqbCAqA8bkhpD0w46qFWlPedBMSsHQMV6vScAt+ 9t2yf/y5MOAdA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SwQDL0frNz6tv5; Wed, 20 Dec 2023 21:30:25 +0100 (CET) From: Philip Kaludercic To: Matto Fransen Subject: Re: bug#67597: [PATCH] Specific rcirc log file time stamp format In-Reply-To: <865y0ufjp8.fsf@werkplek.tradesystem.nl> (Matto Fransen's message of "Tue, 19 Dec 2023 12:41:39 +0000") References: <86plzo1hok.fsf@werkplek.tradesystem.nl> <87msuatort.fsf@posteo.net> <865y0ufjp8.fsf@werkplek.tradesystem.nl> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Wed, 20 Dec 2023 20:30:24 +0000 Message-ID: <875y0sborj.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67597-done Cc: 67597-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) The patch has been applied with minor changes and pushed to master. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 11 15:23:47 2024 Received: (at control) by debbugs.gnu.org; 11 Jan 2024 20:23:47 +0000 Received: from localhost ([127.0.0.1]:34008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO1ac-00084u-TK for submit@debbugs.gnu.org; Thu, 11 Jan 2024 15:23:47 -0500 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]:58731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO1ab-00084f-Cw for control@debbugs.gnu.org; Thu, 11 Jan 2024 15:23:46 -0500 Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2cd46e7ae8fso64838851fa.1 for ; Thu, 11 Jan 2024 12:23:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705004622; x=1705609422; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=XvNkPRV7DOPiQXjiwnElYh31W6V1IjmSU0qDLjVVHVI=; b=NOpuZOVJuKZsIMRltPx95Vk3VYxSMCoTv0Gc83mv1UMFvUthDDskmHRaH6xIq+UC6h l+Gmyd2mmpfppWj0LEKGdDKXRV6Zaqm0qVUHc+CVl6QzAzKoHoDAwNEu9cfzQ2qL1K4g egtGgpZIO+vH/BSrhWuprcabgTMWhDl54kK0QRaW/5mxiYfCumhTBUFn/fisv0Chq3pW cFws04VqVK3dR8Cm4oh4+Wrskgk/QOk75xDxOd68kOS8AnKCvOYfj67jBir+tbovBuHy DPfTd8/SP58K2qqNmwqMQZm0jRKRhDgKkEEx5rvJ0PELX5HKYOAq8xhxndf80yee0H6q p1xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705004622; x=1705609422; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XvNkPRV7DOPiQXjiwnElYh31W6V1IjmSU0qDLjVVHVI=; b=ApP3g8Yfk8kewnS9p2+ZPm50YwepV7fK0FGYmFIPFSajgIPpGJTK0K2YBHZgJY+KoM ZUzYQEcP7jzEU1fyXG718zF4OI5+vY8mgXSzu4DPGTZBw65uhqq1E1pD8glymjU3DYHv LjukArUZeQxT3ma5fuGDZPsBKCxx1n+X5EtI7YOIkunNiOEEVUSlAlAYvuQ3h9efEbvb 4CpViIYevuw4YbjxbGxZoBy/i5loLCmA6SMIXxdopr9qZFmyndCDajuLVXHxBHN9C9GK QRFgA53LiryNQkcoNP5Xdv0FbghAP5LmYhaxeo9NVGq2hMPVm3u97Kadhx6Zpn+MH32l Gr2A== X-Gm-Message-State: AOJu0Yyre3ZSc9zC35maQgPRMWuEWDgyh3ZWtSAbkSvf/uJLrDT62tjE ilpqwvg6wODYNAPeYNdTbL5DZrAUoUc8ICN0yp8= X-Google-Smtp-Source: AGHT+IEEl1gLsLfcxyf1exbW9MNjwRNs6ZCqVGwdmaeoJtZLQkKnwfeuoHUbsNKoDvrpoybi0vcZHhkD8/wL6IDnGvQ= X-Received: by 2002:a2e:9e02:0:b0:2cd:87c3:3846 with SMTP id e2-20020a2e9e02000000b002cd87c33846mr86368ljk.161.1705004621482; Thu, 11 Jan 2024 12:23:41 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 11 Jan 2024 12:23:41 -0800 From: Stefan Kangas In-Reply-To: <87ttnkpaiv.fsf@posteo.net> References: <87o7hk124k.fsf@gmail.com> <87v881uhxe.fsf@posteo.net> <87ttnkpaiv.fsf@posteo.net> MIME-Version: 1.0 Date: Thu, 11 Jan 2024 12:23:41 -0800 Message-ID: Subject: Re: bug#66276: Use a seperate time format in rcirc logfiles To: Philip Kaludercic Content-Type: text/plain; charset="UTF-8" Bcc: control@debbugs.gnu.org X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control Cc: 66276@debbugs.gnu.org, Thuna X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) unarchive 67597 forcemerge 67597 66276 thanks Philip Kaludercic writes: > Stefan Kangas writes: > >> So what should we do with this one? Close? > > We can close it. Does it also have to be marked as duplicate? Thanks. It won't hurt to merge the bugs (our way of marking it as a duplicate), so I did that above. From unknown Sun Jun 15 08:50:11 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 09 Feb 2024 12:24:16 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator