GNU bug report logs - #67582
[PATCH gnome-team 0/4] Update python-dbusmock

Previous Next

Full log

Message #43 received at 67582-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: rg <at> raghavgururajan.name, 67582-done <at> debbugs.gnu.org
Subject: Re: [bug#67582] [PATCH gnome-team 2/4] gnu: Add python-dbus-python.
Date: Tue, 19 Dec 2023 23:54:39 +0100

Am Sonntag, dem 03.12.2023 um 14:06 -0500 schrieb Maxim Cournoyer:
> Hi,
> 
> Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
> 
> > Am Sonntag, dem 03.12.2023 um 12:19 -0500 schrieb Maxim Cournoyer:
> > > Hello,
> > > 
> > > Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
> > > 
> > > > * gnu/packages/python-xyz.scm (python-dbus-python): New
> > > > variable.
> > > 
> > > [...]
> > > 
> > > > +(define-public python-dbus-python
> > > > +  (package
> > > > +  (name "python-dbus-python")
> > > > +  (version "1.3.2")
> > > > +  (source
> > > > +   (origin
> > > > +     (method url-fetch)
> > > > +     (uri (pypi-uri "dbus-python" version))
> > > > +     (sha256
> > > > +      (base32
> > > > "1y28h90v2ib8zqhs3r2yr7ycg8ccwvw3gqkvadlm12v1129q2rxd"))))
> > > > +  (build-system pyproject-build-system)
> > > > +  (arguments
> > > > +   (list #:phases #~(modify-phases %standard-phases
> > > > +                      (add-after 'unpack 'patch-requirements
> > > > +                        (lambda _
> > > > +                          (substitute* (list "pyproject.toml"
> > > > "setup.py")
> > > > +                            (("'(ninja|patchelf)',?") ""))
> > > > +                          (substitute* "setup.cfg"
> > > > +                            (("(ninja|patchelf)") "")))))))
> > > > +  (inputs (list dbus glib))
> > > > +  (propagated-inputs (list python-pygobject))
> > > > +  (native-inputs (list pkg-config
> > > > +                       python-meson-python
> > > > +                       meson ninja patchelf
> > > > +                       python-sphinx python-sphinx-rtd-theme
> > > > +                       python-tappy
> > > > +                       python-wheel))
> > > 
> > > Is this 'guix style' produced?  The convention is to use:
> > > 
> > > (native-inputs
> > >  (list one
> > >        two
> > >        ...))
> > > 
> > > When there are more than 5 inputs (or if they don't fit on a
> > > single line).
> > I manually grouped them by theme.
> 
> I see.  I'd still prefer the conventional sorted flat list, because
> the next person touching it probably won't notice and break that
> logic.
We can still break it when the next person touches it, so that's fine
by me :)

Pushed, along with the rest.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.