GNU bug report logs - #67569
29.1; ruby-mode syntax highlighting breaks with variable named "index" and "/" operator

Previous Next

Full log

View this message in rfc822 format

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: mjh <at> mjhoy.com, 67569 <at> debbugs.gnu.org
Subject: bug#67569: 29.1; ruby-mode syntax highlighting breaks with variable named "index" and "/" operator
Date: Sat, 9 Dec 2023 19:38:28 +0200

[Message part 1 (text/plain, inline)]

On 09/12/2023 16:35, Eli Zaretskii wrote:
>> Date: Sat, 9 Dec 2023 16:13:02 +0200
>> From: Dmitry Gutov<dmitry <at> gutov.dev>
>>
>> Eli, should we put this in Emacs 29.2? It's not a regression (a fairly
>> old problem), but the fix looks simple enough.
> Yes, please.

Very good, pushed to emacs-29.

Here's a second patch on top which gets rid of the whitelist altogether 
(the new heuristic seems to cover the cases better anyway), though I'm 
on the fence whether this should go here or into master.

It seems to work well with some testing, but it is more adventurous than 
the previous one.

[ruby-parenless-regexp-no-whitelist.diff (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.