GNU bug report logs - #67568
Emacs master: Bug in byte compiler when there's an unused parameter.

Previous Next

Full log

Message #20 received at 67568 <at> debbugs.gnu.org (full text, mbox):

From: Alan Mackenzie <acm <at> muc.de>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Dmitry Gutov <dmitry <at> gutov.dev>, acm <at> muc.de, 67568 <at> debbugs.gnu.org
Subject: Re: bug#67568: Emacs master: Bug in byte compiler when there's an
 unused parameter.
Date: Fri, 1 Dec 2023 16:34:18 +0000

Hello, Stefan.

On Fri, Dec 01, 2023 at 10:40:55 -0500, Stefan Monnier wrote:
> > I have a candidate for the buggy function, namely macroexp-parse-body.

> Duh!
> I think the patch below should fix it.

It certainly will in the test case, yes.

I think I understand the function better now, thanks.

Are you going to commit your patch, or should I?  :-)

>         Stefan


> diff --git a/lisp/emacs-lisp/macroexp.el b/lisp/emacs-lisp/macroexp.el
> index 6eb670d6dc1..6ed3e0c4896 100644
> --- a/lisp/emacs-lisp/macroexp.el
> +++ b/lisp/emacs-lisp/macroexp.el
> @@ -540,7 +540,9 @@ macroexp-parse-body
>        (while
>            (and body
>                 (let ((e (car body)))
> -                 (or (stringp e)
> +                 (or (and (stringp e)
> +                          ;; Only the first string can be a docstring.
> +                          (not (delq nil (mapcar #'stringp decls))))
>                       (memq (car-safe e)
>                             '(:documentation declare interactive cl-declare)))))
>          (push (pop body) decls)))

-- 
Alan Mackenzie (Nuremberg, Germany).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.