GNU bug report logs - #67564
[PATCH 0/3] Fixes for haskell importers

Previous Next

Package: guix-patches;

Reported by: Saku Laesvuori <saku <at> laesvuori.fi>

Date: Fri, 1 Dec 2023 09:27:02 UTC

Severity: normal

Tags: patch

Done: Lars-Dominik Braun <lars <at> 6xq.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Lars-Dominik Braun <lars <at> 6xq.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#67564: closed ([PATCH 0/3] Fixes for haskell importers)
Date: Sun, 03 Dec 2023 08:15:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sun, 3 Dec 2023 09:13:46 +0100
with message-id <ZWw4ugrDqSk9eU0v <at> noor.fritz.box>
and subject line Re: [bug#67564] [PATCH 0/3] Fixes for haskell importers
has caused the debbugs.gnu.org bug report #67564,
regarding [PATCH 0/3] Fixes for haskell importers
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
67564: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67564
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Saku Laesvuori <saku <at> laesvuori.fi>
To: guix-patches <at> gnu.org
Cc: Saku Laesvuori <saku <at> laesvuori.fi>
Subject: [PATCH 0/3] Fixes for haskell importers
Date: Fri,  1 Dec 2023 11:24:57 +0200
The first two patches fix crashes in the hackage[1] and stackage
importers.

The third patch improves the cabal file parser so that it can parse a
larger subset of valid cabal files[2]. It fixes guix refresh for 7
packages in Guix.

[1]: https://issues.guix.gnu.org/64734
[2]: https://issues.guix.gnu.org/35743

Saku Laesvuori (3):
  guix: import: hackage: Fix crash on recursive import
  guix: import: stackage: Fix crash on recursive import
  guix: import: Parse cabal layout blocks correctly

 guix/import/cabal.scm    | 42 ++++++++++++++++++----------------------
 guix/import/hackage.scm  |  2 +-
 guix/import/stackage.scm |  2 +-
 3 files changed, 21 insertions(+), 25 deletions(-)


base-commit: cd46757c1a0f886848fbb6828c028dd2a2532767
-- 
2.41.0



[Message part 3 (message/rfc822, inline)]
From: Lars-Dominik Braun <lars <at> 6xq.net>
To: Saku Laesvuori <saku <at> laesvuori.fi>
Cc: 67564-done <at> debbugs.gnu.org
Subject: Re: [bug#67564] [PATCH 0/3] Fixes for haskell importers
Date: Sun, 3 Dec 2023 09:13:46 +0100
Hi,

> Done in v2. There was already a test for this that was expected to fail.
> I just marked it to be expected to pass instead.

yes, you’re right. Merged as:

5bd00bb54235856dddd11e9f0d03481c5469ca63 guix: import: Parse cabal layout blocks correctly
acef524961d4da3464dbc392699fbe7deb0a467b guix: import: stackage: Fix crash on recursive import
160385c013b0403af427b61b1d1cc9a75bc3315d guix: import: hackage: Fix crash on recursive import

Thanks you very much!
Lars



This bug report was last modified 1 year and 171 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.