GNU bug report logs - #67556
29.1; java-ts-mode doesn't indent open curly brackets properly

Previous Next

Package: emacs;

Reported by: Spencer Pavkovic <spavkov <at> ilstu.edu>

Date: Fri, 1 Dec 2023 01:35:02 UTC

Severity: normal

Found in version 29.1

Done: Dmitry Gutov <dmitry <at> gutov.dev>

Bug is archived. No further changes may be made.

Full log


Message #41 received at 67556 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Eli Zaretskii <eliz <at> gnu.org>, theo <at> thornhill.no, casouri <at> gmail.com
Cc: spavkov <at> ilstu.edu, 67556 <at> debbugs.gnu.org
Subject: Re: bug#67556: 29.1; java-ts-mode doesn't indent open curly brackets
 properly
Date: Mon, 12 Feb 2024 00:42:50 +0200
[Message part 1 (text/plain, inline)]
On 11/02/2024 10:43, Eli Zaretskii wrote:
> Ping! Ping! Ping! Yuan and Theo, could you please chime in?

Here's a minimal patch, consisting of a new rule and a couple of 
replacements where the new standalone-parent anchor is used instead of 
the helper c-ts-common-statement-offset.

Because the latter behaves differently when the opening curly is on a 
separate line, and we don't really want that.

A more finished change will likely either switch over to 
standalone-parent completely, or go back and revamp 
c-ts-common-statement-offset to avoid this distinction (despite the 
name, it only remains in use in java-ts-mode these days).

The former has been a simpler route so far, so I suggest we at least 
commit the attached.
[java-ts-mode-indent.diff (text/x-patch, attachment)]

This bug report was last modified 1 year and 93 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.