GNU bug report logs - #6754
TIME_WITH_SYS_TIME in nt/config.nt and src/s/ms-w32.h

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6754 in the body.
You can then email your comments to 6754 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: TIME_WITH_SYS_TIME in nt/config.nt and src/s/ms-w32.h
Date: Thu, 29 Jul 2010 11:59:15 -0400

nt/config.nt:#undef TIME_WITH_SYS_TIME

src/s/ms-w32.h:#define TIME_WITH_SYS_TIME 1

These seems to contradict each other. Aren't these files used on the same platform?

Message #6 received at 6754 <at> debbugs.gnu.org (full text, mbox):

From: Óscar Fuentes <ofv <at> wanadoo.es>
To: Dan Nicolaescu <dann <at> gnu.org>
Cc: 6754 <at> debbugs.gnu.org
Subject: Re: bug#6754: TIME_WITH_SYS_TIME in nt/config.nt and src/s/ms-w32.h
Date: Thu, 29 Jul 2010 18:40:33 +0200

Dan Nicolaescu <dann <at> gnu.org> writes:

> nt/config.nt:#undef TIME_WITH_SYS_TIME
>
> src/s/ms-w32.h:#define TIME_WITH_SYS_TIME 1
>
> These seems to contradict each other. Aren't these files used on the
> same platform?

Yes.

It is clear that config.nt and msw-32.h are trying to be the same.

Message #9 received at 6754 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dan Nicolaescu <dann <at> gnu.org>
Cc: 6754 <at> debbugs.gnu.org
Subject: Re: bug#6754: TIME_WITH_SYS_TIME in nt/config.nt and src/s/ms-w32.h
Date: Thu, 29 Jul 2010 20:55:31 +0300

> From: Dan Nicolaescu <dann <at> gnu.org>
> Date: Thu, 29 Jul 2010 11:59:15 -0400
> Cc: 
> 
> 
> nt/config.nt:#undef TIME_WITH_SYS_TIME
> 
> src/s/ms-w32.h:#define TIME_WITH_SYS_TIME 1
> 
> These seems to contradict each other. Aren't these files used on the same platform?

It seems to be a left-over from long ago.  Once upon a time, Windows
headers didn't have sys/time.h (MSVC still doesn't, but MinGW now
does), so nt/config.nt disabled its use.  Later, nt/inc/sys/time.h was
added to work around this, but the #undef was not removed.  Since
ms-w32.h is included _after_ the #undef, it did no harm.

Bottom line: the #undef in config.nt can be removed.

Message #14 received at 6754-done <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Dan Nicolaescu <dann <at> gnu.org>, 6754-done <at> debbugs.gnu.org
Subject: Re: bug#6754: TIME_WITH_SYS_TIME in nt/config.nt and src/s/ms-w32.h
Date: Tue, 3 Aug 2010 01:24:47 +0200

On Thu, Jul 29, 2010 at 19:55, Eli Zaretskii <eliz <at> gnu.org> wrote:

> Bottom line: the #undef in config.nt can be removed.

Done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.