GNU bug report logs - #67536
29.1; Calc mode's math-read-preprocess-string conses unnecessarily

Previous Next

Package: emacs;

Reported by: Raffael Stocker <r.stocker <at> mnet-mail.de>

Date: Wed, 29 Nov 2023 21:32:02 UTC

Severity: normal

Found in version 29.1

Done: Mattias Engdegård <mattias.engdegard <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #26 received at 67536 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Raffael Stocker <r.stocker <at> mnet-mail.de>,
 Mattias Engdegård <mattiase <at> acm.org>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 67536 <at> debbugs.gnu.org
Subject: Re: bug#67536: 29.1; Calc mode's math-read-preprocess-string conses
 unnecessarily
Date: Sat, 02 Dec 2023 10:03:53 +0200

> From: Raffael Stocker <r.stocker <at> mnet-mail.de>
> Cc: 67536 <at> debbugs.gnu.org
> Date: Fri, 01 Dec 2023 22:10:22 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> I use cl-flet and (eval-when-compile (require 'cl-lib)).  I hope that is
> >> ok.
> >
> > I'd prefer a simple internal function, or a lambda.
> 
> I went with the lambda, it is the more concise choice.
> 
> >> +      (buffer-string))))
> >
> > I think buffer-substring-no-properties would be better than
> > buffer-string, as we don't need to copy any text properties, right?
> 
> Yes, indeed.  I fixed that too.

Thanks.

Mattias, any comments, or should I install this?
This bug report was last modified 1 year and 155 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.