GNU bug report logs - #67533
SVG images confound position pixel measurements

Previous Next

Package: emacs;

Reported by: JD Smith <jdtsmith <at> gmail.com>

Date: Wed, 29 Nov 2023 20:33:01 UTC

Severity: normal

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: 67533 <at> debbugs.gnu.org, jdtsmith <at> gmail.com
Subject: bug#67533: SVG images confound position pixel measurements
Date: Fri, 01 Dec 2023 16:55:47 +0200
> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
> Cc: JD Smith <jdtsmith <at> gmail.com>,  67533 <at> debbugs.gnu.org
> Date: Fri, 01 Dec 2023 15:40:59 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Does the patch below fix the issue?  (It should fix the recipe you
> > posted, but you hinted that this is just the simplest way of seeing a
> > more general problem, so I wonder whether that more general problem is
> > also fixed.)
> 
> Hi,
> 
> I have applied your patch to master and here are the results I get with
> the recipe at the end of this message:
> 
> With a not large enough window:
>   FIRST LINE: (925 24 1); ABOVE IMAGE: (925 24 119)
> 
> With a large enough window (i.e., that can display the whole first
> line):
>   FIRST LINE: (1053 24 1); ABOVE IMAGE: (1062 24 119)

If you think these results still show a problem, please elaborate.
Since you did this on your system, with your fonts and frame
dimensions, I cannot know whether the numbers are correct or not.

The patch I posted is supposed to fix only one issue: the fact that
the Y-dimension of the line above the image was shown as zero.  AFAIU,
it is indeed not zero in the output you show above.

Btw, I wonder what you and JD expect from the (cons (point) -1)
argument.  The doc string says:

  If FROM is a cons, its car specifies a buffer position, and its cdr
  specifies the vertical offset in pixels from that position to the
  first screen line to be measured.

What is the meaning of negative offset from the first line of the
buffer? there's no screen line at that offset, so what do you expect
that to do?  Or what am I missing?




This bug report was last modified 1 year and 156 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.