GNU bug report logs - #67527
30.0.50; FR: Add an option to disable ispell completion in text-mode

Previous Next

Full log

Message #65 received at 67527 <at> debbugs.gnu.org (full text, mbox):

From: Eshel Yaron <me <at> eshelyaron.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Daniel Mendler <mail <at> daniel-mendler.de>, aqua0210 <at> foxmail.com,
 67527 <at> debbugs.gnu.org, simon <at> ecksd.com
Subject: Re: bug#67527: 30.0.50; FR: Add an option to disable ispell
 completion in text-mode
Date: Sat, 20 Jan 2024 12:33:25 +0100

[Message part 1 (text/plain, inline)]

Hi,

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Daniel Mendler <mail <at> daniel-mendler.de>
>>
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>
>> >> From: Daniel Mendler <mail <at> daniel-mendler.de>
>> >>
>> >> Eli Zaretskii <eliz <at> gnu.org> writes:
>> >>
>> >> > Eshel, given this feedback, I think it would make sense to add a new
>> >> > defcustom that would make text-mode avoid adding
>> >> > ispell-completion-at-point to completion-at-point-functions.  Would
>> >> > you please submit such a change and the documentation changes to go
>> >> > with it?  TIA.
>> >>
>> >> Maybe the existing defcustom `text-mode-meta-tab-ispell-complete-word'
>> >> could be renamed and reused, taking three values? This way we avoid
>> >> introducing multiple defcustoms for tweaking the same feature.
>> >>
>> >> - `command': Bind `ispell-complete-word' to TAB.
>> >> - `capf': Add `ispell-completion-at-point' to the
>> >>   `completion-at-point-functions'.
>> >> - `nil': None of the above.
>> >
>> > Reused, yes.  Renamed, I'd rather prefer we avoided that, as it causes
>> > compatibility problems.  If we can extend its list of valid values to
>> > support this aspect as well, it would be good.
>>
>> Iiuc the variable was introduced a short while ago on Emacs master, so
>> renaming it may still be possible?
>
> Oh, I think I confused it with another option.  Yes, if it was
> introduced recently on master, we can rename it.

SGTM, see attached patch below.

[0001-Optionally-avoid-extending-c-a-p-f-in-Text-mode-Bug-.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.