From unknown Wed Jun 18 23:11:09 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#67527 <67527@debbugs.gnu.org> To: bug#67527 <67527@debbugs.gnu.org> Subject: Status: 30.0.50; FR: Add an option to disable ispell completion in text-mode Reply-To: bug#67527 <67527@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:11:09 +0000 retitle 67527 30.0.50; FR: Add an option to disable ispell completion in te= xt-mode reassign 67527 emacs submitter 67527 Eason Huang severity 67527 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 29 05:32:28 2023 Received: (at submit) by debbugs.gnu.org; 29 Nov 2023 10:32:28 +0000 Received: from localhost ([127.0.0.1]:48970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8Hro-0002B6-1T for submit@debbugs.gnu.org; Wed, 29 Nov 2023 05:32:28 -0500 Received: from lists.gnu.org ([2001:470:142::17]:48490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8Hri-0002Al-K5 for submit@debbugs.gnu.org; Wed, 29 Nov 2023 05:32:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8HrV-0005s1-6l for bug-gnu-emacs@gnu.org; Wed, 29 Nov 2023 05:32:09 -0500 Received: from out203-205-221-164.mail.qq.com ([203.205.221.164]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8HrQ-0000je-8W for bug-gnu-emacs@gnu.org; Wed, 29 Nov 2023 05:32:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1701253912; bh=lDUTmEBtbUdevX3uaxhKC6eivySybMWpwCC9ZYRdrow=; h=From:To:Subject:Date; b=MGHsgt5TuZyS47sctwaSRdO2F/kyOya9TsgIZjb7fIO0olYG4ojE6IQ1pzEfce1O7 TOCiVV4zarj/d+Za1SlEJTiVIS1qSR1tXc5PtLWz4n1OYifZKGnhWfx26GUJkHp0mp lU06s6CzXy/DvcRnMH9D51k0llqgnSXt4pEhnrsY= Received: from macbook ([180.162.208.153]) by newxmesmtplogicsvrszb9-1.qq.com (NewEsmtp) with SMTP id 7F304C71; Wed, 29 Nov 2023 18:31:51 +0800 X-QQ-mid: xmsmtpt1701253911teblcbwbl Message-ID: X-QQ-XMAILINFO: NYXSVuwhoxRboDYAazYiv5Z/yNqE0y4kSHkevTvvuUTruxeZJDiClevwezoAl9 OAy4zMMWAq+6WxjaNQKpppEChZC6hs339VwVMPQotCeT8tjCQMPbdlZUW7cxNUx9YIx9bCOPtmN2 bjFcZy5+nV2jk25pFLKFPWkXwuTFPIUK6bAELRQrsel1Lb5Eb5NNAB3eCjMmsXuhOhpoItwoSlQV bH76RBGMSE1srSaZRo/rAewZMYDGcGZD7TSL+HGzqkAFvsp9mXTg/pYaFB6w9TZ6/XEtj1XMCzIz dy9/qKmcvGgJxNL2rTDRnXkAQ5VIMeP3Op4zuI0ssKbMkjiIw9zywlimRTYIFFQhqvlzOOu1CBjz fVF7rnTbNcTcUNbkztfzh3YWK8oB1j0PdVcHm1UeAmpjnBCO18D1xp3D6glf1PHxGKj7c+6Q9FPs UEv6wkEIpbrtW8XPN4CFRRC6ZFjtIKFhtd7+ILox5IlKDbfIVNvNso/o/v+AHvFKqdhBUcqy39js 3Q9SAEsIxuS2bPP8b7K8mv/G2okScLHI1/6y8RnUMT3dS0JHydJNEO8sv8mZzDEZ9fBU9VHDK5cB 0AYNkhd5NV8h29aLqgZz2cnIQQTErCgLbMmAK1Ew/c1/0lK9kLInLnXyeHvEnyAMCpKQw72RzZxE ZzGO8j9FntvXMiqp8sWERANewP3/fqR6IfVZWqcaK64ssjEVsEstwn0V3EG2NPq/ZBO+F2v81q+W fgMdwenco6RBUPrVUpVzWUkeRAsbgYU3INn0LNCaY+fVEUJk3p+tQSkQu24orX9xZ+bl+NuZpeZt TFx3/kAQvUKG+VMoSrwGxlOZDhEQD6jgVU4pO6h4AirP1OMunMW5UfNymHbJQUOYjl4Qo+kCL2Ui 1fmTqPKLqrrA8BAOfx0o6dnghNmgvkKCwtMnUmyiL+37bFFTCYj+J0Nf9fKzLG/46vCjh7qJ413X s7iAOD4GxbQScFg6QMEA== X-QQ-XMRINFO: MPJ6Tf5t3I/ycC2BItcBVIA= From: Eason Huang To: bug-gnu-emacs@gnu.org Subject: 30.0.50; FR: Add an option to disable ispell completion in text-mode Date: Wed, 29 Nov 2023 18:31:43 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=203.205.221.164; envelope-from=aqua0210@foxmail.com; helo=out203-205-221-164.mail.qq.com X-Spam_score_int: 11 X-Spam_score: 1.1 X-Spam_bar: + X-Spam_report: (1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HELO_DYNAMIC_IPADDR=1.951, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello Emacs Dev team, In the below commit, Emacs support ispell-completion-at-point in text-mode. https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=47e313e9805c527e590df4270062a9185ee9db78 Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (aqua0210[at]foxmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (aqua0210[at]foxmail.com) -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Hello Emacs Dev team, In the below commit, Emacs support ispell-completion-at-point in text-mode. https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=47e313e9805c527e590df4270062a9185ee9db78 But it would be nice to add an option to disable this feature. Because when I enable the autocomplete by corfu or company, it will always popup the candidate when I input English charectors. I don't want to diable the autocomplete of corfu or company, because I need it in org code block. Workaroud: Recently, I have to add this code snippet to disable it. ``` (with-eval-after-load 'org (add-hook 'text-mode-hook (lambda () (remove-hook 'completion-at-point-functions 'ispell-completion-at-point t)))) ``` Best Regard, Eason Huang In GNU Emacs 30.0.50 (build 1, x86_64-apple-darwin23.1.0, NS appkit-2487.20 Version 14.1.1 (Build 23B81), git sha1 7a5c91a2831) of 2023-11-28 built on macbook Windowing system distributor 'Apple', version 10.3.2487 System Description: macOS 14.1.1 Configured using: 'configure --without-native-compilation --without-dbus 'CPPFLAGS=-I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk' 'LDFLAGS=-L/opt/local/lib -Wl,-headerpad_max_install_names -Wl,-rpath /opt/local/lib/gcc13 -Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk -arch x86_64'' Configured features: ACL GIF GLIB GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM ZLIB Important settings: value of $LC_CTYPE: en_US.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 38070 9043) (symbols 48 5115 0) (strings 32 13097 2341) (string-bytes 1 375591) (vectors 16 10489) (vector-slots 8 163580 14202) (floats 8 21 23) (intervals 56 239 0) (buffers 992 10)) From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 29 08:18:33 2023 Received: (at 67527) by debbugs.gnu.org; 29 Nov 2023 13:18:33 +0000 Received: from localhost ([127.0.0.1]:49113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8KSX-0006PS-4z for submit@debbugs.gnu.org; Wed, 29 Nov 2023 08:18:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8KSU-0006PF-PN for 67527@debbugs.gnu.org; Wed, 29 Nov 2023 08:18:31 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8KSE-00040Y-Tu; Wed, 29 Nov 2023 08:18:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=y7mKnudZ0+P99MsHf4fYJ9FziJwQqzJnUzoZgNhYcjY=; b=WGRVAEeE4E3O atiSzfWJCGNoNE2kK4NxVrY7ZsoHLULluVy0f7oagG+FhTem03fkBIz/137lfPTFNlaN9w/DTOc0y YKfq+3nTgIeZaQA5rvIk1MnIErFRWcXFf8Sp9Cfsx2ai8sWmdGyMIZVmYx20QUyo1wpsrnUNgFs9O y3cfqQvevBpexT4PF8ys5PcO32M1bLGclE5UvH5vNQfrk+X40bL79HQ7ujW2M5i1QkCNWQwTiI3Y6 lr93Xm24ZFA2sYY70sSYqcN0673ErgJt3ThA2Gfd9z0mGHyj1AhRJjURGT5vGFEhUXJJu/GU6UHpa oCtDc0vLCoErevp2Dbx/5g==; Date: Wed, 29 Nov 2023 15:18:05 +0200 Message-Id: <83fs0o7l6a.fsf@gnu.org> From: Eli Zaretskii To: Eason Huang , Eshel Yaron In-Reply-To: (message from Eason Huang on Wed, 29 Nov 2023 18:31:43 +0800) Subject: Re: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67527 Cc: 67527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Eason Huang > Date: Wed, 29 Nov 2023 18:31:43 +0800 > > Hello Emacs Dev team, > > In the below commit, Emacs support ispell-completion-at-point in > text-mode. > > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=47e313e9805c527e590df4270062a9185ee9db78 > > But it would be nice to add an option to disable this feature. > > Because when I enable the autocomplete by corfu or company, it will > always popup the candidate when I input English charectors. > I don't want to diable the autocomplete of corfu or company, because I > need it in org code block. > > > Workaroud: > > Recently, I have to add this code snippet to disable it. > > ``` > (with-eval-after-load 'org > (add-hook 'text-mode-hook > (lambda () > (remove-hook 'completion-at-point-functions 'ispell-completion-at-point t)))) > ``` Adding Eshel to this discussion. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 29 08:45:46 2023 Received: (at 67527) by debbugs.gnu.org; 29 Nov 2023 13:45:46 +0000 Received: from localhost ([127.0.0.1]:49150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8Ksr-0001KB-Rx for submit@debbugs.gnu.org; Wed, 29 Nov 2023 08:45:46 -0500 Received: from mail.eshelyaron.com ([107.175.124.16]:58826 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8Ksq-0001K3-4P for 67527@debbugs.gnu.org; Wed, 29 Nov 2023 08:45:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1701265536; bh=iw2pJQVRd6WKtys7DV7woHgDMJ2+H9gOZVxrqldl4R8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=cGs/iIIP6rkJqBeBIVPWwvqt+BjnHx34zVeu4E60wyWT3GskuklVCT6ThkRH8zIgQ 6MCRf6kNSZmyPq8qo5F5BmdwYqaZUR+6Tg52avZ1e58KvCMd047sWn+qbaGPueX/NT DvR2DoFgld36uFpz6rmMs/J6Or+8Woge/kb6jL8H1vRh2nuemJfo9v83cXaEywC1cv A4ThTdfCyCEyQ8MjNv+HvPteYUbMRYOaXYA8pfmxjr0FHRC2KCwrkuMfLiQ40grlDd wgJaU+85K+JnPvWX8krzERFNfgw39uqsGrQHaUHtG8Wn8/HQS/CB01a2dGRCVKUhnf 8rEQVL5G24N9g== From: Eshel Yaron To: Eli Zaretskii Subject: Re: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode In-Reply-To: <83fs0o7l6a.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 29 Nov 2023 15:18:05 +0200") References: <83fs0o7l6a.fsf@gnu.org> Date: Wed, 29 Nov 2023 14:45:33 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67527 Cc: Eason Huang , 67527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Eason Huang >> >> In the below commit, Emacs support ispell-completion-at-point in >> text-mode. >> >> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=47e313e9805c527e590df4270062a9185ee9db78 >> >> But it would be nice to add an option to disable this feature. >> >> Because when I enable the autocomplete by corfu or company, it will >> always popup the candidate when I input English charectors. >> I don't want to diable the autocomplete of corfu or company, because I >> need it in org code block. >> >> >> Workaroud: >> >> Recently, I have to add this code snippet to disable it. >> >> ``` >> (with-eval-after-load 'org >> (add-hook 'text-mode-hook >> (lambda () >> (remove-hook 'completion-at-point-functions 'ispell-completion-at-point t)))) >> ``` > > Adding Eshel to this discussion. Thanks for pinging me. Eason Huang, IIUC, you've globally set up your completion selection UI to pop up automatically. Before this commit, there were no completion sources for text modes OOTB, so your global setting was equivalent in practice to something that only affects non-text mode buffers, and that was fine. Is that correct? If so, my suggestion would be to change your global autocomplete setting such that it doesn't apply for text buffers, seeing as you don't seem to want such automatic behavior in these buffers, instead of disabling the completion source. So I'm not sure another user option is due here. I think your workaround is fine, if that works for you, of course. But you could just as well say `(setq-local corfu-auto nil)` in that hook, no? Best, Eshel From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 29 09:04:06 2023 Received: (at 67527) by debbugs.gnu.org; 29 Nov 2023 14:04:06 +0000 Received: from localhost ([127.0.0.1]:49180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8LAb-0001wN-HJ for submit@debbugs.gnu.org; Wed, 29 Nov 2023 09:04:05 -0500 Received: from out162-62-58-211.mail.qq.com ([162.62.58.211]:51701) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8LAU-0001vb-Uz for 67527@debbugs.gnu.org; Wed, 29 Nov 2023 09:04:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1701266614; bh=cHy/PprXzELPoBHzaap7XQ+/eHCBjLOYdk2I5XVe6Tc=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=ZdBuqL83mL6+FxYpsY9h5g0zYXmpDXYCnT6bBDOKMUAls5PCqgUkiPcw2boCVAkPN oKM7ZQxixwDjB0IOwQPdviE3A4aAir+TcIJLTthac8X6ux7nZpanSDY3Fk427ujJ1n 8jXGUrW+yzUGpyLPOKYfGYXAbVC8zP+nGauBRhpQ= Received: from macbook ([180.162.208.153]) by newxmesmtplogicsvrsza1-0.qq.com (NewEsmtp) with SMTP id E0922E6; Wed, 29 Nov 2023 22:03:32 +0800 X-QQ-mid: xmsmtpt1701266612thcnkx3cb Message-ID: X-QQ-XMAILINFO: MqG4KXyEKpQyKdSfHF49RU6L/u5cUuIzR3dmekXT2L88CKBBD3r0YGBKDQCMRV RIYTmzZcs8FKNbsL3CqJgnitwwspa89uUSbMHmKd5DoOD5yflMNUPOoxZhSJqi51ROSpozaPbWsf J9zBCMZj5Rx9H5rDki9LqjKVmXqRHkUZwoE/e/kf3dntbG6Ryhx09j421eXqQTCq9ffdXwyA4Qtb aBNEAYkptSli0Q17fOqPknHCttEwkOPzYJa8Hz4asoYFDdRQEbq7lj5pewTQ/RR5wH78YwZYgIeA e6gZgJMy3KZKLitaII50WO+cE5vrvcuiqkx35Ay5Ar5ZRJYRNfdmR7yKBDNfI0OjBQCtNyYqCxAI 9GXDw8paJwg5cNNgHQ+E19nbnWFV+Wr3VZX2CEX9BoogJyN9pO6HwUH4XNabxVn0AGGGslVeNOPa bncNaOYEOIA048svtU0sGzft0KJd5VBdZUc5lT9AW2dBAgiY2Df4LFDmvCKS4o6cU3+WvVDsb/vn gpdG9jJd0Q7mStcU3RbSTfiWd1WV0QzH+wKtwSbwondnYM8YK+Zp7AyyjIohiR38gDHXCKTKetIs pZQek+Ba9WMIzg4BJQ0KCHn2ScN95hWzZpRnaRTfE5ehcZDlTL+knVx8bi8eXnI2SoI2VvtlyaC9 2NP6+uZk5xF07IYzdyHEpVYjKy0znSvD8WNUCVlA90xzbvfQbqglOf5BqX8inCQ9mUKOblMNNqAM 449lLwRbqSrGpYGd6VBflWSnfyT2/hllEQY0WhTiQwJ6rocF8z9nnclqvzgqwQsM+FvB0Vjh+ExH BuztM2LKfGDjd/SMZ55tKw58IjjQc//t11MI4qPZDroKlsKz0GC0fRGQB5aTcgiTB0W6HuyfYCbp 8HUmZ0uHtbL//ZqsCiviC/jcz44uaJI6qz6xS42wniK6WoTKjTVMSUCxMUyhNoxwu368QHlE+D7R VYWHjiw4uC55PQ+EzHn+fH6fVG5VdGEchIFqFOjwCokUHOv2OgAw== X-QQ-XMRINFO: MPJ6Tf5t3I/ycC2BItcBVIA= From: Eason Huang To: Eshel Yaron Subject: Re: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode In-Reply-To: (Eshel Yaron's message of "Wed, 29 Nov 2023 14:45:33 +0100") References: <83fs0o7l6a.fsf@gnu.org> Date: Wed, 29 Nov 2023 22:03:32 +0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 3.8 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Eshel Yaron writes: > Eli Zaretskii writes: > >>> From: Eason Huang >>> >>> In the below commit, Emacs support ispell-completion-at-point in >>> text-mode. >>> >>> https://git.savannah.gnu.org/cgit/emacs.git/commit/? [...] Content analysis details: (3.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [162.62.58.211 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [162.62.58.211 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (aqua0210[at]foxmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (aqua0210[at]foxmail.com) 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS -0.0 T_SCC_BODY_TEXT_LINE No description available. 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) X-Debbugs-Envelope-To: 67527 Cc: Eli Zaretskii , 67527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.8 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Eshel Yaron writes: > Eli Zaretskii writes: > >>> From: Eason Huang >>> >>> In the below commit, Emacs support ispell-completion-at-point in >>> text-mode. >>> >>> https://git.savannah.gnu.org/cgit/emacs.git/commit/? [...] Content analysis details: (2.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [162.62.58.211 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [162.62.58.211 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (aqua0210[at]foxmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (aqua0210[at]foxmail.com) 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) Eshel Yaron writes: > Eli Zaretskii writes: > >>> From: Eason Huang >>> >>> In the below commit, Emacs support ispell-completion-at-point in >>> text-mode. >>> >>> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=47e313e9805c527e590df4270062a9185ee9db78 >>> >>> But it would be nice to add an option to disable this feature. >>> >>> Because when I enable the autocomplete by corfu or company, it will >>> always popup the candidate when I input English charectors. >>> I don't want to diable the autocomplete of corfu or company, because I >>> need it in org code block. >>> >>> >>> Workaroud: >>> >>> Recently, I have to add this code snippet to disable it. >>> >>> ``` >>> (with-eval-after-load 'org >>> (add-hook 'text-mode-hook >>> (lambda () >>> (remove-hook 'completion-at-point-functions 'ispell-completion-at-point t)))) >>> ``` >> >> Adding Eshel to this discussion. > > Thanks for pinging me. > > Eason Huang, IIUC, you've globally set up your completion selection UI > to pop up automatically. Before this commit, there were no completion > sources for text modes OOTB, so your global setting was equivalent in > practice to something that only affects non-text mode buffers, and that > was fine. Is that correct? No. It's correct on the text file (.txt), but not in org-mode files. Because org-mode also derived from text-mode. In my test.org file, I have emacs-lisp code block and so on. in the code block I do need the UI to pop up automatically. `C-h, v completion-at-point-functions` on org-mode buffer will get: ``` (cape-elisp-block cape-file tags-completion-at-point-function) ``` > If so, my suggestion would be to change your global autocomplete setting > such that it doesn't apply for text buffers, seeing as you don't seem to > want such automatic behavior in these buffers, instead of disabling the > completion source. > So I'm not sure another user option is due here. I think your > workaround is fine, if that works for you, of course. But you could > just as well say `(setq-local corfu-auto nil)` in that hook, no? No. I need (setq-local corfu-auto t) on org-buffer -- Eason Huang From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 29 09:32:35 2023 Received: (at 67527) by debbugs.gnu.org; 29 Nov 2023 14:32:35 +0000 Received: from localhost ([127.0.0.1]:49243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8LcA-0002iJ-M7 for submit@debbugs.gnu.org; Wed, 29 Nov 2023 09:32:35 -0500 Received: from mail.eshelyaron.com ([107.175.124.16]:58940 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8Lc7-0002iA-6m for 67527@debbugs.gnu.org; Wed, 29 Nov 2023 09:32:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1701268343; bh=Wj2dPMcyIThbme4F8Hzqmm9RIt4mxVGNWCV/IC5aB6o=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=kMa0ILKc69AIpLEqbHWLK5I8/JvkBMvc9juP4FYqF/NQ6B3RkW/odrB9WW6lpgxta hWhKxnbFXFeB8Ds6Oz4iWi6b12UdZZtVAJ65aDXjHi/w6yG3pEpRtCo6meACkVavls VIZj9aglvMOB65FrIhJGDEoLRt+BKWF7w/K8d4Nga23unSkmZ/tn3TGKPju7Tdd+Hk dbGZdWNp/J+sT24NAaOeh6KaemcTCHac15xP0jGru3NtSP7M9ES7Pu1znqNT5EHfIV iLOuHkW1r10AboBxa+DCqiYW7bPuXS0fizWNGIwIiem60tg30GyWLaoZGlZG2F3sa4 NYRWt0XyrcdUQ== From: Eshel Yaron To: Eason Huang Subject: Re: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode In-Reply-To: (Eason Huang's message of "Wed, 29 Nov 2023 22:03:32 +0800") References: <83fs0o7l6a.fsf@gnu.org> Date: Wed, 29 Nov 2023 15:32:20 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67527 Cc: Eli Zaretskii , 67527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eason Huang writes: > Eshel Yaron writes: > >> Eason Huang, IIUC, you've globally set up your completion selection UI >> to pop up automatically. Before this commit, there were no completion >> sources for text modes OOTB, so your global setting was equivalent in >> practice to something that only affects non-text mode buffers, and that >> was fine. Is that correct? > No. It's correct on the text file (.txt), but not in org-mode > files. Because org-mode also derived from text-mode. > ... > >> If so, my suggestion would be to change your global autocomplete setting >> such that it doesn't apply for text buffers, seeing as you don't seem to >> want such automatic behavior in these buffers, instead of disabling the >> completion source. >> >> So I'm not sure another user option is due here. I think your >> workaround is fine, if that works for you, of course. But you could >> just as well say `(setq-local corfu-auto nil)` in that hook, no? > > No. I need (setq-local corfu-auto t) on org-buffer Sure, and you can do that. Again, whatever solution works best for you. I just highlighted that the behavior that you want to avoid seems to be a consequence of a global setting that you don't in fact want to apply it in all buffers. Makes sense? From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 30 02:46:51 2023 Received: (at 67527) by debbugs.gnu.org; 30 Nov 2023 07:46:51 +0000 Received: from localhost ([127.0.0.1]:52118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8bl5-0004HY-1F for submit@debbugs.gnu.org; Thu, 30 Nov 2023 02:46:51 -0500 Received: from out203-205-221-173.mail.qq.com ([203.205.221.173]:35904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8bkz-0004HB-Qm for 67527@debbugs.gnu.org; Thu, 30 Nov 2023 02:46:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1701330384; bh=ezvUJ++06u0tDlgT2cdk6yoVB9QjewhrS4akwEO2nV4=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=Tgw5ciH/nyYMsJL31POmAu7DsuFVKXRPsf/v/7p0YScw4VQt6BaxQVEd7s4oi+OwR eC4G1ATL9FeDrFmLXb53fr/M/AeFyRIZ/hcfrdQf8E6oagtO61dkE0NttD8ZT0XsNv vChb7dtp0wW4Xgd4jkkx10nIbf1A/xTZT+1JR0aE= Received: from DESKTOP-VIHFE84 ([202.96.203.174]) by newxmesmtplogicsvrszc5-0.qq.com (NewEsmtp) with SMTP id B9697802; Thu, 30 Nov 2023 15:46:22 +0800 X-QQ-mid: xmsmtpt1701330382tfpeifud9 Message-ID: X-QQ-XMAILINFO: M4rszIxWf0m7a84TkI25Xt8AGzHdRprjzr/ZAV2NozbXyge9j81uWRjAcGTNq3 OhqlIlImrNQk75GLgJ3l5ZuFB4xjJVk6k8mw+TTfT8q4hOTAXtERTJq/XpvPibhCMoBG+wCTcsLd CboSyPhVq3qtT5ngH1xqjUkZtSqIKdSQxpsLmtiehbtZqDtPLEl71Ak/096IHbN7NvtCB1yOAJQu XLGkWHRECFamIeoyMCTuCnYM0SuxiT5r4NpwquIO5DyxSp9ck2gYhQYtwesk9CIAX7OgyyALGfAW hVfvMqzc3JEUuenhfiDvW3Z54fOt/4rLnGxvK8utISGJF+CNWtnQm1vwrn+G7X8GaD+Mo8b5a2mP OP/euoZvwSwCOePEyoS26Da+w7VGUfvEyQbNU2hx2/ujQcx3rkm4ByJhkUCCIjSf8I/tKP9j77LK 21JigKboubqnKwtu09/sQyooPfBaixkpdte+CsuXAgxnUrg9LHbt3YyLdC1CTl54JSB/HvWCQ0r9 NSIdIy/Bqdc3MgeDIjK6AZYD+ju5hYU9XCh+Xf2qDflZmyU+6nodlCs+jjNUW4oTwFw1gCw7AWUi vREeHzj9kRYV6c3GRUTaL/qFqc05Oeq1JSNCdNKtt+FME/1zbvDtW8axjHEJACQclQmmNDlIMMSd RX7k7D8W6raQRgKfX0/MvoViSQ1wf/XbcURhebgGcwrwTf2Sz6XGTShkx8NZ7+S8g/hc7SSwLIzj trLOO7oQbLuUelqjc7ro07VUqV5c1qZJA4QQL5/ssQkLT6yBT2t7sruirXVaaDrgeAtgggQb6Wgh tiPmmve1QLnC5EP0jvXS5WrAuefThLw7isHTPmgxjXWH0nGTfPIZWyZjnwfWG8NDG3IpcV4L+51A 666yCH/3EJeW04S4Odg9I0UpteduoRkGQ82VrA833PeWLPMCIv/L/qC4IKqOqFc8JY5EDXGCa2T5 Tpuv+ecYcFfR6IZ5m604tvPQgpPWIg X-QQ-XMRINFO: M/715EihBoGSf6IYSX1iLFg= From: Eason Huang To: Eshel Yaron Subject: Re: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode In-Reply-To: (Eshel Yaron's message of "Wed, 29 Nov 2023 15:32:20 +0100") References: <83fs0o7l6a.fsf@gnu.org> Date: Thu, 30 Nov 2023 15:46:20 +0800 Message-ID: <86v89jlm43.fsf@foxmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 3.8 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Eshel Yaron writes: > Eason Huang writes: > >> Eshel Yaron writes: >> >>> Eason Huang, IIUC, you've globally set up your completion selection UI >>> to pop up automatically. Before this commit, there were no completi [...] Content analysis details: (3.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [203.205.221.173 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [203.205.221.173 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (aqua0210[at]foxmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (aqua0210[at]foxmail.com) 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) X-Debbugs-Envelope-To: 67527 Cc: Eli Zaretskii , 67527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.8 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Eshel Yaron writes: > Eason Huang writes: > >> Eshel Yaron writes: >> >>> Eason Huang, IIUC, you've globally set up your completion selection UI >>> to pop up automatically. Before this commit, there were no completi [...] Content analysis details: (2.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [203.205.221.173 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [203.205.221.173 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (aqua0210[at]foxmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (aqua0210[at]foxmail.com) 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) Eshel Yaron writes: > Eason Huang writes: > >> Eshel Yaron writes: >> >>> Eason Huang, IIUC, you've globally set up your completion selection UI >>> to pop up automatically. Before this commit, there were no completion >>> sources for text modes OOTB, so your global setting was equivalent in >>> practice to something that only affects non-text mode buffers, and that >>> was fine. Is that correct? >> No. It's correct on the text file (.txt), but not in org-mode >> files. Because org-mode also derived from text-mode. >> ... >> >>> If so, my suggestion would be to change your global autocomplete setting >>> such that it doesn't apply for text buffers, seeing as you don't seem to >>> want such automatic behavior in these buffers, instead of disabling the >>> completion source. >>> >>> So I'm not sure another user option is due here. I think your >>> workaround is fine, if that works for you, of course. But you could >>> just as well say `(setq-local corfu-auto nil)` in that hook, no? >> >> No. I need (setq-local corfu-auto t) on org-buffer > > Sure, and you can do that. Again, whatever solution works best for > you. I just highlighted that the behavior that you want to avoid > seems to be a consequence of a global setting that you don't in fact > want to apply it in all buffers. Makes sense? > Maybe I don't make myself clear! 1. I do confirm that I need to enable corfu-auto in org-mode, and it is useful in code block such as the belwo code in org buffer: #+begin_src emacs-lisp ;; input some code here will get auto completion (message "Hello") #+end_src 2. It's not a good idear to add `ispell-completion-at-point` to `completion-at-point-functions` by default. 3. Anyway, I can use the below code to rollback to the behavior before the commit. ``` (add-hook 'text-mode-hook (lambda () (remove-hook 'completion-at-point-functions 'ispell-completion-at-point t))) ``` If you decide that no need to add an option to prevent adding `ispell-completion-at-point` to completion-at-point-functions by default, feel free to closed this bug report (It's not a bug, I just want to provide some advice from a user view). Best Regards, Eason Huang From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 30 04:01:19 2023 Received: (at 67527) by debbugs.gnu.org; 30 Nov 2023 09:01:19 +0000 Received: from localhost ([127.0.0.1]:52229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8cv9-0000r3-6r for submit@debbugs.gnu.org; Thu, 30 Nov 2023 04:01:19 -0500 Received: from mail.eshelyaron.com ([107.175.124.16]:38122 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8cv7-0000qu-Kt for 67527@debbugs.gnu.org; Thu, 30 Nov 2023 04:01:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1701334868; bh=Lm4ulxZdNb6JgT+zmc/1l+pKIzwb1r98CrT8ycVgzko=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=OJF7c0VitQhLGClxwgIG9ksOHxV095kLOF9aeUGITU4H42i3p7K04UeQWDoooqSR4 gEkJWVvs92foljcunR1Jqb5zzZFb0KZpxn8lyVx332iIx1RfLfLhHqxHI11EjDqfwl kfr1Un6ykvJRFuxPu0buifTtR3H5ELQxpLrHaCDghdxfxKYRrBl7m2PK4I97AC40Bs u5WXtA3kIVtjh5enZ/XJnNqq1TVtaaa7lOSnh3sudvT4yuNWtvS3bJeTUxIi9R9CP+ MKxHvXZng8c/XH6eR1Dzntj2jNW4Pnv7RaESKU2u6pPMNF7aLiFJdH6QAFYhmxlKgC J0mRuxTHVAy5g== From: Eshel Yaron To: Eason Huang Subject: Re: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode In-Reply-To: (Eason Huang's message of "Thu, 30 Nov 2023 15:46:20 +0800") References: <83fs0o7l6a.fsf@gnu.org> Date: Thu, 30 Nov 2023 10:01:06 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67527 Cc: Eli Zaretskii , 67527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eason Huang writes: > Eshel Yaron writes: > >> Eason Huang writes: >> >>> Eshel Yaron writes: >>> >>>> ...I'm not sure another user option is due here. I think your >>>> workaround is fine, if that works for you, of course. But you could >>>> just as well say `(setq-local corfu-auto nil)` in that hook, no? >>> >>> No. I need (setq-local corfu-auto t) on org-buffer >> >> Sure, and you can do that. Again, whatever solution works best for >> you. I just highlighted that the behavior that you want to avoid >> seems to be a consequence of a global setting that you don't in fact >> want to apply it in all buffers. Makes sense? > > Maybe I don't make myself clear! > I do understand, I believe. I'm sorry if I gave you a different impression. > 2. It's not a good idear to add `ispell-completion-at-point` to > `completion-at-point-functions` by default. Here I, respectfully, disagree. I understand that this has an unwelcome effect for your particular setup, but I think that that's because this setup made a brittle assumption about an undocumented and incidental property of `text-mode` (the property of not providing any capfs). > 3. Anyway, I can use the below code to rollback to the behavior before > the commit. > > ``` > (add-hook 'text-mode-hook > (lambda () > (remove-hook 'completion-at-point-functions > 'ispell-completion-at-point t))) > ``` Indeed, it's easy enough to adapt if you happen not to like this capf. Which is why I don't think a dedicated user option is in order. Regarding this specific way of adapting, my suggestion was instead to go with something that still allows you to use word completion in text buffers, but that's just a friendly suggestion, and maybe you simply don't need word completion at all. > If you decide that no need to add an option to prevent adding > `ispell-completion-at-point` to completion-at-point-functions by > default, feel free to closed this bug report (It's not a bug, I just > want to provide some advice from a user view). I appreciate your advice and your valuable user perspective. As I mentioned earlier, I think that such a user option would be redundant. I wonder how others feel about this, though. Cheers, Eshel From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 16 03:37:10 2023 Received: (at 67527) by debbugs.gnu.org; 16 Dec 2023 08:37:10 +0000 Received: from localhost ([127.0.0.1]:53929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEQAY-0006JW-4x for submit@debbugs.gnu.org; Sat, 16 Dec 2023 03:37:10 -0500 Received: from mail.eshelyaron.com ([107.175.124.16]:50742 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEQAV-0006JO-Aj for 67527@debbugs.gnu.org; Sat, 16 Dec 2023 03:37:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1702715826; bh=kZC2TZKHsa64ClvIhDEsuXzzA6qPrSsFvxZ7hlNh+Vs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=n9CUJzGU3fcS5uGl+vNrpC3dJxdzjDVJhqU3HsHrjaHBYpiKBpJq7zGs87nKUQsvf BqxPq2mxkJ0W99nWdisKpEYDU2/+R33yFVEqrufwE2P16SKlhjJloS9jMOTxPNCwux Mf2lDli9Wn/c7fCYLwejqiMR1e9dlMI5nO+8G8CoLufdrU/kQLyyHErY0G7wM86qFf g0/IdKIFIRs8hMdBsej4AoN1lSQYPGRAq9UU63Wdy+HcoWIUVI904Owz6SdRR7VGxJ cOCxzP6DUUXPpweDCqFRCUW5s4tbyNp9dtlb0KXLvrdxLbJQ3VgwJAHiW8agxQG+r7 S2J4VMmEmRfcQ== From: Eshel Yaron To: Eason Huang Subject: Re: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode In-Reply-To: (Eshel Yaron's message of "Thu, 30 Nov 2023 10:01:06 +0100") References: <83fs0o7l6a.fsf@gnu.org> Date: Sat, 16 Dec 2023 09:37:03 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67527 Cc: Daniel Mendler , Eli Zaretskii , 67527@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eshel Yaron writes: > Eason Huang writes: > >> It's not a good idear to add `ispell-completion-at-point` to >> `completion-at-point-functions` by default. >> ... >> Anyway, I can use the below code to rollback to the behavior before >> the commit. >> >> ``` >> (add-hook 'text-mode-hook >> (lambda () >> (remove-hook 'completion-at-point-functions >> 'ispell-completion-at-point t))) >> ``` > > Indeed, it's easy enough to adapt if you happen not to like this capf. > Which is why I don't think a dedicated user option is in order. > ... > I wonder how others feel about this, though. I surveyed a bunch of user configurations online, and saw that it is not that uncommon for people to globally enable automatic completion pop ups with company and corfu. As Eason Huang reports, the new `ispell-completion-at-point` probably makes such pop ups rather noisy. I see that Dmitry (CC'd) already addressed this in company (by skipping this capf). I suppose corfu could do something along the same lines (CC'ing Daniel as well)... Do you guys think that's a reasonable remedy? Eshel From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 16 04:34:59 2023 Received: (at 67527) by debbugs.gnu.org; 16 Dec 2023 09:34:59 +0000 Received: from localhost ([127.0.0.1]:53969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rER4V-0001Fi-EY for submit@debbugs.gnu.org; Sat, 16 Dec 2023 04:34:59 -0500 Received: from server.qxqx.de ([2a01:4f8:121:346::180]:41221 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rER4S-0001FS-Vq for 67527@debbugs.gnu.org; Sat, 16 Dec 2023 04:34:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Bt7bVUJFUBNM+DA1zJGHEH9GnlTZ84nF+yCsdqgaNGA=; b=IIjRvluFZtu5NzQOOMkAPa68Uj SWvRGrCzi3Jc75hCIGUCn4q+U8JC2J7X00VZP1BwXimJy2Fnlrjd00A9jhBuM4OEU3EiVt6d9tqXe gXc0vIvfZc+VYV/GLbkcdWNuTeNPLkzfdHiAo5ifEFp8CH1tV8hID/XvTHGpMlRWxIho=; Message-ID: <1779ab84-21db-48c4-9b59-efa11a4559f1@daniel-mendler.de> Date: Sat, 16 Dec 2023 10:34:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode To: Eshel Yaron , Eason Huang References: <83fs0o7l6a.fsf@gnu.org> Content-Language: en-US From: Daniel Mendler In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67527 Cc: Dmitry Gutov , Eli Zaretskii , 67527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 12/16/23 09:37, Eshel Yaron wrote: > I surveyed a bunch of user configurations online, and saw that it is not > that uncommon for people to globally enable automatic completion pop ups > with company and corfu. As Eason Huang reports, the new > `ispell-completion-at-point` probably makes such pop ups rather noisy. > > I see that Dmitry (CC'd) already addressed this in company (by skipping > this capf). I suppose corfu could do something along the same lines > (CC'ing Daniel as well)... Do you guys think that's a reasonable remedy? Corfu does not modify the completion-at-point-functions variable itself. It leaves that to the users and major mode authors. Daniel From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 16 07:23:41 2023 Received: (at 67527) by debbugs.gnu.org; 16 Dec 2023 12:23:41 +0000 Received: from localhost ([127.0.0.1]:54127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEThk-0001ED-Vs for submit@debbugs.gnu.org; Sat, 16 Dec 2023 07:23:41 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:60709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEThj-0001E0-6L for 67527@debbugs.gnu.org; Sat, 16 Dec 2023 07:23:39 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 7A3FD5C0165; Sat, 16 Dec 2023 07:23:33 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 16 Dec 2023 07:23:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1702729413; x=1702815813; bh=IBmXKiCBop+vyZI6ycku3ZYZwwk8X0HyrlkGkXE3vt0=; b= irqUFeThpxHuk5sRRDb/4RM1q+sT5LQDkEnzOhXZc2NO2737EV2nj9zjyvVudxxq MvT4GvESAygxMgxpeBQOdxzw7oqTSom/PwKlSb1+cBmGSwlMd8gphjO0m1DZLNv3 K9Kaxs9qCGcDk73uhdnGpDhN6ZanDrIByULESXGmD0RAxyd4gt8aYZ5k99LyW2IW sef/T5a9i7pgIvrG0VTbvaIK35WvZksBwwVZ7LmQLWsTnrsjrDexQFsvwxXJ9lCF q3Xx31ap7gsODmptaH/MLm95keq5p/MGuMGhiXD0GVaO/Nu9FRpPVKKrHpjJU1VN ljhXigNVvNCotKC/FslRDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1702729413; x= 1702815813; bh=IBmXKiCBop+vyZI6ycku3ZYZwwk8X0HyrlkGkXE3vt0=; b=4 TzRO7jxY9BsHuYF0iHGQrp7d+mkkulFovyYfRxt5e7TeZtn0oXXxuJKRqkguQ2E8 raF5dPBYtAAKGkLGzGF67wqlDPXv3bBcvZxxPhH7fBEt3JqXiRryPQUTMQYdAEFa Xu1+ECLza4uVCpg7IIZlmM7EmPiOTTxiRjmEVb89sKAx9It7hxjAUEQAycFv2+zq dynRxqAMsxgGG+ySqYwZqraqH4KCREGzdFkKyN2mVsluvr1C9uL69KdCVfVlxLNC 2Sm9JZSIGN3AtIvDCEDZn5xKuDeJ2v0dvy75Zs7xBWwLfd4YkJ4UvfHzaheMvy5E SbVSH+GQFvPKSPEggt1Hw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtgedggeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 16 Dec 2023 07:23:30 -0500 (EST) Message-ID: <4955ebd8-bdd4-85b2-3851-2cfc6b549b24@gutov.dev> Date: Sat, 16 Dec 2023 14:23:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode Content-Language: en-US To: Daniel Mendler , Eshel Yaron , Eason Huang References: <83fs0o7l6a.fsf@gnu.org> <1779ab84-21db-48c4-9b59-efa11a4559f1@daniel-mendler.de> From: Dmitry Gutov In-Reply-To: <1779ab84-21db-48c4-9b59-efa11a4559f1@daniel-mendler.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 67527 Cc: Eli Zaretskii , 67527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) On 16/12/2023 11:34, Daniel Mendler wrote: > On 12/16/23 09:37, Eshel Yaron wrote: >> I surveyed a bunch of user configurations online, and saw that it is not >> that uncommon for people to globally enable automatic completion pop ups >> with company and corfu. As Eason Huang reports, the new >> `ispell-completion-at-point` probably makes such pop ups rather noisy. >> >> I see that Dmitry (CC'd) already addressed this in company (by skipping >> this capf). I suppose corfu could do something along the same lines >> (CC'ing Daniel as well)... Do you guys think that's a reasonable remedy? > Corfu does not modify the completion-at-point-functions variable itself. > It leaves that to the users and major mode authors. I think that's okay: company skips this capf because it has another completion source configured by default (which also "will always popup the candidate when I input English charectors"). Corfu doesn't and follows the current CAPF configuration. In which case showing the ispell results seems reasonable. Though of course some might not like that. I don't know whether that merits a new user option. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 09 03:31:07 2024 Received: (at submit) by debbugs.gnu.org; 9 Jan 2024 08:31:07 +0000 Received: from localhost ([127.0.0.1]:38238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rN7Vo-0007K0-33 for submit@debbugs.gnu.org; Tue, 09 Jan 2024 03:31:07 -0500 Received: from lists.gnu.org ([2001:470:142::17]:35084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rMtqV-0007ns-TQ for submit@debbugs.gnu.org; Mon, 08 Jan 2024 12:55:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMtqF-0001kg-I4 for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 12:55:15 -0500 Received: from mail-ot1-x32a.google.com ([2607:f8b0:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rMtqC-0003mT-Nu for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 12:55:15 -0500 Received: by mail-ot1-x32a.google.com with SMTP id 46e09a7af769-6dbd445f395so1200387a34.2 for ; Mon, 08 Jan 2024 09:55:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ecksdee-org.20230601.gappssmtp.com; s=20230601; t=1704736511; x=1705341311; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=gEXXdGPX7GZt/Z1Z6SgjrGuGm5McIOOdhC6kUzbQ75s=; b=p02OjkmCk5LbX9Qck0Io+xwJhZ3YCsyrU7tBh9s8qo+QuT0jZhh9IVAy6nRuwA4azQ uD0G4LwTN6lmgH3YCidRhdiSa2InKFbCL+lhV/w20L8HLujlTA4BQBhFnmCZdXMtJtW0 vSegDwdQRXvGLVZ/jD3mt4+Gw348L7W1iUkv5BsyH0xcOm5fS9wdVD1PmEzSiCG/YD0Y XQ4JMbcB//eK/BjHpq1hje71WCHAQ05npT4wzRRHDHkp4jI+0B/7eQWOuxLuudtka6uX w5JfcUKROuq+HUWfLonW8KAGN8UnpWXEKUG79FxyPLfgyp+lHyHzqN5BbJ9tKCh56cKs UgKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704736511; x=1705341311; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=gEXXdGPX7GZt/Z1Z6SgjrGuGm5McIOOdhC6kUzbQ75s=; b=uDm9OUiZr9Q39FYWlCx2wpJQuXwePYKiWBPka4jWZUlg74hNyriLb25bljFuYjQzOY Gv2WzW7KXbuBq4INoDenB4b3QB24JsSID9H0+u/un81SObvw+nZ3wpJJuLZ9AG0LYID5 pvUC/DfCdEt2kOCqberhCdkMmSqBSJfFfz3iA7jbuceoK4ApSSW0wakZR8c0V0dJv6TJ TbpkWPg04Uc47d4RjrmwMxlPnt7EpOw/X67c7Kv/+EguA73rBKMmTVs1WIV4hmplEnzs yl3oE+bbBm9uPEFwfy0gm7AuIOckcoEJMrBDzbXJCdp6esLZl6ysEAcmK9Cj+/gOFg0d wbxw== X-Gm-Message-State: AOJu0YzxaXQNsfii4k96ebPYs9XWmsDEEVzMGe+1CZIY1Io4KO9PG6Aj tpbbDgR+BMWyzXZ74uedRASmVnjWRZlk1gmW8rrQJb3bEGz1qt/Qa6Rr/iyV5g== X-Google-Smtp-Source: AGHT+IGZakzo2L+ejkwFcgrebkpMOn6bL2PETxWr8lTxOXhFUmQfP2TW4dSa1EWhE9zp2KrkSi5vWYtD91fb416As4o= X-Received: by 2002:a9d:6745:0:b0:6db:ff9d:9b55 with SMTP id w5-20020a9d6745000000b006dbff9d9b55mr2388661otm.19.1704736510862; Mon, 08 Jan 2024 09:55:10 -0800 (PST) MIME-Version: 1.0 From: Simon Manning Date: Mon, 8 Jan 2024 12:55:00 -0500 Message-ID: Subject: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="0000000000002a7ac9060e72e60f" Received-SPF: none client-ip=2607:f8b0:4864:20::32a; envelope-from=simon@ecksdee.org; helo=mail-ot1-x32a.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 09 Jan 2024 03:30:48 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --0000000000002a7ac9060e72e60f Content-Type: text/plain; charset="UTF-8" For what it's worth, I've hit the same issue as Eason and have had to use the same workaround. The behavior is quite annoying with this (I think quite common?) setup because you can't really type without completion popups for simple words continuously showing up. --0000000000002a7ac9060e72e60f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
For what it's worth, I've hit the same issue as Ea= son and have had to use the same workaround. The behavior is quite annoying= with this (I think quite common?) setup because you can't really type = without completion popups for simple words continuously showing up.
--0000000000002a7ac9060e72e60f-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 09 08:34:37 2024 Received: (at 67527) by debbugs.gnu.org; 9 Jan 2024 13:34:37 +0000 Received: from localhost ([127.0.0.1]:38725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNCFZ-0000hJ-HZ for submit@debbugs.gnu.org; Tue, 09 Jan 2024 08:34:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNCFW-0000h2-HY for 67527@debbugs.gnu.org; Tue, 09 Jan 2024 08:34:35 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNCFK-0008Fw-9H; Tue, 09 Jan 2024 08:34:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CY0+z9gTFMUH5nzouBDnd3lvqDJCAvTexu0UinE4vJc=; b=Hks3y3eh+jdN jPWmz5jKtHmSTZyZw6Sg2rm2pSBE0QKUVVMeJNsLUE/Xf5FgLIVChynRPFuQY8hUEif5aHjatjl1G LIvkQn9jVkX+PzHcXXVlZPXeZ0NEhmG8ls0Ig48V3EZTZz3/rptAceQZYj2oJuuRozk2nIKwB4id4 cQy7g5WifPAp01amV9AYg3hFXACpG6Ml1bpKwUBkckOOWlDiAx4WYhIAfLsU4vAr0cR7CQU17CMTb ts6mcCwdssB3IaK9W6U5xAeGjVTOmD6RNxm1gB/C2A6JlmTUrKfW8x2R/dPUcXu31SEYCKFUdyHkE aEI+05I3xoNMGbtRCQLpxQ==; Date: Tue, 09 Jan 2024 15:33:48 +0200 Message-Id: <83jzoipr5v.fsf@gnu.org> From: Eli Zaretskii To: Simon Manning , Eason Huang In-Reply-To: (message from Simon Manning on Mon, 8 Jan 2024 12:55:00 -0500) Subject: Re: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67527 Cc: 67527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Simon Manning > Date: Mon, 8 Jan 2024 12:55:00 -0500 > > For what it's worth, I've hit the same issue as Eason and have had to use the same workaround. The > behavior is quite annoying with this (I think quite common?) setup because you can't really type > without completion popups for simple words continuously showing up. We add ispell-completion-at-point to completion-at-point-functions with DEPTH of 10. So if other packages use DEPTH omitted or nil when adding their functions to completion-at-point-functions, they should be called before ispell-completion-at-point. Does that happen? if not, why not? If it does happen, why isn't that a good enough resolution of the situation where several candidates compete for the privilege of providing a completion? I took a liberty to add back Eason to the discussion, in the hope that he could explain why DEPTH of 10 didn't solve his situation. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 12 07:52:44 2024 Received: (at 67527) by debbugs.gnu.org; 12 Jan 2024 12:52:44 +0000 Received: from localhost ([127.0.0.1]:35184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOH1g-0004G7-0e for submit@debbugs.gnu.org; Fri, 12 Jan 2024 07:52:44 -0500 Received: from out203-205-221-190.mail.qq.com ([203.205.221.190]:58958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOH1Z-0004Fl-Km for 67527@debbugs.gnu.org; Fri, 12 Jan 2024 07:52:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1705063943; bh=sXJV3bvns8LWvfV0ZZeK5lPTUcL44TbbcJcHfTpCaTQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=HXFc+0cLL/wSyqHXJH8S0QrA1BjbTnblG4fFVN7Lb1Svk+11iOsg/H8oUK4UzHquP T7AFOg+WQjjrRwSurxAYk6loSHMt/mYlXCa1VbFc1CxTxHe5+dcGGqbyeABwkvd8OH 6B2U+XB4O/iWwbIUwL084fWO6bPVwIQqGzy2gmEk= Received: from macbook ([101.85.8.38]) by newxmesmtplogicsvrsza7-0.qq.com (NewEsmtp) with SMTP id B8F318BD; Fri, 12 Jan 2024 20:46:15 +0800 X-QQ-mid: xmsmtpt1705063575t101eb34l Message-ID: X-QQ-XMAILINFO: Mh1dUllL/+A2BFiv0+gNXRVF5m4G8XaBSITw/4F2ujk1LWglxNATtZludZY6gt R/YxVUsuwaBOT8fFMcRR8tWgdQAvMVgJuNRAqLSk7qfrj6Be7XCKMIrsv5pPvSjwUvoB17hZo9Pw XqqX6tPd8j9/2ug+wbjgfoWeYbeTqO9Vg+oyGMYdzPHU8lgFcjhIm8zOo17CX2QC7/acfwU8u4nc +ho54WUUy/YtAU1JWmp2UrFh2n6xtVgV+LqYHfHZ3y2f/l7MywKwbLnGVtomzsp3Y8aBJ33pQvj1 jFqDux8nN8JbhdwRzarj5hesEVQaoCCxIVMVKznSAfFtK7rbV53Vr7D9/BftHAB2Fva0xTed4DuC G7N2FsQYbjL5sduXypozX41xfqbQWb9SMdkowVfVOu/G6eZldIr6hq3ZoBIQOxkJbD5NHm4HOwfT FvvIACShkdSmJtqO8gHmVLW5UC/x4W5ezt4GxkAuCaumyKQ6nMLmj+BG/Q3/C4kDrTWu0eInar2z kPN/2Meg8g5jzBq7KItRcLKI/JVsu0ajEilyxal1lac4pMrKq9/4pldNK1XYaRzPMsoWwisv5kfP ckLGujS/WfQZoZmYZwIcAgRvQm6g9Pzrvgg/pLndFocmhPrCdBse8ChYugMx7DJyoNWmHPpX6drc Uag+fLrNKfjmhIJEIiNYh1rZFoQMjxHrnM55IYVq7WB4ND/739aL9pZ5RsdNL0JexhRMTuDYD1Zl H0Odn9nUdINkfk9G072MinnGlMYrv4zPtQTM+cE8llkr1awqaU3a2Hjj1cxjNO6nzmOqK42pVEap jfGHSU/BtwwoU0Xrv+NMe3UryysfwHIORhNxY1aCRRk8/bDKmiYYwq9LKxkQFIuc0OyNL6VYgWYY rznXTFmpjkP052LHd2cgUOsHrmfLFLH2wi+D4Yr8cJA8A9pL4uA93ENGq46hB+BskfKmDcpQh6fn sdQ1Lj/n2YcaQ4p2zZKznPQo7mXZyX/WcB3fCCqjBbQKv0UjjumSarVZojUf3UvYQ3gACX/LP+Hl exLy2sVQ== X-QQ-XMRINFO: MPJ6Tf5t3I/ycC2BItcBVIA= From: Eason Huang To: Eli Zaretskii Subject: Re: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode In-Reply-To: <83jzoipr5v.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 Jan 2024 15:33:48 +0200") References: <83jzoipr5v.fsf@gnu.org> Date: Fri, 12 Jan 2024 20:46:09 +0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 3.8 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Eli Zaretskii writes: >> From: Simon Manning >> Date: Mon, 8 Jan 2024 12:55:00 -0500 >> >> For what it's worth, I've hit the same issue as Eason and have had to use the same workaround. The >> behavior is quite annoying [...] Content analysis details: (3.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [203.205.221.190 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [203.205.221.190 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (aqua0210[at]foxmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (aqua0210[at]foxmail.com) 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) X-Debbugs-Envelope-To: 67527 Cc: 67527@debbugs.gnu.org, Simon Manning X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.8 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Eli Zaretskii writes: >> From: Simon Manning >> Date: Mon, 8 Jan 2024 12:55:00 -0500 >> >> For what it's worth, I've hit the same issue as Eason and have had to use the same workaround. The >> behavior is quite annoying [...] Content analysis details: (2.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [203.205.221.190 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [203.205.221.190 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (aqua0210[at]foxmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (aqua0210[at]foxmail.com) 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) Eli Zaretskii writes: >> From: Simon Manning >> Date: Mon, 8 Jan 2024 12:55:00 -0500 >> >> For what it's worth, I've hit the same issue as Eason and have had to use the same workaround. The >> behavior is quite annoying with this (I think quite common?) setup because you can't really type >> without completion popups for simple words continuously showing up. > > We add ispell-completion-at-point to completion-at-point-functions > with DEPTH of 10. So if other packages use DEPTH omitted or nil when > adding their functions to completion-at-point-functions, they should > be called before ispell-completion-at-point. Does that happen? if > not, why not? If it does happen, why isn't that a good enough > resolution of the situation where several candidates compete for the > privilege of providing a completion? > > I took a liberty to add back Eason to the discussion, in the hope that > he could explain why DEPTH of 10 didn't solve his situation. > Because I don't have any ohter capf backends in the org buffer(outside the SRC code block), ispell-completion-at-point is the only one. When the cursor is inside the SRC code block, no this issue. -- Eason Huang From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 12 09:09:48 2024 Received: (at 67527) by debbugs.gnu.org; 12 Jan 2024 14:09:48 +0000 Received: from localhost ([127.0.0.1]:35231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOIEF-0002u3-PB for submit@debbugs.gnu.org; Fri, 12 Jan 2024 09:09:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOIEB-0002tl-KR for 67527@debbugs.gnu.org; Fri, 12 Jan 2024 09:09:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOIE6-0000lU-55; Fri, 12 Jan 2024 09:09:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=M7EXX7Gu6YsnceCLqDst0xSQpq8CNMKRAIB8CNAWHgo=; b=jyD26YXG/Y3F RWlGaxVDOgEJ3fQzRivWkBjdUiulCBqmU8SdL6lEOmDo/TQgNsdQt7GnYTCM8o43QCqWczxeuX1u0 vcdEbH5c+6D8zxBkuKqD4k+FT3Xhco/9Z4a07NgwWR33Td/fOfNiHL2u9KAH343tRBdCzCxMRpAI1 qTMgXbRnyYs8dAN+glBOt3tDVtLWJ9FonMpr6rhcHcyXSlfxwgInMk7unsi7G+GR6kGc+0H2qnrPF Vd6XcSE9uKBQKoadBNurONMPM6oIBGscRlhMmD8lWezA2Af7GwzYwuGYko1Mt5MwX8n/OZbyAQ9NR eWeEqBGncP7yUmxokj+ARA==; Date: Fri, 12 Jan 2024 16:09:24 +0200 Message-Id: <83ttniiqy3.fsf@gnu.org> From: Eli Zaretskii To: Eason Huang In-Reply-To: (message from Eason Huang on Fri, 12 Jan 2024 20:46:09 +0800) Subject: Re: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode References: <83jzoipr5v.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67527 Cc: 67527@debbugs.gnu.org, simon@ecksd.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Eason Huang > Cc: Simon Manning , 67527@debbugs.gnu.org > Date: Fri, 12 Jan 2024 20:46:09 +0800 > > Eli Zaretskii writes: > > >> From: Simon Manning > >> Date: Mon, 8 Jan 2024 12:55:00 -0500 > >> > >> For what it's worth, I've hit the same issue as Eason and have had to use the same workaround. The > >> behavior is quite annoying with this (I think quite common?) setup because you can't really type > >> without completion popups for simple words continuously showing up. > > > > We add ispell-completion-at-point to completion-at-point-functions > > with DEPTH of 10. So if other packages use DEPTH omitted or nil when > > adding their functions to completion-at-point-functions, they should > > be called before ispell-completion-at-point. Does that happen? if > > not, why not? If it does happen, why isn't that a good enough > > resolution of the situation where several candidates compete for the > > privilege of providing a completion? > > > > I took a liberty to add back Eason to the discussion, in the hope that > > he could explain why DEPTH of 10 didn't solve his situation. > > > Because I don't have any ohter capf backends in the org buffer(outside > the SRC code block), ispell-completion-at-point is the only one. > > When the cursor is inside the SRC code block, no this issue. I guess I'm confused. In your original report, which started this discussion, you said: Because when I enable the autocomplete by corfu or company, it will always popup the candidate when I input English characters. I don't want to diable the autocomplete of corfu or company, because I need it in org code block. I was asking about that part in your report -- how did the new support for completion-at-point in text mode and its descendants change the behavior when you enable autocomplete by corfu or company, and why were you talking about disabling autocomplete of corfu and company? From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 13 04:08:48 2024 Received: (at 67527) by debbugs.gnu.org; 13 Jan 2024 09:08:48 +0000 Received: from localhost ([127.0.0.1]:38374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOa0W-00022q-Cz for submit@debbugs.gnu.org; Sat, 13 Jan 2024 04:08:48 -0500 Received: from out203-205-221-202.mail.qq.com ([203.205.221.202]:48843) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOa0R-00022V-Ss for 67527@debbugs.gnu.org; Sat, 13 Jan 2024 04:08:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1705136610; bh=2wpUIx6xHEFtFmEQ0iMjRAkOp9YoZBsNj1jP/X/uh6w=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=yzJjl7/Exx1IrTDFZrJAQ7RzO1pzkjzKMjCfi8fR8KC24rlmzo+zGDYrRBrPnDEg5 FZ77U0Mab5YVnjSzBq8/kA01ejuDnEGtjw52toFZ73nvbXLvBmNqVJ6tYTGNww4Ocf bQaTiCz6JZR73P7J1Zi6OgrVJjuYk6mAZNq+V6Lk= Received: from macbook ([101.85.8.38]) by newxmesmtplogicsvrsza10-0.qq.com (NewEsmtp) with SMTP id DD11A99; Sat, 13 Jan 2024 17:03:29 +0800 X-QQ-mid: xmsmtpt1705136609tizos4o1u Message-ID: X-QQ-XMAILINFO: MOpJcPT3Yy24q4DzM0zfDtoAY+WpXDhcMbBujWU/wr/KBF1GbxOuaPEntYMNE0 V+tQZpSW0BtXmMPj1M3uBj9cPq8YidSCaMqNiuHBm/SN4U5z/T8hc30pEgTQudESXDvsQWIf4gmH w6Gxs0K2DI8KvGH2RdQbset31bx6zIgx4u74ozaRPiUnYbq8SgEqVcJLxy2IuTvaFtktJRvx5/jE 7zbHOsg+cGox3PM9yBVcXV7x/vA3DxysZPbohFFMAoN7LLxYcpEWeTCExsemIihVwmal4hkHT19K Ln38laCMkciWGaBh9H8MSM0i8Lt4SglwcDjPwbjyAyO/WAeq9f2Rjb8+B6rA6AzHdmcP+K+j2nkN mlUHd26XMFkDka0GQFe3PFzhMZwufr5eUGgUHVcK80CGjXWeUYiFH92Gr+fcWiQQGu4y3szoM4HY 1U94/J12lN4Dxw8mP+ls8lPRXvD+OyNPMRN6k4EvyD5q2T6H61f5E52A7fTJW/DlVBTtIaJFeWLy hmKPkyNGyhHLMiMl9Ize3CFBLj4ghKJhVp29FPd0X2NyoQziNMowp4MvVsfkdWTJTvMLEgzV786E aQPAtntLW8dJtOj4g4DoWQP0qa55nKQGnDN85j6Cxqn16xWIXrOj5u2akgqv9MTj0sHdHduZxtcL XSMLGg+gMzTCrjP0DiaFo6Rl8RtnLP9P9dwaXThUjjElTIcG7SipqCIrBW4PCdzU2KXCNacNMjzl bjZmSQJJNvahfXH1iRaw+KhRBE2957i9Qx1PTnf/ppKL6lwP8OesBBnD9fiBvE5wJwyhS0KXpQEp n9Xzq1OpD3nHx4IoeJRcn2W5ZJ9FHy4cwLA7zO5+5VvK2gDonRp1zt1/WJSfcQd0tXZeGEUCm0yL hV5QQSLjj443Q74hqyq7KXyZSD0i5wBGqDLS6eDBZL43L7RX3uN2Ec733SGrcmd7tG+gYImJw5Z5 Mr0B7xaqE= X-QQ-XMRINFO: NS+P29fieYNw95Bth2bWPxk= From: Eason Huang To: Eli Zaretskii Subject: Re: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode In-Reply-To: <83ttniiqy3.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 12 Jan 2024 16:09:24 +0200") References: <83jzoipr5v.fsf@gnu.org> <83ttniiqy3.fsf@gnu.org> Date: Sat, 13 Jan 2024 17:03:28 +0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 3.8 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Eli Zaretskii writes: >> > I took a liberty to add back Eason to the discussion, in the hope that >> > he could explain why DEPTH of 10 didn't solve his situation. >> > >> Because I don't have any ohter capf backends in th [...] Content analysis details: (3.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [203.205.221.202 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [203.205.221.202 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (aqua0210[at]foxmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (aqua0210[at]foxmail.com) 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) X-Debbugs-Envelope-To: 67527 Cc: 67527@debbugs.gnu.org, simon@ecksd.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.8 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Eli Zaretskii writes: >> > I took a liberty to add back Eason to the discussion, in the hope that >> > he could explain why DEPTH of 10 didn't solve his situation. >> > >> Because I don't have any ohter capf backends in th [...] Content analysis details: (2.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [203.205.221.202 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [203.205.221.202 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (aqua0210[at]foxmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (aqua0210[at]foxmail.com) 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) Eli Zaretskii writes: >> > I took a liberty to add back Eason to the discussion, in the hope that >> > he could explain why DEPTH of 10 didn't solve his situation. >> > >> Because I don't have any ohter capf backends in the org buffer(outside >> the SRC code block), ispell-completion-at-point is the only one. >> >> When the cursor is inside the SRC code block, no this issue. > > I guess I'm confused. In your original report, which started this > discussion, you said: > > Because when I enable the autocomplete by corfu or company, it will > always popup the candidate when I input English characters. > I don't want to diable the autocomplete of corfu or company, because I > need it in org code block. > > I was asking about that part in your report -- how did the new support > for completion-at-point in text mode and its descendants change the > behavior when you enable autocomplete by corfu or company, and why > were you talking about disabling autocomplete of corfu and company? > I have `cape-elisp-block` capf backend in org-buffer, and it only works in code block, that's why I need the autocomplete. I also need the `flyspell-mode` in org-mode, the `flyspell-mode` will add ispell-completion-at-point to capf, but when I input characters in org-buffer, I don't need the ispell-completion-at-point backend. Anyway, the below workaround works for me: ``` (add-hook 'text-mode-hook (lambda () (remove-hook 'completion-at-point-functions 'ispell-completion-at-point t))) ``` -- Eason Huang From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 20 04:19:55 2024 Received: (at 67527) by debbugs.gnu.org; 20 Jan 2024 09:19:55 +0000 Received: from localhost ([127.0.0.1]:60840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rR7W6-0006qf-J6 for submit@debbugs.gnu.org; Sat, 20 Jan 2024 04:19:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rR7W4-0006qM-CM for 67527@debbugs.gnu.org; Sat, 20 Jan 2024 04:19:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rR7Vt-0000JL-66; Sat, 20 Jan 2024 04:19:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=t4u5sEn4A4VH2cwLs70yjATkgsBla7HCo8WZxqJ0HUA=; b=hZVIYI29Hi3c 4BPHxaRmAM/RLMlwOSExAqcajZof3G/PUMEM4CGB7+aBvuW9zheZgscHOw1izP4DKbH0v4sy72vOF quxl5BfWgA7fc4EaAe3m4llz6Ev0FpdnpUSUtJdPcVrLCgqR3dCYtEhaCu1/KdsJESEoJGkGzePHN u5Cjtg304qYikU8sDFfUYzmgz8K/rBVJhnQeSyBqblcZWZYTPm7Mt1fwaKZq+gHeOAwnCbiV/GLLq RWCOD7QZdvPVZ6+JuBglG1x6vItF0IpNft3GuOpI4tFpSze+fX5Qg9yOweH1WEnPlp/9C8+QarEqa 5KQEsd9CV/dBZ8sCEAU+Xg==; Date: Sat, 20 Jan 2024 11:19:20 +0200 Message-Id: <83le8ktl9j.fsf@gnu.org> From: Eli Zaretskii To: Eason Huang , Eshel Yaron In-Reply-To: (message from Eason Huang on Sat, 13 Jan 2024 17:03:28 +0800) Subject: Re: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode References: <83jzoipr5v.fsf@gnu.org> <83ttniiqy3.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67527 Cc: 67527@debbugs.gnu.org, simon@ecksd.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Eason Huang > Cc: 67527@debbugs.gnu.org, simon@ecksd.com > Date: Sat, 13 Jan 2024 17:03:28 +0800 > > Eli Zaretskii writes: > > > I guess I'm confused. In your original report, which started this > > discussion, you said: > > > > Because when I enable the autocomplete by corfu or company, it will > > always popup the candidate when I input English characters. > > I don't want to diable the autocomplete of corfu or company, because I > > need it in org code block. > > > > I was asking about that part in your report -- how did the new support > > for completion-at-point in text mode and its descendants change the > > behavior when you enable autocomplete by corfu or company, and why > > were you talking about disabling autocomplete of corfu and company? > > > > I have `cape-elisp-block` capf backend in org-buffer, and it only > works in code block, that's why I need the autocomplete. > > I also need the `flyspell-mode` in org-mode, the `flyspell-mode` will add > ispell-completion-at-point to capf, but when I input characters in > org-buffer, I don't need the ispell-completion-at-point backend. > > Anyway, the below workaround works for me: > > ``` > (add-hook 'text-mode-hook > (lambda () > (remove-hook 'completion-at-point-functions 'ispell-completion-at-point t))) > ``` Thanks. Eshel, given this feedback, I think it would make sense to add a new defcustom that would make text-mode avoid adding ispell-completion-at-point to completion-at-point-functions. Would you please submit such a change and the documentation changes to go with it? TIA. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 20 04:46:16 2024 Received: (at 67527) by debbugs.gnu.org; 20 Jan 2024 09:46:17 +0000 Received: from localhost ([127.0.0.1]:60879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rR7vb-0003km-Vc for submit@debbugs.gnu.org; Sat, 20 Jan 2024 04:46:16 -0500 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:50171 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rR7vX-0003ZG-D8 for 67527@debbugs.gnu.org; Sat, 20 Jan 2024 04:46:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=TzBji7EoK8dgMki+It21pOjgJYvAkvuEYr5DFtDnewk=; b=yucDpjpZbvs79OCGdZDYuhZJ+w U3f0k9T1j/2qb7E/JAl5CFLH5IxUecORxv7LtCMnXCXTaFjq1S7JcAEDtwnmWzJXyqziMECZZqv0Q N6sZJYcPnEIWs8A2cPYYSjJrchMyT2mxv1T5IiR/VOyT2OtNbGWgHfDlNRzvaPGtyEP4=; From: Daniel Mendler To: Eli Zaretskii Subject: Re: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode In-Reply-To: <83le8ktl9j.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 20 Jan 2024 11:19:20 +0200") References: <83jzoipr5v.fsf@gnu.org> <83ttniiqy3.fsf@gnu.org> <83le8ktl9j.fsf@gnu.org> Date: Sat, 20 Jan 2024 10:46:00 +0100 Message-ID: <87jzo4ficn.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67527 Cc: 67527@debbugs.gnu.org, Eason Huang , Eshel Yaron , simon@ecksd.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Eason Huang >> Cc: 67527@debbugs.gnu.org, simon@ecksd.com >> Date: Sat, 13 Jan 2024 17:03:28 +0800 >> >> Eli Zaretskii writes: >> >> > I guess I'm confused. In your original report, which started this >> > discussion, you said: >> > >> > Because when I enable the autocomplete by corfu or company, it will >> > always popup the candidate when I input English characters. >> > I don't want to diable the autocomplete of corfu or company, because I >> > need it in org code block. >> > >> > I was asking about that part in your report -- how did the new support >> > for completion-at-point in text mode and its descendants change the >> > behavior when you enable autocomplete by corfu or company, and why >> > were you talking about disabling autocomplete of corfu and company? >> > >> >> I have `cape-elisp-block` capf backend in org-buffer, and it only >> works in code block, that's why I need the autocomplete. >> >> I also need the `flyspell-mode` in org-mode, the `flyspell-mode` will add >> ispell-completion-at-point to capf, but when I input characters in >> org-buffer, I don't need the ispell-completion-at-point backend. >> >> Anyway, the below workaround works for me: >> >> ``` >> (add-hook 'text-mode-hook >> (lambda () >> (remove-hook 'completion-at-point-functions 'ispell-completion-at-point t))) >> ``` > > Thanks. > > Eshel, given this feedback, I think it would make sense to add a new > defcustom that would make text-mode avoid adding > ispell-completion-at-point to completion-at-point-functions. Would > you please submit such a change and the documentation changes to go > with it? TIA. Maybe the existing defcustom `text-mode-meta-tab-ispell-complete-word' could be renamed and reused, taking three values? This way we avoid introducing multiple defcustoms for tweaking the same feature. - `command': Bind `ispell-complete-word' to TAB. - `capf': Add `ispell-completion-at-point' to the `completion-at-point-functions'. - `nil': None of the above. Daniel From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 20 05:29:27 2024 Received: (at 67527) by debbugs.gnu.org; 20 Jan 2024 10:29:27 +0000 Received: from localhost ([127.0.0.1]:32944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rR8bP-0002yh-21 for submit@debbugs.gnu.org; Sat, 20 Jan 2024 05:29:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rR8bM-0002yU-9y for 67527@debbugs.gnu.org; Sat, 20 Jan 2024 05:29:25 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rR8bB-0007An-8m; Sat, 20 Jan 2024 05:29:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=uAdLtegMR9Bj/joGbBjZ48zGRmgLEQk4V5yWYqEI9+E=; b=D2/TsxGtWXp2 VD0PkQs9borl3PsytQmOgXymRpY8ZWz2nDK90S+j26ADYHAPRsjbic0FJLhuXmtEw80d6xSetTQc7 y9MG5qyi6Yn+qjbTu2mp919nMAogDeIoweJ+dgzCloF0Fp459yJgLqz8ptFxHNyHHMH4QPh+BmAKN v/UvICP8jhe6EiODlLKgBps08utJZ4w7xkxu9nTqbwkmXsMKLvdMVvOOzuS7ThzeqeBQm8Ak8kCvB j46QxxH9rF4bTna0VMxK0W3jzL8dCgrCsyolXJ75wEEeq4Zm7y1wv198OA8KQW2gO3aeUl1ZzvPYP jOfVUbzMnmJrycq1qbiwAQ==; Date: Sat, 20 Jan 2024 12:28:53 +0200 Message-Id: <837ck4ti1m.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <87jzo4ficn.fsf@daniel-mendler.de> (message from Daniel Mendler on Sat, 20 Jan 2024 10:46:00 +0100) Subject: Re: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode References: <83jzoipr5v.fsf@gnu.org> <83ttniiqy3.fsf@gnu.org> <83le8ktl9j.fsf@gnu.org> <87jzo4ficn.fsf@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67527 Cc: 67527@debbugs.gnu.org, aqua0210@foxmail.com, me@eshelyaron.com, simon@ecksd.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Mendler > Cc: Eason Huang , Eshel Yaron , > 67527@debbugs.gnu.org, simon@ecksd.com > Date: Sat, 20 Jan 2024 10:46:00 +0100 > > Eli Zaretskii writes: > > > Eshel, given this feedback, I think it would make sense to add a new > > defcustom that would make text-mode avoid adding > > ispell-completion-at-point to completion-at-point-functions. Would > > you please submit such a change and the documentation changes to go > > with it? TIA. > > Maybe the existing defcustom `text-mode-meta-tab-ispell-complete-word' > could be renamed and reused, taking three values? This way we avoid > introducing multiple defcustoms for tweaking the same feature. > > - `command': Bind `ispell-complete-word' to TAB. > - `capf': Add `ispell-completion-at-point' to the > `completion-at-point-functions'. > - `nil': None of the above. Reused, yes. Renamed, I'd rather prefer we avoided that, as it causes compatibility problems. If we can extend its list of valid values to support this aspect as well, it would be good. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 20 05:34:00 2024 Received: (at 67527) by debbugs.gnu.org; 20 Jan 2024 10:34:00 +0000 Received: from localhost ([127.0.0.1]:32950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rR8fn-0005mY-Ry for submit@debbugs.gnu.org; Sat, 20 Jan 2024 05:34:00 -0500 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:58625 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rR8fl-0005mJ-R5 for 67527@debbugs.gnu.org; Sat, 20 Jan 2024 05:33:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+ZcC17sU9pGT7DYjH6N8F8kyDwpg7nB0fzrx5G4jp2c=; b=OxZSjO0Xy13+Jsa72TipzfPF2s ZkBVyvod7DhTMoCHdkpWmLrblqyn2MKUJYIlR7xPiN+ULDfnaKZSWlJy2oRd2mYi5dYtHqc7dcXBw 85TDwIE67sV2ejX+p2QZeRS2bv+A9WZGS9Lhp9vEubCoxrDGEmyXaM5KZLu/YJ1dAsc0=; From: Daniel Mendler To: Eli Zaretskii Subject: Re: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode In-Reply-To: <837ck4ti1m.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 20 Jan 2024 12:28:53 +0200") References: <83jzoipr5v.fsf@gnu.org> <83ttniiqy3.fsf@gnu.org> <83le8ktl9j.fsf@gnu.org> <87jzo4ficn.fsf@daniel-mendler.de> <837ck4ti1m.fsf@gnu.org> Date: Sat, 20 Jan 2024 11:33:47 +0100 Message-ID: <87h6j8fg50.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67527 Cc: 67527@debbugs.gnu.org, aqua0210@foxmail.com, me@eshelyaron.com, simon@ecksd.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Daniel Mendler >> Cc: Eason Huang , Eshel Yaron , >> 67527@debbugs.gnu.org, simon@ecksd.com >> Date: Sat, 20 Jan 2024 10:46:00 +0100 >> >> Eli Zaretskii writes: >> >> > Eshel, given this feedback, I think it would make sense to add a new >> > defcustom that would make text-mode avoid adding >> > ispell-completion-at-point to completion-at-point-functions. Would >> > you please submit such a change and the documentation changes to go >> > with it? TIA. >> >> Maybe the existing defcustom `text-mode-meta-tab-ispell-complete-word' >> could be renamed and reused, taking three values? This way we avoid >> introducing multiple defcustoms for tweaking the same feature. >> >> - `command': Bind `ispell-complete-word' to TAB. >> - `capf': Add `ispell-completion-at-point' to the >> `completion-at-point-functions'. >> - `nil': None of the above. > > Reused, yes. Renamed, I'd rather prefer we avoided that, as it causes > compatibility problems. If we can extend its list of valid values to > support this aspect as well, it would be good. Iiuc the variable was introduced a short while ago on Emacs master, so renaming it may still be possible? Daniel From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 20 05:57:10 2024 Received: (at 67527) by debbugs.gnu.org; 20 Jan 2024 10:57:10 +0000 Received: from localhost ([127.0.0.1]:32962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rR92D-0000dY-VY for submit@debbugs.gnu.org; Sat, 20 Jan 2024 05:57:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rR92A-0000d2-1j for 67527@debbugs.gnu.org; Sat, 20 Jan 2024 05:57:09 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rR91y-0000id-Ft; Sat, 20 Jan 2024 05:56:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=WUoK+SFY+xfYwQkR9oKPuEapzPFKAJXGX7aHg6/PEhU=; b=VrEZ9XTVwS3k Cc3hwjCWKBgZ60KPKeVzkbqcWy+/UhMKQaJAQzAbh9e4GTQKeSEn2Vr1PDM4IdiZqSB1lhHYihnU1 swdRKr9j82//IoKqngPOjs97Df0dhQxDZmy7Be5XE6Ml7MHY6oBZg6KwCQH9iMNOCWLN1uBltxz24 p5TAonq16+2bibX/EEBKshxecFfQvKSEbUIQYYZg+sKiQ2b6+aQnAUeogUZgsBtLwCxwYYCMxWn8y YNWdPfnPL3SCnPUKZuGRyWeKwWEt0pf4nZEtV4/UST2hucJUc1D8B778ZTOpvmUi7w6+e63K3rJvO 6J2vBhzoV0sRCmuXVq2PYg==; Date: Sat, 20 Jan 2024 12:56:33 +0200 Message-Id: <834jf8tgri.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <87h6j8fg50.fsf@daniel-mendler.de> (message from Daniel Mendler on Sat, 20 Jan 2024 11:33:47 +0100) Subject: Re: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode References: <83jzoipr5v.fsf@gnu.org> <83ttniiqy3.fsf@gnu.org> <83le8ktl9j.fsf@gnu.org> <87jzo4ficn.fsf@daniel-mendler.de> <837ck4ti1m.fsf@gnu.org> <87h6j8fg50.fsf@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67527 Cc: 67527@debbugs.gnu.org, aqua0210@foxmail.com, me@eshelyaron.com, simon@ecksd.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Mendler > Cc: aqua0210@foxmail.com, me@eshelyaron.com, 67527@debbugs.gnu.org, > simon@ecksd.com > Date: Sat, 20 Jan 2024 11:33:47 +0100 > > Eli Zaretskii writes: > > >> From: Daniel Mendler > >> Cc: Eason Huang , Eshel Yaron , > >> 67527@debbugs.gnu.org, simon@ecksd.com > >> Date: Sat, 20 Jan 2024 10:46:00 +0100 > >> > >> Eli Zaretskii writes: > >> > >> > Eshel, given this feedback, I think it would make sense to add a new > >> > defcustom that would make text-mode avoid adding > >> > ispell-completion-at-point to completion-at-point-functions. Would > >> > you please submit such a change and the documentation changes to go > >> > with it? TIA. > >> > >> Maybe the existing defcustom `text-mode-meta-tab-ispell-complete-word' > >> could be renamed and reused, taking three values? This way we avoid > >> introducing multiple defcustoms for tweaking the same feature. > >> > >> - `command': Bind `ispell-complete-word' to TAB. > >> - `capf': Add `ispell-completion-at-point' to the > >> `completion-at-point-functions'. > >> - `nil': None of the above. > > > > Reused, yes. Renamed, I'd rather prefer we avoided that, as it causes > > compatibility problems. If we can extend its list of valid values to > > support this aspect as well, it would be good. > > Iiuc the variable was introduced a short while ago on Emacs master, so > renaming it may still be possible? Oh, I think I confused it with another option. Yes, if it was introduced recently on master, we can rename it. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 20 06:33:34 2024 Received: (at 67527) by debbugs.gnu.org; 20 Jan 2024 11:33:35 +0000 Received: from localhost ([127.0.0.1]:33044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rR9bS-0001gX-A2 for submit@debbugs.gnu.org; Sat, 20 Jan 2024 06:33:34 -0500 Received: from mail.eshelyaron.com ([107.175.124.16]:49512 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rR9bP-0001gN-LE for 67527@debbugs.gnu.org; Sat, 20 Jan 2024 06:33:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1705750408; bh=z8Vjh6T+N9IvQG+tcK+ul++34iwC4yDXvtq40/esxxQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=dSPgbDoWsyqFKexwpsNwTQNlDDFDNJsu5Sb7C/mFpCrJqhW/8tzIumgw5G+0mA7XK LzgxaKr5xb0KhTqyK+/JmvUwLeQrqNbanovZ36Mk3kujZW7SHvoj32eLMYcPLPjdZW ViVwvtpFcw3koVYITTrr9/F5VZVEfXGNZ+s8ILIxv6NuWTo8QWpwD+LMKAHbr8hseu CStDaaZxuTif540wmENVyGl8nRREYo4PXyYaMo9iM7orChKkP0C3rAeA+PZbCf58CR r5wLdR4118RE3CYrLna/GX0OG3PcZ+puSpw1kOOk5Gku+h/+QfC2eniCvJYXJ2fo5T ta1OiSFX6x2Rw== From: Eshel Yaron To: Eli Zaretskii Subject: Re: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode In-Reply-To: <834jf8tgri.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 20 Jan 2024 12:56:33 +0200") References: <83jzoipr5v.fsf@gnu.org> <83ttniiqy3.fsf@gnu.org> <83le8ktl9j.fsf@gnu.org> <87jzo4ficn.fsf@daniel-mendler.de> <837ck4ti1m.fsf@gnu.org> <87h6j8fg50.fsf@daniel-mendler.de> <834jf8tgri.fsf@gnu.org> Date: Sat, 20 Jan 2024 12:33:25 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67527 Cc: Daniel Mendler , aqua0210@foxmail.com, 67527@debbugs.gnu.org, simon@ecksd.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi, Eli Zaretskii writes: >> From: Daniel Mendler >> >> Eli Zaretskii writes: >> >> >> From: Daniel Mendler >> >> >> >> Eli Zaretskii writes: >> >> >> >> > Eshel, given this feedback, I think it would make sense to add a new >> >> > defcustom that would make text-mode avoid adding >> >> > ispell-completion-at-point to completion-at-point-functions. Would >> >> > you please submit such a change and the documentation changes to go >> >> > with it? TIA. >> >> >> >> Maybe the existing defcustom `text-mode-meta-tab-ispell-complete-word' >> >> could be renamed and reused, taking three values? This way we avoid >> >> introducing multiple defcustoms for tweaking the same feature. >> >> >> >> - `command': Bind `ispell-complete-word' to TAB. >> >> - `capf': Add `ispell-completion-at-point' to the >> >> `completion-at-point-functions'. >> >> - `nil': None of the above. >> > >> > Reused, yes. Renamed, I'd rather prefer we avoided that, as it causes >> > compatibility problems. If we can extend its list of valid values to >> > support this aspect as well, it would be good. >> >> Iiuc the variable was introduced a short while ago on Emacs master, so >> renaming it may still be possible? > > Oh, I think I confused it with another option. Yes, if it was > introduced recently on master, we can rename it. SGTM, see attached patch below. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Optionally-avoid-extending-c-a-p-f-in-Text-mode-Bug-.patch >From 8ed03422c140be6a7f6f5352c2906b52a7c22a1d Mon Sep 17 00:00:00 2001 From: Eshel Yaron Date: Sat, 20 Jan 2024 12:24:32 +0100 Subject: [PATCH] Optionally avoid extending 'c-a-p-f' in Text mode (Bug#67527) * lisp/textmodes/text-mode.el (text-mode-meta-tab-ispell-complete-word): Rename to... (text-mode-ispell-word-completion): ...this. Extend with another option 'completion-at-point'. (text-mode): Only extend 'completion-at-point-functions' when 'text-mode-ispell-word-completion' is 'completion-at-point'. * etc/NEWS: Update. --- etc/NEWS | 13 +++++++------ lisp/textmodes/text-mode.el | 19 ++++++++++++++----- 2 files changed, 21 insertions(+), 11 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 013d76eb44b..c1b34d2765e 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1404,12 +1404,13 @@ files and save the changes. +++ ** 'M-TAB' now invokes 'completion-at-point' also in Text mode. -Text mode no longer binds 'M-TAB' to 'ispell-complete-word', and -instead this mode arranges for 'completion-at-point', globally bound -to 'M-TAB', to perform word completion as well. If you want 'M-TAB' -to invoke 'ispell-complete-word', as it did in previous Emacs -versions, customize the new user option -'text-mode-meta-tab-ispell-complete-word' to non-nil. +By default, Text mode no longer binds 'M-TAB' to +'ispell-complete-word'. Instead this mode arranges for +'completion-at-point', globally bound to 'M-TAB', to perform word +completion as well. You can have Text mode bind 'M-TAB' to +'ispell-complete-word' as it did in previous Emacs versions, or +disable Ispell word completion in Text mode altogether, by customizing +the new user option 'text-mode-ispell-word-completion'. ** 'pp' and 'pp-to-string' now always include a terminating newline. In the past they included a terminating newline in most cases but not all. diff --git a/lisp/textmodes/text-mode.el b/lisp/textmodes/text-mode.el index 7d3b47a9c03..87f6668cecb 100644 --- a/lisp/textmodes/text-mode.el +++ b/lisp/textmodes/text-mode.el @@ -75,8 +75,15 @@ text-mode-map Many other modes, such as `mail-mode' and `outline-mode', inherit all the commands defined in this map.") -(defcustom text-mode-meta-tab-ispell-complete-word nil - "Whether M-TAB invokes `ispell-complete-word' in Text mode. +(defcustom text-mode-ispell-word-completion 'completion-at-point + "How Text mode provides Ispell word completion. + +By default, this option is set to `completion-at-point', which +means that Text mode adds an Ispell word completion function to +`completion-at-point-functions'. Any other non-nil value says to +bind M-TAB directly to `ispell-complete-word' instead. If this +is nil, Text mode neither binds M-TAB to `ispell-complete-word' +nor does it extend `completion-at-point-functions'. This user option only takes effect when you customize it in Custom or with `setopt', not with `setq'." @@ -84,8 +91,9 @@ text-mode-meta-tab-ispell-complete-word :type 'boolean :version "30.1" :set (lambda (sym val) - (if (set sym val) - (keymap-set text-mode-map "C-M-i" #'ispell-complete-word) + (if (and (set sym val) + (not (eq val 'completion-at-point))) + (keymap-set text-mode-map "C-M-i" #'ispell-complete-word) (keymap-unset text-mode-map "C-M-i" t)))) (easy-menu-define text-mode-menu text-mode-map @@ -144,7 +152,8 @@ text-mode ;; Enable text conversion in this buffer. (setq-local text-conversion-style t) (add-hook 'context-menu-functions 'text-mode-context-menu 10 t) - (add-hook 'completion-at-point-functions #'ispell-completion-at-point 10 t)) + (when (eq text-mode-ispell-word-completion 'completion-at-point) + (add-hook 'completion-at-point-functions #'ispell-completion-at-point 10 t))) (define-derived-mode paragraph-indent-text-mode text-mode "Parindent" "Major mode for editing text, with leading spaces starting a paragraph. -- 2.42.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 27 04:56:45 2024 Received: (at 67527-done) by debbugs.gnu.org; 27 Jan 2024 09:56:45 +0000 Received: from localhost ([127.0.0.1]:53502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTfQa-0007Tj-HU for submit@debbugs.gnu.org; Sat, 27 Jan 2024 04:56:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTfQY-0007TV-DH for 67527-done@debbugs.gnu.org; Sat, 27 Jan 2024 04:56:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTfQI-0008CW-8i; Sat, 27 Jan 2024 04:56:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9/UUm1oajT83dMJxW1FTWoUe29Z/6+7SJv2uZ5DJhk0=; b=Ra8SqrWjB+W5 VfBtcq7qlTRSWH2KPg6UDmxgjQS41rpNDv/LbJAu3Z7mtHqSge9WzHo0vSQ6RNerpvYKux3TJDEmL v+0SEOByDsWaWfkOsKYcy1bl/83bQ28DJQzW+oUcTU/c/K1njLIxEq97j2aaEABv9eQlr2yLwjsNG /ar4C2sW3PwaGe7dnT8C/vglHR5UOwR9aXIPRaMMeHQPXkE99Uz2PzUaveUqFpDSoq38dS40fxAUm qdamJ/fZdrin2L8S13YNPm3Ky1MWEUNDNPyQFlHY75DxOWtEW4zXK3f//4HBaF2703Ln07G6rUoUK 4Sv3gUJuPw8y7jmUmABaoQ==; Date: Sat, 27 Jan 2024 11:56:24 +0200 Message-Id: <86o7d785h3.fsf@gnu.org> From: Eli Zaretskii To: Eshel Yaron In-Reply-To: (message from Eshel Yaron on Sat, 20 Jan 2024 12:33:25 +0100) Subject: Re: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode References: <83jzoipr5v.fsf@gnu.org> <83ttniiqy3.fsf@gnu.org> <83le8ktl9j.fsf@gnu.org> <87jzo4ficn.fsf@daniel-mendler.de> <837ck4ti1m.fsf@gnu.org> <87h6j8fg50.fsf@daniel-mendler.de> <834jf8tgri.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67527-done Cc: mail@daniel-mendler.de, aqua0210@foxmail.com, 67527-done@debbugs.gnu.org, simon@ecksd.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Eshel Yaron > Cc: Daniel Mendler , aqua0210@foxmail.com, > 67527@debbugs.gnu.org, simon@ecksd.com > Date: Sat, 20 Jan 2024 12:33:25 +0100 > > Eli Zaretskii writes: > > >> From: Daniel Mendler > >> > >> Eli Zaretskii writes: > >> > >> >> From: Daniel Mendler > >> >> > >> >> Eli Zaretskii writes: > >> >> > >> >> > Eshel, given this feedback, I think it would make sense to add a new > >> >> > defcustom that would make text-mode avoid adding > >> >> > ispell-completion-at-point to completion-at-point-functions. Would > >> >> > you please submit such a change and the documentation changes to go > >> >> > with it? TIA. > >> >> > >> >> Maybe the existing defcustom `text-mode-meta-tab-ispell-complete-word' > >> >> could be renamed and reused, taking three values? This way we avoid > >> >> introducing multiple defcustoms for tweaking the same feature. > >> >> > >> >> - `command': Bind `ispell-complete-word' to TAB. > >> >> - `capf': Add `ispell-completion-at-point' to the > >> >> `completion-at-point-functions'. > >> >> - `nil': None of the above. > >> > > >> > Reused, yes. Renamed, I'd rather prefer we avoided that, as it causes > >> > compatibility problems. If we can extend its list of valid values to > >> > support this aspect as well, it would be good. > >> > >> Iiuc the variable was introduced a short while ago on Emacs master, so > >> renaming it may still be possible? > > > > Oh, I think I confused it with another option. Yes, if it was > > introduced recently on master, we can rename it. > > SGTM, see attached patch below. Thanks, installed on master, and closing the bug. From unknown Wed Jun 18 23:11:09 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 24 Feb 2024 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator