GNU bug report logs - #67512
[PATCH 0/5] Add LibreWolf

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andrew Tropin <andrew <at> trop.in>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#67512: closed ([PATCH 0/5] Add LibreWolf)
Date: Fri, 12 Apr 2024 13:12:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 12 Apr 2024 16:11:05 +0300
with message-id <87jzl27ml2.fsf <at> trop.in>
and subject line Re: [bug#67512] [PATCH v7 0/3] Add LibreWolf
has caused the debbugs.gnu.org bug report #67512,
regarding [PATCH 0/5] Add LibreWolf
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
67512: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67512
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ian Eure <ian <at> retrospec.tv>
To: guix-patches <at> gnu.org
Cc: Ian Eure <ian <at> retrospec.tv>
Subject: [PATCH 0/5] Add LibreWolf
Date: Tue, 28 Nov 2023 12:09:56 -0800

I mentioned in #guix that I was working on a package for LibreWolf, and it was requested that I send in patches, so I am.  These changes are based on the firefox-esr package in nonguix; I've retained the copyright / authorship notices from there.

LibreWolf (https://librewolf.net/) is a fork of Firefox which removes the telemetry and advertising, and bundles uBlock Origin.  It doesn't have the redistribution issues that Firefox does, its name/logo are under MPL 2.0 and aren't trademarked.

I'm new to Guix, and not remotely a browser development expert, so I don't expect these are ready to be accepted yet, but I believe they're in good enough shape to have a discussion about.  They're working acceptably well for me, though I'm not currently daily driving Guix, so there may be issues I haven't encountered yet.

Guide to changes in this patchset
=================================

icu4c has been updated to 73.1, and the previous version kept as icu4c-71.  I encountered consistent failures of the node <at> 10.24.1 test suite with icu4c 73.1, so I kept that on 71.1.  icu4c is needed by many packages, so this change is the highest-impact in the patchset.

The (gnu packages wasm) module is unchanged from nonguix, except for the file header and module declaration.

The (gnu packages librewolf) module is a simplified/adapted version of (nongnu packages firefox).  The Firefox Nightly packages have been removed, as there's no LibreWolf equivalent.  I also didn't bring over the wayland variant, but I could, if that's desired.  I'm not sure why there are specific x11/wayland variants, as the packages for other distros don't seem to need this split.

The librewolf package has some functions duplicated from (gnu packages gnuzilla), which probably ought to get factored out and put somewhere, but I'm not sure if they should be in (gnu packages mozilla) or a different module.  Guidance would be appreciated here.

Ian Eure (5):
  gnu: icu4c: Update to 73.1.
  gnu: Add icu4c-71.
  gnu: node: Switch to icu4c-71.
  gnu: Add wasm packages.
  gnu: Add librewolf.

 gnu/packages/icu4c.scm     |  21 +-
 gnu/packages/librewolf.scm | 560 +++++++++++++++++++++++++++++++++++++
 gnu/packages/node.scm      |   4 +-
 gnu/packages/wasm.scm      | 273 ++++++++++++++++++
 4 files changed, 854 insertions(+), 4 deletions(-)
 create mode 100644 gnu/packages/librewolf.scm
 create mode 100644 gnu/packages/wasm.scm


base-commit: 2410a30f6c06d56b5589e0ad685bcdf09bb144bf
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Andrew Tropin <andrew <at> trop.in>
To: Ian Eure <ian <at> retrospec.tv>, 67512-done <at> debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>, Ian Eure <ian <at> retrospec.tv>
Subject: Re: [bug#67512] [PATCH v7 0/3] Add LibreWolf
Date: Fri, 12 Apr 2024 16:11:05 +0300

[Message part 4 (text/plain, inline)]

On 2024-04-06 08:04, Ian Eure wrote:

> Moves nss update to nss-3.98 / nss-certs-3.98 to avoid rebuilding thousands of packages.
>
> Rebases.
>
> Ian Eure (3):
>   gnu: Add nss-3.98.
>   gnu: Add nss-certs-3.98.
>   gnu: Add librewolf.
>
>  gnu/packages/certs.scm     |  16 +
>  gnu/packages/librewolf.scm | 621 +++++++++++++++++++++++++++++++++++++
>  gnu/packages/nss.scm       |  45 +++
>  3 files changed, 682 insertions(+)
>  create mode 100644 gnu/packages/librewolf.scm
>
>
> base-commit: ade6845da6cec99f3bca46faac9b2bad6877817e

Hi Ian,

tested those patches, didn't notice any issues.

Added pipewire to LD_LIBRARY_PATH to make screensharing on wayland to
work.

Added librewolf.scm to gnu/local.mk.

Pushed as
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3dc26b4eae

Thank you very much for you work!

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.