From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 28 15:11:04 2023 Received: (at submit) by debbugs.gnu.org; 28 Nov 2023 20:11:05 +0000 Received: from localhost ([127.0.0.1]:47760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r84QA-0003IP-Se for submit@debbugs.gnu.org; Tue, 28 Nov 2023 15:11:04 -0500 Received: from lists.gnu.org ([2001:470:142::17]:46076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r84Pu-0003He-Ku for submit@debbugs.gnu.org; Tue, 28 Nov 2023 15:11:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r84Pf-0007u6-JT for guix-patches@gnu.org; Tue, 28 Nov 2023 15:10:32 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r84Pc-00005j-K3 for guix-patches@gnu.org; Tue, 28 Nov 2023 15:10:31 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 929FA5C02BE; Tue, 28 Nov 2023 15:10:24 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 28 Nov 2023 15:10:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm3; t=1701202224; x=1701288624; bh=BJ/24/wJcL cN7UACcZWZebL3JneQX0YEeqISvoO37MI=; b=Jmh32c3AGGeaFY8NIFfgPVyQkB gnMaqHOGRNLIvEK/mK3fZonXy+bs1rSoIZxWabb0V9wOaD5jN0JN1ke2T9xTTeVE +FtekUXnoZ94CywMCuxXORRUAIeqVM3BvhI9kAZ2K8dDLyUDRoRWBWGtYjokGhbz on0XwqO5svIyrMX/oNj4hqRW2SgZ3uPB7otqOldedOrVHEJeT9dzHM0md6DUhdIZ NGNS4ouk+zPvuqD5vOnQYQ+3gZk0v4vdwRMWWihHJUioR5wVEkhRuc+Z9xm7ieAW Nu1JkucF/KMIS76+jGMqI+8+soOoV/Us71B7qPi8IU/jYByH0PTsxJoeD6jg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1701202224; x=1701288624; bh=BJ/24/wJcLcN7 UACcZWZebL3JneQX0YEeqISvoO37MI=; b=HbZ2oQwqAA6dZxAvwR7odA/WGIhWr 3WiXEJhJoIyLYmqCc4KF8M/+O4CVoF8cpmLQhWOlLTl8P+42ZsEeOr562MzPMLcA EJrMiRG2AuaVxbOpvdHp2zsQAx+cg1gp+p/xKmT/1kElPhtcqjMJUSpzlKyZJWbj jlNxjihXlSkkNQvuIS/Edd8NNzLUKTwXU2cQ2x5VHjqijoJ3xZMAfLDEIeccM0Kt PKqq4NJE0rb6NmJRrtbATZHjY/Ygajn3Xjr3bmeA3aCBJ4by5oSAr/yZodv+lDy0 x3kpvcEABHisllwVpz1l62O42W1baRn5P0tkR9cmhEvq+G2Or6S1Ihr+A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeifedgudefvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgggfestdekre dtredttdenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdr thhvqeenucggtffrrghtthgvrhhnpeegudekvddtvefhieejvdefvedugfejjeduuddvvd ekkefgleehudfhheegkeetgfenucffohhmrghinheplhhisghrvgifohhlfhdrnhgvthen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnse hrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Nov 2023 15:10:23 -0500 (EST) From: Ian Eure To: guix-patches@gnu.org Subject: [PATCH 0/5] Add LibreWolf Date: Tue, 28 Nov 2023 12:09:56 -0800 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=66.111.4.28; envelope-from=ian@retrospec.tv; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: submit Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) I mentioned in #guix that I was working on a package for LibreWolf, and it was requested that I send in patches, so I am. These changes are based on the firefox-esr package in nonguix; I've retained the copyright / authorship notices from there. LibreWolf (https://librewolf.net/) is a fork of Firefox which removes the telemetry and advertising, and bundles uBlock Origin. It doesn't have the redistribution issues that Firefox does, its name/logo are under MPL 2.0 and aren't trademarked. I'm new to Guix, and not remotely a browser development expert, so I don't expect these are ready to be accepted yet, but I believe they're in good enough shape to have a discussion about. They're working acceptably well for me, though I'm not currently daily driving Guix, so there may be issues I haven't encountered yet. Guide to changes in this patchset ================================= icu4c has been updated to 73.1, and the previous version kept as icu4c-71. I encountered consistent failures of the node@10.24.1 test suite with icu4c 73.1, so I kept that on 71.1. icu4c is needed by many packages, so this change is the highest-impact in the patchset. The (gnu packages wasm) module is unchanged from nonguix, except for the file header and module declaration. The (gnu packages librewolf) module is a simplified/adapted version of (nongnu packages firefox). The Firefox Nightly packages have been removed, as there's no LibreWolf equivalent. I also didn't bring over the wayland variant, but I could, if that's desired. I'm not sure why there are specific x11/wayland variants, as the packages for other distros don't seem to need this split. The librewolf package has some functions duplicated from (gnu packages gnuzilla), which probably ought to get factored out and put somewhere, but I'm not sure if they should be in (gnu packages mozilla) or a different module. Guidance would be appreciated here. Ian Eure (5): gnu: icu4c: Update to 73.1. gnu: Add icu4c-71. gnu: node: Switch to icu4c-71. gnu: Add wasm packages. gnu: Add librewolf. gnu/packages/icu4c.scm | 21 +- gnu/packages/librewolf.scm | 560 +++++++++++++++++++++++++++++++++++++ gnu/packages/node.scm | 4 +- gnu/packages/wasm.scm | 273 ++++++++++++++++++ 4 files changed, 854 insertions(+), 4 deletions(-) create mode 100644 gnu/packages/librewolf.scm create mode 100644 gnu/packages/wasm.scm base-commit: 2410a30f6c06d56b5589e0ad685bcdf09bb144bf -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 28 15:13:50 2023 Received: (at 67512) by debbugs.gnu.org; 28 Nov 2023 20:13:50 +0000 Received: from localhost ([127.0.0.1]:47784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r84Sq-0003Mu-Ii for submit@debbugs.gnu.org; Tue, 28 Nov 2023 15:13:50 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:33489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r84Sl-0003MF-HZ for 67512@debbugs.gnu.org; Tue, 28 Nov 2023 15:13:43 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4CD115C011A; Tue, 28 Nov 2023 15:13:31 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 28 Nov 2023 15:13:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1701202411; x= 1701288811; bh=mWDIOgM1C53qxx17F6v0soa9615bp3pdhpRrq61LvKM=; b=C klm0IUfwrSrBaYYUB7KuIbIPVwoOZnBQuPLCUwt2XMRbknwYxSgHHpvOmHUAfBIM RCsuWNu0uNcnSH56RCHVF9RtQM4m08VpFW9IyxTSQHB9WjHIvbNBFHa9nCcHmhRF 1UzPdkEHr+kIw2o+/b/7QifwTUH2ej8iGosGIohMq37DHXhjHBiF0S0hNSNBYlXA /EvE8lLMv3MycCX7fSmEoO2m+/g2gM6ZgBLEjWrQ9YLdI5nG2BW32pBgkkIfBsUw 48J5K2LuoS+yqdhAFK5Tblyfq5tfp8TFAMOp1KeV987tKqUA2/ZiD8IQMsRGHKB/ +YVkF3eyz92SZWkd9hxHA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1701202411; x= 1701288811; bh=mWDIOgM1C53qxx17F6v0soa9615bp3pdhpRrq61LvKM=; b=p ZghzIUpP6BVf3fsg54Cs+pj2ci/wz8Q1k/3ltxhtSFFNMHjxpAPwbTzYrgxYiWfw ukx5+JnYRkx8vX7746j65IVImlG7M/tJRw12CwIQFiUvfoaXzFaxlflvX00BpiYY Kx9cyvxXd6yx1M9IlSPNjfdfzY4E6wYhCb98jC1rhM6qIZHkzO+J/4Vv/yjPURnV 8G8Q2uxm85leaBEy6tNbARmxZgm/4hiP8+7PN5n6n0PzJq4L+cf0cmnT8Z/cU0QJ W8Fr9SEaTo/T0c1UIzXt6tKuMkRrF5TX1MyLt+A6GacGCnWR+1RzWOFYE1uhRGOy 102KIqgkJAYtToTnLwKiA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeifedgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgjfhgggfestd ekredtredttdenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgv tgdrthhvqeenucggtffrrghtthgvrhhnpeevveejffduvdetieeutefgueekvdefieeuvd evleefgefhudelfeetvdfgfeegjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Nov 2023 15:13:30 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH 1/5] gnu: icu4c: Update to 73.1. Date: Tue, 28 Nov 2023 12:13:05 -0800 Message-ID: <5ebb1528778467e817b168d3c7bdad3829d1451c.1701186634.git.ian@retrospec.tv> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/icu4c.scm (icu4c): Update to 73.1. Change-Id: I77b8186898494e5b677c2e0c4fb0a234747dbd29 --- gnu/packages/icu4c.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gnu/packages/icu4c.scm b/gnu/packages/icu4c.scm index 5aaf3a8361..64ae109952 100644 --- a/gnu/packages/icu4c.scm +++ b/gnu/packages/icu4c.scm @@ -45,7 +45,7 @@ (define-module (gnu packages icu4c) (define-public icu4c (package (name "icu4c") - (version "71.1") + (version "73.1") (source (origin (method url-fetch) (uri (string-append @@ -55,7 +55,8 @@ (define-public icu4c (string-map (lambda (x) (if (char=? x #\.) #\_ x)) version) "-src.tgz")) (sha256 - (base32 "1gqywaqj9jmdwrng9lm6inyqmi5j2cz36db9dcqg3yk13zjyd9v7")))) + (base32 + "0iccpdvc0kvpww5a31k9gjkqigyz016i7v80r9zamd34w4fl6mx4")))) (build-system gnu-build-system) (native-inputs (append (list python-minimal) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 28 15:13:54 2023 Received: (at 67512) by debbugs.gnu.org; 28 Nov 2023 20:13:54 +0000 Received: from localhost ([127.0.0.1]:47786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r84Ss-0003NA-ND for submit@debbugs.gnu.org; Tue, 28 Nov 2023 15:13:54 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:59075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r84Sm-0003MH-LX for 67512@debbugs.gnu.org; Tue, 28 Nov 2023 15:13:44 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 6D3ED5C025E; Tue, 28 Nov 2023 15:13:32 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 28 Nov 2023 15:13:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1701202412; x= 1701288812; bh=2L9fGLzl+XT0Acil3G2CmJXiHPmMK4e/E0+k7fl+obE=; b=L +Lr0tLFdU2cjkx0gPpglqwjIa7K9sRjRD1D7x+AIbVELP9cLJ6g3cdKtvErtDRNg ob5k2bKsxGOEtk8n1MEVDGXfwlvSiudLqOMAtzDeYTHmitpgqJyGU9PwR1J6sg3j jh4R1+gB1h45sXkA9+rvHD+v4MveqnA9gLZT/KRABAh5GwrJOKRm9wTSVswsqitN 1v5G6ecnl0wqwXNZ6ys7FKsaG0M20j0C1Qo7mQ3dZ1S0KEE+cSz9l0penilbvNah Fd9GwPidj6fmUbP0lEnoG6IUBwz3Fd9tuYGoscDky8EuFhGB1TYqiSYkq9+thisQ 5J8smGDndcbFtn/+nUJUg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1701202412; x= 1701288812; bh=2L9fGLzl+XT0Acil3G2CmJXiHPmMK4e/E0+k7fl+obE=; b=G BR/jTZ3gIspCtvNqUSu4pMCjPV0ufdfRBymMBWAGaO/zx4bjiOkF9DQMiXioaWxI fktYLX1K8q4aPOksGgRG655nsYbsgzFAMtSjjR4TMh4iiAgfyAgV9ypQ8O4Xn3gb 8oQ+znIPsMgyCwoO2s9GjV80sOOI/qZNwscHouHvgpYRSrINLrdSZN/vMZQWWQ7z 5rsTl1tXZIpdDWZXrsrXeun2Wn0k1/YDeb7V8NKD6fsRyERLBTrn9y13whZuSx/E wiUxQauXSpAAoXygjp9N/z9wBFZozpB5JO3PWnmi8/+fi4I3VF5y3sbgAy5Gx8ew 4EJb0nJBih5bXz3lG4jLg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeifedgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgjfhgggfestd ekredtredttdenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgv tgdrthhvqeenucggtffrrghtthgvrhhnpeejgedukeefleetjeegtdejveelgfektdeige elvdetheetjeegteeiieekhffgheenucffohhmrghinhepihgtuhdqphhrohhjvggtthdr ohhrghdpghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepihgrnhesrhgvthhrohhsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Nov 2023 15:13:31 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH 2/5] gnu: Add icu4c-71. Date: Tue, 28 Nov 2023 12:13:06 -0800 Message-ID: X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/icu4c.scm (icu4c-71): New variable. Change-Id: Iaff0df4d6aaa968cdc43f847bd2ced08d0f3a12e --- gnu/packages/icu4c.scm | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/gnu/packages/icu4c.scm b/gnu/packages/icu4c.scm index 64ae109952..376cbac5c6 100644 --- a/gnu/packages/icu4c.scm +++ b/gnu/packages/icu4c.scm @@ -110,6 +110,22 @@ (define-public icu4c (license x11) (home-page "http://site.icu-project.org/"))) +(define-public icu4c-71 + (package + (inherit icu4c) + (name "icu4c") + (version "71.1") + (source (origin + (method url-fetch) + (uri (string-append + "https://github.com/unicode-org/icu/releases/download/release-" + (string-map (lambda (x) (if (char=? x #\.) #\- x)) version) + "/icu4c-" + (string-map (lambda (x) (if (char=? x #\.) #\_ x)) version) + "-src.tgz")) + (sha256 + (base32 "1gqywaqj9jmdwrng9lm6inyqmi5j2cz36db9dcqg3yk13zjyd9v7")))))) + (define-public icu4c-70 (package (inherit icu4c) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 28 15:14:02 2023 Received: (at 67512) by debbugs.gnu.org; 28 Nov 2023 20:14:02 +0000 Received: from localhost ([127.0.0.1]:47788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r84Sw-0003NK-4J for submit@debbugs.gnu.org; Tue, 28 Nov 2023 15:14:02 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:34257) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r84Sn-0003MJ-OC for 67512@debbugs.gnu.org; Tue, 28 Nov 2023 15:13:46 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 78CB55C0245; Tue, 28 Nov 2023 15:13:33 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 28 Nov 2023 15:13:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1701202413; x= 1701288813; bh=9bCeScb0nTG+ahqUiR03jJDlvtqYrHOMchSxHi0S/Ok=; b=N tbCHnCKbaRJjHqGQJz3VklvF5rQ8Cbt99Mj+1cWVCPQT1bAK4zxXnFW0n5tmd+Af kLE3T26C2vCVqQMQHJc/biGZtXU6imiMjo1NpcvKoLI4+FFcpezHxtoR5s1r9oqk PUt4mTT/Nbh3YQE96GN0BG6E2iLO03HuEGHSOP+tHLu76JmV1cVTfs+nmgHqfS3+ joN/nn3Ff5sfnLmMtVrnpoWTqltB1sPK7RLDyYAnc8aKFRitW6fuJMJT368qa3Cp iHSKOBPmVO+ThekykhwcO1kwqXDrNvrhZgQT4Yzh8CnC14Br+qqeyLN6US+qn6Jx LgF/z0/gorZzeW7bySwtQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1701202413; x= 1701288813; bh=9bCeScb0nTG+ahqUiR03jJDlvtqYrHOMchSxHi0S/Ok=; b=t 4uFD50DtElmjwfNo/T6hAvpxdSv38rKzmslX5f1YCPF5KcENSmjBjaa8MdJSX+qI RCOT4xST+0rHaGdQyVxj8MBKMcuSCtD9iDDUyWkhD/QW8c7x7Zeq0PSbYl6hyU/w ayyhX+/SkYCQEmmapsIqXGsGMYhY25yk9Gb74tSqDXe6uBkBChlcvxMI00e5mQhC dkltstxim49VHnIbcfy/Km4/sH4GhMD6RYiIMagIplwgves7UdRxKlzBsS1xg7cP BwJWsrlmrChk//7No42UzUYPK5z/1W9Ue5Oy7AffvZ2Zw+PLEruy1dWqp3/i7PWb vdMb7DQi2T+3YkbqedwuQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeifedgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgjfhgggfestd ekredtredttdenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgv tgdrthhvqeenucggtffrrghtthgvrhhnpeevveejffduvdetieeutefgueekvdefieeuvd evleefgefhudelfeetvdfgfeegjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Nov 2023 15:13:32 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH 3/5] gnu: node: Switch to icu4c-71. Date: Tue, 28 Nov 2023 12:13:07 -0800 Message-ID: <962283668728cbee1d762202f07c4923394a6115.1701186634.git.ian@retrospec.tv> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/node.scm (node): Switch to icu4c-71. I encountered consistent test failures with icu4c 73.1. Change-Id: Iaad9a4f274f9e3b8736486b58f262a82304b0b5d --- gnu/packages/node.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm index 6e30ad486a..668847405d 100644 --- a/gnu/packages/node.scm +++ b/gnu/packages/node.scm @@ -290,7 +290,7 @@ (define-public node ;; Runtime dependencies for binaries used as a bootstrap. (list c-ares http-parser - icu4c + icu4c-71 libuv-for-node `(,nghttp2-for-node "lib") openssl-1.1 @@ -310,7 +310,7 @@ (define-public node coreutils c-ares http-parser - icu4c + icu4c-71 libuv-for-node `(,nghttp2-for-node "lib") openssl -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 28 15:14:04 2023 Received: (at 67512) by debbugs.gnu.org; 28 Nov 2023 20:14:04 +0000 Received: from localhost ([127.0.0.1]:47791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r84T4-0003Nv-4J for submit@debbugs.gnu.org; Tue, 28 Nov 2023 15:14:04 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:49057) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r84Sq-0003MS-5f for 67512@debbugs.gnu.org; Tue, 28 Nov 2023 15:13:50 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C52A75C02B6; Tue, 28 Nov 2023 15:13:35 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 28 Nov 2023 15:13:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1701202415; x=1701288815; bh=2dtbkvEb3dYM0vlLhXAiAdusTZqBJTKpGHy GdWGVYZw=; b=PSQmtvZEXlXRH3iAyxfHKj5FV36WejAbOz+FHrtHbV+K2eDjB7v Lq5OQuqQjM5G2YUSd9ctMeLE4DBLvAgxzQgVJQDBjkrpWXjjuam8UMwviajbcIkJ vMopgis0ZW/VLRDM1oD8rVco5EbnvVgZOxnRleFCNblTkQNS+mCOySn9r6Ch8RnW sr9NLqVAYhcTQ8w4+EQLou7GtD+MBHvvCrQ5i32KrWIY1G/NlbbwN/B8IVvsnOT5 /fvEktNqwgzp7hfXj17yGhORlUfpPzzC4FOv7xoBuEFrP6uO7S3rNlhWP23c9cg7 2wGFlJ2JJ9+rD1Q+lRxLAz9eh0aaoTRZgkQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1701202415; x=1701288815; bh=2dtbkvEb3dYM0vlLhXAiAdusTZqBJTKpGHy GdWGVYZw=; b=z7jdqvlYHPOPEFSDu8lxhpEUOa0Qqv1+B3w+VEEVw21MWoQhBOq aj4K8GvY69KtU88D9Xqtoe8DGWfVUP8g4VpeLZPPDwMIkx0bg9iyA/nmtKryruly pNyqNfysF0VFNlxHRzixum+3GeZieB7bxZzCU13K30KEaqhH1hQbyChfFrkgklbH zJNorPt+ihMtKiy/Q7PWbSr0+/KRmCLp1iXw11njMB384fWbzZVGfC3S8FxYsLlK g8ICWgsd5SLNbVSW22HIc1Io2W0PzoZRLbMwBPgiyC6mECOehvK0gGDMqu8KWeys n7V/TYVhQf13uOak3j4f2ukI1eCwZjQJVwQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeifedgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgjfhggtgfgse htkeertdertdejnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhp vggtrdhtvheqnecuggftrfgrthhtvghrnhepteetkeekgfeffeejudekteeigeejffekhf duheeileeitedvjeeiieeuffdvtdfhnecuffhomhgrihhnpehgnhhurdhorhhgpdhsvggr rhgthhhfohigrdhorhhgpdhgihhtlhgrsgdrtghomhdptghonhhtvghnthdrrhgvrggupd hmohiiihhllhgrrdhorhhgpdhgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Nov 2023 15:13:34 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH 5/5] gnu: Add librewolf. Date: Tue, 28 Nov 2023 12:13:09 -0800 Message-ID: X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/librewolf.scm (librewolf): New variable. Change-Id: Iea4dcf45bfaff118d1d9d6e871c4a4ff3e68a3b3 --- gnu/packages/librewolf.scm | 560 +++++++++++++++++++++++++++++++++++++ 1 file changed, 560 insertions(+) create mode 100644 gnu/packages/librewolf.scm diff --git a/gnu/packages/librewolf.scm b/gnu/packages/librewolf.scm new file mode 100644 index 0000000000..b1e890e518 --- /dev/null +++ b/gnu/packages/librewolf.scm @@ -0,0 +1,560 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2013, 2015 Andreas Enge +;;; Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019 Ludovic Courtès +;;; Copyright © 2014, 2015, 2016, 2017, 2018, 2019, 2020, 2021 Mark H Weaver +;;; Copyright © 2015 Sou Bunnbu +;;; Copyright © 2016, 2017, 2018, 2019 Efraim Flashner +;;; Copyright © 2016 Alex Griffin +;;; Copyright © 2017 Clément Lassieur +;;; Copyright © 2017, 2018 Nikita +;;; Copyright © 2017, 2018 ng0 +;;; Copyright © 2017, 2018, 2020 Tobias Geerinckx-Rice +;;; Copyright © 2018, 2020, 2022 Ricardo Wurmus +;;; Copyright © 2019 Ivan Petkov +;;; Copyright © 2020 Oleg Pykhalov +;;; Copyright © 2020 Jakub Kądziołka +;;; Copyright © 2019, 2020 Adrian Malacoda +;;; Copyright © 2020-2023 Jonathan Brielmaier +;;; Copyright © 2020 Zhu Zihao +;;; Copyright © 2021 pineapples +;;; Copyright © 2021 Brice Waegeneire +;;; Copyright © 2021, 2022, 2023 John Kehayias +;;; Copyright © 2022 Pierre Langlois +;;; Copyright © 2023 Tomas Volf +;;; Copyright © 2023 Ian Eure +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + + +(define-module (gnu packages librewolf) + #:use-module (guix build-system gnu) + #:use-module (guix build-system cargo) + #:use-module (guix build-system trivial) + #:use-module (guix download) + #:use-module ((guix licenses) #:prefix license:) + #:use-module (guix gexp) + #:use-module (guix packages) + #:use-module (guix utils) + #:use-module ((guix build utils) #:select (alist-replace)) + + #:use-module (gnu packages) + #:use-module (gnu packages assembly) + #:use-module (gnu packages autotools) + #:use-module (gnu packages base) + #:use-module (gnu packages bash) + #:use-module (gnu packages compression) + #:use-module (gnu packages crates-io) + #:use-module (gnu packages cups) + #:use-module (gnu packages fontutils) + #:use-module (gnu packages gl) + #:use-module (gnu packages glib) + #:use-module (gnu packages gnome) + #:use-module (gnu packages gtk) + #:use-module (gnu packages hunspell) + #:use-module (gnu packages icu4c) + #:use-module (gnu packages image) + #:use-module (gnu packages jemalloc) + #:use-module (gnu packages kerberos) + #:use-module (gnu packages libcanberra) + #:use-module (gnu packages libevent) + #:use-module (gnu packages libffi) + #:use-module (gnu packages linux) + #:use-module (gnu packages llvm) + #:use-module (gnu packages m4) + #:use-module (gnu packages node) + #:use-module (gnu packages nss) + #:use-module (gnu packages perl) + #:use-module (gnu packages pkg-config) + #:use-module (gnu packages pulseaudio) + #:use-module (gnu packages python) + #:use-module (gnu packages rust) + #:use-module (gnu packages rust-apps) + #:use-module (gnu packages speech) + #:use-module (gnu packages sqlite) + #:use-module (gnu packages video) + #:use-module (gnu packages wasm) + #:use-module (gnu packages xdisorg) + #:use-module (gnu packages xorg)) + +;; Define the versions of rust needed to build firefox, trying to match +;; upstream. See the file taskcluster/ci/toolchain/rust.yml at +;; https://searchfox.org under the particular firefox release, like +;; mozilla-esr102. +(define rust-librewolf rust) ; 1.60 is the default in Guix, 1.65 is the minimum. + +;; Update this id with every firefox update to its release date. +;; It's used for cache validation and therefore can lead to strange bugs. +(define %librewolf-build-id "20231120132923") + +(define-public librewolf + (package + (name "librewolf") + (version "120.0-2") + (source + (origin + (method url-fetch) + + (uri (string-append + "https://gitlab.com/api/v4/projects/32320088/packages/generic/librewolf-source/" + version "/librewolf-" version ".source.tar.gz")) + (sha256 + (base32 "17yiw4pql9pf2qgk5a6xjqjjbgplla7fflrw1ldgd07rzsjlvj4n")))) + (build-system gnu-build-system) + (arguments + (list + #:configure-flags #~(let ((clang #$(this-package-native-input "clang")) + (wasi-sysroot #$(this-package-native-input + "wasm32-wasi-clang-toolchain"))) + `("--enable-application=browser" + + ;; Configuration + "--with-system-jpeg" + "--with-system-zlib" + ;; "--with-system-png" ;require libpng-apng >= 1.6.35 + "--with-system-icu" + "--enable-system-ffi" + "--enable-system-pixman" + "--enable-jemalloc" + + ;; see https://bugs.gnu.org/32833 + "--with-system-nspr" + ;; "--with-system-nss" + + ,(string-append "--with-clang-path=" clang + "/bin/clang") + ,(string-append "--with-libclang-path=" clang + "/lib") + ,(string-append "--with-wasi-sysroot=" + wasi-sysroot "/wasm32-wasi") + + ;; Distribution + "--with-distribution-id=org.nonguix" + "--disable-official-branding" + "--with-app-name=librewolf" + "--with-app-basename=LibreWolf" + "--with-branding=browser/branding/librewolf" + + ;; Features + "--disable-tests" + "--disable-updater" + "--enable-pulseaudio" + "--disable-crashreporter" + "--allow-addon-sideload" + "--with-unsigned-addon-scopes=app,system" + + ;; Build details + "--disable-debug" + "--enable-rust-simd" + "--enable-release" + "--enable-optimize" + "--enable-strip" + "--enable-hardening" + "--disable-elf-hack")) + #:imported-modules %cargo-utils-modules + #:modules `((ice-9 regex) + (ice-9 string-fun) + (ice-9 ftw) + (srfi srfi-1) + (srfi srfi-26) + (rnrs bytevectors) + (rnrs io ports) + (guix elf) + (guix build gremlin) + ,@%gnu-build-system-modules) + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'fix-preferences + (lambda* (#:key inputs #:allow-other-keys) + (let ((port (open-file "browser/app/profile/firefox.js" + "a"))) + (define (write-setting key value) + (format port "~%pref(\"~a\", ~a);~%" key value) + (format #t + "fix-preferences: setting value of ~a to ~a~%" key + value)) + + ;; We should allow Firefox sandbox to read the store directory, + ;; because Firefox sandbox have access to /usr on FHS distros. + (write-setting + "security.sandbox.content.read_path_whitelist" + (string-append "\"" + (%store-directory) "/\"")) + + ;; XDG settings should be managed by Guix. + (write-setting "browser.shell.checkDefaultBrowser" + "false") + (close-port port)))) + (add-after 'fix-preferences 'fix-ffmpeg-runtime-linker + (lambda* (#:key inputs #:allow-other-keys) + (let* ((ffmpeg (assoc-ref inputs "ffmpeg")) + (libavcodec (string-append ffmpeg + "/lib/libavcodec.so"))) + ;; Arrange to load libavcodec.so by its absolute file name. + (substitute* "dom/media/platforms/ffmpeg/FFmpegRuntimeLinker.cpp" + (("libavcodec\\.so") + libavcodec))))) + (add-after 'patch-source-shebangs 'patch-cargo-checksums + (lambda _ + (use-modules (guix build cargo-utils)) + (let ((null-hash + ;; This is the SHA256 output of an empty string. + "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855")) + (for-each (lambda (file) + (format #t + "patch-cargo-checksums: patching checksums in ~a~%" + file) + (substitute* file + (("(checksum = )\".*\"" all name) + (string-append name "\"" null-hash + "\"")))) + (find-files "." "Cargo\\.lock$")) + (for-each generate-all-checksums + '("build" "dom/media" + "dom/webauthn" + "gfx" + "intl" + "js" + "media" + "modules" + "mozglue/static/rust" + "netwerk" + "remote" + "security/manager/ssl" + "servo" + "storage" + "third_party/rust" + "toolkit" + "xpcom/rust" + "services"))))) + (add-after 'patch-cargo-checksums 'remove-cargo-frozen-flag + (lambda _ + ;; Remove --frozen flag from cargo invokation, otherwise it'll + ;; complain that it's not able to change Cargo.lock. + ;; https://bugzilla.mozilla.org/show_bug.cgi?id=1726373 + (substitute* "build/RunCbindgen.py" + (("\"--frozen\",") + "")))) + (delete 'bootstrap) + (add-before 'configure 'patch-SpeechDispatcherService.cpp + (lambda _ + (let* ((lib "libspeechd.so.2") + (file + "dom/media/webspeech/synth/speechd/SpeechDispatcherService.cpp") + (old-content (call-with-input-file file + get-string-all))) + (substitute file + `((,(format #f "~s" lib) unquote + (λ (line _) + (string-replace-substring line lib + (string-append #$speech-dispatcher + "/lib/" + lib)))))) + (if (string=? old-content + (call-with-input-file file + get-string-all)) + (error + "substitute did nothing, phase requires an update"))))) + (add-before 'configure 'set-build-id + ;; Firefox will write the timestamp to output, which is harmful + ;; for reproducibility, so change it to a fixed date. Use a + ;; separate phase for easier modification with inherit. + (lambda _ + (setenv "MOZ_BUILD_DATE" + #$%librewolf-build-id))) + (replace 'configure + (lambda* (#:key inputs outputs configure-flags + #:allow-other-keys) + (setenv "AUTOCONF" + (string-append (assoc-ref inputs "autoconf") + "/bin/autoconf")) + (setenv "SHELL" + (which "bash")) + (setenv "CONFIG_SHELL" + (which "bash")) + (setenv "MACH_BUILD_PYTHON_NATIVE_PACKAGE_SOURCE" + "system") + ;; This should use the host info probably (does firefox build on + ;; non-x86_64 though?) + (setenv "GUIX_PYTHONPATH" + (string-append (getcwd) + "/obj-x86_64-pc-linux-gnu/_virtualenvs/build")) + + ;; Use Clang, Clang is 2x faster than GCC + (setenv "AR" "llvm-ar") + (setenv "NM" "llvm-nm") + (setenv "CC" "clang") + (setenv "CXX" "clang++") + (setenv "WASM_CC" + (string-append (assoc-ref inputs + "wasm32-wasi-clang-toolchain") + "/bin/clang")) + (setenv "WASM_CXX" + (string-append (assoc-ref inputs + "wasm32-wasi-clang-toolchain") + "/bin/clang++")) + + (setenv "MOZ_NOSPAM" "1") + + (setenv "MOZBUILD_STATE_PATH" + (getcwd)) + + (let* ((mozconfig (string-append (getcwd) "/mozconfig")) + (out (assoc-ref outputs "out")) + (flags (cons (string-append "--prefix=" out) + configure-flags))) + (format #t "build directory: ~s~%" + (getcwd)) + (format #t "configure flags: ~s~%" flags) + + (define write-flags + (lambda flags + (display (string-join (map (cut string-append + "ac_add_options " <>) + flags) "\n")) + (display "\n"))) + (with-output-to-file mozconfig + (lambda () + (apply write-flags flags) + ;; The following option unsets Telemetry Reporting. With the Addons Fiasco, + ;; Mozilla was found to be collecting user's data, including saved passwords and + ;; web form data, without users consent. Mozilla was also found shipping updates + ;; to systems without the user's knowledge or permission. + ;; As a result of this, use the following command to permanently disable + ;; telemetry reporting in Firefox. + (display "unset MOZ_TELEMETRY_REPORTING\n") + (display "mk_add_options MOZ_CRASHREPORTER=0\n") + (display "mk_add_options MOZ_DATA_REPORTING=0\n") + (display + "mk_add_options MOZ_SERVICES_HEALTHREPORT=0") + (display + "mk_add_options MOZ_TELEMETRY_REPORTING=0"))) + (setenv "MOZCONFIG" mozconfig)) + (invoke "./mach" "configure"))) + (replace 'build + (lambda* (#:key (make-flags '()) + (parallel-build? #t) #:allow-other-keys) + (apply invoke "./mach" "build" + ;; mach will use parallel build if possible by default + `(,@(if parallel-build? + '() + '("-j1")) ,@make-flags)))) + (add-after 'build 'neutralise-store-references + (lambda _ + ;; Mangle the store references to compilers & other build tools in + ;; about:buildconfig, reducing Firefox's closure by 1 GiB on x86-64. + (let* ((build-dir (car (scandir "." + (cut string-prefix? + "obj-" <>)))) + (file (string-append build-dir + "/dist/bin/chrome/toolkit/content/global/buildconfig.html"))) + (substitute* file + (((format #f "(~a/)([0-9a-df-np-sv-z]{32})" + (regexp-quote (%store-directory))) + _ store hash) + (string-append store + (string-take hash 8) + "" + (string-drop hash 8))))))) + (replace 'install + (lambda _ + (invoke "./mach" "install"))) + (add-after 'install 'wrap-program + (lambda* (#:key inputs outputs #:allow-other-keys) + ;; The following two functions are from Guix's icecat package in + ;; (gnu packages gnuzilla). See commit + ;; b7a0935420ee630a29b7e5ac73a32ba1eb24f00b. + (define (runpath-of lib) + (call-with-input-file lib + (compose elf-dynamic-info-runpath elf-dynamic-info + parse-elf get-bytevector-all))) + (define (runpaths-of-input label) + (let* ((dir (string-append (assoc-ref inputs label) + "/lib")) + (libs (find-files dir "\\.so$"))) + (append-map runpath-of libs))) + (let* ((out (assoc-ref outputs "out")) + (lib (string-append out "/lib")) + ;; TODO: make me a loop again + (mesa-lib (string-append (assoc-ref inputs + "mesa") + "/lib")) + ;; For the integration of native notifications + (libnotify-lib (string-append (assoc-ref inputs + "libnotify") + "/lib")) + ;; For hardware video acceleration via VA-API + (libva-lib (string-append (assoc-ref inputs + "libva") + "/lib")) + ;; VA-API is run in the RDD (Remote Data Decoder) sandbox + ;; and must be explicitly given access to files it needs. + ;; Rather than adding the whole store (as Nix had + ;; upstream do, see + ;; and + ;; linked upstream patches), we can just follow the + ;; runpaths of the needed libraries to add everything to + ;; LD_LIBRARY_PATH. These will then be accessible in the + ;; RDD sandbox. + (rdd-whitelist (map (cut string-append <> "/") + (delete-duplicates (append-map + runpaths-of-input + '("mesa" + "ffmpeg"))))) + (pulseaudio-lib (string-append (assoc-ref inputs + "pulseaudio") + "/lib")) + ;; For U2F and WebAuthn + (eudev-lib (string-append (assoc-ref inputs + "eudev") + "/lib")) + (gtk-share (string-append (assoc-ref inputs + "gtk+") + "/share"))) + (wrap-program (car (find-files lib "^librewolf$")) + `("LD_LIBRARY_PATH" prefix + (,mesa-lib ,libnotify-lib + ,libva-lib + ,pulseaudio-lib + ,eudev-lib + ,@rdd-whitelist)) + `("XDG_DATA_DIRS" prefix + (,gtk-share)) + `("MOZ_LEGACY_PROFILES" = + ("1")) + `("MOZ_ALLOW_DOWNGRADE" = + ("1")))))) + (add-after 'wrap-program 'install-desktop-entry + (lambda* (#:key outputs #:allow-other-keys) + (let* ((desktop-file + "taskcluster/docker/firefox-snap/firefox.desktop") + (applications (string-append #$output + "/share/applications"))) + (substitute* desktop-file + (("^Exec=firefox") + (string-append "Exec=" + #$output "/bin/librewolf")) + ;; "Firefox" -> "LibreWolf" in all the Name fields + (("^(Name.*)(Firefox)(.*)$" prefix _ suffix) + (string-append prefix "LibreWolf" suffix)) + ;; Remove non-Latin translations. + (("^Name\\[(ar|bn)\\]") + "") + ;; Replace "Firefox" in the keywords + (("^(Keywords.*)(Firefox)(.*)$" prefix _ suffix) + (string-append prefix "LibreWolf" suffix)) + (("Icon=.*") + "Icon=librewolf\n") + (("NewWindow") + "new-window") + (("NewPrivateWindow") + "new-private-window") + (("StartupNotify=true") + "StartupNotify=true +StartupWMClass=Navigator")) + (copy-file desktop-file "librewolf.desktop") + (install-file "librewolf.desktop" applications)))) + (add-after 'install-desktop-entry 'install-icons + (lambda* (#:key outputs #:allow-other-keys) + (let ((icon-source-dir (string-append #$output + "/lib/librewolf/browser/chrome/icons/default"))) + (for-each (lambda (size) + (let ((dest (string-append #$output + "/share/icons/hicolor/" + size + "x" + size + "/apps"))) + (mkdir-p dest) + (symlink (string-append icon-source-dir + "/default" size ".png") + (string-append dest + "/librewolf.png")))) + '("16" "32" "48" "64" "128")))))) + + ;; Test will significantly increase build time but with little rewards. + #:tests? #f + + ;; WARNING: Parallel build will consume lots of memory! + ;; If you have encountered OOM issue in build phase, try disable it. + #:parallel-build? #t + + ;; Some dynamic lib was determined at runtime, so rpath check may fail. + #:validate-runpath? #f)) + (inputs (list bash-minimal + bzip2 + cairo + cups + dbus-glib + freetype + ffmpeg + gdk-pixbuf + glib + gtk+ + gtk+-2 + hunspell + icu4c + jemalloc + libcanberra + libevent + libffi + libgnome + libjpeg-turbo + libnotify + ;; libpng-apng + libva + libvpx + libxcomposite + libxft + libxinerama + libxscrnsaver + libxt + mesa + mit-krb5 + nspr-4.32 + ;; nss + pango + pipewire + pixman + pulseaudio + speech-dispatcher + sqlite + startup-notification + eudev + unzip + zip + zlib)) + (native-inputs (list alsa-lib + autoconf-2.13 + `(,rust-librewolf "cargo") + clang + llvm + wasm32-wasi-clang-toolchain + m4 + nasm + node-lts + perl + pkg-config + python + rust-librewolf + rust-cbindgen-0.26 + which + yasm)) + (home-page "https://mozilla.org/firefox/") + (synopsis "Trademarkless version of Firefox") + (description + "Full-featured browser client built from Firefox source tree, without +the official icon and the name \"firefox\". This is the Extended Support +Release (ESR) version.") + (license license:mpl2.0))) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 28 15:14:13 2023 Received: (at 67512) by debbugs.gnu.org; 28 Nov 2023 20:14:13 +0000 Received: from localhost ([127.0.0.1]:47796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r84T7-0003OP-8L for submit@debbugs.gnu.org; Tue, 28 Nov 2023 15:14:13 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:35609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r84So-0003ML-Pv for 67512@debbugs.gnu.org; Tue, 28 Nov 2023 15:13:50 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8CC505C021C; Tue, 28 Nov 2023 15:13:34 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 28 Nov 2023 15:13:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1701202414; x=1701288814; bh=KBZlLCWoEJhX66/2Huvzkjyb3iA4+CL1lxU j6gOtgbc=; b=emGztUQKYrU+bxppW8Bu8rXrj8hO5eQRCLnDUzAnvV9w/V8png9 u2wnGlYAZSdaKBsY+6akbb7+2p2+FrExBvzCo8RbuG2b8Nx86hKh+X/Moy82NWQB aswhVDkLYGeqPMn5Ds+nFJihJwYYapxJdU5ojDqRn2RLZLlFlPt83233dvOtkKM6 cVrmwyjUTKgfiR2bMJDr/JzSs4gRGa1gb2aWHYFjVR0LGEWnb6W/HiGcnjUZ2vww ix/NpBJ6N4HUh0VCSx4Kkevg0U61t0QZIWZdW/GMN+jcErUWGNAOmzYAv4Bj56FU RbC3FyvFkZdeFltVUZ5d/J1vDKeX+keXM3w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1701202414; x=1701288814; bh=KBZlLCWoEJhX66/2Huvzkjyb3iA4+CL1lxU j6gOtgbc=; b=ul/u995HXfxxbVOzg1qeQrY2kaAomgVoqvMAS85/cGb4FFJCJaK Tzwe2ZF1Qht723CImkzS0dgKDljRQV+BdskzzpKr8cvS94MtxJQLJjlExmxYrQPi pNheSKVfVzR5wKE03qLUJUi1KOd9VkVzaxrH4XGCommDnVseY4qCea/EBs9BV+8G cekxl82G7ea7f2HeDh5xcgHw43srE4abSpLtV3dZUBca4JFyDU0KiFBS+6JZev2X KRCHETPkIMJxO4AHMcloyAEhhVw7lZQqs3UUEX2Q2+LYq7x2LHdXkH6CNTp7r7SL rY45d63TzFbY6Rc2S09nIF/RFyMzrwWhOrg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeifedgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgjfhggtgfgse htkeertdertdejnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhp vggtrdhtvheqnecuggftrfgrthhtvghrnhepudejffefudeluedvheeuhedtvefgkefgte evgeeljeelfeejhfdtveehvedtkeefnecuffhomhgrihhnpehgnhhurdhorhhgpdhgihht hhhusgdrtghomhdpmhhoiihilhhlrgdrohhrghdpfigrshhirdguvghvpdhllhhvmhdroh hrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehi rghnsehrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Nov 2023 15:13:33 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH 4/5] gnu: Add wasm packages. Date: Tue, 28 Nov 2023 12:13:08 -0800 Message-ID: X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/wasm.scm (wasi-libc): New variable. * gnu/packages/wasm.scm (wasm32-wasi-clang-runtime): New variable. * gnu/packages/wasm.scm (wasm32-wasi-clang): New variable. * gnu/packages/wasm.scm (wasm32-wasi-libcxx): New variable. * gnu/packages/wasm.scm (wasm32-wasi-clang-toolchain): New variable. Change-Id: I546cb6b7450b760379fb8c3043e48ffc5e714c68 --- gnu/packages/wasm.scm | 273 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 273 insertions(+) create mode 100644 gnu/packages/wasm.scm diff --git a/gnu/packages/wasm.scm b/gnu/packages/wasm.scm new file mode 100644 index 0000000000..05d247f333 --- /dev/null +++ b/gnu/packages/wasm.scm @@ -0,0 +1,273 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2022-2023 Pierre Langlois +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + +(define-module (gnu packages wasm) + #:use-module (guix base32) + #:use-module (guix gexp) + #:use-module (guix packages) + #:use-module ((guix licenses) #:prefix license:) + #:use-module (guix utils) + #:use-module (guix git-download) + #:use-module (guix build-system cmake) + #:use-module (guix build-system gnu) + #:use-module (guix build-system trivial) + #:use-module (gnu packages bash) + #:use-module (gnu packages llvm) + #:use-module (gnu packages python)) + +(define-public wasi-libc + (package + (name "wasi-libc") + (version "sdk-19") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/WebAssembly/wasi-libc") + (commit (string-append "wasi-" version)) + (recursive? #t))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0bnpz8wk9wiic938296gxp4vz820bvpi1w41jksjzz5552hql169")))) + (build-system gnu-build-system) + (native-inputs (list clang-15)) + (arguments + (list + #:tests? #f ;No test suite + ;; Firefox uses wasm2c to compile WebAssembly to C code, and it + ;; does not support the memory.copy opcode. + ;; See https://bugzilla.mozilla.org/show_bug.cgi?id=1773200#c4 + #:make-flags ''("BULK_MEMORY_SOURCES=") + #:phases #~(modify-phases %standard-phases + (delete 'configure) + (add-before 'build 'set-sysroot-include + (lambda _ + (setenv "C_INCLUDE_PATH" + (string-append (getcwd) "/sysroot/include")))) + (add-before 'install 'set-install-dir + (lambda _ + (setenv "INSTALL_DIR" + (string-append #$output "/wasm32-wasi"))))))) + (home-page "https://wasi.dev") + (synopsis "WASI libc implementation for WebAssembly") + (description + "WASI Libc is a libc for WebAssembly programs built on top of WASI +system calls. It provides a wide array of POSIX-compatible C APIs, including +support for standard I/O, file I/O, filesystem manipulation, memory +management, time, string, environment variables, program startup, and many +other APIs.") + (license (list + ;; For wasi-libc, with LLVM exceptions + license:asl2.0 + ;; For malloc.c. + license:cc0 + ;; For cloudlibc. + license:bsd-2 + ;; For wasi-libc and musl-libc. + license:expat)))) + +(define-public wasm32-wasi-clang-runtime + (package (inherit clang-runtime-15) + (native-inputs + (list clang-15 + wasi-libc)) + (inputs (list llvm-15)) + (arguments + (list + #:build-type "Release" + #:tests? #f + ;; Stripping binaries breaks wasm linking, resulting in the following + ;; error: "archive has no index; run ranlib to add one". + #:strip-binaries? #f + #:configure-flags + #~(list "-DCMAKE_C_COMPILER=clang" + "-DCMAKE_C_COMPILER_TARGET=wasm32-wasi" + (string-append + "-DCMAKE_SYSROOT=" #$wasi-libc "/wasm32-wasi") + (string-append + "-DCMAKE_C_FLAGS=-I " #$wasi-libc "/wasm32-wasi/include") + + "-DCOMPILER_RT_OS_DIR=wasi" + + "-DCOMPILER_RT_BAREMETAL_BUILD=On" + "-DCOMPILER_RT_DEFAULT_TARGET_ONLY=On" + + ;; WASM only needs libclang_rt.builtins-wasm32.a from + ;; compiler-rt. + "../source/compiler-rt/lib/builtins"))))) + +;; FIXME: Ideally we wouldn't need to build a separate compiler because clang +;; can support multiple targets at runtime. However Guix patches the default +;; clang with a specific clang-runtime package. It would be good to improve +;; upstream Guix's support for cross-compiling with clang. + +(define clang-from-llvm (@@ (gnu packages llvm) clang-from-llvm)) +(define llvm-monorepo (@@ (gnu packages llvm) llvm-monorepo)) + +(define-public wasm32-wasi-clang + (let ((base (clang-from-llvm llvm-15 wasm32-wasi-clang-runtime))) + (package + (inherit base) + (name "wasm32-wasi-clang") + (inputs (modify-inputs (package-inputs base) + (prepend wasi-libc))) + (arguments + (substitute-keyword-arguments (package-arguments base) + ((#:configure-flags flags) + #~(list "-DCLANG_INCLUDE_TESTS=True" + ;; Use a sane default include directory. + (string-append "-DC_INCLUDE_DIRS=" + #$wasi-libc "/wasm32-wasi/include"))) + ((#:phases phases) + `(modify-phases ,phases + (delete 'symlink-cfi_ignorelist)))))))) + +(define-public wasm32-wasi-libcxx + (package + (name "wasm32-wasi-libcxx") + (version (package-version llvm-15)) + (source + (llvm-monorepo version)) + (build-system cmake-build-system) + (arguments + (list + #:configure-flags #~(list (string-append "-S ../source/runtimes") + + "-DLLVM_ENABLE_RUNTIMES=libcxx;libcxxabi" + + (string-append "-DCMAKE_SYSROOT=" + #$wasi-libc "/wasm32-wasi") + + (string-append "-DCMAKE_INCLUDE_PATH=" + #$wasi-libc + "/wasm32-wasi/include") + + (string-append "-DCMAKE_STAGING_PREFIX=" + #$output "/wasm32-wasi") + + "-DCMAKE_C_COMPILER=clang" + "-DCMAKE_C_COMPILER_WORKS=ON" + "-DCMAKE_CXX_COMPILER=clang++" + "-DCMAKE_CXX_COMPILER_WORKS=ON" + "-DCMAKE_C_COMPILER_TARGET=wasm32-wasi" + "-DCMAKE_CXX_COMPILER_TARGET=wasm32-wasi" + + "-DLIBCXX_LIBDIR_SUFFIX=/wasm32-wasi" + + "-DLIBCXX_ENABLE_EXCEPTIONS=OFF" + "-DLIBCXX_ENABLE_SHARED=OFF" + "-DLIBCXX_ENABLE_THREADS=OFF" + "-DLIBCXX_ENABLE_FILESYSTEM=OFF" + + "-DLIBCXXABI_LIBDIR_SUFFIX=/wasm32-wasi" + + "-DLIBCXXABI_ENABLE_EXCEPTIONS=OFF" + "-DLIBCXXABI_ENABLE_SHARED=OFF" + "-DLIBCXXABI_ENABLE_THREADS=OFF" + "-DLIBCXXABI_ENABLE_FILESYSTEM=OFF") + #:tests? #f + #:phases #~(modify-phases %standard-phases + (add-after 'set-paths 'adjust-CPLUS_INCLUDE_PATH + (lambda _ + (setenv "CPLUS_INCLUDE_PATH" + (string-append #$wasi-libc + "/wasm32-wasi/include:" + (getenv "CPLUS_INCLUDE_PATH")))))))) + (native-inputs (list lld python wasm32-wasi-clang)) + (inputs (list wasi-libc)) + (home-page "https://libcxx.llvm.org") + (synopsis "C++ standard library for WebAssembly") + (description + "This package provides an implementation of the C++ standard library for +use with Clang, targeting C++11, C++14 and above. This package targets +WebAssembly with WASI.") + (license license:expat))) + +(define-public wasm32-wasi-clang-toolchain + (package + (name "wasm32-wasi-clang-toolchain") + (version (package-version wasm32-wasi-clang)) + (source + #f) + (build-system trivial-build-system) + (arguments + (list + #:builder (with-imported-modules '((guix build union) + (guix build utils)) + #~(begin + (use-modules (guix build union) + (guix build utils)) + (union-build #$output + (list #$wasm32-wasi-clang-runtime + #$wasi-libc + #$wasm32-wasi-libcxx)) + (mkdir-p (string-append #$output + "/bin")) + + ;; We provide clang and clang++ via a wrapped program that sets + ;; include paths correctly so that it does not include paths from + ;; the host. + + ;; FIXME: Review how we can provide better support for + ;; cross-compiling with clang in Guix, maybe adding support for + ;; the CROSS_C_INCLUDE_PATH and CROSS_CPLUS_INCLUDE_PATH + ;; environment variables like GCC. + + (for-each (lambda (bin) + (symlink (string-append #$wasm32-wasi-clang + bin) + (string-append #$output + bin)) + (wrap-program (string-append #$output + bin) + #:sh (string-append #$bash-minimal + "/bin/bash") + `("C_INCLUDE_PATH" + ":" = + (,(string-append #$output + "/wasm32-wasi/include"))) + `("CPLUS_INCLUDE_PATH" + ":" = + ;; Make sure inclure/c++/v1 comes first for #include_next + ;; to work. + (,(string-append #$output + "/wasm32-wasi/include/c++/v1") , + (string-append #$output + "/wasm32-wasi/include"))))) + '("/bin/clang" + "/bin/clang++")) + + (symlink (string-append #$lld + "/bin/wasm-ld") + (string-append #$output + "/bin/wasm-ld")))))) + (inputs (list bash-minimal + lld + wasi-libc + wasm32-wasi-clang + wasm32-wasi-clang-runtime + wasm32-wasi-libcxx)) + (license (cons (package-license wasm32-wasi-clang) + (package-license wasi-libc))) + (home-page "https://clang.llvm.org") + (synopsis + "Complete Clang toolchain for C/C++ development, for WebAssembly.") + (description + "This package provides a complete Clang toolchain for C/C++ +development targeting WebAssembly with WASI. This includes Clang, as well as +libc, libc++ and wasm-ld."))) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 10 16:57:50 2023 Received: (at 67512) by debbugs.gnu.org; 10 Dec 2023 21:57:51 +0000 Received: from localhost ([127.0.0.1]:51899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCRo6-0006ee-IL for submit@debbugs.gnu.org; Sun, 10 Dec 2023 16:57:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCRo4-0006eQ-6n for 67512@debbugs.gnu.org; Sun, 10 Dec 2023 16:57:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCRnk-00020f-05; Sun, 10 Dec 2023 16:57:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=/dDOo1nXFB95HsNolnQp01ZAZUOPtOHhMcuz/qZhRfY=; b=ZuRbW9WbdPsK/O8ad6eU Ox+R3A7LgP0qYQl+5AQMkY9WahCtWB9Ilj5VVUPbaMDs90iMp6OXcPzOHVlm8cx5HsxoheQHDRbCv yl6HOCNu4Ni6YdCN0eM+uktw+q9sBltPeeMrehgbqVNpsbPQmRhkiNCos3q4pEel9Vz8IUxPYpg2k 9P5a8c7C8c5y2gyMOiZ1KSVQfyoM550zgGgzWh5GTD84icS+X6WvAzO84jmJfJt5Fh2CtI0ZZJEw1 uGkp0JFEs3mXgp3EXGB1mzyN/Wrug3hJMIk0jrn+CXf8IY1y/l6TcUohwXYW+0RNEq82ju79TKgPo hRL62pDPuQbJmA==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Ian Eure Subject: Re: [bug#67512] [PATCH 0/5] Add LibreWolf In-Reply-To: (Ian Eure's message of "Tue, 28 Nov 2023 12:09:56 -0800") References: Date: Sun, 10 Dec 2023 22:57:26 +0100 Message-ID: <878r613em1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Ian Eure skribis: > I mentioned in #guix that I was working on a package for LibreWolf, and i= t was requested that I send in patches, so I am. These changes are based o= n the firefox-esr package in nonguix; I've retained the copyright / authors= hip notices from there. > > LibreWolf (https://librewolf.net/) is a fork of Firefox which removes the= telemetry and advertising, and bundles uBlock Origin. It doesn't have the= redistribution issues that Firefox does, its name/logo are under MPL 2.0 a= nd aren't trademarked. > > I'm new to Guix, and not remotely a browser development expert, so I don'= t expect these are ready to be accepted yet, but I believe they're in good = enough shape to have a discussion about. They're working acceptably well f= or me, though I'm not currently daily driving Guix, so there may be issues = I haven't encountered yet. This is much appreciated! People often complain that IceCat is based on too old a version of Firefox, so if we can have LibreWolf (or even Firefox without its problematic bits), that=E2=80=99s great. > The librewolf package has some functions duplicated from (gnu packages gn= uzilla), which probably ought to get factored out and put somewhere, but I'= m not sure if they should be in (gnu packages mozilla) or a different modul= e. Guidance would be appreciated here. To me that=E2=80=99s the main issue here: these packages are complex, and I wouldn=E2=80=99t want us to end up with two (or more!) copies of these beas= ts. As the person who made the changes, it would be great if you could pinpoint things that had to be changed compared to =E2=80=98icecat=E2=80=99= . What phases or flags differ? What phases can be factorized? Thanks for your hard work! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 10 17:42:17 2023 Received: (at 67512) by debbugs.gnu.org; 10 Dec 2023 22:42:17 +0000 Received: from localhost ([127.0.0.1]:51923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCSV7-0007ku-6e for submit@debbugs.gnu.org; Sun, 10 Dec 2023 17:42:17 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:60395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCSV3-0007kf-BL for 67512@debbugs.gnu.org; Sun, 10 Dec 2023 17:42:15 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id BC0B05C00C4; Sun, 10 Dec 2023 17:41:53 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sun, 10 Dec 2023 17:41:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1702248113; x=1702334513; bh=GRLtCsu73kEc2kUdAShjDhOq9h6miN5QA0n IjCxa+5g=; b=S2m7DwhVmEdyqBrnY7zpBmW9Evw18YfhWJzHKMktAX4uAst6UMR peRs4klu8A0By4qzDR9jTe+6PGMYQJDG1YP53Jb5DUl+VoTTqaGPw4ZwjcU6DH0J TF5MidOxXj/fdq/JV9W1q9Lwspc0ZLbcCV7UqlY0WQjQYZrYi738t0lNPGDAda1P dguOjyckMrLGUTvH45iKanR2NqR5Y+oa/sagiZoGjoifdtn90DcEjhwzVO2R9k0j hCFTb2eQOouwtSq6MjVz+5VcLKpBRmN/8GOnco0kPlrH6sBezW1qDNAo+ixdCuM+ yte9OEtdHcGp5ZDajnic/FhnhLY1QH+WdsA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1702248113; x=1702334513; bh=GRLtCsu73kEc2kUdAShjDhOq9h6miN5QA0n IjCxa+5g=; b=yUVUpoXjBIq74HGkRFbLQKnHrN1vHBRnpVYUB08JEEy9qqgR3vn fXWVF44a5SjcORzD/w1WeJwhGlAh6Y13dUkWc7FGt/dkckNxEXM542qrVImVfxR2 EBYRC0KgqBGUGJp0tnZIwqXY6+2E398DRHmuLYikKtkd9T203k3rjDWAP0ef7Onp FKdOBURLZ3FTqqu1oNTz8uLfFfAmtQJrVJOqvQRyKtq1IcyZOVoOmJanIE3D+x9Q EjqiBlLxnwKRxe0bxOoWNNY3uKUQCCUSoK92X1kwaRAA6UmNuJTHdbv5Ct1vtEtk HyaxsxlqXV7XMQFNxSBoUTLHbmBKG8EUTLg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeluddgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgfgsehtqhertddtreejnecuhfhrohhmpefkrghn ucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggtrdhtvheqnecuggftrfgrthhtvghrnh epgeduieejieehgeehueejteevgedtuefgieektdelfeekudeilefggfetgedukeeknecu ffhomhgrihhnpehlihgsrhgvfiholhhfrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepihgrnhesrhgvthhrohhsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 10 Dec 2023 17:41:53 -0500 (EST) References: <878r613em1.fsf@gnu.org> User-agent: mu4e 1.8.13; emacs 28.2 From: Ian Eure To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#67512] [PATCH 0/5] Add LibreWolf Date: Sun, 10 Dec 2023 14:28:35 -0800 In-reply-to: <878r613em1.fsf@gnu.org> Message-ID: <87h6kpk7db.fsf@retrospec.tv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, thank you very much for your comments. Ludovic Court=C3=A8s writes: > Hi! > > Ian Eure skribis: > >> I mentioned in #guix that I was working on a package for=20 >> LibreWolf, >> and it was requested that I send in patches, so I am. These=20 >> changes >> are based on the firefox-esr package in nonguix; I've retained=20 >> the >> copyright / authorship notices from there. >> >> LibreWolf (https://librewolf.net/) is a fork of Firefox which >> removes the telemetry and advertising, and bundles uBlock=20 >> Origin. >> It doesn't have the redistribution issues that Firefox does,=20 >> its >> name/logo are under MPL 2.0 and aren't trademarked. >> >> I'm new to Guix, and not remotely a browser development expert,=20 >> so I >> don't expect these are ready to be accepted yet, but I believe >> they're in good enough shape to have a discussion about.=20 >> They're >> working acceptably well for me, though I'm not currently daily >> driving Guix, so there may be issues I haven't encountered yet. > > This is much appreciated! People often complain that IceCat is=20 > based on > too old a version of Firefox, so if we can have LibreWolf (or=20 > even > Firefox without its problematic bits), that=E2=80=99s great. > IMO, LibreWolf pretty much is Firefox without the problematic=20 bits. It=E2=80=99s been my default browser for several years, and I=E2=80=99m ver= y=20 satisfied with it. >> The librewolf package has some functions duplicated from (gnu >> packages gnuzilla), which probably ought to get factored out=20 >> and put >> somewhere, but I'm not sure if they should be in (gnu packages >> mozilla) or a different module. Guidance would be appreciated=20 >> here. > > To me that=E2=80=99s the main issue here: these packages are complex,=20 > and I > wouldn=E2=80=99t want us to end up with two (or more!) copies of these=20 > beasts. > > As the person who made the changes, it would be great if you=20 > could > pinpoint things that had to be changed compared to =E2=80=98icecat=E2=80= =99.=20 > What > phases or flags differ? What phases can be factorized? > This work isn=E2=80=99t based on the icecat package, but on the=20 firefox-esr package from nonguix. The duplication I refer to is two small=20 helper functions, `runpath-of' and `runpaths-of-input', totaling nine=20 lines of code; they=E2=80=99re flagged with a comment in the patch. As=20 mentioned in the cover letter, I=E2=80=99m happy to extract these, I just don=E2=80=99t = know=20 where they ought to be placed. They=E2=80=99re defined inside a lambda in a=20 gexp, which sounds like it may be challenging to put somewhere=20 accessible to both packages. Skimming the icecat package, not many of the build steps are=20 shared with librewolf, and factoring the commonalities out would IMO=20 result in overly complex, brittle, hard to maintain code that=E2=80=99s worse=20 than the slight duplication between the two packages. If there=E2=80=99s a=20 strong feeling that they must be accounted for, I=E2=80=99ll give it a try, but I don=E2=80=99t believe that it=E2=80=99s the best option. Thanks, =E2=80=94 Ian From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 14 13:39:50 2023 Received: (at 67512) by debbugs.gnu.org; 14 Dec 2023 18:39:50 +0000 Received: from localhost ([127.0.0.1]:50913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rDqcg-0000CP-7g for submit@debbugs.gnu.org; Thu, 14 Dec 2023 13:39:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rDqcf-0000CA-38 for 67512@debbugs.gnu.org; Thu, 14 Dec 2023 13:39:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDqcZ-0008A9-VR; Thu, 14 Dec 2023 13:39:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=cT25ZJq3RZrD8hyIVaAJRSfhC2eHfAaNW2LRzHYyoSQ=; b=Y4kwjfn2r5/iXRGAOSkm wWmiH0jmJnRnmWX8BVNEP7/gFQP87f/PKi6kPeCY0sBN73pwx8YjJhIFM61UisgIxv4QW13T+Da5s QMqpAoi0vMaBPLLHlFk+XncNnOsgWkdRC0XjAqmtiX8adG7bk1wEwLq3xh4rBq8/iGJK9Jl1OBR9p vdFD51c3FZy3WVXHjWJGgnmuDw+uVHUKc9u9NdO1YfRmmaV7AwPDe8Ue7RvZCDBe82lCkyrthx1qY jgvJ/iSJTpz19XNAXqfUh4a69+NdRAH8QNkP1e8Z4eLr/+c4hdetg6eH71jIHUeUmcMamNRaXqptq snI+myt7nGTNQg==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Ian Eure Subject: Re: [bug#67512] [PATCH 0/5] Add LibreWolf In-Reply-To: <87h6kpk7db.fsf@retrospec.tv> (Ian Eure's message of "Sun, 10 Dec 2023 14:28:35 -0800") References: <878r613em1.fsf@gnu.org> <87h6kpk7db.fsf@retrospec.tv> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quartidi 24 Frimaire an 232 de la =?utf-8?Q?R=C3=A9v?= =?utf-8?Q?olution=2C?= jour de l'Oseille X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 14 Dec 2023 19:39:40 +0100 Message-ID: <87sf44tyqb.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Ian, Ian Eure skribis: > Ludovic Court=C3=A8s writes: [...] >> This is much appreciated! People often complain that IceCat is >> based on >> too old a version of Firefox, so if we can have LibreWolf (or even >> Firefox without its problematic bits), that=E2=80=99s great. >> > > IMO, LibreWolf pretty much is Firefox without the problematic bits. > It=E2=80=99s been my default browser for several years, and I=E2=80=99m v= ery satisfied > with it. Perfect, then. >> As the person who made the changes, it would be great if you could >> pinpoint things that had to be changed compared to =E2=80=98icecat=E2=80= =99. What >> phases or flags differ? What phases can be factorized? >> > This work isn=E2=80=99t based on the icecat package, but on the firefox-e= sr > package from nonguix. The duplication I refer to is two small helper > functions, `runpath-of' and `runpaths-of-input', totaling nine lines > of code; they=E2=80=99re flagged with a comment in the patch. As mention= ed in > the cover letter, I=E2=80=99m happy to extract these, I just don=E2=80=99= t know where > they ought to be placed. They=E2=80=99re defined inside a lambda in a ge= xp, > which sounds like it may be challenging to put somewhere accessible to > both packages. > > Skimming the icecat package, not many of the build steps are shared > with librewolf, and factoring the commonalities out would IMO result > in overly complex, brittle, hard to maintain code that=E2=80=99s worse th= an > the slight duplication between the two packages. If there=E2=80=99s a st= rong > feeling that they must be accounted for, I=E2=80=99ll give it a try, but I > don=E2=80=99t believe that it=E2=80=99s the best option. Yeah, you=E2=80=99re right that factorizing can be a bad idea when misplace= d, so let=E2=80=99s keep it that way. I=E2=80=99ll take a closer look at the patches if nobody beats me at it! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 13 12:53:57 2024 Received: (at 67512) by debbugs.gnu.org; 13 Jan 2024 17:53:57 +0000 Received: from localhost ([127.0.0.1]:41002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOiCi-00022U-Ne for submit@debbugs.gnu.org; Sat, 13 Jan 2024 12:53:57 -0500 Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]:59195 helo=email.rimm.ee) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOiCg-00022E-8R for 67512@debbugs.gnu.org; Sat, 13 Jan 2024 12:53:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman; t=1673632595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=MlV4XxTIx0XYJ7F2JQOnlaLPqmXFb/g+b9jKp3lgGvc=; b=j5J11siTC/EE4rbm/YfKEGb05KFpWr2SpnBSaSUz0z1Zr3LvSxo7Dq0WqBq3ho0bysA19s uS5ac/w68fqDqfFAn+NLZQkpCDS3na2hRNCRrfFTiIc0SRTm1hMtdv5DifD2LIujY0EoH+ yXoLXnoNCsGDO98lHpcU4TdKGCQx1avMR51nGURVbvSp9wNOr/ZOgIGgvEGNxRuBRAfIUV WcIVu3Iod4z28LxRgyzfLXo5smyTiDgzk6PZWEWNSA0U7G8ESZ3DVqO1Izu+8QOeX/BgMz PwAOJ9QgsCVsr6YEbLvy17XNeIe3vhsmzqw+EPsXv+aNdYnmKv5scJG66NhCwg== Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id e60bb974 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Fri, 13 Jan 2023 17:56:34 +0000 (UTC) Date: Sat, 13 Jan 2024 18:53:43 +0100 From: Herman Rimm To: Ian Eure Subject: [bug#67512] [PATCH 5/5] gnu: Add librewolf. Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Score: 3.5 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Ian, You can enable --with-system-png flag since libpng-apng >= 1.6.35. These two icecat flags may be required for addons from gnuzilla.gnu.org: ;; Do not require addons in the global app or system directories to ;; be signed by Mozilla. "--with-unsigned-addon-scopes=app, system" "--allow-addon-sideload" Content analysis details: (3.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 TVD_RCVD_IP Message was received from an IP address 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [81.205.150.117 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Ian, You can enable --with-system-png flag since libpng-apng >= 1.6.35. These two icecat flags may be required for addons from gnuzilla.gnu.org: ;; Do not require addons in the global app or system directories to ;; be signed by Mozilla. "--with-unsigned-addon-scopes=app,system" "--allow-addon-sideload" Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [81.205.150.117 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Hi Ian, You can enable --with-system-png flag since libpng-apng >= 1.6.35. These two icecat flags may be required for addons from gnuzilla.gnu.org: ;; Do not require addons in the global app or system directories to ;; be signed by Mozilla. "--with-unsigned-addon-scopes=app,system" "--allow-addon-sideload" This icecat-minimal flag disables DRM: ;; The --disable-eme option is not available on aarch64. #$(if (target-aarch64?) "" "--disable-eme") Librewolf should not link to addons.mozilla.org, using this build phase from torbrowser: (add-before 'build 'fix-addons-placeholder (lambda _ (substitute* "toolkit/locales/en-US/toolkit/about/aboutAddons.ftl" (("addons.mozilla.org") "gnuzilla.gnu.org")))) Cheers, Herman From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 17 10:43:47 2024 Received: (at 67512) by debbugs.gnu.org; 17 Jan 2024 15:43:47 +0000 Received: from localhost ([127.0.0.1]:53066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rQ84x-0007wK-6K for submit@debbugs.gnu.org; Wed, 17 Jan 2024 10:43:47 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:54511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rQ84u-0007w6-Rg for 67512@debbugs.gnu.org; Wed, 17 Jan 2024 10:43:45 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 242DC3200A47; Wed, 17 Jan 2024 10:43:37 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 17 Jan 2024 10:43:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1705506216; x=1705592616; bh=gSWbu/qfENA8B2300JDQqakpuQVSWFZdPig539JPTJw=; b= Q8FX8KybH+qEybhIJuG4Byn9RcRx5PW3xdovXec0vTuLOd6sWyggTg1w1OWpd+Jh 4XSWpzuUQZyrdgT3d93Oza4ADtGNAwLCIN3Qkrs1atZDfMb+CbzoK1gVEIGpmKbn FRvqttjR4El+VrojYQ+j4icczWvgtOaKzjCy2PerOIRlz0OSgZJfidETH97JOocj mcZG4U8iuqqTPD4vevEBAdpGuQitsbMn7xWcQqAMxAh+Y9DbA62DhUSVjRRln4DY DppTc+gekw4mWDsbVK1mavJkST91ALw8ILJJHJREwYEB1rCA8o0L9Hw0v5FNdurK qocBBi9q3cW1D8PyRjrngg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1705506216; x= 1705592616; bh=gSWbu/qfENA8B2300JDQqakpuQVSWFZdPig539JPTJw=; b=A aMrQxNedQ7cF+YDQ419TDOYi13xGZEPnoBdTv2BS7DHY8ymc+033p/eTYZNmzUso G9gGhg6GFFlJnFrwxI/ICX7x7OHXvY5a+iJZhNgVgZh2KtSLyr9VmQLyMKn527kY 8sj64uxYYv1yFCn4p1T+W03ozUIgrVVSMle9w8kr0Mrw4NsLs4RaAr3Lud33jen3 bsec+v5K0JiilDRN8UDb7bX9/aWOSCpSCbvjCTBhd1jNqIUKOCLikr12CxW6G/ng rVvSSDBApcD5EFqZFD3iEbn/+vigds5qyKgvYtIB2XtqKApDWbUNvYIp9Luj1tWI Yi+Wqogyjk3Rup0UE8WSQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdejhedgjeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgfgsehtqhertddtreejnecuhfhrohhmpeevlhor mhgvnhhtucfnrghsshhivghurhcuoegtlhgvmhgvnhhtsehlrghsshhivghurhdrohhrgh eqnecuggftrfgrthhtvghrnhepheegudfhffegffeuleejteettefhtdegteegleekieev hfehteethffhvdefueejnecuffhomhgrihhnpehlihgsrhgvfiholhhfrdhnvghtnecuve hluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheptghlvghmvghn theslhgrshhsihgvuhhrrdhorhhg X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 17 Jan 2024 10:43:35 -0500 (EST) From: =?utf-8?Q?Cl=C3=A9ment_Lassieur?= To: Ian Eure , Pierre Langlois Subject: Re: [bug#67512] [PATCH 0/5] Add LibreWolf In-Reply-To: (Ian Eure's message of "Tue, 28 Nov 2023 12:09:56 -0800") References: Date: Wed, 17 Jan 2024 16:43:31 +0100 Message-ID: <87a5p49d98.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Ian and Pierre, Thank you for this! I hope to do a review soon. Meanwhile I have one question for Pierre: is there any reason why your Wasm work was contributed to Nonguix instead of Guix? It looks like it could be used by Icecat. Would you say it is ready to be added to the Guix repo? Thank you, Cl=C3=A9ment On Tue, Nov 28 2023, Ian Eure wrote: > I mentioned in #guix that I was working on a package for LibreWolf, and i= t was requested that I send in patches, so I am. These changes are based o= n the firefox-esr package in nonguix; I've retained the copyright / authors= hip notices from there. > > LibreWolf (https://librewolf.net/) is a fork of Firefox which removes the= telemetry and advertising, and bundles uBlock Origin. It doesn't have the= redistribution issues that Firefox does, its name/logo are under MPL 2.0 a= nd aren't trademarked. > > I'm new to Guix, and not remotely a browser development expert, so I don'= t expect these are ready to be accepted yet, but I believe they're in good = enough shape to have a discussion about. They're working acceptably well f= or me, though I'm not currently daily driving Guix, so there may be issues = I haven't encountered yet. > > Guide to changes in this patchset > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D > > icu4c has been updated to 73.1, and the previous version kept as icu4c-71= . I encountered consistent failures of the node@10.24.1 test suite with ic= u4c 73.1, so I kept that on 71.1. icu4c is needed by many packages, so thi= s change is the highest-impact in the patchset. > > The (gnu packages wasm) module is unchanged from nonguix, except for the = file header and module declaration. > > The (gnu packages librewolf) module is a simplified/adapted version of (n= ongnu packages firefox). The Firefox Nightly packages have been removed, a= s there's no LibreWolf equivalent. I also didn't bring over the wayland va= riant, but I could, if that's desired. I'm not sure why there are specific= x11/wayland variants, as the packages for other distros don't seem to need= this split. > > The librewolf package has some functions duplicated from (gnu packages gn= uzilla), which probably ought to get factored out and put somewhere, but I'= m not sure if they should be in (gnu packages mozilla) or a different modul= e. Guidance would be appreciated here. > > Ian Eure (5): > gnu: icu4c: Update to 73.1. > gnu: Add icu4c-71. > gnu: node: Switch to icu4c-71. > gnu: Add wasm packages. > gnu: Add librewolf. > > gnu/packages/icu4c.scm | 21 +- > gnu/packages/librewolf.scm | 560 +++++++++++++++++++++++++++++++++++++ > gnu/packages/node.scm | 4 +- > gnu/packages/wasm.scm | 273 ++++++++++++++++++ > 4 files changed, 854 insertions(+), 4 deletions(-) > create mode 100644 gnu/packages/librewolf.scm > create mode 100644 gnu/packages/wasm.scm > > > base-commit: 2410a30f6c06d56b5589e0ad685bcdf09bb144bf From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 28 16:54:30 2024 Received: (at 67512) by debbugs.gnu.org; 28 Jan 2024 21:54:30 +0000 Received: from localhost ([127.0.0.1]:58498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUD6j-0002Jy-TO for submit@debbugs.gnu.org; Sun, 28 Jan 2024 16:54:30 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:54257) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUD6h-0002Ja-E3 for 67512@debbugs.gnu.org; Sun, 28 Jan 2024 16:54:29 -0500 Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.nyi.internal (Postfix) with ESMTP id 0191F5C010F; Sun, 28 Jan 2024 16:54:14 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 28 Jan 2024 16:54:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1706478853; x=1706565253; bh=8KQi9lJWQppniK83CIqFV7tbcTawL0pbAcmoXmcZ7Wc=; b= SORGpkbQ37kJf7D9zdjnOXEmP8WE/HBHWoR/Hd/y9pbiaDAzbPfRv2QrTZi16Czh fpq9zJyZ2qzi9k2ggqyb6Nqan6FhWW0uhdGRL4tt8nBP42fjQ4p0xULzWfXdgN0K NELIEsuzRAqnw80qe+Nv5JTWvd13gNBTXD0VAboqa4dpvbSYjjEJWhY0kP2HIPOT lYZsqSYA8V5ThOjAyMB4rBE7WffXyMymd1e1VAgDK3CYBeH3rWJmT+9oPSizLoex DQXxTMS1onJ1G+pKZ6MF71rot8xL6PW6qZpRxeFXKOa829YLy2KKSrkzF5POsiXS 4Gq41cV1Sco4jGr04Dw60Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1706478853; x= 1706565253; bh=8KQi9lJWQppniK83CIqFV7tbcTawL0pbAcmoXmcZ7Wc=; b=x fiTaJ6LtFiPTfjusRElh1wjw0LE03nK3/Z/YAyUQjRY+rpJcgqabtISQzWAwYjhz Ov7NDVBIeYScjgOYxnvYW1cbGQnUbo0h5E4B3w4WNuMkFpTtOszAfT+PFx+U0rFy xxzEWXpEaxdCz3Mfb+X8h9FtyA9Azm54cwjAU437c+JanopLg6nNGZFc30kY0ien 24hNzldKb7I5TOuh0ofILgu4TCRv2mhXmAcLwb5wVYnmBs5gB1YlYnMQPspiXssH d6xb87w/NhUUJNHp/T8i0abN3v8B9f5yCNAk/yzRRwRzIb9ZWfK0OqHGnjwFVwS6 BPswH7fOkBr4T3nkt0dDg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrfedtvddgudehgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvfevufffjgfkgggtgfesthhqredttderjeenucfhrhhomhepkfgr nhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdrthhvqeenucggtffrrghtthgvrh hnpeduueelfeevleeivdetudffvdfhveehfeegieethfdvfeekfedvfeeugefhhfeutden ucffohhmrghinhepghhnuhdrohhrghdpmhhoiihilhhlrgdrohhrghdplhhisghrvgifoh hlfhdrnhgvthenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehirghnsehrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 28 Jan 2024 16:54:12 -0500 (EST) References: User-agent: mu4e 1.8.13; emacs 28.2 From: Ian Eure To: Herman Rimm Subject: Re: [bug#67512] [PATCH 5/5] gnu: Add librewolf. Date: Sun, 28 Jan 2024 13:23:40 -0800 In-reply-to: Message-ID: <87y1c92kfx.fsf@meson> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Herman Rimm writes: > Hi Ian, > > You can enable --with-system-png flag since libpng-apng >=3D=20 > 1.6.35. These > two icecat flags may be required for addons from=20 > gnuzilla.gnu.org: > Thanks, I=E2=80=99ve made this change, along with a few other fixes I=20 found over the last couple weeks. I=E2=80=99ll send an updated patch=20 series, but would like to resolve the issues you raise first, to=20 avoid repeatedly sending the patch series. > This icecat-minimal flag disables DRM: > > ;; The --disable-eme option is not available on aarch64. > #$(if (target-aarch64?) "" "--disable-eme") > LibreWolf disables DRM by default[1], so I don=E2=80=99t believe this flag= =20 is necessary. I can confirm that it=E2=80=99s disabled in the browser=20 built from the package definition without this flag. > Librewolf should not link to addons.mozilla.org, using this=20 > build phase > from torbrowser: > What=E2=80=99s the rationale for not using addons.mozilla.org? gnuzilla.gnu.org appears to be broken, it=E2=80=99s serving an Apache=20 default page, as if the vhost isn=E2=80=99t configured. Does the browser=20 request some path within that domain, which does work? I=E2=80=99m not=20 familiar with the mechanism used for this. =E2=80=94 Ian [1]: https://librewolf.net/docs/faq/#how-do-i-enable-drm From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 28 17:54:13 2024 Received: (at 67512) by debbugs.gnu.org; 28 Jan 2024 22:54:13 +0000 Received: from localhost ([127.0.0.1]:58586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUE2W-0004Eh-Ry for submit@debbugs.gnu.org; Sun, 28 Jan 2024 17:54:13 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:34745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUE2U-0004EP-BZ for 67512@debbugs.gnu.org; Sun, 28 Jan 2024 17:54:11 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 231915C01AC; Sun, 28 Jan 2024 17:53:57 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 28 Jan 2024 17:53:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1706482437; x=1706568837; bh=vJS0bJvLJusqDOO+8ZPRYBdriouHOR10kMtN7SXav0c=; b= fkph3KMk/gOaXdKLT3KlncFHy0qrT/8TVAA2ZH5TL+JVSSS/OcmjGQTyhJcUYzxQ FNtw5JhsXH2s6qArSMbsL92RAsedTDGPxBFOiefWkbyfUhXbyk6iYAtsaV5/Jc7P j7ubfRBZaDMu4XoiZ58+VyBxEuqbYXti7/Lw0pfUYfy5vFfvr0FTIRt7LmdLUQuw X6MJbf3+J7NK3yvY7gxsezfD1zAFaBg9Nwr9Vv91s5H3HfoR6QX3SPqH4/8RAL8c o5jgZcJihY2Sr4ZZLbstvJQ6RSCpPhvFlUMxreMTvijv9O1tQ43yb0ovaDdd7+d9 FYDY4t6L+b9jw9blD/1urw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1706482437; x= 1706568837; bh=vJS0bJvLJusqDOO+8ZPRYBdriouHOR10kMtN7SXav0c=; b=G mvawzGVYarmV7xGU5FotfZyCswHlVd2EyHnK8HsKXFqxqtWehtsjNS0ZXHih1WQu XaSOPQj5ZRtlMwtkww6a80qg4u1JE0K22+SDV55rLyOMpSg+mM7mVLqTqkf2i9QW 4TX+CdBOJwu5+pSC+9ufvQfiKy6NnuZXR/5AnKYeDuVu3KL/dv8YBZQ2PAnXxDfV 51z8C1R3u23zHyUlZGOUwuQDp+9MFIgXpS1MZGG0VsQmuO65D7lXedamGGunoH7o hDhZar5AlIh84kVePan/AeNQYarUSNYRhaeyZzTmsuFr3f7VFhQvrBKabaUONC9p E2514wTP/cIeZy+pNJ8nw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrfedtfedgtdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgfgsehtqhertddtreejnecuhfhrohhmpefkrghn ucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggtrdhtvheqnecuggftrfgrthhtvghrnh ephfelvedtieeffffggeeivdeukedutedtveejfffhleeileefheeggfdugfeiuefhnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihgrnhesrh gvthhrohhsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 28 Jan 2024 17:53:56 -0500 (EST) References: <87y1c92kfx.fsf@meson> User-agent: mu4e 1.8.13; emacs 28.2 From: Ian Eure To: Herman Rimm Subject: Re: [bug#67512] [PATCH 5/5] gnu: Add librewolf. Date: Sun, 28 Jan 2024 14:51:18 -0800 In-reply-to: <87y1c92kfx.fsf@meson> Message-ID: <87ttmx2hoc.fsf@meson> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Ian Eure writes: >> This icecat-minimal flag disables DRM: >> >> ;; The --disable-eme option is not available on aarch64. >> #$(if (target-aarch64?) "" "--disable-eme") >> > > LibreWolf disables DRM by default[1], so I don=E2=80=99t believe this=20 > flag is > necessary. I can confirm that it=E2=80=99s disabled in the browser=20 > built from > the package definition without this flag. > I looked a bit deeper into this. There are actually no=20 EME-related configuration options in Librewolf at all, either to=20 enable or disable it. It=E2=80=99s always disabled. =E2=80=94 Ian From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 02 13:45:16 2024 Received: (at 67512) by debbugs.gnu.org; 2 Feb 2024 18:45:16 +0000 Received: from localhost ([127.0.0.1]:45546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVyXM-0000x6-6R for submit@debbugs.gnu.org; Fri, 02 Feb 2024 13:45:16 -0500 Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]:42053 helo=email.rimm.ee) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVyXJ-0000wb-Fg for 67512@debbugs.gnu.org; Fri, 02 Feb 2024 13:45:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman; t=1706899494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZZC+OsIyVK8upQucha8VSw0UQPhRMldcaNs/JfS//Vg=; b=HyqV+3K8LuOyD5knffL06BD6XJzb1wJzG7y/eSHQ68EdFHVLiq+0/Gnv+aocbHl14stDSm z+loar/4fnrVU5HXmW8KmWM2E0CjeSnXAc96xxXvwXjMvm+wOuhmxV00d/dcev5JxpJziA B8n6DN4CI0xWYOpnTLbPtxq4nB0iuZcCbTbYLpbYsHlKG8HdwJG7wD6nbob4WUFZDvi4jR nuAUIr/tlqfaP2x4MaVYTJTW3HdpZAh+ejHd7B/UCdUExY/ZgJ5L1YopM6lviSk9ThYz+i I7rHK/ClAoJTszMQDUMdnWynGAJJvQWxkuUdvlnpYdl3K+bukqSc2Qb6OAgkEw== Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id 141d9aeb (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Fri, 2 Feb 2024 18:44:54 +0000 (UTC) Date: Fri, 2 Feb 2024 19:44:49 +0100 From: Herman Rimm To: Ian Eure Subject: [bug#67512] [PATCH 5/5] gnu: Add librewolf. Message-ID: References: <87y1c92kfx.fsf@meson> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87y1c92kfx.fsf@meson> X-Spam-Score: 3.5 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sun, Jan 28, 2024 at 01:23:40PM -0800, Ian Eure wrote: > > Herman Rimm writes: > > > Librewolf should not link to addons.mozilla.org, using this build phase > > from torbrowser: > [...] Content analysis details: (3.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 TVD_RCVD_IP Message was received from an IP address 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [81.205.150.117 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sun, Jan 28, 2024 at 01:23:40PM -0800, Ian Eure wrote: > > Herman Rimm writes: > > > Librewolf should not link to addons.mozilla.org, using this build phase > > from torbrowser: > [...] Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [81.205.150.117 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager On Sun, Jan 28, 2024 at 01:23:40PM -0800, Ian Eure wrote: > > Herman Rimm writes: > > > Librewolf should not link to addons.mozilla.org, using this build phase > > from torbrowser: > > > > What’s the rationale for not using addons.mozilla.org? > > gnuzilla.gnu.org appears to be broken, it’s serving an Apache default page, > as if the vhost isn’t configured. Does the browser request some path within > that domain, which does work? I’m not familiar with the mechanism used for > this. Apologies, the URL is: https://gnuzilla.gnu.org/mozzarella/. It is used because addons.mozilla.org contains nonfree extensions, from [1]: A free system distribution must not steer users towards obtaining any nonfree information for practical use, or encourage them to do so. The system should have no repositories for nonfree software and no specific recipes for installation of particular nonfree programs. Nor should the distribution refer to third-party repositories that are not committed to only including free software; even if they only have free software today, that may not be true tomorrow. Programs in the system should not suggest installing nonfree plugins, documentation, and so on. For instance, a free system distribution must not contain browsers that implement EME, the browser functionality designed to load DRM modules. >> LibreWolf disables DRM by default[1], so I don’t believe this flag is >> necessary. I can confirm that it’s disabled in the browser built from >> the package definition without this flag. >> > >I looked a bit deeper into this. There are actually no EME-related >configuration options in Librewolf at all, either to enable or disable it. >It’s always disabled. Interesting, I applied the patch series onto 551d013, built librewolf, removed ~/.librewolf and ~/.mozilla, started librewolf and went to about:config, where 'browser.eme.ui.enabled' has the default value 'true', so I can see and toggle the checkbox for 'play DRM-controlled content' in about:preferences. I don't know why 'browser.eme.ui.enabled' is 'true' by default for me, but I think adding --disable-eme will set the default to 'false', like it is in the icecat-minimal about:config. Looking at the firefox source [2], 'browser.eme.ui.enabled' is set to true if MOZ_WIDEVINE_EME is defined, false otherwise. MOZ_WIDEVINE_EME gets defined by being in MOZ_EME_MODULES, which is set to eme_modules in toolkit/moz.configure where a comment reads: # Widevine is enabled by default in desktop browser builds. When running grep in a Librewolf repo [3] for the aformentioned terms, only the --disable-jxl configure flag is modified in toolkit/ moz.configure, so I don't think the Librewolf developers disable EME. I am not sure though, I don't want to rebuild librewolf with the --disable-eme flag to look for the difference. Cheers, Herman [1]: https://www.gnu.org/distros/free-system-distribution-guidelines.en.html [2]: https://archive.mozilla.org/pub/firefox/releases/123.0b5/source/firefox-123.0b5.source.tar.xz [3]: https://codeberg.org/librewolf/source.git From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 06 23:00:11 2024 Received: (at 67512) by debbugs.gnu.org; 7 Feb 2024 04:00:11 +0000 Received: from localhost ([127.0.0.1]:55524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXZ6Y-0001MC-QI for submit@debbugs.gnu.org; Tue, 06 Feb 2024 23:00:11 -0500 Received: from wfhigh2-smtp.messagingengine.com ([64.147.123.153]:36059) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXZ6W-0001Kn-45 for 67512@debbugs.gnu.org; Tue, 06 Feb 2024 23:00:09 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.west.internal (Postfix) with ESMTP id 280FE1800081 for <67512@debbugs.gnu.org>; Tue, 6 Feb 2024 22:59:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 06 Feb 2024 22:59:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1707278387; x=1707364787; bh=0ohcfSsFjGaQF8b9S2+8LpE1QStEKKbDj3AuaPOLbwQ=; b= PpjCMO0KKFiLX0dbcDXJFk/CXUQWIWo8UGUoSoBcDqYv59t6RGDEaTVMEwbRseaa ZdydLsH0NTIJa3mfwEp5J4aD5j7uLErQ8SoeeD4Z135C9Fhpwb7axeQaiFGIXeav ytxqTEzPaxWrcLsytOL8XnLVOMuBj6ghNOrlCGK1n1gd+2t8QGSLTGP+KDHW724k w3+VMnAE3DWYIn9OWJZvJeuqX82Maq+VWSy4MogXx/oDXQm2l40wi/6IKhGycRtU jIFLPM29QaZGBgo5nznj9sWPsCmp+wH1WFVdW3eoEO4SdcGyWRIOjt93KDJa9REv W3Kr4ubCAvwLKYwtvks+GA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707278387; x= 1707364787; bh=0ohcfSsFjGaQF8b9S2+8LpE1QStEKKbDj3AuaPOLbwQ=; b=U w5SnRLm7Fjt9wfpldBPnFbtftUAJYARhnNLbBs4YtF8Yqj4gBYT+VJLDMRKk/tp6 45oC9cvnpv2kBCtHGZE7PjFHtRbHwd4/8PqpgowqTWE659YMoMvzFrrXEyf1WKQl RAwfvOFlOPjEY5eE/+epDzspxIK4L25oMsFT3VJGqkxkHHom/ZGkd7WefvSTa9HI a1vVufU9u2NmEse4h+AB+JjnDTsVt9J5deuIPceY+fM6B8IWzOxS00P7duwhJoES V+378pZoSmAW7u7fy+1kXhxxz88ivmp6OorHhQnnU5Crk9X8k77m/Vk7vm6jtFYm fZwn66xxREMEk75oU/bjQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrtddugdeigecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfhgfhffvufffjgfkgggtgfesthhqre dttderjeenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdr thhvqeenucggtffrrghtthgvrhhnpeehteffudelgeehhedvhfdvvdfhtdfhffelleelke evgeffueetgffgfefhuefhveenucffohhmrghinhepmhhoiihilhhlrgdrohhrghdpghhn uhdrohhrghdpnhhuvghvohguvghvvghlrdgtohhmpdhgihhtlhgrsgdrtghomhenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvght rhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <67512@debbugs.gnu.org>; Tue, 6 Feb 2024 22:59:47 -0500 (EST) References: <87y1c92kfx.fsf@meson> User-agent: mu4e 1.8.13; emacs 28.2 From: Ian Eure To: 67512@debbugs.gnu.org Subject: Re: [bug#67512] [PATCH 5/5] gnu: Add librewolf. Date: Tue, 06 Feb 2024 15:29:22 -0800 In-reply-to: Message-ID: <874jekzzyl.fsf@retrospec.tv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Herman Rimm writes: > On Sun, Jan 28, 2024 at 01:23:40PM -0800, Ian Eure wrote: >> >> Herman Rimm writes: >> >> > Librewolf should not link to addons.mozilla.org, using this >> > build phase >> > from to [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [64.147.123.153 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 1.1 DATE_IN_PAST_03_06 Date: is 3 to 6 hours before Received: date 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: 67512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Herman Rimm writes: > On Sun, Jan 28, 2024 at 01:23:40PM -0800, Ian Eure wrote: >> >> Herman Rimm writes: >> >> > Librewolf should not link to addons.mozilla.org, using this=20 >> > build phase >> > from torbrowser: >> > >> >> What=E2=80=99s the rationale for not using addons.mozilla.org? >> >> gnuzilla.gnu.org appears to be broken, it=E2=80=99s serving an Apache=20 >> default page, >> as if the vhost isn=E2=80=99t configured. Does the browser request=20 >> some path within >> that domain, which does work? I=E2=80=99m not familiar with the=20 >> mechanism used for >> this. > > Apologies, the URL is: https://gnuzilla.gnu.org/mozzarella/. It=20 > is used > because addons.mozilla.org contains nonfree extensions, from=20 > [1]: > I=E2=80=99ll look into this and see what it takes to adjust. >>> LibreWolf disables DRM by default[1], so I don=E2=80=99t believe this=20 >>> flag is >>> necessary. I can confirm that it=E2=80=99s disabled in the browser=20 >>> built from >>> the package definition without this flag. >>> >> >>I looked a bit deeper into this. There are actually no=20 >>EME-related >>configuration options in Librewolf at all, either to enable or=20 >>disable it. >>It=E2=80=99s always disabled. > > Interesting, I applied the patch series onto 551d013, built=20 > librewolf, > removed ~/.librewolf and ~/.mozilla, started librewolf and went=20 > to > about:config, where 'browser.eme.ui.enabled' has the default=20 > value > 'true', so I can see and toggle the checkbox for 'play=20 > DRM-controlled > content' in about:preferences. I don't know why=20 > 'browser.eme.ui.enabled' > is 'true' by default for me, but I think adding --disable-eme=20 > will set > the default to 'false', like it is in the icecat-minimal=20 > about:config. > I completely misunderstood the various settings and systems at=20 play here, which I believe led us to talk past each other. The=20 summary of the situation, best as I can tell, is this: - EME support: a build setting controlling whether the browser=20 supports *any kind* of encrypted media playback. - Widevine support: one kind of DRM, implemented as an EME plugin. - `browser.eme.ui.enabled' browser preference: controls whether=20 the UI for DRM is visible. Controls visibility *only*. A=20 browser build without EME will still show this if=20 `browser.eme.ui.enabled' is `true' (but the control does=20 nothing). A browser build *with* EME (and one or more DRM=20 plugins) can have this set to `false' and still play DRM=E2=80=99d=20 content. - The checkbox within the EME UI: On browsers built with EME and=20 DRM plugin(s), controls whether that is allowed to be used. On=20 browsers without EME+Widevine, does nothing. The default configuration of a clean install of a stock LibreWolf=20 build is: - The browser is built with EME and Widevine support - The UI to enable DRM is visible. - Within that UI, the checkbox is unchecked (meaning DRM is not=20 enabled). I have rebuilt with --disable-eme and confirmed that even with=20 browser.eme.ui.enabled=3Dtrue and the "Play DRM-controlled content"=20 box checked, the resulting build cannot play DRM=E2=80=99d streams. This=20 was actually somewhat difficult, since I don=E2=80=99t use or have access=20 to any commercial streaming service, but I found a website which=20 lets you test DRM playback, and used that to compare behavior of a=20 LibreWolf binary obtained from the project with my build. Should=20 anyone else want to verify, or need to do this kind of testing,=20 the site is: https://www.nuevodevel.com/nuevo/showcase/drm > When running grep in a Librewolf repo [3] for the aformentioned=20 > terms, > only the --disable-jxl configure flag is modified in toolkit/ > moz.configure, so I don't think the Librewolf developers disable=20 > EME.I > am not sure though, I don't want to rebuild librewolf with the > --disable-eme flag to look for the difference. > The "source" repo contains patches and orchestration to produce=20 the LibreWolf source tarball. The setting which disables DRM by=20 default is in their settings repo[1], which is a submodule. The=20 likely scenario is that you cloned the repo with the eminently=20 reasonable assumption that this would produce a full copy of its=20 contents, and grepped them. Unfortunately, Git submodules are=20 deeply unreasonable, and do not work this way -- you must perform=20 manual actions to populate or update them, which is very easy to=20 forget, especially if one doesn=E2=80=99t work with them regularly. LibreWolf=E2=80=99s specific wording is "We disable DRM by default," which= =20 I believe is accurate, but fails to capture the fullness of the=20 situation, i.e. that DRM support is included, but dormant. So=20 you=E2=80=99re also correct that they don=E2=80=99t disable EME -- the disa= bling=20 happens above that layer. This was not clear to me in the earlier=20 discussions. I=E2=80=99ve removed EME from the build, and will work on replacing=20 Mozilla=E2=80=99s addons with Mozarella, then send an updated patch=20 series. Separately, I=E2=80=99ve also managed to unbundle libpng,=20 libwebp, and nss; fixed the glxinfo utility program; and=20 eliminated a redundant copy of the main binary. Thanks, =E2=80=94 Ian [1]:=20 https://gitlab.com/librewolf-community/settings/-/blob/ba238a9ca6bfd509f31e= 6eb4a45c14c11b7ef7fe/librewolf.cfg#L258-263 From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 07 05:07:06 2024 Received: (at 67512) by debbugs.gnu.org; 7 Feb 2024 10:07:06 +0000 Received: from localhost ([127.0.0.1]:55744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXepd-00037S-Td for submit@debbugs.gnu.org; Wed, 07 Feb 2024 05:07:06 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:59761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXepa-00036w-L9 for 67512@debbugs.gnu.org; Wed, 07 Feb 2024 05:07:04 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 8BB4C3200A76; Wed, 7 Feb 2024 05:06:42 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 07 Feb 2024 05:06:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1707300402; x=1707386802; bh=2VZxz97pNP2YBOT30GTgLwKA4XODTFLPeqbElNTmHGw=; b= T3UNfjnynjMnRBcuFXnj23QOcYOhtaOMc/u5Lv1Y0EFp+/AzTr6FLtRQWvPNHpmT KupcZlolZ51VBqaCdTkr+Gh2WRj08lv+KiFxyCbxTLwZDmMPYkFojHN5dyeBI19U rn/8UMNrsApP9uYEFL7kjIMY6HBeelVUBKNz7lc5So8U4jxJTHZdGIOdqShdgtyt jkU7J3q56ewrF9d+aJcmkefGAwH5I+fr78LcTmVRKlYbDtBZoV9il4TzBMap/sKm k8zJA4dbxvDMQkbThRn2neE7KFuONchAMwjC7gsznKpXFmFiEeWUNASSrOAKGm1p hZyc5P4iCOf9lUe/5N9YSQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707300402; x= 1707386802; bh=2VZxz97pNP2YBOT30GTgLwKA4XODTFLPeqbElNTmHGw=; b=K Lk19LAI74zJWXE6s+pdzaZd09UeLADu/yQrY/lRwJNhWkOLwUQpNbBanMiFGCRZq RCUGEDoY02KWJjLXeS+/KI/9B2+9z2vR0vPekXaDn+tYXy4BOgT1ugGif8uEoNYG 5EU6HSfrwL1h0LboC0jR1EZOwm3DjNJHtTvXwEg/M5mcidNA3y43p2+inmUCstM9 c5otttKh+jM6h0ZX1dOGEvEUM2Ds8lOC20NBKlru5YDWZbNdWChJl4yQJwYe+AmA trxWjlrplX7stqaPxSxr4mrEAPoEH2nbWtW+XkvsRHS0MDDWk1hxdZBxJBUd3Vnn 3KO8HtTkOR+0hdKeYTLUA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrtddvgddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefujghffffkfgggtgfgsehtqh ertddtreejnecuhfhrohhmpeevlhormhgvnhhtucfnrghsshhivghurhcuoegtlhgvmhgv nhhtsehlrghsshhivghurhdrohhrgheqnecuggftrfgrthhtvghrnhepgeekheefffdtfe ffueevkefgfffhtddugfdugeeugeevgfduteffudfgfefhjedunecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheptghlvghmvghntheslhgrshhsih gvuhhrrdhorhhg X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 7 Feb 2024 05:06:41 -0500 (EST) From: =?utf-8?Q?Cl=C3=A9ment_Lassieur?= To: Ian Eure Subject: Re: [bug#67512] [PATCH 5/5] gnu: Add librewolf. In-Reply-To: <874jekzzyl.fsf@retrospec.tv> (Ian Eure's message of "Tue, 06 Feb 2024 15:29:22 -0800") References: <87y1c92kfx.fsf@meson> <874jekzzyl.fsf@retrospec.tv> Date: Wed, 07 Feb 2024 11:06:38 +0100 Message-ID: <87fry4k2q9.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Tue, Feb 06 2024, Ian Eure wrote: > I=E2=80=99ve removed EME from the build, and will work on replacing Mozil= la=E2=80=99s addons > with Mozarella, then send an updated patch series. For this you can just copy what's done in the Tor Browser package, which is a copy of what's done in upstream Icecat. Cheers From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 14:21:12 2024 Received: (at 67512) by debbugs.gnu.org; 11 Feb 2024 19:21:12 +0000 Received: from localhost ([127.0.0.1]:41276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZFO2-0005oT-Lf for submit@debbugs.gnu.org; Sun, 11 Feb 2024 14:21:12 -0500 Received: from fhigh4-smtp.messagingengine.com ([103.168.172.155]:59293) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZFNy-0005nd-80 for 67512@debbugs.gnu.org; Sun, 11 Feb 2024 14:21:09 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 59E11114007D; Sun, 11 Feb 2024 14:20:44 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 11 Feb 2024 14:20:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :subject:subject:to:to; s=fm2; t=1707679244; x=1707765644; bh=Et c6S9/5T7Im+FHY1F0OhmTE96jQ2Lzi+U31fD3M1ek=; b=XLNblvd/g8KAouOstd pKbCiSIvfL0S93yvox5fyFz3w534iT8nHYVsSyBQ0Vpb0uyHzApO/oonEbv7AVfN XPt3OU+sZd9iFSMmIcYx1gwHgXVYe6Xz7X5ehv4kZ8pDi8dBn9YQ4O8EdyUU7jMU DAssOPqeGDjkU+G9gXvdlXSf+wofKNcNkS+2InkuSc8MQoTL7P37uOjLpXEjRoVc pRO1FnAP/2eHHAKmVJ+D2PqeWXqZmUdknRtgmyS8lQH7iBdFXP+SnmbZHFcnNn9q sziIdwyUiThv8pFIgS4YtS+FZuaunh5BYEaL7DHumsBJgJ1kT2WQo2/+ibBnz0lp 8Hkg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1707679244; x=1707765644; bh=Etc6S9/5T7Im+ FHY1F0OhmTE96jQ2Lzi+U31fD3M1ek=; b=p74styJknUtagzhy5VNd8xEVyTi9O p/YCVqIsAeZSWHjW8G9SrS0QXpuMILkf1B+OoFlvUMhijdBBX6azRj/1mNqGr5Gc gic/Sml1dAiGLbxauVZ0hLJN+fS+BYpLZQbPORCl0zbNHKdspA2ooT4DxFAt729n Tc0USKgeoRmvkJ2KxioF9To+lwmFY4FCA7xCOxkXMcZIyaX8ySWoG7fkIqxoS1Bi jdCJ6Gk8Y68SlCX44A4GHwF+JTD9wl5+MaFr+gs5BpWcsMjmdAcyjZUJ1C2OJVIC 3O6roJmW3wd24GgCHatUMeXGnOMYIWs/cscq8a1ZgQSCLvOfmWVvqgG0g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddugdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffogggtgfesthekre dtredtjeenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdr thhvqeenucggtffrrghtthgvrhhnpeeiffehtdeiteffheetudduheetveekjedvudehvd eljeektedtueduledtudekkeenucffohhmrghinhepghhnuhdrohhrghdpshgvrghrtghh fhhogidrohhrghdpghhithhlrggsrdgtohhmpdgtohhnthgvnhhtrdhrvggrugdpmhhoii hilhhlrgdrohhrghdpghgvthgrugguohhnshdrshgvrghrtghhpdhgvghtrgguughonhhs rdhlihhnkhdpghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepihgrnhesrhgvthhrohhsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 11 Feb 2024 14:20:43 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v2 4/4] gnu: Add librewolf. Date: Sun, 11 Feb 2024 11:20:27 -0800 Message-ID: <20240211192031.32284-5-ian@retrospec.tv> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/librewolf.scm (librewolf): New variable. Change-Id: I98b6410582b856ede83b79637a58e66d6e5832e6 --- gnu/packages/librewolf.scm | 653 +++++++++++++++++++++++++++++++++++++ 1 file changed, 653 insertions(+) create mode 100644 gnu/packages/librewolf.scm diff --git a/gnu/packages/librewolf.scm b/gnu/packages/librewolf.scm new file mode 100644 index 0000000000..32d51eabaf --- /dev/null +++ b/gnu/packages/librewolf.scm @@ -0,0 +1,653 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2013, 2015, 2024 Andreas Enge +;;; Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019 Ludovic Courtès +;;; Copyright © 2014, 2015, 2016, 2017, 2018, 2019, 2020, 2021 Mark H Weaver +;;; Copyright © 2015 Sou Bunnbu +;;; Copyright © 2016, 2017, 2018, 2019 Efraim Flashner +;;; Copyright © 2016 Alex Griffin +;;; Copyright © 2017 Clément Lassieur +;;; Copyright © 2017, 2018 Nikita +;;; Copyright © 2017, 2018 ng0 +;;; Copyright © 2017, 2018, 2020 Tobias Geerinckx-Rice +;;; Copyright © 2018, 2020, 2022 Ricardo Wurmus +;;; Copyright © 2019 Ivan Petkov +;;; Copyright © 2020 Oleg Pykhalov +;;; Copyright © 2020 Jakub Kądziołka +;;; Copyright © 2019, 2020 Adrian Malacoda +;;; Copyright © 2020-2023 Jonathan Brielmaier +;;; Copyright © 2020 Zhu Zihao +;;; Copyright © 2021 pineapples +;;; Copyright © 2021 Brice Waegeneire +;;; Copyright © 2021, 2022, 2023 John Kehayias +;;; Copyright © 2022 Pierre Langlois +;;; Copyright © 2023 Tomas Volf +;;; Copyright © 2023 Ian Eure +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + + +(define-module (gnu packages librewolf) + #:use-module (guix build-system gnu) + #:use-module (guix build-system cargo) + #:use-module (guix build-system trivial) + #:use-module (guix download) + #:use-module ((guix licenses) #:prefix license:) + #:use-module (guix gexp) + #:use-module (guix packages) + #:use-module (guix utils) + #:use-module ((guix build utils) #:select (alist-replace)) + + #:use-module (gnu packages) + #:use-module (gnu packages assembly) + #:use-module (gnu packages autotools) + #:use-module (gnu packages base) + #:use-module (gnu packages bash) + #:use-module (gnu packages compression) + #:use-module (gnu packages crates-io) + #:use-module (gnu packages cups) + #:use-module (gnu packages fontutils) + #:use-module (gnu packages gl) + #:use-module (gnu packages glib) + #:use-module (gnu packages gnome) + #:use-module (gnu packages gtk) + #:use-module (gnu packages hunspell) + #:use-module (gnu packages icu4c) + #:use-module (gnu packages image) + #:use-module (gnu packages jemalloc) + #:use-module (gnu packages kerberos) + #:use-module (gnu packages libcanberra) + #:use-module (gnu packages libevent) + #:use-module (gnu packages libffi) + #:use-module (gnu packages linux) + #:use-module (gnu packages llvm) + #:use-module (gnu packages m4) + #:use-module (gnu packages node) + #:use-module (gnu packages nss) + #:use-module (gnu packages pciutils) + #:use-module (gnu packages perl) + #:use-module (gnu packages pkg-config) + #:use-module (gnu packages pulseaudio) + #:use-module (gnu packages python) + #:use-module (gnu packages rust) + #:use-module (gnu packages rust-apps) + #:use-module (gnu packages speech) + #:use-module (gnu packages sqlite) + #:use-module (gnu packages video) + #:use-module (gnu packages wasm) + #:use-module (gnu packages xdisorg) + #:use-module (gnu packages xorg)) + +;; Define the versions of rust needed to build firefox, trying to match +;; upstream. See the file taskcluster/ci/toolchain/rust.yml at +;; https://searchfox.org under the particular firefox release, like +;; mozilla-esr102. +(define rust-librewolf rust) ; 1.60 is the default in Guix, 1.65 is the minimum. + +;; Update this id with every firefox update to its release date. +;; It's used for cache validation and therefore can lead to strange bugs. +(define %librewolf-build-id "20240130195200") + +(define-public librewolf + (package + (name "librewolf") + (version "122.0-2") + (source + (origin + (method url-fetch) + + (uri (string-append "https://gitlab.com/api/v4/projects/32320088/" + "packages/generic/librewolf-source/" + version + "/librewolf-" + version + ".source.tar.gz")) + (sha256 + (base32 "0ggysgbazx5dl0l9dyvrpjgzbvivgddm9qyiyvjjfk9im9sljkxh")))) + (build-system gnu-build-system) + (arguments + (list + #:configure-flags #~(let ((clang #$(this-package-native-input "clang")) + (wasi-sysroot #$(this-package-native-input + "wasm32-wasi-clang-toolchain"))) + `("--enable-application=browser" + + ;; Configuration + "--with-system-jpeg" + "--with-system-zlib" + "--with-system-png" + "--with-system-webp" + "--with-system-icu" + "--with-system-libvpx" + "--with-system-libevent" + "--with-system-ffi" + "--enable-system-pixman" + "--enable-jemalloc" + + ;; see https://bugs.gnu.org/32833 + "--with-system-nspr" + "--with-system-nss" + + ,(string-append "--with-clang-path=" clang + "/bin/clang") + ,(string-append "--with-libclang-path=" clang + "/lib") + ,(string-append "--with-wasi-sysroot=" + wasi-sysroot "/wasm32-wasi") + + ;; Distribution + "--with-distribution-id=org.guix" + "--with-app-name=librewolf" + "--with-app-basename=LibreWolf" + "--with-branding=browser/branding/librewolf" + + ;; Features + "--disable-tests" + "--disable-updater" + "--enable-pulseaudio" + "--disable-crashreporter" + "--allow-addon-sideload" + "--with-unsigned-addon-scopes=app,system" + "--disable-eme" + + ;; Build details + "--disable-debug" + "--enable-rust-simd" + "--enable-release" + "--enable-optimize" + "--enable-strip" + "--enable-hardening" + "--disable-elf-hack")) + #:imported-modules %cargo-utils-modules + #:modules `((ice-9 regex) + (ice-9 string-fun) + (ice-9 ftw) + (srfi srfi-1) + (srfi srfi-26) + (rnrs bytevectors) + (rnrs io ports) + (guix elf) + (guix build gremlin) + ,@%gnu-build-system-modules) + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'fix-preferences + (lambda* (#:key inputs #:allow-other-keys) + (let ((port (open-file "browser/app/profile/firefox.js" + "a"))) + (define (write-setting key value) + (format port "~%pref(\"~a\", ~a);~%" key value) + (format #t + "fix-preferences: setting value of ~a to ~a~%" key + value)) + + ;; We should allow Firefox sandbox to read the store directory, + ;; because Firefox sandbox have access to /usr on FHS distros. + (write-setting + "security.sandbox.content.read_path_whitelist" + (string-append "\"" + (%store-directory) "/\"")) + + ;; XDG settings should be managed by Guix. + (write-setting "browser.shell.checkDefaultBrowser" + "false") + (close-port port)))) + (add-after 'fix-preferences 'fix-ffmpeg-runtime-linker + (lambda* (#:key inputs #:allow-other-keys) + (let* ((ffmpeg (assoc-ref inputs "ffmpeg")) + (libavcodec (string-append ffmpeg + "/lib/libavcodec.so"))) + ;; Arrange to load libavcodec.so by its absolute file name. + (substitute* "dom/media/platforms/ffmpeg/FFmpegRuntimeLinker.cpp" + (("libavcodec\\.so") + libavcodec))))) + (add-after 'patch-source-shebangs 'patch-cargo-checksums + (lambda _ + (use-modules (guix build cargo-utils)) + (let ((null-hash + ;; This is the SHA256 output of an empty string. + (string-append + "e3b0c44298fc1c149afbf4c8996fb924" + "27ae41e4649b934ca495991b7852b855"))) + (for-each (lambda (file) + (format #t + "patch-cargo-checksums: patching checksums in ~a~%" + file) + (substitute* file + (("(checksum = )\".*\"" all name) + (string-append name "\"" null-hash + "\"")))) + (find-files "." "Cargo\\.lock$")) + (for-each generate-all-checksums + '("build" "dom/media" + "dom/webauthn" + "gfx" + "intl" + "js" + "media" + "modules" + "mozglue/static/rust" + "netwerk" + "remote" + "security/manager/ssl" + "servo" + "storage" + "third_party/rust" + "toolkit" + "xpcom/rust" + "services"))))) + (add-after 'patch-cargo-checksums 'remove-cargo-frozen-flag + (lambda _ + ;; Remove --frozen flag from cargo invokation, otherwise it'll + ;; complain that it's not able to change Cargo.lock. + ;; https://bugzilla.mozilla.org/show_bug.cgi?id=1726373 + (substitute* "build/RunCbindgen.py" + (("\"--frozen\",") + "")))) + (delete 'bootstrap) + (add-before 'configure 'patch-SpeechDispatcherService.cpp + (lambda _ + (let* ((lib "libspeechd.so.2") + (file (string-append + "dom/media/webspeech/synth/" + "speechd/SpeechDispatcherService.cpp")) + (old-content (call-with-input-file file + get-string-all))) + (substitute file + `((,(format #f "~s" lib) unquote + (λ (line _) + (string-replace-substring line lib + (string-append #$speech-dispatcher + "/lib/" + lib)))))) + (if (string=? old-content + (call-with-input-file file + get-string-all)) + (error + "substitute did nothing, phase requires an update"))))) + (add-before 'configure 'set-build-id + ;; Firefox will write the timestamp to output, which is harmful + ;; for reproducibility, so change it to a fixed date. Use a + ;; separate phase for easier modification with inherit. + (lambda _ + (setenv "MOZ_BUILD_DATE" + #$%librewolf-build-id))) + (replace 'configure + (lambda* (#:key inputs outputs configure-flags + #:allow-other-keys) + (setenv "AUTOCONF" + (string-append (assoc-ref inputs "autoconf") + "/bin/autoconf")) + (setenv "SHELL" + (which "bash")) + (setenv "CONFIG_SHELL" + (which "bash")) + (setenv "MACH_BUILD_PYTHON_NATIVE_PACKAGE_SOURCE" + "system") + ;; This should use the host info probably (does firefox build on + ;; non-x86_64 though?) + (setenv "GUIX_PYTHONPATH" + (string-append (getcwd) + "/obj-x86_64-pc-linux-gnu/_virtualenvs/build")) + + ;; Use Clang, Clang is 2x faster than GCC + (setenv "AR" "llvm-ar") + (setenv "NM" "llvm-nm") + (setenv "CC" "clang") + (setenv "CXX" "clang++") + (setenv "WASM_CC" + (string-append (assoc-ref inputs + "wasm32-wasi-clang-toolchain") + "/bin/clang")) + (setenv "WASM_CXX" + (string-append (assoc-ref inputs + "wasm32-wasi-clang-toolchain") + "/bin/clang++")) + + (setenv "MOZ_NOSPAM" "1") + (setenv "MOZ_APP_NAME" "librewolf") + + (setenv "MOZBUILD_STATE_PATH" + (getcwd)) + + (let* ((mozconfig (string-append (getcwd) "/mozconfig")) + (out (assoc-ref outputs "out")) + (flags (cons (string-append "--prefix=" out) + configure-flags))) + (format #t "build directory: ~s~%" + (getcwd)) + (format #t "configure flags: ~s~%" flags) + + (define write-flags + (lambda flags + (display (string-join (map (cut string-append + "ac_add_options " <>) + flags) "\n")) + (display "\n"))) + (with-output-to-file mozconfig + (lambda () + (apply write-flags flags) + ;; The following option unsets Telemetry + ;; Reporting. With the Addons Fiasco, + ;; Mozilla was found to be collecting + ;; user's data, including saved passwords + ;; and web form data, without users + ;; consent. Mozilla was also found + ;; shipping updates to systems without + ;; the user's knowledge or permission. + ;; As a result of this, use the following + ;; command to permanently disable + ;; telemetry reporting in Firefox. + (display "unset MOZ_TELEMETRY_REPORTING\n") + (display "mk_add_options MOZ_CRASHREPORTER=0\n") + (display "mk_add_options MOZ_DATA_REPORTING=0\n") + (display + "mk_add_options MOZ_SERVICES_HEALTHREPORT=0") + (display + "mk_add_options MOZ_TELEMETRY_REPORTING=0"))) + (setenv "MOZCONFIG" mozconfig)) + (invoke "./mach" "configure"))) + (add-before 'build '1fix-addons-placeholder + (lambda _ + (substitute* + "toolkit/locales/en-US/toolkit/about/aboutAddons.ftl" + (("addons.mozilla.org") "gnuzilla.gnu.org")))) + (replace 'build + (lambda* (#:key (make-flags '()) + (parallel-build? #t) #:allow-other-keys) + (apply invoke "./mach" "build" + ;; mach will use parallel build if possible by default + `(,@(if parallel-build? + '() + '("-j1")) ,@make-flags)))) + (add-after 'build 'neutralise-store-references + (lambda _ + ;; Mangle the store references to compilers & + ;; other build tools in about:buildconfig, + ;; reducing Firefox's closure by 1 GiB on + ;; x86-64. + (let* ((build-dir (car (scandir "." + (cut string-prefix? + "obj-" <>)))) + (file (string-append build-dir + "/dist/bin/chrome/toolkit/" + "content/global/buildconfig.html"))) + (substitute* file + (((format #f "(~a/)([0-9a-df-np-sv-z]{32})" + (regexp-quote (%store-directory))) + _ store hash) + (string-append store + (string-take hash 8) + "" + (string-drop hash 8))))))) + (replace 'install + (lambda _ + (invoke "./mach" "install"))) + (add-after 'install 'remove-duplicate-bin + (lambda* (#:key outputs #:allow-other-keys) + (delete-file (string-append #$output + "/lib/librewolf/librewolf-bin")))) + (add-after 'install 'wrap-glxtest + ;; glxtest uses dlopen() to load mesa + ;; libs, wrap it to set LD_LIBRARY_PATH. + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (lib (string-append out "/lib")) + ;; TODO: make me a loop again + (mesa-lib (string-append (assoc-ref inputs + "mesa") + "/lib")) + (pciutils-lib (string-append (assoc-ref inputs + "pciutils") "/lib"))) + (wrap-program (car (find-files lib "^glxtest$")) + `("LD_LIBRARY_PATH" prefix + (,mesa-lib ,pciutils-lib)))))) + (add-after 'install 'autoconfig + (lambda* (#:key inputs #:allow-other-keys) + (let ((lib (string-append #$output "/lib/librewolf")) + (config-file "librewolf.cfg")) + (with-output-to-file (in-vicinity + lib "defaults/pref/autoconfig.js") + (lambda () + (format #t "// first line must be a comment~%") + (format #t "pref(~s, ~s);~%" + "general.config.filename" config-file) + (format #t "pref(~s, ~a);~%" + "general.config.obscure_value" "0"))) + (with-output-to-file (in-vicinity lib config-file) + (lambda () + (format #t "// first line must be a comment~%") + ;; Required for Guix packaged extensions + ;; SCOPE_PROFILE=1, SCOPE_APPLICATION=4, SCOPE_SYSTEM=8 + ;; Default is 5. + (format #t "pref(~s, ~a);~%" + "extensions.enabledScopes" "13") + ;; (format #t "pref(~s, ~s);~%" + ;; "security.sandbox.content.read_path_whitelist" + ;; (call-with-input-file "whitelist.txt" + ;; get-string-all)) + ;; Add-ons pannel (see settings.js in Icecat source). + (format #t "pref(~s, ~s);~%" + "extensions.getAddons.search.browseURL" + "https://gnuzilla.gnu.org/mozzarella") + (format #t "pref(~s, ~s);~%" + "extensions.getAddons.get.url" + "https://gnuzilla.gnu.org/mozzarella") + (format #t "pref(~s, ~s);~%" + "extensions.getAddons.link.url" + "https://gnuzilla.gnu.org/mozzarella") + (format #t "pref(~s, ~s);~%" + "extensions.getAddons.discovery.api_url" + "https://gnuzilla.gnu.org/mozzarella") + (format #t "pref(~s, ~s);~%" + "extensions.getAddons.langpacks.url" + "https://gnuzilla.gnu.org/mozzarella") + (format #t "pref(~s, ~s);~%" + "lightweightThemes.getMoreURL" + "https://gnuzilla.gnu.org/mozzarella")))))) + (add-after 'install 'wrap-program + (lambda* (#:key inputs outputs #:allow-other-keys) + ;; The following two functions are from Guix's icecat package in + ;; (gnu packages gnuzilla). See commit + ;; b7a0935420ee630a29b7e5ac73a32ba1eb24f00b. + (define (runpath-of lib) + (call-with-input-file lib + (compose elf-dynamic-info-runpath elf-dynamic-info + parse-elf get-bytevector-all))) + (define (runpaths-of-input label) + (let* ((dir (string-append (assoc-ref inputs label) + "/lib")) + (libs (find-files dir "\\.so$"))) + (append-map runpath-of libs))) + (let* ((out (assoc-ref outputs "out")) + (lib (string-append out "/lib")) + ;; TODO: make me a loop again + (mesa-lib (string-append (assoc-ref inputs + "mesa") + "/lib")) + (apng-lib (string-append (assoc-ref inputs + "libpng-apng") "/lib")) + ;; For the integration of native notifications + (libnotify-lib (string-append (assoc-ref inputs + "libnotify") + "/lib")) + ;; For hardware video acceleration via VA-API + (libva-lib (string-append (assoc-ref inputs + "libva") + "/lib")) + ;; VA-API is run in the RDD (Remote Data Decoder) sandbox + ;; and must be explicitly given access to files it needs. + ;; Rather than adding the whole store (as Nix had + ;; upstream do, see + ;; and + ;; linked upstream patches), we can just follow the + ;; runpaths of the needed libraries to add everything to + ;; LD_LIBRARY_PATH. These will then be accessible in the + ;; RDD sandbox. + (rdd-whitelist (map (cut string-append <> "/") + (delete-duplicates (append-map + runpaths-of-input + '("mesa" + "ffmpeg"))))) + (pulseaudio-lib (string-append (assoc-ref inputs + "pulseaudio") + "/lib")) + ;; For U2F and WebAuthn + (eudev-lib (string-append (assoc-ref inputs + "eudev") + "/lib")) + (gtk-share (string-append (assoc-ref inputs + "gtk+") + "/share"))) + (wrap-program (car (find-files lib "^librewolf$")) + `("LD_LIBRARY_PATH" prefix + (,mesa-lib ,libnotify-lib + ,libva-lib + ,pulseaudio-lib + ,eudev-lib + ,apng-lib + ,@rdd-whitelist)) + `("XDG_DATA_DIRS" prefix + (,gtk-share)) + `("MOZ_LEGACY_PROFILES" = + ("1")) + `("MOZ_ALLOW_DOWNGRADE" = + ("1")))))) + (add-after 'wrap-program 'install-desktop-entry + (lambda* (#:key outputs #:allow-other-keys) + (let* ((desktop-file + "taskcluster/docker/firefox-snap/firefox.desktop") + (applications (string-append #$output + "/share/applications"))) + (substitute* desktop-file + (("^Exec=firefox") + (string-append "Exec=" + #$output "/bin/librewolf")) + ;; "Firefox" -> "LibreWolf" everywhere + (("Firefox") + "LibreWolf") + ;; Remove non-Latin translations. + (("^Name\\[(ar|bn)\\].*$") + "") + (("^Icon=.*") + (string-append "Icon=" + #$output + "/share/icons/hicolor/128x128/apps/librewolf.png +")) + ;; These commands were changed. + (("-NewWindow") + "-new-window") + (("-NewPrivateWindow") + "-new-private-window") + (("StartupNotify=true") + "StartupNotify=true +StartupWMClass=Navigator")) + (copy-file desktop-file "librewolf.desktop") + (install-file "librewolf.desktop" applications)))) + (add-after 'install-desktop-entry 'install-icons + (lambda* (#:key outputs #:allow-other-keys) + (let ((icon-source-dir (string-append #$output + "/lib/librewolf/browser/" + "chrome/icons/default"))) + (for-each (lambda (size) + (let ((dest (string-append #$output + "/share/icons/hicolor/" + size + "x" + size + "/apps"))) + (mkdir-p dest) + (symlink (string-append icon-source-dir + "/default" size ".png") + (string-append dest + "/librewolf.png")))) + '("16" "32" "48" "64" "128")))))) + + ;; Test will significantly increase build time but with little rewards. + #:tests? #f + + ;; WARNING: Parallel build will consume lots of memory! + ;; If you have encountered OOM issue in build phase, try disable it. + #:parallel-build? #t + + ;; Some dynamic lib was determined at runtime, so rpath check may fail. + #:validate-runpath? #f)) + (inputs (list bash-minimal + bzip2 + cairo + cups + dbus-glib + freetype + ffmpeg + gdk-pixbuf + glib + gtk+ + gtk+-2 + hunspell + icu4c-73 + jemalloc + libcanberra + libevent + libffi + libgnome + libjpeg-turbo + libnotify + libpng-apng + libva + libvpx + libwebp + libxcomposite + libxft + libxinerama + libxscrnsaver + libxt + mesa + mit-krb5 + nspr + nss + pango + pciutils + pipewire + pixman + pulseaudio + speech-dispatcher + sqlite + startup-notification + eudev + unzip + zip + zlib)) + (native-inputs (list alsa-lib + autoconf-2.13 + `(,rust-librewolf "cargo") + clang + llvm + wasm32-wasi-clang-toolchain + m4 + nasm + node-lts + perl + pkg-config + python + rust-librewolf + rust-cbindgen-0.26 + which + yasm)) + (home-page "https://mozilla.org/firefox/") + (synopsis "Trademarkless version of Firefox") + (description + "Full-featured browser client built from Firefox source tree, without +the official icon and the name \"firefox\". This is the Extended Support +Release (ESR) version.") + (license license:mpl2.0))) -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 14:26:28 2024 Received: (at 67512) by debbugs.gnu.org; 11 Feb 2024 19:26:28 +0000 Received: from localhost ([127.0.0.1]:41618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZFT9-00062Z-TS for submit@debbugs.gnu.org; Sun, 11 Feb 2024 14:26:28 -0500 Received: from fout2-smtp.messagingengine.com ([103.168.172.145]:51357) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZFT6-00061v-Q2 for 67512@debbugs.gnu.org; Sun, 11 Feb 2024 14:26:25 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.nyi.internal (Postfix) with ESMTP id 06A2513800AA; Sun, 11 Feb 2024 14:20:37 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 11 Feb 2024 14:20:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to; s=fm2; t=1707679237; x=1707765637; bh=5SCv45Mo1VEx2qzGdC/eP HQqjaFfyOX7LDh47PGHd3o=; b=j1zejZ1ycDeRK9LtuEnssXm5LYaT0Rvl5IYFA UAflHRuvAJcP02w8bBcx/VeUhota1theqGzfLP2l5blHpOMO+t2UDhIZb+vlVBnU egFKvEj58EYE2Tt06gR9ndku2yc2TIhgZOX4hdQR51owxfISUXbsQ99h/toxaWZw w0DkIPDRKEBREXZjq6+sBQegUWgrsJ0dH+Pck0vKJCvUmipETBQ/93PA6TJS0f81 EjDGj2zWz/fdn5ILIxU1bryu3nvPPMytIX09oXpx/DtXn26nVMn8ZAQBVKJy/YXK 62NRPw3qyhooAhBhWJtOBgUAT44MVN/VRpcKZXMLS473SFfkg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1707679237; x=1707765637; bh=5SCv45Mo1VEx2qzGdC/ePHQqjaFf yOX7LDh47PGHd3o=; b=gdm70REA56azrYiClkEVtBRwjJHoVgFdqQXSnOL5sGNA LS5LWlV5FGjNCea9g+cGnpLyHOG3ksEHyn8Y3UY+m6JG0+0sEiChu/3e9KlmAqIa wIpyaTr5AnV01MAvubC2NxuOzNtyGBCLVahstkj1YGAZdz21KoXPDpKhc6xSOnbW WWIhtRjrg7YzQXRcECQqVrw6tVyAsiJ2eLxY6WVrGYazX/rYspdXZ3h5h9lJ1Qbd rv1wzAaoSFZjvPkJW0py4//XVa6j/IwlK20KLu2Cr6WM0MDEyzMNQXth6C6xFszf ZbB2IVFCX8kP5EpNfQmhN8Ykm/GWHdfpcczm0Bt17w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddugdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggtrdht vheqnecuggftrfgrthhtvghrnhephfeiveeliedukeffhefhleeijedtveelleetgefggf ehkeeljeehtdeguddvvefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepihgrnhesrhgvthhrohhsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 11 Feb 2024 14:20:35 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v2 0/4] Add Librewolf Date: Sun, 11 Feb 2024 11:20:23 -0800 Message-ID: <20240211192031.32284-1-ian@retrospec.tv> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Updated patch series. * Updates LibreWolf to 122.0-2. * Moved the icu4c-73-future package definition in (gnu packages gnuzilla) to (gnu packages icu4c). * Updating icu4c to 73.1 would cause a world rebuild, so this is added as `icu4c-73' to avoid that. * Disabled EME. * Uses GNU Mozzarella instead of Firefox for addons. * Updates NSS package. * Unbundles libpng-apng, libwebp, nss, libevent, and libvpx. I believe this addresses all the items I received feedback on. Ian Eure (4): gnu: Move icu4c-73 from gnuzilla to icu4c. gnu: nss: Update to 3.97. gnu: Add wasm packages. gnu: Add librewolf. gnu/packages/certs.scm | 4 +- gnu/packages/gnuzilla.scm | 27 +- gnu/packages/icu4c.scm | 22 ++ gnu/packages/librewolf.scm | 653 +++++++++++++++++++++++++++++++++++++ gnu/packages/nss.scm | 6 +- gnu/packages/wasm.scm | 273 ++++++++++++++++ 6 files changed, 954 insertions(+), 31 deletions(-) create mode 100644 gnu/packages/librewolf.scm create mode 100644 gnu/packages/wasm.scm -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 14:26:28 2024 Received: (at 67512) by debbugs.gnu.org; 11 Feb 2024 19:26:28 +0000 Received: from localhost ([127.0.0.1]:41620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZFTA-00062e-8O for submit@debbugs.gnu.org; Sun, 11 Feb 2024 14:26:28 -0500 Received: from fout2-smtp.messagingengine.com ([103.168.172.145]:50905) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZFT6-00061w-Q0 for 67512@debbugs.gnu.org; Sun, 11 Feb 2024 14:26:25 -0500 Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfout.nyi.internal (Postfix) with ESMTP id 0277B13800B6; Sun, 11 Feb 2024 14:20:40 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sun, 11 Feb 2024 14:20:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to; s=fm2; t=1707679239; x=1707765639; bh=u2o/XPEnETILpVZOJ8E6H LUPLkKhEIer6la1/DRlyBU=; b=kmYfZTgRHyhSlAEQ8IODjWSDS7IM+LbrACL+B 6Kn48GXyeKBzdto4U2TVpvdf1PA1tLnPtIpWdQcy8YYkPlYCIdBgHi7Khklfr5nf OFymVK9TcYYVm5RYvsyL3UHPbekvByc7M5wICTEe8G6gpyyBoaW5IVz48GUCb3fD xvW9mDN4OQhS0ZMfruSMlbnBpnqNcDTuosUB7rloIZzvtkMzmleySzh5DBCB7Sz2 s4hV8Ztjv+We4gGZM4tNCfowqlruc+w3HtbFbF7tl1hBbFh7x/NPt5VvIS+r9izO MNfQx++aA9AA00jz0y5qsacWKsiF+zPEOSzmmyjXOqHIreCig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1707679239; x=1707765639; bh=u2o/XPEnETILpVZOJ8E6HLUPLkKh EIer6la1/DRlyBU=; b=tLyqTwGXbyHWG+JeEZNqnkI292xjV8BoFrybza+/JWo+ PKK+ZViddbMNuJtLv7YpozoNIZgIuubigcKo29S6WUwafWIA/lnvkxTfHKLMjXeg vbO9TRpe/rgHEqLUvO4vs4UeCPF7LSH2Tsq2X/T7unzIMmvDZ89jM3MECWE6GP0w k2836S+7nIu6kg6qGec7TyIz/VEgqvP2DtYXe2U6pnquvqB497JkDGXGjR3VK/H0 U6W9XE96WX1OJD1EVSwftLq9xLy/fdfD3Qqdvgl2uVamw+IwEd++YfULEY2u8EKx BiXh5rFyKIWfyWydes9NswTtEVKf3oG5fpwFJhH0Yg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddugdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggtrdht vheqnecuggftrfgrthhtvghrnhephfehheefveegffffgfeklefhtdekfeehhedttdejle eigeeljeduleejteefueeknecuffhomhgrihhnpehgihhthhhusgdrtghomhdpmhhoiihi lhhlrgdrohhrghdpihgtuhdqphhrohhjvggtthdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrdht vh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 11 Feb 2024 14:20:39 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v2 1/4] gnu: Move icu4c-73 from gnuzilla to icu4c. Date: Sun, 11 Feb 2024 11:20:24 -0800 Message-ID: <20240211192031.32284-2-ian@retrospec.tv> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Debbugs-Cc: Clément Lassieur , Jonathan Brielmaier , Mark H Weaver Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/icu4c.scm (icu4c-73): New variable. * gnu/packages/gnuzilla.scm (icu4c-73-promise): Delete variable. Change-Id: I017e1416b70ecb94313aeb71aa4a0cafdfe0e9ab --- gnu/packages/gnuzilla.scm | 27 +-------------------------- gnu/packages/icu4c.scm | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+), 26 deletions(-) diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm index 5f77512427..094ff348e9 100644 --- a/gnu/packages/gnuzilla.scm +++ b/gnu/packages/gnuzilla.scm @@ -375,31 +375,6 @@ (define-public mozjs-78 (list icu4c-69 readline zlib)))) -;; -;; Needed for IceCat 115. -;; -(define icu4c-73-promise - (delay - (package - (inherit icu4c) - (version "73.1") - (source (origin - (method url-fetch) - (uri (string-append - "https://github.com/unicode-org/icu/releases/download/release-" - (string-map (lambda (x) (if (char=? x #\.) #\- x)) version) - "/icu4c-" - (string-map (lambda (x) (if (char=? x #\.) #\_ x)) version) - "-src.tgz")) - (sha256 - (base32 - "0iccpdvc0kvpww5a31k9gjkqigyz016i7v80r9zamd34w4fl6mx4")) - (patches - (cons - (search-patch - "icu4c-fix-TestHebrewCalendarInTemporalLeapYear.patch") - (origin-patches (package-source icu4c))))))))) - ;;; ;;; Localization helper procedures. ;;; @@ -757,7 +732,7 @@ (define-public icecat-minimal ;; https://bugzilla.mozilla.org/show_bug.cgi?id=1819374). ffmpeg-5 libvpx - (force icu4c-73-promise) + icu4c-73 pixman pulseaudio mesa diff --git a/gnu/packages/icu4c.scm b/gnu/packages/icu4c.scm index 5aaf3a8361..0dfe63b20a 100644 --- a/gnu/packages/icu4c.scm +++ b/gnu/packages/icu4c.scm @@ -109,6 +109,28 @@ (define-public icu4c (license x11) (home-page "http://site.icu-project.org/"))) +(define-public icu4c-73 + (package + (inherit icu4c) + (name "icu4c") + (version "73.1") + (source (origin + (method url-fetch) + (uri (string-append + "https://github.com/unicode-org/icu/releases/download/release-" + (string-map (lambda (x) (if (char=? x #\.) #\- x)) version) + "/icu4c-" + (string-map (lambda (x) (if (char=? x #\.) #\_ x)) version) + "-src.tgz")) + (sha256 + (base32 + "0iccpdvc0kvpww5a31k9gjkqigyz016i7v80r9zamd34w4fl6mx4")) + (patches + (cons + (search-patch + "icu4c-fix-TestHebrewCalendarInTemporalLeapYear.patch") + (origin-patches (package-source icu4c)))))))) + (define-public icu4c-70 (package (inherit icu4c) -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 14:26:32 2024 Received: (at 67512) by debbugs.gnu.org; 11 Feb 2024 19:26:32 +0000 Received: from localhost ([127.0.0.1]:41626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZFTD-00062v-OV for submit@debbugs.gnu.org; Sun, 11 Feb 2024 14:26:32 -0500 Received: from fout2-smtp.messagingengine.com ([103.168.172.145]:43097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZFT6-00061y-Q0 for 67512@debbugs.gnu.org; Sun, 11 Feb 2024 14:26:27 -0500 Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfout.nyi.internal (Postfix) with ESMTP id E09CA13800BB; Sun, 11 Feb 2024 14:20:42 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sun, 11 Feb 2024 14:20:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :subject:subject:to:to; s=fm2; t=1707679242; x=1707765642; bh=oB C0nCRtRxlGrAQi9DWyfMS5etQoFM0ANvepl8rXmd8=; b=bfoh59XUsJk68YyZRd mCJzlFO4wPAuN/yDbN9rPILpZ6DXE8PXKVI6tHScCig9IayrOiC2UkfdjsqkD9ZS tmVgbjd8jyXxHW4T2FsVoHA8vl2P1D7bYeBwTq/aY3oaEhKjqGG5bTE5A4oi8AeL Q4F4H7w9cpcS7YJ409v1x0pVzD50BTRxgmzCWTQ8qqOp6VY1PAOkTOors8+cATd9 k4/XRxcFxFaYo3G0Is6x8mIkEMFrnD6SMcok7GA0xnsqVvhq+ZUVlBVaj5MiHoFZ bYuez1H5nO2ZQJG9ulvuQ1aBmW/2oyabNlRuyKcmT5airQk7sttSN3GccNlzTy2v SRIA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1707679242; x=1707765642; bh=oBC0nCRtRxlGr AQi9DWyfMS5etQoFM0ANvepl8rXmd8=; b=dm2I0yi6ABycCedZytWexzV2Hw8oL shdcejVeIDfs4ATjztWulq6zIMIn4qiBKs26grWl7qvaJ5ppONoT6bykZExi6cTl Zx+QFnaK/hUslhsff0y/enSQuzTtf4gTDsa/uKVxENnS/NpVsIGpDoVv97p0CA+h xIbXxmDONYu6Cx4zY0gJOub41FOPfnrg3ShDQxyE4v0Xr4vrIJwV6E9FFMtQjXg6 Oe+IiJD/NdIj9TPnW54y4v32Tvp+xuB019vC6uvyEr7vKi5Q5Zh+A7MVwEeKVKRa 7YbdUBhzAE1n9+92OVqP6QRUMQ6WwVepPWl8TvJLrzc9ku24VsisXzosw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddugdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffogggtgfesthekre dtredtjeenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdr thhvqeenucggtffrrghtthgvrhhnpeehteevieevffevtdefvedujeekheeigeegteevff etffevjedtudegudegvdffkeenucffohhmrghinhepghhnuhdrohhrghdpghhithhhuhgs rdgtohhmpdhmohiiihhllhgrrdhorhhgpdifrghsihdruggvvhdplhhlvhhmrdhorhhgne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihgrnhes rhgvthhrohhsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 11 Feb 2024 14:20:42 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v2 3/4] gnu: Add wasm packages. Date: Sun, 11 Feb 2024 11:20:26 -0800 Message-ID: <20240211192031.32284-4-ian@retrospec.tv> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/wasm.scm (wasi-libc): New variable. * gnu/packages/wasm.scm (wasm32-wasi-clang-runtime): New variable. * gnu/packages/wasm.scm (wasm32-wasi-clang): New variable. * gnu/packages/wasm.scm (wasm32-wasi-libcxx): New variable. * gnu/packages/wasm.scm (wasm32-wasi-clang-toolchain): New variable. --- gnu/packages/wasm.scm | 273 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 273 insertions(+) create mode 100644 gnu/packages/wasm.scm diff --git a/gnu/packages/wasm.scm b/gnu/packages/wasm.scm new file mode 100644 index 0000000000..05d247f333 --- /dev/null +++ b/gnu/packages/wasm.scm @@ -0,0 +1,273 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2022-2023 Pierre Langlois +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + +(define-module (gnu packages wasm) + #:use-module (guix base32) + #:use-module (guix gexp) + #:use-module (guix packages) + #:use-module ((guix licenses) #:prefix license:) + #:use-module (guix utils) + #:use-module (guix git-download) + #:use-module (guix build-system cmake) + #:use-module (guix build-system gnu) + #:use-module (guix build-system trivial) + #:use-module (gnu packages bash) + #:use-module (gnu packages llvm) + #:use-module (gnu packages python)) + +(define-public wasi-libc + (package + (name "wasi-libc") + (version "sdk-19") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/WebAssembly/wasi-libc") + (commit (string-append "wasi-" version)) + (recursive? #t))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0bnpz8wk9wiic938296gxp4vz820bvpi1w41jksjzz5552hql169")))) + (build-system gnu-build-system) + (native-inputs (list clang-15)) + (arguments + (list + #:tests? #f ;No test suite + ;; Firefox uses wasm2c to compile WebAssembly to C code, and it + ;; does not support the memory.copy opcode. + ;; See https://bugzilla.mozilla.org/show_bug.cgi?id=1773200#c4 + #:make-flags ''("BULK_MEMORY_SOURCES=") + #:phases #~(modify-phases %standard-phases + (delete 'configure) + (add-before 'build 'set-sysroot-include + (lambda _ + (setenv "C_INCLUDE_PATH" + (string-append (getcwd) "/sysroot/include")))) + (add-before 'install 'set-install-dir + (lambda _ + (setenv "INSTALL_DIR" + (string-append #$output "/wasm32-wasi"))))))) + (home-page "https://wasi.dev") + (synopsis "WASI libc implementation for WebAssembly") + (description + "WASI Libc is a libc for WebAssembly programs built on top of WASI +system calls. It provides a wide array of POSIX-compatible C APIs, including +support for standard I/O, file I/O, filesystem manipulation, memory +management, time, string, environment variables, program startup, and many +other APIs.") + (license (list + ;; For wasi-libc, with LLVM exceptions + license:asl2.0 + ;; For malloc.c. + license:cc0 + ;; For cloudlibc. + license:bsd-2 + ;; For wasi-libc and musl-libc. + license:expat)))) + +(define-public wasm32-wasi-clang-runtime + (package (inherit clang-runtime-15) + (native-inputs + (list clang-15 + wasi-libc)) + (inputs (list llvm-15)) + (arguments + (list + #:build-type "Release" + #:tests? #f + ;; Stripping binaries breaks wasm linking, resulting in the following + ;; error: "archive has no index; run ranlib to add one". + #:strip-binaries? #f + #:configure-flags + #~(list "-DCMAKE_C_COMPILER=clang" + "-DCMAKE_C_COMPILER_TARGET=wasm32-wasi" + (string-append + "-DCMAKE_SYSROOT=" #$wasi-libc "/wasm32-wasi") + (string-append + "-DCMAKE_C_FLAGS=-I " #$wasi-libc "/wasm32-wasi/include") + + "-DCOMPILER_RT_OS_DIR=wasi" + + "-DCOMPILER_RT_BAREMETAL_BUILD=On" + "-DCOMPILER_RT_DEFAULT_TARGET_ONLY=On" + + ;; WASM only needs libclang_rt.builtins-wasm32.a from + ;; compiler-rt. + "../source/compiler-rt/lib/builtins"))))) + +;; FIXME: Ideally we wouldn't need to build a separate compiler because clang +;; can support multiple targets at runtime. However Guix patches the default +;; clang with a specific clang-runtime package. It would be good to improve +;; upstream Guix's support for cross-compiling with clang. + +(define clang-from-llvm (@@ (gnu packages llvm) clang-from-llvm)) +(define llvm-monorepo (@@ (gnu packages llvm) llvm-monorepo)) + +(define-public wasm32-wasi-clang + (let ((base (clang-from-llvm llvm-15 wasm32-wasi-clang-runtime))) + (package + (inherit base) + (name "wasm32-wasi-clang") + (inputs (modify-inputs (package-inputs base) + (prepend wasi-libc))) + (arguments + (substitute-keyword-arguments (package-arguments base) + ((#:configure-flags flags) + #~(list "-DCLANG_INCLUDE_TESTS=True" + ;; Use a sane default include directory. + (string-append "-DC_INCLUDE_DIRS=" + #$wasi-libc "/wasm32-wasi/include"))) + ((#:phases phases) + `(modify-phases ,phases + (delete 'symlink-cfi_ignorelist)))))))) + +(define-public wasm32-wasi-libcxx + (package + (name "wasm32-wasi-libcxx") + (version (package-version llvm-15)) + (source + (llvm-monorepo version)) + (build-system cmake-build-system) + (arguments + (list + #:configure-flags #~(list (string-append "-S ../source/runtimes") + + "-DLLVM_ENABLE_RUNTIMES=libcxx;libcxxabi" + + (string-append "-DCMAKE_SYSROOT=" + #$wasi-libc "/wasm32-wasi") + + (string-append "-DCMAKE_INCLUDE_PATH=" + #$wasi-libc + "/wasm32-wasi/include") + + (string-append "-DCMAKE_STAGING_PREFIX=" + #$output "/wasm32-wasi") + + "-DCMAKE_C_COMPILER=clang" + "-DCMAKE_C_COMPILER_WORKS=ON" + "-DCMAKE_CXX_COMPILER=clang++" + "-DCMAKE_CXX_COMPILER_WORKS=ON" + "-DCMAKE_C_COMPILER_TARGET=wasm32-wasi" + "-DCMAKE_CXX_COMPILER_TARGET=wasm32-wasi" + + "-DLIBCXX_LIBDIR_SUFFIX=/wasm32-wasi" + + "-DLIBCXX_ENABLE_EXCEPTIONS=OFF" + "-DLIBCXX_ENABLE_SHARED=OFF" + "-DLIBCXX_ENABLE_THREADS=OFF" + "-DLIBCXX_ENABLE_FILESYSTEM=OFF" + + "-DLIBCXXABI_LIBDIR_SUFFIX=/wasm32-wasi" + + "-DLIBCXXABI_ENABLE_EXCEPTIONS=OFF" + "-DLIBCXXABI_ENABLE_SHARED=OFF" + "-DLIBCXXABI_ENABLE_THREADS=OFF" + "-DLIBCXXABI_ENABLE_FILESYSTEM=OFF") + #:tests? #f + #:phases #~(modify-phases %standard-phases + (add-after 'set-paths 'adjust-CPLUS_INCLUDE_PATH + (lambda _ + (setenv "CPLUS_INCLUDE_PATH" + (string-append #$wasi-libc + "/wasm32-wasi/include:" + (getenv "CPLUS_INCLUDE_PATH")))))))) + (native-inputs (list lld python wasm32-wasi-clang)) + (inputs (list wasi-libc)) + (home-page "https://libcxx.llvm.org") + (synopsis "C++ standard library for WebAssembly") + (description + "This package provides an implementation of the C++ standard library for +use with Clang, targeting C++11, C++14 and above. This package targets +WebAssembly with WASI.") + (license license:expat))) + +(define-public wasm32-wasi-clang-toolchain + (package + (name "wasm32-wasi-clang-toolchain") + (version (package-version wasm32-wasi-clang)) + (source + #f) + (build-system trivial-build-system) + (arguments + (list + #:builder (with-imported-modules '((guix build union) + (guix build utils)) + #~(begin + (use-modules (guix build union) + (guix build utils)) + (union-build #$output + (list #$wasm32-wasi-clang-runtime + #$wasi-libc + #$wasm32-wasi-libcxx)) + (mkdir-p (string-append #$output + "/bin")) + + ;; We provide clang and clang++ via a wrapped program that sets + ;; include paths correctly so that it does not include paths from + ;; the host. + + ;; FIXME: Review how we can provide better support for + ;; cross-compiling with clang in Guix, maybe adding support for + ;; the CROSS_C_INCLUDE_PATH and CROSS_CPLUS_INCLUDE_PATH + ;; environment variables like GCC. + + (for-each (lambda (bin) + (symlink (string-append #$wasm32-wasi-clang + bin) + (string-append #$output + bin)) + (wrap-program (string-append #$output + bin) + #:sh (string-append #$bash-minimal + "/bin/bash") + `("C_INCLUDE_PATH" + ":" = + (,(string-append #$output + "/wasm32-wasi/include"))) + `("CPLUS_INCLUDE_PATH" + ":" = + ;; Make sure inclure/c++/v1 comes first for #include_next + ;; to work. + (,(string-append #$output + "/wasm32-wasi/include/c++/v1") , + (string-append #$output + "/wasm32-wasi/include"))))) + '("/bin/clang" + "/bin/clang++")) + + (symlink (string-append #$lld + "/bin/wasm-ld") + (string-append #$output + "/bin/wasm-ld")))))) + (inputs (list bash-minimal + lld + wasi-libc + wasm32-wasi-clang + wasm32-wasi-clang-runtime + wasm32-wasi-libcxx)) + (license (cons (package-license wasm32-wasi-clang) + (package-license wasi-libc))) + (home-page "https://clang.llvm.org") + (synopsis + "Complete Clang toolchain for C/C++ development, for WebAssembly.") + (description + "This package provides a complete Clang toolchain for C/C++ +development targeting WebAssembly with WASI. This includes Clang, as well as +libc, libc++ and wasm-ld."))) -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 14:36:27 2024 Received: (at 67512) by debbugs.gnu.org; 11 Feb 2024 19:36:28 +0000 Received: from localhost ([127.0.0.1]:42335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZFcp-0006WX-74 for submit@debbugs.gnu.org; Sun, 11 Feb 2024 14:36:27 -0500 Received: from fout2-smtp.messagingengine.com ([103.168.172.145]:51379) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZFcm-0006WB-He for 67512@debbugs.gnu.org; Sun, 11 Feb 2024 14:36:25 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.nyi.internal (Postfix) with ESMTP id 873D913800B1; Sun, 11 Feb 2024 14:20:41 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 11 Feb 2024 14:20:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :subject:subject:to:to; s=fm2; t=1707679241; x=1707765641; bh=t9 zcTh/3F5OJ78xUWkwpnOkg66naOfDct7RvwWpolUM=; b=tS/1vyIqS0P1h+g2Zo Rpq1ERZkjbofgRxt+nRwjsg6o13lx8pDuYkR2zMuJEXuobFpiL24cNsLhy7yE8Hj PIRYklLfWMWAcUdsjC5fm1khZpwmxoowv0MrbeudeItpwSsTqyR91nXvCcjYPtXy ole8G52g4DR8Mtuk9OoUI0bEOgi8MRRLAGECcroSEuguA7nBRSEEg/us0ACTPrFt YAmpKAYzQSzG1fmMnHQLlUJ37Ruk8Qnxwav6hx1L9ZICdQbzghg1IVa2JP9dhOux g0Y0WHKxoWN6gYoGGSPOHHKPsKkPR7QgV/F1UWQfHfhbCtSNHXRqEsAYsWBwSiyz 1ciw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1707679241; x=1707765641; bh=t9zcTh/3F5OJ7 8xUWkwpnOkg66naOfDct7RvwWpolUM=; b=AZrXcBDJGZjXJqeuoTlCccBJfauwC o8oGuKpvv1hpyX/Xn4n34Fd5q5OPjSeiF4vI/dToHYBLsLGE1y1R9CeIgKyX8iMR 6RJYPRhd8GeJeXb4RtUJEnotFiMcDxlmAA7uLAcdN+hn8rejMr0crUSnBTAbivFt 4H1AEtZZdbvIWTS3ETkZ+H8L6zzW6Ymq7GufAMvSby7VFHZVtyVV9FJfJIroc4Wo 7f9B7TeX8K1hRqaEBm3Yf3wDbBlzpL3VrZ/hPdUkxJm7rPmgiBInjQEFuyKtlo8q 4cBTmqUEEmF/3TW7IGwUUPNPxd6RKjZLo03lq0Ejvg3+w9K7Ct5qM/rHg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddugdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffogggtgfesthekre dtredtjeenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdr thhvqeenucggtffrrghtthgvrhhnpeektefhkedtgffhtdeuhfetjedvudeujeduhfevvd eivdduhfekveehvdetgeefffenucffohhmrghinhepmhhoiihilhhlrgdrohhrghenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvg htrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 11 Feb 2024 14:20:40 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v2 2/4] gnu: nss: Update to 3.97. Date: Sun, 11 Feb 2024 11:20:25 -0800 Message-ID: <20240211192031.32284-3-ian@retrospec.tv> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/nss.scm (nss): Update to 3.97. * gnu/packages/certs.scm (nss-certs): Update to 3.97. --- gnu/packages/certs.scm | 4 ++-- gnu/packages/nss.scm | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gnu/packages/certs.scm b/gnu/packages/certs.scm index 58b4d50ec8..2a6106df78 100644 --- a/gnu/packages/certs.scm +++ b/gnu/packages/certs.scm @@ -131,7 +131,7 @@ (define-public nss-certs ;; XXX We used to refer to the nss package here, but that eventually caused ;; module cycles. The below is a quick copy-paste job that must be kept in ;; sync manually. Surely there's a better way…? - (version "3.88.1") + (version "3.97") (source (origin (method url-fetch) (uri (let ((version-with-underscores @@ -142,7 +142,7 @@ (define-public nss-certs "nss-" version ".tar.gz"))) (sha256 (base32 - "15il9fsmixa1r4446zq1wl627sg0hz9h67w6kjxz273xz3nl7li7")) + "02pscmkp7flawmgwqzr807nsn6kzzw7r7xjbzfql0bpkjf1zp3h7")) ;; Create nss.pc and nss-config. (patches (search-patches "nss-3.56-pkgconfig.patch" "nss-getcwd-nonnull.patch" diff --git a/gnu/packages/nss.scm b/gnu/packages/nss.scm index 54b9e5041a..268ddaa24f 100644 --- a/gnu/packages/nss.scm +++ b/gnu/packages/nss.scm @@ -106,7 +106,7 @@ (define-public nss ;; IMPORTANT: Also update and test the nss-certs package, which duplicates ;; version and source to avoid a top-level variable reference & module ;; cycle. - (version "3.88.1") + (version "3.97") (source (origin (method url-fetch) (uri (let ((version-with-underscores @@ -117,7 +117,7 @@ (define-public nss "nss-" version ".tar.gz"))) (sha256 (base32 - "15il9fsmixa1r4446zq1wl627sg0hz9h67w6kjxz273xz3nl7li7")) + "02pscmkp7flawmgwqzr807nsn6kzzw7r7xjbzfql0bpkjf1zp3h7")) ;; Create nss.pc and nss-config. (patches (search-patches "nss-3.56-pkgconfig.patch" "nss-getcwd-nonnull.patch" @@ -200,7 +200,7 @@ (define-public nss ;; leading to test failures: ;; . To ;; work around that, set the time to roughly the release date. - (invoke "faketime" "2022-11-01" "./nss/tests/all.sh")) + (invoke "faketime" "2024-01-23" "./nss/tests/all.sh")) (format #t "test suite not run~%")))) (replace 'install (lambda* (#:key outputs #:allow-other-keys) -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 15:23:04 2024 Received: (at 67512) by debbugs.gnu.org; 11 Feb 2024 20:23:04 +0000 Received: from localhost ([127.0.0.1]:45405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZGLw-0000NE-6c for submit@debbugs.gnu.org; Sun, 11 Feb 2024 15:23:04 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:53415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZGLu-0000Mb-Rn for 67512@debbugs.gnu.org; Sun, 11 Feb 2024 15:23:03 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 50EEC5C007B; Sun, 11 Feb 2024 15:22:41 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 11 Feb 2024 15:22:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1707682961; x=1707769361; bh=cYuR2L+Nhm aKtspYgF3fTS28m+OY3UFSzElFhswdfzk=; b=apjrNm9ROFPiP0UbkhhHtvPdkU LMkeQJugbEql9hsvLuF5GXhF1NBwMmtz7uhcAkKogURUvf14qo8ZYCacEMYtsWLa 8ehs3H8ARQXQpWzG4CiCEKw33vqYJOrZtyRUvjI1nxzEYGVz2HyAtqUuwomPDeMG pVG6IdYKrSVyvdb+EkdbKp1X6mOvYy+ULMdBzSnfU37fll0KzS/4+Vhm2JrGDoLo Slh/yk6RQD6yKuBV5mWSlFEEhVql6Tl1i1c/fPbfz4xSzFwdwtPGt1o/ey1bJQm+ VJeV2TKkWL4lPoE/Q7CLko7VpzgHLtRDwdr25y/zQaOrt0zBxWACJSOs6QkA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1707682961; x=1707769361; bh=cYuR2L+NhmaKtspYgF3fTS28m+OY 3UFSzElFhswdfzk=; b=R9k9BkQ/daUg6+M5stQCbghLklA3u0GXfgTT2/ORJTYT pvUY3cbakqD16s2LoH9KMNjgwFbhudKvXcJnq1C5VPK2PdVD6mheMS5wPy+rMDs/ UuSUId1RyfbKOQcRp+U6CitFKWJ7vc0pg6aLFT4caJA4PHJqgMcHSX/iqsxq+137 B8A8DX1eqb/azx5CJXn8KAwF+aKWw7hM8uS3Pc1rApuwPSI+Q7umcHHoXSbDkQO8 YVk847TBo4uKY6QRMZmPbbA5RZ9t2FIbnlA1g84K3jkU7JNY7AHWLKJXgedzVq+o KhgYJPsWGsDJvQnEPdAyeplKVHGZ0yVvOH3AUX4V0g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddugddufeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufgjfhffkfgfgggtsehttd ertddtreejnecuhfhrohhmpeevlhormhgvnhhtucfnrghsshhivghurhcuoegtlhgvmhgv nhhtsehlrghsshhivghurhdrohhrgheqnecuggftrfgrthhtvghrnhepveejleejhfeltd ehudekjefhkeeugfelgfdtvdduteevleejkeduvedthfdtgfffnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheptghlvghmvghntheslhgrshhsih gvuhhrrdhorhhg X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 11 Feb 2024 15:22:40 -0500 (EST) From: =?utf-8?Q?Cl=C3=A9ment_Lassieur?= To: Ian Eure Subject: Re: [bug#67512] [PATCH v2 0/4] Add Librewolf In-Reply-To: <20240211192031.32284-1-ian@retrospec.tv> (Ian Eure's message of "Sun, 11 Feb 2024 11:20:23 -0800") References: <20240211192031.32284-1-ian@retrospec.tv> Date: Sun, 11 Feb 2024 21:22:37 +0100 Message-ID: <87eddihhte.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, Feb 11 2024, Ian Eure wrote: > Updated patch series. > > * Updates LibreWolf to 122.0-2. > * Moved the icu4c-73-future package definition in (gnu packages gnuzilla) to (gnu packages icu4c). > * Updating icu4c to 73.1 would cause a world rebuild, so this is added as `icu4c-73' to avoid that. > * Disabled EME. > * Uses GNU Mozzarella instead of Firefox for addons. > * Updates NSS package. > * Unbundles libpng-apng, libwebp, nss, libevent, and libvpx. Well we still have no news from the Wasm person? From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 16:59:07 2024 Received: (at 67512) by debbugs.gnu.org; 11 Feb 2024 21:59:07 +0000 Received: from localhost ([127.0.0.1]:51746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZHqt-0004xb-5P for submit@debbugs.gnu.org; Sun, 11 Feb 2024 16:59:07 -0500 Received: from world.peace.net ([64.112.178.59]:55058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZHqr-0004wW-8F for 67512@debbugs.gnu.org; Sun, 11 Feb 2024 16:59:05 -0500 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZHZB-0004RE-OJ; Sun, 11 Feb 2024 16:40:49 -0500 From: Mark H Weaver To: Ian Eure , 67512@debbugs.gnu.org Subject: Re: [bug#67512] [PATCH v2 1/4] gnu: Move icu4c-73 from gnuzilla to icu4c. In-Reply-To: <20240211192031.32284-2-ian@retrospec.tv> References: <20240211192031.32284-2-ian@retrospec.tv> Date: Sun, 11 Feb 2024 16:40:39 -0500 Message-ID: <87a5o665n1.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67512 Cc: Jonathan Brielmaier , =?utf-8?Q?Cl=C3=A9ment?= Lassieur X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ian Eure writes: > * gnu/packages/icu4c.scm (icu4c-73): New variable. > * gnu/packages/gnuzilla.scm (icu4c-73-promise): Delete variable. Looks good to me. Thanks, Mark From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 17:14:28 2024 Received: (at 67512) by debbugs.gnu.org; 11 Feb 2024 22:14:28 +0000 Received: from localhost ([127.0.0.1]:52991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZI5j-0005qP-HH for submit@debbugs.gnu.org; Sun, 11 Feb 2024 17:14:28 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:39365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZI5h-0005q0-M7 for 67512@debbugs.gnu.org; Sun, 11 Feb 2024 17:14:26 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 15E9A5C0069; Sun, 11 Feb 2024 17:14:04 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 11 Feb 2024 17:14:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1707689644; x=1707776044; bh=fwWtNMw/E8Oe+szPKyBvg4LOLT2jgNMHgvqZr8GinRs=; b= O9XRaz43tGnN6wJTIrBlgCmv1HqRpWd7JwwywdAKWmN6K386NP7RsBOMTzA7eW2L u3Wt5ADuXSp+Of9jEF8WB7y8lnkdn/Yv2ZgrsJlXx0mw0E7VsRZba0JSOxWA8Sn8 cLf8zwNHyHyYi4qeAHO1xUgRSeABxnfx4ghEsOw3Dh6oYuAD9EKeiaNDzlTY2gkr kdGj+E2wXQT+2BaiQ7wNX7wFB3T1HIzxKR5XfnOwbxFjci0aIp+Fp3BVo1QjCjqF tq5+sRYsVc3f+VZUlyuO0ubPDjrfvJwX6qsbRArvBfD91TwVY2sxE893ijSzdPL1 aSVwpExy0Ndfj2q4YQXjAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707689644; x= 1707776044; bh=fwWtNMw/E8Oe+szPKyBvg4LOLT2jgNMHgvqZr8GinRs=; b=g RX39n4sx1oQhv5HYpIU0a2VzhUVYIRTrONB4TZmb0+BisO5vQfao7xcZYry5N++R YR84y/sko+tk4FReP6pbaCC+jSxtKYKFbOZ+w+oos6jMoEywfiMEJbY5TxOM2G8g aHkC1WB3buE6So6EpSohHBZnaIUTuUy6lbBqRheeEtbSyoh/XrlPF1TsWoRIgY4e uIdhtVhWCxhH6DfUGD27d05wFkAkuZtEO32qX8CZwTJsTSDMqYDwbwSNcjGcTCaB h8fqsz7rQZlG2opVnYAvt7+Fq6gS0QN8ECWQT0YhoOPfbBo22ja3abK6cMf9rBhF Cle01c+lo15X1IJNRJgSw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddugdduiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgfgsehtqhertddtreejnecuhfhrohhmpeevlhor mhgvnhhtucfnrghsshhivghurhcuoegtlhgvmhgvnhhtsehlrghsshhivghurhdrohhrgh eqnecuggftrfgrthhtvghrnhepgeekheefffdtfeffueevkefgfffhtddugfdugeeugeev gfduteffudfgfefhjedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomheptghlvghmvghntheslhgrshhsihgvuhhrrdhorhhg X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 11 Feb 2024 17:14:02 -0500 (EST) From: =?utf-8?Q?Cl=C3=A9ment_Lassieur?= To: Ian Eure Subject: Re: [bug#67512] [PATCH v2 1/4] gnu: Move icu4c-73 from gnuzilla to icu4c. In-Reply-To: <20240211192031.32284-2-ian@retrospec.tv> (Ian Eure's message of "Sun, 11 Feb 2024 11:20:24 -0800") References: <20240211192031.32284-2-ian@retrospec.tv> Date: Sun, 11 Feb 2024 23:14:01 +0100 Message-ID: <87jzna4pjq.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, Mark H Weaver , Jonathan Brielmaier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, Feb 11 2024, Ian Eure wrote: > * gnu/packages/icu4c.scm (icu4c-73): New variable. > * gnu/packages/gnuzilla.scm (icu4c-73-promise): Delete variable. > > Change-Id: I017e1416b70ecb94313aeb71aa4a0cafdfe0e9ab I'm sorry, but with this patch neither mullvadbrowser or torbrowser builds. I get: --8<---------------cut here---------------start------------->8--- error: icu4c-73-promise: unbound variable --8<---------------cut here---------------end--------------->8--- Cl=C3=A9ment From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 18:23:56 2024 Received: (at 67512) by debbugs.gnu.org; 11 Feb 2024 23:23:56 +0000 Received: from localhost ([127.0.0.1]:58241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZJAy-0000sY-BO for submit@debbugs.gnu.org; Sun, 11 Feb 2024 18:23:56 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:39971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZJAu-0000s3-IX for 67512@debbugs.gnu.org; Sun, 11 Feb 2024 18:23:55 -0500 Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.nyi.internal (Postfix) with ESMTP id 43B8C5C0056 for <67512@debbugs.gnu.org>; Sun, 11 Feb 2024 18:23:30 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 11 Feb 2024 18:23:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1707693810; x=1707780210; bh=9X1EhZE/x6G0TcKAAbCtXxqbLIUf7tr0TeZh1/5576U=; b= V6Tma7OacPdrzcNHj3Oeg0fxAY7X5VcjPptQBnvPDqK+sP9m47fRHH4u+zqYNHqM 6nveRUh8WIZBaYfFWHydWqdtov9Mn4XYPDKQaivCiF5W3AAGyiuSRJXyxI7DX2IV C+dkeEot4K8WCJAF7VjVEFk1EUmoS0Apxv8C1FyqRRgA+7yc+8M8+M1FAhDLtU7O wcbHK5e0iEbtbeANQolOVtbyzBqGfi4V+gqE39gV6pqST754bfxP8HgtEeSQJhAV lFL9TDcjvJ2Jdr43h9Fz6G8a0xykvtWrPCHSTUejl3/FmB7HY+cd1uTrgNXAKOvq S87a0qGZ720rQ5gp01jxoA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707693810; x= 1707780210; bh=9X1EhZE/x6G0TcKAAbCtXxqbLIUf7tr0TeZh1/5576U=; b=F 8Q5/si/fFNoDZaXq8bLMmYQq3KdN0XsXuyoo9jbl80sWjbJkA9Wdw5L85HHLAYpz JGVeWa3gxYnsX6CH4tNivIguVchHEUFyzF5bk4MKeo35UCgOI6cfYgohhcu27Yb4 bYDiFA9dxF+umAjVvd5w5/qHqCXG/7QU4F7BKkfe5bJF9MSDnUbwL1dte0AnsYFt JEbZ4AMm7JUbFAJ1j3gW+AFHsDi/M37IltS0tDQPM6gsCMCYTklyqZSKosCKvOxA uCe6EJOd6iK7mfDm6MUs2JLxqVVGXvKmlI+db/5BFHNwEfa4t/xm1jA70eyLtR48 4E/ZIKBNrPkeoqTIehF0A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddvgddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfhgfhffvufffjgfkgggtgfesthhqre dttderjeenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdr thhvqeenucggtffrrghtthgvrhhnpeevudeuvefgudeftdehkeegkeeitdeivdelgfejhf dvgfegiedutdeludeileegudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <67512@debbugs.gnu.org>; Sun, 11 Feb 2024 18:23:29 -0500 (EST) References: <20240211192031.32284-1-ian@retrospec.tv> <87eddihhte.fsf@lassieur.org> User-agent: mu4e 1.8.13; emacs 28.2 From: Ian Eure To: 67512@debbugs.gnu.org Subject: Re: [bug#67512] [PATCH v2 0/4] Add Librewolf Date: Sun, 11 Feb 2024 15:23:04 -0800 In-reply-to: <87eddihhte.fsf@lassieur.org> Message-ID: <87zfw6y49b.fsf@retrospec.tv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Cl=C3=A9ment Lassieur writes: > On Sun, Feb 11 2024, Ian Eure wrote: > >> Updated patch series. >> >> * Updates LibreWolf to 122.0-2. >> * Moved the icu4c-73-future package definition in (gnu packages=20 >> gnuzilla) to (gnu packages icu4c). >> * Updating icu4c to 73.1 would cause a world rebuild, so this=20 >> is added as `icu4c-73' to avoid that. >> * Disabled EME. >> * Uses GNU Mozzarella instead of Firefox for addons. >> * Updates NSS package. >> * Unbundles libpng-apng, libwebp, nss, libevent, and libvpx. > > Well we still have no news from the Wasm person? > Seems like no. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 18:30:48 2024 Received: (at 67512) by debbugs.gnu.org; 11 Feb 2024 23:30:48 +0000 Received: from localhost ([127.0.0.1]:58741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZJHa-0001CW-68 for submit@debbugs.gnu.org; Sun, 11 Feb 2024 18:30:47 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:56201) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZJHY-0001C5-2X for 67512@debbugs.gnu.org; Sun, 11 Feb 2024 18:30:44 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 727215C0090 for <67512@debbugs.gnu.org>; Sun, 11 Feb 2024 18:30:22 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 11 Feb 2024 18:30:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1707694222; x=1707780622; bh=t9hOh4E9NNrWI37lHhNcsbqHemGPndtwqTzxBP6lX68=; b= OccItMDIL4tSMdsKkOpfSpoIinT6VY9dJX2uh18KJ8LP9bNyU4HLCnu2+hvAcWbU lR0evIVK6dVgwhwuUMDaUaQsrnrvc7RWIiGJWkRsjaz0U/VbEmVCZnyyCqHip+hG 5hiuZX8SnX2VTlC7nT5YOrZmOT4crsXlZTnpbSc1C2hV8vt+/z3lCatfIH+MDKdw Kk2CUiuSp7oTFp+cTS6xNM4vj4m6ABBk6kkqRkY09GxAxsgDR97hTJok0qmxKqzu B6cPrsDdZE0x7EvnPnipkvOtHTPUeotUP7R/fVBwTf3A4r6XreVgkqHeYg9l29SD DZzPvg383TMlQU2m/ybHmg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707694222; x= 1707780622; bh=t9hOh4E9NNrWI37lHhNcsbqHemGPndtwqTzxBP6lX68=; b=K z+YrgQOVWRc6GlpVqWoV+8XZZXU9iS9USStg/Pm4o1j+XwgTHMlgWWBUxmtqK/Jl gNxFCggH1e9Eljfy3h+tHT6Azzktyvgob56qB4pVshv/YI8PNWd+KopD6Lhtl16N zpu/Ot3am/memiG52cY9euNC2R8RDtGkjftBR8FfbyiyVVcrxZDEdn+edsEMYEH0 j7SUb4/er768AO4sy4nvRN9YTKJEB1WBjN+119LyhugnaAblXB6wvsBNctQ3T97O IvM+ASU/ipvqfRg4noxSzNFRU97YbyLXNUEvg+UB5/1L1Y3N3386jMGW1C51Lbd8 pkmzj4OdcGC3SgmRcvMHQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddvgdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfhgfhffvufffjgfkgggtgfesthhqre dttderjeenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdr thhvqeenucggtffrrghtthgvrhhnpeevudeuvefgudeftdehkeegkeeitdeivdelgfejhf dvgfegiedutdeludeileegudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <67512@debbugs.gnu.org>; Sun, 11 Feb 2024 18:30:21 -0500 (EST) References: <20240211192031.32284-2-ian@retrospec.tv> <87jzna4pjq.fsf@lassieur.org> User-agent: mu4e 1.8.13; emacs 28.2 From: Ian Eure To: 67512@debbugs.gnu.org Subject: Re: [bug#67512] [PATCH v2 1/4] gnu: Move icu4c-73 from gnuzilla to icu4c. Date: Sun, 11 Feb 2024 15:23:39 -0800 In-reply-to: <87jzna4pjq.fsf@lassieur.org> Message-ID: <87v86uy3xu.fsf@retrospec.tv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Cl=C3=A9ment Lassieur writes: > On Sun, Feb 11 2024, Ian Eure wrote: > >> * gnu/packages/icu4c.scm (icu4c-73): New variable. >> * gnu/packages/gnuzilla.scm (icu4c-73-promise): Delete=20 >> variable. >> >> Change-Id: I017e1416b70ecb94313aeb71aa4a0cafdfe0e9ab > > I'm sorry, but with this patch neither mullvadbrowser or=20 > torbrowser > builds. > > I get: > > error: icu4c-73-promise: unbound variable > It=E2=80=99s a oneliner fix, I=E2=80=99ll have an updated patch momentarily. The root of the issue is that `make-torbrowser' is very naughty=20 and uses the unexported icu4c-73-promise symbol from (gnu packages=20 gnuzilla), so it broke when I moved it to the proper (gnu packages=20 icu4c) module. =E2=80=94 Ian From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 18:32:39 2024 Received: (at 67512) by debbugs.gnu.org; 11 Feb 2024 23:32:39 +0000 Received: from localhost ([127.0.0.1]:58883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZJJO-0001Hx-5A for submit@debbugs.gnu.org; Sun, 11 Feb 2024 18:32:39 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:43007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZJJI-0001HP-CN for 67512@debbugs.gnu.org; Sun, 11 Feb 2024 18:32:36 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id BD2D15C005B; Sun, 11 Feb 2024 18:32:10 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 11 Feb 2024 18:32:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1707694330; x=1707780730; bh=fmk9f76e76pjDp6/tXGreA37cOUgNESHS/74JIHXN8M=; b= C/CGll6DhioPN2TD27WrayiOEFEkbi0Fh4RMYTUUXFraHESFAVYIjcCmJk88fEwW yTTHIIPdAQgPtCxm8T6SmLsChO7mxsK2aSnTSFrmLgsio08cVTkAsyueGWJ/0s9q KCNZ9pVNsCbxvYGDsPgjK3SOIRcsQn7ve2U+uIzxqWeNnnbGdrRBKRaWNY7A224h H4cwzdqbeAeIJOkiHtGDmdAclzE0muGqIGHjV5nfJHzJPJ8RDx1DaqQPXM4Uq9Ru lfjE1ZobW42in/aiKwlFGTEbd+rwNXB04aj+OV+ItwpPROvoxYIX7HXfOIk9m99y 9WiZPlek3vCOfI4qGvSu7g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707694330; x= 1707780730; bh=fmk9f76e76pjDp6/tXGreA37cOUgNESHS/74JIHXN8M=; b=k w6YuPWjhl1abR0pIN+n+/XKeuYFS5q7JjKR1cEijXHZUA+iogDBeGKW1F7lLBAnA uRfAkixrZ9/yZgjJrKyFkCjrhnUEkP3IOFSXfI2gkKD2oPcJlP0WBq7XL9w4ufQd b0itntCIZtVGOCRXtD0nXlUx7WKFCKV15WM1yozLbf4aM106gwGCFK67afnznXix NPDTMQZVLeoA78Qj31Ly0xONxe1nYfKNGfl7d6plBGpRjcqhdKavOIUgS1pkEQRk XjidGYJhUoxqbOed94KFv2CsSKkahjU1167K9o0lRgrt32pfIdJxawECERrPo7AY kQimB3J7pcNwuFz1Izrtw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddvgdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefujghffffkfgggtgfgsehtqh ertddtreejnecuhfhrohhmpeevlhormhgvnhhtucfnrghsshhivghurhcuoegtlhgvmhgv nhhtsehlrghsshhivghurhdrohhrgheqnecuggftrfgrthhtvghrnhepgeekheefffdtfe ffueevkefgfffhtddugfdugeeugeevgfduteffudfgfefhjedunecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheptghlvghmvghntheslhgrshhsih gvuhhrrdhorhhg X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 11 Feb 2024 18:32:09 -0500 (EST) From: =?utf-8?Q?Cl=C3=A9ment_Lassieur?= To: Ian Eure Subject: Re: [bug#67512] [PATCH v2 0/4] Add Librewolf In-Reply-To: <87zfw6y49b.fsf@retrospec.tv> (Ian Eure's message of "Sun, 11 Feb 2024 15:23:04 -0800") References: <20240211192031.32284-1-ian@retrospec.tv> <87eddihhte.fsf@lassieur.org> <87zfw6y49b.fsf@retrospec.tv> Date: Mon, 12 Feb 2024 00:32:07 +0100 Message-ID: <87bk8m4lxk.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, Feb 11 2024, Ian Eure wrote: > Cl=C3=A9ment Lassieur writes: > >> On Sun, Feb 11 2024, Ian Eure wrote: >> >>> Updated patch series. >>> >>> * Updates LibreWolf to 122.0-2. >>> * Moved the icu4c-73-future package definition in (gnu packages gnuzill= a) >>> to (gnu packages icu4c). >>> * Updating icu4c to 73.1 would cause a world rebuild, so this is added = as >>> `icu4c-73' to avoid that. >>> * Disabled EME. >>> * Uses GNU Mozzarella instead of Firefox for addons. >>> * Updates NSS package. >>> * Unbundles libpng-apng, libwebp, nss, libevent, and libvpx. >> >> Well we still have no news from the Wasm person? >> > > Seems like no. Unrelated, but please do "reply to all", it helps. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 18:34:49 2024 Received: (at 67512) by debbugs.gnu.org; 11 Feb 2024 23:34:49 +0000 Received: from localhost ([127.0.0.1]:59057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZJLU-0001OA-N6 for submit@debbugs.gnu.org; Sun, 11 Feb 2024 18:34:49 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:39517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZJLS-0001Nl-Ue for 67512@debbugs.gnu.org; Sun, 11 Feb 2024 18:34:47 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 50B195C009A; Sun, 11 Feb 2024 18:34:25 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 11 Feb 2024 18:34:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1707694465; x=1707780865; bh=HWV0cU9mSMnZr8EL9gtRHpzSJv5F90mAriHtgbFMtOc=; b= O6xoD5aDWU0GDh5/xXqZZ8psI9VJUZcyhs9m2XFr/evPxy8WKwjgIqmSEYxrzSnC 7FgSUTjfcoD8TGHQqkrg1IEMzF2Bg0Ha8/JqD4586tM7fyb1RDJB9jQo4muZEXoa 7KYTI0WzVZQV5nm+u0PMmspKZy7oCOKK00/iPx5+hSxwAH7kILf/E5qsxnF5b8Z1 y5oo/6zFKJxKtxBj3uVJmDr7w03fPMj9M9TuFUzhuTXqZQqrQJhpqWcZDK1hM2PZ nfYQnwMVDp4OqeVvFG4lJ3ozCYqVeo7aytpNZYOLNTlqeU8+71N+wVB3pgBlmuuA +/4gAtZgsRdsX8y+/PpQdQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707694465; x= 1707780865; bh=HWV0cU9mSMnZr8EL9gtRHpzSJv5F90mAriHtgbFMtOc=; b=z AqCT3juLTpg5I2j2tYGc79qPO2gd0svjH0etSao2gYheMoep6cGTRaNs17/fU9fy t1KG702my2PhwNxdeJGI7fLEDWvcAiz/T+32GZK75nNCuL55vPzhS1LqTqjNUh+L TkIUorfWnmd/28+U2fk+RifhpT5gz/+fjgl1KWjN4NKcxllefSeCeon1UFkQjfVn VROz/Thstr6RAd5Rl07uI1GgChxhINXGzHdWANCdGAoTyCazjln+aIF2N2VpiimA qm5m7ga5aN5sH2WUl8r7ZZWd1zN7ukUHwz1tt+NZR9qTlufM8yjuEu4qSuZxzNpk 24pmWRRVVLsvwv9iQBOFw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddvgdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefujghffffkfgggtgfgsehtqh ertddtreejnecuhfhrohhmpeevlhormhgvnhhtucfnrghsshhivghurhcuoegtlhgvmhgv nhhtsehlrghsshhivghurhdrohhrgheqnecuggftrfgrthhtvghrnhepgeekheefffdtfe ffueevkefgfffhtddugfdugeeugeevgfduteffudfgfefhjedunecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheptghlvghmvghntheslhgrshhsih gvuhhrrdhorhhg X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 11 Feb 2024 18:34:24 -0500 (EST) From: =?utf-8?Q?Cl=C3=A9ment_Lassieur?= To: Ian Eure Subject: Re: [bug#67512] [PATCH v2 1/4] gnu: Move icu4c-73 from gnuzilla to icu4c. In-Reply-To: <87v86uy3xu.fsf@retrospec.tv> (Ian Eure's message of "Sun, 11 Feb 2024 15:23:39 -0800") References: <20240211192031.32284-2-ian@retrospec.tv> <87jzna4pjq.fsf@lassieur.org> <87v86uy3xu.fsf@retrospec.tv> Date: Mon, 12 Feb 2024 00:34:23 +0100 Message-ID: <87jznaa83k.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, Feb 11 2024, Ian Eure wrote: > Cl=C3=A9ment Lassieur writes: > >> On Sun, Feb 11 2024, Ian Eure wrote: >> >>> * gnu/packages/icu4c.scm (icu4c-73): New variable. >>> * gnu/packages/gnuzilla.scm (icu4c-73-promise): Delete variable. >>> >>> Change-Id: I017e1416b70ecb94313aeb71aa4a0cafdfe0e9ab >> >> I'm sorry, but with this patch neither mullvadbrowser or torbrowser >> builds. >> >> I get: >> >> error: icu4c-73-promise: unbound variable >> > > It=E2=80=99s a oneliner fix, I=E2=80=99ll have an updated patch momentari= ly. > > The root of the issue is that `make-torbrowser' is very naughty and uses = the > unexported icu4c-73-promise symbol from (gnu packages gnuzilla), so it br= oke > when I moved it to the proper (gnu packages icu4c) module. Well thanks for making it less naughty then ;) From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 18:50:23 2024 Received: (at 67512) by debbugs.gnu.org; 11 Feb 2024 23:50:23 +0000 Received: from localhost ([127.0.0.1]:60210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZJaY-0002BU-Bz for submit@debbugs.gnu.org; Sun, 11 Feb 2024 18:50:23 -0500 Received: from fhigh6-smtp.messagingengine.com ([103.168.172.157]:56103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZJaS-0002Ar-5p for 67512@debbugs.gnu.org; Sun, 11 Feb 2024 18:50:21 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 87722114009C; Sun, 11 Feb 2024 18:49:54 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 11 Feb 2024 18:49:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :subject:subject:to:to; s=fm2; t=1707695394; x=1707781794; bh=t9 zcTh/3F5OJ78xUWkwpnOkg66naOfDct7RvwWpolUM=; b=dcp4IPndgxXAcrzm3H 4IbKe5H1jKjbsbTdzmJvR+wZ9/XfgnpbQIL3nDAhawKMNkT9DfLxVTIPypAzsNyd XkrsAqVPbAOLydE6SeuFRjW3UkfRZ/IgkLdq3UPdq7gckXvJFif6DmDGrPi4ir5I v4Fx1ti7QPlMTXQUVe8mEqyrWAPYkZ8NCVHx3I0mjG5nthFp+jSDmpi33VrM7Mrv c6P5Mj2DKWHxGKquyVGV68n4IxL6teFEEv0jJroZKq2VlH4acrsQCU1+wbZas5ws +gdwg9Gi8Lh5Y1CXScmk6Cvs79zJx1m9bkZK7CKDLBVnYct9uRtRbvVJBXhMBapc 0xIA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1707695394; x=1707781794; bh=t9zcTh/3F5OJ7 8xUWkwpnOkg66naOfDct7RvwWpolUM=; b=vw5VOyxeJtcLVvK1ApJ2swdVA1h5T 1tJ+o28s4UwSNVdaJoUuPIEU8sWsOqMZgiXh8J2WNs5HueJQMj1jJPKMKJAnhQ3d qLeiC39oQJDHEr/TLccjJcpyDxG2LlTlOT/YIRAT7HDrsNzdaE4GYIB0K92biRtT fuAkCuEF+sYg3KvIxRHxEB51AE0F3tR+Ojg0ov9i8pHLAYF1dOF4JLAoBKqZIIh3 VIzxp112BsYq71p+pEbU3Kv9mHdVnREAD1bYsRlfgTHhdJZ88z+kWIptBj9Lyd8o ZNN0qoeJIaQAZgEHmOntkoz9Y20FsHXUfcr16k7Voo+gXkiyV09gRZVAQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddvgddugecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofggtgfgsehtkeertd ertdejnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggtrdht vheqnecuggftrfgrthhtvghrnhepkeethfektdfghfdtuefhteejvdduueejudfhvedvie dvudfhkeevhedvteegfeffnecuffhomhgrihhnpehmohiiihhllhgrrdhorhhgnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihgrnhesrhgvth hrohhsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 11 Feb 2024 18:49:53 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v3 2/4] gnu: nss: Update to 3.97. Date: Sun, 11 Feb 2024 15:49:42 -0800 Message-ID: <20240211234948.7568-2-ian@retrospec.tv> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/nss.scm (nss): Update to 3.97. * gnu/packages/certs.scm (nss-certs): Update to 3.97. --- gnu/packages/certs.scm | 4 ++-- gnu/packages/nss.scm | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gnu/packages/certs.scm b/gnu/packages/certs.scm index 58b4d50ec8..2a6106df78 100644 --- a/gnu/packages/certs.scm +++ b/gnu/packages/certs.scm @@ -131,7 +131,7 @@ (define-public nss-certs ;; XXX We used to refer to the nss package here, but that eventually caused ;; module cycles. The below is a quick copy-paste job that must be kept in ;; sync manually. Surely there's a better way…? - (version "3.88.1") + (version "3.97") (source (origin (method url-fetch) (uri (let ((version-with-underscores @@ -142,7 +142,7 @@ (define-public nss-certs "nss-" version ".tar.gz"))) (sha256 (base32 - "15il9fsmixa1r4446zq1wl627sg0hz9h67w6kjxz273xz3nl7li7")) + "02pscmkp7flawmgwqzr807nsn6kzzw7r7xjbzfql0bpkjf1zp3h7")) ;; Create nss.pc and nss-config. (patches (search-patches "nss-3.56-pkgconfig.patch" "nss-getcwd-nonnull.patch" diff --git a/gnu/packages/nss.scm b/gnu/packages/nss.scm index 54b9e5041a..268ddaa24f 100644 --- a/gnu/packages/nss.scm +++ b/gnu/packages/nss.scm @@ -106,7 +106,7 @@ (define-public nss ;; IMPORTANT: Also update and test the nss-certs package, which duplicates ;; version and source to avoid a top-level variable reference & module ;; cycle. - (version "3.88.1") + (version "3.97") (source (origin (method url-fetch) (uri (let ((version-with-underscores @@ -117,7 +117,7 @@ (define-public nss "nss-" version ".tar.gz"))) (sha256 (base32 - "15il9fsmixa1r4446zq1wl627sg0hz9h67w6kjxz273xz3nl7li7")) + "02pscmkp7flawmgwqzr807nsn6kzzw7r7xjbzfql0bpkjf1zp3h7")) ;; Create nss.pc and nss-config. (patches (search-patches "nss-3.56-pkgconfig.patch" "nss-getcwd-nonnull.patch" @@ -200,7 +200,7 @@ (define-public nss ;; leading to test failures: ;; . To ;; work around that, set the time to roughly the release date. - (invoke "faketime" "2022-11-01" "./nss/tests/all.sh")) + (invoke "faketime" "2024-01-23" "./nss/tests/all.sh")) (format #t "test suite not run~%")))) (replace 'install (lambda* (#:key outputs #:allow-other-keys) -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 18:50:23 2024 Received: (at 67512) by debbugs.gnu.org; 11 Feb 2024 23:50:24 +0000 Received: from localhost ([127.0.0.1]:60213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZJaZ-0002Bc-4h for submit@debbugs.gnu.org; Sun, 11 Feb 2024 18:50:23 -0500 Received: from fhigh6-smtp.messagingengine.com ([103.168.172.157]:41835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZJaR-0002Ap-JA for 67512@debbugs.gnu.org; Sun, 11 Feb 2024 18:50:21 -0500 Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 7E6DF114009D; Sun, 11 Feb 2024 18:49:53 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sun, 11 Feb 2024 18:49:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to; s=fm2; t=1707695393; x=1707781793; bh=RQcrtaZh5wOmaQ9Zp34NR jHAom07pHBNiZTxlYbuQyY=; b=C8MzZbZy/jwT7EL2dCTZ4tJAPy8zOrbRnSC2O joQirVlE1o8INXIxGpTs+IjFPpz5gQ03QABGeBOsMuqmCDB2JSwODX8vS4q6Xrar bd1XsBGRk7h3iKhoDZOhuYTSZGi3urOLfFhVhCYxhp96/lFxS/YEY9pQ6FhEZdOz w4MYmEmFrz9Pv4nOmnD+IACiQgYRZo56MI4YTJBG/gH+znv97gALJJJGU3Dknsi4 r4zx+WS/pzOvKYgyMsCK6kvy7ZMeBfkNUExVzSBi2m4aNBOoru2d8yWsFm2uMX6Z O4cz2FSmk0CWMZz1Lo25b2C7xtX0DF1+Ipgbzdld6jU2iSLQw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1707695393; x=1707781793; bh=RQcrtaZh5wOmaQ9Zp34NRjHAom07 pHBNiZTxlYbuQyY=; b=kog3J53J8H7Tm37tQm0t8QuMi+pU4WVzOuNB4eozCboC nWQAj5GtPKxBCC+MU+zhKHJsnb4xiggPoIn2N5PFTfk/sgn6ONfLDaJVCBQ2CrAZ QExk0HUMZqvQtx6z0CEBZDr/xUaykf9yieOXJslw+25zEoNgK1jwY+6smXkAWq6S ij5JtKmaF4zIqXBh5wiepWpSrh3y0SonUyonFbyGA7xr7yCUvLa/FztJ8cX8tZzJ dcXjX7kPPoytn3B23Ipw/kCmiyRD+HJX/ZnstNAeNWoJHFn3rPMYvsM0HS+QJnE4 zBAox760LRZh0I0Rxp6HqEwTtrB/0wVl+nsCfhSltg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddvgdduhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgggfestdekredtre dttdenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdrthhv qeenucggtffrrghtthgvrhhnpefhheehfeevgefffffgkeelhfdtkeefheehtddtjeelie egleejudeljeetfeeukeenucffohhmrghinhepghhithhhuhgsrdgtohhmpdhmohiiihhl lhgrrdhorhhgpdhitghuqdhprhhojhgvtghtrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepihgrnhesrhgvthhrohhsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 11 Feb 2024 18:49:52 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v3 1/4] gnu: Move icu4c-73 from gnuzilla to icu4c. Date: Sun, 11 Feb 2024 15:49:41 -0800 Message-ID: <20240211234948.7568-1-ian@retrospec.tv> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Debbugs-Cc: Clément Lassieur , Jonathan Brielmaier , Mark H Weaver Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/icu4c.scm (icu4c-73): New variable. * gnu/packages/gnuzilla.scm (icu4c-73-promise): Delete variable. Change-Id: I017e1416b70ecb94313aeb71aa4a0cafdfe0e9ab --- gnu/packages/gnuzilla.scm | 27 +-------------------------- gnu/packages/icu4c.scm | 22 ++++++++++++++++++++++ gnu/packages/tor-browsers.scm | 3 ++- 3 files changed, 25 insertions(+), 27 deletions(-) diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm index 5f77512427..094ff348e9 100644 --- a/gnu/packages/gnuzilla.scm +++ b/gnu/packages/gnuzilla.scm @@ -375,31 +375,6 @@ (define-public mozjs-78 (list icu4c-69 readline zlib)))) -;; -;; Needed for IceCat 115. -;; -(define icu4c-73-promise - (delay - (package - (inherit icu4c) - (version "73.1") - (source (origin - (method url-fetch) - (uri (string-append - "https://github.com/unicode-org/icu/releases/download/release-" - (string-map (lambda (x) (if (char=? x #\.) #\- x)) version) - "/icu4c-" - (string-map (lambda (x) (if (char=? x #\.) #\_ x)) version) - "-src.tgz")) - (sha256 - (base32 - "0iccpdvc0kvpww5a31k9gjkqigyz016i7v80r9zamd34w4fl6mx4")) - (patches - (cons - (search-patch - "icu4c-fix-TestHebrewCalendarInTemporalLeapYear.patch") - (origin-patches (package-source icu4c))))))))) - ;;; ;;; Localization helper procedures. ;;; @@ -757,7 +732,7 @@ (define-public icecat-minimal ;; https://bugzilla.mozilla.org/show_bug.cgi?id=1819374). ffmpeg-5 libvpx - (force icu4c-73-promise) + icu4c-73 pixman pulseaudio mesa diff --git a/gnu/packages/icu4c.scm b/gnu/packages/icu4c.scm index 5aaf3a8361..0dfe63b20a 100644 --- a/gnu/packages/icu4c.scm +++ b/gnu/packages/icu4c.scm @@ -109,6 +109,28 @@ (define-public icu4c (license x11) (home-page "http://site.icu-project.org/"))) +(define-public icu4c-73 + (package + (inherit icu4c) + (name "icu4c") + (version "73.1") + (source (origin + (method url-fetch) + (uri (string-append + "https://github.com/unicode-org/icu/releases/download/release-" + (string-map (lambda (x) (if (char=? x #\.) #\- x)) version) + "/icu4c-" + (string-map (lambda (x) (if (char=? x #\.) #\_ x)) version) + "-src.tgz")) + (sha256 + (base32 + "0iccpdvc0kvpww5a31k9gjkqigyz016i7v80r9zamd34w4fl6mx4")) + (patches + (cons + (search-patch + "icu4c-fix-TestHebrewCalendarInTemporalLeapYear.patch") + (origin-patches (package-source icu4c)))))))) + (define-public icu4c-70 (package (inherit icu4c) diff --git a/gnu/packages/tor-browsers.scm b/gnu/packages/tor-browsers.scm index c4ce997b99..ee5e072102 100644 --- a/gnu/packages/tor-browsers.scm +++ b/gnu/packages/tor-browsers.scm @@ -52,6 +52,7 @@ (define-module (gnu packages tor-browsers) #:use-module (gnu packages golang) #:use-module (gnu packages gtk) #:use-module (gnu packages hunspell) + #:use-module (gnu packages icu4c) #:use-module (gnu packages image) #:use-module (gnu packages kerberos) #:use-module (gnu packages libcanberra) @@ -270,7 +271,7 @@ (define* (make-torbrowser #:key ;; https://bugzilla.mozilla.org/show_bug.cgi?id=1819374). ffmpeg-5 libvpx - (force (@@ (gnu packages gnuzilla) icu4c-73-promise)) + icu4c-73 pixman pulseaudio mesa -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 18:50:29 2024 Received: (at 67512) by debbugs.gnu.org; 11 Feb 2024 23:50:29 +0000 Received: from localhost ([127.0.0.1]:60217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZJaZ-0002Bt-Vs for submit@debbugs.gnu.org; Sun, 11 Feb 2024 18:50:29 -0500 Received: from fout4-smtp.messagingengine.com ([103.168.172.147]:60491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZJaU-0002Ax-GF for 67512@debbugs.gnu.org; Sun, 11 Feb 2024 18:50:22 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.nyi.internal (Postfix) with ESMTP id C811713800A6; Sun, 11 Feb 2024 18:49:56 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 11 Feb 2024 18:49:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :subject:subject:to:to; s=fm2; t=1707695396; x=1707781796; bh=Et c6S9/5T7Im+FHY1F0OhmTE96jQ2Lzi+U31fD3M1ek=; b=UPGe0shs2UP5uzvCJd juhBYPHLSiSAZwZahHkg+9YVTh/7sesxadyG+xhbQItTdeLZLq7MUHitQkLe/ULe GO61bY7MM4rAzvcfifcw8aa1g/wLqmDISYpf2ONmg9iJP3f8ri/mIJtppn8Gsmej /qv461qPscnsdu09Dwi32IDUIs+Tj9zuvH3U3LJ3hDtsl/lvQ5oUCNNRGgnJ+Aht 4qQEW12CFYn1//sH+fm5Cj7w52n78lU55RS9K5JJz3bhzr15vLhQJz8fKbrbiXyG j9yHP+xtpAF027RG7PMqA0D+htjd+4xNdXjEym/QVsDfsc71EmqYVml0vmx4vgGd xaew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1707695396; x=1707781796; bh=Etc6S9/5T7Im+ FHY1F0OhmTE96jQ2Lzi+U31fD3M1ek=; b=iCm/q6QBmczlBHQN9gZKgS+NGOyMA Qv+OlL7NRFLRvewN/C6EUEPpx4AjObmoTL12Yp3Gz4aqMl9uNVMnrDmi9cL8DAoX o6FqOe1VUs9HBtui+ixN/y5I8KD+0Y2TLpJ1cw7EcsDAtHjF12X7iEAMWs/o5zbI b5cYFvY7eCY2IRlS3cbLov66B7vzjAMMfUf4WfBRg3Up+dYUKMEs+aMKo3CU9ff0 rHE7L9PCQRbRbUIZ8KOl5sSEsPnYDM1lRwLVGUdppzQXeI66N6VDH7Q8J4MLqAdJ AItTHx+n4UkrgIumgVrRkM5SDmz+1MqMyGU8+CCI2R8QhNLF7bwD4E3Vw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddvgddugecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofggtgfgsehtkeertd ertdejnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggtrdht vheqnecuggftrfgrthhtvghrnhepieffhedtieetffehteduudehteevkeejvdduhedvle ejkeettdeuudeltddukeeknecuffhomhgrihhnpehgnhhurdhorhhgpdhsvggrrhgthhhf ohigrdhorhhgpdhgihhtlhgrsgdrtghomhdptghonhhtvghnthdrrhgvrggupdhmohiiih hllhgrrdhorhhgpdhgvghtrgguughonhhsrdhsvggrrhgthhdpghgvthgrugguohhnshdr lhhinhhkpdhgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 11 Feb 2024 18:49:55 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v3 4/4] gnu: Add librewolf. Date: Sun, 11 Feb 2024 15:49:44 -0800 Message-ID: <20240211234948.7568-4-ian@retrospec.tv> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/librewolf.scm (librewolf): New variable. Change-Id: I98b6410582b856ede83b79637a58e66d6e5832e6 --- gnu/packages/librewolf.scm | 653 +++++++++++++++++++++++++++++++++++++ 1 file changed, 653 insertions(+) create mode 100644 gnu/packages/librewolf.scm diff --git a/gnu/packages/librewolf.scm b/gnu/packages/librewolf.scm new file mode 100644 index 0000000000..32d51eabaf --- /dev/null +++ b/gnu/packages/librewolf.scm @@ -0,0 +1,653 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2013, 2015, 2024 Andreas Enge +;;; Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019 Ludovic Courtès +;;; Copyright © 2014, 2015, 2016, 2017, 2018, 2019, 2020, 2021 Mark H Weaver +;;; Copyright © 2015 Sou Bunnbu +;;; Copyright © 2016, 2017, 2018, 2019 Efraim Flashner +;;; Copyright © 2016 Alex Griffin +;;; Copyright © 2017 Clément Lassieur +;;; Copyright © 2017, 2018 Nikita +;;; Copyright © 2017, 2018 ng0 +;;; Copyright © 2017, 2018, 2020 Tobias Geerinckx-Rice +;;; Copyright © 2018, 2020, 2022 Ricardo Wurmus +;;; Copyright © 2019 Ivan Petkov +;;; Copyright © 2020 Oleg Pykhalov +;;; Copyright © 2020 Jakub Kądziołka +;;; Copyright © 2019, 2020 Adrian Malacoda +;;; Copyright © 2020-2023 Jonathan Brielmaier +;;; Copyright © 2020 Zhu Zihao +;;; Copyright © 2021 pineapples +;;; Copyright © 2021 Brice Waegeneire +;;; Copyright © 2021, 2022, 2023 John Kehayias +;;; Copyright © 2022 Pierre Langlois +;;; Copyright © 2023 Tomas Volf +;;; Copyright © 2023 Ian Eure +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + + +(define-module (gnu packages librewolf) + #:use-module (guix build-system gnu) + #:use-module (guix build-system cargo) + #:use-module (guix build-system trivial) + #:use-module (guix download) + #:use-module ((guix licenses) #:prefix license:) + #:use-module (guix gexp) + #:use-module (guix packages) + #:use-module (guix utils) + #:use-module ((guix build utils) #:select (alist-replace)) + + #:use-module (gnu packages) + #:use-module (gnu packages assembly) + #:use-module (gnu packages autotools) + #:use-module (gnu packages base) + #:use-module (gnu packages bash) + #:use-module (gnu packages compression) + #:use-module (gnu packages crates-io) + #:use-module (gnu packages cups) + #:use-module (gnu packages fontutils) + #:use-module (gnu packages gl) + #:use-module (gnu packages glib) + #:use-module (gnu packages gnome) + #:use-module (gnu packages gtk) + #:use-module (gnu packages hunspell) + #:use-module (gnu packages icu4c) + #:use-module (gnu packages image) + #:use-module (gnu packages jemalloc) + #:use-module (gnu packages kerberos) + #:use-module (gnu packages libcanberra) + #:use-module (gnu packages libevent) + #:use-module (gnu packages libffi) + #:use-module (gnu packages linux) + #:use-module (gnu packages llvm) + #:use-module (gnu packages m4) + #:use-module (gnu packages node) + #:use-module (gnu packages nss) + #:use-module (gnu packages pciutils) + #:use-module (gnu packages perl) + #:use-module (gnu packages pkg-config) + #:use-module (gnu packages pulseaudio) + #:use-module (gnu packages python) + #:use-module (gnu packages rust) + #:use-module (gnu packages rust-apps) + #:use-module (gnu packages speech) + #:use-module (gnu packages sqlite) + #:use-module (gnu packages video) + #:use-module (gnu packages wasm) + #:use-module (gnu packages xdisorg) + #:use-module (gnu packages xorg)) + +;; Define the versions of rust needed to build firefox, trying to match +;; upstream. See the file taskcluster/ci/toolchain/rust.yml at +;; https://searchfox.org under the particular firefox release, like +;; mozilla-esr102. +(define rust-librewolf rust) ; 1.60 is the default in Guix, 1.65 is the minimum. + +;; Update this id with every firefox update to its release date. +;; It's used for cache validation and therefore can lead to strange bugs. +(define %librewolf-build-id "20240130195200") + +(define-public librewolf + (package + (name "librewolf") + (version "122.0-2") + (source + (origin + (method url-fetch) + + (uri (string-append "https://gitlab.com/api/v4/projects/32320088/" + "packages/generic/librewolf-source/" + version + "/librewolf-" + version + ".source.tar.gz")) + (sha256 + (base32 "0ggysgbazx5dl0l9dyvrpjgzbvivgddm9qyiyvjjfk9im9sljkxh")))) + (build-system gnu-build-system) + (arguments + (list + #:configure-flags #~(let ((clang #$(this-package-native-input "clang")) + (wasi-sysroot #$(this-package-native-input + "wasm32-wasi-clang-toolchain"))) + `("--enable-application=browser" + + ;; Configuration + "--with-system-jpeg" + "--with-system-zlib" + "--with-system-png" + "--with-system-webp" + "--with-system-icu" + "--with-system-libvpx" + "--with-system-libevent" + "--with-system-ffi" + "--enable-system-pixman" + "--enable-jemalloc" + + ;; see https://bugs.gnu.org/32833 + "--with-system-nspr" + "--with-system-nss" + + ,(string-append "--with-clang-path=" clang + "/bin/clang") + ,(string-append "--with-libclang-path=" clang + "/lib") + ,(string-append "--with-wasi-sysroot=" + wasi-sysroot "/wasm32-wasi") + + ;; Distribution + "--with-distribution-id=org.guix" + "--with-app-name=librewolf" + "--with-app-basename=LibreWolf" + "--with-branding=browser/branding/librewolf" + + ;; Features + "--disable-tests" + "--disable-updater" + "--enable-pulseaudio" + "--disable-crashreporter" + "--allow-addon-sideload" + "--with-unsigned-addon-scopes=app,system" + "--disable-eme" + + ;; Build details + "--disable-debug" + "--enable-rust-simd" + "--enable-release" + "--enable-optimize" + "--enable-strip" + "--enable-hardening" + "--disable-elf-hack")) + #:imported-modules %cargo-utils-modules + #:modules `((ice-9 regex) + (ice-9 string-fun) + (ice-9 ftw) + (srfi srfi-1) + (srfi srfi-26) + (rnrs bytevectors) + (rnrs io ports) + (guix elf) + (guix build gremlin) + ,@%gnu-build-system-modules) + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'fix-preferences + (lambda* (#:key inputs #:allow-other-keys) + (let ((port (open-file "browser/app/profile/firefox.js" + "a"))) + (define (write-setting key value) + (format port "~%pref(\"~a\", ~a);~%" key value) + (format #t + "fix-preferences: setting value of ~a to ~a~%" key + value)) + + ;; We should allow Firefox sandbox to read the store directory, + ;; because Firefox sandbox have access to /usr on FHS distros. + (write-setting + "security.sandbox.content.read_path_whitelist" + (string-append "\"" + (%store-directory) "/\"")) + + ;; XDG settings should be managed by Guix. + (write-setting "browser.shell.checkDefaultBrowser" + "false") + (close-port port)))) + (add-after 'fix-preferences 'fix-ffmpeg-runtime-linker + (lambda* (#:key inputs #:allow-other-keys) + (let* ((ffmpeg (assoc-ref inputs "ffmpeg")) + (libavcodec (string-append ffmpeg + "/lib/libavcodec.so"))) + ;; Arrange to load libavcodec.so by its absolute file name. + (substitute* "dom/media/platforms/ffmpeg/FFmpegRuntimeLinker.cpp" + (("libavcodec\\.so") + libavcodec))))) + (add-after 'patch-source-shebangs 'patch-cargo-checksums + (lambda _ + (use-modules (guix build cargo-utils)) + (let ((null-hash + ;; This is the SHA256 output of an empty string. + (string-append + "e3b0c44298fc1c149afbf4c8996fb924" + "27ae41e4649b934ca495991b7852b855"))) + (for-each (lambda (file) + (format #t + "patch-cargo-checksums: patching checksums in ~a~%" + file) + (substitute* file + (("(checksum = )\".*\"" all name) + (string-append name "\"" null-hash + "\"")))) + (find-files "." "Cargo\\.lock$")) + (for-each generate-all-checksums + '("build" "dom/media" + "dom/webauthn" + "gfx" + "intl" + "js" + "media" + "modules" + "mozglue/static/rust" + "netwerk" + "remote" + "security/manager/ssl" + "servo" + "storage" + "third_party/rust" + "toolkit" + "xpcom/rust" + "services"))))) + (add-after 'patch-cargo-checksums 'remove-cargo-frozen-flag + (lambda _ + ;; Remove --frozen flag from cargo invokation, otherwise it'll + ;; complain that it's not able to change Cargo.lock. + ;; https://bugzilla.mozilla.org/show_bug.cgi?id=1726373 + (substitute* "build/RunCbindgen.py" + (("\"--frozen\",") + "")))) + (delete 'bootstrap) + (add-before 'configure 'patch-SpeechDispatcherService.cpp + (lambda _ + (let* ((lib "libspeechd.so.2") + (file (string-append + "dom/media/webspeech/synth/" + "speechd/SpeechDispatcherService.cpp")) + (old-content (call-with-input-file file + get-string-all))) + (substitute file + `((,(format #f "~s" lib) unquote + (λ (line _) + (string-replace-substring line lib + (string-append #$speech-dispatcher + "/lib/" + lib)))))) + (if (string=? old-content + (call-with-input-file file + get-string-all)) + (error + "substitute did nothing, phase requires an update"))))) + (add-before 'configure 'set-build-id + ;; Firefox will write the timestamp to output, which is harmful + ;; for reproducibility, so change it to a fixed date. Use a + ;; separate phase for easier modification with inherit. + (lambda _ + (setenv "MOZ_BUILD_DATE" + #$%librewolf-build-id))) + (replace 'configure + (lambda* (#:key inputs outputs configure-flags + #:allow-other-keys) + (setenv "AUTOCONF" + (string-append (assoc-ref inputs "autoconf") + "/bin/autoconf")) + (setenv "SHELL" + (which "bash")) + (setenv "CONFIG_SHELL" + (which "bash")) + (setenv "MACH_BUILD_PYTHON_NATIVE_PACKAGE_SOURCE" + "system") + ;; This should use the host info probably (does firefox build on + ;; non-x86_64 though?) + (setenv "GUIX_PYTHONPATH" + (string-append (getcwd) + "/obj-x86_64-pc-linux-gnu/_virtualenvs/build")) + + ;; Use Clang, Clang is 2x faster than GCC + (setenv "AR" "llvm-ar") + (setenv "NM" "llvm-nm") + (setenv "CC" "clang") + (setenv "CXX" "clang++") + (setenv "WASM_CC" + (string-append (assoc-ref inputs + "wasm32-wasi-clang-toolchain") + "/bin/clang")) + (setenv "WASM_CXX" + (string-append (assoc-ref inputs + "wasm32-wasi-clang-toolchain") + "/bin/clang++")) + + (setenv "MOZ_NOSPAM" "1") + (setenv "MOZ_APP_NAME" "librewolf") + + (setenv "MOZBUILD_STATE_PATH" + (getcwd)) + + (let* ((mozconfig (string-append (getcwd) "/mozconfig")) + (out (assoc-ref outputs "out")) + (flags (cons (string-append "--prefix=" out) + configure-flags))) + (format #t "build directory: ~s~%" + (getcwd)) + (format #t "configure flags: ~s~%" flags) + + (define write-flags + (lambda flags + (display (string-join (map (cut string-append + "ac_add_options " <>) + flags) "\n")) + (display "\n"))) + (with-output-to-file mozconfig + (lambda () + (apply write-flags flags) + ;; The following option unsets Telemetry + ;; Reporting. With the Addons Fiasco, + ;; Mozilla was found to be collecting + ;; user's data, including saved passwords + ;; and web form data, without users + ;; consent. Mozilla was also found + ;; shipping updates to systems without + ;; the user's knowledge or permission. + ;; As a result of this, use the following + ;; command to permanently disable + ;; telemetry reporting in Firefox. + (display "unset MOZ_TELEMETRY_REPORTING\n") + (display "mk_add_options MOZ_CRASHREPORTER=0\n") + (display "mk_add_options MOZ_DATA_REPORTING=0\n") + (display + "mk_add_options MOZ_SERVICES_HEALTHREPORT=0") + (display + "mk_add_options MOZ_TELEMETRY_REPORTING=0"))) + (setenv "MOZCONFIG" mozconfig)) + (invoke "./mach" "configure"))) + (add-before 'build '1fix-addons-placeholder + (lambda _ + (substitute* + "toolkit/locales/en-US/toolkit/about/aboutAddons.ftl" + (("addons.mozilla.org") "gnuzilla.gnu.org")))) + (replace 'build + (lambda* (#:key (make-flags '()) + (parallel-build? #t) #:allow-other-keys) + (apply invoke "./mach" "build" + ;; mach will use parallel build if possible by default + `(,@(if parallel-build? + '() + '("-j1")) ,@make-flags)))) + (add-after 'build 'neutralise-store-references + (lambda _ + ;; Mangle the store references to compilers & + ;; other build tools in about:buildconfig, + ;; reducing Firefox's closure by 1 GiB on + ;; x86-64. + (let* ((build-dir (car (scandir "." + (cut string-prefix? + "obj-" <>)))) + (file (string-append build-dir + "/dist/bin/chrome/toolkit/" + "content/global/buildconfig.html"))) + (substitute* file + (((format #f "(~a/)([0-9a-df-np-sv-z]{32})" + (regexp-quote (%store-directory))) + _ store hash) + (string-append store + (string-take hash 8) + "" + (string-drop hash 8))))))) + (replace 'install + (lambda _ + (invoke "./mach" "install"))) + (add-after 'install 'remove-duplicate-bin + (lambda* (#:key outputs #:allow-other-keys) + (delete-file (string-append #$output + "/lib/librewolf/librewolf-bin")))) + (add-after 'install 'wrap-glxtest + ;; glxtest uses dlopen() to load mesa + ;; libs, wrap it to set LD_LIBRARY_PATH. + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (lib (string-append out "/lib")) + ;; TODO: make me a loop again + (mesa-lib (string-append (assoc-ref inputs + "mesa") + "/lib")) + (pciutils-lib (string-append (assoc-ref inputs + "pciutils") "/lib"))) + (wrap-program (car (find-files lib "^glxtest$")) + `("LD_LIBRARY_PATH" prefix + (,mesa-lib ,pciutils-lib)))))) + (add-after 'install 'autoconfig + (lambda* (#:key inputs #:allow-other-keys) + (let ((lib (string-append #$output "/lib/librewolf")) + (config-file "librewolf.cfg")) + (with-output-to-file (in-vicinity + lib "defaults/pref/autoconfig.js") + (lambda () + (format #t "// first line must be a comment~%") + (format #t "pref(~s, ~s);~%" + "general.config.filename" config-file) + (format #t "pref(~s, ~a);~%" + "general.config.obscure_value" "0"))) + (with-output-to-file (in-vicinity lib config-file) + (lambda () + (format #t "// first line must be a comment~%") + ;; Required for Guix packaged extensions + ;; SCOPE_PROFILE=1, SCOPE_APPLICATION=4, SCOPE_SYSTEM=8 + ;; Default is 5. + (format #t "pref(~s, ~a);~%" + "extensions.enabledScopes" "13") + ;; (format #t "pref(~s, ~s);~%" + ;; "security.sandbox.content.read_path_whitelist" + ;; (call-with-input-file "whitelist.txt" + ;; get-string-all)) + ;; Add-ons pannel (see settings.js in Icecat source). + (format #t "pref(~s, ~s);~%" + "extensions.getAddons.search.browseURL" + "https://gnuzilla.gnu.org/mozzarella") + (format #t "pref(~s, ~s);~%" + "extensions.getAddons.get.url" + "https://gnuzilla.gnu.org/mozzarella") + (format #t "pref(~s, ~s);~%" + "extensions.getAddons.link.url" + "https://gnuzilla.gnu.org/mozzarella") + (format #t "pref(~s, ~s);~%" + "extensions.getAddons.discovery.api_url" + "https://gnuzilla.gnu.org/mozzarella") + (format #t "pref(~s, ~s);~%" + "extensions.getAddons.langpacks.url" + "https://gnuzilla.gnu.org/mozzarella") + (format #t "pref(~s, ~s);~%" + "lightweightThemes.getMoreURL" + "https://gnuzilla.gnu.org/mozzarella")))))) + (add-after 'install 'wrap-program + (lambda* (#:key inputs outputs #:allow-other-keys) + ;; The following two functions are from Guix's icecat package in + ;; (gnu packages gnuzilla). See commit + ;; b7a0935420ee630a29b7e5ac73a32ba1eb24f00b. + (define (runpath-of lib) + (call-with-input-file lib + (compose elf-dynamic-info-runpath elf-dynamic-info + parse-elf get-bytevector-all))) + (define (runpaths-of-input label) + (let* ((dir (string-append (assoc-ref inputs label) + "/lib")) + (libs (find-files dir "\\.so$"))) + (append-map runpath-of libs))) + (let* ((out (assoc-ref outputs "out")) + (lib (string-append out "/lib")) + ;; TODO: make me a loop again + (mesa-lib (string-append (assoc-ref inputs + "mesa") + "/lib")) + (apng-lib (string-append (assoc-ref inputs + "libpng-apng") "/lib")) + ;; For the integration of native notifications + (libnotify-lib (string-append (assoc-ref inputs + "libnotify") + "/lib")) + ;; For hardware video acceleration via VA-API + (libva-lib (string-append (assoc-ref inputs + "libva") + "/lib")) + ;; VA-API is run in the RDD (Remote Data Decoder) sandbox + ;; and must be explicitly given access to files it needs. + ;; Rather than adding the whole store (as Nix had + ;; upstream do, see + ;; and + ;; linked upstream patches), we can just follow the + ;; runpaths of the needed libraries to add everything to + ;; LD_LIBRARY_PATH. These will then be accessible in the + ;; RDD sandbox. + (rdd-whitelist (map (cut string-append <> "/") + (delete-duplicates (append-map + runpaths-of-input + '("mesa" + "ffmpeg"))))) + (pulseaudio-lib (string-append (assoc-ref inputs + "pulseaudio") + "/lib")) + ;; For U2F and WebAuthn + (eudev-lib (string-append (assoc-ref inputs + "eudev") + "/lib")) + (gtk-share (string-append (assoc-ref inputs + "gtk+") + "/share"))) + (wrap-program (car (find-files lib "^librewolf$")) + `("LD_LIBRARY_PATH" prefix + (,mesa-lib ,libnotify-lib + ,libva-lib + ,pulseaudio-lib + ,eudev-lib + ,apng-lib + ,@rdd-whitelist)) + `("XDG_DATA_DIRS" prefix + (,gtk-share)) + `("MOZ_LEGACY_PROFILES" = + ("1")) + `("MOZ_ALLOW_DOWNGRADE" = + ("1")))))) + (add-after 'wrap-program 'install-desktop-entry + (lambda* (#:key outputs #:allow-other-keys) + (let* ((desktop-file + "taskcluster/docker/firefox-snap/firefox.desktop") + (applications (string-append #$output + "/share/applications"))) + (substitute* desktop-file + (("^Exec=firefox") + (string-append "Exec=" + #$output "/bin/librewolf")) + ;; "Firefox" -> "LibreWolf" everywhere + (("Firefox") + "LibreWolf") + ;; Remove non-Latin translations. + (("^Name\\[(ar|bn)\\].*$") + "") + (("^Icon=.*") + (string-append "Icon=" + #$output + "/share/icons/hicolor/128x128/apps/librewolf.png +")) + ;; These commands were changed. + (("-NewWindow") + "-new-window") + (("-NewPrivateWindow") + "-new-private-window") + (("StartupNotify=true") + "StartupNotify=true +StartupWMClass=Navigator")) + (copy-file desktop-file "librewolf.desktop") + (install-file "librewolf.desktop" applications)))) + (add-after 'install-desktop-entry 'install-icons + (lambda* (#:key outputs #:allow-other-keys) + (let ((icon-source-dir (string-append #$output + "/lib/librewolf/browser/" + "chrome/icons/default"))) + (for-each (lambda (size) + (let ((dest (string-append #$output + "/share/icons/hicolor/" + size + "x" + size + "/apps"))) + (mkdir-p dest) + (symlink (string-append icon-source-dir + "/default" size ".png") + (string-append dest + "/librewolf.png")))) + '("16" "32" "48" "64" "128")))))) + + ;; Test will significantly increase build time but with little rewards. + #:tests? #f + + ;; WARNING: Parallel build will consume lots of memory! + ;; If you have encountered OOM issue in build phase, try disable it. + #:parallel-build? #t + + ;; Some dynamic lib was determined at runtime, so rpath check may fail. + #:validate-runpath? #f)) + (inputs (list bash-minimal + bzip2 + cairo + cups + dbus-glib + freetype + ffmpeg + gdk-pixbuf + glib + gtk+ + gtk+-2 + hunspell + icu4c-73 + jemalloc + libcanberra + libevent + libffi + libgnome + libjpeg-turbo + libnotify + libpng-apng + libva + libvpx + libwebp + libxcomposite + libxft + libxinerama + libxscrnsaver + libxt + mesa + mit-krb5 + nspr + nss + pango + pciutils + pipewire + pixman + pulseaudio + speech-dispatcher + sqlite + startup-notification + eudev + unzip + zip + zlib)) + (native-inputs (list alsa-lib + autoconf-2.13 + `(,rust-librewolf "cargo") + clang + llvm + wasm32-wasi-clang-toolchain + m4 + nasm + node-lts + perl + pkg-config + python + rust-librewolf + rust-cbindgen-0.26 + which + yasm)) + (home-page "https://mozilla.org/firefox/") + (synopsis "Trademarkless version of Firefox") + (description + "Full-featured browser client built from Firefox source tree, without +the official icon and the name \"firefox\". This is the Extended Support +Release (ESR) version.") + (license license:mpl2.0))) -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 18:50:30 2024 Received: (at 67512) by debbugs.gnu.org; 11 Feb 2024 23:50:30 +0000 Received: from localhost ([127.0.0.1]:60219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZJaf-0002CA-EE for submit@debbugs.gnu.org; Sun, 11 Feb 2024 18:50:30 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:43605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZJaV-0002At-Qv for 67512@debbugs.gnu.org; Sun, 11 Feb 2024 18:50:23 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id A20A95C0069; Sun, 11 Feb 2024 18:49:55 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 11 Feb 2024 18:49:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :subject:subject:to:to; s=fm2; t=1707695395; x=1707781795; bh=oB C0nCRtRxlGrAQi9DWyfMS5etQoFM0ANvepl8rXmd8=; b=OGD7nbe87e86e3r4Nl 37w4i68gVdMbs820I5XDT7lV1sJfg+K+mdaOoi9c/xELHGaB0RbXiiDUCHasYuUx OI+ZN7W9/h4mO+w4/GtIYRTnnJLxH7umzaKmbro+oCd82VplBj8MiDXyz5f62RrJ 9dxc3tlQ7rjfP6LiwOuv8YbNRAY2LuYwrzFtBAT3NmlVRypgtxjh8H9IErBDjrdi O+tOrBHiH30pC/imZ5qHR59C9PerL5qsTOFDyIpGh39pD+R/99WZBhbtaXhygx5N LYGuYkfXatWuvCCO38og44reFRsxggC4JjsgRHrMJCsRsZe23ZKwHuzVsi2rsK3u zNEg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1707695395; x=1707781795; bh=oBC0nCRtRxlGr AQi9DWyfMS5etQoFM0ANvepl8rXmd8=; b=Dt/lXDbvV8s76ah03hWUjQk+2elog SdTOrtUal8KW3xZ6mZzPievsTmeSRtuvzVyJ3+YZY8N5q7zxS3h1X3k0eXCEptcp GRSXw6baxN9cT5i46tUhP657UoYHtay5BSxE51RgiR2+2JlfHuqxeg7BTNkVUO8Y DbNJnBPH9rSgTgxYwYJDaI1qZEzInSkVHicG5ZnJB67ygeiEz86sVTC4S7k6y7FI FQZSBEwTB2QJMtjobk/dkG9wVxgVGa+9f0IGSIR3OmsJUWKqFIX+y373RKxP+kQD 8lbVIvtRHzsWW2tIF4feawXkE7LqivqYtyeIeCjQND2YU/APpfGciI6bA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddvgdduhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofggtgfgsehtkeertd ertdejnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggtrdht vheqnecuggftrfgrthhtvghrnhepheetveeiveffvedtfeevudejkeehieeggeetveffte ffveejtddugedugedvffeknecuffhomhgrihhnpehgnhhurdhorhhgpdhgihhthhhusgdr tghomhdpmhhoiihilhhlrgdrohhrghdpfigrshhirdguvghvpdhllhhvmhdrohhrghenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehr vghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 11 Feb 2024 18:49:54 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v3 3/4] gnu: Add wasm packages. Date: Sun, 11 Feb 2024 15:49:43 -0800 Message-ID: <20240211234948.7568-3-ian@retrospec.tv> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/wasm.scm (wasi-libc): New variable. * gnu/packages/wasm.scm (wasm32-wasi-clang-runtime): New variable. * gnu/packages/wasm.scm (wasm32-wasi-clang): New variable. * gnu/packages/wasm.scm (wasm32-wasi-libcxx): New variable. * gnu/packages/wasm.scm (wasm32-wasi-clang-toolchain): New variable. --- gnu/packages/wasm.scm | 273 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 273 insertions(+) create mode 100644 gnu/packages/wasm.scm diff --git a/gnu/packages/wasm.scm b/gnu/packages/wasm.scm new file mode 100644 index 0000000000..05d247f333 --- /dev/null +++ b/gnu/packages/wasm.scm @@ -0,0 +1,273 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2022-2023 Pierre Langlois +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + +(define-module (gnu packages wasm) + #:use-module (guix base32) + #:use-module (guix gexp) + #:use-module (guix packages) + #:use-module ((guix licenses) #:prefix license:) + #:use-module (guix utils) + #:use-module (guix git-download) + #:use-module (guix build-system cmake) + #:use-module (guix build-system gnu) + #:use-module (guix build-system trivial) + #:use-module (gnu packages bash) + #:use-module (gnu packages llvm) + #:use-module (gnu packages python)) + +(define-public wasi-libc + (package + (name "wasi-libc") + (version "sdk-19") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/WebAssembly/wasi-libc") + (commit (string-append "wasi-" version)) + (recursive? #t))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0bnpz8wk9wiic938296gxp4vz820bvpi1w41jksjzz5552hql169")))) + (build-system gnu-build-system) + (native-inputs (list clang-15)) + (arguments + (list + #:tests? #f ;No test suite + ;; Firefox uses wasm2c to compile WebAssembly to C code, and it + ;; does not support the memory.copy opcode. + ;; See https://bugzilla.mozilla.org/show_bug.cgi?id=1773200#c4 + #:make-flags ''("BULK_MEMORY_SOURCES=") + #:phases #~(modify-phases %standard-phases + (delete 'configure) + (add-before 'build 'set-sysroot-include + (lambda _ + (setenv "C_INCLUDE_PATH" + (string-append (getcwd) "/sysroot/include")))) + (add-before 'install 'set-install-dir + (lambda _ + (setenv "INSTALL_DIR" + (string-append #$output "/wasm32-wasi"))))))) + (home-page "https://wasi.dev") + (synopsis "WASI libc implementation for WebAssembly") + (description + "WASI Libc is a libc for WebAssembly programs built on top of WASI +system calls. It provides a wide array of POSIX-compatible C APIs, including +support for standard I/O, file I/O, filesystem manipulation, memory +management, time, string, environment variables, program startup, and many +other APIs.") + (license (list + ;; For wasi-libc, with LLVM exceptions + license:asl2.0 + ;; For malloc.c. + license:cc0 + ;; For cloudlibc. + license:bsd-2 + ;; For wasi-libc and musl-libc. + license:expat)))) + +(define-public wasm32-wasi-clang-runtime + (package (inherit clang-runtime-15) + (native-inputs + (list clang-15 + wasi-libc)) + (inputs (list llvm-15)) + (arguments + (list + #:build-type "Release" + #:tests? #f + ;; Stripping binaries breaks wasm linking, resulting in the following + ;; error: "archive has no index; run ranlib to add one". + #:strip-binaries? #f + #:configure-flags + #~(list "-DCMAKE_C_COMPILER=clang" + "-DCMAKE_C_COMPILER_TARGET=wasm32-wasi" + (string-append + "-DCMAKE_SYSROOT=" #$wasi-libc "/wasm32-wasi") + (string-append + "-DCMAKE_C_FLAGS=-I " #$wasi-libc "/wasm32-wasi/include") + + "-DCOMPILER_RT_OS_DIR=wasi" + + "-DCOMPILER_RT_BAREMETAL_BUILD=On" + "-DCOMPILER_RT_DEFAULT_TARGET_ONLY=On" + + ;; WASM only needs libclang_rt.builtins-wasm32.a from + ;; compiler-rt. + "../source/compiler-rt/lib/builtins"))))) + +;; FIXME: Ideally we wouldn't need to build a separate compiler because clang +;; can support multiple targets at runtime. However Guix patches the default +;; clang with a specific clang-runtime package. It would be good to improve +;; upstream Guix's support for cross-compiling with clang. + +(define clang-from-llvm (@@ (gnu packages llvm) clang-from-llvm)) +(define llvm-monorepo (@@ (gnu packages llvm) llvm-monorepo)) + +(define-public wasm32-wasi-clang + (let ((base (clang-from-llvm llvm-15 wasm32-wasi-clang-runtime))) + (package + (inherit base) + (name "wasm32-wasi-clang") + (inputs (modify-inputs (package-inputs base) + (prepend wasi-libc))) + (arguments + (substitute-keyword-arguments (package-arguments base) + ((#:configure-flags flags) + #~(list "-DCLANG_INCLUDE_TESTS=True" + ;; Use a sane default include directory. + (string-append "-DC_INCLUDE_DIRS=" + #$wasi-libc "/wasm32-wasi/include"))) + ((#:phases phases) + `(modify-phases ,phases + (delete 'symlink-cfi_ignorelist)))))))) + +(define-public wasm32-wasi-libcxx + (package + (name "wasm32-wasi-libcxx") + (version (package-version llvm-15)) + (source + (llvm-monorepo version)) + (build-system cmake-build-system) + (arguments + (list + #:configure-flags #~(list (string-append "-S ../source/runtimes") + + "-DLLVM_ENABLE_RUNTIMES=libcxx;libcxxabi" + + (string-append "-DCMAKE_SYSROOT=" + #$wasi-libc "/wasm32-wasi") + + (string-append "-DCMAKE_INCLUDE_PATH=" + #$wasi-libc + "/wasm32-wasi/include") + + (string-append "-DCMAKE_STAGING_PREFIX=" + #$output "/wasm32-wasi") + + "-DCMAKE_C_COMPILER=clang" + "-DCMAKE_C_COMPILER_WORKS=ON" + "-DCMAKE_CXX_COMPILER=clang++" + "-DCMAKE_CXX_COMPILER_WORKS=ON" + "-DCMAKE_C_COMPILER_TARGET=wasm32-wasi" + "-DCMAKE_CXX_COMPILER_TARGET=wasm32-wasi" + + "-DLIBCXX_LIBDIR_SUFFIX=/wasm32-wasi" + + "-DLIBCXX_ENABLE_EXCEPTIONS=OFF" + "-DLIBCXX_ENABLE_SHARED=OFF" + "-DLIBCXX_ENABLE_THREADS=OFF" + "-DLIBCXX_ENABLE_FILESYSTEM=OFF" + + "-DLIBCXXABI_LIBDIR_SUFFIX=/wasm32-wasi" + + "-DLIBCXXABI_ENABLE_EXCEPTIONS=OFF" + "-DLIBCXXABI_ENABLE_SHARED=OFF" + "-DLIBCXXABI_ENABLE_THREADS=OFF" + "-DLIBCXXABI_ENABLE_FILESYSTEM=OFF") + #:tests? #f + #:phases #~(modify-phases %standard-phases + (add-after 'set-paths 'adjust-CPLUS_INCLUDE_PATH + (lambda _ + (setenv "CPLUS_INCLUDE_PATH" + (string-append #$wasi-libc + "/wasm32-wasi/include:" + (getenv "CPLUS_INCLUDE_PATH")))))))) + (native-inputs (list lld python wasm32-wasi-clang)) + (inputs (list wasi-libc)) + (home-page "https://libcxx.llvm.org") + (synopsis "C++ standard library for WebAssembly") + (description + "This package provides an implementation of the C++ standard library for +use with Clang, targeting C++11, C++14 and above. This package targets +WebAssembly with WASI.") + (license license:expat))) + +(define-public wasm32-wasi-clang-toolchain + (package + (name "wasm32-wasi-clang-toolchain") + (version (package-version wasm32-wasi-clang)) + (source + #f) + (build-system trivial-build-system) + (arguments + (list + #:builder (with-imported-modules '((guix build union) + (guix build utils)) + #~(begin + (use-modules (guix build union) + (guix build utils)) + (union-build #$output + (list #$wasm32-wasi-clang-runtime + #$wasi-libc + #$wasm32-wasi-libcxx)) + (mkdir-p (string-append #$output + "/bin")) + + ;; We provide clang and clang++ via a wrapped program that sets + ;; include paths correctly so that it does not include paths from + ;; the host. + + ;; FIXME: Review how we can provide better support for + ;; cross-compiling with clang in Guix, maybe adding support for + ;; the CROSS_C_INCLUDE_PATH and CROSS_CPLUS_INCLUDE_PATH + ;; environment variables like GCC. + + (for-each (lambda (bin) + (symlink (string-append #$wasm32-wasi-clang + bin) + (string-append #$output + bin)) + (wrap-program (string-append #$output + bin) + #:sh (string-append #$bash-minimal + "/bin/bash") + `("C_INCLUDE_PATH" + ":" = + (,(string-append #$output + "/wasm32-wasi/include"))) + `("CPLUS_INCLUDE_PATH" + ":" = + ;; Make sure inclure/c++/v1 comes first for #include_next + ;; to work. + (,(string-append #$output + "/wasm32-wasi/include/c++/v1") , + (string-append #$output + "/wasm32-wasi/include"))))) + '("/bin/clang" + "/bin/clang++")) + + (symlink (string-append #$lld + "/bin/wasm-ld") + (string-append #$output + "/bin/wasm-ld")))))) + (inputs (list bash-minimal + lld + wasi-libc + wasm32-wasi-clang + wasm32-wasi-clang-runtime + wasm32-wasi-libcxx)) + (license (cons (package-license wasm32-wasi-clang) + (package-license wasi-libc))) + (home-page "https://clang.llvm.org") + (synopsis + "Complete Clang toolchain for C/C++ development, for WebAssembly.") + (description + "This package provides a complete Clang toolchain for C/C++ +development targeting WebAssembly with WASI. This includes Clang, as well as +libc, libc++ and wasm-ld."))) -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 13 15:34:44 2024 Received: (at 67512) by debbugs.gnu.org; 13 Feb 2024 20:34:44 +0000 Received: from localhost ([127.0.0.1]:47763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZzUJ-0006IQ-Cq for submit@debbugs.gnu.org; Tue, 13 Feb 2024 15:34:44 -0500 Received: from fout8-smtp.messagingengine.com ([103.168.172.151]:37855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZzUE-0006Hu-Nf for 67512@debbugs.gnu.org; Tue, 13 Feb 2024 15:34:42 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.nyi.internal (Postfix) with ESMTP id A5A9513800EE; Tue, 13 Feb 2024 15:34:15 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 13 Feb 2024 15:34:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to; s=fm2; t=1707856455; x=1707942855; bh=FyIedIvNy8CbonEt0axfO cUh7sbEopADoo8or9yX2A0=; b=YKOxh3umQjduxecYQAcxhtbxQZ8LESpnL8yDT nl6eo0eJTjT49emNxZAWmQX2vk4tD42Fy9BOnAKTBKwr0dJBa84R9xb7xTotOUXg TG56sRVtKXMbf3kblKa26hJz3aVKXUhWaxJ5YExjwofYIGmmpfdxS8DXmT21FI/n YfcatKSubW8qxVX78OlETIRXAZVaq9x1hr+bmKS5dGBLurft8m4cODIWxmvFnZRa WR4TKOBM/300gQSg7CJ6ZTGdGh09Yn3dW95kEe5/wjWWDdrQ3XZ2+GplYv6wmrE9 1XsSV/x5UOmPHIyvUI7ZkaY2fOP5F0x3X+xQv+r0N7+f+zf0Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1707856455; x=1707942855; bh=FyIedIvNy8CbonEt0axfOcUh7sbE opADoo8or9yX2A0=; b=Gwo2BGen09Tc3OjfZThiGeRUNmAm6MiDyKZ2sg4IsZdS zMIWQA8TWk2BvoV/VQdmnucwveVHHm1hVhvk/3mkDn4RubB8EHro+CKWwKJIGnt5 Wv4FNZ9IV0ITgziaJU1tNStvBSOD3W6izHkMLcRX2ffxpjOMhi09q3iPsLJJYepG 15b4S2h03RvEoM1J0JZdOZNYiusx1w20QHrwriGlJgiFXhpDU5zF5t0BAfja9Ls9 L8e4CXru9IteIQ9xMo8YtqT8WS3PaKM9IH9C42UsBBvH2DlbxruH3llZfS+0I1+B LDJrrrjlFFMqLzgXoa4HDJFxfY9j/oBttWC9MWzRqQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudehgddufeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggtrdht vheqnecuggftrfgrthhtvghrnhepiefhuddttedvtdeludefgeffvdegtefhffehveevtd dtfffgudejjeetfffgiedunecuffhomhgrihhnpehgvghtrgguughonhhsrdhsvggrrhgt hhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirg hnsehrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 13 Feb 2024 15:34:14 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v4 0/4] Add LibreWolf Date: Tue, 13 Feb 2024 12:34:02 -0800 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) During testing, I found some problems with v3 of the patch. * The vendor-provided browser config was getting clobbered during 'autoconfig. Reworked this to append to librewolf.cfg instead of obliterating it or using autoconfig.js. * Extension search from about:addons was broken, because extensions.getAddons.search.browseURL was missing the %TERMS% placeholder. Added. * extensions.getAddons settings were defined with pref() instead of defaultPref(). pref() is for user settings, and causes them to show up as modified in about:config, with a revert button to restore the value from defaultPref (which is Mozilla's addons repo). Switched to defaultPref(). Both the extension search and pref/defaultPref issues are present in torbrowser and mullvad, and *if* those upstreams ship autoconfig.js files, their contents won't make it into the Guix packages. Someone might want to look into those issues. Ian Eure (4): gnu: Move icu4c-73 from gnuzilla to icu4c. gnu: nss: Update to 3.97. gnu: Add wasm packages. gnu: Add librewolf. gnu/packages/certs.scm | 4 +- gnu/packages/gnuzilla.scm | 27 +- gnu/packages/icu4c.scm | 22 ++ gnu/packages/librewolf.scm | 642 ++++++++++++++++++++++++++++++++++ gnu/packages/nss.scm | 6 +- gnu/packages/tor-browsers.scm | 3 +- gnu/packages/wasm.scm | 273 +++++++++++++++ 7 files changed, 945 insertions(+), 32 deletions(-) create mode 100644 gnu/packages/librewolf.scm create mode 100644 gnu/packages/wasm.scm base-commit: b6439fc5f800b5d22d48192bc347be794f050329 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 13 15:34:45 2024 Received: (at 67512) by debbugs.gnu.org; 13 Feb 2024 20:34:45 +0000 Received: from localhost ([127.0.0.1]:47768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZzUL-0006Il-7K for submit@debbugs.gnu.org; Tue, 13 Feb 2024 15:34:45 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:53951) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZzUH-0006Hx-GS for 67512@debbugs.gnu.org; Tue, 13 Feb 2024 15:34:42 -0500 Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.nyi.internal (Postfix) with ESMTP id B7F0E5C00B4; Tue, 13 Feb 2024 15:34:17 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 13 Feb 2024 15:34:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1707856457; x= 1707942857; bh=enOsNQ8CRbPWW4n1cdI6D4rSUopgfZyrdG2iHfE31R0=; b=U fb0hQm8sOc0sWYAw8JQqAHnKReivYhrxpb5e1qpILMzP+yJ0xUhhvr+waIWx1VYH 3inc+omFV14enT573nAog5VuocRVYloWFm1po3SM9BqHTgYCObPAWuzFdJ1PbJtb Jps2OAGIEedcx0g5dnwh+7TyM7iTp2YQpHCR5vLckH/GkxvlpOUmK7gLYsalMIaW cxuop2uDf8Lv73lWklk7IQ1hGijln2qlKOnYK0h6qsoIdsYtdr0Oa/qK4bI8iKXu UWx+zOl/UyMvBJFNoLFUaJkvrbQYq6xxtFU1NBxgUsWuOxa7HoGRhjzPQVk996L6 +TdkXCZH6D91SN+wSnyMA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707856457; x= 1707942857; bh=enOsNQ8CRbPWW4n1cdI6D4rSUopgfZyrdG2iHfE31R0=; b=c XclgmhLjvnKSumun34GslW/ikBS95OX4xagV8ERusiqa+3qxoX9qUzIFGf4aDI0b +BHsq2HLIVidMPjm6k9jTCFfo0ohgZT//lLK/zA4wELurwgAxGJENiRqeWQJgeNU be/dYgdf2poTytdrV0vSPrL+ttLV9k4EU54OEuEMCXjcryfew/vFjrgtc9ZHLUKh WNUIHbO0jwInj310XqMmb6goDUYFzsUis3wZqDFoKbNyofAp5Sy508ZsDPZ5ocPn X74D+K+TLCgyGMxwPYaJVeNUHh8WBg+vHY2D5ThDQEK9vtWNmoI6/YFAm50z68d+ 4jc4N1jSI3MBtcEPTFXWg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudehgddufeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggt rdhtvheqnecuggftrfgrthhtvghrnheptddtudeludeitedvgeffleefjefgteeuudduhf eivedvtdffieettdetueeuudeknecuffhomhgrihhnpehgihhthhhusgdrtghomhdpmhho iihilhhlrgdrohhrghdpihgtuhdqphhrohhjvggtthdrohhrghenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggt rdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 13 Feb 2024 15:34:16 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v4 1/4] gnu: Move icu4c-73 from gnuzilla to icu4c. Date: Tue, 13 Feb 2024 12:34:03 -0800 Message-ID: X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Clément Lassieur , Jonathan Brielmaier , Mark H Weaver Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/icu4c.scm (icu4c-73): New variable. * gnu/packages/gnuzilla.scm (icu4c-73-promise): Delete variable. Change-Id: I017e1416b70ecb94313aeb71aa4a0cafdfe0e9ab --- gnu/packages/gnuzilla.scm | 27 +-------------------------- gnu/packages/icu4c.scm | 22 ++++++++++++++++++++++ gnu/packages/tor-browsers.scm | 3 ++- 3 files changed, 25 insertions(+), 27 deletions(-) diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm index 5f77512427..094ff348e9 100644 --- a/gnu/packages/gnuzilla.scm +++ b/gnu/packages/gnuzilla.scm @@ -375,31 +375,6 @@ (define-public mozjs-78 (list icu4c-69 readline zlib)))) -;; -;; Needed for IceCat 115. -;; -(define icu4c-73-promise - (delay - (package - (inherit icu4c) - (version "73.1") - (source (origin - (method url-fetch) - (uri (string-append - "https://github.com/unicode-org/icu/releases/download/release-" - (string-map (lambda (x) (if (char=? x #\.) #\- x)) version) - "/icu4c-" - (string-map (lambda (x) (if (char=? x #\.) #\_ x)) version) - "-src.tgz")) - (sha256 - (base32 - "0iccpdvc0kvpww5a31k9gjkqigyz016i7v80r9zamd34w4fl6mx4")) - (patches - (cons - (search-patch - "icu4c-fix-TestHebrewCalendarInTemporalLeapYear.patch") - (origin-patches (package-source icu4c))))))))) - ;;; ;;; Localization helper procedures. ;;; @@ -757,7 +732,7 @@ (define-public icecat-minimal ;; https://bugzilla.mozilla.org/show_bug.cgi?id=1819374). ffmpeg-5 libvpx - (force icu4c-73-promise) + icu4c-73 pixman pulseaudio mesa diff --git a/gnu/packages/icu4c.scm b/gnu/packages/icu4c.scm index 5aaf3a8361..0dfe63b20a 100644 --- a/gnu/packages/icu4c.scm +++ b/gnu/packages/icu4c.scm @@ -109,6 +109,28 @@ (define-public icu4c (license x11) (home-page "http://site.icu-project.org/"))) +(define-public icu4c-73 + (package + (inherit icu4c) + (name "icu4c") + (version "73.1") + (source (origin + (method url-fetch) + (uri (string-append + "https://github.com/unicode-org/icu/releases/download/release-" + (string-map (lambda (x) (if (char=? x #\.) #\- x)) version) + "/icu4c-" + (string-map (lambda (x) (if (char=? x #\.) #\_ x)) version) + "-src.tgz")) + (sha256 + (base32 + "0iccpdvc0kvpww5a31k9gjkqigyz016i7v80r9zamd34w4fl6mx4")) + (patches + (cons + (search-patch + "icu4c-fix-TestHebrewCalendarInTemporalLeapYear.patch") + (origin-patches (package-source icu4c)))))))) + (define-public icu4c-70 (package (inherit icu4c) diff --git a/gnu/packages/tor-browsers.scm b/gnu/packages/tor-browsers.scm index c4ce997b99..ee5e072102 100644 --- a/gnu/packages/tor-browsers.scm +++ b/gnu/packages/tor-browsers.scm @@ -52,6 +52,7 @@ (define-module (gnu packages tor-browsers) #:use-module (gnu packages golang) #:use-module (gnu packages gtk) #:use-module (gnu packages hunspell) + #:use-module (gnu packages icu4c) #:use-module (gnu packages image) #:use-module (gnu packages kerberos) #:use-module (gnu packages libcanberra) @@ -270,7 +271,7 @@ (define* (make-torbrowser #:key ;; https://bugzilla.mozilla.org/show_bug.cgi?id=1819374). ffmpeg-5 libvpx - (force (@@ (gnu packages gnuzilla) icu4c-73-promise)) + icu4c-73 pixman pulseaudio mesa -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 13 15:34:46 2024 Received: (at 67512) by debbugs.gnu.org; 13 Feb 2024 20:34:46 +0000 Received: from localhost ([127.0.0.1]:47770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZzUL-0006Ir-Pb for submit@debbugs.gnu.org; Tue, 13 Feb 2024 15:34:46 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:33493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZzUH-0006I0-Qx for 67512@debbugs.gnu.org; Tue, 13 Feb 2024 15:34:43 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 135105C00D6; Tue, 13 Feb 2024 15:34:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 13 Feb 2024 15:34:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1707856459; x=1707942859; bh=OP9vnT2CuYajB32UXMqbGR7aHLCogfh6ACoSI8xsRik=; b= WElaQuMfSzJBHsHlzUl+OPnMW/Q+SFthbFG7QAQ6W7zyrty4GPG2dNiBPOhboccM JslUOzsfXJp7pfx+JJhXt0XEJf2TRwvSiskwFDVlHa6VIm5lXIpEp4bAmpQ/BkSZ +6bEpiPlO9I+fTx4SG892i7YFvOvF1uIt1HBW4KSh8+5BPczbfwckIlemkGqdBWi YhOILM6KEc67rnSc/qAKBtkwObE4rXTWxi6c/YITZtqMAB99T6TY7SEUijEOxeVJ S9JxFXAB/EeoI/zsyPiyYBCvtzuJ9b6dTU2oeB7poFlvOGofiwwhd6zJeESMdKfv M5bd+WEfk9qCQO9FlBDCuA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707856459; x= 1707942859; bh=OP9vnT2CuYajB32UXMqbGR7aHLCogfh6ACoSI8xsRik=; b=K w6bUrladpOO8RbeEO65mOPcCF4Svv+UPcP/as9MRrEGAVyP/Go9LZSTNBtipo/5c WiBcDKoJCmB36IKYQKDkLiKs1hIawrvwAQ7eJhC/cclK2pMtkodPpxjdVztXT2eV n1NeLPdX7deovz0JXskxfJC7zmRsw2e2EN33q3j8FYoOzHc0Il+6X3Xqb4PhKzav BvYKq6Qh4ubXKOGJ2hVsb68TFX6IBIpmIggc/QugMWMTQDojDVsMrFlK9pRNbCOV fVeeGGbZB5tc8C75R+9El7++080m5ULGh63RFTzV5yC2tHgmiAAjTmxEAVRMVwRV RztAUPVUCOdJ/Mzv3whwQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudehgddufeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfgggtgfesth ekredtredtjeenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgv tgdrthhvqeenucggtffrrghtthgvrhhnpeejfeffheeffeeghefhvdekiefggfeigfevhe etffehtdetffefgfduveeuvedtffenucffohhmrghinhepmhhoiihilhhlrgdrohhrghen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnse hrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 13 Feb 2024 15:34:18 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v4 2/4] gnu: nss: Update to 3.97. Date: Tue, 13 Feb 2024 12:34:04 -0800 Message-ID: <134355782c0831601fad01d54581d4bf05742b0b.1707855137.git.ian@retrospec.tv> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/nss.scm (nss): Update to 3.97. * gnu/packages/certs.scm (nss-certs): Update to 3.97. --- gnu/packages/certs.scm | 4 ++-- gnu/packages/nss.scm | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gnu/packages/certs.scm b/gnu/packages/certs.scm index 58b4d50ec8..2a6106df78 100644 --- a/gnu/packages/certs.scm +++ b/gnu/packages/certs.scm @@ -131,7 +131,7 @@ (define-public nss-certs ;; XXX We used to refer to the nss package here, but that eventually caused ;; module cycles. The below is a quick copy-paste job that must be kept in ;; sync manually. Surely there's a better way…? - (version "3.88.1") + (version "3.97") (source (origin (method url-fetch) (uri (let ((version-with-underscores @@ -142,7 +142,7 @@ (define-public nss-certs "nss-" version ".tar.gz"))) (sha256 (base32 - "15il9fsmixa1r4446zq1wl627sg0hz9h67w6kjxz273xz3nl7li7")) + "02pscmkp7flawmgwqzr807nsn6kzzw7r7xjbzfql0bpkjf1zp3h7")) ;; Create nss.pc and nss-config. (patches (search-patches "nss-3.56-pkgconfig.patch" "nss-getcwd-nonnull.patch" diff --git a/gnu/packages/nss.scm b/gnu/packages/nss.scm index 54b9e5041a..268ddaa24f 100644 --- a/gnu/packages/nss.scm +++ b/gnu/packages/nss.scm @@ -106,7 +106,7 @@ (define-public nss ;; IMPORTANT: Also update and test the nss-certs package, which duplicates ;; version and source to avoid a top-level variable reference & module ;; cycle. - (version "3.88.1") + (version "3.97") (source (origin (method url-fetch) (uri (let ((version-with-underscores @@ -117,7 +117,7 @@ (define-public nss "nss-" version ".tar.gz"))) (sha256 (base32 - "15il9fsmixa1r4446zq1wl627sg0hz9h67w6kjxz273xz3nl7li7")) + "02pscmkp7flawmgwqzr807nsn6kzzw7r7xjbzfql0bpkjf1zp3h7")) ;; Create nss.pc and nss-config. (patches (search-patches "nss-3.56-pkgconfig.patch" "nss-getcwd-nonnull.patch" @@ -200,7 +200,7 @@ (define-public nss ;; leading to test failures: ;; . To ;; work around that, set the time to roughly the release date. - (invoke "faketime" "2022-11-01" "./nss/tests/all.sh")) + (invoke "faketime" "2024-01-23" "./nss/tests/all.sh")) (format #t "test suite not run~%")))) (replace 'install (lambda* (#:key outputs #:allow-other-keys) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 13 15:34:47 2024 Received: (at 67512) by debbugs.gnu.org; 13 Feb 2024 20:34:47 +0000 Received: from localhost ([127.0.0.1]:47772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZzUM-0006Iz-C4 for submit@debbugs.gnu.org; Tue, 13 Feb 2024 15:34:47 -0500 Received: from fout8-smtp.messagingengine.com ([103.168.172.151]:51103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZzUJ-0006I2-2A for 67512@debbugs.gnu.org; Tue, 13 Feb 2024 15:34:44 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.nyi.internal (Postfix) with ESMTP id 4B4DF13800EF; Tue, 13 Feb 2024 15:34:20 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 13 Feb 2024 15:34:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1707856460; x=1707942860; bh=MNK98XLfq6CqwXiea4qFO0rELVUQ9vopcBmO9epUh8E=; b= BpU8jDNU3y+VvqP37naam+m1mKvUp78+BgCKVAmCqcJBFgbtEJNDbB94vk1anBFe dqcICHI0l2zdkXR2Gg9xIQ9lPBN2pzDC0VAV4kI/yjNbfMkkUjkehyUveClaBWOG 6JHZqpDhqcddTyx/omDds7asAqH7/H5o9mhFoWlLkiWh1F75fx9Rul7btFI5xgKj zZz7/PdzJObHypfQl+1mK43+5gmrdITmx6rTGClIqUkeNXyXyyMFWU0SvWeHPCl2 YiE4vV4CS9sgwX9c9QmuiHRV1fsT6VMHuNGhBHzN7ftwbZtUomX7nyNZPyJX6M0R sxXBQw6yPUHOlmP9vqWAuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707856460; x= 1707942860; bh=MNK98XLfq6CqwXiea4qFO0rELVUQ9vopcBmO9epUh8E=; b=B JENxs7s7EjAtHrmveSKEWq+Y+zP/p6/BQCM2h2zQlnEWFgFrS/El0DGmQHFrmPqS hU4nfjxzMVgrMvOCJguRZRHTxF2CM6UeFAvocgYOaffQGaaJJg9KXksF2eQmbxsd l/zDMe3ntHcZP1KxhjCnfepK3dQX4BtLoCn2alSTrS81GHh/uUtI036W+43JCGzZ KL47jLueetNrj1Jxhe5zZCl7QOwPx5t0ov4GXKruKJPA75r24C4FHOcuXdCHJoev bNgJHKA93yKJ9D2LC2x3GhTU+v6RT+6MFVPf7iHEvX8sFbfVwBhBM6r5ZRzzRhOS 73wJEne2UHqDridA1DFsA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudehgddufeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfgggtgfesth ekredtredtjeenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgv tgdrthhvqeenucggtffrrghtthgvrhhnpedujefffeduleeuvdehueehtdevgfekgfetve egleejleefjefhtdevheevtdekfeenucffohhmrghinhepghhnuhdrohhrghdpghhithhh uhgsrdgtohhmpdhmohiiihhllhgrrdhorhhgpdifrghsihdruggvvhdplhhlvhhmrdhorh hgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihgr nhesrhgvthhrohhsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 13 Feb 2024 15:34:19 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v4 3/4] gnu: Add wasm packages. Date: Tue, 13 Feb 2024 12:34:05 -0800 Message-ID: <39662eaab8ebb73981be67f42a0277c2013be76b.1707855137.git.ian@retrospec.tv> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) * gnu/packages/wasm.scm (wasi-libc): New variable. * gnu/packages/wasm.scm (wasm32-wasi-clang-runtime): New variable. * gnu/packages/wasm.scm (wasm32-wasi-clang): New variable. * gnu/packages/wasm.scm (wasm32-wasi-libcxx): New variable. * gnu/packages/wasm.scm (wasm32-wasi-clang-toolchain): New variable. --- gnu/packages/wasm.scm | 273 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 273 insertions(+) create mode 100644 gnu/packages/wasm.scm diff --git a/gnu/packages/wasm.scm b/gnu/packages/wasm.scm new file mode 100644 index 0000000000..05d247f333 --- /dev/null +++ b/gnu/packages/wasm.scm @@ -0,0 +1,273 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2022-2023 Pierre Langlois +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + +(define-module (gnu packages wasm) + #:use-module (guix base32) + #:use-module (guix gexp) + #:use-module (guix packages) + #:use-module ((guix licenses) #:prefix license:) + #:use-module (guix utils) + #:use-module (guix git-download) + #:use-module (guix build-system cmake) + #:use-module (guix build-system gnu) + #:use-module (guix build-system trivial) + #:use-module (gnu packages bash) + #:use-module (gnu packages llvm) + #:use-module (gnu packages python)) + +(define-public wasi-libc + (package + (name "wasi-libc") + (version "sdk-19") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/WebAssembly/wasi-libc") + (commit (string-append "wasi-" version)) + (recursive? #t))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0bnpz8wk9wiic938296gxp4vz820bvpi1w41jksjzz5552hql169")))) + (build-system gnu-build-system) + (native-inputs (list clang-15)) + (arguments + (list + #:tests? #f ;No test suite + ;; Firefox uses wasm2c to compile WebAssembly to C code, and it + ;; does not support the memory.copy opcode. + ;; See https://bugzilla.mozilla.org/show_bug.cgi?id=1773200#c4 + #:make-flags ''("BULK_MEMORY_SOURCES=") + #:phases #~(modify-phases %standard-phases + (delete 'configure) + (add-before 'build 'set-sysroot-include + (lambda _ + (setenv "C_INCLUDE_PATH" + (string-append (getcwd) "/sysroot/include")))) + (add-before 'install 'set-install-dir + (lambda _ + (setenv "INSTALL_DIR" + (string-append #$output "/wasm32-wasi"))))))) + (home-page "https://wasi.dev") + (synopsis "WASI libc implementation for WebAssembly") + (description + "WASI Libc is a libc for WebAssembly programs built on top of WASI +system calls. It provides a wide array of POSIX-compatible C APIs, including +support for standard I/O, file I/O, filesystem manipulation, memory +management, time, string, environment variables, program startup, and many +other APIs.") + (license (list + ;; For wasi-libc, with LLVM exceptions + license:asl2.0 + ;; For malloc.c. + license:cc0 + ;; For cloudlibc. + license:bsd-2 + ;; For wasi-libc and musl-libc. + license:expat)))) + +(define-public wasm32-wasi-clang-runtime + (package (inherit clang-runtime-15) + (native-inputs + (list clang-15 + wasi-libc)) + (inputs (list llvm-15)) + (arguments + (list + #:build-type "Release" + #:tests? #f + ;; Stripping binaries breaks wasm linking, resulting in the following + ;; error: "archive has no index; run ranlib to add one". + #:strip-binaries? #f + #:configure-flags + #~(list "-DCMAKE_C_COMPILER=clang" + "-DCMAKE_C_COMPILER_TARGET=wasm32-wasi" + (string-append + "-DCMAKE_SYSROOT=" #$wasi-libc "/wasm32-wasi") + (string-append + "-DCMAKE_C_FLAGS=-I " #$wasi-libc "/wasm32-wasi/include") + + "-DCOMPILER_RT_OS_DIR=wasi" + + "-DCOMPILER_RT_BAREMETAL_BUILD=On" + "-DCOMPILER_RT_DEFAULT_TARGET_ONLY=On" + + ;; WASM only needs libclang_rt.builtins-wasm32.a from + ;; compiler-rt. + "../source/compiler-rt/lib/builtins"))))) + +;; FIXME: Ideally we wouldn't need to build a separate compiler because clang +;; can support multiple targets at runtime. However Guix patches the default +;; clang with a specific clang-runtime package. It would be good to improve +;; upstream Guix's support for cross-compiling with clang. + +(define clang-from-llvm (@@ (gnu packages llvm) clang-from-llvm)) +(define llvm-monorepo (@@ (gnu packages llvm) llvm-monorepo)) + +(define-public wasm32-wasi-clang + (let ((base (clang-from-llvm llvm-15 wasm32-wasi-clang-runtime))) + (package + (inherit base) + (name "wasm32-wasi-clang") + (inputs (modify-inputs (package-inputs base) + (prepend wasi-libc))) + (arguments + (substitute-keyword-arguments (package-arguments base) + ((#:configure-flags flags) + #~(list "-DCLANG_INCLUDE_TESTS=True" + ;; Use a sane default include directory. + (string-append "-DC_INCLUDE_DIRS=" + #$wasi-libc "/wasm32-wasi/include"))) + ((#:phases phases) + `(modify-phases ,phases + (delete 'symlink-cfi_ignorelist)))))))) + +(define-public wasm32-wasi-libcxx + (package + (name "wasm32-wasi-libcxx") + (version (package-version llvm-15)) + (source + (llvm-monorepo version)) + (build-system cmake-build-system) + (arguments + (list + #:configure-flags #~(list (string-append "-S ../source/runtimes") + + "-DLLVM_ENABLE_RUNTIMES=libcxx;libcxxabi" + + (string-append "-DCMAKE_SYSROOT=" + #$wasi-libc "/wasm32-wasi") + + (string-append "-DCMAKE_INCLUDE_PATH=" + #$wasi-libc + "/wasm32-wasi/include") + + (string-append "-DCMAKE_STAGING_PREFIX=" + #$output "/wasm32-wasi") + + "-DCMAKE_C_COMPILER=clang" + "-DCMAKE_C_COMPILER_WORKS=ON" + "-DCMAKE_CXX_COMPILER=clang++" + "-DCMAKE_CXX_COMPILER_WORKS=ON" + "-DCMAKE_C_COMPILER_TARGET=wasm32-wasi" + "-DCMAKE_CXX_COMPILER_TARGET=wasm32-wasi" + + "-DLIBCXX_LIBDIR_SUFFIX=/wasm32-wasi" + + "-DLIBCXX_ENABLE_EXCEPTIONS=OFF" + "-DLIBCXX_ENABLE_SHARED=OFF" + "-DLIBCXX_ENABLE_THREADS=OFF" + "-DLIBCXX_ENABLE_FILESYSTEM=OFF" + + "-DLIBCXXABI_LIBDIR_SUFFIX=/wasm32-wasi" + + "-DLIBCXXABI_ENABLE_EXCEPTIONS=OFF" + "-DLIBCXXABI_ENABLE_SHARED=OFF" + "-DLIBCXXABI_ENABLE_THREADS=OFF" + "-DLIBCXXABI_ENABLE_FILESYSTEM=OFF") + #:tests? #f + #:phases #~(modify-phases %standard-phases + (add-after 'set-paths 'adjust-CPLUS_INCLUDE_PATH + (lambda _ + (setenv "CPLUS_INCLUDE_PATH" + (string-append #$wasi-libc + "/wasm32-wasi/include:" + (getenv "CPLUS_INCLUDE_PATH")))))))) + (native-inputs (list lld python wasm32-wasi-clang)) + (inputs (list wasi-libc)) + (home-page "https://libcxx.llvm.org") + (synopsis "C++ standard library for WebAssembly") + (description + "This package provides an implementation of the C++ standard library for +use with Clang, targeting C++11, C++14 and above. This package targets +WebAssembly with WASI.") + (license license:expat))) + +(define-public wasm32-wasi-clang-toolchain + (package + (name "wasm32-wasi-clang-toolchain") + (version (package-version wasm32-wasi-clang)) + (source + #f) + (build-system trivial-build-system) + (arguments + (list + #:builder (with-imported-modules '((guix build union) + (guix build utils)) + #~(begin + (use-modules (guix build union) + (guix build utils)) + (union-build #$output + (list #$wasm32-wasi-clang-runtime + #$wasi-libc + #$wasm32-wasi-libcxx)) + (mkdir-p (string-append #$output + "/bin")) + + ;; We provide clang and clang++ via a wrapped program that sets + ;; include paths correctly so that it does not include paths from + ;; the host. + + ;; FIXME: Review how we can provide better support for + ;; cross-compiling with clang in Guix, maybe adding support for + ;; the CROSS_C_INCLUDE_PATH and CROSS_CPLUS_INCLUDE_PATH + ;; environment variables like GCC. + + (for-each (lambda (bin) + (symlink (string-append #$wasm32-wasi-clang + bin) + (string-append #$output + bin)) + (wrap-program (string-append #$output + bin) + #:sh (string-append #$bash-minimal + "/bin/bash") + `("C_INCLUDE_PATH" + ":" = + (,(string-append #$output + "/wasm32-wasi/include"))) + `("CPLUS_INCLUDE_PATH" + ":" = + ;; Make sure inclure/c++/v1 comes first for #include_next + ;; to work. + (,(string-append #$output + "/wasm32-wasi/include/c++/v1") , + (string-append #$output + "/wasm32-wasi/include"))))) + '("/bin/clang" + "/bin/clang++")) + + (symlink (string-append #$lld + "/bin/wasm-ld") + (string-append #$output + "/bin/wasm-ld")))))) + (inputs (list bash-minimal + lld + wasi-libc + wasm32-wasi-clang + wasm32-wasi-clang-runtime + wasm32-wasi-libcxx)) + (license (cons (package-license wasm32-wasi-clang) + (package-license wasi-libc))) + (home-page "https://clang.llvm.org") + (synopsis + "Complete Clang toolchain for C/C++ development, for WebAssembly.") + (description + "This package provides a complete Clang toolchain for C/C++ +development targeting WebAssembly with WASI. This includes Clang, as well as +libc, libc++ and wasm-ld."))) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 13 15:34:53 2024 Received: (at 67512) by debbugs.gnu.org; 13 Feb 2024 20:34:53 +0000 Received: from localhost ([127.0.0.1]:47774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZzUR-0006JL-Ew for submit@debbugs.gnu.org; Tue, 13 Feb 2024 15:34:53 -0500 Received: from fhigh2-smtp.messagingengine.com ([103.168.172.153]:48839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZzUK-0006I9-Eg for 67512@debbugs.gnu.org; Tue, 13 Feb 2024 15:34:47 -0500 Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 9DBA81140099; Tue, 13 Feb 2024 15:34:21 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 13 Feb 2024 15:34:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1707856461; x=1707942861; bh=9YPTzWgv+pFEHYCgMYaflzwV9NQCTOyDiF/A4DrWKYM=; b= igbYqpmYca8SkJS0/Um1wGUwwnPq7Gm6gP/sinZEDRdmft9OPwfBvF14TA/8uOLN bwo9CjVcfl2lBrVGNqGuFJM7Kbm5VrEb63yNFGZPW/ffbt+R1tEgMwwXp5KIA0/3 +9AW5FcIlG6n8/SZmEUw62UeEfUGj9tqIgzknsQPctzsuhAZnylJHI4F64WUfmZU uZXDc9dN5c91owE2XTsQmMDOCWX9JoktKDQWudOQIIKDGkTcyx8pcp7hgAGDLYbQ xy0NNU+phh1MyEmykqv4MMKV4pIYwz6cIuoj9yEIalFOrZxSwZqRG6YgIajb/att f2d8zVsUevdkK+e0ogyhNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707856461; x= 1707942861; bh=9YPTzWgv+pFEHYCgMYaflzwV9NQCTOyDiF/A4DrWKYM=; b=i PoagF95+FvzDpD1arSBH2ByXQfLkXFd2+X49Mzqw6S3x8RTuq+ODcrWUAY1Sx+Vk 2EVS5nlftwWHwjCdRBTpIs9ZOGvLjDibz4r9zmpHSja0BMVhy6vHtiW0toeSpi22 pUbnB/qHoDBp+Y+wjQENshUY4KcRNt+7WTK+y/O/HXHIQ+iVQQU/0DcNCuDFslvj Egwojd6xMwmzQaAB46q49CwAntduGG+rJrVhfiB7cSMMCwDNU/UVKyzPUcgSsGPz iDmtxLuZlgzYMp/6egCnZD+duu5ysUfswogao2gNllHQcjStrxqiAce8BtVfNc19 avwKs2LmEZSNSKR/MG0Gw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudehgddufeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfgggtgfesth ekredtredtjeenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgv tgdrthhvqeenucggtffrrghtthgvrhhnpeekveffleelheetffekteefvddtveegteeife etgfduleetjeelteefueekffetheenucffohhmrghinhepghhnuhdrohhrghdpshgvrghr tghhfhhogidrohhrghdpghhithhlrggsrdgtohhmpdgtohhnthgvnhhtrdhrvggrugdpmh hoiihilhhlrgdrohhrghdpghgvthgrugguohhnshdrshgvrghrtghhpdhgvghtrgguugho nhhsrdhlihhnkhdpghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepihgrnhesrhgvthhrohhsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 13 Feb 2024 15:34:20 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v4 4/4] gnu: Add librewolf. Date: Tue, 13 Feb 2024 12:34:06 -0800 Message-ID: <96c848a2d5ce1f456187ea47a3151a21079b333a.1707855137.git.ian@retrospec.tv> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/librewolf.scm (librewolf): New variable. Change-Id: I98b6410582b856ede83b79637a58e66d6e5832e6 --- gnu/packages/librewolf.scm | 642 +++++++++++++++++++++++++++++++++++++ 1 file changed, 642 insertions(+) create mode 100644 gnu/packages/librewolf.scm diff --git a/gnu/packages/librewolf.scm b/gnu/packages/librewolf.scm new file mode 100644 index 0000000000..6aa84ee372 --- /dev/null +++ b/gnu/packages/librewolf.scm @@ -0,0 +1,642 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2013, 2015, 2024 Andreas Enge +;;; Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019 Ludovic Courtès +;;; Copyright © 2014, 2015, 2016, 2017, 2018, 2019, 2020, 2021 Mark H Weaver +;;; Copyright © 2015 Sou Bunnbu +;;; Copyright © 2016, 2017, 2018, 2019 Efraim Flashner +;;; Copyright © 2016 Alex Griffin +;;; Copyright © 2017 Clément Lassieur +;;; Copyright © 2017, 2018 Nikita +;;; Copyright © 2017, 2018 ng0 +;;; Copyright © 2017, 2018, 2020 Tobias Geerinckx-Rice +;;; Copyright © 2018, 2020, 2022 Ricardo Wurmus +;;; Copyright © 2019 Ivan Petkov +;;; Copyright © 2020 Oleg Pykhalov +;;; Copyright © 2020 Jakub Kądziołka +;;; Copyright © 2019, 2020 Adrian Malacoda +;;; Copyright © 2020-2023 Jonathan Brielmaier +;;; Copyright © 2020 Zhu Zihao +;;; Copyright © 2021 pineapples +;;; Copyright © 2021 Brice Waegeneire +;;; Copyright © 2021, 2022, 2023 John Kehayias +;;; Copyright © 2022 Pierre Langlois +;;; Copyright © 2023 Tomas Volf +;;; Copyright © 2023 Ian Eure +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + + +(define-module (gnu packages librewolf) + #:use-module (guix build-system gnu) + #:use-module (guix build-system cargo) + #:use-module (guix build-system trivial) + #:use-module (guix download) + #:use-module ((guix licenses) #:prefix license:) + #:use-module (guix gexp) + #:use-module (guix packages) + #:use-module (guix utils) + #:use-module ((guix build utils) #:select (alist-replace)) + + #:use-module (gnu packages) + #:use-module (gnu packages assembly) + #:use-module (gnu packages autotools) + #:use-module (gnu packages base) + #:use-module (gnu packages bash) + #:use-module (gnu packages compression) + #:use-module (gnu packages crates-io) + #:use-module (gnu packages cups) + #:use-module (gnu packages fontutils) + #:use-module (gnu packages gl) + #:use-module (gnu packages glib) + #:use-module (gnu packages gnome) + #:use-module (gnu packages gtk) + #:use-module (gnu packages hunspell) + #:use-module (gnu packages icu4c) + #:use-module (gnu packages image) + #:use-module (gnu packages jemalloc) + #:use-module (gnu packages kerberos) + #:use-module (gnu packages libcanberra) + #:use-module (gnu packages libevent) + #:use-module (gnu packages libffi) + #:use-module (gnu packages linux) + #:use-module (gnu packages llvm) + #:use-module (gnu packages m4) + #:use-module (gnu packages node) + #:use-module (gnu packages nss) + #:use-module (gnu packages pciutils) + #:use-module (gnu packages perl) + #:use-module (gnu packages pkg-config) + #:use-module (gnu packages pulseaudio) + #:use-module (gnu packages python) + #:use-module (gnu packages rust) + #:use-module (gnu packages rust-apps) + #:use-module (gnu packages speech) + #:use-module (gnu packages sqlite) + #:use-module (gnu packages video) + #:use-module (gnu packages wasm) + #:use-module (gnu packages xdisorg) + #:use-module (gnu packages xorg)) + +;; Define the versions of rust needed to build firefox, trying to match +;; upstream. See the file taskcluster/ci/toolchain/rust.yml at +;; https://searchfox.org under the particular firefox release, like +;; mozilla-esr102. +(define rust-librewolf rust) ; 1.60 is the default in Guix, 1.65 is the minimum. + +;; Update this id with every firefox update to its release date. +;; It's used for cache validation and therefore can lead to strange bugs. +(define %librewolf-build-id "20240130195200") + +(define-public librewolf + (package + (name "librewolf") + (version "122.0-2") + (source + (origin + (method url-fetch) + + (uri (string-append "https://gitlab.com/api/v4/projects/32320088/" + "packages/generic/librewolf-source/" + version + "/librewolf-" + version + ".source.tar.gz")) + (sha256 + (base32 "0ggysgbazx5dl0l9dyvrpjgzbvivgddm9qyiyvjjfk9im9sljkxh")))) + (build-system gnu-build-system) + (arguments + (list + #:configure-flags #~(let ((clang #$(this-package-native-input "clang")) + (wasi-sysroot #$(this-package-native-input + "wasm32-wasi-clang-toolchain"))) + `("--enable-application=browser" + + ;; Configuration + "--with-system-jpeg" + "--with-system-zlib" + "--with-system-png" + "--with-system-webp" + "--with-system-icu" + "--with-system-libvpx" + "--with-system-libevent" + "--with-system-ffi" + "--enable-system-pixman" + "--enable-jemalloc" + + ;; see https://bugs.gnu.org/32833 + "--with-system-nspr" + "--with-system-nss" + + ,(string-append "--with-clang-path=" clang + "/bin/clang") + ,(string-append "--with-libclang-path=" clang + "/lib") + ,(string-append "--with-wasi-sysroot=" + wasi-sysroot "/wasm32-wasi") + + ;; Distribution + "--with-distribution-id=org.guix" + "--with-app-name=librewolf" + "--with-app-basename=LibreWolf" + "--with-branding=browser/branding/librewolf" + + ;; Features + "--disable-tests" + "--disable-updater" + "--enable-pulseaudio" + "--disable-crashreporter" + "--allow-addon-sideload" + "--with-unsigned-addon-scopes=app,system" + "--disable-eme" + + ;; Build details + "--disable-debug" + "--enable-rust-simd" + "--enable-release" + "--enable-optimize" + "--enable-strip" + "--enable-hardening" + "--disable-elf-hack")) + #:imported-modules %cargo-utils-modules + #:modules `((ice-9 regex) + (ice-9 string-fun) + (ice-9 ftw) + (srfi srfi-1) + (srfi srfi-26) + (rnrs bytevectors) + (rnrs io ports) + (guix elf) + (guix build gremlin) + ,@%gnu-build-system-modules) + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'fix-preferences + (lambda* (#:key inputs #:allow-other-keys) + (let ((port (open-file "browser/app/profile/firefox.js" + "a"))) + (define (write-setting key value) + (format port "~%pref(\"~a\", ~a);~%" key value) + (format #t + "fix-preferences: setting value of ~a to ~a~%" key + value)) + + ;; We should allow Firefox sandbox to read the store directory, + ;; because Firefox sandbox have access to /usr on FHS distros. + (write-setting + "security.sandbox.content.read_path_whitelist" + (string-append "\"" + (%store-directory) "/\"")) + + ;; XDG settings should be managed by Guix. + (write-setting "browser.shell.checkDefaultBrowser" + "false") + (close-port port)))) + (add-after 'fix-preferences 'fix-ffmpeg-runtime-linker + (lambda* (#:key inputs #:allow-other-keys) + (let* ((ffmpeg (assoc-ref inputs "ffmpeg")) + (libavcodec (string-append ffmpeg + "/lib/libavcodec.so"))) + ;; Arrange to load libavcodec.so by its absolute file name. + (substitute* "dom/media/platforms/ffmpeg/FFmpegRuntimeLinker.cpp" + (("libavcodec\\.so") + libavcodec))))) + (add-after 'patch-source-shebangs 'patch-cargo-checksums + (lambda _ + (use-modules (guix build cargo-utils)) + (let ((null-hash + ;; This is the SHA256 output of an empty string. + (string-append + "e3b0c44298fc1c149afbf4c8996fb924" + "27ae41e4649b934ca495991b7852b855"))) + (for-each (lambda (file) + (format #t + "patch-cargo-checksums: patching checksums in ~a~%" + file) + (substitute* file + (("(checksum = )\".*\"" all name) + (string-append name "\"" null-hash + "\"")))) + (find-files "." "Cargo\\.lock$")) + (for-each generate-all-checksums + '("build" "dom/media" + "dom/webauthn" + "gfx" + "intl" + "js" + "media" + "modules" + "mozglue/static/rust" + "netwerk" + "remote" + "security/manager/ssl" + "servo" + "storage" + "third_party/rust" + "toolkit" + "xpcom/rust" + "services"))))) + (add-after 'patch-cargo-checksums 'remove-cargo-frozen-flag + (lambda _ + ;; Remove --frozen flag from cargo invokation, otherwise it'll + ;; complain that it's not able to change Cargo.lock. + ;; https://bugzilla.mozilla.org/show_bug.cgi?id=1726373 + (substitute* "build/RunCbindgen.py" + (("\"--frozen\",") + "")))) + (delete 'bootstrap) + (add-before 'configure 'patch-SpeechDispatcherService.cpp + (lambda _ + (let* ((lib "libspeechd.so.2") + (file (string-append + "dom/media/webspeech/synth/" + "speechd/SpeechDispatcherService.cpp")) + (old-content (call-with-input-file file + get-string-all))) + (substitute file + `((,(format #f "~s" lib) unquote + (λ (line _) + (string-replace-substring line lib + (string-append #$speech-dispatcher + "/lib/" + lib)))))) + (if (string=? old-content + (call-with-input-file file + get-string-all)) + (error + "substitute did nothing, phase requires an update"))))) + (add-before 'configure 'set-build-id + ;; Firefox will write the timestamp to output, which is harmful + ;; for reproducibility, so change it to a fixed date. Use a + ;; separate phase for easier modification with inherit. + (lambda _ + (setenv "MOZ_BUILD_DATE" + #$%librewolf-build-id))) + (replace 'configure + (lambda* (#:key inputs outputs configure-flags + #:allow-other-keys) + (setenv "AUTOCONF" + (string-append (assoc-ref inputs "autoconf") + "/bin/autoconf")) + (setenv "SHELL" + (which "bash")) + (setenv "CONFIG_SHELL" + (which "bash")) + (setenv "MACH_BUILD_PYTHON_NATIVE_PACKAGE_SOURCE" + "system") + ;; This should use the host info probably (does firefox build on + ;; non-x86_64 though?) + (setenv "GUIX_PYTHONPATH" + (string-append (getcwd) + "/obj-x86_64-pc-linux-gnu/_virtualenvs/build")) + + ;; Use Clang, Clang is 2x faster than GCC + (setenv "AR" "llvm-ar") + (setenv "NM" "llvm-nm") + (setenv "CC" "clang") + (setenv "CXX" "clang++") + (setenv "WASM_CC" + (string-append (assoc-ref inputs + "wasm32-wasi-clang-toolchain") + "/bin/clang")) + (setenv "WASM_CXX" + (string-append (assoc-ref inputs + "wasm32-wasi-clang-toolchain") + "/bin/clang++")) + + (setenv "MOZ_NOSPAM" "1") + (setenv "MOZ_APP_NAME" "librewolf") + + (setenv "MOZBUILD_STATE_PATH" + (getcwd)) + + (let* ((mozconfig (string-append (getcwd) "/mozconfig")) + (out (assoc-ref outputs "out")) + (flags (cons (string-append "--prefix=" out) + configure-flags))) + (format #t "build directory: ~s~%" + (getcwd)) + (format #t "configure flags: ~s~%" flags) + + (define write-flags + (lambda flags + (display (string-join (map (cut string-append + "ac_add_options " <>) + flags) "\n")) + (display "\n"))) + (with-output-to-file mozconfig + (lambda () + (apply write-flags flags) + ;; The following option unsets Telemetry + ;; Reporting. With the Addons Fiasco, + ;; Mozilla was found to be collecting + ;; user's data, including saved passwords + ;; and web form data, without users + ;; consent. Mozilla was also found + ;; shipping updates to systems without + ;; the user's knowledge or permission. + ;; As a result of this, use the following + ;; command to permanently disable + ;; telemetry reporting in Firefox. + (display "unset MOZ_TELEMETRY_REPORTING\n") + (display "mk_add_options MOZ_CRASHREPORTER=0\n") + (display "mk_add_options MOZ_DATA_REPORTING=0\n") + (display + "mk_add_options MOZ_SERVICES_HEALTHREPORT=0") + (display + "mk_add_options MOZ_TELEMETRY_REPORTING=0"))) + (setenv "MOZCONFIG" mozconfig)) + (invoke "./mach" "configure"))) + (add-before 'build '1fix-addons-placeholder + (lambda _ + (substitute* + "toolkit/locales/en-US/toolkit/about/aboutAddons.ftl" + (("addons.mozilla.org") "gnuzilla.gnu.org")))) + (replace 'build + (lambda* (#:key (make-flags '()) + (parallel-build? #t) #:allow-other-keys) + (apply invoke "./mach" "build" + ;; mach will use parallel build if possible by default + `(,@(if parallel-build? + '() + '("-j1")) ,@make-flags)))) + (add-after 'build 'neutralise-store-references + (lambda _ + ;; Mangle the store references to compilers & + ;; other build tools in about:buildconfig, + ;; reducing Firefox's closure by 1 GiB on + ;; x86-64. + (let* ((build-dir (car (scandir "." + (cut string-prefix? + "obj-" <>)))) + (file (string-append build-dir + "/dist/bin/chrome/toolkit/" + "content/global/buildconfig.html"))) + (substitute* file + (((format #f "(~a/)([0-9a-df-np-sv-z]{32})" + (regexp-quote (%store-directory))) + _ store hash) + (string-append store + (string-take hash 8) + "" + (string-drop hash 8))))))) + (replace 'install + (lambda _ + (invoke "./mach" "install"))) + (add-after 'install 'remove-duplicate-bin + (lambda* (#:key outputs #:allow-other-keys) + (delete-file (string-append #$output + "/lib/librewolf/librewolf-bin")))) + (add-after 'install 'wrap-glxtest + ;; glxtest uses dlopen() to load mesa + ;; libs, wrap it to set LD_LIBRARY_PATH. + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (lib (string-append out "/lib")) + ;; TODO: make me a loop again + (mesa-lib (string-append (assoc-ref inputs + "mesa") + "/lib")) + (pciutils-lib (string-append (assoc-ref inputs + "pciutils") "/lib"))) + (wrap-program (car (find-files lib "^glxtest$")) + `("LD_LIBRARY_PATH" prefix + (,mesa-lib ,pciutils-lib)))))) + (add-after 'install 'patch-config + (lambda* (#:key inputs #:allow-other-keys) + (let ((lib (string-append #$output "/lib/librewolf")) + (config-file "librewolf.cfg")) + + ;; Required for Guix packaged extensions + ;; SCOPE_PROFILE=1, SCOPE_APPLICATION=4, SCOPE_SYSTEM=8 + ;; Default is 5. + (substitute* (in-vicinity lib config-file) + (("defaultPref\\(\"extensions.enabledScopes\", 5\\)") + "defaultPref(\"extensions.enabledScopes\", 13)")) + ;; Use Mozzarella addons repo. + (call-with-port + (open-file (in-vicinity lib config-file) "a") + (lambda (port) + ;; Add-ons panel (see settings.js in Icecat source). + (for-each + (lambda (pref) + (format port "defaultPref(~s, ~s);~%" + (car pref) (cdr pref))) + '(("extensions.getAddons.search.browseURL" . + "https://gnuzilla.gnu.org/mozzarella/search.php?q=%TERMS%") + ("extensions.getAddons.get.url" . + "https://gnuzilla.gnu.org/mozzarella") + ("extensions.getAddons.link.url" . + "https://gnuzilla.gnu.org/mozzarella") + ("extensions.getAddons.discovery.api_url" . + "https://gnuzilla.gnu.org/mozzarella") + ("extensions.getAddons.langpacks.url" . + "https://gnuzilla.gnu.org/mozzarella") + ("lightweightThemes.getMoreURL" . + "https://gnuzilla.gnu.org/mozzarella")))))))) + (add-after 'install 'wrap-program + (lambda* (#:key inputs outputs #:allow-other-keys) + ;; The following two functions are from Guix's icecat package in + ;; (gnu packages gnuzilla). See commit + ;; b7a0935420ee630a29b7e5ac73a32ba1eb24f00b. + (define (runpath-of lib) + (call-with-input-file lib + (compose elf-dynamic-info-runpath elf-dynamic-info + parse-elf get-bytevector-all))) + (define (runpaths-of-input label) + (let* ((dir (string-append (assoc-ref inputs label) + "/lib")) + (libs (find-files dir "\\.so$"))) + (append-map runpath-of libs))) + (let* ((out (assoc-ref outputs "out")) + (lib (string-append out "/lib")) + ;; TODO: make me a loop again + (mesa-lib (string-append (assoc-ref inputs + "mesa") + "/lib")) + (apng-lib (string-append (assoc-ref inputs + "libpng-apng") "/lib")) + ;; For the integration of native notifications + (libnotify-lib (string-append (assoc-ref inputs + "libnotify") + "/lib")) + ;; For hardware video acceleration via VA-API + (libva-lib (string-append (assoc-ref inputs + "libva") + "/lib")) + ;; VA-API is run in the RDD (Remote Data Decoder) sandbox + ;; and must be explicitly given access to files it needs. + ;; Rather than adding the whole store (as Nix had + ;; upstream do, see + ;; and + ;; linked upstream patches), we can just follow the + ;; runpaths of the needed libraries to add everything to + ;; LD_LIBRARY_PATH. These will then be accessible in the + ;; RDD sandbox. + (rdd-whitelist (map (cut string-append <> "/") + (delete-duplicates (append-map + runpaths-of-input + '("mesa" + "ffmpeg"))))) + (pulseaudio-lib (string-append (assoc-ref inputs + "pulseaudio") + "/lib")) + ;; For U2F and WebAuthn + (eudev-lib (string-append (assoc-ref inputs + "eudev") + "/lib")) + (gtk-share (string-append (assoc-ref inputs + "gtk+") + "/share"))) + (wrap-program (car (find-files lib "^librewolf$")) + `("LD_LIBRARY_PATH" prefix + (,mesa-lib ,libnotify-lib + ,libva-lib + ,pulseaudio-lib + ,eudev-lib + ,apng-lib + ,@rdd-whitelist)) + `("XDG_DATA_DIRS" prefix + (,gtk-share)) + `("MOZ_LEGACY_PROFILES" = + ("1")) + `("MOZ_ALLOW_DOWNGRADE" = + ("1")))))) + (add-after 'wrap-program 'install-desktop-entry + (lambda* (#:key outputs #:allow-other-keys) + (let* ((desktop-file + "taskcluster/docker/firefox-snap/firefox.desktop") + (applications (string-append #$output + "/share/applications"))) + (substitute* desktop-file + (("^Exec=firefox") + (string-append "Exec=" + #$output "/bin/librewolf")) + ;; "Firefox" -> "LibreWolf" everywhere + (("Firefox") + "LibreWolf") + ;; Remove non-Latin translations. + (("^Name\\[(ar|bn)\\].*$") + "") + (("^Icon=.*") + (string-append "Icon=" + #$output + "/share/icons/hicolor/128x128/apps/librewolf.png +")) + ;; These commands were changed. + (("-NewWindow") + "-new-window") + (("-NewPrivateWindow") + "-new-private-window") + (("StartupNotify=true") + "StartupNotify=true +StartupWMClass=Navigator")) + (copy-file desktop-file "librewolf.desktop") + (install-file "librewolf.desktop" applications)))) + (add-after 'install-desktop-entry 'install-icons + (lambda* (#:key outputs #:allow-other-keys) + (let ((icon-source-dir (string-append #$output + "/lib/librewolf/browser/" + "chrome/icons/default"))) + (for-each (lambda (size) + (let ((dest (string-append #$output + "/share/icons/hicolor/" + size + "x" + size + "/apps"))) + (mkdir-p dest) + (symlink (string-append icon-source-dir + "/default" size ".png") + (string-append dest + "/librewolf.png")))) + '("16" "32" "48" "64" "128")))))) + + ;; Test will significantly increase build time but with little rewards. + #:tests? #f + + ;; WARNING: Parallel build will consume lots of memory! + ;; If you have encountered OOM issue in build phase, try disable it. + #:parallel-build? #t + + ;; Some dynamic lib was determined at runtime, so rpath check may fail. + #:validate-runpath? #f)) + (inputs (list bash-minimal + bzip2 + cairo + cups + dbus-glib + freetype + ffmpeg + gdk-pixbuf + glib + gtk+ + gtk+-2 + hunspell + icu4c-73 + jemalloc + libcanberra + libevent + libffi + libgnome + libjpeg-turbo + libnotify + libpng-apng + libva + libvpx + libwebp + libxcomposite + libxft + libxinerama + libxscrnsaver + libxt + mesa + mit-krb5 + nspr + nss + pango + pciutils + pipewire + pixman + pulseaudio + speech-dispatcher + sqlite + startup-notification + eudev + unzip + zip + zlib)) + (native-inputs (list alsa-lib + autoconf-2.13 + `(,rust-librewolf "cargo") + clang + llvm + wasm32-wasi-clang-toolchain + m4 + nasm + node-lts + perl + pkg-config + python + rust-librewolf + rust-cbindgen-0.26 + which + yasm)) + (home-page "https://mozilla.org/firefox/") + (synopsis "Trademarkless version of Firefox") + (description + "Full-featured browser client built from Firefox source tree, without +the official icon and the name \"firefox\". This is the Extended Support +Release (ESR) version.") + (license license:mpl2.0))) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 13 17:42:44 2024 Received: (at 67512) by debbugs.gnu.org; 13 Feb 2024 22:42:44 +0000 Received: from localhost ([127.0.0.1]:48516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ra1UC-00033p-0S for submit@debbugs.gnu.org; Tue, 13 Feb 2024 17:42:44 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:43313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ra1U9-00033W-7m for 67512@debbugs.gnu.org; Tue, 13 Feb 2024 17:42:42 -0500 Received: by mail-ed1-f65.google.com with SMTP id 4fb4d7f45d1cf-562117d3dbfso364884a12.1 for <67512@debbugs.gnu.org>; Tue, 13 Feb 2024 14:42:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707864078; x=1708468878; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=65Ai00HWseTEiuDAgnfzHRBLrE9n7NNzSCYdmgsxkmE=; b=BQ+zVr3NAAUdsOujy0OahdJYC0znokr1U0U7Xa7fF1iEsvyU0PGuo0enC54+Vq3xNg 4z6WRS7+MJLJaH/ktXOFoJm2fU4vmdGY5BEUA7SxDQ+BSQ3V0fuJqgEH0Hl6nqMGtjIf HpChsgqSjFtdawB+ydlnTgin8ftxAmBCN1d0DZW50ZSgu2K/VIs6LQV3UKgQFLT2Bpri TAKuAdjM7zl7IQipx51s2amYAffEoNJdj/yi/OE63w154wFuRL0CSERilMiEq7RdT747 vN11KpBcXCBsnzT1f/uQcmOtn0iHEwPeeWWIIqnDQRbEYJZ9vOgu7PVuVrEdh7qqmy9o EdXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707864078; x=1708468878; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=65Ai00HWseTEiuDAgnfzHRBLrE9n7NNzSCYdmgsxkmE=; b=ft3Ki3reqsFBjfDk1pQJ9/L1abwMPz+oECumFcfGfkeCMU7ecHgUH7FaDFQVvt7SNk Mp0pmBRDeTzUKwLIg8N5Ja50q236Q8wXfRoXhlIk0+5TSm7a9CCMlwP/1t3Wjj2nujwV GfTiGpVAbIe0+BEiBjVCsF2Ay6B/MMPbXlo8N9Zpup3mwySDKVu0Gf/EIFZ/rfVoEJYg G37kN3KB10KJtWcBSFFWqAYqhp7ZlAKWtaAFbtyh+ACSKweOyUTkcTd20sxM3aCZjWsC k9RPpfc1dgFyeVOGciukuRixOuj/w1t3AMiYbpOwXIMxLZxsdOyIaUQZeJXm1xMgrWRY 0AUg== X-Forwarded-Encrypted: i=1; AJvYcCXq9s6QsaSrM233qz1XQL4Bvy4fNKcayg1nMl2+N9U5f2bAadn7zUKTroUYx0HjQ3vf29dPYfTdOCLoCE5K5Qob6zxGh5A= X-Gm-Message-State: AOJu0YyVmI7LGipuLLfSbjMQC2o56FqTXLGs0GmzeFvlP2DmwSpksVy9 Vg7k7cKEQ+XuuX+0at9gtIm3dMyl16uf+n2LOxzktQm9UFWOepWgu56frxhB35w= X-Google-Smtp-Source: AGHT+IFtuccMmCfQsMQZq617mHcmd4K3TpQd7gNoF7QIhyk8l7tsWu0UfEOv2GtDU/n5j024PLfU1Q== X-Received: by 2002:a17:906:aacb:b0:a3c:d0d0:4602 with SMTP id kt11-20020a170906aacb00b00a3cd0d04602mr173243ejb.6.1707864077625; Tue, 13 Feb 2024 14:41:17 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCX2u0Hjl0pM1HrtPUGlL2znXQk6p8z8KutQmY7bHF0Ezbx1Hb2pFzGPdakpgqUs0B5lzbTJvr7REvMzCK+OwNI7PvgFdp8= Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id tl19-20020a170907c31300b00a3cea63f7efsm1403212ejc.30.2024.02.13.14.41.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 14:41:17 -0800 (PST) Message-ID: <1808da259ee4755731fade4507812fb3f9ba619e.camel@gmail.com> Subject: Re: [PATCH v4 3/4] gnu: Add wasm packages. From: Liliana Marie Prikler To: Ian Eure , 67512@debbugs.gnu.org Date: Tue, 13 Feb 2024 23:41:16 +0100 In-Reply-To: <39662eaab8ebb73981be67f42a0277c2013be76b.1707855137.git.ian@retrospec.tv> References: <39662eaab8ebb73981be67f42a0277c2013be76b.1707855137.git.ian@retrospec.tv> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Dienstag, dem 13.02.2024 um 12:34 -0800 schrieb Ian Eure: > * gnu/packages/wasm.scm (wasi-libc): New variable. > * gnu/packages/wasm.scm (wasm32-wasi-clang-runtime): New variable. > * gnu/packages/wasm.scm (wasm32-wasi-clang): New variable. > * gnu/packages/wasm.scm (wasm32-wasi-libcxx): New variable. > * gnu/packages/wasm.scm (wasm32-wasi-clang-toolchain): New variable. > --- Not sure what the result from v1-v3 is, but generally we do one package per patch. Also, if there is a reason to create a new file, what do we do with the already packaged webassembly stuff in web.scm? Cheers From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 13 18:47:57 2024 Received: (at 67512) by debbugs.gnu.org; 13 Feb 2024 23:47:57 +0000 Received: from localhost ([127.0.0.1]:48702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ra2VJ-0005Rl-73 for submit@debbugs.gnu.org; Tue, 13 Feb 2024 18:47:57 -0500 Received: from fhigh4-smtp.messagingengine.com ([103.168.172.155]:58653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ra2VF-0005RS-3k for 67512@debbugs.gnu.org; Tue, 13 Feb 2024 18:47:55 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 1590D114006F; Tue, 13 Feb 2024 18:47:30 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 13 Feb 2024 18:47:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1707868050; x=1707954450; bh=5KseBq3DyCDMNqmVBBnNYj8YudLQ9Ez96Ras9W/WQ7U=; b= X1XgH6/HvpL4uM7STcyvfgFDS0ZWTbn5no/eeUmUYZSMVdAsjg9TqGYJDI1WSHvw Xa1BR6cBgAe34vUXEfNQqbMlQUf4zInzhhHAEJS29ahg0DYflWLHVd+kdskj1VvY 15FoHvqY1TH+54M5s3zt+DpEiTZUPglg0twg9J2GqH7ZURN/shRWbxe2qJbJKHAx 09KGT0CL6ZxqwTyuc2ucFc4sYLuSqR2fQ24IFht2BRKrnEzCk77KVsC5Ii+Z3E2U DLEeC7N5xRQhqyQkk20yH3KXk3Pdawke4fflEqCGj6a1oDTNiJC7r/K+32I2rArR eOnVSf/ti3hnuvJ9jm7szg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707868050; x= 1707954450; bh=5KseBq3DyCDMNqmVBBnNYj8YudLQ9Ez96Ras9W/WQ7U=; b=t anxpkcaWygkMDwwzY3tKzKtYaAqMKJz+OnRgg4OZIdewi0U5c0cMY+XBchr4rFTi uKl89Noqv1WqvQXD1wTpK37jEAa2dzZcYLa8WG4EGoQFoiRoS513ZZjYxVjSqWkK caFYwwZMUcLd21QW79hCLeSfI0Ks54e37DiYJvY3wUlxJlKshMjyfawmWKM47AOs kuOtwGJR2bhy33uEKFvGfMIwzaAiAUA4G55HhO+TW4YEwQ9ZZ8Ne851mX4XaNpKB GseRYCeY6eQNoxgaYcb5CBqLzXWNghuSsVlgnjlNdoSJ8zP+ykoQWMpGrDOO1YR3 wHZyL2PyXet2MOS3EGhFw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudeigdduhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffjgfkgggtgfesthhqredttderjeenucfhrhhomhepkfgrnhcu gfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdrthhvqeenucggtffrrghtthgvrhhnpe fhleevtdeifeffgfegiedvueekudettdevjeffhfelieelfeehgefgudfgieeuhfenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvg htrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 13 Feb 2024 18:47:29 -0500 (EST) References: <39662eaab8ebb73981be67f42a0277c2013be76b.1707855137.git.ian@retrospec.tv> <1808da259ee4755731fade4507812fb3f9ba619e.camel@gmail.com> User-agent: mu4e 1.8.13; emacs 28.2 From: Ian Eure To: Liliana Marie Prikler Subject: Re: [PATCH v4 3/4] gnu: Add wasm packages. Date: Tue, 13 Feb 2024 15:22:06 -0800 In-reply-to: <1808da259ee4755731fade4507812fb3f9ba619e.camel@gmail.com> Message-ID: <87eddgx6y7.fsf@retrospec.tv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Liliana Marie Prikler writes: > Am Dienstag, dem 13.02.2024 um 12:34 -0800 schrieb Ian Eure: >> * gnu/packages/wasm.scm (wasi-libc): New variable. >> * gnu/packages/wasm.scm (wasm32-wasi-clang-runtime): New=20 >> variable. >> * gnu/packages/wasm.scm (wasm32-wasi-clang): New variable. >> * gnu/packages/wasm.scm (wasm32-wasi-libcxx): New variable. >> * gnu/packages/wasm.scm (wasm32-wasi-clang-toolchain): New=20 >> variable. >> --- > Not sure what the result from v1-v3 is, but generally we do one=20 > package > per patch. > I have no problem splitting it up. > Also, if there is a reason to create a new file what do we do=20 > with the already packaged webassembly stuff in web.scm? > It was like that in nonguix, where I got it from. It=E2=80=99s not a=20 *good* reason, but that=E2=80=99s the reason. I have absolutely zero preference, so please let me know where=20 things should go and I=E2=80=99ll do it. If it helps to have some=20 options, I think these are reasonable ones, ordered by=20 my-hot-take-descending: A. Move the two wasm packages from (gnu packages web) to (gnu=20 packages wasm). Will require updates to anything which uses wabt,=20 wasm3, or wasm-micro-runtime as inputs. B. Leave as-is. C. Fold the new (gnu packages wasm) into (gnu packages web). I=E2=80=99m=20 not certain this is a sensible place. This has things more=20 traditionally webby, like HTTP servers Perl cooke modules, HTML=20 formatters, etc. The wasm packages I=E2=80=99m bringing over are a wasm=20 complier and libc usable by the wasm code built with that=20 compiler. D. Fold the new (gnu packages wasm) into (gnu packages librewolf).=20 This is the only place they=E2=80=99re used, but it sounds like there=E2=80= =99s=20 desire to port some of the other firefoxen to this stuff, so=20 probably not a good long-term option. In the interest of avoiding more back-and-forth, are there other=20 structural things I should be addressing at the same time as=20 these? This patch series has been open for three months and I=E2=80=99d=20 like to get things wrapped up. =E2=80=94 Ian From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 14 13:06:11 2024 Received: (at 67512) by debbugs.gnu.org; 14 Feb 2024 18:06:11 +0000 Received: from localhost ([127.0.0.1]:53011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raJe7-0007N7-Dk for submit@debbugs.gnu.org; Wed, 14 Feb 2024 13:06:11 -0500 Received: from world.peace.net ([64.112.178.59]:34744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raJe5-0007Mr-GH for 67512@debbugs.gnu.org; Wed, 14 Feb 2024 13:06:10 -0500 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1raJdd-0005Kw-H0; Wed, 14 Feb 2024 13:05:41 -0500 From: Mark H Weaver To: Ian Eure , 67512@debbugs.gnu.org Subject: Re: [bug#67512] [PATCH v4 1/4] gnu: Move icu4c-73 from gnuzilla to icu4c. In-Reply-To: References: Date: Wed, 14 Feb 2024 13:05:34 -0500 Message-ID: <87ttma53au.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 67512 Cc: Jonathan Brielmaier , =?utf-8?Q?Cl=C3=A9ment?= Lassieur X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) Ian Eure writes: > * gnu/packages/icu4c.scm (icu4c-73): New variable. > * gnu/packages/gnuzilla.scm (icu4c-73-promise): Delete variable. The commit log should mention the changes to 'icecat-minimal' and 'make-torbrowser'. Otherwise, looks good to me. Thanks, Mark From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 16 09:02:32 2024 Received: (at 67512) by debbugs.gnu.org; 16 Feb 2024 14:02:32 +0000 Received: from localhost ([127.0.0.1]:58113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raynP-0001td-Rz for submit@debbugs.gnu.org; Fri, 16 Feb 2024 09:02:32 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:59277) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raynM-0001tQ-S7 for 67512@debbugs.gnu.org; Fri, 16 Feb 2024 09:02:30 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 6C1305C0068; Fri, 16 Feb 2024 09:02:04 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 16 Feb 2024 09:02:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1708092124; x=1708178524; bh=9V6xmNN/m6Q9ebVwc8FjkGS0Du76p6T/WTne8iWYqbM=; b= gDP4E43wp2zZkJoQ7OI9O/V9Wqyq/5q7LNcubhUNtp39VDv6J7PaJ+uBe6zPPL9O UWim6DxJQCx3xU9FbpYD4APRYrrhIiFMwSZ17kuF1xifYkUo2jHNw/7eY905j9Px Hz8kevfzcgCeOYxKndgl8BzrtBy85+9mSlDtXWILETFUZpCjF0RXfNMdRwxirEiC eMRzLn4mhfwnKFd6uVCVo1QDIU+UU3SDur1Rf88kvZbwyLIgljYqKPi8xTKwH3vQ tlI2jFgx3RatCuwNO8byVM13wriPqghKJ/0yQCryA7nkfzjq48cRYomIF+zzw1vh rdM3b22zzhv8SZOkEm7pyw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708092124; x= 1708178524; bh=9V6xmNN/m6Q9ebVwc8FjkGS0Du76p6T/WTne8iWYqbM=; b=a DJggI7XlQpkE+2Be6Cl9b2x9OScXS15g+GoNg86VjrwHUdr7BgdqwA8awrTCFigp uw+sGlYfcpGa/uZ20EMDcLKTiO55NAwCk2FYH0eJg9uzBxQ6wl3Rbe8RXsA1NxdL ngbOWKd7LjyyQ9P+iNmjcaI9XPqGtpaVnkZk/Rlg+v1ALSM6WY/gvhmCwxmWnXdH 9k4HihCs1PNgGjpIsOWO5bSWnF8jCp/42W2sCquof7PMdU112GSv6f5+hllN1cMq evV5Mrpwoo7UO+hyh4OpNzUeFDvftF4B8lurrS2ijbPJlO/p7LqFbRTykQbJ/mCK EcGFP3WQkrdRExU9bwn2Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddvgdehlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfgfgggtgfesthhqredttderjeenucfhrhhomhepvehlrohm vghnthcunfgrshhsihgvuhhruceotghlvghmvghntheslhgrshhsihgvuhhrrdhorhhgqe enucggtffrrghtthgvrhhnpeegkeehfefftdefffeuveekgfffhfdtudfgudegueegvefg udetffdugfefhfejudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpegtlhgvmhgvnhhtsehlrghsshhivghurhdrohhrgh X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Feb 2024 09:02:02 -0500 (EST) From: =?utf-8?Q?Cl=C3=A9ment_Lassieur?= To: Mark H Weaver Subject: Re: [bug#67512] [PATCH v4 1/4] gnu: Move icu4c-73 from gnuzilla to icu4c. In-Reply-To: <87ttma53au.fsf@netris.org> (Mark H. Weaver's message of "Wed, 14 Feb 2024 13:05:34 -0500") References: <87ttma53au.fsf@netris.org> Date: Fri, 16 Feb 2024 15:02:01 +0100 Message-ID: <87cyswfqxy.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, Jonathan Brielmaier , Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) On Wed, Feb 14 2024, Mark H Weaver wrote: > Ian Eure writes: >> * gnu/packages/icu4c.scm (icu4c-73): New variable. >> * gnu/packages/gnuzilla.scm (icu4c-73-promise): Delete variable. > > The commit log should mention the changes to 'icecat-minimal' and > 'make-torbrowser'. Otherwise, looks good to me. I pushed this one (with small commit message updates), so we can have a feeling that things are advancing :) Thanks Cl=C3=A9ment From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 16 09:30:00 2024 Received: (at 67512) by debbugs.gnu.org; 16 Feb 2024 14:30:00 +0000 Received: from localhost ([127.0.0.1]:58129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1razDz-0002Yq-Pj for submit@debbugs.gnu.org; Fri, 16 Feb 2024 09:30:00 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:48459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1razDx-0002Ye-L4 for 67512@debbugs.gnu.org; Fri, 16 Feb 2024 09:29:59 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id BC0955C00A0; Fri, 16 Feb 2024 09:29:32 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 16 Feb 2024 09:29:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1708093772; x=1708180172; bh=SY6bT7IHDVm/xgz/YbV6jgrvEIeCYUAp/9lg1yk4FIY=; b= X6XWSog/RSkPtJoHsDRsVYo8ctcX1tlObbjxTHt6YJrGjS7gFvJBCjouSgYVcsbS J+lsMm5vOWrWqSrM/WdBm1nCoY+OtW3LgwI5hVmCcQ8gIGcDIqxUQYcBJ7t60DGV EGGKyhiS1Pevvav7CzXF46MoQJ1WzMo0NHmOv9tNKCRbpP0spTm235lm51Ce4Szi q+n+w0JlA0Blulmd5mZ6F/vi4VKvcbnJNouk5fLUKZyeYtogZS64Uc2etAoLJKBQ IZiSJSoyKTjewiEeGzSYEF502mjJjso5oFeUtTxs7YMwGY0W9WaAaIAT4eiJ+d9O /YyuTrHd5xZ/s5NcyFq3Ng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708093772; x= 1708180172; bh=SY6bT7IHDVm/xgz/YbV6jgrvEIeCYUAp/9lg1yk4FIY=; b=c ObKX3+kUBEfyFcpOeiCgrDcP6foDJ2BX8pAh4E7Ie6qYdP+kmI8NovAKepKXc/h5 MU/a440o3jvSJbB7WAwh2yf4dKKe3dvUZl/MNrDlbDnEAsqTVdLskztthMDF8wbB tGtZOOSyzt+oqlGFN3jtegnd0KyZi5bbC/sTHPGQ26p2G2E3B6UiczjI0A97VrjN xu2MxelZDxE1X6v7xoRcLSFh21L/p4jXLkB5MVtB4odgHS08r3qQ4QI4H73vgtt5 Tu2P2xavmky8tukB9JV00Qo3YlJ2O3sZECSL1Jhl3XVn753paCpMx70HPGL7btMi vuDPq/NaVwFF2zzl1k2IA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddvgdeigecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfgfgggtgfesthhqredttderjeenucfhrhhomhepvehlrohm vghnthcunfgrshhsihgvuhhruceotghlvghmvghntheslhgrshhsihgvuhhrrdhorhhgqe enucggtffrrghtthgvrhhnpeegkeehfefftdefffeuveekgfffhfdtudfgudegueegvefg udetffdugfefhfejudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpegtlhgvmhgvnhhtsehlrghsshhivghurhdrohhrgh X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Feb 2024 09:29:31 -0500 (EST) From: =?utf-8?Q?Cl=C3=A9ment_Lassieur?= To: Ian Eure Subject: Re: [bug#67512] [PATCH v4 3/4] gnu: Add wasm packages. In-Reply-To: <87eddgx6y7.fsf@retrospec.tv> (Ian Eure's message of "Tue, 13 Feb 2024 15:22:06 -0800") References: <39662eaab8ebb73981be67f42a0277c2013be76b.1707855137.git.ian@retrospec.tv> <1808da259ee4755731fade4507812fb3f9ba619e.camel@gmail.com> <87eddgx6y7.fsf@retrospec.tv> Date: Fri, 16 Feb 2024 15:29:29 +0100 Message-ID: <877cj4fpo6.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, Mark H Weaver , Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) On Tue, Feb 13 2024, Ian Eure wrote: > D. Fold the new (gnu packages wasm) into (gnu packages librewolf). This i= s the > only place they=E2=80=99re used, but it sounds like there=E2=80=99s desir= e to port some of the > other firefoxen to this stuff, so probably not a good long-term option. Does Librewolf depend on the Wasm packages more than the other Firefox based browsers? My point is that if your Librewolf package is independent from the Wasm packages, they can be split and reviewed independently. That would make the Librewolf review shorter and easier, and the Wasm review more consistent and easy to test. Also, adding Wasm to our Firefox based browsers would be a one-shot. (Of course it doesn't have to be included in Icecat, but I think it would be great to have it in =E2=80=98make-torbrowser=E2=80=99.) It makes even more sense when considering that the author of the Wasm patches is not you (and doesn't reply). > In the interest of avoiding more back-and-forth, are there other structur= al > things I should be addressing at the same time as these? This patch seri= es > has been open for three months and I=E2=80=99d like to get things wrapped= up. Sorry, reviewing is hard. I've pushed the icu4c-73 one, and I wish to get the Wasm patch independent so that we can focus on reviewing Librewolf. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 16 16:49:42 2024 Received: (at 67512) by debbugs.gnu.org; 16 Feb 2024 21:49:42 +0000 Received: from localhost ([127.0.0.1]:60295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rb65V-0002xV-Vc for submit@debbugs.gnu.org; Fri, 16 Feb 2024 16:49:42 -0500 Received: from world.peace.net ([64.112.178.59]:36998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rb65S-0002xF-Vm for 67512@debbugs.gnu.org; Fri, 16 Feb 2024 16:49:40 -0500 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rb651-0004OG-2l; Fri, 16 Feb 2024 16:49:11 -0500 From: Mark H Weaver To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur , Ian Eure Subject: Re: [bug#67512] [PATCH v4 3/4] gnu: Add wasm packages. In-Reply-To: <877cj4fpo6.fsf@lassieur.org> References: <39662eaab8ebb73981be67f42a0277c2013be76b.1707855137.git.ian@retrospec.tv> <1808da259ee4755731fade4507812fb3f9ba619e.camel@gmail.com> <87eddgx6y7.fsf@retrospec.tv> <877cj4fpo6.fsf@lassieur.org> Date: Fri, 16 Feb 2024 16:48:55 -0500 Message-ID: <87mss03wrh.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) Cl=C3=A9ment Lassieur writes: > On Tue, Feb 13 2024, Ian Eure wrote: > >> D. Fold the new (gnu packages wasm) into (gnu packages librewolf). This = is the >> only place they=E2=80=99re used, but it sounds like there=E2=80=99s desi= re to port some of the >> other firefoxen to this stuff, so probably not a good long-term option. > > Does Librewolf depend on the Wasm packages more than the other Firefox > based browsers? My point is that if your Librewolf package is > independent from the Wasm packages, they can be split and reviewed > independently. > > That would make the Librewolf review shorter and easier, and the Wasm > review more consistent and easy to test. Also, adding Wasm to our > Firefox based browsers would be a one-shot. (Of course it doesn't have > to be included in Icecat, but I think it would be great to have it in > =E2=80=98make-torbrowser=E2=80=99.) I'd like to have support for Wasm sandboxed libraries in IceCat as well. Thanks, Mark From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 17 11:08:09 2024 Received: (at 67512) by debbugs.gnu.org; 17 Feb 2024 16:08:09 +0000 Received: from localhost ([127.0.0.1]:33651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbNEW-0004Lo-Rx for submit@debbugs.gnu.org; Sat, 17 Feb 2024 11:08:09 -0500 Received: from wfout5-smtp.messagingengine.com ([64.147.123.148]:49075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbNEU-0004Kq-Uh for 67512@debbugs.gnu.org; Sat, 17 Feb 2024 11:08:08 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfout.west.internal (Postfix) with ESMTP id 9EE591C0009D; Sat, 17 Feb 2024 11:07:40 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 17 Feb 2024 11:07:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1708186060; x=1708272460; bh=ralsJQAhWytJq2wiCgNPKVoCyIpRuPIq3Cwy7ZE4Pfc=; b= EZE3n1Xtr9ih3CqiUiGT/CaU7FnpFvh1djUFC5adXDKaT2+xKNZ2aMUevdGRJY3q 8Ap4MvJxqMlDSHIVEusnT1q95T6EPnVWqXmApjeYv4ZI3JiGcOwzaqOYNctw3ULR k+yK11WhqHFITsZG05AmjG+8B/SuIiDpoWxGMg5AbXtWBa2jTSZoY5U78weiwKWr CvX2bBPzodj+fiU7fa1y8TcNRhnkENmST5x6XeWSwGBtP6H0WCUMRw/COpzZrJ99 TLUqH/KCoEzCUg1rebVPQCGIkU5nvdTZ4wZhqPpEFRiClJjc3AKvjp8AckLd6MDH F1hqrpeoOwQqHjM5svEoAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708186060; x= 1708272460; bh=ralsJQAhWytJq2wiCgNPKVoCyIpRuPIq3Cwy7ZE4Pfc=; b=T RgOyyA+KKijZj7Qs0CP0tqXdleRjjKongNbKBUOP9KtDNlkL8ftxV6LWC1lSf7Pc e2p1qH2drvvFNIcVa7+zCapjx+26r0d+WIghgfybuRIHCAhGPQrYUYbxbIexUdtF 40IkH7VunUXq1b++xA584rjvQOR0sMPHS0NJJUXcG1W4KlCR22TDSdt/JEZJKQmZ puygi4V0ySQaLK7zlpxIC65hcvE93pATsIw/O6gpP4tEARxCEhbF8RQwkr6EqAjc xvWwi1RUfalOlcBDjtlJ+GuUjtDPjJipNQTO6xSU+di/YvggG0nrzXggHqDsXULx Yae/wUtR/EXfi0aLmNCmg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeggdekgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffjgfkgggtgfesthhqredttderjeenucfhrhhomhepkfgrnhcu gfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdrthhvqeenucggtffrrghtthgvrhhnpe egudeijeeiheegheeujeetveegtdeugfeikedtleefkeduieelgffgteegudekkeenucff ohhmrghinheplhhisghrvgifohhlfhdrnhgvthenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 17 Feb 2024 11:07:39 -0500 (EST) References: <87a5p49d98.fsf@lassieur.org> User-agent: mu4e 1.10.8; emacs 29.1 From: Ian Eure To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Subject: Re: [bug#67512] [PATCH 0/5] Add LibreWolf Date: Sat, 17 Feb 2024 08:06:56 -0800 In-reply-to: <87a5p49d98.fsf@lassieur.org> Message-ID: <87cysvdqgm.fsf@retrospec.tv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, Pierre Langlois X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) Hi Pierre, Pinging on this to see if you saw it / have an answer. Thanks, =E2=80=94 Ian Cl=C3=A9ment Lassieur writes: > Hi Ian and Pierre, > > Thank you for this! I hope to do a review soon. Meanwhile I=20 > have one > question for Pierre: is there any reason why your Wasm work was > contributed to Nonguix instead of Guix? It looks like it could=20 > be used > by Icecat. Would you say it is ready to be added to the Guix=20 > repo? > > Thank you, > Cl=C3=A9ment > > On Tue, Nov 28 2023, Ian Eure wrote: > >> I mentioned in #guix that I was working on a package for=20 >> LibreWolf, and it was requested that I send in patches, so I=20 >> am. These changes are based on the firefox-esr package in=20 >> nonguix; I've retained the copyright / authorship notices from=20 >> there. >> >> LibreWolf (https://librewolf.net/) is a fork of Firefox which=20 >> removes the telemetry and advertising, and bundles uBlock=20 >> Origin. It doesn't have the redistribution issues that Firefox=20 >> does, its name/logo are under MPL 2.0 and aren't trademarked. >> >> I'm new to Guix, and not remotely a browser development expert,=20 >> so I don't expect these are ready to be accepted yet, but I=20 >> believe they're in good enough shape to have a discussion=20 >> about. They're working acceptably well for me, though I'm not=20 >> currently daily driving Guix, so there may be issues I haven't=20 >> encountered yet. >> >> Guide to changes in this patchset >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D >> >> icu4c has been updated to 73.1, and the previous version kept=20 >> as icu4c-71. I encountered consistent failures of the=20 >> node@10.24.1 test suite with icu4c 73.1, so I kept that on=20 >> 71.1. icu4c is needed by many packages, so this change is the=20 >> highest-impact in the patchset. >> >> The (gnu packages wasm) module is unchanged from nonguix,=20 >> except for the file header and module declaration. >> >> The (gnu packages librewolf) module is a simplified/adapted=20 >> version of (nongnu packages firefox). The Firefox Nightly=20 >> packages have been removed, as there's no LibreWolf equivalent.=20 >> I also didn't bring over the wayland variant, but I could, if=20 >> that's desired. I'm not sure why there are specific=20 >> x11/wayland variants, as the packages for other distros don't=20 >> seem to need this split. >> >> The librewolf package has some functions duplicated from (gnu=20 >> packages gnuzilla), which probably ought to get factored out=20 >> and put somewhere, but I'm not sure if they should be in (gnu=20 >> packages mozilla) or a different module. Guidance would be=20 >> appreciated here. >> >> Ian Eure (5): >> gnu: icu4c: Update to 73.1. >> gnu: Add icu4c-71. >> gnu: node: Switch to icu4c-71. >> gnu: Add wasm packages. >> gnu: Add librewolf. >> >> gnu/packages/icu4c.scm | 21 +- >> gnu/packages/librewolf.scm | 560=20 >> +++++++++++++++++++++++++++++++++++++ >> gnu/packages/node.scm | 4 +- >> gnu/packages/wasm.scm | 273 ++++++++++++++++++ >> 4 files changed, 854 insertions(+), 4 deletions(-) >> create mode 100644 gnu/packages/librewolf.scm >> create mode 100644 gnu/packages/wasm.scm >> >> >> base-commit: 2410a30f6c06d56b5589e0ad685bcdf09bb144bf > From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 17 11:09:39 2024 Received: (at 67512) by debbugs.gnu.org; 17 Feb 2024 16:09:39 +0000 Received: from localhost ([127.0.0.1]:33662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbNFz-0004Pr-6q for submit@debbugs.gnu.org; Sat, 17 Feb 2024 11:09:39 -0500 Received: from wfhigh6-smtp.messagingengine.com ([64.147.123.157]:37251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbNFw-0004Pd-9v for 67512@debbugs.gnu.org; Sat, 17 Feb 2024 11:09:38 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.west.internal (Postfix) with ESMTP id 602541800086; Sat, 17 Feb 2024 11:09:09 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 17 Feb 2024 11:09:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1708186148; x=1708272548; bh=PiAKlmbDqqbJT0WNKJ1JN7ngrR4tsSgYtODGO4vEx5k=; b= ek2XbldhgQ2d2GTaXpWqt5BjF4nPTuMTay0jEHaNnGF938Z/j25BrJVpHz2Pp15+ NmwhMJmtUfzadJQKPo+vbHdoZjHqEFSXizzAWc0OKFKcsFmZSdraAzpntc33cUWC j/pxAr5oJFTKfliMDKTW88QcAeT5RnMNoOZrCOTDphcO51oSYSsGMefzc5zKs72O LV+B88UlTXD3O9TNUjk8zFcvoznB5fEiewBWB/2lTWNyWEK6XVFtwO9R2jmw63t5 t5ewuTc2Y/vXWM2OR5hGDWyy8Mewp19qjLc5dHH1ajsxEr8vyE8X7oyXJIfvu0GZ z6sJxvk6qgEH3UhZaAcv8A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708186148; x= 1708272548; bh=PiAKlmbDqqbJT0WNKJ1JN7ngrR4tsSgYtODGO4vEx5k=; b=g Na5K1T0l+bi/b4lPO++ljlNuT56ap/1GwCrY1jFoxtRDzn/Ic451Vxss4K96MNwl GnaspvmotYg6SKubGPlg0Vu+UJdc5+UYtK3FqobSbBwPUhXvvJuJYM8guA1y0s8O u2xal7sgTTfKSzfjJB2TGFJrkZHYXdIfoZbzNhFfWjz6EirovoU53NfEPEsja0wX ua0BBz5KD9r0nen+qkYgxLyZ0n8TzDXlnDKix3/UGYdUpkj0ROKO4eBqgP63qNJI 7ZQQP25TimRiMW1rtSM0e7Jv9spKOxD3XM/0J51E3VebLDdDXk8zAD/Dno7oKw3n ICVbM2vVh3Kn0TgnlhmbQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeggdekgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffjgfkgggtgfesthhqredttderjeenucfhrhhomhepkfgrnhcu gfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdrthhvqeenucggtffrrghtthgvrhhnpe fhleevtdeifeffgfegiedvueekudettdevjeffhfelieelfeehgefgudfgieeuhfenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvg htrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 17 Feb 2024 11:09:07 -0500 (EST) References: <87ttma53au.fsf@netris.org> <87cyswfqxy.fsf@lassieur.org> User-agent: mu4e 1.10.8; emacs 29.1 From: Ian Eure To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Subject: Re: [bug#67512] [PATCH v4 1/4] gnu: Move icu4c-73 from gnuzilla to icu4c. Date: Sat, 17 Feb 2024 08:07:52 -0800 In-reply-to: <87cyswfqxy.fsf@lassieur.org> Message-ID: <878r3jdqe4.fsf@retrospec.tv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, Mark H Weaver , Jonathan Brielmaier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) Cl=C3=A9ment Lassieur writes: > On Wed, Feb 14 2024, Mark H Weaver wrote: > >> Ian Eure writes: >>> * gnu/packages/icu4c.scm (icu4c-73): New variable. >>> * gnu/packages/gnuzilla.scm (icu4c-73-promise): Delete=20 >>> variable. >> >> The commit log should mention the changes to 'icecat-minimal'=20 >> and >> 'make-torbrowser'. Otherwise, looks good to me. > > I pushed this one (with small commit message updates), so we can=20 > have a > feeling that things are advancing :) > Thank you. Do you think the nss patch is also mergeable? Thanks, =E2=80=94 Ian From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 17 11:25:53 2024 Received: (at 67512) by debbugs.gnu.org; 17 Feb 2024 16:25:53 +0000 Received: from localhost ([127.0.0.1]:33674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbNVg-0004qM-FF for submit@debbugs.gnu.org; Sat, 17 Feb 2024 11:25:52 -0500 Received: from wfhigh6-smtp.messagingengine.com ([64.147.123.157]:34249) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbNVd-0004py-6Y for 67512@debbugs.gnu.org; Sat, 17 Feb 2024 11:25:50 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.west.internal (Postfix) with ESMTP id E6B3218000AD; Sat, 17 Feb 2024 11:25:22 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 17 Feb 2024 11:25:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1708187122; x=1708273522; bh=+NHYzQbMTP2cGAKjWsPRLMOCdhAOZwC1l4YDA6jU2Fw=; b= Man1Z9K7ub5XiaJIwWMk56psTqHs5U6YBv4TgyKhLDsJp2og/FasycfgVN8q1eu8 87IA54wJMAfFYDG7ufveD5LHdlChjhPpVkM2EAZMDBDFAQkejzkwn4+qXLehX+UQ 8S50MZ7+Fu/OUrjyId4qt6MkOwFzTcLoY49u8mM399eEzhCoFBdjVfJHOOZpvC4L SoARHNLQQrT2L59Y0Eq6Uyo78nyzFzgSEvtxpnZU4wsL/AuZSbM9G/dCFLA7togZ ls5WE29E1rn2T3DSIxEn15ztW4ot6GOIWpFKItm5O6zHr5uacUG/HAnTFnXD122x X370hOLBw2cXU2vNh1mmzw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708187122; x= 1708273522; bh=+NHYzQbMTP2cGAKjWsPRLMOCdhAOZwC1l4YDA6jU2Fw=; b=i 25P3QEO/6IdC5LpItqmeVeX8pAoywLjCUvCcg/S11gaJegT3NAP4XgcjUK9SMw49 cAdwWVBdticoiWCZH13D45az+sj+M1hrKcU9x/zP5g2aMFnqe16k/y+KvjzoycUD xKXdhLWmA8MFZrIVXTF8juMDRaWpOWO2N9DPd19FUQttVZdl+nXnmUWTpWYMCKak VJY6F8agOO+0EGYeUF6bm9qmU5atvDVk2PRoLMORrmik9w6UtNCudLgycJBnY/tT +dS6yXzLmShdr28ojLE3LfDbqNzzaxPftRfIe2/Gf/UmWvaSOTZitJnd+bJQWY0g EyNHZTSz+QlVOU3JsN+1g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeggdekjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffjgfkgggtgfesthhqredttderjeenucfhrhhomhepkfgrnhcu gfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdrthhvqeenucggtffrrghtthgvrhhnpe fhfffhvdduvedvueevjeeiueekgeeukedvfeehleegkeffhfeggfetgeeujeeuheenucff ohhmrghinhepmhhoiihilhhlrgdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 17 Feb 2024 11:25:21 -0500 (EST) References: <39662eaab8ebb73981be67f42a0277c2013be76b.1707855137.git.ian@retrospec.tv> <1808da259ee4755731fade4507812fb3f9ba619e.camel@gmail.com> <87eddgx6y7.fsf@retrospec.tv> <877cj4fpo6.fsf@lassieur.org> User-agent: mu4e 1.10.8; emacs 29.1 From: Ian Eure To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Subject: Re: [bug#67512] [PATCH v4 3/4] gnu: Add wasm packages. Date: Sat, 17 Feb 2024 08:09:22 -0800 In-reply-to: <877cj4fpo6.fsf@lassieur.org> Message-ID: <871q9bdpn3.fsf@retrospec.tv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, Mark H Weaver , Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) Cl=C3=A9ment Lassieur writes: > On Tue, Feb 13 2024, Ian Eure wrote: > >> D. Fold the new (gnu packages wasm) into (gnu packages=20 >> librewolf). This is the >> only place they=E2=80=99re used, but it sounds like there=E2=80=99s desi= re to=20 >> port some of the >> other firefoxen to this stuff, so probably not a good long-term=20 >> option. > > Does Librewolf depend on the Wasm packages more than the other=20 > Firefox > based browsers? Upstream Librewolf doesn=E2=80=99t depend on the WASM packages more than=20 any other Firefoxen. I believe that WASM sandboxing is an=20 optional feature for recent Firefox and FF-derived browsers. In case anyone reading this isn=E2=80=99t familiar: Firefox has taken some= =20 libraries that handle untrusted data (which are implemented in=20 C/C++) and complied those WASM, which it runs in isolated=20 sandboxes. The idea being that if there=E2=80=99s a vulnerability in one=20 of those libraries, the impact will be diminished becasue the=20 exploit runs in an environment with very limited privileges[1]. > My point is that if your Librewolf package is independent from=20 > the Wasm packages, they can be split and reviewed independently. The Librewolf package I=E2=80=99m submitting depends on these WASM=20 packages; other Firefox-derived browsers currently in Guix don=E2=80=99t=20 (because they can=E2=80=99t, because the toolchain isn=E2=80=99t in Guix). > That would make the Librewolf review shorter and easier, and the=20 > Wasm > review more consistent and easy to test. Also, adding Wasm to=20 > our > Firefox based browsers would be a one-shot. (Of course it=20 > doesn't have > to be included in Icecat, but I think it would be great to have=20 > it in > =E2=80=98make-torbrowser=E2=80=99.) > I=E2=80=99m not sure what you mean by "adding Wasm to our Firefox based=20 browsers would be a one-shot." Are you saying you want a process=20 like: 1a. Get wasm toolchain stuff merged. 1b. Get Librewolf merged without WASM sandboxing. 2. Update icecat, torbrowser, mullvad, and librewolf to use WASM=20 sandboxing. Thanks, =E2=80=94 Ian [1]: See=20 https://hacks.mozilla.org/2020/02/securing-firefox-with-webassembly/=20 and=20 https://blog.mozilla.org/attack-and-defense/2021/12/06/webassembly-and-back= -again-fine-grained-sandboxing-in-firefox-95/=20 for more on this. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 20 21:01:19 2024 Received: (at 67512) by debbugs.gnu.org; 21 Feb 2024 02:01:19 +0000 Received: from localhost ([127.0.0.1]:47454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcbvD-0004Dz-AL for submit@debbugs.gnu.org; Tue, 20 Feb 2024 21:01:19 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:36881) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcbvA-0004Dl-Nb for 67512@debbugs.gnu.org; Tue, 20 Feb 2024 21:01:17 -0500 Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.nyi.internal (Postfix) with ESMTP id 48B745C0093; Tue, 20 Feb 2024 21:00:49 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 20 Feb 2024 21:00:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1708480849; x=1708567249; bh=ux6ej/EVByYkjoPWxmU+utCurugFr11QziuRHNodomY=; b= MgIMA3kEzeBib9beFB54lSOR25DGKnJp9w/Jt/15OWQrYlWVkeFcJ3GTWduxj5GZ xSkBNMhdrbmviBlJMpGQKP9vMaohIqG9PNWlC8XR2gzMGkH7ZSfmgvdlnqDB1Ezj CUJMhGOvq5guazT2iKphqzY270HLBNwybwR9MGaxZmQRt+PYb05W2oAMq4xkp2PH 07N4usR0lPkWNOOoNNB9o8Z+DaLwyY49NbrR3KG1AHpBDdszBjPoxWJGmvIlXF7g /lTZWVIUReY8FpHUsC/9Na1NYCwliVp7ijZMuD322boD02Hc8YkWo+Hm/PjbKv+A dzJUs67iroclttroCdm4Xg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708480849; x= 1708567249; bh=ux6ej/EVByYkjoPWxmU+utCurugFr11QziuRHNodomY=; b=g 8nPzgpSszkFzLynIAiWbQZUQ3MOsHh1MhfqSu9exgN5lu1BFXcdEAMFTeuNiEWf9 0wrgaMxdKEvRCn0r8rUcag3heOgqAkyNGq6zPTd15PlC8stgNZRuuuZAEu26yvtK 3mLa+xw5AO7z01KdBCRpMgIPdwZO84jyJ5G4DvQx90+v0Ha93vjPDp6iZEPZoBdH 0KDFWjwVcqA+f65gb98uEBKm6jtuekB1BYXsXfqiiyEiqRhMpP0/u6wQiUeKM25V du1HfHP6gmCxyM3sqPmdQjZqN0LIugacVaDgX5outDTrp6uwgt+E/xjhmzjyEHsF fcFNm1MDoq7JlscIK7Zvw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedugdegvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfgfgggtgfesthhqredttderjeenucfhrhhomhepvehlrohm vghnthcunfgrshhsihgvuhhruceotghlvghmvghntheslhgrshhsihgvuhhrrdhorhhgqe enucggtffrrghtthgvrhhnpeeiudeuheeviedtleelheeivedutdejgfevhfdvtedvudel hfdthedvvddtieehkeenucffohhmrghinhepghhnuhdrohhrghenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegtlhgvmhgvnhhtsehlrghsshhi vghurhdrohhrgh X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 20 Feb 2024 21:00:47 -0500 (EST) From: =?utf-8?Q?Cl=C3=A9ment_Lassieur?= To: Ian Eure Subject: Re: [bug#67512] [PATCH v4 3/4] gnu: Add wasm packages. In-Reply-To: <871q9bdpn3.fsf@retrospec.tv> (Ian Eure's message of "Sat, 17 Feb 2024 08:09:22 -0800") References: <39662eaab8ebb73981be67f42a0277c2013be76b.1707855137.git.ian@retrospec.tv> <1808da259ee4755731fade4507812fb3f9ba619e.camel@gmail.com> <87eddgx6y7.fsf@retrospec.tv> <877cj4fpo6.fsf@lassieur.org> <871q9bdpn3.fsf@retrospec.tv> Date: Wed, 21 Feb 2024 03:00:43 +0100 Message-ID: <87ttm2wp84.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, Mark H Weaver , Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) On Sat, Feb 17 2024, Ian Eure wrote: > Cl=C3=A9ment Lassieur writes: > >> On Tue, Feb 13 2024, Ian Eure wrote: >> >>> D. Fold the new (gnu packages wasm) into (gnu packages librewolf). This= is >>> the >>> only place they=E2=80=99re used, but it sounds like there=E2=80=99s des= ire to port some of >>> the >>> other firefoxen to this stuff, so probably not a good long-term option. >> >> Does Librewolf depend on the Wasm packages more than the other Firefox >> based browsers? > > Upstream Librewolf doesn=E2=80=99t depend on the WASM packages more than = any other > Firefoxen. I believe that WASM sandboxing is an optional feature for rec= ent > Firefox and FF-derived browsers. > > > In case anyone reading this isn=E2=80=99t familiar: Firefox has taken som= e libraries > that handle untrusted data (which are implemented in C/C++) and complied = those > WASM, which it runs in isolated sandboxes. The idea being that if there= =E2=80=99s a > vulnerability in one of those libraries, the impact will be diminished be= casue > the exploit runs in an environment with very limited privileges[1]. > > >> My point is that if your Librewolf package is independent from the Wasm >> packages, they can be split and reviewed independently. > > The Librewolf package I=E2=80=99m submitting depends on these WASM packag= es; other > Firefox-derived browsers currently in Guix don=E2=80=99t (because they ca= n=E2=80=99t, because > the toolchain isn=E2=80=99t in Guix). > > >> That would make the Librewolf review shorter and easier, and the Wasm >> review more consistent and easy to test. Also, adding Wasm to our >> Firefox based browsers would be a one-shot. (Of course it doesn't have >> to be included in Icecat, but I think it would be great to have it in >> =E2=80=98make-torbrowser=E2=80=99.) >> > > I=E2=80=99m not sure what you mean by "adding Wasm to our Firefox based b= rowsers would > be a one-shot." Are you saying you want a process like: > > 1a. Get wasm toolchain stuff merged. > 1b. Get Librewolf merged without WASM sandboxing. > 2. Update icecat, torbrowser, mullvad, and librewolf to use WASM sandboxi= ng. Excatly. 1b can be done after 1a, or before 1a. And if you can explain why is Mullvad Browser not "great for daily use" that would be great. https://logs.guix.gnu.org/guix/2024-02-20.log Cl=C3=A9ment From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 20 21:39:39 2024 Received: (at 67512) by debbugs.gnu.org; 21 Feb 2024 02:39:39 +0000 Received: from localhost ([127.0.0.1]:47491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rccWI-00057v-Sk for submit@debbugs.gnu.org; Tue, 20 Feb 2024 21:39:39 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:35405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rccWE-00057b-FJ for 67512@debbugs.gnu.org; Tue, 20 Feb 2024 21:39:36 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id C97075C0092; Tue, 20 Feb 2024 21:39:06 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 20 Feb 2024 21:39:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1708483146; x=1708569546; bh=Ls6UyNt4K/aR/CmnwiIRE+k9URdvrGVORHysX6vgloY=; b= SnwBQ7DiDORosPLtB2Afswg4hj9Af6mhMdGJ/EL70NIZNkqt5vjPq9qix7AKnQWN dtc0g1JUfLezbkQtwI/CmioE3lAwYk3eIh06aZFpeZ6PpZxpf1bJ/qwG8j87skpD hLD/nTWKcNWjK9NMSO5u7QgI1u/KmIb9vHfW+yU+njA67qqjcQF9Gf9iJ42dTbRr AFJ7eLQ/gw3a3WB3LtcCn8Y8Zn4vR5K5/YKRv6aa7X/Mk0kJfz2lMu3HIck1rJJL iIfeCvUWsy08WmX44Pdto3APt/wMCVAsFF9iMX9puQxhfqDWTPOt7uUGufm1TJVs 2ZT5PQvbQUQ/sjJlU9PUYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708483146; x= 1708569546; bh=Ls6UyNt4K/aR/CmnwiIRE+k9URdvrGVORHysX6vgloY=; b=h xMItxSmrQkq96qHnGGuUQaleRmCaFi0KTlDQZoazaxjs/j6T6kFvWKZALtNcqrN0 xoPj5kpaQaV8otXSl7MTS1vkTBHV2/WE1qGcfZRqUsVuezgQT9e5bQEiZVeO1gbI zwnP8PXU6uS8DbrdZUD2ToZC9U3y3oZbzs7iD3it9w9FTHCa3Jz459vcUoLX0VLd pJw3xkTExDLetPYS8vhE1PHLGho4CEcKHTWNorqxeW+otnfRhEjALQNLMZfRCHCL Dyf4CG0Xbi2cSY3Qo4pPUUWuFzWqRh5UACqlx1PTnPnjgO6w2fsRBqmDBNhORKNA 2/vCtoO+MGT/0xsy+aQFg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedugdehtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffjgfkgggtgfesthhqredttderjeenucfhrhhomhepkfgrnhcu gfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdrthhvqeenucggtffrrghtthgvrhhnpe fhleevtdeifeffgfegiedvueekudettdevjeffhfelieelfeehgefgudfgieeuhfenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvg htrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 20 Feb 2024 21:39:05 -0500 (EST) References: <39662eaab8ebb73981be67f42a0277c2013be76b.1707855137.git.ian@retrospec.tv> <1808da259ee4755731fade4507812fb3f9ba619e.camel@gmail.com> <87eddgx6y7.fsf@retrospec.tv> <877cj4fpo6.fsf@lassieur.org> <871q9bdpn3.fsf@retrospec.tv> <87ttm2wp84.fsf@lassieur.org> User-agent: mu4e 1.8.13; emacs 28.2 From: Ian Eure To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Subject: Re: [bug#67512] [PATCH v4 3/4] gnu: Add wasm packages. Date: Tue, 20 Feb 2024 18:18:03 -0800 In-reply-to: <87ttm2wp84.fsf@lassieur.org> Message-ID: <87le7e4k3b.fsf@retrospec.tv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, Mark H Weaver , Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) Cl=C3=A9ment Lassieur writes: >> Are you saying you want a process like: >> >> 1a. Get wasm toolchain stuff merged. >> 1b. Get Librewolf merged without WASM sandboxing. >> 2. Update icecat, torbrowser, mullvad, and librewolf to use=20 >> WASM sandboxing. > > Excatly. 1b can be done after 1a, or before 1a. > Is there a technical reason why landing WASM sandboxing support=20 for all browsers in the same patch is desirable? I can intuit=20 none, and as I=E2=80=99m disinclined to either roll back portions of my=20 existing patchset, or work on other browsers, the proposal is=20 disagreeable. I=E2=80=99m fine with splitting off the WASM toolchain stuff into a=20 separate patch, and then merging LibreWolf afterwards. If others=20 would like to add WASM sandboxing to their Firefox-derived=20 browsers afterwards, they are, of course, welcome to. Is there further guidance on where the WASM toolchain packages=20 should be placed? It seemed there was objection to having them in=20 (gnu packages wasm), but nobody has proposed an alternate location=20 or engaged with the options I presented. Thanks, =E2=80=94 Ian From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 21 00:21:53 2024 Received: (at 67512) by debbugs.gnu.org; 21 Feb 2024 05:21:53 +0000 Received: from localhost ([127.0.0.1]:47566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcf3I-0000si-HJ for submit@debbugs.gnu.org; Wed, 21 Feb 2024 00:21:52 -0500 Received: from mail-ej1-f66.google.com ([209.85.218.66]:50524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcf3E-0000sP-Kv for 67512@debbugs.gnu.org; Wed, 21 Feb 2024 00:21:51 -0500 Received: by mail-ej1-f66.google.com with SMTP id a640c23a62f3a-a28a6cef709so733826366b.1 for <67512@debbugs.gnu.org>; Tue, 20 Feb 2024 21:21:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708492820; x=1709097620; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=a3A51aQbIRXboXWwqYmxG4HxpqlCOdvm7iTbKw7pz7A=; b=iAQLVHpxNqkPGNMLRfy8LBgctFOuBB9EfnhuNoofVgrEz5YUWHd+gexmC9YmfQcz8Q tSR/b4sDNPVSYbL8LmpFZGozQITp7Vn0Hz62sXiDYGVLBxXfU4AadzGXurlBuk8vmD9N JzKW0uyBvqpdurjMkCXcyqJclbwAd97mSuJ1g+6oW6t3ukyYi5eLBLQmt+QALZIM3tzp 42osbMpAdgvN3b6jsGcDDWgHWlQLXwPQtjpal/vXhyHB0uqOJ0NeBAeRDDwIDo23OZH8 jraQN8+/uU044Bx2dzb3O1lFE3BLxs16eT4tTeVfJ3i2a/fyLrVKQGEuKqrmmtMLI9nW dwFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708492820; x=1709097620; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=a3A51aQbIRXboXWwqYmxG4HxpqlCOdvm7iTbKw7pz7A=; b=fPwTuj3DIDm9LXkjktlPzhuRTx90xNq1twHj1ofle0S5A1jAxl43gUX2hNEOYs16Ub C3DhXUSsrenI7X4R/OYoZyWlXUkf5Kk0gLT/b4/aOiRumMFr5B1h/d1s2HjkRCaVLsjR TTvtqCiXBWN58ynmYtzSVhnt4r3u+qlqz20K9SbZGt2SGtRYAwU7tQ+BiCHG858SjNBe bx7PdRzJ57YpWMc8hQ3rjJ25mXoR5W/FFYvkjvC6QjNNkTSQ0Swy83NeSI8lXfsEsrQD KunL+8nDXH1NKsB5iAiUCaZsncUt5EqETjFF+Kx4aFHWWuweI3cmuWlqnz55XZ2Z9p3a hx7Q== X-Gm-Message-State: AOJu0YzMgebE+0r+lQ3N3PjF15hzyR+GK9rZb+dY2lWh6Bi6dyaAScxX 2n2624DekChkHRnaBfyIi6xbIk2PGrlI6Zhyr5PJ6Z1NNyIQkDfS/Twx/rF8EIQ= X-Google-Smtp-Source: AGHT+IHj4sKhyLiHEq5E1gJhaBkD82Zi8emWoIqWtdUVFbs2HGjSHID0cv2Wn2x6TOK8p+/7DyGQHA== X-Received: by 2002:a17:906:1982:b0:a3d:c9e9:c7e5 with SMTP id g2-20020a170906198200b00a3dc9e9c7e5mr10036320ejd.61.1708492820421; Tue, 20 Feb 2024 21:20:20 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id se7-20020a170906ce4700b00a3d26a25cbasm4569387ejb.37.2024.02.20.21.20.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 21:20:19 -0800 (PST) Message-ID: <7c457d6001344a781bd51e2716a295235d6ea755.camel@gmail.com> Subject: Re: [bug#67512] [PATCH v4 3/4] gnu: Add wasm packages. From: Liliana Marie Prikler To: Ian Eure , =?ISO-8859-1?Q?Cl=E9ment?= Lassieur Date: Wed, 21 Feb 2024 06:20:17 +0100 In-Reply-To: <87le7e4k3b.fsf@retrospec.tv> References: <39662eaab8ebb73981be67f42a0277c2013be76b.1707855137.git.ian@retrospec.tv> <1808da259ee4755731fade4507812fb3f9ba619e.camel@gmail.com> <87eddgx6y7.fsf@retrospec.tv> <877cj4fpo6.fsf@lassieur.org> <871q9bdpn3.fsf@retrospec.tv> <87ttm2wp84.fsf@lassieur.org> <87le7e4k3b.fsf@retrospec.tv> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, Mark H Weaver X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) Am Dienstag, dem 20.02.2024 um 18:18 -0800 schrieb Ian Eure: > Cl=C3=A9ment Lassieur writes: >=20 > > > Are you saying you want a process like: > > >=20 > > > 1a. Get wasm toolchain stuff merged. > > > 1b. Get Librewolf merged without WASM sandboxing. > > > 2. Update icecat, torbrowser, mullvad, and librewolf to use=20 > > > WASM sandboxing. > >=20 > > Excatly.=C2=A0 1b can be done after 1a, or before 1a. > >=20 >=20 > Is there a technical reason why landing WASM sandboxing support=20 > for all browsers in the same patch is desirable?=C2=A0 I can intuit=20 > none, and as I=E2=80=99m disinclined to either roll back portions of my= =20 > existing patchset, or work on other browsers, the proposal is=20 > disagreeable. I think this ordering is w.r.t. *patch sets*, not patches. I wouldn't suggest dropping four packages into one patch. > I=E2=80=99m fine with splitting off the WASM toolchain stuff into a=20 > separate patch, and then merging LibreWolf afterwards.=C2=A0 If others= =20 > would like to add WASM sandboxing to their Firefox-derived=20 > browsers afterwards, they are, of course, welcome to. >=20 > Is there further guidance on where the WASM toolchain packages=20 > should be placed?=C2=A0 It seemed there was objection to having them in= =20 > (gnu packages wasm), but nobody has proposed an alternate location=20 > or engaged with the options I presented. Unless there's a strong reason not to, I'd place them among the existing ones in (gnu packages web). WDYT? From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 21 06:46:02 2024 Received: (at 67512) by debbugs.gnu.org; 21 Feb 2024 11:46:02 +0000 Received: from localhost ([127.0.0.1]:47961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcl34-0002iT-Cu for submit@debbugs.gnu.org; Wed, 21 Feb 2024 06:46:02 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:49463) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcl31-0002hy-U7 for 67512@debbugs.gnu.org; Wed, 21 Feb 2024 06:46:01 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 91AF43200A24; Wed, 21 Feb 2024 06:45:30 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 21 Feb 2024 06:45:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1708515930; x=1708602330; bh=zh6y96hNnOsc7svfpxKXVkmTx7UnY3CeY0JGYepEOjU=; b= BkvGhAp6Z9GpLLbDn49Tz6dIS/InssgH02JmQ+fSrrNbdEgo0LFEbBTbpF3qHcqa ZCl9aoddwF7V/+lx6+HEmsBlv+ooVrch/fMiKw8z2iFftG1wo1++m4XQSsfntgxZ cZDEq8VYLvxBdVnrC2o9SMN6Y2tLW2fIOEsdLnkfEASlHN1znZ9Z0DaDvPKMAvs0 D0Yqzuo5ffPJ7P5pJYrRlpAMrmPNhRxdn/E4b5L9q68T++a4VQLUnA1FO7XY741Q 4k9IBwyqsnwirePn3QjvLZCbbud5p0emZdeS3NzlkeaUtJPJiDLuIEjGoIdLRLVQ PMl6KCHPswE69XNEivOOtQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708515930; x= 1708602330; bh=zh6y96hNnOsc7svfpxKXVkmTx7UnY3CeY0JGYepEOjU=; b=e soiOhALc3rhBMUues6YBzVAQsijoC4x+zzZnqgnuPt07nWN6xD1jSwxAMxn06EOb +qUqPv9LbjH3M2bhWMCTlbGABRb9j/sNeHbwAllB8PcvggSNFPubTuiNsUyGDMQl ZW9VMrEQGTyoEmkje+l+87Ix2MuO4k7mk3cn8MTsHztQR1khTAbgvuRv6Cbkyyn8 pqm8xh0oSSQvNAN/tEL3Z4xtQAFEOZYJ2YqB16InbuXDts0X85uQQ+8u7UejVGtr LIKu91dqIUycWX2SrwjxdzvFXOb44MMvn5nWOz/KHNvxotUfCxVCla5K/9hNOyWF 77ZOlGEDLgrbmsbRwHDyg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedvgdefvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfgfgggtgfesthhqredttderjeenucfhrhhomhepvehlrohm vghnthcunfgrshhsihgvuhhruceotghlvghmvghntheslhgrshhsihgvuhhrrdhorhhgqe enucggtffrrghtthgvrhhnpeegkeehfefftdefffeuveekgfffhfdtudfgudegueegvefg udetffdugfefhfejudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpegtlhgvmhgvnhhtsehlrghsshhivghurhdrohhrgh X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 21 Feb 2024 06:45:28 -0500 (EST) From: =?utf-8?Q?Cl=C3=A9ment_Lassieur?= To: Liliana Marie Prikler Subject: Re: [bug#67512] [PATCH v4 3/4] gnu: Add wasm packages. In-Reply-To: <7c457d6001344a781bd51e2716a295235d6ea755.camel@gmail.com> (Liliana Marie Prikler's message of "Wed, 21 Feb 2024 06:20:17 +0100") References: <39662eaab8ebb73981be67f42a0277c2013be76b.1707855137.git.ian@retrospec.tv> <1808da259ee4755731fade4507812fb3f9ba619e.camel@gmail.com> <87eddgx6y7.fsf@retrospec.tv> <877cj4fpo6.fsf@lassieur.org> <871q9bdpn3.fsf@retrospec.tv> <87ttm2wp84.fsf@lassieur.org> <87le7e4k3b.fsf@retrospec.tv> <7c457d6001344a781bd51e2716a295235d6ea755.camel@gmail.com> Date: Wed, 21 Feb 2024 12:45:24 +0100 Message-ID: <87frxmqbvv.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, Mark H Weaver , Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) On Wed, Feb 21 2024, Liliana Marie Prikler wrote: > Am Dienstag, dem 20.02.2024 um 18:18 -0800 schrieb Ian Eure: >> Cl=C3=A9ment Lassieur writes: >>=20 >> > > Are you saying you want a process like: >> > >=20 >> > > 1a. Get wasm toolchain stuff merged. >> > > 1b. Get Librewolf merged without WASM sandboxing. >> > > 2. Update icecat, torbrowser, mullvad, and librewolf to use=20 >> > > WASM sandboxing. >> >=20 >> > Excatly.=C2=A0 1b can be done after 1a, or before 1a. >> >=20 >>=20 >> Is there a technical reason why landing WASM sandboxing support=20 >> for all browsers in the same patch is desirable?=C2=A0 I can intuit=20 >> none, and as I=E2=80=99m disinclined to either roll back portions of my= =20 >> existing patchset, or work on other browsers, the proposal is=20 >> disagreeable. > I think this ordering is w.r.t. *patch sets*, not patches. I wouldn't > suggest dropping four packages into one patch. Indeed I've never said it should be done in one patch. I said one-shot as in =E2=80=98symmetrical=E2=80=99: the work required to add Wasm to our b= rowsers should be more or less the same for all browsers, and code duplication should be avoided. >> I=E2=80=99m fine with splitting off the WASM toolchain stuff into a=20 >> separate patch, and then merging LibreWolf afterwards.=C2=A0 If others=20 >> would like to add WASM sandboxing to their Firefox-derived=20 >> browsers afterwards, they are, of course, welcome to. My point is that we need to understand the diff between a browser without wasm, and a browser with wasm. If you add librewolf with wasm already included, we don't have that diff info. And it's harder for us reviewers to understand what in your patch is wasm specific. And it's harder for us to include wasm to our firefox based browsers. I acknowledge it's more work for you, but it's a work that would have to be done otherwise by the reviewer, at least to test the wasm stuff. >> Is there further guidance on where the WASM toolchain packages=20 >> should be placed?=C2=A0 It seemed there was objection to having them in= =20 >> (gnu packages wasm), but nobody has proposed an alternate location=20 >> or engaged with the options I presented. > Unless there's a strong reason not to, I'd place them among the > existing ones in (gnu packages web). > > WDYT? Agreed. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 21 06:50:07 2024 Received: (at 67512) by debbugs.gnu.org; 21 Feb 2024 11:50:07 +0000 Received: from localhost ([127.0.0.1]:47967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcl71-0002vq-3o for submit@debbugs.gnu.org; Wed, 21 Feb 2024 06:50:07 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:50215) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcl6y-0002v4-7a for 67512@debbugs.gnu.org; Wed, 21 Feb 2024 06:50:05 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 0AD1932009F4; Wed, 21 Feb 2024 06:49:35 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 21 Feb 2024 06:49:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1708516175; x=1708602575; bh=mTkEZWCxJoVe5R1QPw3BZJ+dWWfW38HCNbHFgMvSyfs=; b= T856zVB/cMEpTapaOtva+sRkJIqfPoD/2E7+Lc4H8juz4w43WBb4WxB3fCcNy1br 2Qbf8b3jMhFuoWsGTWnkSXwAq12DsfEBDiDjT6kZMhPkFtvyafKtPV/sBfhR3iTQ XroYCeesB5zqGNCFjdmiArniwb4XUQCDT8uZabhsGuLSTjHhYwzJBfdbqwOxq9mW OWLnXAdOa9w/fWRKhlpNbUR4bwr4bp58GI9zF4df50Wz9Gn1xwePOergcm6V4uwT znkF9HHAa/R+oFgx9SLnTwPvfhSTJJU/Nn2yCJH4o3pUfwdeiEVlo2vH4TdEpWgt BcrObWgGqzXy7IYXmN8R6A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708516175; x= 1708602575; bh=mTkEZWCxJoVe5R1QPw3BZJ+dWWfW38HCNbHFgMvSyfs=; b=a K5iDpgYMwmWy0CbYlmYUG+FSE1GAgOItDUTSHT0TLiZegIS6dcaxC2DtatTvoWdf lC76Ed8C85bvT8PCN0G3WIivDFU5l2FQHJrnjq8xOyioQv/8CfZ4jNsgTIb29H6V L7jMQDFd5BKoFjNyfTqm/WLja/hmvRfhs7ziqRU1fm4S2N8mqxfbh2kGRkLT+q1N Ow9z6bsDysANXd9F+njaEAIh6xMs31FyRMuiOcSOSU2+hTA5IuuYfXqZtkro9Hko 7hrm+OvKWtfCz94Ywd3aWpF69yPqEMOO8WlQhBY+byJ3TjdGZ89PClw71Bp2Fh4J X8LZDgjEJZyTY/Mz3odBg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedvgdefvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfgfgggtgfesthhqredttderjeenucfhrhhomhepvehlrohm vghnthcunfgrshhsihgvuhhruceotghlvghmvghntheslhgrshhsihgvuhhrrdhorhhgqe enucggtffrrghtthgvrhhnpeegkeehfefftdefffeuveekgfffhfdtudfgudegueegvefg udetffdugfefhfejudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpegtlhgvmhgvnhhtsehlrghsshhivghurhdrohhrgh X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 21 Feb 2024 06:49:33 -0500 (EST) From: =?utf-8?Q?Cl=C3=A9ment_Lassieur?= To: Ian Eure Subject: Re: [bug#67512] [PATCH v4 1/4] gnu: Move icu4c-73 from gnuzilla to icu4c. In-Reply-To: <878r3jdqe4.fsf@retrospec.tv> (Ian Eure's message of "Sat, 17 Feb 2024 08:07:52 -0800") References: <87ttma53au.fsf@netris.org> <87cyswfqxy.fsf@lassieur.org> <878r3jdqe4.fsf@retrospec.tv> Date: Wed, 21 Feb 2024 12:49:31 +0100 Message-ID: <87bk8aqbp0.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, Mark H Weaver , Jonathan Brielmaier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) On Sat, Feb 17 2024, Ian Eure wrote: > Cl=C3=A9ment Lassieur writes: > >> On Wed, Feb 14 2024, Mark H Weaver wrote: >> >>> Ian Eure writes: >>>> * gnu/packages/icu4c.scm (icu4c-73): New variable. >>>> * gnu/packages/gnuzilla.scm (icu4c-73-promise): Delete variable. >>> >>> The commit log should mention the changes to 'icecat-minimal' and >>> 'make-torbrowser'. Otherwise, looks good to me. >> >> I pushed this one (with small commit message updates), so we can have a >> feeling that things are advancing :) >> > > Thank you. Do you think the nss patch is also mergeable? Do we know why this patch is necessary for librewolf and not for other ESR based browsers? From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 21 09:33:20 2024 Received: (at 67512) by debbugs.gnu.org; 21 Feb 2024 14:33:20 +0000 Received: from localhost ([127.0.0.1]:48060 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcney-0001fg-0B for submit@debbugs.gnu.org; Wed, 21 Feb 2024 09:33:20 -0500 Received: from world.peace.net ([64.112.178.59]:54730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcnev-0001fM-F6 for 67512@debbugs.gnu.org; Wed, 21 Feb 2024 09:33:18 -0500 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rcneS-0008MX-M2; Wed, 21 Feb 2024 09:32:48 -0500 From: Mark H Weaver To: Ian Eure Subject: Re: [bug#67512] [PATCH v4 3/4] gnu: Add wasm packages. In-Reply-To: <87ttm2wp84.fsf@lassieur.org> References: <39662eaab8ebb73981be67f42a0277c2013be76b.1707855137.git.ian@retrospec.tv> <1808da259ee4755731fade4507812fb3f9ba619e.camel@gmail.com> <87eddgx6y7.fsf@retrospec.tv> <877cj4fpo6.fsf@lassieur.org> <871q9bdpn3.fsf@retrospec.tv> <87ttm2wp84.fsf@lassieur.org> Date: Wed, 21 Feb 2024 09:32:37 -0500 Message-ID: <87a5nt51lr.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, Liliana Marie Prikler , =?utf-8?Q?Cl=C3=A9ment?= Lassieur X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) Hi Ian, Cl=C3=A9ment Lassieur asked Ian Eure: > And if you can explain why is Mullvad Browser not "great for daily use" > that would be great. https://logs.guix.gnu.org/guix/2024-02-20.log I see that you also wrote about GNU IceCat in the cited IRC log: ieure (apparently Ian Eure) wrote on the #guix IRC channel: > [...] IceCat, which is weirdware Firefox that won't run non-GPL'd > JavaScript out of the box [...] For the record, this statement is incorrect. IceCat _will_ run "non-GPL'd JavaScript" out of the box. IceCat will, by default, run trivial JavaScript regardless of license, and it will also run nontrivial JavaScript that's marked as having a known free software license. There is no requirement that the JavaScript be covered by the GNU GPL. It's also easy to add sites to the whitelist, or to disable LibreJS entirely. I have no idea what you meant by "weirdware". Can you please explain what you meant by that? Thanks, Mark From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 21 20:15:00 2024 Received: (at 67512) by debbugs.gnu.org; 22 Feb 2024 01:15:00 +0000 Received: from localhost ([127.0.0.1]:60679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcxfv-0004IF-B3 for submit@debbugs.gnu.org; Wed, 21 Feb 2024 20:15:00 -0500 Received: from fout1-smtp.messagingengine.com ([103.168.172.144]:59605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcxfg-0004H9-M9 for 67512@debbugs.gnu.org; Wed, 21 Feb 2024 20:14:58 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.nyi.internal (Postfix) with ESMTP id 6C34F1380095; Wed, 21 Feb 2024 20:14:16 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 21 Feb 2024 20:14:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1708564456; x=1708650856; bh=QD1R609CqNo6Q/a7GKARkOa0lbKbyutVSpepnRcAI68=; b= GXtvWFXzb1xiOzK7b11dy6Z32chS52M/uts1fNB098Xwh6CcB7ocSGyDAj0Ve/Eg oNhm+w0asNBYRQj8q/ok6DcPBoKv1ywYdaDjVYCWvcLinLbBaE/i7R3pCRRDeiKx AvJZpUJDfS4/C+ZFib0xC4Ykp/73RMisPwiefXLpxoE960ujSkfw9rtKa8mJMJNi xgnHCYYJncQtyA55F6ZiiggGznxhP3EN6RNlk0cDevstNwbt4J+GM0Tl1pn39mwu M3DopfdSBtXEkzGfnYmosRsikZiXxSjXPNexWCJJz9dFuKV1sH7NT3U1mdCv5VUR +J5jpf1zJFnxuO4Spo7HLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708564456; x= 1708650856; bh=QD1R609CqNo6Q/a7GKARkOa0lbKbyutVSpepnRcAI68=; b=I 9msh4inh2m+wt5sw0rl1F/MnJNE0nXDIlnud8D3gIVO7Fqsf+fsrRCKVcbJv6+GX 6nuvf2/3Nmim7fkTMB4nYBD9VRniUPEfo5XcLHPKKD4ogsESq+mtVWxo6bsAf1ZD zsC+30p5JBX6b2S+kXK4YZqWfWTnFBwbBL++2Vw2Md1Ua39xv7QMFYEewbUil4um F9hgR9/Z1L2pUU6b2MWUHFNIUByYwKc3OwbaKy+KsyrAG7mDdGSIuyrhF6Kc5vIj jnaRpHzr4ImxEPdhWpY3ckjpsCvU1oNZrOzQWeyW0fjXFR2rCpuEfertY1n0RKAf cKRdYjwBECg1/vzsFlEFg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeefgdefudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffjgfkgggtgfesthhqredttderjeenucfhrhhomhepkfgrnhcu gfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdrthhvqeenucggtffrrghtthgvrhhnpe fhleevtdeifeffgfegiedvueekudettdevjeffhfelieelfeehgefgudfgieeuhfenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvg htrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 21 Feb 2024 20:14:15 -0500 (EST) References: <87ttma53au.fsf@netris.org> <87cyswfqxy.fsf@lassieur.org> <878r3jdqe4.fsf@retrospec.tv> <87bk8aqbp0.fsf@lassieur.org> User-agent: mu4e 1.8.13; emacs 28.2 From: Ian Eure To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Subject: Re: [bug#67512] [PATCH v4 1/4] gnu: Move icu4c-73 from gnuzilla to icu4c. Date: Wed, 21 Feb 2024 17:07:59 -0800 In-reply-to: <87bk8aqbp0.fsf@lassieur.org> Message-ID: <87cysp47x5.fsf@retrospec.tv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, Mark H Weaver , Jonathan Brielmaier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) Cl=C3=A9ment Lassieur writes: > On Sat, Feb 17 2024, Ian Eure wrote: > >> Cl=C3=A9ment Lassieur writes: >> >>> On Wed, Feb 14 2024, Mark H Weaver wrote: >>> >>>> Ian Eure writes: >>>>> * gnu/packages/icu4c.scm (icu4c-73): New variable. >>>>> * gnu/packages/gnuzilla.scm (icu4c-73-promise): Delete=20 >>>>> variable. >>>> >>>> The commit log should mention the changes to 'icecat-minimal'=20 >>>> and >>>> 'make-torbrowser'. Otherwise, looks good to me. >>> >>> I pushed this one (with small commit message updates), so we=20 >>> can have a >>> feeling that things are advancing :) >>> >> >> Thank you. Do you think the nss patch is also mergeable? > > Do we know why this patch is necessary for librewolf and not for=20 > other > ESR based browsers? > LibreWolf is based on standard Firefox releases, not ESR; that may=20 account for it, but I don=E2=80=99t know for sure. Thanks, =E2=80=94 Ian From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 21 20:27:35 2024 Received: (at 67512) by debbugs.gnu.org; 22 Feb 2024 01:27:35 +0000 Received: from localhost ([127.0.0.1]:33451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcxs6-0004wj-SJ for submit@debbugs.gnu.org; Wed, 21 Feb 2024 20:27:35 -0500 Received: from fout1-smtp.messagingengine.com ([103.168.172.144]:48631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcxs1-0004w5-G4 for 67512@debbugs.gnu.org; Wed, 21 Feb 2024 20:27:34 -0500 Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfout.nyi.internal (Postfix) with ESMTP id 7F1CE13800B6; Wed, 21 Feb 2024 20:27:01 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 21 Feb 2024 20:27:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1708565221; x=1708651621; bh=d7n6l1PbF8xOwJKSdjW8ifS2wVYRBR2Ql/LRqitBNPY=; b= sEst9xU1+rgVMqEPmV8Ke9k6bfHf8uk/WmjscIAOQT+SZndw+gHktUOc+9SrLYIh 63wIrrZC4id8y8DJ4fhltdDibOGBesAeCEqAQeWPw5Qu9jTXTnvlP4wN6Roi8wI8 2yt6mpfQ0p8+bZKa9h6rlKF+ATgFQ8R3AjiuBVbjrEDMzbIAXdOhPKslQd+10j0w oRFS4kICSM5OVO1onIwSEpT+reVPp+vUht5qA5sr5xu81JLiACoJ9OOxe8eX3/gE AAhZZSOV3GfDw3LpDXzXP+Q+g6i8l0MR2mSMX8fbUy+MCLk/Wi/bEhA4hKzDdykd vM5ucT3179ePyB3/O8+aJA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708565221; x= 1708651621; bh=d7n6l1PbF8xOwJKSdjW8ifS2wVYRBR2Ql/LRqitBNPY=; b=Z GqgUe0sasuj51GWLV//Bq0qREd+6uHAa0HbzOKZPkmlfjmDcGY7yKvOvvVtkDl1p LnAiCRCFDe13dJsR1QAG4XSHZrXZekV3IOZRx83SPBjVE4R618tqJ7Q7JEsf0ugl LVcZYP5X8xr7DuTPabtzrwEQVMgZUHbFgF94CeG5hjJYwN2D5vh8J4PssNIv4eCc ZIu9A+2c5wRcXRFiuoPQSyOf19A6IgJZe/5qCbD1laVqlOAsIeiJg7KdZiOv1nNb Vv5H5J8JL+MLjZhWF0xr9SpQFVrOWoA4/WJDtyT5j2yoSBa9jhlSPjKcL2aLj4OD uJSVb1tn8M5E6iTL5LFGA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeefgdeffecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffjgfkgggtgfesthhqredttderjeenucfhrhhomhepkfgrnhcu gfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdrthhvqeenucggtffrrghtthgvrhhnpe fhleevtdeifeffgfegiedvueekudettdevjeffhfelieelfeehgefgudfgieeuhfenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvg htrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 21 Feb 2024 20:27:00 -0500 (EST) References: <39662eaab8ebb73981be67f42a0277c2013be76b.1707855137.git.ian@retrospec.tv> <1808da259ee4755731fade4507812fb3f9ba619e.camel@gmail.com> <87eddgx6y7.fsf@retrospec.tv> <877cj4fpo6.fsf@lassieur.org> <871q9bdpn3.fsf@retrospec.tv> <87ttm2wp84.fsf@lassieur.org> <87le7e4k3b.fsf@retrospec.tv> <7c457d6001344a781bd51e2716a295235d6ea755.camel@gmail.com> <87frxmqbvv.fsf@lassieur.org> User-agent: mu4e 1.8.13; emacs 28.2 From: Ian Eure To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Subject: Re: [bug#67512] [PATCH v4 3/4] gnu: Add wasm packages. Date: Wed, 21 Feb 2024 16:07:30 -0800 In-reply-to: <87frxmqbvv.fsf@lassieur.org> Message-ID: <878r3d47bw.fsf@retrospec.tv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, Mark H Weaver , Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) Cl=C3=A9ment Lassieur writes: > On Wed, Feb 21 2024, Liliana Marie Prikler wrote: >> Am Dienstag, dem 20.02.2024 um 18:18 -0800 schrieb Ian Eure: >>> Cl=C3=A9ment Lassieur writes: >>>=20 >>> > > Are you saying you want a process like: >>> > >=20 >>> > > 1a. Get wasm toolchain stuff merged. >>> > > 1b. Get Librewolf merged without WASM sandboxing. >>> > > 2. Update icecat, torbrowser, mullvad, and librewolf to=20 >>> > > use=20 >>> > > WASM sandboxing. >>> >=20 >>> > Excatly.=C2=A0 1b can be done after 1a, or before 1a. >>> >=20 >>>=20 >>> Is there a technical reason why landing WASM sandboxing=20 >>> support=20 >>> for all browsers in the same patch is desirable?=C2=A0 I can intuit=20 >>> none, and as I=E2=80=99m disinclined to either roll back portions of=20 >>> my=20 >>> existing patchset, or work on other browsers, the proposal is=20 >>> disagreeable. >> I think this ordering is w.r.t. *patch sets*, not patches. I=20 >> wouldn't >> suggest dropping four packages into one patch. > > Indeed I've never said it should be done in one patch. I said=20 > one-shot > as in =E2=80=98symmetrical=E2=80=99: the work required to add Wasm to our= =20 > browsers > should be more or less the same for all browsers, and code=20 > duplication > should be avoided. > Forgive me for my imprecision, and thank you for the explanation.=20 Unfortunately, the distinction makes little difference to me, as=20 it still would require me to do work I=E2=80=99m unwilling to do. My=20 unwillingness has less to do with the amount of work than its=20 scope: My goal is to get LibreWolf into Guix, and I simply have no=20 desire or motivation to work on other browsers. I think the best course of action is to reduce scope by removing=20 the WASM component of this patch series entirely. I=E2=80=99d send a new=20 patch series without the WASM toolchain packages, and with WASM=20 sandboxing disabled in the LibreWolf package. The official=20 LibreWolf binaries don=E2=80=99t appear to have this enabled, so no=20 hardening would be sacrified vs. LibreWolf installed any other=20 way. And since I=E2=80=99m not the original author of the WASM packages,=20 and not well-positioned to address problems with them, omitting=20 them seems likely to circumvent difficulties in the review process=20 and support of those. What do you think? Thanks, =E2=80=94 Ian From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 22 05:22:22 2024 Received: (at 67512) by debbugs.gnu.org; 22 Feb 2024 10:22:22 +0000 Received: from localhost ([127.0.0.1]:42703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rd6De-0003H9-E1 for submit@debbugs.gnu.org; Thu, 22 Feb 2024 05:22:22 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:60865) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rd6Db-0003Gn-S3 for 67512@debbugs.gnu.org; Thu, 22 Feb 2024 05:22:20 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id CDEC35C00D0; Thu, 22 Feb 2024 05:21:51 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 22 Feb 2024 05:21:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1708597311; x=1708683711; bh=7cJr69ZvQ0HSoe/UTeNV7UiYMI+C1BRxu89BEhg4Wk0=; b= WqM5oykJfIUGhydR1FjEwuPSN8+88xOLiQ9cPDHVzbLinr3J2EbkPrv1lt1jv4iR 8EFs4bsJ1hBwJ2ZpOfCv6pa/Z9xl3xShcxudJEt+7LzyN6uqbdXMPq3NiarJ8OB6 kF7EcbXETT8Aq/ODXdPRl0UK1XAKYSCFHchvDH6scw30xat4DRXjzfXJY8kjPost EwhXcsxWNNOy204UaaFFlQlCE1VX/A8S6bBAKgzvjvuVadfG93XaExuSby9RQejz 3yv/GQcowa4m+8ReYHYXfeF/dcnn3PCNb3NzbiSmnHsr0AQASUyBCcoXDYCERG/0 zH4wTRhNtgUKHfJ67Dm8iQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708597311; x= 1708683711; bh=7cJr69ZvQ0HSoe/UTeNV7UiYMI+C1BRxu89BEhg4Wk0=; b=o P8ddw71E471XtCSBHade+oLUYlqNpDGioZy5vaJ++0lLepTJ7/qyWurc1zSqbqct HGUfBDKuirF/eK1sBXbwaF84mwo7drgbQmAvaRBdDGrH+CH0ujGJxAh0eL//fIUr AQXMPV1vONuv2ZaAXdkxOleKKzVDqss+DNvp04HeuC7qjmvoNNeDbqSQEbiNe0AR UwstnlczGcsLFItCLOtihPXinKD9DTUyK61mloEEM749vk5NDFHsK067PVNjiGkX zHxZ5mrMyhhkgcvLn4vOfGjO5izkZ9hOWMjLAOjGi8PDM90WY0XHWNylQbA+wMnQ 08fVwD87t25Wrbfg0ENJA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeeggddugecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfgfgggtgfesthhqredttderjeenucfhrhhomhepvehlrohm vghnthcunfgrshhsihgvuhhruceotghlvghmvghntheslhgrshhsihgvuhhrrdhorhhgqe enucggtffrrghtthgvrhhnpeegkeehfefftdefffeuveekgfffhfdtudfgudegueegvefg udetffdugfefhfejudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpegtlhgvmhgvnhhtsehlrghsshhivghurhdrohhrgh X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Feb 2024 05:21:49 -0500 (EST) From: =?utf-8?Q?Cl=C3=A9ment_Lassieur?= To: Ian Eure Subject: Re: [bug#67512] [PATCH v4 1/4] gnu: Move icu4c-73 from gnuzilla to icu4c. In-Reply-To: <87cysp47x5.fsf@retrospec.tv> (Ian Eure's message of "Wed, 21 Feb 2024 17:07:59 -0800") References: <87ttma53au.fsf@netris.org> <87cyswfqxy.fsf@lassieur.org> <878r3jdqe4.fsf@retrospec.tv> <87bk8aqbp0.fsf@lassieur.org> <87cysp47x5.fsf@retrospec.tv> Date: Thu, 22 Feb 2024 11:21:47 +0100 Message-ID: <87y1bcvlxg.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, Mark H Weaver , Jonathan Brielmaier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) On Wed, Feb 21 2024, Ian Eure wrote: > Cl=C3=A9ment Lassieur writes: > >> On Sat, Feb 17 2024, Ian Eure wrote: >> >>> Cl=C3=A9ment Lassieur writes: >>> >>>> On Wed, Feb 14 2024, Mark H Weaver wrote: >>>> >>>>> Ian Eure writes: >>>>>> * gnu/packages/icu4c.scm (icu4c-73): New variable. >>>>>> * gnu/packages/gnuzilla.scm (icu4c-73-promise): Delete variable. >>>>> >>>>> The commit log should mention the changes to 'icecat-minimal' and >>>>> 'make-torbrowser'. Otherwise, looks good to me. >>>> >>>> I pushed this one (with small commit message updates), so we can have a >>>> feeling that things are advancing :) >>>> >>> >>> Thank you. Do you think the nss patch is also mergeable? >> >> Do we know why this patch is necessary for librewolf and not for other >> ESR based browsers? >> > > LibreWolf is based on standard Firefox releases, not ESR; that may accoun= t for > it, but I don=E2=80=99t know for sure. I'm just confused by the description: > + (description > + "Full-featured browser client built from Firefox source tree, witho= ut > +the official icon and the name \"firefox\". This is the Extended Support > +Release (ESR) version.") Cl=C3=A9ment From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 22 05:40:23 2024 Received: (at 67512) by debbugs.gnu.org; 22 Feb 2024 10:40:23 +0000 Received: from localhost ([127.0.0.1]:43924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rd6V4-00045C-Ni for submit@debbugs.gnu.org; Thu, 22 Feb 2024 05:40:23 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:33529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rd6Az-00038b-M4 for 67512@debbugs.gnu.org; Thu, 22 Feb 2024 05:19:39 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 72E205C010D; Thu, 22 Feb 2024 05:19:09 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 22 Feb 2024 05:19:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1708597149; x=1708683549; bh=BHiDZ6uEtWskyqGwYnZMTODrHC1VG+dd+fPIU8G32wI=; b= EoQ2IazIPEHwBeeGydP1sTXmp2bk6cRkqBGGClPoTIZxLuoHZDoFCUnaZpGfIO35 YeQTUN2fZq6n/JkL5Gza+5+v8k48W1sE7sWpZqItXuCMzcQZiY4++iVwReCH7PBx MRojiqZxnvaNSEHgVd9lUQ8yyUidL48YMHvWRYQKuBw6haeOb6dvNelhmfOlASzn SfyWiFMa8DTFBvPc6Gty9s0SJ9KoYwWM42QuaHH0mXz9UDilKVZgEzgjIrVz3b5d 4CPI2lcLFgY9mxibsugsqGlfSeECFPpK6S465qXW7Yw9GZYBY6w28CiPWKYI89g2 oqCzrZErQHqxZkWsU+6pRQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708597149; x= 1708683549; bh=BHiDZ6uEtWskyqGwYnZMTODrHC1VG+dd+fPIU8G32wI=; b=a o2q2SP2utg4p+o4eLZsfTx3SZ+TkNp/mKwnzrLQ38p26ThelmST5i7ApTPdsE0Yz gCmniDLU+m5p7h68UwPwG+16Tyw8a3+OgVYNOYrs2m9GYpG4ZF7peexBXTiT2oRd xIUQpInb1Lfrbr8PCve729oDzsGboJ2wdGj5Pz1TpB51fCdHck6baqEk3rt9zuY4 BHtLx1SvQd2KsSum6t3h5BnaZHN8yFO1JXNkRz36hbMW5l+nSPpN+25NDzn9exTg tfUKwza81CPwfhNG4pU9eX5YXmP2r6BSFZCwfKIz9CX3pe/Aal4ZCHDygCPifykD aP47JnhKc5ubUe5c2M+jQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeeggddufecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfgfgggtgfesthhqredttderjeenucfhrhhomhepvehlrohm vghnthcunfgrshhsihgvuhhruceotghlvghmvghntheslhgrshhsihgvuhhrrdhorhhgqe enucggtffrrghtthgvrhhnpeegkeehfefftdefffeuveekgfffhfdtudfgudegueegvefg udetffdugfefhfejudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpegtlhgvmhgvnhhtsehlrghsshhivghurhdrohhrgh X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Feb 2024 05:19:07 -0500 (EST) From: =?utf-8?Q?Cl=C3=A9ment_Lassieur?= To: Ian Eure Subject: Re: [bug#67512] [PATCH v4 3/4] gnu: Add wasm packages. In-Reply-To: <878r3d47bw.fsf@retrospec.tv> (Ian Eure's message of "Wed, 21 Feb 2024 16:07:30 -0800") References: <39662eaab8ebb73981be67f42a0277c2013be76b.1707855137.git.ian@retrospec.tv> <1808da259ee4755731fade4507812fb3f9ba619e.camel@gmail.com> <87eddgx6y7.fsf@retrospec.tv> <877cj4fpo6.fsf@lassieur.org> <871q9bdpn3.fsf@retrospec.tv> <87ttm2wp84.fsf@lassieur.org> <87le7e4k3b.fsf@retrospec.tv> <7c457d6001344a781bd51e2716a295235d6ea755.camel@gmail.com> <87frxmqbvv.fsf@lassieur.org> <878r3d47bw.fsf@retrospec.tv> Date: Thu, 22 Feb 2024 11:19:03 +0100 Message-ID: <8734tkx0mg.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, Mark H Weaver , Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) On Wed, Feb 21 2024, Ian Eure wrote: > Cl=C3=A9ment Lassieur writes: > >> On Wed, Feb 21 2024, Liliana Marie Prikler wrote: >>> Am Dienstag, dem 20.02.2024 um 18:18 -0800 schrieb Ian Eure: >>>> Cl=C3=A9ment Lassieur writes: >>>> > > Are you saying you want a process like: >>>> > > > > 1a. Get wasm toolchain stuff merged. >>>> > > 1b. Get Librewolf merged without WASM sandboxing. >>>> > > 2. Update icecat, torbrowser, mullvad, and librewolf to > > use = > > >>>> WASM sandboxing. >>>> > > Excatly.=C2=A0 1b can be done after 1a, or before 1a. >>>> > Is there a technical reason why landing WASM sandboxing support for = all >>>> browsers in the same patch is desirable?=C2=A0 I can intuit none, and = as I=E2=80=99m >>>> disinclined to either roll back portions of my existing patchset, or w= ork >>>> on other browsers, the proposal is disagreeable. >>> I think this ordering is w.r.t. *patch sets*, not patches. I wouldn't >>> suggest dropping four packages into one patch. >> >> Indeed I've never said it should be done in one patch. I said one-shot >> as in =E2=80=98symmetrical=E2=80=99: the work required to add Wasm to ou= r browsers >> should be more or less the same for all browsers, and code duplication >> should be avoided. >> > > Forgive me for my imprecision, and thank you for the > explanation. Unfortunately, the distinction makes little difference to me= , as > it still would require me to do work I=E2=80=99m unwilling to do. My unw= illingness > has less to do with the amount of work than its scope: My goal is to get > LibreWolf into Guix, and I simply have no desire or motivation to work on > other browsers. Firefox based browsers are closely related. Sounds impossible to me to really do good work on one of them without touching the other ones. > I think the best course of action is to reduce scope by removing the WASM > component of this patch series entirely. I=E2=80=99d send a new patch se= ries without > the WASM toolchain packages, and with WASM sandboxing disabled in the > LibreWolf package. The official LibreWolf binaries don=E2=80=99t appear = to have this > enabled, so no hardening would be sacrified vs. LibreWolf installed any o= ther > way. And since I=E2=80=99m not the original author of the WASM packages,= and not > well-positioned to address problems with them, omitting them seems likely= to > circumvent difficulties in the review process and support of those. > > What do you think? Sounds good. And we can add WASM later. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 22 09:35:15 2024 Received: (at 67512) by debbugs.gnu.org; 22 Feb 2024 14:35:15 +0000 Received: from localhost ([127.0.0.1]:58659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdAAL-0006dF-H7 for submit@debbugs.gnu.org; Thu, 22 Feb 2024 09:35:15 -0500 Received: from world.peace.net ([64.112.178.59]:59582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdAAJ-0006cs-41 for 67512@debbugs.gnu.org; Thu, 22 Feb 2024 09:35:11 -0500 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rdA9n-0006gZ-9v; Thu, 22 Feb 2024 09:34:39 -0500 From: Mark H Weaver To: Ian Eure Subject: Re: [bug#67512] [PATCH v4 1/4] gnu: Move icu4c-73 from gnuzilla to icu4c. In-Reply-To: <87y1bcvlxg.fsf@lassieur.org> References: <87ttma53au.fsf@netris.org> <87cyswfqxy.fsf@lassieur.org> <878r3jdqe4.fsf@retrospec.tv> <87bk8aqbp0.fsf@lassieur.org> <87cysp47x5.fsf@retrospec.tv> <87y1bcvlxg.fsf@lassieur.org> Date: Thu, 22 Feb 2024 09:34:27 -0500 Message-ID: <8734tk4lf5.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, Jonathan Brielmaier , =?utf-8?Q?Cl=C3=A9ment?= Lassieur X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) Hi Ian, Cl=C3=A9ment Lassieur writes: > I'm just confused by the description: > >> + (description >> + "Full-featured browser client built from Firefox source tree, with= out >> +the official icon and the name \"firefox\". This is the Extended Suppo= rt >> +Release (ESR) version.") The description above, apparently written by you, states that this browser is "Full-featured", and the only differences mentioned between Firefox and Librewolf are that it lacks the "official icon and the name 'firefox'". Note that Firefox does not comply with the GNU FSDG. For example, Firefox supports EME, and that it also steers users towards nonfree software, notably nonfree addons. Therefore Firefox is not included in Guix. Can you tell me more about the differences between Firefox and Librewolf? Thanks, Mark From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 22 20:25:18 2024 Received: (at 67512) by debbugs.gnu.org; 23 Feb 2024 01:25:18 +0000 Received: from localhost ([127.0.0.1]:48948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdKJR-0000f1-Hn for submit@debbugs.gnu.org; Thu, 22 Feb 2024 20:25:18 -0500 Received: from wfout6-smtp.messagingengine.com ([64.147.123.149]:51119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdKFq-0000UZ-2U for 67512@debbugs.gnu.org; Thu, 22 Feb 2024 20:21:36 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.west.internal (Postfix) with ESMTP id 5E0651C0009F; Thu, 22 Feb 2024 20:11:04 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 22 Feb 2024 20:11:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1708650663; x=1708737063; bh=n2u8P09XkPfpKarvewxrBrxIi4ALAMquX/hK2Dt/jj0=; b= sD3ZmxdXdS9j1Gp7I2iERU/kiQC/3M4DV/dbIhhEb0daJH9VmEZKj/8v/9v6fXvM mpZ3XuJ56ucGx37Owg70GRY2YH7Wc/iSb40l58hY+rY1lpZQ9vD6zThUi/codsfN y4XxtNK/o1l5YCWoddkmuUlHMqumIcoYCmTDTrG7xuX8z0G2kbshJI/BycBeqibx wyRHS9PtzZVR4e/gyZwZ5asipT3eZ05ZnB57WFBLTg/6rJui1QUa+9cjkjQrwaud dZgdKrw4XLVu/MKNkYJjY686/BePBHVyZ1/KXoQj9qy4iA6D3iKbLOYcqHrMyZ2i ceNcevyBCH6PCdHz3WuyXg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708650663; x= 1708737063; bh=n2u8P09XkPfpKarvewxrBrxIi4ALAMquX/hK2Dt/jj0=; b=K AgPQno4ZiuBbx0bEmRGtcn96nq1gO6darhGXHABupG3/041qsKfgZDa3utUbYY4H 6S51O1rZIgIyFg6EQ0gnu9IWQ65ZFQWbSH9PZ2CaORifd7IsEHAa4P6qHKlbkXze 5E4JGfvA5is8SWm4zf1dHzGPmdmj0nyzsMhZWg45V1psIZ8I2adDOUaEQmZpsgRG ZFDkNxMV3F01V0WFq2zZTNsJAHLUBk6BrUxIdNmGYPpx0Hhk7oMQ2FIPXlqmEMfT vAvWFgP+ieOGZwfyu56Jm6guI2hpKLmHYE9UKAuTZgI1AwyAeAudXg3+IOiAUIu+ e7MKpECQrMyZEiXvtzGqQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeehgdeftdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffjgfkgggtgfesthhqredttderjeenucfhrhhomhepkfgrnhcu gfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdrthhvqeenucggtffrrghtthgvrhhnpe egudeijeeiheegheeujeetveegtdeugfeikedtleefkeduieelgffgteegudekkeenucff ohhmrghinheplhhisghrvgifohhlfhdrnhgvthenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Feb 2024 20:11:02 -0500 (EST) References: <87ttma53au.fsf@netris.org> <87cyswfqxy.fsf@lassieur.org> <878r3jdqe4.fsf@retrospec.tv> <87bk8aqbp0.fsf@lassieur.org> <87cysp47x5.fsf@retrospec.tv> <87y1bcvlxg.fsf@lassieur.org> <8734tk4lf5.fsf@netris.org> User-agent: mu4e 1.10.8; emacs 29.1 From: Ian Eure To: Mark H Weaver Subject: Re: [bug#67512] [PATCH v4 1/4] gnu: Move icu4c-73 from gnuzilla to icu4c. Date: Thu, 22 Feb 2024 16:56:57 -0800 In-reply-to: <8734tk4lf5.fsf@netris.org> Message-ID: <871q94t26y.fsf@retrospec.tv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, Jonathan Brielmaier , =?utf-8?Q?Cl=C3=A9ment?= Lassieur X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) Hi Mark, Mark H Weaver writes: > Hi Ian, > > Cl=C3=A9ment Lassieur writes: > >> I'm just confused by the description: >> >>> + (description >>> + "Full-featured browser client built from Firefox source=20 >>> tree, without >>> +the official icon and the name \"firefox\". This is the=20 >>> Extended Support >>> +Release (ESR) version.") > > The description above, apparently written by you, states that=20 > this > browser is "Full-featured", and the only differences mentioned=20 > between > Firefox and Librewolf are that it lacks the "official icon and=20 > the name > 'firefox'". > Thank you for bringing this to my attention. This is an artifact=20 of the Firefox package definition I based this on, and isn=E2=80=99t an=20 accurate description of LibreWolf. I=E2=80=99ll correct this in the next=20 version. > Note that Firefox does not comply with the GNU FSDG. For=20 > example, > Firefox supports EME, and that it also steers users towards=20 > nonfree > software, notably nonfree addons. Therefore Firefox is not=20 > included in > Guix. > > Can you tell me more about the differences between Firefox and > Librewolf? > I can=E2=80=99t enumerate every difference; if you have a question about=20 specific feature(s), I=E2=80=99d be happy to answer that. In general: - LibreWolf permits use of their name and logo. - Telemetry is disabled. - User-hostile things like ads for Mozilla VPN are removed. - DRM is disabled by default (but can be enabled by the user). - Default settings have been adjusted for more security and/or=20 privacy. This feature list covers most of the changes:=20 https://librewolf.net/docs/features/ Additionally, the patch I submitted builds LibreWolf without EME=20 support (which is what the other Firefox forks in Guix do); and=20 uses GNU Mozzarella for extensions. Thanks, =E2=80=94 Ian From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 24 19:54:46 2024 Received: (at 67512) by debbugs.gnu.org; 25 Feb 2024 00:54:46 +0000 Received: from localhost ([127.0.0.1]:48069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1re2mz-0007zN-13 for submit@debbugs.gnu.org; Sat, 24 Feb 2024 19:54:46 -0500 Received: from fout5-smtp.messagingengine.com ([103.168.172.148]:51397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1re2mv-0007yi-Pq for 67512@debbugs.gnu.org; Sat, 24 Feb 2024 19:54:43 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfout.nyi.internal (Postfix) with ESMTP id C0F8A138008C; Sat, 24 Feb 2024 19:54:11 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 24 Feb 2024 19:54:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to; s=fm3; t=1708822451; x=1708908851; bh=+NRWJdJiSeRn7e7sWCRJd 8rd/Xf/hnREz/v3zSwZpWQ=; b=sk07AtiYGLZtKJtvtMTFw1JMi2nSFuLrMWavY draHfrBEvag/8d12ErAnEwClPrduqE7OLPX9np+0fVmR4/SXP6TEcv26v+Cm1wpy cNjsKfgIktTCtHqpwP3iPpei7ca91O5pMVTZ3xpeTes7sb52/At02sLfoifcDUgO w80rZaMC3Ssq7LJ6omtI9Qj4zWwtPO4/lS2cU7eqg1hPw9pzCLblDk2Iy4p7MQRg 2tK8dipYxU/hACoLCNMeqQX5I9870+PK8AdqN2//kdgbcHUjTmaWCJb5ejKhY9hL /a9/MBlqe7vsFBmuwxNYQErY/nHjTnJnY7NYWWseJJoaPUXaA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1708822451; x=1708908851; bh=+NRWJdJiSeRn7e7sWCRJd8rd/Xf/ hnREz/v3zSwZpWQ=; b=ba7OA6IaolX8KxIf6CFmPGSXEYbDhmmrIW6CbDeSQnN6 PPODChZZkl3GHLjLDPALZ/u1dvU33sIAeqKEyVS39h/hEPQqCXnCqaMWdWO1cTqq rxEFhcOFmaLUapOKoB5m9NqcllR9sU0gyfawJ6PWFqWcRohKsOZf/wqxU3bcxVS/ UKpcJZKb/hAsPlBRbKFLpntAAuUqq4GKJeElVopGaGIWHQBI+B7DuEaYu5PyaaBd xYpa+r0LdhJ/Y62e1xSpHzo3jCMSAyufe5acBhfhLvku8kRzKIAIdGdazCmnamo9 5uoAbVVFBpPVPF7af1BRo2hVs+7KgNfsiC21ettptQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeelgddvjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgggfestdekredtre dttdenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdrthhv qeenucggtffrrghtthgvrhhnpefhieevleeiudekffehhfelieejtdevleelteeggffghe ekleejhedtgeduvdevgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 24 Feb 2024 19:54:10 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v5 0/2] Add LibreWolf. Date: Sat, 24 Feb 2024 16:53:34 -0800 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Vs. the previous patch series, this: - Corrects package home-page, synopsis, and description. - Removes "firefox" language in comments. - Updates to LibreWolf 123.0-1 and update %librewolf-build-id. - Removes WASM sandboxing, wasi-libc, etc. - Corrects most linter issues. I don't know how to correct the remaining items, or how big a deal they are. Guidance would be appreciated here. Ian Eure (2): gnu: nss: Update to 3.97. gnu: Add librewolf. gnu/packages/certs.scm | 4 +- gnu/packages/librewolf.scm | 638 +++++++++++++++++++++++++++++++++++++ gnu/packages/nss.scm | 6 +- 3 files changed, 643 insertions(+), 5 deletions(-) create mode 100644 gnu/packages/librewolf.scm base-commit: 05bbe9993f687da1fd684a31474c621f2a1c37b2 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 24 19:54:50 2024 Received: (at 67512) by debbugs.gnu.org; 25 Feb 2024 00:54:51 +0000 Received: from localhost ([127.0.0.1]:48076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1re2n3-000801-6K for submit@debbugs.gnu.org; Sat, 24 Feb 2024 19:54:50 -0500 Received: from fout5-smtp.messagingengine.com ([103.168.172.148]:38165) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1re2mx-0007ys-9O for 67512@debbugs.gnu.org; Sat, 24 Feb 2024 19:54:45 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.nyi.internal (Postfix) with ESMTP id B1D071380094; Sat, 24 Feb 2024 19:54:13 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 24 Feb 2024 19:54:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1708822453; x=1708908853; bh=JKthMH4e5oHF+D5kLFSa0fYeg3TIOhDyDzmUvCMXj9E=; b= qN5yPe4axNrj0t6HSFrhndf+XVI5AQf27kBBwuB+7fQr/jgCTgnBYfWqYBz4wCwZ 85KU/cmi0jsFRgYScBttMsQYAXvWXqsdz+bnPSIUeIR2iLSnqAWzrs9ejQLQBYt9 G1pMvQsdVXwot2p/2TTxae4LXWyhB27x7v2WTJQ2mhv6LolV7SFlXyEDZ91WIZBC w4YdcOaqXdKM7phMdWOrU2DwBCh+mxozDGDixnJh+MiQmi3fBoCEKxkdNSbAnt2v iMHm+CxRTUbc3cNXu9Ic6rhAkp2kc67HyVUlJJsKAl0euWZB+Tn+f5ApVd2G9x/E uTS/HgFRDOl0XJp3YmidXQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708822453; x= 1708908853; bh=JKthMH4e5oHF+D5kLFSa0fYeg3TIOhDyDzmUvCMXj9E=; b=A 50PCfbMg37XpqR/hhBdH187vkis+orGFMYyQc5INUskR8jNQ7oChIpx4zb71f1p4 9M/e32969MzWitMXFVSyNKnr+APu5ckvi/fLlKPTOv65njzU2zsR2yt8mOGb31yp PYAPxHH+VQk+26viOw+c+X14RJpPhwqg+P7NmFgBGI0lNuAel+jokYRwbYKNAmer 5PMmT9rX4nsb0HIImj3Pt8o+IJpxT6g4wdK/DH5dX0EuWlN9+SWFwFnnF2UNaT0m 2LiEizxyRsyKASxJYj7TF1WdB6VYFc50Oiliye5J3Fv3IdEshWagS+bwQxaa+eZy ODTeN/ruhn5FNfC3JDo3A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeelgddvjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgjfhggtgfgsehtke ertdertdejnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggt rdhtvheqnecuggftrfgrthhtvghrnhepgfffleevkeeutedvfefgvdfhheeludfhleelie eivedtuddvhfetveelfedvieffnecuffhomhgrihhnpehgnhhurdhorhhgpdhsvggrrhgt hhhfohigrdhorhhgpdhgihhtlhgrsgdrtghomhdptghonhhtvghnthdrrhgvrggupdhmoh iiihhllhgrrdhorhhgpdhgvghtrgguughonhhsrdhsvggrrhgthhdpghgvthgrugguohhn shdrlhhinhhkpdhgihhthhhusgdrtghomhdplhhisghrvgifohhlfhdrnhgvthenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvght rhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 24 Feb 2024 19:54:12 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v5 2/2] gnu: Add librewolf. Date: Sat, 24 Feb 2024 16:53:36 -0800 Message-ID: <7affbd74977d48b8962bebf7a1d76fd05f93a6b0.1708822278.git.ian@retrospec.tv> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/librewolf.scm (librewolf): New variable. Change-Id: I98b6410582b856ede83b79637a58e66d6e5832e6 --- gnu/packages/librewolf.scm | 638 +++++++++++++++++++++++++++++++++++++ 1 file changed, 638 insertions(+) create mode 100644 gnu/packages/librewolf.scm diff --git a/gnu/packages/librewolf.scm b/gnu/packages/librewolf.scm new file mode 100644 index 0000000000..a1f0e984d6 --- /dev/null +++ b/gnu/packages/librewolf.scm @@ -0,0 +1,638 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2013, 2015, 2024 Andreas Enge +;;; Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019 Ludovic Courtès +;;; Copyright © 2014, 2015, 2016, 2017, 2018, 2019, 2020, 2021 Mark H Weaver +;;; Copyright © 2015 Sou Bunnbu +;;; Copyright © 2016, 2017, 2018, 2019 Efraim Flashner +;;; Copyright © 2016 Alex Griffin +;;; Copyright © 2017 Clément Lassieur +;;; Copyright © 2017, 2018 Nikita +;;; Copyright © 2017, 2018 ng0 +;;; Copyright © 2017, 2018, 2020 Tobias Geerinckx-Rice +;;; Copyright © 2018, 2020, 2022 Ricardo Wurmus +;;; Copyright © 2019 Ivan Petkov +;;; Copyright © 2020 Oleg Pykhalov +;;; Copyright © 2020 Jakub Kądziołka +;;; Copyright © 2019, 2020 Adrian Malacoda +;;; Copyright © 2020-2023 Jonathan Brielmaier +;;; Copyright © 2020 Zhu Zihao +;;; Copyright © 2021 pineapples +;;; Copyright © 2021 Brice Waegeneire +;;; Copyright © 2021, 2022, 2023 John Kehayias +;;; Copyright © 2022 Pierre Langlois +;;; Copyright © 2023 Tomas Volf +;;; Copyright © 2023 Ian Eure +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + + +(define-module (gnu packages librewolf) + #:use-module (guix build-system gnu) + #:use-module (guix build-system cargo) + #:use-module (guix build-system trivial) + #:use-module (guix download) + #:use-module ((guix licenses) #:prefix license:) + #:use-module (guix gexp) + #:use-module (guix packages) + #:use-module (guix utils) + #:use-module ((guix build utils) #:select (alist-replace)) + + #:use-module (gnu packages) + #:use-module (gnu packages assembly) + #:use-module (gnu packages autotools) + #:use-module (gnu packages base) + #:use-module (gnu packages bash) + #:use-module (gnu packages compression) + #:use-module (gnu packages crates-io) + #:use-module (gnu packages cups) + #:use-module (gnu packages fontutils) + #:use-module (gnu packages gl) + #:use-module (gnu packages glib) + #:use-module (gnu packages gnome) + #:use-module (gnu packages gtk) + #:use-module (gnu packages hunspell) + #:use-module (gnu packages icu4c) + #:use-module (gnu packages image) + #:use-module (gnu packages jemalloc) + #:use-module (gnu packages kerberos) + #:use-module (gnu packages libcanberra) + #:use-module (gnu packages libevent) + #:use-module (gnu packages libffi) + #:use-module (gnu packages linux) + #:use-module (gnu packages llvm) + #:use-module (gnu packages m4) + #:use-module (gnu packages node) + #:use-module (gnu packages nss) + #:use-module (gnu packages pciutils) + #:use-module (gnu packages perl) + #:use-module (gnu packages pkg-config) + #:use-module (gnu packages pulseaudio) + #:use-module (gnu packages python) + #:use-module (gnu packages rust) + #:use-module (gnu packages rust-apps) + #:use-module (gnu packages speech) + #:use-module (gnu packages sqlite) + #:use-module (gnu packages video) + #:use-module (gnu packages xdisorg) + #:use-module (gnu packages xorg)) + +;; Define the versions of rust needed to build librewolf, trying to match +;; upstream. See the file taskcluster/ci/toolchain/rust.yml at +;; https://searchfox.org under the particular firefox release, like +;; mozilla-esr102. +(define rust-librewolf rust) ; 1.60 is the default in Guix, 1.65 is the minimum. + +;; Update this id with every update to its release date. +;; It's used for cache validation and therefore can lead to strange bugs. +(define %librewolf-build-id "20240224100924") + +(define-public librewolf + (package + (name "librewolf") + (version "123.0-1") + (source + (origin + (method url-fetch) + + (uri (string-append "https://gitlab.com/api/v4/projects/32320088/" + "packages/generic/librewolf-source/" + version + "/librewolf-" + version + ".source.tar.gz")) + (sha256 + (base32 "050kg717jy70fvjfh91aydmq25mqaz6cbf9cqsdsgh6hvpxrw873")))) + (build-system gnu-build-system) + (arguments + (list + #:configure-flags #~(let ((clang #$(this-package-native-input "clang"))) + `("--enable-application=browser" + + ;; Configuration + "--without-wasm-sandboxed-libraries" + "--with-system-jpeg" + "--with-system-zlib" + "--with-system-png" + "--with-system-webp" + "--with-system-icu" + "--with-system-libvpx" + "--with-system-libevent" + "--with-system-ffi" + "--enable-system-pixman" + "--enable-jemalloc" + + ;; see https://bugs.gnu.org/32833 + "--with-system-nspr" + "--with-system-nss" + + ,(string-append "--with-clang-path=" clang + "/bin/clang") + ,(string-append "--with-libclang-path=" clang + "/lib") + + ;; Distribution + "--with-distribution-id=org.guix" + "--with-app-name=librewolf" + "--with-app-basename=LibreWolf" + "--with-branding=browser/branding/librewolf" + + ;; Features + "--disable-tests" + "--disable-updater" + "--enable-pulseaudio" + "--disable-crashreporter" + "--allow-addon-sideload" + "--with-unsigned-addon-scopes=app,system" + "--disable-eme" + + ;; Build details + "--disable-debug" + "--enable-rust-simd" + "--enable-release" + "--enable-optimize" + "--enable-strip" + "--enable-hardening" + "--disable-elf-hack")) + #:imported-modules %cargo-utils-modules + #:modules `((ice-9 regex) + (ice-9 string-fun) + (ice-9 ftw) + (srfi srfi-1) + (srfi srfi-26) + (rnrs bytevectors) + (rnrs io ports) + (guix elf) + (guix build gremlin) + ,@%gnu-build-system-modules) + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'fix-preferences + (lambda* (#:key inputs #:allow-other-keys) + (let ((port (open-file "browser/app/profile/firefox.js" + "a"))) + (define (write-setting key value) + (format port "~%pref(\"~a\", ~a);~%" key value) + (format #t + "fix-preferences: setting value of ~a to ~a~%" key + value)) + + ;; We should allow the sandbox to read the store directory, + ;; because the sandbox has access to /usr on FHS distros. + (write-setting + "security.sandbox.content.read_path_whitelist" + (string-append "\"" + (%store-directory) "/\"")) + + ;; XDG settings should be managed by Guix. + (write-setting "browser.shell.checkDefaultBrowser" + "false") + (close-port port)))) + (add-after 'fix-preferences 'fix-ffmpeg-runtime-linker + (lambda* (#:key inputs #:allow-other-keys) + (let* ((ffmpeg (assoc-ref inputs "ffmpeg")) + (libavcodec (string-append ffmpeg + "/lib/libavcodec.so"))) + ;; Arrange to load libavcodec.so by its absolute file name. + (substitute* "dom/media/platforms/ffmpeg/FFmpegRuntimeLinker.cpp" + (("libavcodec\\.so") + libavcodec))))) + (add-after 'patch-source-shebangs 'patch-cargo-checksums + (lambda _ + (use-modules (guix build cargo-utils)) + (let ((null-hash + ;; This is the SHA256 output of an empty string. + (string-append + "e3b0c44298fc1c149afbf4c8996fb924" + "27ae41e4649b934ca495991b7852b855"))) + (for-each (lambda (file) + (format #t + "patch-cargo-checksums: patching checksums in ~a~%" + file) + (substitute* file + (("(checksum = )\".*\"" all name) + (string-append name "\"" null-hash + "\"")))) + (find-files "." "Cargo\\.lock$")) + (for-each generate-all-checksums + '("build" "dom/media" + "dom/webauthn" + "gfx" + "intl" + "js" + "media" + "modules" + "mozglue/static/rust" + "netwerk" + "remote" + "security/manager/ssl" + "servo" + "storage" + "third_party/rust" + "toolkit" + "xpcom/rust" + "services"))))) + (add-after 'patch-cargo-checksums 'remove-cargo-frozen-flag + (lambda _ + ;; Remove --frozen flag from cargo invokation, otherwise it'll + ;; complain that it's not able to change Cargo.lock. + ;; https://bugzilla.mozilla.org/show_bug.cgi?id=1726373 + (substitute* "build/RunCbindgen.py" + (("\"--frozen\",") + "")))) + (delete 'bootstrap) + (add-before 'configure 'patch-SpeechDispatcherService.cpp + (lambda _ + (let* ((lib "libspeechd.so.2") + (file (string-append + "dom/media/webspeech/synth/" + "speechd/SpeechDispatcherService.cpp")) + (old-content (call-with-input-file file + get-string-all))) + (substitute + file + `((,(format #f "~s" lib) unquote + (lambda (line _) + (string-replace-substring + line lib + (string-append #$speech-dispatcher + "/lib/" lib)))))) + (if (string=? old-content + (call-with-input-file file + get-string-all)) + (error + "substitute did nothing, phase requires an update"))))) + (add-before 'configure 'set-build-id + ;; Build will write the timestamp to output, which is harmful + ;; for reproducibility, so change it to a fixed date. Use a + ;; separate phase for easier modification with inherit. + (lambda _ + (setenv "MOZ_BUILD_DATE" + #$%librewolf-build-id))) + (replace 'configure + (lambda* (#:key inputs outputs configure-flags + #:allow-other-keys) + (setenv "AUTOCONF" + (string-append (assoc-ref inputs "autoconf") + "/bin/autoconf")) + (setenv "SHELL" + (which "bash")) + (setenv "CONFIG_SHELL" + (which "bash")) + (setenv "MACH_BUILD_PYTHON_NATIVE_PACKAGE_SOURCE" + "system") + ;; This should use the host info probably (does it + ;; build on non-x86_64 though?) + (setenv "GUIX_PYTHONPATH" + (string-append (getcwd) + "/obj-x86_64-pc-linux-gnu/_virtualenvs/build")) + + ;; Use Clang, Clang is 2x faster than GCC + (setenv "AR" "llvm-ar") + (setenv "NM" "llvm-nm") + (setenv "CC" "clang") + (setenv "CXX" "clang++") + (setenv "MOZ_NOSPAM" "1") + (setenv "MOZ_APP_NAME" "librewolf") + + (setenv "MOZBUILD_STATE_PATH" + (getcwd)) + + (let* ((mozconfig (string-append (getcwd) "/mozconfig")) + (out (assoc-ref outputs "out")) + (flags (cons (string-append "--prefix=" out) + configure-flags))) + (format #t "build directory: ~s~%" + (getcwd)) + (format #t "configure flags: ~s~%" flags) + + (define write-flags + (lambda flags + (display (string-join (map (cut string-append + "ac_add_options " <>) + flags) "\n")) + (display "\n"))) + (with-output-to-file mozconfig + (lambda () + (apply write-flags flags) + ;; The following option unsets Telemetry + ;; Reporting. With the Addons Fiasco, + ;; Mozilla was found to be collecting + ;; user's data, including saved passwords + ;; and web form data, without users + ;; consent. Mozilla was also found + ;; shipping updates to systems without + ;; the user's knowledge or permission. + ;; As a result of this, use the following + ;; command to permanently disable + ;; telemetry reporting. + (display "unset MOZ_TELEMETRY_REPORTING\n") + (display "mk_add_options MOZ_CRASHREPORTER=0\n") + (display "mk_add_options MOZ_DATA_REPORTING=0\n") + (display + "mk_add_options MOZ_SERVICES_HEALTHREPORT=0") + (display + "mk_add_options MOZ_TELEMETRY_REPORTING=0"))) + (setenv "MOZCONFIG" mozconfig)) + (invoke "./mach" "configure"))) + (add-before 'build '1fix-addons-placeholder + (lambda _ + (substitute* "toolkit/locales/en-US/toolkit/about/aboutAddons.ftl" + (("addons.mozilla.org") + "gnuzilla.gnu.org")))) + (replace 'build + (lambda* (#:key (make-flags '()) + (parallel-build? #t) #:allow-other-keys) + (apply invoke "./mach" "build" + ;; mach will use parallel build if possible by default + `(,@(if parallel-build? + '() + '("-j1")) ,@make-flags)))) + (add-after 'build 'neutralise-store-references + (lambda _ + ;; Mangle the store references to compilers & + ;; other build tools in about:buildconfig, + ;; reducing the package's closure by 1 GiB on + ;; x86-64. + (let* ((build-dir (car (scandir "." + (cut string-prefix? + "obj-" <>)))) + (file (string-append build-dir + "/dist/bin/chrome/toolkit/" + "content/global/buildconfig.html"))) + (substitute* file + (((format #f "(~a/)([0-9a-df-np-sv-z]{32})" + (regexp-quote (%store-directory))) + _ store hash) + (string-append store + (string-take hash 8) + "" + (string-drop hash 8))))))) + (replace 'install + (lambda _ + (invoke "./mach" "install"))) + (add-after 'install 'remove-duplicate-bin + (lambda* (#:key outputs #:allow-other-keys) + (delete-file (string-append #$output + "/lib/librewolf/librewolf-bin")))) + (add-after 'install 'wrap-glxtest + ;; glxtest uses dlopen() to load mesa + ;; libs, wrap it to set LD_LIBRARY_PATH. + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (lib (string-append out "/lib")) + ;; TODO: make me a loop again + (mesa-lib (string-append (assoc-ref inputs + "mesa") + "/lib")) + (pciutils-lib (string-append (assoc-ref inputs + "pciutils") "/lib"))) + (wrap-program (car (find-files lib "^glxtest$")) + `("LD_LIBRARY_PATH" prefix + (,mesa-lib ,pciutils-lib)))))) + (add-after 'install 'patch-config + (lambda* (#:key inputs #:allow-other-keys) + (let ((lib (string-append #$output "/lib/librewolf")) + (config-file "librewolf.cfg")) + + ;; Required for Guix packaged extensions + ;; SCOPE_PROFILE=1, SCOPE_APPLICATION=4, SCOPE_SYSTEM=8 + ;; Default is 5. + (substitute* (in-vicinity lib config-file) + (("defaultPref\\(\"extensions.enabledScopes\", 5\\)") + "defaultPref(\"extensions.enabledScopes\", 13)")) + ;; Use Mozzarella addons repo. + (call-with-port + (open-file + (in-vicinity lib config-file) + "a") + (lambda (port) + ;; Add-ons panel (see settings.js in Icecat source). + (for-each + (lambda (pref) + (format port + "defaultPref(~s, ~s);~%" + (car pref) + (cdr pref))) + '(("extensions.getAddons.search.browseURL" + string-append + "https://gnuzilla.gnu.org/mozzarella/" + "search.php?q=%TERMS%") + ("extensions.getAddons.get.url" . + "https://gnuzilla.gnu.org/mozzarella") + ("extensions.getAddons.link.url" . + "https://gnuzilla.gnu.org/mozzarella") + ("extensions.getAddons.discovery.api_url" . + "https://gnuzilla.gnu.org/mozzarella") + ("extensions.getAddons.langpacks.url" . + "https://gnuzilla.gnu.org/mozzarella") + ("lightweightThemes.getMoreURL" . + "https://gnuzilla.gnu.org/mozzarella")))))))) + (add-after 'install 'wrap-program + (lambda* (#:key inputs outputs #:allow-other-keys) + ;; The following two functions are from Guix's icecat package in + ;; (gnu packages gnuzilla). See commit + ;; b7a0935420ee630a29b7e5ac73a32ba1eb24f00b. + (define (runpath-of lib) + (call-with-input-file lib + (compose elf-dynamic-info-runpath elf-dynamic-info + parse-elf get-bytevector-all))) + (define (runpaths-of-input label) + (let* ((dir (string-append (assoc-ref inputs label) + "/lib")) + (libs (find-files dir "\\.so$"))) + (append-map runpath-of libs))) + (let* ((out (assoc-ref outputs "out")) + (lib (string-append out "/lib")) + ;; TODO: make me a loop again + (mesa-lib (string-append (assoc-ref inputs + "mesa") + "/lib")) + (apng-lib (string-append (assoc-ref inputs + "libpng-apng") "/lib")) + ;; For the integration of native notifications + (libnotify-lib (string-append (assoc-ref inputs + "libnotify") + "/lib")) + ;; For hardware video acceleration via VA-API + (libva-lib (string-append (assoc-ref inputs + "libva") + "/lib")) + ;; VA-API is run in the RDD (Remote Data Decoder) sandbox + ;; and must be explicitly given access to files it needs. + ;; Rather than adding the whole store (as Nix had + ;; upstream do, see + ;; and + ;; linked upstream patches), we can just follow the + ;; runpaths of the needed libraries to add everything to + ;; LD_LIBRARY_PATH. These will then be accessible in the + ;; RDD sandbox. + (rdd-whitelist (map (cut string-append <> "/") + (delete-duplicates (append-map + runpaths-of-input + '("mesa" + "ffmpeg"))))) + (pulseaudio-lib (string-append (assoc-ref inputs + "pulseaudio") + "/lib")) + ;; For U2F and WebAuthn + (eudev-lib (string-append (assoc-ref inputs + "eudev") + "/lib")) + (gtk-share (string-append (assoc-ref inputs + "gtk+") + "/share"))) + (wrap-program (car (find-files lib "^librewolf$")) + `("LD_LIBRARY_PATH" prefix + (,mesa-lib ,libnotify-lib + ,libva-lib + ,pulseaudio-lib + ,eudev-lib + ,apng-lib + ,@rdd-whitelist)) + `("XDG_DATA_DIRS" prefix + (,gtk-share)) + `("MOZ_LEGACY_PROFILES" = + ("1")) + `("MOZ_ALLOW_DOWNGRADE" = + ("1")))))) + (add-after 'wrap-program 'install-desktop-entry + (lambda* (#:key outputs #:allow-other-keys) + (let* ((desktop-file + "taskcluster/docker/firefox-snap/firefox.desktop") + (applications (string-append #$output + "/share/applications"))) + (substitute* desktop-file + (("^Exec=firefox") + (string-append "Exec=" + #$output "/bin/librewolf")) + ;; "Firefox" -> "LibreWolf" everywhere + (("Firefox") + "LibreWolf") + ;; Remove non-Latin translations. + (("^Name\\[(ar|bn)\\].*$") + "") + (("^Icon=.*") + (string-append "Icon=" + #$output + "/share/icons/hicolor/128x128/apps/librewolf.png +")) + ;; These commands were changed. + (("-NewWindow") + "-new-window") + (("-NewPrivateWindow") + "-new-private-window") + (("StartupNotify=true") + "StartupNotify=true +StartupWMClass=Navigator")) + (copy-file desktop-file "librewolf.desktop") + (install-file "librewolf.desktop" applications)))) + (add-after 'install-desktop-entry 'install-icons + (lambda* (#:key outputs #:allow-other-keys) + (let ((icon-source-dir (string-append #$output + "/lib/librewolf/browser/" + "chrome/icons/default"))) + (for-each (lambda (size) + (let ((dest (string-append #$output + "/share/icons/hicolor/" + size + "x" + size + "/apps"))) + (mkdir-p dest) + (symlink (string-append icon-source-dir + "/default" size ".png") + (string-append dest + "/librewolf.png")))) + '("16" "32" "48" "64" "128")))))) + + ;; Test will significantly increase build time but with little rewards. + #:tests? #f + + ;; WARNING: Parallel build will consume lots of memory! + ;; If you have encountered OOM issue in build phase, try disable it. + #:parallel-build? #t + + ;; Some dynamic lib was determined at runtime, so rpath check may fail. + #:validate-runpath? #f)) + (inputs (list bash-minimal + bzip2 + cairo + cups + dbus-glib + freetype + ffmpeg + gdk-pixbuf + glib + gtk+ + gtk+-2 + hunspell + icu4c-73 + jemalloc + libcanberra + libevent + libffi + libgnome + libjpeg-turbo + libnotify + libpng-apng + libva + libvpx + libwebp + libxcomposite + libxft + libxinerama + libxscrnsaver + libxt + mesa + mit-krb5 + nspr + nss + pango + pciutils + pipewire + pixman + pulseaudio + speech-dispatcher + sqlite + startup-notification + eudev + unzip + zip + zlib)) + (native-inputs (list alsa-lib + autoconf-2.13 + `(,rust-librewolf "cargo") + clang + llvm + m4 + nasm + node-lts + perl + pkg-config + python + rust-librewolf + rust-cbindgen-0.26 + which + yasm)) + (home-page "https://librewolf.net/") + (synopsis + "Custom version of Firefox, focused on privacy, security and freedom") + (description + "LibreWolf is designed to increase protection against tracking and +fingerprinting techniques, while also including a few security improvements. +This is achieved through our privacy and security oriented settings and +patches. LibreWolf also aims to remove all the telemetry, data collection and +annoyances, as well as disabling anti-freedom features like DRM.") + (license license:mpl2.0))) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 24 20:01:40 2024 Received: (at 67512) by debbugs.gnu.org; 25 Feb 2024 01:01:40 +0000 Received: from localhost ([127.0.0.1]:48596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1re2tf-0008Sy-CS for submit@debbugs.gnu.org; Sat, 24 Feb 2024 20:01:40 -0500 Received: from fout5-smtp.messagingengine.com ([103.168.172.148]:48285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1re2td-0008SR-2y for 67512@debbugs.gnu.org; Sat, 24 Feb 2024 20:01:37 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.nyi.internal (Postfix) with ESMTP id ADE6D1380091; Sat, 24 Feb 2024 19:54:12 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 24 Feb 2024 19:54:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1708822452; x=1708908852; bh=OP9vnT2CuYajB32UXMqbGR7aHLCogfh6ACoSI8xsRik=; b= M6g0oLURiQ6t/0sYpJ+wB1CxErywyZ3CpKmjjsbmq12zbm5cnp/gVM/Z0uS5syNJ Szg8LEhEramMnNTxXtwEx/b401PEShxxdpKQFVebKTPNaReFMyLwNRRmle7FXq0B FdyDTZEDxx9E22pHYlOnYza0hYfB/vmy526vcMelbOBaNPQN+wAmRJnU0PZ57/GJ 45QjydS4OvExxCWPtgrLAsX4/xdcT1u0qDIS1WWUegOc1dcSwOQtTZG5RZEgwCcR JvpN5jTr5OgDsmaQUZPUEehAShJm841VI4Qa/OprZl+PbAsSfdntdAIVAhARzRg9 gIIQZw6C7J/o5q5JICdh2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708822452; x= 1708908852; bh=OP9vnT2CuYajB32UXMqbGR7aHLCogfh6ACoSI8xsRik=; b=P kBx6K56ZhAYQR19sOTlFZmdvGMPDW/j+Oyr6L1dQp1qFGACHrs6bzGi+mYOC88zb Eh7YmpnLlLI2d6xMc/RKBhlN6M2UTvC9U65pc9X8fAOgtU1qBLx9Y74fpnzELSuW bDYv5hf2BuAW4T1eByB4nTITS6YbkTqfn2ZqaE0nMM1XUvwFA00lQk08G125Dy1K U6CN4/kVBTCJ6og/fNF/77xgqyejSPgAYUS/pRiWZsggdHXeG4MEXNcy4bFPEM1h bP/VMl5VXusEteoz5I9Fzn7PqJ6Z4aTv29plNZtj3VZalf8eybBdAsRjEt3Ewm+m bM4blrfLvWiwH/QZvh6ig== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeelgddvjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgjfhggtgfgsehtke ertdertdejnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggt rdhtvheqnecuggftrfgrthhtvghrnhepjeefffehfeefgeehhfdvkeeigffgiefgveehte ffhedttefffefgudevueevtdffnecuffhomhgrihhnpehmohiiihhllhgrrdhorhhgnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihgrnhesrh gvthhrohhsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 24 Feb 2024 19:54:12 -0500 (EST) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v5 1/2] gnu: nss: Update to 3.97. Date: Sat, 24 Feb 2024 16:53:35 -0800 Message-ID: <6d50ace280feb881bcfb5af5bbc4e661b545c75b.1708822278.git.ian@retrospec.tv> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/nss.scm (nss): Update to 3.97. * gnu/packages/certs.scm (nss-certs): Update to 3.97. --- gnu/packages/certs.scm | 4 ++-- gnu/packages/nss.scm | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gnu/packages/certs.scm b/gnu/packages/certs.scm index 58b4d50ec8..2a6106df78 100644 --- a/gnu/packages/certs.scm +++ b/gnu/packages/certs.scm @@ -131,7 +131,7 @@ (define-public nss-certs ;; XXX We used to refer to the nss package here, but that eventually caused ;; module cycles. The below is a quick copy-paste job that must be kept in ;; sync manually. Surely there's a better way…? - (version "3.88.1") + (version "3.97") (source (origin (method url-fetch) (uri (let ((version-with-underscores @@ -142,7 +142,7 @@ (define-public nss-certs "nss-" version ".tar.gz"))) (sha256 (base32 - "15il9fsmixa1r4446zq1wl627sg0hz9h67w6kjxz273xz3nl7li7")) + "02pscmkp7flawmgwqzr807nsn6kzzw7r7xjbzfql0bpkjf1zp3h7")) ;; Create nss.pc and nss-config. (patches (search-patches "nss-3.56-pkgconfig.patch" "nss-getcwd-nonnull.patch" diff --git a/gnu/packages/nss.scm b/gnu/packages/nss.scm index 54b9e5041a..268ddaa24f 100644 --- a/gnu/packages/nss.scm +++ b/gnu/packages/nss.scm @@ -106,7 +106,7 @@ (define-public nss ;; IMPORTANT: Also update and test the nss-certs package, which duplicates ;; version and source to avoid a top-level variable reference & module ;; cycle. - (version "3.88.1") + (version "3.97") (source (origin (method url-fetch) (uri (let ((version-with-underscores @@ -117,7 +117,7 @@ (define-public nss "nss-" version ".tar.gz"))) (sha256 (base32 - "15il9fsmixa1r4446zq1wl627sg0hz9h67w6kjxz273xz3nl7li7")) + "02pscmkp7flawmgwqzr807nsn6kzzw7r7xjbzfql0bpkjf1zp3h7")) ;; Create nss.pc and nss-config. (patches (search-patches "nss-3.56-pkgconfig.patch" "nss-getcwd-nonnull.patch" @@ -200,7 +200,7 @@ (define-public nss ;; leading to test failures: ;; . To ;; work around that, set the time to roughly the release date. - (invoke "faketime" "2022-11-01" "./nss/tests/all.sh")) + (invoke "faketime" "2024-01-23" "./nss/tests/all.sh")) (format #t "test suite not run~%")))) (replace 'install (lambda* (#:key outputs #:allow-other-keys) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 09 16:23:05 2024 Received: (at 67512) by debbugs.gnu.org; 9 Mar 2024 21:23:05 +0000 Received: from localhost ([127.0.0.1]:34895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rj49p-0002Kc-9c for submit@debbugs.gnu.org; Sat, 09 Mar 2024 16:23:05 -0500 Received: from wfout2-smtp.messagingengine.com ([64.147.123.145]:40669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rj49l-0002K3-Pj for 67512@debbugs.gnu.org; Sat, 09 Mar 2024 16:23:04 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfout.west.internal (Postfix) with ESMTP id 6D6C81C0007E; Sat, 9 Mar 2024 16:22:21 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 09 Mar 2024 16:22:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1710019340; x=1710105740; bh=OGRZsM0rIqkFOFtFxAN66ewADzunYufj2JMgj3C6b9E=; b= UxMnUMcL0kl0/ONpx6S/j4V3+GIyliwAFB52kkAsrr7dRcUh948PEiCLdLakYrc9 baR3CM0Xtfl3x2MpTJ0yd3juntpI26oj37qT7ZI2YwlVq9DoyQHO3+Ev9vGZUkzQ uX0p4FQ+koUfioCGNKgBzbKBfLRjajhN0uMVEMxqnhwSsryYLikJRPcRxcmCiuPK m+YlMAQw0Zw1mx8j1HUml+35oHGG5zO4ZtHj5yNekd6Hg4vYTiKPUkJxEo+Q16Uf KwNcHjFbX8yrgiaa9QOttqdu7wGXkU+VvZlz8v8zEBmtmyAP4jC+5RBqB9xNi8KU fVmm3WPb4bwIlvMCdOslbQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1710019340; x= 1710105740; bh=OGRZsM0rIqkFOFtFxAN66ewADzunYufj2JMgj3C6b9E=; b=e x46NEybArjVH1SMgZZUBpChMTW8yNe6EPqck8Cdpxk63KoCZnKNhxSa8HgTrwbfc /UfjZq2K7katy44j66honCG+53EPWmSyBRUtU++10meiRIY3fyp6MSRJTd7B2Z4r ZKiLdtwrnhPTXC+MlIkSxacqqYXE9KFNL86Bi4A2FlWYTttvQ/h/85YYGi/3iCeH Q+NLtqwBKNpksQdRLLp59Qmk8/Bm0I1HCmT6ciqx2kdXiKWie84petT/a5NymVmq dO8OSsAkZDUZm5J+MOIHjI3sO6B6g+epXih8uZw8yGX9/nfEHIGD4Fjb4rIZWpL5 9OP4na2/3+zW5vBomm3Vw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrieejgddugeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgfgsehtqhertddtreejnecuhfhrohhmpefkrghn ucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggtrdhtvheqnecuggftrfgrthhtvghrnh ephfelvedtieeffffggeeivdeukedutedtveejfffhleeileefheeggfdugfeiuefhnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihgrnhesrh gvthhrohhsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 9 Mar 2024 16:22:19 -0500 (EST) References: <39662eaab8ebb73981be67f42a0277c2013be76b.1707855137.git.ian@retrospec.tv> <1808da259ee4755731fade4507812fb3f9ba619e.camel@gmail.com> <87eddgx6y7.fsf@retrospec.tv> <877cj4fpo6.fsf@lassieur.org> <871q9bdpn3.fsf@retrospec.tv> <87ttm2wp84.fsf@lassieur.org> <87le7e4k3b.fsf@retrospec.tv> <7c457d6001344a781bd51e2716a295235d6ea755.camel@gmail.com> <87frxmqbvv.fsf@lassieur.org> <878r3d47bw.fsf@retrospec.tv> <8734tkx0mg.fsf@lassieur.org> User-agent: mu4e 1.8.13; emacs 28.2 From: Ian Eure To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Subject: Re: [bug#67512] [PATCH v4 3/4] gnu: Add wasm packages. Date: Sat, 09 Mar 2024 13:20:41 -0800 In-reply-to: <8734tkx0mg.fsf@lassieur.org> Message-ID: <87zfv7w16c.fsf@meson> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, Mark H Weaver , Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Just pinging on this. v5 of the patch reduces scope, as we=20 discussed; it=E2=80=99s now just a nss update + addition of LibreWolf. Thanks, =E2=80=94 Ian Cl=C3=A9ment Lassieur writes: > On Wed, Feb 21 2024, Ian Eure wrote: > >> Cl=C3=A9ment Lassieur writes: >> >>> On Wed, Feb 21 2024, Liliana Marie Prikler wrote: >>>> Am Dienstag, dem 20.02.2024 um 18:18 -0800 schrieb Ian Eure: >>>>> Cl=C3=A9ment Lassieur writes: >>>>> > > Are you saying you want a process like: >>>>> > > > > 1a. Get wasm toolchain stuff merged. >>>>> > > 1b. Get Librewolf merged without WASM sandboxing. >>>>> > > 2. Update icecat, torbrowser, mullvad, and librewolf to=20 >>>>> > > > > use > > >>>>> WASM sandboxing. >>>>> > > Excatly.=C2=A0 1b can be done after 1a, or before 1a. >>>>> > Is there a technical reason why landing WASM sandboxing=20 >>>>> > support for all >>>>> browsers in the same patch is desirable?=C2=A0 I can intuit none,=20 >>>>> and as I=E2=80=99m >>>>> disinclined to either roll back portions of my existing=20 >>>>> patchset, or work >>>>> on other browsers, the proposal is disagreeable. >>>> I think this ordering is w.r.t. *patch sets*, not patches. I=20 >>>> wouldn't >>>> suggest dropping four packages into one patch. >>> >>> Indeed I've never said it should be done in one patch. I said=20 >>> one-shot >>> as in =E2=80=98symmetrical=E2=80=99: the work required to add Wasm to o= ur=20 >>> browsers >>> should be more or less the same for all browsers, and code=20 >>> duplication >>> should be avoided. >>> >> >> Forgive me for my imprecision, and thank you for the >> explanation. Unfortunately, the distinction makes little=20 >> difference to me, as >> it still would require me to do work I=E2=80=99m unwilling to do. My=20 >> unwillingness >> has less to do with the amount of work than its scope: My goal=20 >> is to get >> LibreWolf into Guix, and I simply have no desire or motivation=20 >> to work on >> other browsers. > > Firefox based browsers are closely related. Sounds impossible=20 > to me to > really do good work on one of them without touching the other=20 > ones. > >> I think the best course of action is to reduce scope by=20 >> removing the WASM >> component of this patch series entirely. I=E2=80=99d send a new patch=20 >> series without >> the WASM toolchain packages, and with WASM sandboxing disabled=20 >> in the >> LibreWolf package. The official LibreWolf binaries don=E2=80=99t=20 >> appear to have this >> enabled, so no hardening would be sacrified vs. LibreWolf=20 >> installed any other >> way. And since I=E2=80=99m not the original author of the WASM=20 >> packages, and not >> well-positioned to address problems with them, omitting them=20 >> seems likely to >> circumvent difficulties in the review process and support of=20 >> those. >> >> What do you think? > > Sounds good. And we can add WASM later. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 13 05:08:15 2024 Received: (at 67512) by debbugs.gnu.org; 13 Mar 2024 09:08:15 +0000 Received: from localhost ([127.0.0.1]:44707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rkKas-0001dh-Va for submit@debbugs.gnu.org; Wed, 13 Mar 2024 05:08:15 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:7889) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rkKap-0001dO-9K for 67512@debbugs.gnu.org; Wed, 13 Mar 2024 05:08:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:message-id:subject:mime-version: content-transfer-encoding; bh=6fcoiyo8LGWTpfhGU7v+zvL69knVQhm7PNCrVrVvTB4=; b=kyU14ht7GLqm+JrCXTXNeaecai3MmOgzTx4pIn74BYp0Nex76PHR2pPC Zg7mysKLdal5HK5ar3TTQIDPjoJ+MYhcLVIu0lfpNTNTHnXS8TYfNchr6 VNFEmmbVMEyb1SuMSM2HGa+qkACMempCuYOB1Lr14fxTgPsxYuFK4yIGg E=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=Pass smtp.mailfrom=romain.garbage@inria.fr; spf=None smtp.helo=postmaster@zcs2-store5.inria.fr Received-SPF: Pass (mail2-relais-roc.national.inria.fr: domain of romain.garbage@inria.fr designates 128.93.142.15 as permitted sender) identity=mailfrom; client-ip=128.93.142.15; receiver=mail2-relais-roc.national.inria.fr; envelope-from="romain.garbage@inria.fr"; x-sender="romain.garbage@inria.fr"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 include:mailout.safebrands.com a:basic-mail.safebrands.com a:basic-mail01.safebrands.com a:basic-mail02.safebrands.com ip4:128.93.142.0/24 ip4:192.134.164.0/24 ip4:128.93.162.160 ip4:89.107.174.7 mx ~all" Received-SPF: None (mail2-relais-roc.national.inria.fr: no sender authenticity information available from domain of postmaster@zcs2-store5.inria.fr) identity=helo; client-ip=128.93.142.15; receiver=mail2-relais-roc.national.inria.fr; envelope-from="romain.garbage@inria.fr"; x-sender="postmaster@zcs2-store5.inria.fr"; x-conformance=spf_only X-IronPort-AV: E=Sophos;i="6.07,119,1708383600"; d="scan'208";a="156400165" Received: from zcs2-store5.inria.fr ([128.93.142.15]) by mail2-relais-roc.national.inria.fr with ESMTP; 13 Mar 2024 10:07:29 +0100 Date: Wed, 13 Mar 2024 10:07:29 +0100 (CET) From: Romain Garbage To: 67512@debbugs.gnu.org Message-ID: <1236779570.226874.1710320849955.JavaMail.zimbra@inria.fr> Subject: Feedback for Librewolf package MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Originating-IP: [128.93.162.3] X-Mailer: Zimbra 10.0.7_GA_4598 (ZimbraWebClient - FF115 (Linux)/10.0.7_GA_4598) Thread-Index: GEujyKVhqR0QxCfUe1qkOF8xtHpajA== Thread-Topic: Feedback for Librewolf package X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67512 Cc: ian@retrospec.tv X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, I tested the v5 of the patch series, applied on guix master 0547fe862c. Both patches apply and compile cleanly. I then launched Librewolf through `./pre-inst-env guix shell librewolf -- librewolf`. I got an error window with the following error message: "Configuration Error: Failed to read the configuration file. Please contact your system administrator." and the following error messages in console: ``` JavaScript error: librewolf.cfg, line 545: SyntaxError: missing ) in parenthetical JavaScript warning: resource://services-settings/Utils.sys.mjs, line 57: unreachable code after return statement console.error: "formatURLPref: Couldn't get pref: " "startup.homepage_welcome_url.additional" console.error: "Ignoring protocol handler for mailto without a uriTemplate!" console.error: ({}) JavaScript error: resource://activity-stream/lib/TelemetryFeed.jsm, line 1066: Error: Failed to load chrome://pocket/content/pktApi.sys.mjs JavaScript error: resource://gre/modules/PromiseWorker.sys.mjs, line 96: Error: Could not get children of file(/home/romain/.librewolf/rhx67hr4.default/thumbnails) because it does not exist console.error: "about:home startup cache construction failed:" (new TypeError("sectionOrder is undefined", "resource://activity-stream/data/content/activity-stream.bundle.js", 7802)) console.error: "update.locale" " file doesn't exist in either the application or GRE directories" console.error: services.settings: main/search-config Signature failed InvalidSignatureError: Invalid content signature (main/search-config) using 'remote-settings.content-signature.mozilla.org-2024-04-09-14-36-39.chain' console.error: services.settings: main/search-config local data was corrupted console.warn: services.settings: main/search-config Signature verified failed. Retry from scratch ``` After closing the error window, the browser launched properly and could be used to browse the web. I closed it and launched it again and got the same error window, then the browser started again (same behaviour). I tried to install an add-on from `about:addons`, I got redirected to https://addons.mozilla.org eventhough gnuzilla.gnu.org is mentioned in the search bar. The Firefox addons website doesn't recognise Librewolf as a Firefox compatible browser and suggests to install Firefox instead of the addon installation. I don't know if these issues are related to the guix package, although I have been using Librewolf in NixOS during one year as a daily driver and never ran into these issues. If you need more testing or details, feel free to ask :) Have a nice day, Romain From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 15 10:11:17 2024 Received: (at 67512) by debbugs.gnu.org; 15 Mar 2024 14:11:17 +0000 Received: from localhost ([127.0.0.1]:53550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rl8HE-0002JI-FU for submit@debbugs.gnu.org; Fri, 15 Mar 2024 10:11:17 -0400 Received: from wfout7-smtp.messagingengine.com ([64.147.123.150]:44675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rl8H8-0002J0-2j for 67512@debbugs.gnu.org; Fri, 15 Mar 2024 10:11:13 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.west.internal (Postfix) with ESMTP id 708551C000BD; Fri, 15 Mar 2024 10:10:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 15 Mar 2024 10:10:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1710511826; x=1710598226; bh=mla34Fs1/KrpIWWc5oO4YfRjLzaPglcifDEiNvXv7FY=; b= nc3wjX1gG3yHMR7e68BGTrsl9e6PDwJgnWaPFXoBQMLhJpV996UIA3UVJNyl9Gl0 q2NGkiVQT+j7RFoC1D7C4F2LqSHjGqyjXJHNj/6Wxk4ZTQ0dp5US98G4mGJ6+W66 tjm0CvuKIMmXlnkpeNjL88rOEgShLfO8KgJTJZoJ0+3WhXKb6I2BBrXOp8OPCH8s I9qWzpactZ44rWYSFoM3XfImp6M8Zus26HJJ4tdkg4Ra/nfOeGq/PVWiJeYc9Wzd puavL6WN5tlAXzaNfvCLcuTEd4FjYGm6uZS2uFa3LAmguqBaDWEE4kQmbrT0Aqd4 y6KLiaaJ+PqBcbVL9fS8Pg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1710511826; x= 1710598226; bh=mla34Fs1/KrpIWWc5oO4YfRjLzaPglcifDEiNvXv7FY=; b=J ZPSWWk72jeTs8jBXRwyHJ+JUbvysP20UaLMoCCAn9aEuvaAZLcDhLUEiM+4cIBDb LYa8oKhXOWaU1OVzV1tpm6jQ1RqPXAMYLAtiDlAPeWWE3BjZES+BaWSfNzivI4Ww QNo+c6hJurGqExCup2htk845erSf+SujNSzU4FcBPlD19xWEPuNZ+p85azHYlcYk oD8g1MHpToAbKHsI869JR9JwRk4JLlukfrMSKY6d6gTPTUbsRHDPwDxQtiTsvUUK udKdJ6wVSLdQyptqzrKxb92tLVuTJOIWb223DsjIMKoKDq4+sm6lnCyO+WA9ozOs B76zfaOTAxZgCob4BsJzw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrjeelgdeiudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffjgfkgggtgfesthhqredttderjeenucfhrhhomhepkfgrnhcu gfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdrthhvqeenucggtffrrghtthgvrhhnpe dtvefgvedvgefhteegteeugedvvdeitdejkeegkeeigfegveefhfehkeekleeltdenucff ohhmrghinhepmhhoiihilhhlrgdrohhrghdpghhnuhdrohhrghenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggt rdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 15 Mar 2024 10:10:26 -0400 (EDT) References: <1236779570.226874.1710320849955.JavaMail.zimbra@inria.fr> User-agent: mu4e 1.8.13; emacs 28.2 From: Ian Eure To: Romain Garbage Subject: Re: Feedback for Librewolf package Date: Fri, 15 Mar 2024 07:05:18 -0700 In-reply-to: <1236779570.226874.1710320849955.JavaMail.zimbra@inria.fr> Message-ID: <87sf0r1t7y.fsf@retrospec.tv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Romain, This is indeed a bug, I was missing parens around a string-append=20 call, which broke the preferences file. I saw the error you=20 mention, but thought my user preferences were broken in some way=20 by the many short-lived local builds I=E2=80=99ve run. I=E2=80=99ll have a fixed patch soon. Thank you very much for taking the=20 time to try things out and letting me know about this problem. =E2=80=94 Ian Romain Garbage writes: > Hello, > > I tested the v5 of the patch series, applied on guix master=20 > 0547fe862c. > > Both patches apply and compile cleanly. > > I then launched Librewolf through `./pre-inst-env guix shell=20 > librewolf -- librewolf`. > > I got an error window with the following error message:=20 > "Configuration > Error: Failed to read the configuration file. Please contact=20 > your > system administrator." > > and the following error messages in console: > > ``` > JavaScript error: librewolf.cfg, line 545: SyntaxError: missing=20 > ) in parenthetical > JavaScript warning: resource://services-settings/Utils.sys.mjs,=20 > line 57: unreachable code after return statement > console.error: "formatURLPref: Couldn't get pref: "=20 > "startup.homepage_welcome_url.additional" > console.error: "Ignoring protocol handler for mailto without a=20 > uriTemplate!" > console.error: ({}) > JavaScript error:=20 > resource://activity-stream/lib/TelemetryFeed.jsm, line 1066:=20 > Error: Failed to load chrome://pocket/content/pktApi.sys.mjs > JavaScript error: resource://gre/modules/PromiseWorker.sys.mjs,=20 > line > 96: Error: Could not get children of > file(/home/romain/.librewolf/rhx67hr4.default/thumbnails)=20 > because it > does not exist > console.error: "about:home startup cache construction failed:"=20 > (new > TypeError("sectionOrder is undefined", > "resource://activity-stream/data/content/activity-stream.bundle.js", > 7802)) > console.error: "update.locale" " file doesn't exist in either=20 > the application or GRE directories" > console.error: services.settings:=20 > main/search-config Signature failed InvalidSignatureError:=20 > Invalid > content signature (main/search-config) using > 'remote-settings.content-signature.mozilla.org-2024-04-09-14-36-39.chain' > console.error: services.settings:=20 > main/search-config local data was corrupted > console.warn: services.settings: main/search-config Signature=20 > verified failed. Retry from scratch > ``` > > After closing the error window, the browser launched properly=20 > and could be used to browse the web. > > I closed it and launched it again and got the same error window,=20 > then the browser started again (same behaviour). > > I tried to install an add-on from `about:addons`, I got=20 > redirected to > https://addons.mozilla.org eventhough gnuzilla.gnu.org is=20 > mentioned in > the search bar. > The Firefox addons website doesn't recognise Librewolf as a=20 > Firefox > compatible browser and suggests to install Firefox instead of=20 > the > addon installation. > > I don't know if these issues are related to the guix package,=20 > although > I have been using Librewolf in NixOS during one year as a daily=20 > driver > and never ran into these issues. > > If you need more testing or details, feel free to ask :) > > Have a nice day, > Romain > From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 29 18:35:06 2024 Received: (at 67512) by debbugs.gnu.org; 29 Mar 2024 22:35:06 +0000 Received: from localhost ([127.0.0.1]:43587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqKoU-000795-7F for submit@debbugs.gnu.org; Fri, 29 Mar 2024 18:35:06 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:36955) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqKoQ-00077z-TJ for 67512@debbugs.gnu.org; Fri, 29 Mar 2024 18:35:04 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 061E73200258; Fri, 29 Mar 2024 18:34:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 29 Mar 2024 18:34:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :subject:subject:to:to; s=fm1; t=1711751694; x=1711838094; bh=NY uBY2hBcIGZHBW8Ktm2k8ii4IqH7aFijMEDTxT+nvA=; b=GSsiRXOSh6H92agNKk vRmAbEdw/1zHXN1fwi6u+N8nN5AUmEU7KUCR9G/smnVVw6giaD6QpgErKUPjBqZC yOke11rHPu9QI28U2GzpV3V4tm6WzimVeGSRBFY6x4gYlzpU5Vggwf6QmCCbK6w9 Ix+CQxC9R7/gxb2XCd6WwEkPX3QaoxVByLMoDJFLjBzHlIaQpV1OOyJm+sFk4fES mvEY8twRm0/feUqLP4hzYtDILMHwb1FZHYTblduuzV1P6TDJ3czXuk94nl3c3QK1 EafRsQmAU0/Pe1jEqt2SryP1gkfwjnLwGlb97ivfSLk7+ZKYWOpMfyc1sxOG5h2H UqAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1711751694; x=1711838094; bh=NYuBY2hBcIGZH BW8Ktm2k8ii4IqH7aFijMEDTxT+nvA=; b=t0zPlNEC47dKOV+OcAcUKR0XdWLm5 VM36ZOZEeU5aUFtX8pwP6loUUfDuUDNoHtzH3IsE1d9xPxhTTFkpRJiEjZNjr2M8 8d4g9eAz8svrGYJv9aH6FTNYh5cElQ9cPMxzQB7lUkxRRJvHrhoy1lnIwQvLGaae 7xN1HjJe+WEh14p9DarEFcG0SQApdbkIzaWb/vcM1R2neyE9GyA5UxR3tSdyjFm+ jteHMHqbxjBDiAqQmw4Iw4TGihxtmcKX8nDhAMbrnVVjox0HU8Y3dxiFaxJ8VI3R aGfKihZcDcNo5+QJ4KV7D8A9uceqeU3geUmAN7v2ilMdhbHB+jr+UtYbA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddvfecutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofggtgfgsehtkeertdertd ejnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggtrdhtvheq necuggftrfgrthhtvghrnhepgfeukeffjedugfdvveetleetiedtueduudffhfeuhfeihf ejteeuhffgteetvdetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepihgrnhesrhgvthhrohhsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 29 Mar 2024 18:34:53 -0400 (EDT) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v6 0/2] Add LibreWolf Date: Fri, 29 Mar 2024 15:34:41 -0700 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) - Updates LibreWolf to 124.0.1-1, which fixes numerous important security issues from upstream Firefox 123.x and 124.0. - Updates nss to 3.98, required by LW 124.0.1-1. - Corrects wrong string-append which broke the preferences file. - Correct typo’d phase name '1fix-addons-placeholder to 'fix-addons-placeholder. - Turn code flagged with "TODO turn me back into a loop" back into a loop. Ian Eure (2): gnu: nss: Update to 3.98. gnu: Add librewolf. gnu/packages/certs.scm | 4 +- gnu/packages/librewolf.scm | 621 +++++++++++++++++++++++++++++++++++++ gnu/packages/nss.scm | 6 +- 3 files changed, 626 insertions(+), 5 deletions(-) create mode 100644 gnu/packages/librewolf.scm base-commit: 423ca234cbd7b4902fd2a3fbc089a6fd57ed5583 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 29 18:35:11 2024 Received: (at 67512) by debbugs.gnu.org; 29 Mar 2024 22:35:11 +0000 Received: from localhost ([127.0.0.1]:43592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqKoY-00079N-IZ for submit@debbugs.gnu.org; Fri, 29 Mar 2024 18:35:11 -0400 Received: from wfout4-smtp.messagingengine.com ([64.147.123.147]:37453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqKoS-00078Q-RG for 67512@debbugs.gnu.org; Fri, 29 Mar 2024 18:35:05 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.west.internal (Postfix) with ESMTP id 7BD8E1C000E6; Fri, 29 Mar 2024 18:34:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 29 Mar 2024 18:34:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1711751697; x=1711838097; bh=13pnBPxZ+ZOOSnuvJ+jQ/WqAR41IEOWYTOZzGWNdrME=; b= r27EgSJesqdMRr0b2tM6EZVyB0w7sieOAdCD+gzk02/IPvjqFR1Tq9FNJtnwsaa2 Tyc/AVeF/HU1Melaq/U0ykjmJXvgE8xGgrMN9UVGGzdqEW5DyyksJHSVBNsorxUb ZBRFyMvOeg1h7dOdJ+qbZmOVa0zx8FLwVUOlWGq4DdsGJHDwXG6Ws50GCSPSc8kM jkJjLpgSj80PuRlFG7ETLH2MBBK6aGYUtqaDLuGTaLXdmIHyq2rZJ2DmG9OseYLW cUgCaMgI56VnVdQAqbCAXVPfSUXtL3V7z9lPzoEqxdVc2URCpm1gteqswAxLWnya BrnIAMrirCVcga6isFVZfg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1711751697; x= 1711838097; bh=13pnBPxZ+ZOOSnuvJ+jQ/WqAR41IEOWYTOZzGWNdrME=; b=n iTDYPXzoA03Ts/Exuy2JqXs/3NaFChjuHLpioJ4vxRIwTehZojwIiFcPotQXEK0D bl1Vh0PQJ5QFKqobjJAJ3ZABmydkS2ybvNnG5NFX/hhbtbPHmEpH9vUoIFwtE2oU 3v45kbP/wkvsardmb9Xn33XjFHQgldNsKNh/XuSTU3MUoAzpqzPfgeNNXoZgdkOu +Z/oN9afJu2jdNIROSIf0vn4pCsQZ4FuwbUkqxEVQLUBia9Sf2l8SL261Mz12Am3 ADNF608Hb6u8eY/l+Y4wXphGprSbTbqQUifExhvWa4qQBhHmp8Qq97zAR5kGLocp z790dT3SuTYlqnZY4ajcw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddvfecutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgjfhggtgfgsehtkeertd ertdejnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggtrdht vheqnecuggftrfgrthhtvghrnhepjeefffehfeefgeehhfdvkeeigffgiefgveehteffhe dttefffefgudevueevtdffnecuffhomhgrihhnpehmohiiihhllhgrrdhorhhgnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihgrnhesrhgvth hrohhsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 29 Mar 2024 18:34:55 -0400 (EDT) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v6 1/2] gnu: nss: Update to 3.98. Date: Fri, 29 Mar 2024 15:34:42 -0700 Message-ID: X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/nss.scm (nss): Update to 3.98. * gnu/packages/certs.scm (nss-certs): Update to 3.98. Change-Id: I443ffb49cffa0985d9c3aa3e9990575ba11edf8a --- gnu/packages/certs.scm | 4 ++-- gnu/packages/nss.scm | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gnu/packages/certs.scm b/gnu/packages/certs.scm index 58b4d50ec8..b8d849f49d 100644 --- a/gnu/packages/certs.scm +++ b/gnu/packages/certs.scm @@ -131,7 +131,7 @@ (define-public nss-certs ;; XXX We used to refer to the nss package here, but that eventually caused ;; module cycles. The below is a quick copy-paste job that must be kept in ;; sync manually. Surely there's a better way…? - (version "3.88.1") + (version "3.98") (source (origin (method url-fetch) (uri (let ((version-with-underscores @@ -142,7 +142,7 @@ (define-public nss-certs "nss-" version ".tar.gz"))) (sha256 (base32 - "15il9fsmixa1r4446zq1wl627sg0hz9h67w6kjxz273xz3nl7li7")) + "1kh98amfklrq6915n4mlbrcqghc3srm7rkzs9dkh21jwscrwqjgm")) ;; Create nss.pc and nss-config. (patches (search-patches "nss-3.56-pkgconfig.patch" "nss-getcwd-nonnull.patch" diff --git a/gnu/packages/nss.scm b/gnu/packages/nss.scm index 54b9e5041a..fafc377b0b 100644 --- a/gnu/packages/nss.scm +++ b/gnu/packages/nss.scm @@ -106,7 +106,7 @@ (define-public nss ;; IMPORTANT: Also update and test the nss-certs package, which duplicates ;; version and source to avoid a top-level variable reference & module ;; cycle. - (version "3.88.1") + (version "3.98") (source (origin (method url-fetch) (uri (let ((version-with-underscores @@ -117,7 +117,7 @@ (define-public nss "nss-" version ".tar.gz"))) (sha256 (base32 - "15il9fsmixa1r4446zq1wl627sg0hz9h67w6kjxz273xz3nl7li7")) + "1kh98amfklrq6915n4mlbrcqghc3srm7rkzs9dkh21jwscrwqjgm")) ;; Create nss.pc and nss-config. (patches (search-patches "nss-3.56-pkgconfig.patch" "nss-getcwd-nonnull.patch" @@ -200,7 +200,7 @@ (define-public nss ;; leading to test failures: ;; . To ;; work around that, set the time to roughly the release date. - (invoke "faketime" "2022-11-01" "./nss/tests/all.sh")) + (invoke "faketime" "2024-01-23" "./nss/tests/all.sh")) (format #t "test suite not run~%")))) (replace 'install (lambda* (#:key outputs #:allow-other-keys) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 29 18:35:12 2024 Received: (at 67512) by debbugs.gnu.org; 29 Mar 2024 22:35:12 +0000 Received: from localhost ([127.0.0.1]:43594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqKoZ-00079P-2E for submit@debbugs.gnu.org; Fri, 29 Mar 2024 18:35:12 -0400 Received: from wfout4-smtp.messagingengine.com ([64.147.123.147]:33433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqKoV-00078T-5F for 67512@debbugs.gnu.org; Fri, 29 Mar 2024 18:35:09 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.west.internal (Postfix) with ESMTP id B17921C000E7; Fri, 29 Mar 2024 18:34:59 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 29 Mar 2024 18:34:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1711751699; x=1711838099; bh=2AHEQJJp2GDa5xX5iV35zvHCX6HUR7eKfNkLbsDDCtc=; b= hZp6xPsMbWm0/VJSh4pym4/IbzcfNMmLqFb2jFp2JIfH7F9vfJLZNo06X9K2M7Pw 1ZDI4MMbHPeigCce7kQ26Ex3OQ7gxLn1FV0J95Z3myJIJDTeEHk+lNv9upevp6KL vcNFG4YYtK1qoZK1wmd2nC5RGuFZwSbMAZ1fmw7/i5LcKXrNJpnPzi+RNtIJVxLL +fsYcxX75NiYN070V38qPiAg9wuVT/0hfI2+phQX+m3mviv/QmveM3kappGHawJR St5p3nVrxqjHw4b38SlKN/429zH9usTMqbMV6mRuKf6MlWqRd013PjNHIhF1m8o8 JqrXRAk1LgT3z8wyn9Fm9A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1711751699; x= 1711838099; bh=2AHEQJJp2GDa5xX5iV35zvHCX6HUR7eKfNkLbsDDCtc=; b=B DTEiL4HwzvvrMsBSfro0/ZpMfViuTmvmaLjeom6w/PVGY2vXuloaWdodAgv7UTJP qyfO3t9XkZqbWcGc7ansS33a+NjPFmJP2etVNHawDcirGW+J5ugvnNAo7r2Ec7Bu 17yvlzfTEPwOCC/1c8X5tbp8skyBQM1PMFLfowNDi972n8c5W0MFxmUtFsi0B2JL i4SIyGegWZOdJX/qUmne7QcBiooQJk9/jzScfJ56xhirYgeHROnFs075lLQ8cfCT xx2Ax9Pqkm/mIxIitIk4PHLw+wd7D+cJCQyMYwRbuyeysZFfqTAGFrDUWFzJo+Yc bufhSLP4e/apu9TomBZYQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddvfecutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgjfhggtgfgsehtkeertd ertdejnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggtrdht vheqnecuggftrfgrthhtvghrnhepgfffleevkeeutedvfefgvdfhheeludfhleelieeive dtuddvhfetveelfedvieffnecuffhomhgrihhnpehgnhhurdhorhhgpdhsvggrrhgthhhf ohigrdhorhhgpdhgihhtlhgrsgdrtghomhdptghonhhtvghnthdrrhgvrggupdhmohiiih hllhgrrdhorhhgpdhgvghtrgguughonhhsrdhsvggrrhgthhdpghgvthgrugguohhnshdr lhhinhhkpdhgihhthhhusgdrtghomhdplhhisghrvgifohhlfhdrnhgvthenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvghtrhho shhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 29 Mar 2024 18:34:58 -0400 (EDT) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v6 2/2] gnu: Add librewolf. Date: Fri, 29 Mar 2024 15:34:43 -0700 Message-ID: <3d9dfa681c4b4acfdccaf46fb34d345013f1f5bc.1711751402.git.ian@retrospec.tv> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/librewolf.scm (librewolf): New variable. Change-Id: I98b6410582b856ede83b79637a58e66d6e5832e6 --- gnu/packages/librewolf.scm | 621 +++++++++++++++++++++++++++++++++++++ 1 file changed, 621 insertions(+) create mode 100644 gnu/packages/librewolf.scm diff --git a/gnu/packages/librewolf.scm b/gnu/packages/librewolf.scm new file mode 100644 index 0000000000..2b20b90655 --- /dev/null +++ b/gnu/packages/librewolf.scm @@ -0,0 +1,621 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2013, 2015, 2024 Andreas Enge +;;; Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019 Ludovic Courtès +;;; Copyright © 2014, 2015, 2016, 2017, 2018, 2019, 2020, 2021 Mark H Weaver +;;; Copyright © 2015 Sou Bunnbu +;;; Copyright © 2016, 2017, 2018, 2019 Efraim Flashner +;;; Copyright © 2016 Alex Griffin +;;; Copyright © 2017 Clément Lassieur +;;; Copyright © 2017, 2018 Nikita +;;; Copyright © 2017, 2018 ng0 +;;; Copyright © 2017, 2018, 2020 Tobias Geerinckx-Rice +;;; Copyright © 2018, 2020, 2022 Ricardo Wurmus +;;; Copyright © 2019 Ivan Petkov +;;; Copyright © 2020 Oleg Pykhalov +;;; Copyright © 2020 Jakub Kądziołka +;;; Copyright © 2019, 2020 Adrian Malacoda +;;; Copyright © 2020-2023 Jonathan Brielmaier +;;; Copyright © 2020 Zhu Zihao +;;; Copyright © 2021 pineapples +;;; Copyright © 2021 Brice Waegeneire +;;; Copyright © 2021, 2022, 2023 John Kehayias +;;; Copyright © 2022 Pierre Langlois +;;; Copyright © 2023 Tomas Volf +;;; Copyright © 2023 Ian Eure +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + + +(define-module (gnu packages librewolf) + #:use-module (guix build-system gnu) + #:use-module (guix build-system cargo) + #:use-module (guix build-system trivial) + #:use-module (guix download) + #:use-module ((guix licenses) #:prefix license:) + #:use-module (guix gexp) + #:use-module (guix packages) + #:use-module (guix utils) + #:use-module ((guix build utils) #:select (alist-replace)) + + #:use-module (gnu packages) + #:use-module (gnu packages assembly) + #:use-module (gnu packages autotools) + #:use-module (gnu packages base) + #:use-module (gnu packages bash) + #:use-module (gnu packages compression) + #:use-module (gnu packages crates-io) + #:use-module (gnu packages cups) + #:use-module (gnu packages fontutils) + #:use-module (gnu packages gl) + #:use-module (gnu packages glib) + #:use-module (gnu packages gnome) + #:use-module (gnu packages gtk) + #:use-module (gnu packages hunspell) + #:use-module (gnu packages icu4c) + #:use-module (gnu packages image) + #:use-module (gnu packages jemalloc) + #:use-module (gnu packages kerberos) + #:use-module (gnu packages libcanberra) + #:use-module (gnu packages libevent) + #:use-module (gnu packages libffi) + #:use-module (gnu packages linux) + #:use-module (gnu packages llvm) + #:use-module (gnu packages m4) + #:use-module (gnu packages node) + #:use-module (gnu packages nss) + #:use-module (gnu packages pciutils) + #:use-module (gnu packages perl) + #:use-module (gnu packages pkg-config) + #:use-module (gnu packages pulseaudio) + #:use-module (gnu packages python) + #:use-module (gnu packages rust) + #:use-module (gnu packages rust-apps) + #:use-module (gnu packages speech) + #:use-module (gnu packages sqlite) + #:use-module (gnu packages video) + #:use-module (gnu packages xdisorg) + #:use-module (gnu packages xorg)) + +;; Define the versions of rust needed to build librewolf, trying to match +;; upstream. See the file taskcluster/ci/toolchain/rust.yml at +;; https://searchfox.org under the particular firefox release, like +;; mozilla-esr102. +(define rust-librewolf rust) ; 1.60 is the default in Guix, 1.65 is the minimum. + +;; Update this id with every update to its release date. +;; It's used for cache validation and therefore can lead to strange bugs. +;; ex: date '+%Y%m%d%H%M%S' +(define %librewolf-build-id "20240326080003") + +(define-public librewolf + (package + (name "librewolf") + (version "124.0.1-1") + (source + (origin + (method url-fetch) + + (uri (string-append "https://gitlab.com/api/v4/projects/32320088/" + "packages/generic/librewolf-source/" + version + "/librewolf-" + version + ".source.tar.gz")) + (sha256 + (base32 "1sks49nywzhvq5mik4ipm3vyyxv49s9hq6bfyk5d9r6f0nlydllf")))) + (build-system gnu-build-system) + (arguments + (list + #:configure-flags #~(let ((clang #$(this-package-native-input "clang"))) + `("--enable-application=browser" + + ;; Configuration + "--without-wasm-sandboxed-libraries" + "--with-system-jpeg" + "--with-system-zlib" + "--with-system-png" + "--with-system-webp" + "--with-system-icu" + "--with-system-libvpx" + "--with-system-libevent" + "--with-system-ffi" + "--enable-system-pixman" + "--enable-jemalloc" + + ;; see https://bugs.gnu.org/32833 + "--with-system-nspr" + "--with-system-nss" + + ,(string-append "--with-clang-path=" clang + "/bin/clang") + ,(string-append "--with-libclang-path=" clang + "/lib") + + ;; Distribution + "--with-distribution-id=org.guix" + "--with-app-name=librewolf" + "--with-app-basename=LibreWolf" + "--with-branding=browser/branding/librewolf" + + ;; Features + "--disable-tests" + "--disable-updater" + "--enable-pulseaudio" + "--disable-crashreporter" + "--allow-addon-sideload" + "--with-unsigned-addon-scopes=app,system" + "--disable-eme" + + ;; Build details + "--disable-debug" + "--enable-rust-simd" + "--enable-release" + "--enable-optimize" + "--enable-strip" + "--enable-hardening" + "--disable-elf-hack")) + #:imported-modules %cargo-utils-modules + #:modules `((ice-9 regex) + (ice-9 string-fun) + (ice-9 ftw) + (srfi srfi-1) + (srfi srfi-26) + (rnrs bytevectors) + (rnrs io ports) + (guix elf) + (guix build gremlin) + ,@%gnu-build-system-modules) + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'fix-preferences + (lambda* (#:key inputs #:allow-other-keys) + (let ((port (open-file "browser/app/profile/firefox.js" + "a"))) + (define (write-setting key value) + (format port "~%pref(\"~a\", ~a);~%" key value) + (format #t + "fix-preferences: setting value of ~a to ~a~%" key + value)) + + ;; We should allow the sandbox to read the store directory, + ;; because the sandbox has access to /usr on FHS distros. + (write-setting + "security.sandbox.content.read_path_whitelist" + (string-append "\"" + (%store-directory) "/\"")) + + ;; XDG settings should be managed by Guix. + (write-setting "browser.shell.checkDefaultBrowser" + "false") + (close-port port)))) + (add-after 'fix-preferences 'fix-ffmpeg-runtime-linker + (lambda* (#:key inputs #:allow-other-keys) + (let* ((ffmpeg (assoc-ref inputs "ffmpeg")) + (libavcodec (string-append ffmpeg + "/lib/libavcodec.so"))) + ;; Arrange to load libavcodec.so by its absolute file name. + (substitute* "dom/media/platforms/ffmpeg/FFmpegRuntimeLinker.cpp" + (("libavcodec\\.so") + libavcodec))))) + (add-after 'patch-source-shebangs 'patch-cargo-checksums + (lambda _ + (use-modules (guix build cargo-utils)) + (let ((null-hash + ;; This is the SHA256 output of an empty string. + (string-append + "e3b0c44298fc1c149afbf4c8996fb924" + "27ae41e4649b934ca495991b7852b855"))) + (for-each (lambda (file) + (format #t + "patch-cargo-checksums: patching checksums in ~a~%" + file) + (substitute* file + (("(checksum = )\".*\"" all name) + (string-append name "\"" null-hash + "\"")))) + (find-files "." "Cargo\\.lock$")) + (for-each generate-all-checksums + '("build" "dom/media" + "dom/webauthn" + "gfx" + "intl" + "js" + "media" + "modules" + "mozglue/static/rust" + "netwerk" + "remote" + "security/manager/ssl" + "servo" + "storage" + "third_party/rust" + "toolkit" + "xpcom/rust" + "services"))))) + (add-after 'patch-cargo-checksums 'remove-cargo-frozen-flag + (lambda _ + ;; Remove --frozen flag from cargo invokation, otherwise it'll + ;; complain that it's not able to change Cargo.lock. + ;; https://bugzilla.mozilla.org/show_bug.cgi?id=1726373 + (substitute* "build/RunCbindgen.py" + (("args.append\\(\"--frozen\"\\)") "pass")))) + (delete 'bootstrap) + (add-before 'configure 'patch-SpeechDispatcherService.cpp + (lambda _ + (let* ((lib "libspeechd.so.2") + (file (string-append + "dom/media/webspeech/synth/" + "speechd/SpeechDispatcherService.cpp")) + (old-content (call-with-input-file file + get-string-all))) + (substitute + file + `((,(format #f "~s" lib) unquote + (lambda (line _) + (string-replace-substring + line lib + (string-append #$speech-dispatcher + "/lib/" lib)))))) + (if (string=? old-content + (call-with-input-file file + get-string-all)) + (error + "substitute did nothing, phase requires an update"))))) + (add-before 'configure 'set-build-id + ;; Build will write the timestamp to output, which is harmful + ;; for reproducibility, so change it to a fixed date. Use a + ;; separate phase for easier modification with inherit. + (lambda _ + (setenv "MOZ_BUILD_DATE" + #$%librewolf-build-id))) + (replace 'configure + (lambda* (#:key inputs outputs configure-flags + #:allow-other-keys) + (setenv "AUTOCONF" + (string-append (assoc-ref inputs "autoconf") + "/bin/autoconf")) + (setenv "SHELL" + (which "bash")) + (setenv "CONFIG_SHELL" + (which "bash")) + (setenv "MACH_BUILD_PYTHON_NATIVE_PACKAGE_SOURCE" + "system") + ;; This should use the host info probably (does it + ;; build on non-x86_64 though?) + (setenv "GUIX_PYTHONPATH" + (string-append (getcwd) + "/obj-x86_64-pc-linux-gnu/_virtualenvs/build")) + + ;; Use Clang, Clang is 2x faster than GCC + (setenv "AR" "llvm-ar") + (setenv "NM" "llvm-nm") + (setenv "CC" "clang") + (setenv "CXX" "clang++") + (setenv "MOZ_NOSPAM" "1") + (setenv "MOZ_APP_NAME" "librewolf") + + (setenv "MOZBUILD_STATE_PATH" + (getcwd)) + + (let* ((mozconfig (string-append (getcwd) "/mozconfig")) + (out (assoc-ref outputs "out")) + (flags (cons (string-append "--prefix=" out) + configure-flags))) + (format #t "build directory: ~s~%" + (getcwd)) + (format #t "configure flags: ~s~%" flags) + + (define write-flags + (lambda flags + (display (string-join (map (cut string-append + "ac_add_options " <>) + flags) "\n")) + (display "\n"))) + (with-output-to-file mozconfig + (lambda () + (apply write-flags flags) + ;; The following option unsets Telemetry + ;; Reporting. With the Addons Fiasco, + ;; Mozilla was found to be collecting + ;; user's data, including saved passwords + ;; and web form data, without users + ;; consent. Mozilla was also found + ;; shipping updates to systems without + ;; the user's knowledge or permission. + ;; As a result of this, use the following + ;; command to permanently disable + ;; telemetry reporting. + (display "unset MOZ_TELEMETRY_REPORTING\n") + (display "mk_add_options MOZ_CRASHREPORTER=0\n") + (display "mk_add_options MOZ_DATA_REPORTING=0\n") + (display + "mk_add_options MOZ_SERVICES_HEALTHREPORT=0") + (display + "mk_add_options MOZ_TELEMETRY_REPORTING=0"))) + (setenv "MOZCONFIG" mozconfig)) + (invoke "./mach" "configure"))) + (add-before 'build 'fix-addons-placeholder + (lambda _ + (substitute* "toolkit/locales/en-US/toolkit/about/aboutAddons.ftl" + (("addons.mozilla.org") + "gnuzilla.gnu.org")))) + (replace 'build + (lambda* (#:key (make-flags '()) + (parallel-build? #t) #:allow-other-keys) + (apply invoke "./mach" "build" + ;; mach will use parallel build if possible by default + `(,@(if parallel-build? + '() + '("-j1")) ,@make-flags)))) + (add-after 'build 'neutralise-store-references + (lambda _ + ;; Mangle the store references to compilers & + ;; other build tools in about:buildconfig, + ;; reducing the package's closure by 1 GiB on + ;; x86-64. + (let* ((build-dir (car (scandir "." + (cut string-prefix? + "obj-" <>)))) + (file (string-append build-dir + "/dist/bin/chrome/toolkit/" + "content/global/buildconfig.html"))) + (substitute* file + (((format #f "(~a/)([0-9a-df-np-sv-z]{32})" + (regexp-quote (%store-directory))) + _ store hash) + (string-append store + (string-take hash 8) + "" + (string-drop hash 8))))))) + (replace 'install + (lambda _ + (invoke "./mach" "install"))) + (add-after 'install 'remove-duplicate-bin + (lambda* (#:key outputs #:allow-other-keys) + (delete-file (string-append #$output + "/lib/librewolf/librewolf-bin")))) + (add-after 'install 'wrap-glxtest + ;; glxtest uses dlopen() to load mesa and pci + ;; libs, wrap it to set LD_LIBRARY_PATH. + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (lib (string-append out "/lib")) + (libs (map + (lambda (lib-name) + (string-append (assoc-ref inputs + lib-name) + "/lib")) + '("mesa" "pciutils")))) + (wrap-program (car (find-files lib "^glxtest$")) + `("LD_LIBRARY_PATH" prefix ,libs))))) + (add-after 'install 'patch-config + (lambda* (#:key inputs #:allow-other-keys) + (let ((lib (string-append #$output "/lib/librewolf")) + (config-file "librewolf.cfg")) + + ;; Required for Guix packaged extensions + ;; SCOPE_PROFILE=1, SCOPE_APPLICATION=4, SCOPE_SYSTEM=8 + ;; Default is 5. + (substitute* (in-vicinity lib config-file) + (("defaultPref\\(\"extensions.enabledScopes\", 5\\)") + "defaultPref(\"extensions.enabledScopes\", 13)")) + ;; Use Mozzarella addons repo. + (call-with-port + (open-file + (in-vicinity lib config-file) + "a") + (lambda (port) + ;; Add-ons panel (see settings.js in Icecat source). + (for-each + (lambda (pref) + (format port + "defaultPref(~s, ~s);~%" + (car pref) + (cdr pref))) + `(("extensions.getAddons.search.browseURL" + ,(string-append + "https://gnuzilla.gnu.org/mozzarella/" + "search.php?q=%TERMS%")) + ("extensions.getAddons.get.url" . + "https://gnuzilla.gnu.org/mozzarella") + ("extensions.getAddons.link.url" . + "https://gnuzilla.gnu.org/mozzarella") + ("extensions.getAddons.discovery.api_url" . + "https://gnuzilla.gnu.org/mozzarella") + ("extensions.getAddons.langpacks.url" . + "https://gnuzilla.gnu.org/mozzarella") + ("lightweightThemes.getMoreURL" . + "https://gnuzilla.gnu.org/mozzarella")))))))) + (add-after 'install 'wrap-program + (lambda* (#:key inputs outputs #:allow-other-keys) + ;; The following two functions are from Guix's icecat package in + ;; (gnu packages gnuzilla). See commit + ;; b7a0935420ee630a29b7e5ac73a32ba1eb24f00b. + (define (runpath-of lib) + (call-with-input-file lib + (compose elf-dynamic-info-runpath elf-dynamic-info + parse-elf get-bytevector-all))) + (define (runpaths-of-input label) + (let* ((dir (string-append (assoc-ref inputs label) + "/lib")) + (libs (find-files dir "\\.so$"))) + (append-map runpath-of libs))) + (let* ((out (assoc-ref outputs "out")) + (lib (string-append out "/lib")) + (libs (map + (lambda (lib-name) + (string-append (assoc-ref inputs + lib-name) + "/lib")) + '("mesa" "libpng-apng" "libnotify" "libva" + "pulseaudio" "gtk+" + ;; For U2F and WebAuthn + "eudev"))) + + ;; VA-API is run in the RDD (Remote Data Decoder) sandbox + ;; and must be explicitly given access to files it needs. + ;; Rather than adding the whole store (as Nix had + ;; upstream do, see + ;; and + ;; linked upstream patches), we can just follow the + ;; runpaths of the needed libraries to add everything to + ;; LD_LIBRARY_PATH. These will then be accessible in the + ;; RDD sandbox. + (rdd-whitelist (map (cut string-append <> "/") + (delete-duplicates (append-map + runpaths-of-input + '("mesa" + "ffmpeg"))))) + (gtk-share (string-append (assoc-ref inputs + "gtk+") + "/share"))) + (wrap-program (car (find-files lib "^librewolf$")) + `("LD_LIBRARY_PATH" prefix + (,@libs ,@rdd-whitelist)) + `("XDG_DATA_DIRS" prefix + (,gtk-share)) + `("MOZ_LEGACY_PROFILES" = + ("1")) + `("MOZ_ALLOW_DOWNGRADE" = + ("1")))))) + (add-after 'wrap-program 'install-desktop-entry + (lambda* (#:key outputs #:allow-other-keys) + (let* ((desktop-file + "taskcluster/docker/firefox-snap/firefox.desktop") + (applications (string-append #$output + "/share/applications"))) + (substitute* desktop-file + (("^Exec=firefox") + (string-append "Exec=" + #$output "/bin/librewolf")) + ;; "Firefox" -> "LibreWolf" everywhere + (("Firefox") + "LibreWolf") + ;; Remove non-Latin translations. + (("^Name\\[(ar|bn)\\].*$") + "") + (("^Icon=.*") + (string-append "Icon=" + #$output + "/share/icons/hicolor/128x128/apps/librewolf.png +")) + ;; These commands were changed. + (("-NewWindow") + "-new-window") + (("-NewPrivateWindow") + "-new-private-window") + (("StartupNotify=true") + "StartupNotify=true +StartupWMClass=Navigator")) + (copy-file desktop-file "librewolf.desktop") + (install-file "librewolf.desktop" applications)))) + (add-after 'install-desktop-entry 'install-icons + (lambda* (#:key outputs #:allow-other-keys) + (let ((icon-source-dir (string-append #$output + "/lib/librewolf/browser/" + "chrome/icons/default"))) + (for-each (lambda (size) + (let ((dest (string-append #$output + "/share/icons/hicolor/" + size + "x" + size + "/apps"))) + (mkdir-p dest) + (symlink (string-append icon-source-dir + "/default" size ".png") + (string-append dest + "/librewolf.png")))) + '("16" "32" "48" "64" "128")))))) + + ;; Test will significantly increase build time but with little rewards. + #:tests? #f + + ;; WARNING: Parallel build will consume lots of memory! + ;; If you have encountered OOM issue in build phase, try disable it. + #:parallel-build? #t + + ;; Some dynamic lib was determined at runtime, so rpath check may fail. + #:validate-runpath? #f)) + (inputs (list bash-minimal + bzip2 + cairo + cups + dbus-glib + freetype + ffmpeg + gdk-pixbuf + glib + gtk+ + gtk+-2 + hunspell + icu4c-73 + jemalloc + libcanberra + libevent + libffi + libgnome + libjpeg-turbo + libnotify + libpng-apng + libva + libvpx + libwebp + libxcomposite + libxft + libxinerama + libxscrnsaver + libxt + mesa + mit-krb5 + nspr + nss + pango + pciutils + pipewire + pixman + pulseaudio + speech-dispatcher + sqlite + startup-notification + eudev + unzip + zip + zlib)) + (native-inputs (list alsa-lib + autoconf-2.13 + `(,rust-librewolf "cargo") + clang + llvm + m4 + nasm + node-lts + perl + pkg-config + python + rust-librewolf + rust-cbindgen-0.26 + which + yasm)) + (home-page "https://librewolf.net/") + (synopsis + "Custom version of Firefox, focused on privacy, security and freedom") + (description + "LibreWolf is designed to increase protection against tracking and +fingerprinting techniques, while also including a few security improvements. +This is achieved through our privacy and security oriented settings and +patches. LibreWolf also aims to remove all the telemetry, data collection and +annoyances, as well as disabling anti-freedom features like DRM.") + (license license:mpl2.0))) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 06 11:04:51 2024 Received: (at 67512) by debbugs.gnu.org; 6 Apr 2024 15:04:51 +0000 Received: from localhost ([127.0.0.1]:40581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rt7b9-0001qH-1a for submit@debbugs.gnu.org; Sat, 06 Apr 2024 11:04:51 -0400 Received: from fout7-smtp.messagingengine.com ([103.168.172.150]:55405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rt7b4-0001p2-3K for 67512@debbugs.gnu.org; Sat, 06 Apr 2024 11:04:48 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfout.nyi.internal (Postfix) with ESMTP id 81A36138008A; Sat, 6 Apr 2024 11:04:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 06 Apr 2024 11:04:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to; s=fm1; t=1712415874; x=1712502274; bh=eSKVLCOL6uUTxrSA7BLko +0U9SYg8R5OJSll/LQDVeQ=; b=ComZhM8pT0vleYX3EaqEh1c1mboGRNRJPDVCV Azvp4Db7oHE+ZHW1F+9UZsLbZDwpRzik6yxovpceykipVULDZWyY33ffrYxGE5eB 2MvGcPRuv9T9zocwWWBgvoN2tPV+k780srzJHVZgxDNwtZmSaED8EFjTn3nlrFQk HS1CgLd7lKiWt9CnVMMv6JIXLEuMMxNtIlG1/LkeL1o52Xw0aK2G0B/xa9aPtrQy diGL8uOxVg7XjM3kgIvmrJQBfjk2nWy/YaiWNyFrW6oCbvXWnbhBDlwFyV3/Dsu/ NmqY1DCyhjzcurq559nXSDiF6k9zMzIb1K8DaVh8B6b2dGLow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1712415874; x=1712502274; bh=eSKVLCOL6uUTxrSA7BLko+0U9SYg 8R5OJSll/LQDVeQ=; b=Mlz71VBVniZbV6tXEOv+2EIjA8mXTPeZ5tJFl080NzVK jM2wTh52yeha32U90MpWfVfgtr4QXovWXpF2Fhwjh12qxz8eobgwVV2xGkGaVrff Lj/xws45culiRBwdylqVh9FBckM3NZUHK6hsTX04TMbYusHDg5+bUFvRxYxFj5bT ZkvzErlex+b3so8nEiLmql+9O7B0d947ucQqxLMc9vz/14X7aRNgHwrh0M07+co5 3u+QLiiBt3kH2IEERxM9tZka6Lf8QwR/tSFZzFidaOry2ebpi5T46XkQ3Md/XEJZ zN3IcWsaz/6cleUunE4P1ZxONeR9hzPlp1IoDHlmqw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudegvddgkeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggtrdht vheqnecuggftrfgrthhtvghrnhephfeiveeliedukeffhefhleeijedtveelleetgefggf ehkeeljeehtdeguddvvefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepihgrnhesrhgvthhrohhsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 6 Apr 2024 11:04:33 -0400 (EDT) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v7 0/3] Add LibreWolf Date: Sat, 6 Apr 2024 08:04:15 -0700 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Moves nss update to nss-3.98 / nss-certs-3.98 to avoid rebuilding thousands of packages. Rebases. Ian Eure (3): gnu: Add nss-3.98. gnu: Add nss-certs-3.98. gnu: Add librewolf. gnu/packages/certs.scm | 16 + gnu/packages/librewolf.scm | 621 +++++++++++++++++++++++++++++++++++++ gnu/packages/nss.scm | 45 +++ 3 files changed, 682 insertions(+) create mode 100644 gnu/packages/librewolf.scm base-commit: ade6845da6cec99f3bca46faac9b2bad6877817e -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 06 11:04:55 2024 Received: (at 67512) by debbugs.gnu.org; 6 Apr 2024 15:04:55 +0000 Received: from localhost ([127.0.0.1]:40583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rt7bC-0001qX-HR for submit@debbugs.gnu.org; Sat, 06 Apr 2024 11:04:54 -0400 Received: from fout7-smtp.messagingengine.com ([103.168.172.150]:56827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rt7b6-0001pF-TN for 67512@debbugs.gnu.org; Sat, 06 Apr 2024 11:04:50 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfout.nyi.internal (Postfix) with ESMTP id 848CA13800C2; Sat, 6 Apr 2024 11:04:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 06 Apr 2024 11:04:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1712415877; x= 1712502277; bh=VA/OIOChjaFcLApMVkHr/tPez+u1AZup+WWGPjb+wis=; b=Z IjilQMsvhd5Mcm6sXHsQp3x0WNEqoBz6wIJChzxsz+Q+nTkLniAUTIxfu6A3eHms B3Zbg86CnEj5wYhWhlbXyRn9n0bKxuHd76xhBmo8ik2Cm0CnOyzOr4dYlV31hY2U +SNZGSrdwT2T/Cn9/Z0vBDp/4P91qcEKAH1qO06SWW8YAFf5eUcIpXrg55p/tgSA g15dNey0SyykHBrnR6uJdaHRi/GyFk+TGcFkhTVG7ZdIgVfZF21kYw1XjGusH42W YqCllXBb3v8ENQ0ynqFvcyjkEljsbcGlOBJzq0HkGHnn7T5LlIiICNou3lWOLb7m JZcCv/SLAoN0D6XRkrqIQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1712415877; x= 1712502277; bh=VA/OIOChjaFcLApMVkHr/tPez+u1AZup+WWGPjb+wis=; b=D 8Fz+JE4E80/PBw1fkrG614BkUACXQFHyfccKtuMNwGUMhWIsE3YulWkQ9pwdM7+3 wGj0y4XSpKcbJM2uzeKMe0seSz8SsxsiG1vi+cxv0ZJ9LRUjlg2ZjVtMfxe87Nnb XrY6bslDC+vXsU3JuUWxYdxhlY3q9E0Xpz0I0jhA0n57d4Ka1aIeaxhkTd9jAChg DdpLd/0NGpk9mk6NHpkUAerTx9NS6XiValZTTube1/65yX7CxyrlHUFan3VmkFU9 CeN5ybx3P0lQTl+15tb8GZ9lW5aWOhknUHANytfazPVYvt9Rw9OskgcnuVHvoJxh sTjDzwwpk0PdSaf46WEeA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudegvddgkeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggt rdhtvheqnecuggftrfgrthhtvghrnhepgfetieffvdeljeelieeiveeggeelgeeiveejke efveeludfgheettefgueffvefhnecuffhomhgrihhnpehmohiiihhllhgrrdhorhhgnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihgrnhesrh gvthhrohhsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 6 Apr 2024 11:04:36 -0400 (EDT) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v7 2/3] gnu: Add nss-certs-3.98. Date: Sat, 6 Apr 2024 08:04:17 -0700 Message-ID: X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/certs.scm (nss-certs-3.98): New variable. Change-Id: I95b54781c7b85f1d6b54158c6b906116791e009c --- gnu/packages/certs.scm | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/gnu/packages/certs.scm b/gnu/packages/certs.scm index 58b4d50ec8..7078c7c8d1 100644 --- a/gnu/packages/certs.scm +++ b/gnu/packages/certs.scm @@ -188,6 +188,22 @@ (define-public nss-certs (home-page "https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS") (license license:mpl2.0))) +(define-public nss-certs-3.98 + (package + (inherit nss-certs) + (version "3.98") + (source (origin + (method url-fetch) + (uri (let ((version-with-underscores + (string-join (string-split version #\.) "_"))) + (string-append + "https://ftp.mozilla.org/pub/mozilla.org/security/nss/" + "releases/NSS_" version-with-underscores "_RTM/src/" + "nss-" version ".tar.gz"))) + (sha256 + (base32 + "1kh98amfklrq6915n4mlbrcqghc3srm7rkzs9dkh21jwscrwqjgm")))))) + (define-public le-certs (package (name "le-certs") -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 06 11:04:56 2024 Received: (at 67512) by debbugs.gnu.org; 6 Apr 2024 15:04:56 +0000 Received: from localhost ([127.0.0.1]:40585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rt7bD-0001qc-1B for submit@debbugs.gnu.org; Sat, 06 Apr 2024 11:04:56 -0400 Received: from fout7-smtp.messagingengine.com ([103.168.172.150]:46863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rt7b6-0001p8-KC for 67512@debbugs.gnu.org; Sat, 06 Apr 2024 11:04:50 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfout.nyi.internal (Postfix) with ESMTP id 392B413800A2; Sat, 6 Apr 2024 11:04:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 06 Apr 2024 11:04:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1712415876; x= 1712502276; bh=7/f4sqU5tNrkuXAo1ILjb2Dm2yWC0FZwbOkfKRe9WCY=; b=Z CcZ+4q0OMnt8sdGuXbi9rNnAlCxw7cCGwc0e3PEJd0gmUyNj2MZRxUgSo4iTdP7i DaRililMW6TrU21i5jWnKYjK9l7jOBlT1X/z/D6/FyZwpdKruvruCc7L0q+WAWvr OMI2OasddF6GQVNZKPZSkUulnCZle/J3C4QzZIfKA6h/cG3j5sNuAa0Ze8kNKfTu kz1HAvtP+tkPj136xiJmkS/p4+PS/WWXKnIOb/KQpuTtxym4W2Po0GSETn92PZjj tNcauM7PzvOC6uXCd0Fu+cW8Yn+cK8jE19Jk7RXpZaR60kAalmYZVwxfakWIwrd+ FA1TaiYa0wlnR3xh+ni0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1712415876; x= 1712502276; bh=7/f4sqU5tNrkuXAo1ILjb2Dm2yWC0FZwbOkfKRe9WCY=; b=V ZdHeoXxA9TZuAOyG+AXKPxo2HEYLk7TO6hwmAWEjHYF43YAjhow6vWF7I5GB5kBS yyGNYcgwsDg1l+YPfUbvIZdsx1dMyaTvTJfp8zQnfLMqp/0uQACdqQSmVm1z11Fq n1jnIYGYtoRtOOqe8LO1pnCLzJOIYCeZjMU4NYAJhw/KojgAoSQ+0EBYIjmQgFff nCzETjyMu3ZSUG062Cjvv23genpoDk6x9kPWdzytC4LSdWkrnzLPSL6OvPsUmsrW IpRdDcZigFnNbS+lQZj/7djE8bKapVlqjuFK+LSbq/UMtXUzJghPzzOUPYzezNQa 3IHa34EbdkBIZpFkUwaSw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudegvddgkeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggt rdhtvheqnecuggftrfgrthhtvghrnhepgfetieffvdeljeelieeiveeggeelgeeiveejke efveeludfgheettefgueffvefhnecuffhomhgrihhnpehmohiiihhllhgrrdhorhhgnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihgrnhesrh gvthhrohhsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 6 Apr 2024 11:04:35 -0400 (EDT) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v7 1/3] gnu: Add nss-3.98. Date: Sat, 6 Apr 2024 08:04:16 -0700 Message-ID: <3db6c1dd76de00bee42833d2286cf916444cd49e.1712415593.git.ian@retrospec.tv> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/nss.scm (nss-3.98): New variable. Change-Id: If54ba20d296da2f4edd444c7cfa223a2d5a9ecb8 --- gnu/packages/nss.scm | 45 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/gnu/packages/nss.scm b/gnu/packages/nss.scm index 54b9e5041a..14612d7ce9 100644 --- a/gnu/packages/nss.scm +++ b/gnu/packages/nss.scm @@ -241,3 +241,48 @@ (define-public nss security standards.") (license license:mpl2.0))) +(define-public nss-3.98 + (package + (inherit nss) + (version "3.98") + (source (origin + (method url-fetch) + (uri (let ((version-with-underscores + (string-join (string-split version #\.) "_"))) + (string-append + "https://ftp.mozilla.org/pub/mozilla.org/security/nss/" + "releases/NSS_" version-with-underscores "_RTM/src/" + "nss-" version ".tar.gz"))) + (sha256 + (base32 + "1kh98amfklrq6915n4mlbrcqghc3srm7rkzs9dkh21jwscrwqjgm")) + ;; Create nss.pc and nss-config. + (patches (search-patches "nss-3.56-pkgconfig.patch" + "nss-getcwd-nonnull.patch" + "nss-increase-test-timeout.patch")) + (modules '((guix build utils))) + (snippet + '(begin + ;; Delete the bundled copy of these libraries. + (delete-file-recursively "nss/lib/zlib") + (delete-file-recursively "nss/lib/sqlite"))))) + (arguments + (substitute-keyword-arguments (package-arguments nss) + ((#:phases phases) + #~(modify-phases #$phases + (replace 'check + (lambda* (#:key tests? #:allow-other-keys) + (if tests? + (begin + ;; Use 127.0.0.1 instead of $HOST.$DOMSUF as HOSTADDR for + ;; testing. The latter requires a working DNS or /etc/hosts. + (setenv "DOMSUF" "localdomain") + (setenv "USE_IP" "TRUE") + (setenv "IP_ADDRESS" "127.0.0.1") + + ;; The "PayPalEE.cert" certificate expires every six months, + ;; leading to test failures: + ;; . To + ;; work around that, set the time to roughly the release date. + (invoke "faketime" "2024-01-23" "./nss/tests/all.sh")) + (format #t "test suite not run~%")))))))))) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 06 11:05:00 2024 Received: (at 67512) by debbugs.gnu.org; 6 Apr 2024 15:05:00 +0000 Received: from localhost ([127.0.0.1]:40587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rt7bE-0001qx-5c for submit@debbugs.gnu.org; Sat, 06 Apr 2024 11:05:00 -0400 Received: from fout7-smtp.messagingengine.com ([103.168.172.150]:54743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rt7b8-0001pH-Oh for 67512@debbugs.gnu.org; Sat, 06 Apr 2024 11:04:53 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.nyi.internal (Postfix) with ESMTP id 5FA9613800C9; Sat, 6 Apr 2024 11:04:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 06 Apr 2024 11:04:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1712415879; x=1712502279; bh=rabO8ZlfHjkuXMNi3WLYdV62SQvHGcjnJq6ypmEBqws=; b= KmWoeUJ5aHlYoxyPOBDMq+m97TOmiIhkU2SNgEvcBjasPKlEnUSuaJWdL13SLzen lffp0hNOshkqe3kZWokrOi6A1CVCOyMluBzGlVz/mBOQCd89BdWlaoY5BA4xLQDF RR06h8+8++ACF0IxkH2P3MFdcteuB7L5pqP41jcqwbXVk9MGojEJUB6b133yRAiW etvpMNejAgE7db4sFcL2dpEVmPXTs4JNgOfzizk9OLNtsf1QT5lJUBZS9v2W4i7T 0Vc9Lry6zLhlyCreP16BO7YXjpCUdkyKORFK/G/Mna9AOjp/G59JSgFJ/6uVudXL M/m87vrMNE85g76NHfhIbg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1712415879; x= 1712502279; bh=rabO8ZlfHjkuXMNi3WLYdV62SQvHGcjnJq6ypmEBqws=; b=q 4g9JuiRIvhhtXsgijLwNeZUUArHrvq/C23BmHP31mAvhhm8aK8kdTmX/YLFuQlj9 u0Vo2SCNGtHTvjEU8wieXNq/vW2yw/dvfcgyPvbjBRptiMlAgkQNekWynwN2eVWf e52VYqf3f7CHF801z+qYcTBmb/jS1IXgj08EnoI3nqlczuKLiGVpsDHnwcI4b/Yj teKyGGwZ++4ekAurJzx/tPQASwaD/RNYkcqquaB/vTfdNVsu5Bfm+t+jltKSZQgm xTgP+GR4tWVVVz7Sly0gds3YeXSqfWse4h/HMQLo1G1eaG8NN91OuoIqZkG7bGC0 QJ7lgYL95hvioipRx6h1A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudegvddgkeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfgggtgfesth ekredtredtjeenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgv tgdrthhvqeenucggtffrrghtthgvrhhnpefgffelveekueetvdefgfdvhfehleduhfelle eiieevtdduvdfhteevleefvdeiffenucffohhmrghinhepghhnuhdrohhrghdpshgvrghr tghhfhhogidrohhrghdpghhithhlrggsrdgtohhmpdgtohhnthgvnhhtrdhrvggrugdpmh hoiihilhhlrgdrohhrghdpghgvthgrugguohhnshdrshgvrghrtghhpdhgvghtrgguugho nhhsrdhlihhnkhdpghhithhhuhgsrdgtohhmpdhlihgsrhgvfiholhhfrdhnvghtnecuve hluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihgrnhesrhgv thhrohhsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 6 Apr 2024 11:04:37 -0400 (EDT) From: Ian Eure To: 67512@debbugs.gnu.org Subject: [PATCH v7 3/3] gnu: Add librewolf. Date: Sat, 6 Apr 2024 08:04:18 -0700 Message-ID: <2be94f3d5ea0a72bd6acfeb3698264a56d774d9b.1712415593.git.ian@retrospec.tv> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/librewolf.scm (librewolf): New variable. Change-Id: I98b6410582b856ede83b79637a58e66d6e5832e6 --- gnu/packages/librewolf.scm | 621 +++++++++++++++++++++++++++++++++++++ 1 file changed, 621 insertions(+) create mode 100644 gnu/packages/librewolf.scm diff --git a/gnu/packages/librewolf.scm b/gnu/packages/librewolf.scm new file mode 100644 index 0000000000..4804a872ce --- /dev/null +++ b/gnu/packages/librewolf.scm @@ -0,0 +1,621 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2013, 2015, 2024 Andreas Enge +;;; Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019 Ludovic Courtès +;;; Copyright © 2014, 2015, 2016, 2017, 2018, 2019, 2020, 2021 Mark H Weaver +;;; Copyright © 2015 Sou Bunnbu +;;; Copyright © 2016, 2017, 2018, 2019 Efraim Flashner +;;; Copyright © 2016 Alex Griffin +;;; Copyright © 2017 Clément Lassieur +;;; Copyright © 2017, 2018 Nikita +;;; Copyright © 2017, 2018 ng0 +;;; Copyright © 2017, 2018, 2020 Tobias Geerinckx-Rice +;;; Copyright © 2018, 2020, 2022 Ricardo Wurmus +;;; Copyright © 2019 Ivan Petkov +;;; Copyright © 2020 Oleg Pykhalov +;;; Copyright © 2020 Jakub Kądziołka +;;; Copyright © 2019, 2020 Adrian Malacoda +;;; Copyright © 2020-2023 Jonathan Brielmaier +;;; Copyright © 2020 Zhu Zihao +;;; Copyright © 2021 pineapples +;;; Copyright © 2021 Brice Waegeneire +;;; Copyright © 2021, 2022, 2023 John Kehayias +;;; Copyright © 2022 Pierre Langlois +;;; Copyright © 2023 Tomas Volf +;;; Copyright © 2023 Ian Eure +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + + +(define-module (gnu packages librewolf) + #:use-module (guix build-system gnu) + #:use-module (guix build-system cargo) + #:use-module (guix build-system trivial) + #:use-module (guix download) + #:use-module ((guix licenses) #:prefix license:) + #:use-module (guix gexp) + #:use-module (guix packages) + #:use-module (guix utils) + #:use-module ((guix build utils) #:select (alist-replace)) + + #:use-module (gnu packages) + #:use-module (gnu packages assembly) + #:use-module (gnu packages autotools) + #:use-module (gnu packages base) + #:use-module (gnu packages bash) + #:use-module (gnu packages compression) + #:use-module (gnu packages crates-io) + #:use-module (gnu packages cups) + #:use-module (gnu packages fontutils) + #:use-module (gnu packages gl) + #:use-module (gnu packages glib) + #:use-module (gnu packages gnome) + #:use-module (gnu packages gtk) + #:use-module (gnu packages hunspell) + #:use-module (gnu packages icu4c) + #:use-module (gnu packages image) + #:use-module (gnu packages jemalloc) + #:use-module (gnu packages kerberos) + #:use-module (gnu packages libcanberra) + #:use-module (gnu packages libevent) + #:use-module (gnu packages libffi) + #:use-module (gnu packages linux) + #:use-module (gnu packages llvm) + #:use-module (gnu packages m4) + #:use-module (gnu packages node) + #:use-module (gnu packages nss) + #:use-module (gnu packages pciutils) + #:use-module (gnu packages perl) + #:use-module (gnu packages pkg-config) + #:use-module (gnu packages pulseaudio) + #:use-module (gnu packages python) + #:use-module (gnu packages rust) + #:use-module (gnu packages rust-apps) + #:use-module (gnu packages speech) + #:use-module (gnu packages sqlite) + #:use-module (gnu packages video) + #:use-module (gnu packages xdisorg) + #:use-module (gnu packages xorg)) + +;; Define the versions of rust needed to build librewolf, trying to match +;; upstream. See the file taskcluster/ci/toolchain/rust.yml at +;; https://searchfox.org under the particular firefox release, like +;; mozilla-esr102. +(define rust-librewolf rust) ; 1.60 is the default in Guix, 1.65 is the minimum. + +;; Update this id with every update to its release date. +;; It's used for cache validation and therefore can lead to strange bugs. +;; ex: date '+%Y%m%d%H%M%S' +(define %librewolf-build-id "20240326080003") + +(define-public librewolf + (package + (name "librewolf") + (version "124.0.1-1") + (source + (origin + (method url-fetch) + + (uri (string-append "https://gitlab.com/api/v4/projects/32320088/" + "packages/generic/librewolf-source/" + version + "/librewolf-" + version + ".source.tar.gz")) + (sha256 + (base32 "1sks49nywzhvq5mik4ipm3vyyxv49s9hq6bfyk5d9r6f0nlydllf")))) + (build-system gnu-build-system) + (arguments + (list + #:configure-flags #~(let ((clang #$(this-package-native-input "clang"))) + `("--enable-application=browser" + + ;; Configuration + "--without-wasm-sandboxed-libraries" + "--with-system-jpeg" + "--with-system-zlib" + "--with-system-png" + "--with-system-webp" + "--with-system-icu" + "--with-system-libvpx" + "--with-system-libevent" + "--with-system-ffi" + "--enable-system-pixman" + "--enable-jemalloc" + + ;; see https://bugs.gnu.org/32833 + "--with-system-nspr" + "--with-system-nss" + + ,(string-append "--with-clang-path=" clang + "/bin/clang") + ,(string-append "--with-libclang-path=" clang + "/lib") + + ;; Distribution + "--with-distribution-id=org.guix" + "--with-app-name=librewolf" + "--with-app-basename=LibreWolf" + "--with-branding=browser/branding/librewolf" + + ;; Features + "--disable-tests" + "--disable-updater" + "--enable-pulseaudio" + "--disable-crashreporter" + "--allow-addon-sideload" + "--with-unsigned-addon-scopes=app,system" + "--disable-eme" + + ;; Build details + "--disable-debug" + "--enable-rust-simd" + "--enable-release" + "--enable-optimize" + "--enable-strip" + "--enable-hardening" + "--disable-elf-hack")) + #:imported-modules %cargo-utils-modules + #:modules `((ice-9 regex) + (ice-9 string-fun) + (ice-9 ftw) + (srfi srfi-1) + (srfi srfi-26) + (rnrs bytevectors) + (rnrs io ports) + (guix elf) + (guix build gremlin) + ,@%gnu-build-system-modules) + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'fix-preferences + (lambda* (#:key inputs #:allow-other-keys) + (let ((port (open-file "browser/app/profile/firefox.js" + "a"))) + (define (write-setting key value) + (format port "~%pref(\"~a\", ~a);~%" key value) + (format #t + "fix-preferences: setting value of ~a to ~a~%" key + value)) + + ;; We should allow the sandbox to read the store directory, + ;; because the sandbox has access to /usr on FHS distros. + (write-setting + "security.sandbox.content.read_path_whitelist" + (string-append "\"" + (%store-directory) "/\"")) + + ;; XDG settings should be managed by Guix. + (write-setting "browser.shell.checkDefaultBrowser" + "false") + (close-port port)))) + (add-after 'fix-preferences 'fix-ffmpeg-runtime-linker + (lambda* (#:key inputs #:allow-other-keys) + (let* ((ffmpeg (assoc-ref inputs "ffmpeg")) + (libavcodec (string-append ffmpeg + "/lib/libavcodec.so"))) + ;; Arrange to load libavcodec.so by its absolute file name. + (substitute* "dom/media/platforms/ffmpeg/FFmpegRuntimeLinker.cpp" + (("libavcodec\\.so") + libavcodec))))) + (add-after 'patch-source-shebangs 'patch-cargo-checksums + (lambda _ + (use-modules (guix build cargo-utils)) + (let ((null-hash + ;; This is the SHA256 output of an empty string. + (string-append + "e3b0c44298fc1c149afbf4c8996fb924" + "27ae41e4649b934ca495991b7852b855"))) + (for-each (lambda (file) + (format #t + "patch-cargo-checksums: patching checksums in ~a~%" + file) + (substitute* file + (("(checksum = )\".*\"" all name) + (string-append name "\"" null-hash + "\"")))) + (find-files "." "Cargo\\.lock$")) + (for-each generate-all-checksums + '("build" "dom/media" + "dom/webauthn" + "gfx" + "intl" + "js" + "media" + "modules" + "mozglue/static/rust" + "netwerk" + "remote" + "security/manager/ssl" + "servo" + "storage" + "third_party/rust" + "toolkit" + "xpcom/rust" + "services"))))) + (add-after 'patch-cargo-checksums 'remove-cargo-frozen-flag + (lambda _ + ;; Remove --frozen flag from cargo invokation, otherwise it'll + ;; complain that it's not able to change Cargo.lock. + ;; https://bugzilla.mozilla.org/show_bug.cgi?id=1726373 + (substitute* "build/RunCbindgen.py" + (("args.append\\(\"--frozen\"\\)") "pass")))) + (delete 'bootstrap) + (add-before 'configure 'patch-SpeechDispatcherService.cpp + (lambda _ + (let* ((lib "libspeechd.so.2") + (file (string-append + "dom/media/webspeech/synth/" + "speechd/SpeechDispatcherService.cpp")) + (old-content (call-with-input-file file + get-string-all))) + (substitute + file + `((,(format #f "~s" lib) unquote + (lambda (line _) + (string-replace-substring + line lib + (string-append #$speech-dispatcher + "/lib/" lib)))))) + (if (string=? old-content + (call-with-input-file file + get-string-all)) + (error + "substitute did nothing, phase requires an update"))))) + (add-before 'configure 'set-build-id + ;; Build will write the timestamp to output, which is harmful + ;; for reproducibility, so change it to a fixed date. Use a + ;; separate phase for easier modification with inherit. + (lambda _ + (setenv "MOZ_BUILD_DATE" + #$%librewolf-build-id))) + (replace 'configure + (lambda* (#:key inputs outputs configure-flags + #:allow-other-keys) + (setenv "AUTOCONF" + (string-append (assoc-ref inputs "autoconf") + "/bin/autoconf")) + (setenv "SHELL" + (which "bash")) + (setenv "CONFIG_SHELL" + (which "bash")) + (setenv "MACH_BUILD_PYTHON_NATIVE_PACKAGE_SOURCE" + "system") + ;; This should use the host info probably (does it + ;; build on non-x86_64 though?) + (setenv "GUIX_PYTHONPATH" + (string-append (getcwd) + "/obj-x86_64-pc-linux-gnu/_virtualenvs/build")) + + ;; Use Clang, Clang is 2x faster than GCC + (setenv "AR" "llvm-ar") + (setenv "NM" "llvm-nm") + (setenv "CC" "clang") + (setenv "CXX" "clang++") + (setenv "MOZ_NOSPAM" "1") + (setenv "MOZ_APP_NAME" "librewolf") + + (setenv "MOZBUILD_STATE_PATH" + (getcwd)) + + (let* ((mozconfig (string-append (getcwd) "/mozconfig")) + (out (assoc-ref outputs "out")) + (flags (cons (string-append "--prefix=" out) + configure-flags))) + (format #t "build directory: ~s~%" + (getcwd)) + (format #t "configure flags: ~s~%" flags) + + (define write-flags + (lambda flags + (display (string-join (map (cut string-append + "ac_add_options " <>) + flags) "\n")) + (display "\n"))) + (with-output-to-file mozconfig + (lambda () + (apply write-flags flags) + ;; The following option unsets Telemetry + ;; Reporting. With the Addons Fiasco, + ;; Mozilla was found to be collecting + ;; user's data, including saved passwords + ;; and web form data, without users + ;; consent. Mozilla was also found + ;; shipping updates to systems without + ;; the user's knowledge or permission. + ;; As a result of this, use the following + ;; command to permanently disable + ;; telemetry reporting. + (display "unset MOZ_TELEMETRY_REPORTING\n") + (display "mk_add_options MOZ_CRASHREPORTER=0\n") + (display "mk_add_options MOZ_DATA_REPORTING=0\n") + (display + "mk_add_options MOZ_SERVICES_HEALTHREPORT=0") + (display + "mk_add_options MOZ_TELEMETRY_REPORTING=0"))) + (setenv "MOZCONFIG" mozconfig)) + (invoke "./mach" "configure"))) + (add-before 'build 'fix-addons-placeholder + (lambda _ + (substitute* "toolkit/locales/en-US/toolkit/about/aboutAddons.ftl" + (("addons.mozilla.org") + "gnuzilla.gnu.org")))) + (replace 'build + (lambda* (#:key (make-flags '()) + (parallel-build? #t) #:allow-other-keys) + (apply invoke "./mach" "build" + ;; mach will use parallel build if possible by default + `(,@(if parallel-build? + '() + '("-j1")) ,@make-flags)))) + (add-after 'build 'neutralise-store-references + (lambda _ + ;; Mangle the store references to compilers & + ;; other build tools in about:buildconfig, + ;; reducing the package's closure by 1 GiB on + ;; x86-64. + (let* ((build-dir (car (scandir "." + (cut string-prefix? + "obj-" <>)))) + (file (string-append build-dir + "/dist/bin/chrome/toolkit/" + "content/global/buildconfig.html"))) + (substitute* file + (((format #f "(~a/)([0-9a-df-np-sv-z]{32})" + (regexp-quote (%store-directory))) + _ store hash) + (string-append store + (string-take hash 8) + "" + (string-drop hash 8))))))) + (replace 'install + (lambda _ + (invoke "./mach" "install"))) + (add-after 'install 'remove-duplicate-bin + (lambda* (#:key outputs #:allow-other-keys) + (delete-file (string-append #$output + "/lib/librewolf/librewolf-bin")))) + (add-after 'install 'wrap-glxtest + ;; glxtest uses dlopen() to load mesa and pci + ;; libs, wrap it to set LD_LIBRARY_PATH. + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (lib (string-append out "/lib")) + (libs (map + (lambda (lib-name) + (string-append (assoc-ref inputs + lib-name) + "/lib")) + '("mesa" "pciutils")))) + (wrap-program (car (find-files lib "^glxtest$")) + `("LD_LIBRARY_PATH" prefix ,libs))))) + (add-after 'install 'patch-config + (lambda* (#:key inputs #:allow-other-keys) + (let ((lib (string-append #$output "/lib/librewolf")) + (config-file "librewolf.cfg")) + + ;; Required for Guix packaged extensions + ;; SCOPE_PROFILE=1, SCOPE_APPLICATION=4, SCOPE_SYSTEM=8 + ;; Default is 5. + (substitute* (in-vicinity lib config-file) + (("defaultPref\\(\"extensions.enabledScopes\", 5\\)") + "defaultPref(\"extensions.enabledScopes\", 13)")) + ;; Use Mozzarella addons repo. + (call-with-port + (open-file + (in-vicinity lib config-file) + "a") + (lambda (port) + ;; Add-ons panel (see settings.js in Icecat source). + (for-each + (lambda (pref) + (format port + "defaultPref(~s, ~s);~%" + (car pref) + (cdr pref))) + `(("extensions.getAddons.search.browseURL" + ,(string-append + "https://gnuzilla.gnu.org/mozzarella/" + "search.php?q=%TERMS%")) + ("extensions.getAddons.get.url" . + "https://gnuzilla.gnu.org/mozzarella") + ("extensions.getAddons.link.url" . + "https://gnuzilla.gnu.org/mozzarella") + ("extensions.getAddons.discovery.api_url" . + "https://gnuzilla.gnu.org/mozzarella") + ("extensions.getAddons.langpacks.url" . + "https://gnuzilla.gnu.org/mozzarella") + ("lightweightThemes.getMoreURL" . + "https://gnuzilla.gnu.org/mozzarella")))))))) + (add-after 'install 'wrap-program + (lambda* (#:key inputs outputs #:allow-other-keys) + ;; The following two functions are from Guix's icecat package in + ;; (gnu packages gnuzilla). See commit + ;; b7a0935420ee630a29b7e5ac73a32ba1eb24f00b. + (define (runpath-of lib) + (call-with-input-file lib + (compose elf-dynamic-info-runpath elf-dynamic-info + parse-elf get-bytevector-all))) + (define (runpaths-of-input label) + (let* ((dir (string-append (assoc-ref inputs label) + "/lib")) + (libs (find-files dir "\\.so$"))) + (append-map runpath-of libs))) + (let* ((out (assoc-ref outputs "out")) + (lib (string-append out "/lib")) + (libs (map + (lambda (lib-name) + (string-append (assoc-ref inputs + lib-name) + "/lib")) + '("mesa" "libpng-apng" "libnotify" "libva" + "pulseaudio" "gtk+" + ;; For U2F and WebAuthn + "eudev"))) + + ;; VA-API is run in the RDD (Remote Data Decoder) sandbox + ;; and must be explicitly given access to files it needs. + ;; Rather than adding the whole store (as Nix had + ;; upstream do, see + ;; and + ;; linked upstream patches), we can just follow the + ;; runpaths of the needed libraries to add everything to + ;; LD_LIBRARY_PATH. These will then be accessible in the + ;; RDD sandbox. + (rdd-whitelist (map (cut string-append <> "/") + (delete-duplicates (append-map + runpaths-of-input + '("mesa" + "ffmpeg"))))) + (gtk-share (string-append (assoc-ref inputs + "gtk+") + "/share"))) + (wrap-program (car (find-files lib "^librewolf$")) + `("LD_LIBRARY_PATH" prefix + (,@libs ,@rdd-whitelist)) + `("XDG_DATA_DIRS" prefix + (,gtk-share)) + `("MOZ_LEGACY_PROFILES" = + ("1")) + `("MOZ_ALLOW_DOWNGRADE" = + ("1")))))) + (add-after 'wrap-program 'install-desktop-entry + (lambda* (#:key outputs #:allow-other-keys) + (let* ((desktop-file + "taskcluster/docker/firefox-snap/firefox.desktop") + (applications (string-append #$output + "/share/applications"))) + (substitute* desktop-file + (("^Exec=firefox") + (string-append "Exec=" + #$output "/bin/librewolf")) + ;; "Firefox" -> "LibreWolf" everywhere + (("Firefox") + "LibreWolf") + ;; Remove non-Latin translations. + (("^Name\\[(ar|bn)\\].*$") + "") + (("^Icon=.*") + (string-append "Icon=" + #$output + "/share/icons/hicolor/128x128/apps/librewolf.png +")) + ;; These commands were changed. + (("-NewWindow") + "-new-window") + (("-NewPrivateWindow") + "-new-private-window") + (("StartupNotify=true") + "StartupNotify=true +StartupWMClass=Navigator")) + (copy-file desktop-file "librewolf.desktop") + (install-file "librewolf.desktop" applications)))) + (add-after 'install-desktop-entry 'install-icons + (lambda* (#:key outputs #:allow-other-keys) + (let ((icon-source-dir (string-append #$output + "/lib/librewolf/browser/" + "chrome/icons/default"))) + (for-each (lambda (size) + (let ((dest (string-append #$output + "/share/icons/hicolor/" + size + "x" + size + "/apps"))) + (mkdir-p dest) + (symlink (string-append icon-source-dir + "/default" size ".png") + (string-append dest + "/librewolf.png")))) + '("16" "32" "48" "64" "128")))))) + + ;; Test will significantly increase build time but with little rewards. + #:tests? #f + + ;; WARNING: Parallel build will consume lots of memory! + ;; If you have encountered OOM issue in build phase, try disable it. + #:parallel-build? #t + + ;; Some dynamic lib was determined at runtime, so rpath check may fail. + #:validate-runpath? #f)) + (inputs (list bash-minimal + bzip2 + cairo + cups + dbus-glib + freetype + ffmpeg + gdk-pixbuf + glib + gtk+ + gtk+-2 + hunspell + icu4c-73 + jemalloc + libcanberra + libevent + libffi + libgnome + libjpeg-turbo + libnotify + libpng-apng + libva + libvpx + libwebp + libxcomposite + libxft + libxinerama + libxscrnsaver + libxt + mesa + mit-krb5 + nspr + nss-3.98 + pango + pciutils + pipewire + pixman + pulseaudio + speech-dispatcher + sqlite + startup-notification + eudev + unzip + zip + zlib)) + (native-inputs (list alsa-lib + autoconf-2.13 + `(,rust-librewolf "cargo") + clang + llvm + m4 + nasm + node-lts + perl + pkg-config + python + rust-librewolf + rust-cbindgen-0.26 + which + yasm)) + (home-page "https://librewolf.net/") + (synopsis + "Custom version of Firefox, focused on privacy, security and freedom") + (description + "LibreWolf is designed to increase protection against tracking and +fingerprinting techniques, while also including a few security improvements. +This is achieved through our privacy and security oriented settings and +patches. LibreWolf also aims to remove all the telemetry, data collection and +annoyances, as well as disabling anti-freedom features like DRM.") + (license license:mpl2.0))) -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 12 07:33:17 2024 Received: (at 67512) by debbugs.gnu.org; 12 Apr 2024 11:33:18 +0000 Received: from localhost ([127.0.0.1]:58008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvF9g-00019J-6k for submit@debbugs.gnu.org; Fri, 12 Apr 2024 07:33:17 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:47507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvF9d-00017h-Dr for 67512@debbugs.gnu.org; Fri, 12 Apr 2024 07:33:14 -0400 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-346f4266e59so591501f8f.3 for <67512@debbugs.gnu.org>; Fri, 12 Apr 2024 04:33:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712921576; x=1713526376; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=/KKjoxV5fPoEFPhT0fDhe8tZec20d1tv0RZN01wdyFc=; b=Iiw3q86SYISSorWDzm/yyv3w0ZkwcP7LxZRkJdl3k1YS7eY4TkeJp95JUQ1e/LozE2 G9kty/6vVSQSvaJld8+ElYw8vh9Le66w3KSeOqoD0WTDbFRvbZl+MEHT2rO4iJXkL9m2 k85UtGw+5Ee47M8g8xiSBDkDVB4G1RkiIcIc2Z3F/zNQ05+afKTPz99ylVGl3BBgC0EF /w60jQdkJbSepQrtCXC/qeoQ3b3O7hXvIFAPTM4a2ICQi8GX/sQQqD5AvpmFIhbFZxU0 wrcBrOcezhdpILRTPNIKUultH5mt6VBNE0jUlljqdQYZfchgNforPtmT27OjtTHsJKF/ FicA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712921576; x=1713526376; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/KKjoxV5fPoEFPhT0fDhe8tZec20d1tv0RZN01wdyFc=; b=JOAzcVcXJoio50HkMAgqjzWvcc0EWvWc6W0QKyUJ/jHeiOPIEncriGaobsUDSswQhQ FLmyDskO/xLxSEFOBAgy3RqdNDW3MINRf2t0laTM0aHv7d4dVWECQcZ453l55RbOriyM A6rof+jy0+qaZkutHD+HaxGzpLG/3j7xz/7BELG979x1l6atqh0Yc7743+6TcMrpx9VB 3/Na6EVJFO9qx1ZbzUK0GI3+FYCwfttvHT73wff/Uu/913tMaZc1WI4W4/tD1zNXkT8v fvC5udjip9/p4Fq66WvJK/jZLf2X65nzjXDPLRbjG8lHAzm9GvmzwcY4FofSWTEzegQJ ns9Q== X-Gm-Message-State: AOJu0YzJArFI/6F0a/UwUCFBP3bOkUPekQrxgnZznG55ScB6ngpxZdGM 0jahG/Afcp4qWwVuiF4GvfWYUDol8drF8WKqXmqdnTY7MonIdz3gIyBLdNvn X-Google-Smtp-Source: AGHT+IH4u+Zs9cZQzfMTb/ZNSr7p/l4DYMz0IxVLFiJaMYxt1Vh2quNjWoYONywFPmVWoUztruCugQ== X-Received: by 2002:a05:6000:4c7:b0:345:70bc:b08c with SMTP id h7-20020a05600004c700b0034570bcb08cmr1452596wri.60.1712921576491; Fri, 12 Apr 2024 04:32:56 -0700 (PDT) Received: from guxtil (cpc100856-bagu15-2-0-cust368.1-3.cable.virginm.net. [82.25.93.113]) by smtp.gmail.com with ESMTPSA id h15-20020adff4cf000000b003432ffc3aeasm4058407wrp.56.2024.04.12.04.32.55 for <67512@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 04:32:55 -0700 (PDT) From: Sharlatan Hellseher To: 67512@debbugs.gnu.org Subject: [PATCH 0/5] Add LibreWolf Date: Fri, 12 Apr 2024 12:32:53 +0100 Message-ID: <87jzl27r4q.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 67512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Guix team! It would be great to have one more modern and libre web browser in the Guix's belt! I've managed to build and run it successfully by applying patch directly from QA, thanks Andrew Tropin for the snippet. =2D-8<---------------cut here---------------start------------->8--- guix time-machine \ --url=3D'https://git.guix-patches.cbaines.net/git/guix-patches' \ --branch=3Dissue-67512 \ --disable-authentication -- shell librewolf -- librewolf =2D-8<---------------cut here---------------end--------------->8--- =2D- Oleg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmYZG+UACgkQdtcnv/Ys 0rXyYA/+L8+9hQjzdZDff2uCQ0nP9n1HZc8T2CZnBt070fzpzg28+rtVW2pE/XKK ztYqMGTJF0EkiiUPFnTxrfbzyRFSGBjmrxHh8NC8zsEE/xfsjapWcp5PvceCmYti unOV7nSuoyDcpNqcVJgguZJu2kqKT3lWJKn3sp/hNgEtgwpMeFJy/ZU5h51SAbwJ 6+4lUrfe6KCccn0mUl16liSSBp0xIm5LGylxQVpwLsfS617bz5wp/A2m8qAIZRBa 0AZ+6vCTi+UHCB5LdJy7ES8tSP2umDFjL+FmUzB7LRbJulnjz0bGt9k3cjf+zYs+ /+n8rKoq6mVQMdjtqTfuezCFxYgZ9+ACnP9J9eGrXy0xG98D2hD6fFfx52Qk2DTQ bpWJoXwkrYT/tEpQYbMRnEX4lFgoujK55SwFvuFK2rsMK972qASq5Y7NfTtIUxNv mXrOxM6OK/MBb1IyxKwYybdla/WIDc6IsdpFPzmh0ozXFdzPCi4nnuu1TThQxut6 I0bQSHrykgu6UzNvmWHr5/HrDHBYGq+JTmSbQy7zIBh3XwZvRXT6RZZ/PAAsVY5R z9Ko5uClA7ZWvLjXyY3pPsXLfE1JvlO6/UDigeeA/gv0YIPyJVjZwvSfN8OZKWaM E5wg325LiphxhdMtOlnGgIE5/HYKXRYpB/uvMPOsWMOFLTtozBY= =klIG -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 12 09:11:34 2024 Received: (at 67512-done) by debbugs.gnu.org; 12 Apr 2024 13:11:35 +0000 Received: from localhost ([127.0.0.1]:58105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvGgo-00080H-Kg for submit@debbugs.gnu.org; Fri, 12 Apr 2024 09:11:34 -0400 Received: from out-185.mta0.migadu.com ([91.218.175.185]:32279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvGgl-0007zE-Pc for 67512-done@debbugs.gnu.org; Fri, 12 Apr 2024 09:11:33 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=key1; t=1712927473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9WSlNS7he87E0i9kWgmceBaQ4MOEaueIZKWmK1XXi6U=; b=RsU9q/mhjWM66PhLL/JflODSJy8yIGdyPjuDi2jxbAuf6xT+5MvN7OSaIwALs8VIrFQCq+ zK40yXl6pcL9SlZcDfXvqOzn39q0tCkUQ02IAIpOd6VRYkW/OAueIBmw5lSlUjCxXGLBgU e/ddv8MC43+NtTSfxUVtyCQLBJ9KQrr+12LolnWN+OS6L4mUPZ4O7ULAbeUQC6THVBgcke Akoa7Z+Vh59FcKAb1UR9elg6HblEI6tsgCe0MmgmRE0AJneqesD7FwgP+FOkS2Es2J/eNS 6E5kiGaYDA9AjPHtk0DgHVx4Nkw9cdtki8ncimzQDEHNuPQk55OpVB0iRQ2kNA== From: Andrew Tropin To: Ian Eure , 67512-done@debbugs.gnu.org Subject: Re: [bug#67512] [PATCH v7 0/3] Add LibreWolf In-Reply-To: References: Date: Fri, 12 Apr 2024 16:11:05 +0300 Message-ID: <87jzl27ml2.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 67512-done Cc: Sharlatan Hellseher , Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2024-04-06 08:04, Ian Eure wrote: > Moves nss update to nss-3.98 / nss-certs-3.98 to avoid rebuilding thousan= ds of packages. > > Rebases. > > Ian Eure (3): > gnu: Add nss-3.98. > gnu: Add nss-certs-3.98. > gnu: Add librewolf. > > gnu/packages/certs.scm | 16 + > gnu/packages/librewolf.scm | 621 +++++++++++++++++++++++++++++++++++++ > gnu/packages/nss.scm | 45 +++ > 3 files changed, 682 insertions(+) > create mode 100644 gnu/packages/librewolf.scm > > > base-commit: ade6845da6cec99f3bca46faac9b2bad6877817e Hi Ian, tested those patches, didn't notice any issues. Added pipewire to LD_LIBRARY_PATH to make screensharing on wayland to work. Added librewolf.scm to gnu/local.mk. Pushed as https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D3dc26b4eae Thank you very much for you work! =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmYZMuoACgkQIgjSCVjB 3rDjeQ//f6Cesd7j687LdkMtqw5wTFi6XCRFXB0CZOz2fvyjKTkG8hBHSKE7hrHb mPxr2zUZTfBhPQDwzjc+B/Zm0zH8EiH4MtcZ5cgL/0zKbZz1qnIXHYe/+If+u3QA Qw5uQpdWaz+4oQAY2pWvhsW/x49yJlq7tTaCTapBN6rIl1Kpzle/156ZhIdlqOlZ MP1KxmtKrifXw+hZqb3WjA3PrORpz/V+odWLlXpgUoXlhhp9Qw9kU4kBl/ZhE/vu 833dZxVqkhi7DR4nhD35M0y6QGSgzhK9ifgOj/Zje7y8i2Wz8ScX/HEpW2gfR9lR 0lKFY3wfsnsrwStCFCEd9B4aelR5nqnWzycyJXNfFY96pJUmsnrCFEz1c1mvabBU hWCFZWMQEw8CA823GVC2j/IKz7/GZtVqIes0OjV07ezeBwkdhLihuoVNKlipN0uP 0gixLL08RJhbynVp9j2pUx8VerzpltCNX4sVaCGwQJCtOjG077tLi1+Cyx6gnzYj uLR/ghCC91af40VQ3hxwfBoOMTf6PibPYWxLJ8l8dWxR4btV28v5672j+tOSOxpc qYrFAK9ErPpGj3YmOI7SjQ0dBregJjeJXj3pIUFwmep7sUPC+2yUZ6wvA/K8k2+8 HbZDdWqq74CsPcM8JstOJCum+o1tgmgfqAPzexj/UjVnI6oipxI= =1Fr0 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 27 06:46:52 2024 Received: (at 67512) by debbugs.gnu.org; 27 Apr 2024 10:46:53 +0000 Received: from localhost ([127.0.0.1]:39042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0fZv-0006nU-NT for submit@debbugs.gnu.org; Sat, 27 Apr 2024 06:46:52 -0400 Received: from fout4-smtp.messagingengine.com ([103.168.172.147]:32859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0fZo-0006kr-Uo for 67512@debbugs.gnu.org; Sat, 27 Apr 2024 06:46:44 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.nyi.internal (Postfix) with ESMTP id D086B1380114; Sat, 27 Apr 2024 06:46:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 27 Apr 2024 06:46:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1714214776; x=1714301176; bh=5dNC4QaodKSki9kV4eLBWhZinTAaWCiX/WvQUGNLzsY=; b= Oekmvk5u5uRHXW9Qp9npm7tiX7L/aYDZqqRIUoTwmoQjD3QFXQc72HU4F3Dvjq0x ASVRtXgl5d9WKFwKTAiZeJQ35Ncz7OCvy4JJSmXXKN3j63XEQpK2VvV9enBgj0ER GU9N+sOipgEDmFyMVLRcbDaaCcLbQ2GXbyqA1ZQg57zLg12ChENYyzDARU7gX9zM zLiWAGgq9GyVqN1Y2RLGA7monvXBFhP++W8i7pyTkwI5TS/ncOUJbYeUcFnFw4N8 8nUpOYg6rxK+2Df1cDtajhLLRT59JDKcVAWRIIieOLLeaOYXlKKEfbwIiVjMRPTI WI7d2MCbhmUD0EgNFukWtg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1714214776; x= 1714301176; bh=5dNC4QaodKSki9kV4eLBWhZinTAaWCiX/WvQUGNLzsY=; b=d vA3mPIyQIJyu7ViJXAl0/nxdP8O6MqZO7Vss8x3LJSGwWq7AfAiJ9/xPQ37/C6Li wS93qVs4oSR4Ui0tZQrx4Sm4is3trzHsIya2CaC51K4AtO5taJJEeTWLsCXMoZ23 rNxC60pI5+dj0KyMw/XxHapHuyCLwI48TJAY6RsfjRDT/5Q4ytOXg7NoABKtX1gz IDlqWkd7siDddPY5NBJGAZTU6Jcgq50xvJ6cXYTk5Q3NKL+6KKj0x/aBQ7jsanlW xzv8SQ7huPiy0FvJpBLE2gNosBOfigVEzWIdrJMVvkEwqsTdWmNHUlWj8WtUib8X jLnhcPIuXeeX+QzrEuaUg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddtuddgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufgjfhffkfgfgggtgfesth hqredttderjeenucfhrhhomhepvehlrohmvghnthcunfgrshhsihgvuhhruceotghlvghm vghntheslhgrshhsihgvuhhrrdhorhhgqeenucggtffrrghtthgvrhhnpeeiudeuheevie dtleelheeivedutdejgfevhfdvtedvudelhfdthedvvddtieehkeenucffohhmrghinhep ghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpegtlhgvmhgvnhhtsehlrghsshhivghurhdrohhrgh X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 27 Apr 2024 06:46:14 -0400 (EDT) From: =?utf-8?Q?Cl=C3=A9ment_Lassieur?= To: 67512@debbugs.gnu.org Subject: Re: bug#67512: [PATCH v7 0/3] Add LibreWolf In-Reply-To: <87jzl27ml2.fsf@trop.in> (Andrew Tropin via Guix-patches via's message of "Fri, 12 Apr 2024 16:11:05 +0300") References: <87jzl27ml2.fsf@trop.in> Date: Sat, 27 Apr 2024 12:46:11 +0200 Message-ID: <87il03gk24.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: guix-devel@gnu.org, Mark H Weaver , ian@retrospec.tv, guix-security@gnu.org, andrew@trop.in X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, Apr 12 2024, Andrew Tropin via Guix-patches via wrote: > On 2024-04-06 08:04, Ian Eure wrote: > >> Moves nss update to nss-3.98 / nss-certs-3.98 to avoid rebuilding thousa= nds of packages. >> >> Rebases. >> >> Ian Eure (3): >> gnu: Add nss-3.98. >> gnu: Add nss-certs-3.98. >> gnu: Add librewolf. >> >> gnu/packages/certs.scm | 16 + >> gnu/packages/librewolf.scm | 621 +++++++++++++++++++++++++++++++++++++ >> gnu/packages/nss.scm | 45 +++ >> 3 files changed, 682 insertions(+) >> create mode 100644 gnu/packages/librewolf.scm >> >> >> base-commit: ade6845da6cec99f3bca46faac9b2bad6877817e > > Hi Ian, > > tested those patches, didn't notice any issues. > > Added pipewire to LD_LIBRARY_PATH to make screensharing on wayland to > work. > > Added librewolf.scm to gnu/local.mk. > > Pushed as > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D3dc26b4eae > > Thank you very much for you work! Thank you Andrew for reviewing. Now that this is pushed, is there anyone maintaining this "librewolf" package? This is serious work, with security updates quite often. Right now the package is subject to CVE-2024-3852 (high) CVE-2024-3853 (high) CVE-2024-3854 (high) CVE-2024-3855 (high) CVE-2024-3856 (high) CVE-2024-3857 (high) CVE-2024-3858 (high) CVE-2024-3859 (moderate) CVE-2024-3860 (moderate) CVE-2024-3861 (moderate) CVE-2024-3862 (moderate) CVE-2024-3302 (low) CVE-2024-3864 (high) CVE-2024-3865 (high) Thanks, Cl=C3=A9ment From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 27 13:29:40 2024 Received: (at 67512) by debbugs.gnu.org; 27 Apr 2024 17:29:40 +0000 Received: from localhost ([127.0.0.1]:49613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0lro-00012h-7F for submit@debbugs.gnu.org; Sat, 27 Apr 2024 13:29:40 -0400 Received: from fhigh5-smtp.messagingengine.com ([103.168.172.156]:49367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0lrl-00012Y-Oi for 67512@debbugs.gnu.org; Sat, 27 Apr 2024 13:29:38 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 8F76D11400AB; Sat, 27 Apr 2024 13:29:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 27 Apr 2024 13:29:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1714238953; x=1714325353; bh=jtQq4lpIkTK2dFA+m9ymP+MeYhZD91zno1Lp+54ki00=; b= djFpgVrMObneEz5Pb8RLEC3YV9pwjwZUq8iQnCcy11sq/zjKLoNTvOsShHA6M7Ub t6KahGDKaNTaZqCGY+0Rd9kBC4Twr40Mwfsfgy+mpY5FGE8Z4IR238RxYy9TgQZ1 yBbVtDDVK/kScdmufTlGxg1ZAOHOoTN1K34ejWbYCelhXINBDP+SxgBUQKICloGf GSgFhaZ+lqhCwOj4bHtptV3ELsRhKbbKTCFpSeSc8se+QuFzRUhgk0BunpqC1FE3 gJmgb4Kubadbzr2ZjMKW410J9NJCbhlwyCWLcz6Ukdp1UkgRALWUqMMtpwhKPteq LrEJq0B8rOpTI0YgqHCwPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1714238953; x= 1714325353; bh=jtQq4lpIkTK2dFA+m9ymP+MeYhZD91zno1Lp+54ki00=; b=B F+ANzzetgrKgUAajohKagNsTGy+hMyzOI78To28FrP5f8zSYASbR/hH9zN39H3R1 k2aOBID7ov0PvX9supes0F/AW1RBCpyoFxbBb+VyneDdaad5LGHAT5mWioZp1V23 1tg/+AHd40CisZRpeUTNjYwhuQKhhpFhLkQ6aElVLLd3bQMfj1v29TlYeMfdjR4n PCCSdVP7tDug6gbORV8PFbRO2tTzeC3n13oJdd3UrVa6N02U7MnE7vDfYQadOh2P /0Wp+Ntk3hXPSK8dVwX7xvLEdQamk88ja3HW5GwXHwpvdeRBARRjDs7QGtVtJQny l2Ib/mb/Ezvz8UWlFYJIA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddtuddgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvfevufffjgfkgggtgfesthhqredttderjeenucfhrhhomhepkfgr nhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdrthhvqeenucggtffrrghtthgvrh hnpefhhfegieekfeegueehfeelteejhfeugfelvdeggfduvdevteelleetkeelffdtkeen ucffohhmrghinhepghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 27 Apr 2024 13:29:11 -0400 (EDT) References: <87jzl27ml2.fsf@trop.in> <87il03gk24.fsf@lassieur.org> User-agent: mu4e 1.8.13; emacs 28.2 From: Ian Eure To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Subject: Re: bug#67512: [PATCH v7 0/3] Add LibreWolf Date: Sat, 27 Apr 2024 10:19:46 -0700 In-reply-to: <87il03gk24.fsf@lassieur.org> Message-ID: <87r0eqww7t.fsf@meson> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, guix-devel@gnu.org, guix-security@gnu.org, Mark H Weaver , andrew@trop.in X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Cl=C3=A9ment Lassieur writes: > On Fri, Apr 12 2024, Andrew Tropin via Guix-patches via wrote: > >> On 2024-04-06 08:04, Ian Eure wrote: >> >>> Moves nss update to nss-3.98 / nss-certs-3.98 to avoid=20 >>> rebuilding thousands of packages. >>> >>> Rebases. >>> >>> Ian Eure (3): >>> gnu: Add nss-3.98. >>> gnu: Add nss-certs-3.98. >>> gnu: Add librewolf. >>> >>> gnu/packages/certs.scm | 16 + >>> gnu/packages/librewolf.scm | 621=20 >>> +++++++++++++++++++++++++++++++++++++ >>> gnu/packages/nss.scm | 45 +++ >>> 3 files changed, 682 insertions(+) >>> create mode 100644 gnu/packages/librewolf.scm >>> >>> >>> base-commit: ade6845da6cec99f3bca46faac9b2bad6877817e >> >> Hi Ian, >> >> tested those patches, didn't notice any issues. >> >> Added pipewire to LD_LIBRARY_PATH to make screensharing on=20 >> wayland to >> work. >> >> Added librewolf.scm to gnu/local.mk. >> >> Pushed as >> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D3dc26b4eae >> >> Thank you very much for you work! > > Thank you Andrew for reviewing. > > Now that this is pushed, is there anyone maintaining this=20 > "librewolf" > package? This is serious work, with security updates quite=20 > often. > Hi Clement, I=E2=80=99m planning to continue sending patches for updates and the like.= =20 Getting a working updater is close to the top of my list. > Right now the package is subject to > > CVE-2024-3852 (high) > CVE-2024-3853 (high) > CVE-2024-3854 (high) > CVE-2024-3855 (high) > CVE-2024-3856 (high) > CVE-2024-3857 (high) > CVE-2024-3858 (high) > CVE-2024-3859 (moderate) > CVE-2024-3860 (moderate) > CVE-2024-3861 (moderate) > CVE-2024-3862 (moderate) > CVE-2024-3302 (low) > CVE-2024-3864 (high) > CVE-2024-3865 (high) > The version in Guix is the latest available. I=E2=80=99ll send in a patch= =20 when the next release happens; I=E2=80=99m waiting on upstream for that. Thanks, =E2=80=94 Ian From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 27 14:21:46 2024 Received: (at 67512) by debbugs.gnu.org; 27 Apr 2024 18:21:46 +0000 Received: from localhost ([127.0.0.1]:49674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0mgE-0004Wb-E1 for submit@debbugs.gnu.org; Sat, 27 Apr 2024 14:21:46 -0400 Received: from fhigh5-smtp.messagingengine.com ([103.168.172.156]:59835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0mgC-0004WV-58 for 67512@debbugs.gnu.org; Sat, 27 Apr 2024 14:21:44 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfhigh.nyi.internal (Postfix) with ESMTP id E282611400D9; Sat, 27 Apr 2024 14:21:19 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 27 Apr 2024 14:21:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1714242079; x=1714328479; bh=K7qYoIgwIwQc94UfBvp0gYPYFn1qnpxhO0dllniAhXc=; b= MR81CE584HGALAoK36HZKZwNHurWxKjhGhiR9O3btj5M8d9S7F4LdBt/Dueytnwp g1pw9Iisy1Bq7pSnW65Bxkj60ew1woxEZ17tAYnPSzpFb9e9TBrgjIDtwuxLFS29 TW+Bn/C5eYTIDM1alprJ5MUCATK6XvJuRha17qkj0T3+UZKMF9zpPpmpFzd6MWzh gsbeQeCovPctX4hpqCqk98CeQ5HQ1+omdLoc1SdR8fFdTBL50+7ZVb1fJOVwZjTD c4t4WJAHe7sliONu6QqpN/hmHtUJ7z3vwMK9Q3+b/9yDJCpuUrfX5UG0R+Cqjgdg /dw9JB7oi/85lCcAHTNUtg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1714242079; x= 1714328479; bh=K7qYoIgwIwQc94UfBvp0gYPYFn1qnpxhO0dllniAhXc=; b=K wtUYqtsQX4OCggOzFr/Yu39YjERyGc9AnptEBTVN6dgrm22xw8/Imj7bFD6nxr9C XCBCO9iunTAFvMrf0c4ACQF0A6OO48F0oRBG7cruLgH3fLqnKinwpULwbmbHYthO 7iuR1EqxVxP/08nfZLGnc4RaG6nSKcANxiKYEdBq6nI1x5wcwU0vXtmEmd5TPKWE Hc0Cw8+WwsZ1Th5ARXVqPg1a2pgilADL/AEnnfyxR6QWBQfazA5RhlGCbO9YodLr ncYWGrz1qK5E/ZIKPrkTDTwA7JF/CZlAc46tU7TidmNGSN0FuPoQTanWnkzYvR6L zqfz8w/IYzLzdkrJEQRjw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddtuddguddvfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhgffffkgggtgfesthhqredttderjeenucfhrhhomhepkfgr nhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdrthhvqeenucggtffrrghtthgvrh hnpeetudeliedtjefgieeuudeiueeludfgieevfeevudethedvheejgfdthfektefhieen ucffohhmrghinhepghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 27 Apr 2024 14:21:18 -0400 (EDT) From: Ian Eure To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Subject: Re: bug#67512: [PATCH v7 0/3] Add LibreWolf In-Reply-To: <87r0eqww7t.fsf@meson> (Ian Eure's message of "Sat, 27 Apr 2024 10:19:46 -0700") References: <87jzl27ml2.fsf@trop.in> <87il03gk24.fsf@lassieur.org> <87r0eqww7t.fsf@meson> User-Agent: mu4e 1.12.2; emacs 29.3 Date: Sat, 27 Apr 2024 11:21:16 -0700 Message-ID: <87r0eqekf7.fsf@retrospec.tv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, guix-devel@gnu.org, guix-security@gnu.org, Mark H Weaver , andrew@trop.in X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Ian Eure writes: > Cl=C3=A9ment Lassieur writes: > >> On Fri, Apr 12 2024, Andrew Tropin via Guix-patches via wrote: >> >>> On 2024-04-06 08:04, Ian Eure wrote: >>> >>>> Moves nss update to nss-3.98 / nss-certs-3.98 to avoid=20 >>>> rebuilding >>>> thousands of packages. >>>> >>>> Rebases. >>>> >>>> Ian Eure (3): >>>> gnu: Add nss-3.98. >>>> gnu: Add nss-certs-3.98. >>>> gnu: Add librewolf. >>>> >>>> gnu/packages/certs.scm | 16 + >>>> gnu/packages/librewolf.scm | 621 >>>> +++++++++++++++++++++++++++++++++++++ >>>> gnu/packages/nss.scm | 45 +++ >>>> 3 files changed, 682 insertions(+) >>>> create mode 100644 gnu/packages/librewolf.scm >>>> >>>> >>>> base-commit: ade6845da6cec99f3bca46faac9b2bad6877817e >>> >>> Hi Ian, >>> >>> tested those patches, didn't notice any issues. >>> >>> Added pipewire to LD_LIBRARY_PATH to make screensharing on=20 >>> wayland >>> to >>> work. >>> >>> Added librewolf.scm to gnu/local.mk. >>> >>> Pushed as >>> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D3dc26b4eae >>> >>> Thank you very much for you work! >> >> Thank you Andrew for reviewing. >> >> Now that this is pushed, is there anyone maintaining this >> "librewolf" >> package? This is serious work, with security updates quite=20 >> often. >> > > Hi Clement, > > I=E2=80=99m planning to continue sending patches for updates and the > like. Getting a working updater is close to the top of my list. > > >> Right now the package is subject to >> >> CVE-2024-3852 (high) >> CVE-2024-3853 (high) >> CVE-2024-3854 (high) >> CVE-2024-3855 (high) >> CVE-2024-3856 (high) >> CVE-2024-3857 (high) >> CVE-2024-3858 (high) >> CVE-2024-3859 (moderate) >> CVE-2024-3860 (moderate) >> CVE-2024-3861 (moderate) >> CVE-2024-3862 (moderate) >> CVE-2024-3302 (low) >> CVE-2024-3864 (high) >> CVE-2024-3865 (high) >> > > The version in Guix is the latest available. I=E2=80=99ll send in a=20 > patch > when the next release happens; I=E2=80=99m waiting on upstream for that. > Okay, I see that I=E2=80=99m incorrect about this -- LibreWolf is moving=20 onto Codeberg, but I was looking at their GitLab project, which=20 doesn=E2=80=99t have the recent releases. I=E2=80=99ll get this updated. Thanks, =E2=80=94 Ian From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 28 05:00:25 2024 Received: (at 67512) by debbugs.gnu.org; 28 Apr 2024 09:00:25 +0000 Received: from localhost ([127.0.0.1]:50103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s10OW-0003Ue-Pp for submit@debbugs.gnu.org; Sun, 28 Apr 2024 05:00:25 -0400 Received: from fhigh6-smtp.messagingengine.com ([103.168.172.157]:56447) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s10OV-0003UW-AD for 67512@debbugs.gnu.org; Sun, 28 Apr 2024 05:00:23 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.nyi.internal (Postfix) with ESMTP id BF78B11400BC; Sun, 28 Apr 2024 04:59:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 28 Apr 2024 04:59:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1714294798; x=1714381198; bh=uLawuBrWwko8G31ORksQB2yndKK6r0WCz6LavEoT024=; b= eT0BqTcgy0+Rsaz5HTVL8REs8HooMBZ2S5E8MhKum62GkdE6SKkErFlst/+SJeh7 iRQgddpTNWo2K2j649UkgsJtJMcG0th53Fe5QiG3kHcQiPXyKUb5Zq7KFKR4+EjH lFJxa770P53A5K2pA9L0JkH5DXwJ585I6Tt38c5x2oD3nUuKOepTBHc4jAuuOKwF /OLpLbR5lXvNaVPMj4XEflTLh1atimyp8IWQmdoj8fGIUxd7jXx/f6QSS18zj0/K jHzbzk5DqaonHmSyMlm0HOj6eTnOW1z26rS+8RgFfSSFXQU39UXC/Wx2JFRmlY/S KnANRbZAqCNzlSUFAyoocw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1714294798; x= 1714381198; bh=uLawuBrWwko8G31ORksQB2yndKK6r0WCz6LavEoT024=; b=e Ws/FQtmhNBgEQiNQ5QNHBPMF2XlgWJPpzqbNKH0tPHjxo5Nfx/6HHPYFVLncklPD tcexuPKQYyqg77+XtgPV+pzZzbnb5ekpVEA1sICrWsv/KYsi/FlVjkjQcFhHjZxT qTJ1rI44z3nw3NdrGvOB2butAPPcRFcoIzS9wRzsFtJKfMPUFOKHdus57zkIkZUS wipuS+uavb49K1e+Okb7UOuRxgK50w0b3YgR2Ds5o5tBqzMfqkNnwrL6lNj9+6cX ZNQawwjuxBpHHJw0FSSB6xweEVKJbbUmGcX1ueo19w89UwP1miGCIKxnpmwUGVZz R93WNHhzzxC6IznmJwtkQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddtgedgfeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufgjfhffkfgfgggtgfesth hqredttderjeenucfhrhhomhepvehlrohmvghnthcunfgrshhsihgvuhhruceotghlvghm vghntheslhgrshhsihgvuhhrrdhorhhgqeenucggtffrrghtthgvrhhnpeegkeehfefftd efffeuveekgfffhfdtudfgudegueegvefgudetffdugfefhfejudenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegtlhgvmhgvnhhtsehlrghssh hivghurhdrohhrgh X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 28 Apr 2024 04:59:55 -0400 (EDT) From: =?utf-8?Q?Cl=C3=A9ment_Lassieur?= To: Ian Eure Subject: Re: [bug#67512] [PATCH v7 0/3] Add LibreWolf In-Reply-To: <87r0eqekf7.fsf@retrospec.tv> (Ian Eure's message of "Sat, 27 Apr 2024 11:21:16 -0700") References: <87jzl27ml2.fsf@trop.in> <87il03gk24.fsf@lassieur.org> <87r0eqww7t.fsf@meson> <87r0eqekf7.fsf@retrospec.tv> Date: Sun, 28 Apr 2024 10:59:53 +0200 Message-ID: <87sez5n9py.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67512 Cc: 67512@debbugs.gnu.org, guix-devel@gnu.org, andrew@trop.in, Mark H Weaver , guix-security@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sat, Apr 27 2024, Ian Eure wrote: >> The version in Guix is the latest available. I=E2=80=99ll send in a pat= ch >> when the next release happens; I=E2=80=99m waiting on upstream for that. >> > > Okay, I see that I=E2=80=99m incorrect about this -- LibreWolf is moving = onto > Codeberg, but I was looking at their GitLab project, which doesn=E2=80=99= t have the > recent releases. I=E2=80=99ll get this updated. Great, thank you Ian! From unknown Mon Aug 18 04:42:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 26 May 2024 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator