From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 28 05:27:45 2023 Received: (at submit) by debbugs.gnu.org; 28 Nov 2023 10:27:45 +0000 Received: from localhost ([127.0.0.1]:45469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7vJg-00019N-KU for submit@debbugs.gnu.org; Tue, 28 Nov 2023 05:27:45 -0500 Received: from lists.gnu.org ([2001:470:142::17]:37256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7vJb-000193-J9 for submit@debbugs.gnu.org; Tue, 28 Nov 2023 05:27:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r7vJP-00037V-EW for guix-patches@gnu.org; Tue, 28 Nov 2023 05:27:27 -0500 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r7vJN-0002MV-N7 for guix-patches@gnu.org; Tue, 28 Nov 2023 05:27:27 -0500 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a00a9c6f1e9so752115366b.3 for ; Tue, 28 Nov 2023 02:27:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701167244; x=1701772044; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=L6S8x7w6ibOrBDxNQ7NMBxG+c/tpisxBk++63pwjBR8=; b=FLmOR75YlosXjrZ3t/dCmAFIkd/bSu4ibsPhKlVCm9uB9Ta5rJQjZr9O+JFF3Bdyhc IfJuqcF6E18BbzdudqzzKOKiWa6NPlTO8mcHzXL5kbIQD1rqQzdHSe0fAZ1B+2NND/dw EKKTvAP8G/bThSpT2AIz5z4gKOsEl8bhvl2MmxevNTqntCBqCJKtCo77gMk7/xFlBInX oeL7smt2JNnuRciK8Twn6jfmSH7HBkkcctyVss6jOyj52L6ahj99XcA8hkcGAIQMud78 9CtiBFwCE2Hf+WKTN/iF1BJFpYOIGbSLYLc09keVNdvjEBYzpDyVDYrhbhk2Pwsc+ONE CdDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701167244; x=1701772044; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L6S8x7w6ibOrBDxNQ7NMBxG+c/tpisxBk++63pwjBR8=; b=NNPKSU1S68vfyEWMC8liCPbkAZusBDGkmbknhzX8Rr9QkpWwST6XK4IgXhSDSQ3Pkt c/6TK05Be1YCje49HTGAHHBuQjgTiIx7VoaSv9cT6mnfeVdCgUnUHgpebNtf190vEZiu ew5rTE85ow5u3FjtXvn/TQkHFRD4XOfKruCKOSgl4VXmybVVmVkuFsKhD7xZMUXtd/qN HpHZ+Rvk3dmpKu6AcsrqijjIYVsSPN/1sAkRfTaaD/BrlpuqYWtCYCuxN+KDiiIx4LNO lrsBsSQl+GdcQBmwZZTgJo1WkvHyI+Zlo/IXMefoFkiDo8UJGE+FRyv+3hnTxK2+olbk T+lA== X-Gm-Message-State: AOJu0Yxr+w/dQ2jNHajenXYuIzkkwE35aRJECORv62JEv/mA0fopILAA rIuqWg2zOTw/jLP0wQWqZ4JUX0Gdo79dXw== X-Google-Smtp-Source: AGHT+IGJD85hSKA5A9nAXPsPAOd0stoElocPPO/cGFPhDaEvH/WLa6QgZT7FRq3rUJOke5Qwno9xxw== X-Received: by 2002:a17:906:3f92:b0:9e0:4910:166a with SMTP id b18-20020a1709063f9200b009e04910166amr8822915ejj.32.1701167244102; Tue, 28 Nov 2023 02:27:24 -0800 (PST) Received: from localhost ([176.12.138.93]) by smtp.gmail.com with ESMTPSA id si12-20020a170906cecc00b009fca9f39e98sm6653325ejb.26.2023.11.28.02.27.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 02:27:23 -0800 (PST) From: Efraim Flashner To: guix-patches@gnu.org Subject: [PATCH] build/go: Don't use set! Date: Tue, 28 Nov 2023 12:24:15 +0200 Message-ID: <92508cd851b013f54a799350082f49b157c7aebf.1701167049.git.efraim@flashner.co.il> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Debbugs-Cc: Katherine Cox-Buday Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::636; envelope-from=efraim.flashner@gmail.com; helo=mail-ej1-x636.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This causes build failures on powerpc-linux. * guix/build/go-build-system.scm (unpack): When the unpack-path is unset use the import-path but don't redefine the unpack-path. Change-Id: I2b5a36eb738abb14307941d388038139dbaf2bdf --- Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (efraim.flashner[at]gmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: submit Cc: Efraim Flashner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) This causes build failures on powerpc-linux. * guix/build/go-build-system.scm (unpack): When the unpack-path is unset use the import-path but don't redefine the unpack-path. Change-Id: I2b5a36eb738abb14307941d388038139dbaf2bdf --- I checked the rest of the build code in (guix build go-build-system) and I didn't see anywhere that didn't also check to make sure the unpack-path wasn't empty. I have yet to create a minimal reproducer for the set! issue on powerpc-linux but this is the only change preventing building go packages on powerpc-linux (the 32-bit ones, not powerpc64le-linux). guix/build/go-build-system.scm | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/guix/build/go-build-system.scm b/guix/build/go-build-system.scm index 7f25e05d0d..d32235bf5a 100644 --- a/guix/build/go-build-system.scm +++ b/guix/build/go-build-system.scm @@ -4,7 +4,7 @@ ;;; Copyright © 2019 Maxim Cournoyer ;;; Copyright © 2020 Jack Hill ;;; Copyright © 2020 Jakub Kądziołka -;;; Copyright © 2020, 2021 Efraim Flashner +;;; Copyright © 2020, 2021, 2023 Efraim Flashner ;;; Copyright © 2021 Sarah Morgensen ;;; ;;; This file is part of GNU Guix. @@ -227,9 +227,10 @@ (define* (unpack #:key source import-path unpack-path #:allow-other-keys) (when (string-null? import-path) (display "WARNING: The Go import path is unset.\n")) - (when (string-null? unpack-path) - (set! unpack-path import-path)) - (let ((dest (string-append (getenv "GOPATH") "/src/" unpack-path))) + (let ((dest (string-append (getenv "GOPATH") "/src/" + (if (string-null? unpack-path) + import-path + unpack-path)))) (mkdir-p dest) (if (file-is-directory? source) (copy-recursively source dest #:keep-mtime? #t) base-commit: 62376e3eb67644454bc655bed56be4be965bd13e -- Efraim Flashner רנשלפ םירפא GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 03 17:49:24 2023 Received: (at 67505) by debbugs.gnu.org; 3 Dec 2023 22:49:24 +0000 Received: from localhost ([127.0.0.1]:33013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9vHA-0002Am-G7 for submit@debbugs.gnu.org; Sun, 03 Dec 2023 17:49:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9vH8-0002AY-MT for 67505@debbugs.gnu.org; Sun, 03 Dec 2023 17:49:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9vGs-0004PY-Jy; Sun, 03 Dec 2023 17:49:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=R8qWmeXsmWzd+2oVCKXz15ZoqHINzeGUzh8qY4yU8i8=; b=Ian2fm9RVkdMTSSH0wun RkiV4TNWm8VpA8GZHy6aJaN3kP4/plcxorTl5FsGrOOZ1RWEj2GkyOVJRqDVpNhi8m4dLtYn6E2V6 v07L3xuwMwonIm6iPrWTF26CEz+mQl29UOeK4nSbYUEwGWU69dSDesY6EPxy/mJDnH+wAWcPKSJhn RdB8V6IXbbr/NhFxVSgH0b8vPydUhR90QLqe4GaUcPzRJPoaCP4TjUtthRf+OihdZOxURnHEnGE4s eFxzbIJO5dfRYH5LpFxJJgE2No9zZc0SlIDwYN2sC7pOnwSpaw9t2XtZcPjZVw8uVNfsFIqbLm1dD 7niO6sBOMXPsSA==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Efraim Flashner Subject: Re: [bug#67505] [PATCH] build/go: Don't use set! In-Reply-To: <92508cd851b013f54a799350082f49b157c7aebf.1701167049.git.efraim@flashner.co.il> (Efraim Flashner's message of "Tue, 28 Nov 2023 12:24:15 +0200") References: <92508cd851b013f54a799350082f49b157c7aebf.1701167049.git.efraim@flashner.co.il> Date: Sun, 03 Dec 2023 23:49:03 +0100 Message-ID: <87jzpuewbk.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67505 Cc: 67505@debbugs.gnu.org, Katherine Cox-Buday X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Efraim Flashner skribis: > This causes build failures on powerpc-linux. > > * guix/build/go-build-system.scm (unpack): When the unpack-path is unset > use the import-path but don't redefine the unpack-path. > > Change-Id: I2b5a36eb738abb14307941d388038139dbaf2bdf [...] > - (when (string-null? unpack-path) > - (set! unpack-path import-path)) > - (let ((dest (string-append (getenv "GOPATH") "/src/" unpack-path))) > + (let ((dest (string-append (getenv "GOPATH") "/src/" > + (if (string-null? unpack-path) > + import-path > + unpack-path)))) Could you adjust indentation of the =E2=80=98if=E2=80=99 arms? Otherwise LGTM, thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 04 04:54:21 2023 Received: (at 67505-done) by debbugs.gnu.org; 4 Dec 2023 09:54:21 +0000 Received: from localhost ([127.0.0.1]:33498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rA5ef-00062D-Fa for submit@debbugs.gnu.org; Mon, 04 Dec 2023 04:54:21 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:52657) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rA5eb-00061w-HI for 67505-done@debbugs.gnu.org; Mon, 04 Dec 2023 04:54:20 -0500 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-40c09f4814eso12580865e9.1 for <67505-done@debbugs.gnu.org>; Mon, 04 Dec 2023 01:54:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701683641; x=1702288441; darn=debbugs.gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=WANtWGzJjwMB/sSBQjS0qHeL4lzbykYu1i/iG9j7xy0=; b=lein5DRD8ah8bXaNk6//i2GuJ0zzLzb7XBNbnoqvnGXAcylhja45MfY3fjHvD/Vuo0 9Wx8iiimLzutH+5ZQ2+Q8GQ/2Ni+7MU0TyXy1DmviNGvHMczk3Jb38cqAE0r0kAQbyzC 0YJhEhI6i4CYPR5j1+pMTvgProw3THyL/3/Nirf3VB6GZZZhENRyBQW1dQVGdPuxkDts LeSlFX/kRApIbYUgBfJmELlFyFU8VrZoznLVKcUez6HzpB/N+mgCiee8KYXPwFWfZh2b DuV3m62cxskxjNd2BxSyNdjcIsOtekiIBPgCk7bq0pY8xeK1h07L+21PCZ+0hQ1NeOGC 4zag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701683641; x=1702288441; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WANtWGzJjwMB/sSBQjS0qHeL4lzbykYu1i/iG9j7xy0=; b=NmtuYuiuf3o3tstnePwiHMkoTFU5lXPGr2K2K0XnofvBFZzobeMzD2K3yKrbsQbG/W UOnYOovKjc8ZgGK+XNgM+1oYr5p/WqDdh34n5gF8yatCas13c0Rd7NlbW7bNLX+gpZ36 9tLESS0ENveFNJXnVtD5L+H3lCYj5W9r1I8+tiW0+ipPqVT7xIw9/1fEK3FeHvOru3Vp CfrAK+K1/mXqsne9jm8/AUnlY5ocUoNTq9pEc0iRIQ0bjrvJuEyvnund0oaGAMlgUFcm w3Z4IpQSacdE3AvuCFH+tclEoFmrUao7Wqaf5nVDMVr46NfSL32yHGx7jba/tfIlh/i7 QQwg== X-Gm-Message-State: AOJu0Yz44OVRHPkbIh0jBqf8VhzUagd+VAFLMGUexwYwzeXiu7igzgJ4 1X0g5P3gdA6B3sYyXyeKR/o= X-Google-Smtp-Source: AGHT+IHDFX0H5Hpn3sFFcP4VVqrRa6s9+avauW7s7IooGxuE+5HyQa5FbtmWubJ+MlGFGyLz7ppGUw== X-Received: by 2002:a05:600c:3585:b0:408:3f61:cb4f with SMTP id p5-20020a05600c358500b004083f61cb4fmr2436509wmq.23.1701683640872; Mon, 04 Dec 2023 01:54:00 -0800 (PST) Received: from localhost ([188.120.129.233]) by smtp.gmail.com with ESMTPSA id p36-20020a05600c1da400b0040b478da760sm14472637wms.48.2023.12.04.01.53.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 01:53:59 -0800 (PST) Date: Mon, 4 Dec 2023 11:53:58 +0200 From: Efraim Flashner To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#67505] [PATCH] build/go: Don't use set! Message-ID: Mail-Followup-To: Efraim Flashner , Ludovic =?utf-8?Q?Court=C3=A8s?= , 67505-done@debbugs.gnu.org, Katherine Cox-Buday References: <92508cd851b013f54a799350082f49b157c7aebf.1701167049.git.efraim@flashner.co.il> <87jzpuewbk.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rheOYXulewIPgN3G" Content-Disposition: inline In-Reply-To: <87jzpuewbk.fsf@gnu.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 67505-done Cc: 67505-done@debbugs.gnu.org, Katherine Cox-Buday X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --rheOYXulewIPgN3G Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 03, 2023 at 11:49:03PM +0100, Ludovic Court=C3=A8s wrote: > Efraim Flashner skribis: >=20 > > This causes build failures on powerpc-linux. > > > > * guix/build/go-build-system.scm (unpack): When the unpack-path is unset > > use the import-path but don't redefine the unpack-path. > > > > Change-Id: I2b5a36eb738abb14307941d388038139dbaf2bdf >=20 > [...] >=20 > > - (when (string-null? unpack-path) > > - (set! unpack-path import-path)) > > - (let ((dest (string-append (getenv "GOPATH") "/src/" unpack-path))) > > + (let ((dest (string-append (getenv "GOPATH") "/src/" > > + (if (string-null? unpack-path) > > + import-path > > + unpack-path)))) >=20 > Could you adjust indentation of the =E2=80=98if=E2=80=99 arms? >=20 > Otherwise LGTM, thanks! Done. Patch pushed! --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --rheOYXulewIPgN3G Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmVtobYACgkQQarn3Mo9 g1E25xAAlEKqSolqlZkPM3XELAwj4J66kCCAdaT7O7gUs2Tv+AOfRQws9eHCHu1v POOFNF+MY4I/lYMkhFMvbMp/71MxwJiHU8nFdpUEK7pRWzx+Ia4f+kTkTf2deyDz gyFTIZ0F9RRKLqYv4TsahW4WHgd/iDWPQzAt2ndUHnbYVufgMP1Jn8mwQcGzQhT0 fvqpSjohDsPvpZT5eHeUMQ4ajA6CySLm6OSWecWt7hYu4d8/A/Y/yY0I905zxfzi c8f8HhEdFJMjqxlVkOR7ZBttl1zj9Lj/Y8fIDnjMrgcT1adhAmhqYCVRri8nW2cP 5+0n8apBJs6S9GX7z5wDY4QJcGPulEuY57KELesDSYX614sAR/I6QoY+pW0/8QIU bbmjzwFLpNeog4+OAkYx6+KGDUq9jrh/FA+SeVFU69PA7SWWXCeO0cuJOkUan0Td 3stqHN4hdeqtBed+2zw6eSbjG0V4gf/brY7BXgwUoCzAYLy+NrQi3KGJvpLOHKUS bjf3n2xayhwIKLYtlrfj0AfURUMuP13ngycWbOT46zq5E4bLxy+X5IatQvGhWCIJ LWg8ZSlD29keBqAqn6gpq01SVLUvmki14l/kXrYOsJPR/ca44bNf9GW2uWz864cJ J50z0AL1V3g3V3gCzG/ju4FtDL6wjUj1FnsFyERWiia294hGJp0= =PuSU -----END PGP SIGNATURE----- --rheOYXulewIPgN3G-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 06 07:27:43 2023 Received: (at 67505) by debbugs.gnu.org; 6 Dec 2023 12:27:43 +0000 Received: from localhost ([127.0.0.1]:39019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAr0A-00073W-QY for submit@debbugs.gnu.org; Wed, 06 Dec 2023 07:27:43 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:58628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAr08-00073J-Id for 67505@debbugs.gnu.org; Wed, 06 Dec 2023 07:27:41 -0500 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-40c0f3a7717so28328145e9.1 for <67505@debbugs.gnu.org>; Wed, 06 Dec 2023 04:27:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701865643; x=1702470443; darn=debbugs.gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to; bh=tmt0jQ98c89F8LAuMUZJFmC3nCBudQNV0b94uySDIS0=; b=fvIImndK3B3kgtV2TnKpV7iRzsRQESq8V2IG2X6VoE7mo4W/quBFXXWzpIjDvtgMkI 6O1WvlELOUa+yheGIamKf7GyZpS2JXPE6dTb9Rs4kASbOE5Y4bkHfTDc3oRvP7EYm7mR r1ZP4z96Q0uwWYH41YjkSN9M3jyoKoKzMv8R1fmon4PW+XxXRD+UgZac4o70/QLVurTI bISVzLbj9aKpLUrTggqjyekVyIKzUdwp4GJn+pTFW1UQAjFydMb40k6qCpJruZu0fbMD xP8GJgiI9odDT8K8xMsvKN8cq/PvMfJitnOYMJt70TwKaijlZ7fGgx76sHtwKzT9KkAY w3yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701865643; x=1702470443; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tmt0jQ98c89F8LAuMUZJFmC3nCBudQNV0b94uySDIS0=; b=iz3GZGHWQ/GlXMYZsO9frAFqM2LpIJXugUW9kosxJHqsqDsZaueHL1lGTn9D8XHk9K +vaa9F7JSSwpkaXFNXtsLJLtQZCFNle+fC8MsB5sSnzgas2h5GaAUiP8asJEQAiJramL FcRR5F/I1sYs+2dEkY6QhP3sdIIEjrw6INRIfUDV9HCch4a/0LBbT0pa5uda9WKprBzx rzdNB45pjtv8677iJ1xP9pncTuAxcvA1xg8kBKNTrh5cTXDCu9YKT9CxIQY+/s8TmNvV BHVvUSerayHOQwzIH6S+h2dKwghM7kxbZQYjrSl37cPanpBagqPE3Om6Jj6wyBPA9u3n zSTw== X-Gm-Message-State: AOJu0Yw3C8XuP12y61+sYjr87H7MQwZZjfX0J4pvTratW5WiRlbpnpyr zkFR7Y4QafuY9Pt6yrNELGc= X-Google-Smtp-Source: AGHT+IENzx6FCQhbIj6niqkDWO6G1coXGa4Mlhv184DowJo1v5xWhD4XetKF4esPqISdpbERRSRQ/A== X-Received: by 2002:a05:600c:4a83:b0:40c:2061:dee7 with SMTP id b3-20020a05600c4a8300b0040c2061dee7mr223474wmp.130.1701865642753; Wed, 06 Dec 2023 04:27:22 -0800 (PST) Received: from localhost ([188.120.129.233]) by smtp.gmail.com with ESMTPSA id hg10-20020a05600c538a00b0040b398f0585sm22058031wmb.9.2023.12.06.04.27.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 04:27:22 -0800 (PST) Date: Wed, 6 Dec 2023 14:27:20 +0200 From: Efraim Flashner To: Ludovic =?utf-8?Q?Court=C3=A8s?= , 67505@debbugs.gnu.org, Katherine Cox-Buday Subject: Re: bug#67505: [PATCH] build/go: Don't use set! Message-ID: Mail-Followup-To: Efraim Flashner , Ludovic =?utf-8?Q?Court=C3=A8s?= , 67505@debbugs.gnu.org, Katherine Cox-Buday References: <92508cd851b013f54a799350082f49b157c7aebf.1701167049.git.efraim@flashner.co.il> <87jzpuewbk.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RkHi6oTk7q4pYf68" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 67505 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --RkHi6oTk7q4pYf68 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 04, 2023 at 11:53:58AM +0200, Efraim Flashner wrote: > On Sun, Dec 03, 2023 at 11:49:03PM +0100, Ludovic Court=C3=A8s wrote: > > Efraim Flashner skribis: > >=20 > > > This causes build failures on powerpc-linux. > > > > > > * guix/build/go-build-system.scm (unpack): When the unpack-path is un= set > > > use the import-path but don't redefine the unpack-path. > > > > > > Change-Id: I2b5a36eb738abb14307941d388038139dbaf2bdf > >=20 > > [...] > >=20 > > > - (when (string-null? unpack-path) > > > - (set! unpack-path import-path)) > > > - (let ((dest (string-append (getenv "GOPATH") "/src/" unpack-path))) > > > + (let ((dest (string-append (getenv "GOPATH") "/src/" > > > + (if (string-null? unpack-path) > > > + import-path > > > + unpack-path)))) > >=20 > > Could you adjust indentation of the =E2=80=98if=E2=80=99 arms? > >=20 > > Otherwise LGTM, thanks! >=20 > Done. Patch pushed! Patch re-opened. I reverted it since it caused ~4800 package builds on Berlin. I'll probably carry it locally for now (I'm almost certainly the only one affected) and we can apply it another time something touches go. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --RkHi6oTk7q4pYf68 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmVwaKgACgkQQarn3Mo9 g1FL0RAAnZOeJIhtF3EHus3PNv7fwqnY5ItE0L0XBGzf4cpnMegnjQ4n3K6hje5Y j5PfnTnUNHC7zKbqXrum/lpQEAI7WfG4vow2i2ejEh95vrxLBujbC0ccqd+8rZBp TZtd3C+Vltyz+fPoBe0xz9DP1JRtsCQtJIocHJssGc9n1JQOZerMMyJG9R+kxXkl gadsF3BHb5+wjB91dMRKGGhto0iJ0xISh9/U/62qaY74tvERcTRB3CHgeS/2HyrH i0TYmaieFw3GX3BUH7dCa6TYE1jH7t6lxcYX/4Y692XoWr/+6/rHLvufKSbWTrw2 0puiM1GKYwT4E5fsfY8VUkE0YrolploE3kksw1VOJ+8VsNOdSOmmutdkAQxKfHWo /gluuWVv33L3XPR4XWrasLg5kRPah7+ILm0xNs1VrXC2Xacat0nYiWYvfsuMbixi AwcF0hOMtIv4H/iCO8vHgH/NF7mKhzjIn3UQqEkpo2W5S95H2Qg5orffyM8BLlJ/ jzcptpAhEXLckvOMlJNZI4b95+5uBVAsSIFPK69lN4XYbeLBi+OJAI2ALwBEpWpG XQM24yBbp5IN3EQsuAN/P8b4pcM8OWeks/QOQYVmG4ALB7qgYomEixr/Jhq99uoH 63GmA0YLds20PeHAG3CwT4zghlHYw/Qde4DdHgPFCojBG0yoDzM= =U2NR -----END PGP SIGNATURE----- --RkHi6oTk7q4pYf68-- From unknown Sat Aug 09 09:37:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 04 Jan 2024 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator